Re: [PHP-DEV] Harcoded mysql.sock path in mysqlnd extension

2012-01-16 Thread Remi Collet
Le 15/01/2012 00:12, Johannes Schlüter a écrit :

 In what case do you notice that? - ext/mysql, mysqli and PDO_mysql
 should override that. Only case I can see would be some mysqlnd plugin
 overriding the host.

You're right, this patch is an old one, before bug #60155 was fixed (in
r318696), and it works without it.

Sorry for the noise.

Remi.


P.S. well, don't know if having such a hardcoded path is a good idea...

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Harcoded mysql.sock path in mysqlnd extension

2012-01-16 Thread Ulf Wendel

Am 16.01.2012 11:19, schrieb Remi Collet:

P.S. well, don't know if having such a hardcoded path is a good idea...


mysqlnd is a libmysql drop-in replacement. Guess what libmysql does... - 
do strings libmysqlclient.so | grep mysql.sock on a standard source build.


Ulf

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Harcoded mysql.sock path in mysqlnd extension

2012-01-16 Thread Remi Collet
Le 16/01/2012 18:39, Ulf Wendel a écrit :
 Am 16.01.2012 11:19, schrieb Remi Collet:
 P.S. well, don't know if having such a hardcoded path is a good idea...
 
 mysqlnd is a libmysql drop-in replacement. Guess what libmysql does... -
 do strings libmysqlclient.so | grep mysql.sock on a standard source
 build.

$ strings /usr/lib64/mysql/libmysqlclient.so.18 | grep mysql.sock
/var/lib/mysql/mysql.sock

Which is taken from configure option
--with-unix-socket-path=/var/lib/mysql/mysql.sock

Default (cmake config) is /tmp/mysql.sock, but even upstream package
don't use it and set it to %{mysqldatadir}/mysql.sock

I'm ok with the hardcoded default value of /tmp/mysql.sock.
I just don't understand why mysqlnd doesn't honour config option (even
if this value will probably be never used)

Regards,
Remi.

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



Re: [PHP-DEV] Harcoded mysql.sock path in mysqlnd extension

2012-01-14 Thread Johannes Schlüter
On Fri, 2012-01-13 at 18:28 +0100, Remi Collet wrote:
 I fill a bug : https://bugs.php.net/bug.php?id=60748
 (trivial patch proposed, shouldn't break anything)
 
 Just a notice, there is no mysqlnd component in bug tracker...
 (or I was unable to find it...)

In what case do you notice that? - ext/mysql, mysqli and PDO_mysql
should override that. Only case I can see would be some mysqlnd plugin
overriding the host.

johannes

 Remi.
 
 



-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



[PHP-DEV] Harcoded mysql.sock path in mysqlnd extension

2012-01-13 Thread Remi Collet
I fill a bug : https://bugs.php.net/bug.php?id=60748
(trivial patch proposed, shouldn't break anything)

Just a notice, there is no mysqlnd component in bug tracker...
(or I was unable to find it...)

Remi.


-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php