Re: [PHP-DEV] Requesting RFC karma

[Derick Rethans]

On 20 February 2024 10:05:25 CET, Marc Bennewitz  wrote:
>
>On 20.02.24 09:58, Derick Rethans wrote:
>> On 20 February 2024 08:41:19 GMT, Marc Bennewitz  wrote:
>>> Hi Hans,
>>> 
>>> On 16.02.24 13:05, Hans Henrik Bergan wrote:
 My name is "Hans Henrik Bergan", usually go by the nickname
 "divinity76", I've contributed to OSS (including PHP) for years, and
 am currently involved in 3 things that might require an RFC, and
 requesting RFC karma for wiki account "divinity76".
 
 3/3: int|float for DateTime::setTimestamp, setTimestamp(0.123456) =>
 1970-01-01 00:00:00.123456 :https://github.com/php/php-src/pull/13383
>>> Actually I also want to work on this if I find time ... but as this is a BC 
>>> break I think it makes sense to revisit DateTime (and friends) to bundle BC 
>>> breaks to a single PHP version - probably PHP 9 and more sure there is a 
>>> way for users to make it work in PHP (7+)8+9.
>>> 
>>> Personal and incomplete list I think needs improvements:
>>> 
>>> * allow float for `setTimestamp`
>>> * option to return timestamp as float to simplify passing it to JS
>>> * Missing getter/setter for most of the date/time parts like 
>>> `get/setSecond`, `get/setHour` etc.
>>>    * For now I only added `get/setMicroseconds` together with 
>>> `createFromTimestamp` because 
>>> `DateTime::createFromTimestamp(123456789)->setMicroseconds(123987)`
>>>    * After thinking about naming - I think this should be renamed to 
>>> singular 
>>> * Add missing methods to DateTimeInterface
>>> * Allow userland implements DateTimeInterface
>>>    * Define how `createFromInterface` behaves on userland implementations
>>> * fixing ISO 8601 format
>>> * fixing some return type definitions from self to static
>>> * strict mode
>>>    * `DateTime::createFromFormat('Y-m-d', '2023-02-29')`
>>>    * `DateTime::createFromFormat('Y-m-d H:i', '2024-03-31 02:30', new 
>>> DateTimeZone('Europe/Berlin'))`
>>> * Missing current microseconds on `createFromFormat` but other non defined 
>>> parts needs to be explicitly reset using `|!`
>>> * leap seconds support on UTC TZ
>>>    * As of leap seconds ... wouldn't it be better to default to +00:00 
>>> instead of UTC ?
>>> * Support nanoseconds
>>> 
>>> 
>>> I'm for sure not able to work on all these points and that's why I only 
>>> started very small close to no BC improvements without RFC.
>>> 
>> IMO, doing tweaks to this base functionality isn't the way forwards. I've 
>> been having on and off conversations with Florian over the last couple of 
>> months to see if we can design a better higher level API instead of patching 
>> the nits.
>
>Do you mean adding an additional API in C or userland? Is there a way to 
>participate on the discussion?


A bit of both, I suppose. But mainly for a user facing API. I've nothing 
concrete yet, and will soon start collecting thoughts. I'll make sure to email 
this list.

cheers
Derick

Re: [PHP-DEV] Requesting RFC karma

[Marc Bennewitz]

On 20.02.24 09:58, Derick Rethans wrote:

On 20 February 2024 08:41:19 GMT, Marc Bennewitz  wrote:

Hi Hans,

On 16.02.24 13:05, Hans Henrik Bergan wrote:

My name is "Hans Henrik Bergan", usually go by the nickname
"divinity76", I've contributed to OSS (including PHP) for years, and
am currently involved in 3 things that might require an RFC, and
requesting RFC karma for wiki account "divinity76".

3/3: int|float for DateTime::setTimestamp, setTimestamp(0.123456) =>
1970-01-01 00:00:00.123456 :https://github.com/php/php-src/pull/13383

Actually I also want to work on this if I find time ... but as this is a BC 
break I think it makes sense to revisit DateTime (and friends) to bundle BC 
breaks to a single PHP version - probably PHP 9 and more sure there is a way 
for users to make it work in PHP (7+)8+9.

Personal and incomplete list I think needs improvements:

* allow float for `setTimestamp`
* option to return timestamp as float to simplify passing it to JS
* Missing getter/setter for most of the date/time parts like `get/setSecond`, 
`get/setHour` etc.
   * For now I only added `get/setMicroseconds` together with 
`createFromTimestamp` because 
`DateTime::createFromTimestamp(123456789)->setMicroseconds(123987)`
   * After thinking about naming - I think this should be renamed to singular 
* Add missing methods to DateTimeInterface
* Allow userland implements DateTimeInterface
   * Define how `createFromInterface` behaves on userland implementations
* fixing ISO 8601 format
* fixing some return type definitions from self to static
* strict mode
   * `DateTime::createFromFormat('Y-m-d', '2023-02-29')`
   * `DateTime::createFromFormat('Y-m-d H:i', '2024-03-31 02:30', new 
DateTimeZone('Europe/Berlin'))`
* Missing current microseconds on `createFromFormat` but other non defined 
parts needs to be explicitly reset using `|!`
* leap seconds support on UTC TZ
   * As of leap seconds ... wouldn't it be better to default to +00:00 instead 
of UTC ?
* Support nanoseconds


I'm for sure not able to work on all these points and that's why I only started 
very small close to no BC improvements without RFC.


Marc


IMO, doing tweaks to this base functionality isn't the way forwards. I've been 
having on and off conversations with Florian over the last couple of months to 
see if we can design a better higher level API instead of patching the nits.


Do you mean adding an additional API in C or userland? Is there a way to 
participate on the discussion?



cheers
Derick


Best,
Marc


OpenPGP_0x3936ABF753BC88CE.asc
Description: OpenPGP public key


OpenPGP_signature.asc
Description: OpenPGP digital signature

Re: [PHP-DEV] Requesting RFC karma

[Derick Rethans]

On 20 February 2024 08:41:19 GMT, Marc Bennewitz  wrote:
>Hi Hans,
>
>On 16.02.24 13:05, Hans Henrik Bergan wrote:
>> My name is "Hans Henrik Bergan", usually go by the nickname
>> "divinity76", I've contributed to OSS (including PHP) for years, and
>> am currently involved in 3 things that might require an RFC, and
>> requesting RFC karma for wiki account "divinity76".
>> 
>> 3/3: int|float for DateTime::setTimestamp, setTimestamp(0.123456) =>
>> 1970-01-01 00:00:00.123456 : https://github.com/php/php-src/pull/13383
>
>Actually I also want to work on this if I find time ... but as this is a BC 
>break I think it makes sense to revisit DateTime (and friends) to bundle BC 
>breaks to a single PHP version - probably PHP 9 and more sure there is a way 
>for users to make it work in PHP (7+)8+9.
>
>Personal and incomplete list I think needs improvements:
>
>* allow float for `setTimestamp`
>* option to return timestamp as float to simplify passing it to JS
>* Missing getter/setter for most of the date/time parts like `get/setSecond`, 
>`get/setHour` etc.
>  * For now I only added `get/setMicroseconds` together with 
>`createFromTimestamp` because 
>`DateTime::createFromTimestamp(123456789)->setMicroseconds(123987)`
>  * After thinking about naming - I think this should be renamed to singular 
>* Add missing methods to DateTimeInterface
>* Allow userland implements DateTimeInterface
>  * Define how `createFromInterface` behaves on userland implementations
>* fixing ISO 8601 format
>* fixing some return type definitions from self to static
>* strict mode
>  * `DateTime::createFromFormat('Y-m-d', '2023-02-29')`
>  * `DateTime::createFromFormat('Y-m-d H:i', '2024-03-31 02:30', new 
>DateTimeZone('Europe/Berlin'))`
>* Missing current microseconds on `createFromFormat` but other non defined 
>parts needs to be explicitly reset using `|!`
>* leap seconds support on UTC TZ
>  * As of leap seconds ... wouldn't it be better to default to +00:00 instead 
>of UTC ?
>* Support nanoseconds
>
>
>I'm for sure not able to work on all these points and that's why I only 
>started very small close to no BC improvements without RFC.
>
>
>Marc
>

IMO, doing tweaks to this base functionality isn't the way forwards. I've been 
having on and off conversations with Florian over the last couple of months to 
see if we can design a better higher level API instead of patching the nits.

cheers
Derick

Re: [PHP-DEV] Requesting RFC karma

[Marc Bennewitz]

Hi Hans,

On 16.02.24 13:05, Hans Henrik Bergan wrote:

My name is "Hans Henrik Bergan", usually go by the nickname
"divinity76", I've contributed to OSS (including PHP) for years, and
am currently involved in 3 things that might require an RFC, and
requesting RFC karma for wiki account "divinity76".

3/3: int|float for DateTime::setTimestamp, setTimestamp(0.123456) =>
1970-01-01 00:00:00.123456 : https://github.com/php/php-src/pull/13383


Actually I also want to work on this if I find time ... but as this is a 
BC break I think it makes sense to revisit DateTime (and friends) to 
bundle BC breaks to a single PHP version - probably PHP 9 and more sure 
there is a way for users to make it work in PHP (7+)8+9.


Personal and incomplete list I think needs improvements:

* allow float for `setTimestamp`
* option to return timestamp as float to simplify passing it to JS
* Missing getter/setter for most of the date/time parts like 
`get/setSecond`, `get/setHour` etc.
  * For now I only added `get/setMicroseconds` together with 
`createFromTimestamp` because 
`DateTime::createFromTimestamp(123456789)->setMicroseconds(123987)`
  * After thinking about naming - I think this should be renamed to 
singular 

* Add missing methods to DateTimeInterface
* Allow userland implements DateTimeInterface
  * Define how `createFromInterface` behaves on userland implementations
* fixing ISO 8601 format
* fixing some return type definitions from self to static
* strict mode
  * `DateTime::createFromFormat('Y-m-d', '2023-02-29')`
  * `DateTime::createFromFormat('Y-m-d H:i', '2024-03-31 02:30', new 
DateTimeZone('Europe/Berlin'))`
* Missing current microseconds on `createFromFormat` but other non 
defined parts needs to be explicitly reset using `|!`

* leap seconds support on UTC TZ
  * As of leap seconds ... wouldn't it be better to default to +00:00 
instead of UTC ?

* Support nanoseconds


I'm for sure not able to work on all these points and that's why I only 
started very small close to no BC improvements without RFC.



Marc



OpenPGP_0x3936ABF753BC88CE.asc
Description: OpenPGP public key


OpenPGP_signature.asc
Description: OpenPGP digital signature

Re: [PHP-DEV] Requesting RFC karma

[Hans Henrik Bergan]

On Sat, 17 Feb 2024 at 08:22, Hans Henrik Bergan  wrote:
>
> My name is "Hans Henrik Bergan", usually go by the nickname
> "divinity76", I've contributed to OSS (including PHP) for years, and
> am currently involved in 3 things that might require an RFC, and
> requesting RFC karma for wiki account "divinity76".
>
> 1/3: adding BLAKE3 to PHP, a *very* fast cryptographically secure
> hash: https://github.com/php/php-src/pull/13194
>
> 2/3: int|float for sleep, sleep(0.1) => sleep 0.1 seconds:
> https://github.com/php/php-src/pull/13401
>
> 3/3: int|float for DateTime::setTimestamp, setTimestamp(0.123456) =>
> 1970-01-01 00:00:00.123456 : https://github.com/php/php-src/pull/13383

and possibly
4/4: automatic code formatting check for pull requests:
https://github.com/php/php-src/pull/13417

Re: [PHP-DEV] Requesting RFC karma

[Ilija Tovilo]

Hi Hans

On 16.02.24 13:05, Hans Henrik Bergan wrote:

My name is "Hans Henrik Bergan", usually go by the nickname
"divinity76", I've contributed to OSS (including PHP) for years, and
am currently involved in 3 things that might require an RFC, and
requesting RFC karma for wiki account "divinity76".


RFC karma was granted, good luck!

Ilija

[PHP-DEV] Requesting RFC karma

[Hans Henrik Bergan]

My name is "Hans Henrik Bergan", usually go by the nickname
"divinity76", I've contributed to OSS (including PHP) for years, and
am currently involved in 3 things that might require an RFC, and
requesting RFC karma for wiki account "divinity76".

1/3: adding BLAKE3 to PHP, a *very* fast cryptographically secure
hash: https://github.com/php/php-src/pull/13194

2/3: int|float for sleep, sleep(0.1) => sleep 0.1 seconds:
https://github.com/php/php-src/pull/13401

3/3: int|float for DateTime::setTimestamp, setTimestamp(0.123456) =>
1970-01-01 00:00:00.123456 : https://github.com/php/php-src/pull/13383

Re: [PHP-DEV] Requesting RFC karma for athos

[Ilija Tovilo]

Hi Athos

On Sat, Jul 29, 2023 at 3:37 AM Athos Ribeiro  wrote:
> I hereby request RFC karma for my recently created wiki account name
> "athos".

I granted you RFC karma. Please let me know if it works, it's the
first time I did it so I'm not sure I did it right. :)

Ilija

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: https://www.php.net/unsub.php

[PHP-DEV] Requesting RFC karma for athos

[Athos Ribeiro]

Hi,

I hereby request RFC karma for my recently created wiki account name
"athos".

As discussed in [1], I intent to create a new RFC to continue the work
started in [2] to add a new optional suffix param to tempnam.

Thanks!

[1] https://marc.info/?l=php-internals=168912164828942=2
[2] https://wiki.php.net/rfc/tempnam-suffix

--
Athos Ribeiro

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: https://www.php.net/unsub.php

[PHP-DEV] Requesting RFC karma

[Oliver Nybroe]

Hi, I would like to have RFC karma, so I can submit an RFC for a new syntax
for checking not instance of.


Best regards
Oliver Nybroe (he/him)

[PHP-DEV] Requesting RFC Karma

[Hamza Ahmad]

HI Internals,

After having a hot discussion on my STR_left-right functions' thread, I want
to bring an RFC. After reaching on a better proposal and a better agreement,
I will head for the voting process. I request for granting me an RFC karma.
My username would be hamza.

PS: when I attempted to register on the wiki, I received this message "That
wasn't the answer we were expecting". Please also tell me what it was and
the way how I can resolve this.

Best Regards

Hamza ahmad

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: https://www.php.net/unsub.php

[PHP-DEV] Requesting RFC karma

[Kim Hallberg]

Hi internals,

With the initial attitude for the clamp proposal being mostly positive 
I am moving ahead with the RFC and am therefore requesting RFC karma 
to create this RFC.

If anyone would like to grant me this karma my username for the wiki is: 
thinkverse

Thank you,
Kim Hallberg.
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: https://www.php.net/unsub.php

Re: [PHP-DEV] Requesting RFC karma for your wiki account.

[G. P. B.]

On Thu, 11 Feb 2021 at 02:03, Russell Stuart <
russell+lists.php@stuart.id.au> wrote:

> I'm created a branch to php-src that makes pdo_firebird::getColumnMeta()
> return "native_type" in addition to "pdo_type".  It also fixes a bug in
> the current getColumnMeta() (of the SIG_SEGV variety), and adds a unit
> test getColumnMeta() for it.  There is none currently.
>
> The branch is here:
>
>
> https://github.com/rstuart/php-src/tree/0044.1-add-pdo-firebird-getcolumnmeta.patch
>
> If I get RFC karma, I will create an RFC and a pull request for it.
>
> --
> Regards,
> Russell Stuart
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>
>
I don't think this would need an RFC as the MySQL PDO driver went through
the same change.
Have you opened a PR against php/php-src?

Best regards,

George P. Banyard

[PHP-DEV] Requesting RFC karma for your wiki account.

[Russell Stuart]

I'm created a branch to php-src that makes pdo_firebird::getColumnMeta() 
return "native_type" in addition to "pdo_type".  It also fixes a bug in 
the current getColumnMeta() (of the SIG_SEGV variety), and adds a unit 
test getColumnMeta() for it.  There is none currently.


The branch is here:

https://github.com/rstuart/php-src/tree/0044.1-add-pdo-firebird-getcolumnmeta.patch

If I get RFC karma, I will create an RFC and a pull request for it.

--
Regards,
Russell Stuart

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: https://www.php.net/unsub.php

[PHP-DEV] Requesting RFC karma for my wiki account

[€– ”k”k]

I will create one RFC for allows direct execution of files compiled by 
opcache_compile_file() functions.
my request path: https://github.com/php/php-src/pull/6146
The requet path will copy opcode file to special path, and allows direct 
execution opcode file.



--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: https://www.php.net/unsub.php

Re: [PHP-DEV] Requesting RFC karma

[Ferenc Kovacs]

On Thu, Sep 3, 2015 at 4:08 PM, Nikita Nefedov  wrote:

> Hey everyone,
>
> I'm asking for some RFC karma for wiki account nikita2206
> in preparation of callable typehints RFC [0]
> with Marcio, and some other RFCs in the future.
>
> Thanks in advance \O/
>
> [0] https://wiki.php.net/rfc/callable-types
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
hi Nikita,



-- 
Ferenc Kovács
@Tyr43l - http://tyrael.hu

Re: [PHP-DEV] Requesting RFC karma

[Ferenc Kovacs]

On Tue, Sep 8, 2015 at 6:44 PM, Ferenc Kovacs  wrote:

>
>
> On Thu, Sep 3, 2015 at 4:08 PM, Nikita Nefedov  wrote:
>
>> Hey everyone,
>>
>> I'm asking for some RFC karma for wiki account nikita2206
>> in preparation of callable typehints RFC [0]
>> with Marcio, and some other RFCs in the future.
>>
>> Thanks in advance \O/
>>
>> [0] https://wiki.php.net/rfc/callable-types
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>
> hi Nikita,
>

I've granted you with rfc karma, let me know if you need further assistance!

ps: I've sent the mail a bit too early. :/

-- 
Ferenc Kovács
@Tyr43l - http://tyrael.hu

[PHP-DEV] Requesting RFC karma

[Nikita Nefedov]

Hey everyone,

I'm asking for some RFC karma for wiki account nikita2206
in preparation of callable typehints RFC [0]
with Marcio, and some other RFCs in the future.

Thanks in advance \O/

[0] https://wiki.php.net/rfc/callable-types

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Requesting RFC karma

[Marcio Almada]

+1

He did most of the hard work for this particular RFC already,
so it would be great to give him permission to edit too.

2015-09-03 11:08 GMT-03:00 Nikita Nefedov :
> Hey everyone,
>
> I'm asking for some RFC karma for wiki account nikita2206
> in preparation of callable typehints RFC [0]
> with Marcio, and some other RFCs in the future.
>
> Thanks in advance \O/
>
> [0] https://wiki.php.net/rfc/callable-types
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Requesting RFC karma for wiki account

[AllenJB]

Wiki account: allenjb

I wish to submit an RFC for my notice on array-access on non-arrays pull 
request.


Draft RFC: https://gist.github.com/AllenJB/793d54a86ac182ef61f5
PR: https://github.com/php/php-src/pull/1269

Thanks in advance,

AllenJB

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php