Re: [PHP-DEV] Streams BC break unfixed since 5.6.5

2015-03-17 Thread Remi Collet
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Le 17/03/2015 14:12, Jan Schneider a écrit :
> Hello,
> 
> now that RFCing has settled down a bit, and things should get back
> to more development and less politics, can someone please take a
> look at this regression: https://bugs.php.net/bug.php?id=68948 that
> has a PR here: https://github.com/php/php-src/pull/1153
> 
> This BC breaking regression is breaking real world applications
> since two 5.5 and 5.6 releases (http://3v4l.org/YJRWQ) and the fix
> is ready to merge, at least to the master branch.

For memory, this have been detected during 5.5.21RC on Jan 11th and
reported to internal

http://news.php.net/php.internals/80363
http://news.php.net/php.internals/80410

And also reported to affected projects, i.e. Guzzle and Horde (Jan 10th)

Answer from horde developer (slusarz):

> I think the current (fixed) behavior is correct.
> 
> My implementation of the filter was actually wrong in that it
> assumed that the filter would only be called once with a single
> bucket.  From a practical standpoint, this didn't make a difference
> because strings that we need to quote, at least in
> Horde_Imap_Client, are so short (< 50 characters) that the filter
> never saw more than 1 bucket in everyday usage.  But theoretically,
> if someone was using the filter to quote a long string, the
> previous Horde_Imap_Client_Data_Format_Filter_Quote would have been
> broken before my fix.

I'm very disappointed by this, by the lack of interested by my initial
"heads-up" message, by lack of reaction from upstream project, and
this very late request for revert.


Remi.

> 
> Thanks for looking into this, Jan.
> 

-BEGIN PGP SIGNATURE-
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlUILFAACgkQYUppBSnxahhtqQCg525E7cZvIPB6XIv0ux/YRkst
9TAAoPU2qLdlyNo98EKK8EkuHrPZ7d+r
=BSgH
-END PGP SIGNATURE-

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php



[PHP-DEV] Streams BC break unfixed since 5.6.5

2015-03-17 Thread Jan Schneider

Hello,

now that RFCing has settled down a bit, and things should get back to  
more development and less politics, can someone please take a look at  
this regression: https://bugs.php.net/bug.php?id=68948 that has a PR  
here: https://github.com/php/php-src/pull/1153


This BC breaking regression is breaking real world applications since  
two 5.5 and 5.6 releases (http://3v4l.org/YJRWQ) and the fix is ready  
to merge, at least to the master branch.


Thanks for looking into this,
Jan.

--
Jan Schneider
The Horde Project
http://www.horde.org/
https://www.facebook.com/hordeproject


--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php