Re: [PHP-DEV] [RFC] Deprecate and remove INTL_IDNA_VARIANT_2003

2017-01-07 Thread Joe Watkins 
Evening Christoph,

+1, and good catch noticing the upstream change.

Cheers
Joe

On Sat, Jan 7, 2017 at 2:06 PM, Christoph M. Becker 
wrote:

> Hi!
>
> Following up on , I have
> written the RFC
>
>   
>
> and hereby placing it under discussion.
>
> I appreciate reviews and comments!
>
> --
> Christoph M. Becker
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

Re: [PHP-DEV] [RFC] Deprecate and remove INTL_IDNA_VARIANT_2003

2017-01-07 Thread Sara Golemon 
On Sat, Jan 7, 2017 at 6:06 AM, Christoph M. Becker  wrote:
> Following up on , I have
> written the RFC
>
>   
>
> and hereby placing it under discussion.
>
> I appreciate reviews and comments!
>
I noticed that recently as well (combing through compiler warnings)
but ended up deciding "If it ain't broke, don't fix it."

A deprecation is certainly in order, though I'd say we shouldn't
change the default in 7.2.  I'd be fine deprecating in 7.2, changing
default in 7.4, then removing in 8.0

It's profoundly non-broken atm, so there's no need to rush.

-Sara

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [RFC] Deprecate and remove INTL_IDNA_VARIANT_2003

2017-01-08 Thread Christoph M. Becker 
On 08.01.2017 at 01:38, Sara Golemon wrote:

> On Sat, Jan 7, 2017 at 6:06 AM, Christoph M. Becker  wrote:
>> Following up on , I have
>> written the RFC
>>
>>   
>>
>> and hereby placing it under discussion.
>>
>> I appreciate reviews and comments!
>>
> I noticed that recently as well (combing through compiler warnings)

There's also a respective ticket in the tracker:
.

> but ended up deciding "If it ain't broke, don't fix it."
> 
> A deprecation is certainly in order, though I'd say we shouldn't
> change the default in 7.2.  I'd be fine deprecating in 7.2, changing
> default in 7.4, then removing in 8.0

Thanks, that's fine for me.  I'm going to change the RFC accordingly.

Cheers,
Christoph

> It's profoundly non-broken atm, so there's no need to rush.
> 
> -Sara


-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php