Re: [PHP-DEV] Deprecate define_syslog_variables in 5.3
Hi 2008/10/14 Lukas Kahwe Smith [EMAIL PROTECTED]: On 14.10.2008, at 15:03, Markus Fischer wrote: Hi, Lukas Kahwe Smith wrote: That being said I never used this function or the constants in my code. So is there anyone that does actually use it and has some objection? Me neither, but in such cases it's probably a good idea to take a look at code search machines, e.g. http://www.google.com/codesearch?as_q=define_syslog_variablesbtnG=Search+Codehl=enas_lang=phpas_license_restrict=ias_license=as_package=as_filename=as_case= right .. and the interesting thing there is that most of the code is using the constants even though it calls the function to define the variables beforehand. the faulty documentation is probably the cause of this. so for the most part people will just need to remove the function call. I've removed it from HEAD and added an E_DEPRECATED notice on define_syslog_variables() in 5.3. If you're having define_syslog_variables=On in HEAD, it will result in an E_WARNING just like safe_mode, magic_quotes ect. Docs/wiki are updated aswell. regards, Lukas Kahwe Smith [EMAIL PROTECTED] -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php regrads -- Kalle Sommer Nielsen -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Deprecate define_syslog_variables in 5.3
On 14.10.2008, at 04:04, Kalle Sommer Nielsen wrote: Hello internals I've been looking at the function define_syslog_variables(), and I'm unsure if its intentional to keep this old functionality in PHP, seeing as define_syslog_variables defines a shortcut for each of the LOG_* constants in the form of $LOG_*. Therefore I propose the function is being deprecated in 5.3 and removed in HEAD. I agree. Fixing your code is easy (just remove the call to define_syslog_variables() and the $ in front of LOG), maintains BC with older PHP releases. On the up side this function could create an insanely hard to debug problem for users, is redundant and was a very bad idea from the start (and the docs seem incorrect too). That being said I never used this function or the constants in my code. So is there anyone that does actually use it and has some objection? regards, Lukas Kahwe Smith [EMAIL PROTECTED] -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Deprecate define_syslog_variables in 5.3
Hi, Lukas Kahwe Smith wrote: That being said I never used this function or the constants in my code. So is there anyone that does actually use it and has some objection? Me neither, but in such cases it's probably a good idea to take a look at code search machines, e.g. http://www.google.com/codesearch?as_q=define_syslog_variablesbtnG=Search+Codehl=enas_lang=phpas_license_restrict=ias_license=as_package=as_filename=as_case= or e.g. http://www.krugle.org/ cheers, - Markus -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Deprecate define_syslog_variables in 5.3
On 14.10.2008, at 15:03, Markus Fischer wrote: Hi, Lukas Kahwe Smith wrote: That being said I never used this function or the constants in my code. So is there anyone that does actually use it and has some objection? Me neither, but in such cases it's probably a good idea to take a look at code search machines, e.g. http://www.google.com/codesearch?as_q=define_syslog_variablesbtnG=Search+Codehl=enas_lang=phpas_license_restrict=ias_license=as_package=as_filename=as_case= right .. and the interesting thing there is that most of the code is using the constants even though it calls the function to define the variables beforehand. the faulty documentation is probably the cause of this. so for the most part people will just need to remove the function call. regards, Lukas Kahwe Smith [EMAIL PROTECTED] -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Deprecate define_syslog_variables in 5.3
Hi Kalle, Am Dienstag, den 14.10.2008, 04:04 +0200 schrieb Kalle Sommer Nielsen: [...] Therefore I propose the function is being deprecated in 5.3 and removed in HEAD. +1 cu, Lars -- Jabber: [EMAIL PROTECTED] Weblog: http://usrportage.de signature.asc Description: Dies ist ein digital signierter Nachrichtenteil
RE: [PHP-DEV] Deprecate define_syslog_variables in 5.3
We use syslog a lot. I've always found define_syslog_variables to be pointless and frankly a little bizarre. +1 on this. John. -Original Message- From: Lukas Kahwe Smith [mailto:[EMAIL PROTECTED] Sent: 14 October 2008 08:42 To: Kalle Sommer Nielsen Cc: PHP Development Subject: Re: [PHP-DEV] Deprecate define_syslog_variables in 5.3 On 14.10.2008, at 04:04, Kalle Sommer Nielsen wrote: Hello internals I've been looking at the function define_syslog_variables(), and I'm unsure if its intentional to keep this old functionality in PHP, seeing as define_syslog_variables defines a shortcut for each of the LOG_* constants in the form of $LOG_*. Therefore I propose the function is being deprecated in 5.3 and removed in HEAD. I agree. Fixing your code is easy (just remove the call to define_syslog_variables() and the $ in front of LOG), maintains BC with older PHP releases. On the up side this function could create an insanely hard to debug problem for users, is redundant and was a very bad idea from the start (and the docs seem incorrect too). That being said I never used this function or the constants in my code. So is there anyone that does actually use it and has some objection? regards, Lukas Kahwe Smith [EMAIL PROTECTED] -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
