Re: [PHP-DEV] Passing error codes through to PDOException

[Joey Smith]

I also just attached the following to the bug - it's a test that checks this 
fix in
the sqlite driver - I can write tests for all the others if need be, but I 
figured
there are others who might already be more familiar with the individual PDO 
drivers
that would write them more quickly than I.
--TEST--
Bug #50728 (All PDOExceptions hardcode 'code' property to 0) (crash on 
PDO::FETCH_CLASS + __set())
--SKIPIF--
?php # vim:ft=php
if (!extension_loaded('pdo_sqlite')) print 'skip not loaded';
?
--FILE--
?php
 try {
 $a = new PDO(sqlite:/this/path/should/not/exist.db);
 } catch (PDOException $e) {
 var_dump($e-getCode());
 }

?
--EXPECTF-- 
int(14)

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Passing error codes through to PDOException

[Lester Caine]

Joey Smith wrote:

Maybe I'm up in the night, but I've just opened 50728 because I discovered that 
all
the PDO drivers had a hardcoded 0 where I would expect to see the 
driver-specific
error - a user reported this in ##PHP on Freenode and I take a stab at writing 
the
patches that would let the individual drivers pass their error code on to the 
user.

They're attached to the bug as comments (the first against the tip of 5.3.2 
[svn #293440] and the second against HEAD [svn #293440]) - but I'm also attaching

them as udiffs to this email.

If there's a reason that the PDOExceptions don't contain their driver-specific
error codes, feel free to ignore this.


Joey - there is a separate list for PDO development p...@lists.php.net
And a todo list http://wiki.php.net/internals/pdo/brainstorming?s[]=pdo
But very little actual work being done, so any assistance there would be 
welcome!

--
Lester Caine - G8HFL
-
Contact - http://lsces.co.uk/wiki/?page=contact
L.S.Caine Electronic Services - http://lsces.co.uk
EnquirySolve - http://enquirysolve.com/
Model Engineers Digital Workshop - http://medw.co.uk//
Firebird - http://www.firebirdsql.org/index.php

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php