Re: [PHP-DEV] Re: Patch: Reflection Exception Messages

2010-04-09 Thread Lukas Kahwe Smith 

On 28.03.2010, at 17:59, David Soria Parra wrote:

 On 2010-03-28, Benjamin Eberlei kont...@beberlei.de wrote:
 Index: ext/reflection/php_reflection.c
 ===
 --- ext/reflection/php_reflection.c  (revision 296963)
 +++ ext/reflection/php_reflection.c  (working copy)
 @@ -3425,7 +3425,7 @@
  } else {
  efree(lc_name);
  zend_throw_exception_ex(reflection_exception_ptr, 0 TSRMLS_CC, 
 -Method %s does not exist, name);
 +Method %s::%s() does not exist, ce-name, 
 name);
  return;
  }
 }
 @@ -3602,7 +3602,7 @@
  }   
  }
  zend_throw_exception_ex(reflection_exception_ptr, 0 TSRMLS_CC, 
 -Property %s does not exist, name);
 +Property %s::%s does not exist, ce-name, name);
 }
 /* }}} *
 
 The patch is against SVN trunk.
 
 looks good for me. if there are no objections from someone else I'll
 commit it tomorrow.


@David: seems like you forgot to commit this?

regards,
Lukas Kahwe Smith
m...@pooteeweet.org




-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: Patch: Reflection Exception Messages

2010-04-09 Thread Pierre Joye 
On Fri, Apr 9, 2010 at 9:26 AM, Lukas Kahwe Smith m...@pooteeweet.org wrote:

 looks good for me. if there are no objections from someone else I'll
 commit it tomorrow.


 @David: seems like you forgot to commit this?

David will be back in 10 days.

Cheers,
-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: Patch: Reflection Exception Messages

2010-04-09 Thread David Soria Parra 


  @@ -3602,7 +3602,7 @@
 }   
 }
 zend_throw_exception_ex(reflection_exception_ptr, 0 TSRMLS_CC, 
  -  Property %s does not exist, name);
  +  Property %s::%s does not exist, ce-name, name);
  }
  /* }}} *
  
  The patch is against SVN trunk.
  
  looks good for me. if there are no objections from someone else I'll
  commit it tomorrow.
 
 
 @David: seems like you forgot to commit this?
 
Hi,

I'm sorry. I haven't had time to commit it. If someone want's to commit it, go 
for it, otherwise I'll do it on April 20.

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php