Re: [PHP-DEV] Re: Throwing E_DEPRECATED on startup
Uwe Schindler wrote: I had the same this morning when I compiled PHP on my solaris machine. The php.ini from my system-wide lib folder was used for the tests. In my case it claimed about the deprecated *_long_arrays setting (or something like that). Almost no test worked until I edited my global php.ini. Tests should use a local php.ini in the build directory. Well, actually they do use local ini. It's just sanitized version of your global one. --Jani -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: Throwing E_DEPRECATED on startup
On Wed, Jul 1, 2009 at 08:05, Kalle Sommer Nielsen wrote: > 2009/6/30 Hannes Magnusson : >> Like I warned about; if you enable any of these features in your >> php.ini and then run the test suite.. there are only a handful of >> tests that actually pass. > > I can see us passing -n parameter to the binary when executing a test, > as most tests rely on the default builtin values in php. That defeats the point of the tests. They need to be tested under various configurations. For those tests that require special INI settings we have the --INI-- section to make sure those are set the way the test requires it. Everything else should work under other configurations. -Hannes -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: Throwing E_DEPRECATED on startup
2009/6/30 Hannes Magnusson : > > Now that 5.3.0 is out, are you looking into fixing run-tests.php or all tests? run-tests.php seems most reasonable to fix, and then those tests that fail (aka. those who havnt been updated to catch these warnings). > > Like I warned about; if you enable any of these features in your > php.ini and then run the test suite.. there are only a handful of > tests that actually pass. I can see us passing -n parameter to the binary when executing a test, as most tests rely on the default builtin values in php. -- regrads, Kalle Sommer Nielsen ka...@php.net -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
RE: [PHP-DEV] Re: Throwing E_DEPRECATED on startup
I had the same this morning when I compiled PHP on my solaris machine. The php.ini from my system-wide lib folder was used for the tests. In my case it claimed about the deprecated *_long_arrays setting (or something like that). Almost no test worked until I edited my global php.ini. Tests should use a local php.ini in the build directory. - Uwe Schindler H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de eMail: u...@thetaphi.de > -Original Message- > From: paras...@gmail.com [mailto:paras...@gmail.com] On Behalf Of Daniel > Brown > Sent: Tuesday, June 30, 2009 11:31 PM > To: Hannes Magnusson > Cc: Kalle Sommer Nielsen; Internals > Subject: Re: [PHP-DEV] Re: Throwing E_DEPRECATED on startup > > On Tue, Jun 30, 2009 at 16:30, Hannes > Magnusson wrote: > > > > Now that 5.3.0 is out, are you looking into fixing run-tests.php or all > tests? > > > > Like I warned about; if you enable any of these features in your > > php.ini and then run the test suite.. there are only a handful of > > tests that actually pass. > > Indeed. Going to install it on the CA2 mirror server this morning > brought up a ton of failed and skip messages, which I mentioned to > Hannes. Here's the grep'd output: > > > > r...@december [/dls/php/php-5.3.0]# make test | grep PASS > PHP Warning: Directive 'magic_quotes_gpc' is deprecated in PHP 5.3 > and greater in Unknown on line 0 > PHP Warning: Directive 'magic_quotes_gpc' is deprecated in PHP 5.3 > and greater in Unknown on line 0 > PHP Warning: Directive 'magic_quotes_gpc' is deprecated in PHP 5.3 > and greater in Unknown on line 0 > PASS Error messages are shown [tests/run-test/test006.phpt] > PASS Testing $argc and $argv handling (cli) [tests/basic/012.phpt] > PASS Bug #28213 (crash in debug_print_backtrace in static methods) > [tests/lang/bug28213.phpt] > PASS Bug #39763 (filter applies magic_quotes twice in parse_str()) > [ext/filter/tests/bug39763.phpt] > PASS Test phpinfo() displays gettext support > [ext/gettext/tests/gettext_phpinfo.phpt] > PASS Bug #43293 (Multiple segfaults in getopt()) > [ext/standard/tests/general_functions/bug43293_3.phpt] > PASS Test get_magic_quotes_gpc() function > [ext/standard/tests/general_functions/get_magic_quotes_gpc.phpt] > PASS getopt [ext/standard/tests/general_functions/getopt.phpt] t] > PASS getopt#002 [ext/standard/tests/general_functions/getopt_002.phpt] > PASS getopt#003 [ext/standard/tests/general_functions/getopt_003.phpt] > PASS getopt#004 (Optional values) > [ext/standard/tests/general_functions/getopt_004.phpt] > PASS getopt#005 (Required values) > [ext/standard/tests/general_functions/getopt_005.phpt] > FAIL Test parse_url() function: Parse a load of URLs without > specifying PHP_URL_PASS as the URL component > [ext/standard/tests/url/parse_url_basic_006.phpt] > PASS Test phpinfo() displays xsl info [ext/xsl/tests/xsl-phpinfo.phpt] > Test parse_url() function: Parse a load of URLs without specifying > PHP_URL_PASS as the URL component > [ext/standard/tests/url/parse_url_basic_006.phpt] > > r...@december [/dls/php/php-5.3.0]# uname -a > Linux december.pilotpig.net 2.6.18-128.1.1.el5.028stab062.3 #1 SMP Tue > May 5 17:31:34 MSD 2009 i686 i686 i386 GNU/Linux > > > > The rest of the 9,400+ tests all came back with undesired results. > There were no other problems on any of the dev boxes I tried this > morning, just the test results. > > -- > > daniel.br...@parasane.net || danbr...@php.net > http://www.parasane.net/ || http://www.pilotpig.net/ > Ask me about our fully-managed servers and proactive management > clusters starting at just $200/mo.! > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: Throwing E_DEPRECATED on startup
On Tue, Jun 30, 2009 at 16:30, Hannes Magnusson wrote: > > Now that 5.3.0 is out, are you looking into fixing run-tests.php or all tests? > > Like I warned about; if you enable any of these features in your > php.ini and then run the test suite.. there are only a handful of > tests that actually pass. Indeed. Going to install it on the CA2 mirror server this morning brought up a ton of failed and skip messages, which I mentioned to Hannes. Here's the grep'd output: r...@december [/dls/php/php-5.3.0]# make test | grep PASS PHP Warning: Directive 'magic_quotes_gpc' is deprecated in PHP 5.3 and greater in Unknown on line 0 PHP Warning: Directive 'magic_quotes_gpc' is deprecated in PHP 5.3 and greater in Unknown on line 0 PHP Warning: Directive 'magic_quotes_gpc' is deprecated in PHP 5.3 and greater in Unknown on line 0 PASS Error messages are shown [tests/run-test/test006.phpt] PASS Testing $argc and $argv handling (cli) [tests/basic/012.phpt] PASS Bug #28213 (crash in debug_print_backtrace in static methods) [tests/lang/bug28213.phpt] PASS Bug #39763 (filter applies magic_quotes twice in parse_str()) [ext/filter/tests/bug39763.phpt] PASS Test phpinfo() displays gettext support [ext/gettext/tests/gettext_phpinfo.phpt] PASS Bug #43293 (Multiple segfaults in getopt()) [ext/standard/tests/general_functions/bug43293_3.phpt] PASS Test get_magic_quotes_gpc() function [ext/standard/tests/general_functions/get_magic_quotes_gpc.phpt] PASS getopt [ext/standard/tests/general_functions/getopt.phpt] t] PASS getopt#002 [ext/standard/tests/general_functions/getopt_002.phpt] PASS getopt#003 [ext/standard/tests/general_functions/getopt_003.phpt] PASS getopt#004 (Optional values) [ext/standard/tests/general_functions/getopt_004.phpt] PASS getopt#005 (Required values) [ext/standard/tests/general_functions/getopt_005.phpt] FAIL Test parse_url() function: Parse a load of URLs without specifying PHP_URL_PASS as the URL component [ext/standard/tests/url/parse_url_basic_006.phpt] PASS Test phpinfo() displays xsl info [ext/xsl/tests/xsl-phpinfo.phpt] Test parse_url() function: Parse a load of URLs without specifying PHP_URL_PASS as the URL component [ext/standard/tests/url/parse_url_basic_006.phpt] r...@december [/dls/php/php-5.3.0]# uname -a Linux december.pilotpig.net 2.6.18-128.1.1.el5.028stab062.3 #1 SMP Tue May 5 17:31:34 MSD 2009 i686 i686 i386 GNU/Linux The rest of the 9,400+ tests all came back with undesired results. There were no other problems on any of the dev boxes I tried this morning, just the test results. -- daniel.br...@parasane.net || danbr...@php.net http://www.parasane.net/ || http://www.pilotpig.net/ Ask me about our fully-managed servers and proactive management clusters starting at just $200/mo.! -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: Throwing E_DEPRECATED on startup
On Tue, May 5, 2009 at 21:34, Kalle Sommer Nielsen wrote: > 2009/2/6 Kalle Sommer Nielsen : >> G'day >> >> I'd like to propose a change for when PHP starts to throw an >> E_DEPRECATED notice for each of the deprecated ini directives (such as >> register_globals, safe_mode ect.) like in HEAD where they just throw a >> warning (more about that below). I have attached a patch for this in >> 5.3 (which is the only branch this patch really relates to). >> > > Implemented in RC2 Now that 5.3.0 is out, are you looking into fixing run-tests.php or all tests? Like I warned about; if you enable any of these features in your php.ini and then run the test suite.. there are only a handful of tests that actually pass. -Hannes -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: Throwing E_DEPRECATED on startup
All right!I think, there win't be any rejections. Let's deploy it ;-D 2009/2/6 Kalle Sommer Nielsen > 2009/2/6 Kalle Sommer Nielsen : > > G'day > > > > [snip] > > > > -- > > Kalle Sommer Nielsen > > > > Resending the patch, as Felipe said it wasn't there for some odd > reason because of the file extension and for the sake of sanity: > > http://paste2.org/p/142865 - PHP_5_3 > http://paste2.org/p/142866 - HEAD > > > > -- > Kalle Sommer Nielsen > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php >
