Re: [PATCH v2 00/33] Separate struct slab from struct page
On Mon, Dec 20, 2021 at 01:47:54AM +0100, Vlastimil Babka wrote: > > * mm/slub: Convert print_page_info() to print_slab_info() > > Do we really need to explicitly convert slab_folio()'s result to (struct > > folio *)? > > Unfortunately yes, as long as folio_flags() don't take const struct folio *, > which will need some yak shaving. In case anyone's interested ... folio_flags calls VM_BUG_ON_PGFLAGS() which would need its second argument to be const. That means dump_page() needs to take a const struct page, which means __dump_page() needs its argument to be const. That calls ... is_migrate_cma_page() page_mapping() page_mapcount() page_ref_count() page_to_pgoff() page_to_pfn() hpage_pincount_available() head_compound_mapcount() head_compound_pincount() compound_order() PageKsm() PageAnon() PageCompound() ... and at that point, I ran out of motivation to track down some parts of this tarbaby that could be fixed. I did do: mm: constify page_count and page_ref_count mm: constify get_pfnblock_flags_mask and get_pfnblock_migratetype mm: make compound_head const-preserving mm/page_owner: constify dump_page_owner so some of those are already done. But a lot of them just need to be done at the same time. For example, page_mapping() calls folio_mapping() which calls folio_test_slab() which calls folio_flags(), so dump_page() and page_mapping() need to be done at the same time. One bit that could be broken off easily (I think ...) is PageTransTail() PageTail(), PageCompound(), PageHuge(), page_to_pgoff() and page_to_index(). One wrinkle is needed a temporary TESTPAGEFLAGS_FALSE_CONST. But I haven't tried it yet. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v3 6/9] iommu/vt-d: Use put_pages_list
Hi Robin, On 12/17/21 11:31 PM, Robin Murphy wrote: From: "Matthew Wilcox (Oracle)" page->freelist is for the use of slab. We already have the ability to free a list of pages in the core mm, but it requires the use of a list_head and for the pages to be chained together through page->lru. Switch the Intel IOMMU and IOVA code over to using free_pages_list(). Signed-off-by: Matthew Wilcox (Oracle) [rm: split from original patch, cosmetic tweaks, fix fq entries] Signed-off-by: Robin Murphy I had boot tests on my development machines with both strict and lazy flushing modes. I didn't see any regression, the disk i/o and network i/o worked good for me. For changes in iommu/vt-d: Reviewed-by: Lu Baolu Best regards, baolu ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v2 00/33] Separate struct slab from struct page
On 12/16/21 00:38, Roman Gushchin wrote: > Part 2: > > * mm: Convert check_heap_object() to use struct slab > Reviewed-by: Roman Gushchin > > * mm/slub: Convert detached_freelist to use a struct slab > How about to convert free_nonslab_page() to free_nonslab_folio()? > And maybe rename it to something like free_large_kmalloc()? > If I'm not missing something, large kmallocs is the only way how we can end up > there with a !slab folio/page. Good point, thanks! But did at as part of the following patch, where it fits logically better. > * mm/slub: Convert kfree() to use a struct slab > Reviewed-by: Roman Gushchin Didn't add your tag because of the addition of free_large_kmalloc() change. > * mm/slub: Convert __slab_lock() and __slab_unlock() to struct slab > Reviewed-by: Roman Gushchin > > * mm/slub: Convert print_page_info() to print_slab_info() > Do we really need to explicitly convert slab_folio()'s result to (struct > folio *)? Unfortunately yes, as long as folio_flags() don't take const struct folio *, which will need some yak shaving. > Reviewed-by: Roman Gushchin > > * mm/slub: Convert alloc_slab_page() to return a struct slab > Reviewed-by: Roman Gushchin > > * mm/slub: Convert __free_slab() to use struct slab > Reviewed-by: Roman Gushchin > > * mm/slub: Convert pfmemalloc_match() to take a struct slab > Cool! Removing pfmemalloc_unsafe() is really nice. > Reviewed-by: Roman Gushchin > > * mm/slub: Convert most struct page to struct slab by spatch > Reviewed-by: Roman Gushchin > > * mm/slub: Finish struct page to struct slab conversion > Reviewed-by: Roman Gushchin > > * mm/slab: Convert kmem_getpages() and kmem_freepages() to struct slab > Reviewed-by: Roman Gushchin Thanks again! > * mm/slab: Convert most struct page to struct slab by spatch > > Another patch with the same title? Rebase error? > > * mm/slab: Finish struct page to struct slab conversion > > And this one too? > > > Thanks! > > Roman ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v2 00/33] Separate struct slab from struct page
On 12/15/21 02:03, Roman Gushchin wrote: > On Tue, Dec 14, 2021 at 01:57:22PM +0100, Vlastimil Babka wrote: >> On 12/1/21 19:14, Vlastimil Babka wrote: >> > Folks from non-slab subsystems are Cc'd only to patches affecting them, and >> > this cover letter. >> > >> > Series also available in git, based on 5.16-rc3: >> > https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/linux.git/log/?h=slab-struct_slab-v2r2 >> >> Pushed a new branch slab-struct-slab-v3r3 with accumulated fixes and small >> tweaks >> and a new patch from Hyeonggon Yoo on top. To avoid too much spam, here's a >> range diff: > > Hi Vlastimil! > > I've started to review this patchset (btw, a really nice work, I like > the resulting code way more). Because I'm looking at v3 and I don't have > the whole v2 in my mailbox, here is what I've now: Thanks a lot, Roman! > * mm: add virt_to_folio() and folio_address() > Reviewed-by: Roman Gushchin > > * mm/slab: Dissolve slab_map_pages() in its caller > Reviewed-by: Roman Gushchin > > * mm/slub: Make object_err() static > Reviewed-by: Roman Gushchin > > * mm: Split slab into its own type > 1) Shouldn't SLAB_MATCH() macro use struct folio instead of struct page for > the > comparison? Folio doesn't have define most of the fields, and matching some to page and others to folio seems like unnecessary complication. Maybe as part of the final struct page cleanup when the slab fields are gone from struct page, the rest could all be in folio - I'll check once we get there. > 2) page_slab() is used only in kasan and only in one place, so maybe it's > better > to not introduce it as a generic helper? Yeah that's the case after the series, but as part of the incremental steps, page_slab() gets used in many places. I'll consider removing it on top though. > Other than that > Reviewed-by: Roman Gushchin > > * mm: Add account_slab() and unaccount_slab() > 1) maybe change the title to convert/replace instead of add? Done. > 2) maybe move later changes to memcg_alloc_page_obj_cgroups() to this patch? Maybe possible, but that would distort the series more than I'd like to at this rc6 time. > Reviewed-by: Roman Gushchin > > * mm: Convert virt_to_cache() to use struct slab > Reviewed-by: Roman Gushchin > > * mm: Convert __ksize() to struct slab > It looks like certain parts of __ksize() can be merged between slab, slub and > slob? > Reviewed-by: Roman Gushchin > > * mm: Use struct slab in kmem_obj_info() > Reviewed-by: Roman Gushchin > > > I'll try to finish reviewing the patchset until the end of the week. > > Thanks! > > Roman ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
