[RFC PATCH] dma-direct: dma_contiguous_pernuma_area[] can be static
Signed-off-by: kbuild test robot --- contiguous.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/dma/contiguous.c b/kernel/dma/contiguous.c index 4b10d0ca0456d..2094c8e0590ac 100644 --- a/kernel/dma/contiguous.c +++ b/kernel/dma/contiguous.c @@ -37,7 +37,7 @@ #endif struct cma *dma_contiguous_default_area; -struct cma *dma_contiguous_pernuma_area[MAX_NUMNODES]; +static struct cma *dma_contiguous_pernuma_area[MAX_NUMNODES]; /* * Default global CMA area size can be defined in kernel's .config. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 1/3] dma-direct: provide the ability to reserve per-numa CMA
Hi Barry, I love your patch! Perhaps something to improve: [auto build test WARNING on arm64/for-next/core] [also build test WARNING on linus/master v5.7] [cannot apply to next-20200602] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Barry-Song/support-per-numa-CMA-for-ARM-server/20200603-104821 base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core config: i386-randconfig-s002-20200602 (attached as .config) compiler: gcc-9 (Debian 9.3.0-13) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.1-244-g0ee050a8-dirty # save the attached .config to linux build tree make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) >> kernel/dma/contiguous.c:40:12: sparse: sparse: symbol >> 'dma_contiguous_pernuma_area' was not declared. Should it be static? >> kernel/dma/contiguous.c:278:50: sparse: sparse: invalid access below >> 'dma_contiguous_pernuma_area' (-4 4) Please review and possibly fold the followup patch. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 1/3] dma-direct: provide the ability to reserve per-numa CMA
Hi Barry,
I love your patch! Perhaps something to improve:
[auto build test WARNING on arm64/for-next/core]
[also build test WARNING on linus/master v5.7]
[cannot apply to hch-configfs/for-next next-20200602]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Barry-Song/support-per-numa-CMA-for-ARM-server/20200603-104821
base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git
for-next/core
config: i386-randconfig-r033-20200602 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
All warnings (new ones prefixed by >>, old ones prefixed by <<):
In file included from include/linux/kernel.h:15,
from include/asm-generic/bug.h:19,
from arch/x86/include/asm/bug.h:83,
from include/linux/bug.h:5,
from include/linux/mmdebug.h:5,
from include/linux/mm.h:9,
from include/linux/memblock.h:13,
from kernel/dma/contiguous.c:21:
kernel/dma/contiguous.c: In function 'dma_pernuma_cma_reserve':
>> include/linux/kern_levels.h:5:18: warning: format '%llu' expects argument of
>> type 'long long unsigned int', but argument 3 has type 'unsigned int'
>> [-Wformat=]
5 | #define KERN_SOH "001" /* ASCII Start Of Header */
| ^~
include/linux/printk.h:137:10: note: in definition of macro 'no_printk'
137 | printk(fmt, ##__VA_ARGS__); | ^~~
include/linux/kern_levels.h:15:20: note: in expansion of macro 'KERN_SOH'
15 | #define KERN_DEBUG KERN_SOH "7" /* debug-level messages */
|^~~~
include/linux/printk.h:336:12: note: in expansion of macro 'KERN_DEBUG'
336 | no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
|^~
kernel/dma/contiguous.c:128:3: note: in expansion of macro 'pr_debug'
128 | pr_debug("%s: reserved %llu MiB on node %dn", __func__,
| ^~~~
kernel/dma/contiguous.c:128:29: note: format string is defined here
128 | pr_debug("%s: reserved %llu MiB on node %dn", __func__,
| ~~~^
| |
| long long unsigned int
| %u
vim +5 include/linux/kern_levels.h
314ba3520e513a Joe Perches 2012-07-30 4
04d2c8c83d0e3a Joe Perches 2012-07-30 @5 #define KERN_SOH "\001"
/* ASCII Start Of Header */
04d2c8c83d0e3a Joe Perches 2012-07-30 6 #define KERN_SOH_ASCII'\001'
04d2c8c83d0e3a Joe Perches 2012-07-30 7
:: The code at line 5 was first introduced by commit
:: 04d2c8c83d0e3ac5f78aeede51babb3236200112 printk: convert the format for
KERN_ to a 2 byte pattern
:: TO: Joe Perches
:: CC: Linus Torvalds
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
[iommu:x86/vt-d 23/44] drivers/iommu/mtk_iommu_v1.c:467:25: warning: variable 'data' set but not used
tree: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git x86/vt-d
head: 69cf449166987d9a041020be6422ee7bf94a7228
commit: 57dbf81f50c82a0ad895a57828ad1ab539785a25 [23/44] iommu/mediatek-v1
Convert to probe/release_device() call-backs
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 57dbf81f50c82a0ad895a57828ad1ab539785a25
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
All warnings (new ones prefixed by >>, old ones prefixed by <<):
drivers/iommu/mtk_iommu_v1.c: In function 'mtk_iommu_release_device':
>> drivers/iommu/mtk_iommu_v1.c:467:25: warning: variable 'data' set but not
>> used [-Wunused-but-set-variable]
467 | struct mtk_iommu_data *data;
| ^~~~
vim +/data +467 drivers/iommu/mtk_iommu_v1.c
b17336c55d8928c4 Honghui Zhang 2016-06-08 463
57dbf81f50c82a0a Joerg Roedel 2020-04-29 464 static void
mtk_iommu_release_device(struct device *dev)
b17336c55d8928c4 Honghui Zhang 2016-06-08 465 {
a9bf2eec5a6fc01a Joerg Roedel 2018-11-29 466 struct iommu_fwspec
*fwspec = dev_iommu_fwspec_get(dev);
6f66ea099fc2f31d Joerg Roedel 2017-03-31 @467 struct mtk_iommu_data
*data;
6f66ea099fc2f31d Joerg Roedel 2017-03-31 468
a9bf2eec5a6fc01a Joerg Roedel 2018-11-29 469 if (!fwspec ||
fwspec->ops != _iommu_ops)
b17336c55d8928c4 Honghui Zhang 2016-06-08 470 return;
b17336c55d8928c4 Honghui Zhang 2016-06-08 471
3524b5592cad638b Joerg Roedel 2020-03-26 472 data =
dev_iommu_priv_get(dev);
84672f192671e64e Robin Murphy 2016-10-17 473 iommu_fwspec_free(dev);
b17336c55d8928c4 Honghui Zhang 2016-06-08 474 }
b17336c55d8928c4 Honghui Zhang 2016-06-08 475
:: The code at line 467 was first introduced by commit
:: 6f66ea099fc2f31d31d6cd39f3b13b23bdeb6196 iommu/mediatek: Teach
MTK-IOMMUv1 about 'struct iommu_device'
:: TO: Joerg Roedel
:: CC: Joerg Roedel
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 3/5] swiotlb: Add alloc and free APIs
Hi Srivatsa,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on vhost/linux-next]
[also build test ERROR on xen-tip/linux-next linus/master v5.7-rc3
next-20200429]
[cannot apply to swiotlb/linux-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Srivatsa-Vaddagiri/virtio-on-Type-1-hypervisor/20200429-032334
base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: i386-randconfig-b002-20200429 (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
In file included from drivers/gpu/drm/i915/i915_scatterlist.h:12:0,
from drivers/gpu/drm/i915/i915_scatterlist.c:7:
include/linux/swiotlb.h: In function 'swiotlb_alloc':
>> include/linux/swiotlb.h:231:9: error: 'DMA_MAPPING_ERROR' undeclared (first
>> use in this function); did you mean 'APM_NO_ERROR'?
return DMA_MAPPING_ERROR;
^
APM_NO_ERROR
include/linux/swiotlb.h:231:9: note: each undeclared identifier is reported
only once for each function it appears in
vim +231 include/linux/swiotlb.h
226
227 static inline phys_addr_t swiotlb_alloc(struct swiotlb_pool *pool,
228 size_t alloc_size, unsigned long tbl_dma_addr,
229 unsigned long mask)
230 {
> 231 return DMA_MAPPING_ERROR;
232 }
233
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
[RFC PATCH] virtio: virtio_pool can be static
Signed-off-by: kbuild test robot
---
virtio_bounce.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/virtio/virtio_bounce.c b/drivers/virtio/virtio_bounce.c
index 3de8e0eb71e48..5a68d48667c42 100644
--- a/drivers/virtio/virtio_bounce.c
+++ b/drivers/virtio/virtio_bounce.c
@@ -19,7 +19,7 @@
static phys_addr_t bounce_buf_paddr;
static void *bounce_buf_vaddr;
static size_t bounce_buf_size;
-struct swiotlb_pool *virtio_pool;
+static struct swiotlb_pool *virtio_pool;
#define VIRTIO_MAX_BOUNCE_SIZE (16*4096)
@@ -76,7 +76,7 @@ static void virtio_unmap_page(struct device *dev, dma_addr_t
dev_addr,
size, dir, attrs);
}
-size_t virtio_max_mapping_size(struct device *dev)
+static size_t virtio_max_mapping_size(struct device *dev)
{
return VIRTIO_MAX_BOUNCE_SIZE;
}
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 5/5] virtio: Add bounce DMA ops
Hi Srivatsa, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on vhost/linux-next] [also build test WARNING on xen-tip/linux-next linus/master v5.7-rc3 next-20200428] [cannot apply to swiotlb/linux-next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Srivatsa-Vaddagiri/virtio-on-Type-1-hypervisor/20200429-032334 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next reproduce: # apt-get install sparse # sparse version: v0.6.1-191-gc51a0382-dirty make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) >> drivers/virtio/virtio_bounce.c:22:21: sparse: sparse: symbol 'virtio_pool' >> was not declared. Should it be static? >> drivers/virtio/virtio_bounce.c:79:8: sparse: sparse: symbol >> 'virtio_max_mapping_size' was not declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 1/5] swiotlb: Introduce concept of swiotlb_pool
Hi Srivatsa,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on vhost/linux-next]
[also build test ERROR on xen-tip/linux-next linus/master v5.7-rc3
next-20200428]
[cannot apply to swiotlb/linux-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Srivatsa-Vaddagiri/virtio-on-Type-1-hypervisor/20200429-032334
base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: x86_64-defconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
drivers/iommu/intel-iommu.c: In function 'bounce_map_single':
>> drivers/iommu/intel-iommu.c:3990:24: error: 'io_tlb_start' undeclared (first
>> use in this function); did you mean 'swiotlb_start'?
__phys_to_dma(dev, io_tlb_start),
^~~~
swiotlb_start
drivers/iommu/intel-iommu.c:3990:24: note: each undeclared identifier is
reported only once for each function it appears in
vim +3990 drivers/iommu/intel-iommu.c
cfb94a372f2d4e Lu Baolu 2019-09-06 3941
cfb94a372f2d4e Lu Baolu 2019-09-06 3942 static dma_addr_t
cfb94a372f2d4e Lu Baolu 2019-09-06 3943 bounce_map_single(struct device
*dev, phys_addr_t paddr, size_t size,
cfb94a372f2d4e Lu Baolu 2019-09-06 3944 enum
dma_data_direction dir, unsigned long attrs,
cfb94a372f2d4e Lu Baolu 2019-09-06 3945 u64 dma_mask)
cfb94a372f2d4e Lu Baolu 2019-09-06 3946 {
cfb94a372f2d4e Lu Baolu 2019-09-06 3947size_t aligned_size =
ALIGN(size, VTD_PAGE_SIZE);
cfb94a372f2d4e Lu Baolu 2019-09-06 3948struct dmar_domain *domain;
cfb94a372f2d4e Lu Baolu 2019-09-06 3949struct intel_iommu *iommu;
cfb94a372f2d4e Lu Baolu 2019-09-06 3950unsigned long iova_pfn;
cfb94a372f2d4e Lu Baolu 2019-09-06 3951unsigned long nrpages;
cfb94a372f2d4e Lu Baolu 2019-09-06 3952phys_addr_t tlb_addr;
cfb94a372f2d4e Lu Baolu 2019-09-06 3953int prot = 0;
cfb94a372f2d4e Lu Baolu 2019-09-06 3954int ret;
cfb94a372f2d4e Lu Baolu 2019-09-06 3955
a11bfde9c77df1 Joerg Roedel 2020-02-17 3956if
(unlikely(attach_deferred(dev)))
a11bfde9c77df1 Joerg Roedel 2020-02-17 3957do_deferred_attach(dev);
a11bfde9c77df1 Joerg Roedel 2020-02-17 3958
96d170f3b1a607 Joerg Roedel 2020-02-17 3959domain = find_domain(dev);
a11bfde9c77df1 Joerg Roedel 2020-02-17 3960
cfb94a372f2d4e Lu Baolu 2019-09-06 3961if (WARN_ON(dir == DMA_NONE ||
!domain))
cfb94a372f2d4e Lu Baolu 2019-09-06 3962return
DMA_MAPPING_ERROR;
cfb94a372f2d4e Lu Baolu 2019-09-06 3963
cfb94a372f2d4e Lu Baolu 2019-09-06 3964iommu =
domain_get_iommu(domain);
cfb94a372f2d4e Lu Baolu 2019-09-06 3965if (WARN_ON(!iommu))
cfb94a372f2d4e Lu Baolu 2019-09-06 3966return
DMA_MAPPING_ERROR;
cfb94a372f2d4e Lu Baolu 2019-09-06 3967
cfb94a372f2d4e Lu Baolu 2019-09-06 3968nrpages = aligned_nrpages(0,
size);
cfb94a372f2d4e Lu Baolu 2019-09-06 3969iova_pfn =
intel_alloc_iova(dev, domain,
cfb94a372f2d4e Lu Baolu 2019-09-06 3970
dma_to_mm_pfn(nrpages), dma_mask);
cfb94a372f2d4e Lu Baolu 2019-09-06 3971if (!iova_pfn)
cfb94a372f2d4e Lu Baolu 2019-09-06 3972return
DMA_MAPPING_ERROR;
cfb94a372f2d4e Lu Baolu 2019-09-06 3973
cfb94a372f2d4e Lu Baolu 2019-09-06 3974/*
cfb94a372f2d4e Lu Baolu 2019-09-06 3975 * Check if DMAR supports
zero-length reads on write only
cfb94a372f2d4e Lu Baolu 2019-09-06 3976 * mappings..
cfb94a372f2d4e Lu Baolu 2019-09-06 3977 */
cfb94a372f2d4e Lu Baolu 2019-09-06 3978if (dir == DMA_TO_DEVICE || dir
== DMA_BIDIRECTIONAL ||
cfb94a372f2d4e Lu Baolu 2019-09-06 3979
!cap_zlr(iommu->cap))
cfb94a372f2d4e Lu Baolu 2019-09-06 3980prot |= DMA_PTE_READ;
cfb94a372f2d4e Lu Baolu 2019-09-06 3981if (dir == DMA_FROM_DEVICE ||
dir == DMA_BIDIRECTIONAL)
cfb94a372f2d4e Lu Baolu 2019-09-06 3982prot |= DMA_PTE_WRITE;
cfb94a372f2d4e Lu Baolu 2019-09-06 3983
cfb94a372f2d4e Lu Baolu 2019-09-06 3984/*
cfb94a372f2d4e Lu Baolu 2019-09-06 3985 * If both the physical buffer
start address and size are
cfb94a372f2d4e Lu Baolu 2019-09-06 3986 * page aligned, we don't need
to use a bounce page.
cfb94a372f2d4e Lu Baolu 2019-09-06 3987 */
cfb94a372f2
Re: [PATCH 5/5] virtio: Add bounce DMA ops
Hi Srivatsa,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on vhost/linux-next]
[also build test ERROR on xen-tip/linux-next linus/master v5.7-rc3
next-20200428]
[cannot apply to swiotlb/linux-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Srivatsa-Vaddagiri/virtio-on-Type-1-hypervisor/20200429-032334
base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: s390-randconfig-a001-20200428 (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
drivers/virtio/virtio_bounce.c: In function 'virtio_bounce_setup':
>> drivers/virtio/virtio_bounce.c:144:7: error: implicit declaration of
>> function 'of_get_flat_dt_prop' [-Werror=implicit-function-declaration]
144 | if (!of_get_flat_dt_prop(node, "no-map", NULL))
| ^~~
cc1: some warnings being treated as errors
vim +/of_get_flat_dt_prop +144 drivers/virtio/virtio_bounce.c
139
140 static int __init virtio_bounce_setup(struct reserved_mem *rmem)
141 {
142 unsigned long node = rmem->fdt_node;
143
> 144 if (!of_get_flat_dt_prop(node, "no-map", NULL))
145 return -EINVAL;
146
147 return virtio_register_bounce_buffer(rmem->base, rmem->size);
148 }
149
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 5/5] virtio: Add bounce DMA ops
Hi Srivatsa,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on vhost/linux-next]
[also build test WARNING on xen-tip/linux-next linus/master v5.7-rc3
next-20200428]
[cannot apply to swiotlb/linux-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Srivatsa-Vaddagiri/virtio-on-Type-1-hypervisor/20200429-032334
base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
config: sh-randconfig-a001-20200428 (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
All warnings (new ones prefixed by >>):
In file included from drivers/virtio/virtio_bounce.c:13:
include/linux/swiotlb.h: In function 'swiotlb_alloc':
include/linux/swiotlb.h:234:9: error: 'DMA_MAPPING_ERROR' undeclared (first
use in this function)
234 | return DMA_MAPPING_ERROR;
| ^
include/linux/swiotlb.h:234:9: note: each undeclared identifier is reported
only once for each function it appears in
>> include/linux/swiotlb.h:235:1: warning: control reaches end of non-void
>> function [-Wreturn-type]
235 | }
| ^
vim +235 include/linux/swiotlb.h
9ab4c39d9f9298 Srivatsa Vaddagiri 2020-04-28 229
9ab4c39d9f9298 Srivatsa Vaddagiri 2020-04-28 230 static inline phys_addr_t
swiotlb_alloc(struct swiotlb_pool *pool,
9ab4c39d9f9298 Srivatsa Vaddagiri 2020-04-28 231 size_t
alloc_size, unsigned long tbl_dma_addr,
9ab4c39d9f9298 Srivatsa Vaddagiri 2020-04-28 232 unsigned long
mask)
9ab4c39d9f9298 Srivatsa Vaddagiri 2020-04-28 233 {
9ab4c39d9f9298 Srivatsa Vaddagiri 2020-04-28 234 return
DMA_MAPPING_ERROR;
9ab4c39d9f9298 Srivatsa Vaddagiri 2020-04-28 @235 }
9ab4c39d9f9298 Srivatsa Vaddagiri 2020-04-28 236
:: The code at line 235 was first introduced by commit
:: 9ab4c39d9f929840cb884e589f6112770dbc2f63 swiotlb: Add alloc and free APIs
:: TO: Srivatsa Vaddagiri
:: CC: 0day robot
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v3] of_device: removed #include that caused a recursion in included headers
Hi Hadar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on sparc/master]
[also build test ERROR on stm32/stm32-next linus/master v5.7-rc2 next-20200422]
[cannot apply to sparc-next/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Hadar-Gat/of_device-removed-include-that-caused-a-recursion-in-included-headers/20200423-040844
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc.git master
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross
ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
drivers/firmware/ti_sci.c: In function 'ti_sci_probe':
>> drivers/firmware/ti_sci.c:3520:9: error: implicit declaration of function
>> 'of_platform_populate' [-Werror=implicit-function-declaration]
3520 | return of_platform_populate(dev->of_node, NULL, NULL, dev);
| ^~~~
drivers/firmware/ti_sci.c: In function 'ti_sci_remove':
>> drivers/firmware/ti_sci.c:3536:2: error: implicit declaration of function
>> 'of_platform_depopulate' [-Werror=implicit-function-declaration]
3536 | of_platform_depopulate(dev);
| ^~
cc1: some warnings being treated as errors
--
drivers/firmware/tegra/bpmp.c: In function 'tegra_bpmp_get':
>> drivers/firmware/tegra/bpmp.c:51:9: error: implicit declaration of function
>> 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'?
>> [-Werror=implicit-function-declaration]
51 | pdev = of_find_device_by_node(np);
| ^~
| bus_find_device_by_fwnode
drivers/firmware/tegra/bpmp.c:51:7: warning: assignment to 'struct
platform_device *' from 'int' makes pointer from integer without a cast
[-Wint-conversion]
51 | pdev = of_find_device_by_node(np);
| ^
drivers/firmware/tegra/bpmp.c: In function 'tegra_bpmp_probe':
>> drivers/firmware/tegra/bpmp.c:759:8: error: implicit declaration of function
>> 'of_platform_default_populate' [-Werror=implicit-function-declaration]
759 | err = of_platform_default_populate(pdev->dev.of_node, NULL,
>dev);
|^~~~
cc1: some warnings being treated as errors
--
drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c: In function
'sun8i_dw_hdmi_find_connector_pdev':
>> drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c:115:9: error: implicit declaration of
>> function 'of_find_device_by_node'; did you mean
>> 'of_find_i2c_device_by_node'? [-Werror=implicit-function-declaration]
115 | pdev = of_find_device_by_node(remote);
| ^~
| of_find_i2c_device_by_node
drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c:115:7: warning: assignment to 'struct
platform_device *' from 'int' makes pointer from integer without a cast
[-Wint-conversion]
115 | pdev = of_find_device_by_node(remote);
| ^
cc1: some warnings being treated as errors
vim +/of_platform_populate +3520 drivers/firmware/ti_sci.c
aa276781a64a5f Nishanth Menon 2016-10-18 3385
aa276781a64a5f Nishanth Menon 2016-10-18 3386 static int ti_sci_probe(struct
platform_device *pdev)
aa276781a64a5f Nishanth Menon 2016-10-18 3387 {
aa276781a64a5f Nishanth Menon 2016-10-18 3388 struct device *dev =
>dev;
aa276781a64a5f Nishanth Menon 2016-10-18 3389 const struct
of_device_id *of_id;
aa276781a64a5f Nishanth Menon 2016-10-18 3390 const struct
ti_sci_desc *desc;
aa276781a64a5f Nishanth Menon 2016-10-18 3391 struct ti_sci_xfer
*xfer;
aa276781a64a5f Nishanth Menon 2016-10-18 3392 struct ti_sci_info
*info = NULL;
aa276781a64a5f Nishanth Menon 2016-10-18 3393 struct
ti_sci_xfers_info *minfo;
aa276781a64a5f Nishanth Menon 2016-10-18 3394 struct mbox_client *cl;
aa276781a64a5f Nishanth Menon 2016-10-18 3395 int ret = -EINVAL;
aa276781a64a5f Nishanth Menon 2016-10-18 3396 int i;
912cffb4ed8612 Nishanth Menon 2016-10-18 3397 int reboot = 0;
e69a35531589a2 Nishanth Menon 2018-08-28 3398 u32 h_id;
aa276781a64a5f Nishanth Menon 2016-10-18 3399
aa276781a64a5f Nishanth Menon 2016-10-18 3400 of_id =
of_match_device(ti_sci_of_match, dev);
aa276781a64a5f Nishanth Me
Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers
Hi Hadar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on stm32/stm32-next]
[also build test ERROR on sunxi/sunxi/for-next linus/master v5.7-rc1
next-20200416]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Hadar-Gat/of_device-removed-include-that-caused-a-recursion-in-included-headers/20200417-155422
base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git
stm32-next
config: sparc64-defconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross
ARCH=sparc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
arch/sparc/kernel/sbus.c: In function 'sbus_init':
>> arch/sparc/kernel/sbus.c:669:32: error: implicit declaration of function
>> 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'?
>> [-Werror=implicit-function-declaration]
669 | struct platform_device *op = of_find_device_by_node(dp);
|^~
|bus_find_device_by_fwnode
>> arch/sparc/kernel/sbus.c:669:32: error: initialization of 'struct
>> platform_device *' from 'int' makes pointer from integer without a cast
>> [-Werror=int-conversion]
cc1: all warnings being treated as errors
--
arch/sparc/kernel/pci.c: In function 'of_create_pci_dev':
>> arch/sparc/kernel/pci.c:276:7: error: implicit declaration of function
>> 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'?
>> [-Werror=implicit-function-declaration]
276 | op = of_find_device_by_node(node);
| ^~
| bus_find_device_by_fwnode
>> arch/sparc/kernel/pci.c:276:5: error: assignment to 'struct platform_device
>> *' from 'int' makes pointer from integer without a cast
>> [-Werror=int-conversion]
276 | op = of_find_device_by_node(node);
| ^
cc1: all warnings being treated as errors
--
arch/sparc/kernel/pci_sabre.c: In function 'sabre_register_error_handlers':
>> arch/sparc/kernel/pci_sabre.c:324:7: error: implicit declaration of function
>> 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'?
>> [-Werror=implicit-function-declaration]
324 | op = of_find_device_by_node(dp);
| ^~
| bus_find_device_by_fwnode
arch/sparc/kernel/pci_sabre.c:324:5: error: assignment to 'struct
platform_device *' from 'int' makes pointer from integer without a cast
[-Werror=int-conversion]
324 | op = of_find_device_by_node(dp);
| ^
cc1: all warnings being treated as errors
--
arch/sparc/kernel/pci_schizo.c: In function
'tomatillo_register_error_handlers':
>> arch/sparc/kernel/pci_schizo.c:850:31: error: implicit declaration of
>> function 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'?
>> [-Werror=implicit-function-declaration]
850 | struct platform_device *op =
of_find_device_by_node(pbm->op->dev.of_node);
| ^~
| bus_find_device_by_fwnode
arch/sparc/kernel/pci_schizo.c:850:31: error: initialization of 'struct
platform_device *' from 'int' makes pointer from integer without a cast
[-Werror=int-conversion]
arch/sparc/kernel/pci_schizo.c: In function 'schizo_register_error_handlers':
arch/sparc/kernel/pci_schizo.c:945:31: error: initialization of 'struct
platform_device *' from 'int' makes pointer from integer without a cast
[-Werror=int-conversion]
945 | struct platform_device *op =
of_find_device_by_node(pbm->op->dev.of_node);
| ^~
cc1: all warnings being treated as errors
vim +669 arch/sparc/kernel/sbus.c
8fae097debdf8a arch/sparc64/kernel/sbus.c David S. Miller 2006-06-20 663
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 664
static int __init sbus_init(void)
576c352e89e57c arch/sparc64/kernel/sbus.c David S. Miller 2006-06-23 665 {
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 666
struct device_node *dp;
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-08-27 667
046e26a8ba10b8 arch/sparc64/kernel/sbus.c David S. Miller 2008-0
Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers
Hi Hadar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on stm32/stm32-next]
[also build test ERROR on sunxi/sunxi/for-next linus/master v5.7-rc1
next-20200416]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Hadar-Gat/of_device-removed-include-that-caused-a-recursion-in-included-headers/20200417-155422
base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git
stm32-next
config: arm-imx_v6_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
drivers/media/platform/coda/coda-common.c: In function 'coda_get_vdoa_data':
>> drivers/media/platform/coda/coda-common.c:385:14: error: implicit
>> declaration of function 'of_find_device_by_node'; did you mean
>> 'of_find_spi_device_by_node'? [-Werror=implicit-function-declaration]
385 | vdoa_pdev = of_find_device_by_node(vdoa_node);
| ^~
| of_find_spi_device_by_node
drivers/media/platform/coda/coda-common.c:385:12: warning: assignment to
'struct platform_device *' from 'int' makes pointer from integer without a cast
[-Wint-conversion]
385 | vdoa_pdev = of_find_device_by_node(vdoa_node);
|^
cc1: some warnings being treated as errors
vim +385 drivers/media/platform/coda/coda-common.c
927933f7b4b213 drivers/media/platform/coda.c Philipp Zabel
2013-09-30 374
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter
2017-01-20 375 static struct vdoa_data *coda_get_vdoa_data(void)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter
2017-01-20 376 {
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter
2017-01-20 377struct device_node *vdoa_node;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter
2017-01-20 378struct platform_device *vdoa_pdev;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter
2017-01-20 379struct vdoa_data *vdoa_data = NULL;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter
2017-01-20 380
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter
2017-01-20 381vdoa_node = of_find_compatible_node(NULL, NULL,
"fsl,imx6q-vdoa");
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter
2017-01-20 382if (!vdoa_node)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter
2017-01-20 383return NULL;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter
2017-01-20 384
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter
2017-01-20 @385vdoa_pdev = of_find_device_by_node(vdoa_node);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter
2017-01-20 386if (!vdoa_pdev)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter
2017-01-20 387goto out;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter
2017-01-20 388
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter
2017-01-20 389vdoa_data = platform_get_drvdata(vdoa_pdev);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter
2017-01-20 390if (!vdoa_data)
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter
2017-01-20 391vdoa_data = ERR_PTR(-EPROBE_DEFER);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter
2017-01-20 392
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter
2017-01-20 393 out:
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter
2017-01-20 394of_node_put(vdoa_node);
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter
2017-01-20 395
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter
2017-01-20 396return vdoa_data;
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter
2017-01-20 397 }
e7f3c548103508 drivers/media/platform/coda/coda-common.c Michael Tretter
2017-01-20 398
:: The code at line 385 was first introduced by commit
:: e7f3c54810350827823d241905fb7823eee30c21 [me
Re: [PATCH] of_device: removed #include that caused a recursion in included headers
Hi Hadar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on stm32/stm32-next]
[also build test ERROR on sunxi/sunxi/for-next tegra/for-next linus/master
v5.7-rc1 next-20200413]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Hadar-Gat/of_device-removed-include-that-caused-a-recursion-in-included-headers/20200414-032638
base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git
stm32-next
config: arm-multi_v5_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
drivers/bus/imx-weim.c: In function 'weim_parse_dt':
>> drivers/bus/imx-weim.c:227:9: error: implicit declaration of function
>> 'of_platform_default_populate' [-Werror=implicit-function-declaration]
227 | ret = of_platform_default_populate(pdev->dev.of_node,
| ^~~~
cc1: some warnings being treated as errors
--
drivers/pinctrl/freescale/pinctrl-imx1-core.c: In function
'imx1_pinctrl_core_probe':
>> drivers/pinctrl/freescale/pinctrl-imx1-core.c:639:8: error: implicit
>> declaration of function 'of_platform_populate'
>> [-Werror=implicit-function-declaration]
639 | ret = of_platform_populate(pdev->dev.of_node, NULL, NULL,
>dev);
|^~~~
cc1: some warnings being treated as errors
vim +/of_platform_default_populate +227 drivers/bus/imx-weim.c
85bf6d4e4b100e Huang Shijie 2013-05-28 189
4a92f07816ba30 Sascha Hauer 2019-08-14 190 static int
weim_parse_dt(struct platform_device *pdev, void __iomem *base)
85bf6d4e4b100e Huang Shijie 2013-05-28 191 {
3f98b6baad63b1 Alexander Shiyan 2013-06-29 192const struct
of_device_id *of_id = of_match_device(weim_id_table,
3f98b6baad63b1 Alexander Shiyan 2013-06-29 193
>dev);
3f98b6baad63b1 Alexander Shiyan 2013-06-29 194const struct
imx_weim_devtype *devtype = of_id->data;
85bf6d4e4b100e Huang Shijie 2013-05-28 195struct device_node
*child;
52c47b63412b09 Alison Chaiken2015-02-18 196int ret, have_child = 0;
c7995bcb36ef61 Sven Van Asbroeck 2018-12-17 197struct cs_timing_state
ts = {};
77266e722feabb Sven Van Asbroeck 2019-07-12 198u32 reg;
85bf6d4e4b100e Huang Shijie 2013-05-28 199
8d9ee21e98205e Shawn Guo 2014-02-11 200if (devtype ==
_weim_devtype) {
8d9ee21e98205e Shawn Guo 2014-02-11 201ret =
imx_weim_gpr_setup(pdev);
8d9ee21e98205e Shawn Guo 2014-02-11 202if (ret)
8d9ee21e98205e Shawn Guo 2014-02-11 203return
ret;
8d9ee21e98205e Shawn Guo 2014-02-11 204}
8d9ee21e98205e Shawn Guo 2014-02-11 205
77266e722feabb Sven Van Asbroeck 2019-07-12 206if
(of_property_read_bool(pdev->dev.of_node, "fsl,burst-clk-enable")) {
77266e722feabb Sven Van Asbroeck 2019-07-12 207if
(devtype->wcr_bcm) {
77266e722feabb Sven Van Asbroeck 2019-07-12 208reg =
readl(base + devtype->wcr_offset);
77266e722feabb Sven Van Asbroeck 2019-07-12 209
writel(reg | devtype->wcr_bcm,
77266e722feabb Sven Van Asbroeck 2019-07-12 210
base + devtype->wcr_offset);
77266e722feabb Sven Van Asbroeck 2019-07-12 211} else {
77266e722feabb Sven Van Asbroeck 2019-07-12 212
dev_err(>dev, "burst clk mode not supported.\n");
77266e722feabb Sven Van Asbroeck 2019-07-12 213return
-EINVAL;
77266e722feabb Sven Van Asbroeck 2019-07-12 214}
77266e722feabb Sven Van Asbroeck 2019-07-12 215}
77266e722feabb Sven Van Asbroeck 2019-07-12 216
33b96d2c957921 Fabio Estevam 2016-02-22 217
for_each_available_child_of_node(pdev->dev.of_node, child) {
c7995bcb36ef61 Sven Van Asbroeck 2018-12-17 218ret =
weim_timing_setup(>dev, child, base, devtype, );
52c47b63412b09 Alison Chaiken2015-02-18 219if (ret)
9c0982d809fd81 Rob Herring 2017-07-18 220
dev_warn(>dev, "%pOF set timing failed.\n",
9c0982d809fd81 Rob Herring
Re: [PATCH] of_device: removed #include that caused a recursion in included headers
Hi Hadar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on stm32/stm32-next]
[also build test ERROR on linus/master v5.7-rc1 next-20200413]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Hadar-Gat/of_device-removed-include-that-caused-a-recursion-in-included-headers/20200414-032638
base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git
stm32-next
config: sparc-randconfig-a001-20200413 (attached as .config)
compiler: sparc-linux-gcc (GCC) 9.3.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=9.3.0 make.cross ARCH=sparc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
arch/sparc/mm/iommu.c: In function 'iommu_init':
>> arch/sparc/mm/iommu.c:139:32: error: implicit declaration of function
>> 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'?
>> [-Werror=implicit-function-declaration]
139 | struct platform_device *op = of_find_device_by_node(dp);
|^~
|bus_find_device_by_fwnode
>> arch/sparc/mm/iommu.c:139:32: error: initialization of 'struct
>> platform_device *' from 'int' makes pointer from integer without a cast
>> [-Werror=int-conversion]
cc1: all warnings being treated as errors
--
arch/sparc/mm/io-unit.c: In function 'iounit_init':
>> arch/sparc/mm/io-unit.c:81:32: error: implicit declaration of function
>> 'of_find_device_by_node'; did you mean 'bus_find_device_by_fwnode'?
>> [-Werror=implicit-function-declaration]
81 | struct platform_device *op = of_find_device_by_node(dp);
|^~
|bus_find_device_by_fwnode
>> arch/sparc/mm/io-unit.c:81:32: error: initialization of 'struct
>> platform_device *' from 'int' makes pointer from integer without a cast
>> [-Werror=int-conversion]
cc1: all warnings being treated as errors
vim +139 arch/sparc/mm/iommu.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 133
046e26a8ba10b8 David S. Miller 2008-08-27 134 static int __init
iommu_init(void)
046e26a8ba10b8 David S. Miller 2008-08-27 135 {
046e26a8ba10b8 David S. Miller 2008-08-27 136 struct device_node *dp;
046e26a8ba10b8 David S. Miller 2008-08-27 137
046e26a8ba10b8 David S. Miller 2008-08-27 138
for_each_node_by_name(dp, "iommu") {
cd4cd7306a403f Grant Likely2010-07-22 @139 struct
platform_device *op = of_find_device_by_node(dp);
046e26a8ba10b8 David S. Miller 2008-08-27 140
046e26a8ba10b8 David S. Miller 2008-08-27 141
sbus_iommu_init(op);
046e26a8ba10b8 David S. Miller 2008-08-27 142
of_propagate_archdata(op);
046e26a8ba10b8 David S. Miller 2008-08-27 143 }
046e26a8ba10b8 David S. Miller 2008-08-27 144
046e26a8ba10b8 David S. Miller 2008-08-27 145 return 0;
046e26a8ba10b8 David S. Miller 2008-08-27 146 }
046e26a8ba10b8 David S. Miller 2008-08-27 147
:: The code at line 139 was first introduced by commit
:: cd4cd7306a403f62ef3ca783b9d1cf2a03e595ed sparc: remove references to
of_device and to_of_device
:: TO: Grant Likely
:: CC: Grant Likely
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH] of_device: removed #include that caused a recursion in included headers
Hi Hadar,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on stm32/stm32-next]
[also build test ERROR on sunxi/sunxi/for-next tegra/for-next linus/master
v5.7-rc1 next-20200413]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Hadar-Gat/of_device-removed-include-that-caused-a-recursion-in-included-headers/20200414-032638
base: https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git
stm32-next
config: x86_64-randconfig-h003-20200413 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project
8e2daa0c7f27b5d13b11bff68ae3cd42329abd6c)
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
>> drivers/clk/mediatek/clk-mt7622-aud.c:153:6: error: implicit declaration of
>> function 'devm_of_platform_populate'
>> [-Werror,-Wimplicit-function-declaration]
r = devm_of_platform_populate(>dev);
^
1 error generated.
vim +/devm_of_platform_populate +153 drivers/clk/mediatek/clk-mt7622-aud.c
2fc0a509e4ee85 Sean Wang 2017-10-05 132
2fc0a509e4ee85 Sean Wang 2017-10-05 133 static int
clk_mt7622_audiosys_init(struct platform_device *pdev)
2fc0a509e4ee85 Sean Wang 2017-10-05 134 {
2fc0a509e4ee85 Sean Wang 2017-10-05 135struct clk_onecell_data
*clk_data;
2fc0a509e4ee85 Sean Wang 2017-10-05 136struct device_node *node =
pdev->dev.of_node;
2fc0a509e4ee85 Sean Wang 2017-10-05 137int r;
2fc0a509e4ee85 Sean Wang 2017-10-05 138
2fc0a509e4ee85 Sean Wang 2017-10-05 139clk_data =
mtk_alloc_clk_data(CLK_AUDIO_NR_CLK);
2fc0a509e4ee85 Sean Wang 2017-10-05 140
2fc0a509e4ee85 Sean Wang 2017-10-05 141mtk_clk_register_gates(node,
audio_clks, ARRAY_SIZE(audio_clks),
2fc0a509e4ee85 Sean Wang 2017-10-05 142
clk_data);
2fc0a509e4ee85 Sean Wang 2017-10-05 143
2fc0a509e4ee85 Sean Wang 2017-10-05 144r = of_clk_add_provider(node,
of_clk_src_onecell_get, clk_data);
037b21133e5367 Ryder Lee 2018-03-20 145if (r) {
2fc0a509e4ee85 Sean Wang 2017-10-05 146dev_err(>dev,
2fc0a509e4ee85 Sean Wang 2017-10-05 147"could not
register clock provider: %s: %d\n",
2fc0a509e4ee85 Sean Wang 2017-10-05 148pdev->name, r);
2fc0a509e4ee85 Sean Wang 2017-10-05 149
037b21133e5367 Ryder Lee 2018-03-20 150goto err_clk_provider;
037b21133e5367 Ryder Lee 2018-03-20 151}
037b21133e5367 Ryder Lee 2018-03-20 152
037b21133e5367 Ryder Lee 2018-03-20 @153r =
devm_of_platform_populate(>dev);
037b21133e5367 Ryder Lee 2018-03-20 154if (r)
037b21133e5367 Ryder Lee 2018-03-20 155goto err_plat_populate;
037b21133e5367 Ryder Lee 2018-03-20 156
037b21133e5367 Ryder Lee 2018-03-20 157return 0;
037b21133e5367 Ryder Lee 2018-03-20 158
037b21133e5367 Ryder Lee 2018-03-20 159 err_plat_populate:
037b21133e5367 Ryder Lee 2018-03-20 160of_clk_del_provider(node);
037b21133e5367 Ryder Lee 2018-03-20 161 err_clk_provider:
2fc0a509e4ee85 Sean Wang 2017-10-05 162return r;
2fc0a509e4ee85 Sean Wang 2017-10-05 163 }
2fc0a509e4ee85 Sean Wang 2017-10-05 164
:: The code at line 153 was first introduced by commit
:: 037b21133e5367c833908db0226d77138ba4c5eb clk: mediatek: add
devm_of_platform_populate() for MT7622 audsys
:: TO: Ryder Lee
:: CC: Stephen Boyd
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v1 4/8] vfio: Check nesting iommu uAPI version
Hi Yi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on vfio/next]
[also build test ERROR on v5.6-rc6 next-20200320]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Liu-Yi-L/vfio-expose-virtual-Shared-Virtual-Addressing-to-VMs/20200322-213259
base: https://github.com/awilliam/linux-vfio.git next
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=9.2.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
drivers/vfio/vfio_iommu_type1.c: In function 'vfio_iommu_type1_ioctl':
>> drivers/vfio/vfio_iommu_type1.c:2299:11: error: implicit declaration of
>> function 'iommu_get_uapi_version' [-Werror=implicit-function-declaration]
2299 |return iommu_get_uapi_version();
| ^~
cc1: some warnings being treated as errors
vim +/iommu_get_uapi_version +2299 drivers/vfio/vfio_iommu_type1.c
2281
2282 static long vfio_iommu_type1_ioctl(void *iommu_data,
2283 unsigned int cmd, unsigned long arg)
2284 {
2285 struct vfio_iommu *iommu = iommu_data;
2286 unsigned long minsz;
2287
2288 if (cmd == VFIO_CHECK_EXTENSION) {
2289 switch (arg) {
2290 case VFIO_TYPE1_IOMMU:
2291 case VFIO_TYPE1v2_IOMMU:
2292 case VFIO_TYPE1_NESTING_IOMMU:
2293 return 1;
2294 case VFIO_DMA_CC_IOMMU:
2295 if (!iommu)
2296 return 0;
2297 return vfio_domains_have_iommu_cache(iommu);
2298 case VFIO_NESTING_IOMMU_UAPI:
> 2299 return iommu_get_uapi_version();
2300 default:
2301 return 0;
2302 }
2303 } else if (cmd == VFIO_IOMMU_GET_INFO) {
2304 struct vfio_iommu_type1_info info;
2305 struct vfio_info_cap caps = { .buf = NULL, .size = 0 };
2306 unsigned long capsz;
2307 int ret;
2308
2309 minsz = offsetofend(struct vfio_iommu_type1_info,
iova_pgsizes);
2310
2311 /* For backward compatibility, cannot require this */
2312 capsz = offsetofend(struct vfio_iommu_type1_info,
cap_offset);
2313
2314 if (copy_from_user(, (void __user *)arg, minsz))
2315 return -EFAULT;
2316
2317 if (info.argsz < minsz)
2318 return -EINVAL;
2319
2320 if (info.argsz >= capsz) {
2321 minsz = capsz;
2322 info.cap_offset = 0; /* output, no-recopy
necessary */
2323 }
2324
2325 info.flags = VFIO_IOMMU_INFO_PGSIZES;
2326
2327 info.iova_pgsizes = vfio_pgsize_bitmap(iommu);
2328
2329 ret = vfio_iommu_iova_build_caps(iommu, );
2330 if (ret)
2331 return ret;
2332
2333 ret = vfio_iommu_info_add_nesting_cap(iommu, );
2334 if (ret)
2335 return ret;
2336
2337 if (caps.size) {
2338 info.flags |= VFIO_IOMMU_INFO_CAPS;
2339
2340 if (info.argsz < sizeof(info) + caps.size) {
2341 info.argsz = sizeof(info) + caps.size;
2342 } else {
2343 vfio_info_cap_shift(,
sizeof(info));
2344 if (copy_to_user((void __user *)arg +
2345 sizeof(info), caps.buf,
2346 caps.size)) {
2347 kfree(caps.buf);
2348 return -EFAULT;
2349 }
2350 info.cap_offset = sizeof(info);
2351 }
2352
2353 kfree(caps.buf);
2354 }
2355
2356 return copy_to_user((void _
Re: [PATCH v1 6/8] vfio/type1: Bind guest page tables to host
Hi Yi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on vfio/next]
[also build test ERROR on v5.6-rc6 next-20200320]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Liu-Yi-L/vfio-expose-virtual-Shared-Virtual-Addressing-to-VMs/20200322-213259
base: https://github.com/awilliam/linux-vfio.git next
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=9.2.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
drivers/vfio/vfio_iommu_type1.c: In function 'vfio_iommu_get_stage1_format':
drivers/vfio/vfio_iommu_type1.c:2300:4: error: 'DOMAIN_ATTR_PASID_FORMAT'
undeclared (first use in this function)
2300 |DOMAIN_ATTR_PASID_FORMAT, )) {
|^~~~
drivers/vfio/vfio_iommu_type1.c:2300:4: note: each undeclared identifier is
reported only once for each function it appears in
drivers/vfio/vfio_iommu_type1.c: In function 'vfio_iommu_type1_ioctl':
drivers/vfio/vfio_iommu_type1.c:2464:11: error: implicit declaration of
function 'iommu_get_uapi_version' [-Werror=implicit-function-declaration]
2464 |return iommu_get_uapi_version();
| ^~
>> drivers/vfio/vfio_iommu_type1.c:2626:15: error: implicit declaration of
>> function 'iommu_uapi_get_data_size' [-Werror=implicit-function-declaration]
2626 | data_size = iommu_uapi_get_data_size(
| ^~~~
>> drivers/vfio/vfio_iommu_type1.c:2627:5: error: 'IOMMU_UAPI_BIND_GPASID'
>> undeclared (first use in this function)
2627 | IOMMU_UAPI_BIND_GPASID, version);
| ^~
cc1: some warnings being treated as errors
vim +/iommu_uapi_get_data_size +2626 drivers/vfio/vfio_iommu_type1.c
2446
2447 static long vfio_iommu_type1_ioctl(void *iommu_data,
2448 unsigned int cmd, unsigned long arg)
2449 {
2450 struct vfio_iommu *iommu = iommu_data;
2451 unsigned long minsz;
2452
2453 if (cmd == VFIO_CHECK_EXTENSION) {
2454 switch (arg) {
2455 case VFIO_TYPE1_IOMMU:
2456 case VFIO_TYPE1v2_IOMMU:
2457 case VFIO_TYPE1_NESTING_IOMMU:
2458 return 1;
2459 case VFIO_DMA_CC_IOMMU:
2460 if (!iommu)
2461 return 0;
2462 return vfio_domains_have_iommu_cache(iommu);
2463 case VFIO_NESTING_IOMMU_UAPI:
2464 return iommu_get_uapi_version();
2465 default:
2466 return 0;
2467 }
2468 } else if (cmd == VFIO_IOMMU_GET_INFO) {
2469 struct vfio_iommu_type1_info info;
2470 struct vfio_info_cap caps = { .buf = NULL, .size = 0 };
2471 unsigned long capsz;
2472 int ret;
2473
2474 minsz = offsetofend(struct vfio_iommu_type1_info,
iova_pgsizes);
2475
2476 /* For backward compatibility, cannot require this */
2477 capsz = offsetofend(struct vfio_iommu_type1_info,
cap_offset);
2478
2479 if (copy_from_user(, (void __user *)arg, minsz))
2480 return -EFAULT;
2481
2482 if (info.argsz < minsz)
2483 return -EINVAL;
2484
2485 if (info.argsz >= capsz) {
2486 minsz = capsz;
2487 info.cap_offset = 0; /* output, no-recopy
necessary */
2488 }
2489
2490 info.flags = VFIO_IOMMU_INFO_PGSIZES;
2491
2492 info.iova_pgsizes = vfio_pgsize_bitmap(iommu);
2493
2494 ret = vfio_iommu_iova_build_caps(iommu, );
2495 if (ret)
2496 return ret;
2497
2498 ret = vfio_iommu_info_add_nesting_cap(iommu, );
2499 if (ret)
2500 return ret;
2501
2502 if (caps.size) {
2503 info.flags |= VFIO_IOMMU_INFO_CAPS;
2504
2505 if (i
Re: [PATCH v1 2/8] vfio/type1: Add vfio_iommu_type1 parameter for quota tuning
Hi Yi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on vfio/next]
[also build test ERROR on v5.6-rc6 next-20200320]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Liu-Yi-L/vfio-expose-virtual-Shared-Virtual-Addressing-to-VMs/20200322-213259
base: https://github.com/awilliam/linux-vfio.git next
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=9.2.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
drivers/vfio/vfio.c: In function 'vfio_create_mm':
drivers/vfio/vfio.c:2149:8: error: implicit declaration of function
'ioasid_alloc_set'; did you mean 'ioasid_alloc'?
[-Werror=implicit-function-declaration]
2149 | ret = ioasid_alloc_set((struct ioasid_set *) mm,
|^~~~
|ioasid_alloc
drivers/vfio/vfio.c:2158:13: warning: assignment to 'long long unsigned int'
from 'struct mm_struct *' makes integer from pointer without a cast
[-Wint-conversion]
2158 | token->val = mm;
| ^
drivers/vfio/vfio.c: In function 'vfio_mm_unlock_and_free':
drivers/vfio/vfio.c:2170:2: error: implicit declaration of function
'ioasid_free_set'; did you mean 'ioasid_free'?
[-Werror=implicit-function-declaration]
2170 | ioasid_free_set(vmm->ioasid_sid, true);
| ^~~
| ioasid_free
drivers/vfio/vfio.c: In function 'vfio_mm_pasid_alloc':
>> drivers/vfio/vfio.c:2230:3: error: implicit declaration of function
>> 'ioasid_adjust_set' [-Werror=implicit-function-declaration]
2230 | ioasid_adjust_set(vmm->ioasid_sid, quota);
| ^
drivers/vfio/vfio.c:2233:26: warning: passing argument 1 of 'ioasid_alloc'
makes pointer from integer without a cast [-Wint-conversion]
2233 | pasid = ioasid_alloc(vmm->ioasid_sid, min, max, NULL);
| ~~~^~~~
| |
| int
In file included from include/linux/iommu.h:16,
from drivers/vfio/vfio.c:20:
include/linux/ioasid.h:45:56: note: expected 'struct ioasid_set *' but
argument is of type 'int'
45 | static inline ioasid_t ioasid_alloc(struct ioasid_set *set, ioasid_t
min,
| ~~~^~~
drivers/vfio/vfio.c: In function 'vfio_mm_pasid_free':
drivers/vfio/vfio.c:2252:25: warning: passing argument 1 of 'ioasid_find'
makes pointer from integer without a cast [-Wint-conversion]
2252 | pdata = ioasid_find(vmm->ioasid_sid, pasid, NULL);
| ~~~^~~~
| |
| int
In file included from include/linux/iommu.h:16,
from drivers/vfio/vfio.c:20:
include/linux/ioasid.h:55:52: note: expected 'struct ioasid_set *' but
argument is of type 'int'
55 | static inline void *ioasid_find(struct ioasid_set *set, ioasid_t
ioasid,
| ~~~^~~
cc1: some warnings being treated as errors
vim +/ioasid_adjust_set +2230 drivers/vfio/vfio.c
2133
2134 /**
2135 * VFIO_MM objects - create, release, get, put, search
2136 * Caller of the function should have held vfio.vfio_mm_lock.
2137 */
2138 static struct vfio_mm *vfio_create_mm(struct mm_struct *mm)
2139 {
2140 struct vfio_mm *vmm;
2141 struct vfio_mm_token *token;
2142 int ret = 0;
2143
2144 vmm = kzalloc(sizeof(*vmm), GFP_KERNEL);
2145 if (!vmm)
2146 return ERR_PTR(-ENOMEM);
2147
2148 /* Per mm IOASID set used for quota control and group
operations */
2149 ret = ioasid_alloc_set((struct ioasid_set *) mm,
2150 VFIO_DEFAULT_PASID_QUOTA,
>ioasid_sid);
2151 if (ret) {
2152 kfree(vmm);
2153 return ERR_PTR(ret);
2154 }
2155
2156 kref_init(>kref);
2157 token = >token;
> 2158 token->val = mm;
2159 vmm->pasid_quota = VFIO_DEFAULT_PASID_QUOTA;
2160 mutex_init(>pasid_lock);
2161
2162 list_add(>vfio_next, _mm_list);
2163
2164 return vmm;
2165 }
2166
2167 static void vfio
Re: [PATCH v1 5/8] vfio/type1: Report 1st-level/stage-1 format to userspace
Hi Yi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on vfio/next]
[also build test ERROR on v5.6-rc6 next-20200320]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Liu-Yi-L/vfio-expose-virtual-Shared-Virtual-Addressing-to-VMs/20200322-213259
base: https://github.com/awilliam/linux-vfio.git next
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=9.2.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
drivers/vfio/vfio_iommu_type1.c: In function 'vfio_iommu_get_stage1_format':
>> drivers/vfio/vfio_iommu_type1.c:2273:4: error: 'DOMAIN_ATTR_PASID_FORMAT'
>> undeclared (first use in this function)
2273 |DOMAIN_ATTR_PASID_FORMAT, )) {
|^~~~
drivers/vfio/vfio_iommu_type1.c:2273:4: note: each undeclared identifier is
reported only once for each function it appears in
drivers/vfio/vfio_iommu_type1.c: In function 'vfio_iommu_type1_ioctl':
drivers/vfio/vfio_iommu_type1.c:2355:11: error: implicit declaration of
function 'iommu_get_uapi_version' [-Werror=implicit-function-declaration]
2355 |return iommu_get_uapi_version();
| ^~
cc1: some warnings being treated as errors
vim +/DOMAIN_ATTR_PASID_FORMAT +2273 drivers/vfio/vfio_iommu_type1.c
2257
2258 static int vfio_iommu_get_stage1_format(struct vfio_iommu *iommu,
2259 u32 *stage1_format)
2260 {
2261 struct vfio_domain *domain;
2262 u32 format = 0, tmp_format = 0;
2263 int ret;
2264
2265 mutex_lock(>lock);
2266 if (list_empty(>domain_list)) {
2267 mutex_unlock(>lock);
2268 return -EINVAL;
2269 }
2270
2271 list_for_each_entry(domain, >domain_list, next) {
2272 if (iommu_domain_get_attr(domain->domain,
> 2273 DOMAIN_ATTR_PASID_FORMAT, )) {
2274 ret = -EINVAL;
2275 format = 0;
2276 goto out_unlock;
2277 }
2278 /*
2279 * format is always non-zero (the first format is
2280 * IOMMU_PASID_FORMAT_INTEL_VTD which is 1). For
2281 * the reason of potential different backed IOMMU
2282 * formats, here we expect to have identical formats
2283 * in the domain list, no mixed formats support.
2284 * return -EINVAL to fail the attempt of setup
2285 * VFIO_TYPE1_NESTING_IOMMU if non-identical formats
2286 * are detected.
2287 */
2288 if (tmp_format && tmp_format != format) {
2289 ret = -EINVAL;
2290 format = 0;
2291 goto out_unlock;
2292 }
2293
2294 tmp_format = format;
2295 }
2296 ret = 0;
2297
2298 out_unlock:
2299 if (format)
2300 *stage1_format = format;
2301 mutex_unlock(>lock);
2302 return ret;
2303 }
2304
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v1 1/8] vfio: Add VFIO_IOMMU_PASID_REQUEST(alloc/free)
Hi Yi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on vfio/next]
[also build test WARNING on v5.6-rc6 next-20200320]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Liu-Yi-L/vfio-expose-virtual-Shared-Virtual-Addressing-to-VMs/20200322-213259
base: https://github.com/awilliam/linux-vfio.git next
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=9.2.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All warnings (new ones prefixed by >>):
drivers/vfio/vfio.c: In function 'vfio_create_mm':
drivers/vfio/vfio.c:2149:8: error: implicit declaration of function
'ioasid_alloc_set'; did you mean 'ioasid_alloc'?
[-Werror=implicit-function-declaration]
2149 | ret = ioasid_alloc_set((struct ioasid_set *) mm,
|^~~~
|ioasid_alloc
>> drivers/vfio/vfio.c:2158:13: warning: assignment to 'long long unsigned int'
>> from 'struct mm_struct *' makes integer from pointer without a cast
>> [-Wint-conversion]
2158 | token->val = mm;
| ^
drivers/vfio/vfio.c: In function 'vfio_mm_unlock_and_free':
drivers/vfio/vfio.c:2170:2: error: implicit declaration of function
'ioasid_free_set'; did you mean 'ioasid_free'?
[-Werror=implicit-function-declaration]
2170 | ioasid_free_set(vmm->ioasid_sid, true);
| ^~~
| ioasid_free
drivers/vfio/vfio.c: In function 'vfio_mm_pasid_alloc':
drivers/vfio/vfio.c:2227:26: warning: passing argument 1 of 'ioasid_alloc'
makes pointer from integer without a cast [-Wint-conversion]
2227 | pasid = ioasid_alloc(vmm->ioasid_sid, min, max, NULL);
| ~~~^~~~
| |
| int
In file included from include/linux/iommu.h:16,
from drivers/vfio/vfio.c:20:
include/linux/ioasid.h:45:56: note: expected 'struct ioasid_set *' but
argument is of type 'int'
45 | static inline ioasid_t ioasid_alloc(struct ioasid_set *set, ioasid_t
min,
| ~~~^~~
drivers/vfio/vfio.c: In function 'vfio_mm_pasid_free':
drivers/vfio/vfio.c:2246:25: warning: passing argument 1 of 'ioasid_find'
makes pointer from integer without a cast [-Wint-conversion]
2246 | pdata = ioasid_find(vmm->ioasid_sid, pasid, NULL);
| ~~~^~~~
| |
| int
In file included from include/linux/iommu.h:16,
from drivers/vfio/vfio.c:20:
include/linux/ioasid.h:55:52: note: expected 'struct ioasid_set *' but
argument is of type 'int'
55 | static inline void *ioasid_find(struct ioasid_set *set, ioasid_t
ioasid,
| ~~~^~~
cc1: some warnings being treated as errors
vim +2158 drivers/vfio/vfio.c
2133
2134 /**
2135 * VFIO_MM objects - create, release, get, put, search
2136 * Caller of the function should have held vfio.vfio_mm_lock.
2137 */
2138 static struct vfio_mm *vfio_create_mm(struct mm_struct *mm)
2139 {
2140 struct vfio_mm *vmm;
2141 struct vfio_mm_token *token;
2142 int ret = 0;
2143
2144 vmm = kzalloc(sizeof(*vmm), GFP_KERNEL);
2145 if (!vmm)
2146 return ERR_PTR(-ENOMEM);
2147
2148 /* Per mm IOASID set used for quota control and group
operations */
2149 ret = ioasid_alloc_set((struct ioasid_set *) mm,
2150 VFIO_DEFAULT_PASID_QUOTA,
>ioasid_sid);
2151 if (ret) {
2152 kfree(vmm);
2153 return ERR_PTR(ret);
2154 }
2155
2156 kref_init(>kref);
2157 token = >token;
> 2158 token->val = mm;
2159 vmm->pasid_quota = VFIO_DEFAULT_PASID_QUOTA;
2160 mutex_init(>pasid_lock);
2161
2162 list_add(>vfio_next, _mm_list);
2163
2164 return vmm;
2165 }
2166
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-found
Re: [PATCH v10 01/11] vfio: VFIO_IOMMU_SET_PASID_TABLE
Hi Eric,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on vfio/next]
[also build test ERROR on v5.6-rc6 next-20200320]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Eric-Auger/SMMUv3-Nested-Stage-Setup-VFIO-part/20200321-040935
base: https://github.com/awilliam/linux-vfio.git next
config: arm64-randconfig-a001-20200321 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=9.2.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
In file included from include/linux/vfio.h:16,
from drivers/vfio/vfio.c:32:
>> include/uapi/linux/vfio.h:811:34: error: field 'config' has incomplete type
811 | struct iommu_pasid_table_config config; /* used on SET */
| ^~
--
In file included from include/linux/vfio.h:16,
from drivers/vfio/vfio_iommu_type1.c:35:
>> include/uapi/linux/vfio.h:811:34: error: field 'config' has incomplete type
811 | struct iommu_pasid_table_config config; /* used on SET */
| ^~
drivers/vfio/vfio_iommu_type1.c: In function 'vfio_detach_pasid_table':
>> drivers/vfio/vfio_iommu_type1.c:2204:3: error: implicit declaration of
>> function 'iommu_detach_pasid_table'; did you mean 'vfio_detach_pasid_table'?
>> [-Werror=implicit-function-declaration]
2204 | iommu_detach_pasid_table(d->domain);
| ^~~~
| vfio_detach_pasid_table
drivers/vfio/vfio_iommu_type1.c: In function 'vfio_attach_pasid_table':
>> drivers/vfio/vfio_iommu_type1.c:2219:9: error: implicit declaration of
>> function 'iommu_attach_pasid_table'; did you mean 'vfio_attach_pasid_table'?
>> [-Werror=implicit-function-declaration]
2219 | ret = iommu_attach_pasid_table(d->domain, >config);
| ^~~~
| vfio_attach_pasid_table
cc1: some warnings being treated as errors
vim +/config +811 include/uapi/linux/vfio.h
797
798 /**
799 * VFIO_IOMMU_SET_PASID_TABLE - _IOWR(VFIO_TYPE, VFIO_BASE + 22,
800 * struct vfio_iommu_type1_set_pasid_table)
801 *
802 * The SET operation passes a PASID table to the host while the
803 * UNSET operation detaches the one currently programmed. Setting
804 * a table while another is already programmed replaces the old table.
805 */
806 struct vfio_iommu_type1_set_pasid_table {
807 __u32 argsz;
808 __u32 flags;
809 #define VFIO_PASID_TABLE_FLAG_SET (1 << 0)
810 #define VFIO_PASID_TABLE_FLAG_UNSET (1 << 1)
> 811 struct iommu_pasid_table_config config; /* used on SET */
812 };
813
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v10 09/13] dma-iommu: Implement NESTED_MSI cookie
Hi Eric,
I love your patch! Yet something to improve:
[auto build test ERROR on iommu/next]
[also build test ERROR on linus/master v5.6-rc6 next-20200320]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Eric-Auger/SMMUv3-Nested-Stage-Setup-IOMMU-part/20200321-040627
base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: arm-exynos_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=9.2.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
In file included from drivers/gpu/drm/exynos/exynos_drm_dma.c:7:
>> include/linux/dma-iommu.h:90:1: error: expected identifier or '(' before '{'
>> token
90 | {
| ^
In file included from drivers/gpu/drm/exynos/exynos_drm_dma.c:7:
include/linux/dma-iommu.h:89:1: warning: 'iommu_dma_unbind_guest_msi'
declared 'static' but never defined [-Wunused-function]
89 | iommu_dma_unbind_guest_msi(struct iommu_domain *domain, dma_addr_t
giova);
| ^~
vim +90 include/linux/dma-iommu.h
87
88 static inline void
89 iommu_dma_unbind_guest_msi(struct iommu_domain *domain, dma_addr_t
giova);
> 90 {
91 }
92
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH] treewide: Rename "unencrypted" to "decrypted"
Hi Borislav, I love your patch! Yet something to improve: [auto build test ERROR on tip/x86/mm] [cannot apply to linux/master powerpc/next s390/features tip/x86/core linus/master v5.6-rc6 next-20200317] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Borislav-Petkov/treewide-Rename-unencrypted-to-decrypted/20200318-015738 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 17c4a2ae15a7aaefe84bdb271952678c5c9cd8e1 config: powerpc-defconfig (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=9.2.0 make.cross ARCH=powerpc If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): powerpc64-linux-ld: warning: orphan section `.gnu.hash' from `linker stubs' being placed in section `.gnu.hash' powerpc64-linux-ld: kernel/dma/mapping.o: in function `.dma_pgprot': >> mapping.c:(.text+0xc5c): undefined reference to `.force_dma_decrypted' powerpc64-linux-ld: kernel/dma/mapping.o: in function `.dma_common_mmap': mapping.c:(.text+0xcfc): undefined reference to `.force_dma_decrypted' powerpc64-linux-ld: kernel/dma/direct.o: in function `.dma_direct_get_required_mask': >> direct.c:(.text+0x920): undefined reference to `.force_dma_decrypted' powerpc64-linux-ld: kernel/dma/direct.o: in function `.__dma_direct_alloc_pages': direct.c:(.text+0x9fc): undefined reference to `.force_dma_decrypted' >> powerpc64-linux-ld: direct.c:(.text+0xaa8): undefined reference to >> `.force_dma_decrypted' powerpc64-linux-ld: kernel/dma/direct.o:direct.c:(.text+0xb28): more undefined references to `.force_dma_decrypted' follow --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH] treewide: Rename "unencrypted" to "decrypted"
Hi Borislav, I love your patch! Yet something to improve: [auto build test ERROR on tip/x86/mm] [cannot apply to linux/master powerpc/next s390/features tip/x86/core linus/master v5.6-rc6 next-20200317] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Borislav-Petkov/treewide-Rename-unencrypted-to-decrypted/20200318-015738 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 17c4a2ae15a7aaefe84bdb271952678c5c9cd8e1 config: s390-zfcpdump_defconfig (attached as .config) compiler: s390-linux-gcc (GCC) 9.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=9.2.0 make.cross ARCH=s390 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): s390-linux-ld: kernel/dma/mapping.o: in function `dma_pgprot': mapping.c:(.text+0x144): undefined reference to `force_dma_decrypted' s390-linux-ld: kernel/dma/mapping.o: in function `dma_common_mmap': mapping.c:(.text+0x1a4): undefined reference to `force_dma_decrypted' s390-linux-ld: kernel/dma/direct.o: in function `dma_direct_get_required_mask': direct.c:(.text+0xae): undefined reference to `force_dma_decrypted' s390-linux-ld: kernel/dma/direct.o: in function `__dma_direct_alloc_pages': direct.c:(.text+0x152): undefined reference to `force_dma_decrypted' >> s390-linux-ld: direct.c:(.text+0x1e8): undefined reference to >> `force_dma_decrypted' s390-linux-ld: kernel/dma/direct.o:direct.c:(.text+0x2e0): more undefined references to `force_dma_decrypted' follow --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org .config.gz Description: application/gzip ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
[iommu:arm/omap 4/4] drivers/gpu/drm/rockchip/rockchip_drm_gem.c:134:20: error: implicit declaration of function 'vmap'; did you mean 'bmap'?
tree: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git arm/omap
head: e93a1695d7fb551376b1c1220a267d032b6ad159
commit: e93a1695d7fb551376b1c1220a267d032b6ad159 [4/4] iommu: Enable compile
testing for some of drivers
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.5.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout e93a1695d7fb551376b1c1220a267d032b6ad159
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=sparc
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
drivers/gpu/drm/rockchip/rockchip_drm_gem.c: In function
'rockchip_gem_alloc_iommu':
>> drivers/gpu/drm/rockchip/rockchip_drm_gem.c:134:20: error: implicit
>> declaration of function 'vmap'; did you mean 'bmap'?
>> [-Werror=implicit-function-declaration]
rk_obj->kvaddr = vmap(rk_obj->pages, rk_obj->num_pages, VM_MAP,
^~~~
bmap
>> drivers/gpu/drm/rockchip/rockchip_drm_gem.c:134:59: error: 'VM_MAP'
>> undeclared (first use in this function); did you mean 'VM_MPX'?
rk_obj->kvaddr = vmap(rk_obj->pages, rk_obj->num_pages, VM_MAP,
^~
VM_MPX
drivers/gpu/drm/rockchip/rockchip_drm_gem.c:134:59: note: each undeclared
identifier is reported only once for each function it appears in
drivers/gpu/drm/rockchip/rockchip_drm_gem.c: In function
'rockchip_gem_free_iommu':
>> drivers/gpu/drm/rockchip/rockchip_drm_gem.c:190:2: error: implicit
>> declaration of function 'vunmap'; did you mean 'iounmap'?
>> [-Werror=implicit-function-declaration]
vunmap(rk_obj->kvaddr);
^~
iounmap
drivers/gpu/drm/rockchip/rockchip_drm_gem.c: In function
'rockchip_gem_prime_vmap':
drivers/gpu/drm/rockchip/rockchip_drm_gem.c:547:49: error: 'VM_MAP'
undeclared (first use in this function); did you mean 'VM_MPX'?
return vmap(rk_obj->pages, rk_obj->num_pages, VM_MAP,
^~
VM_MPX
cc1: some warnings being treated as errors
vim +134 drivers/gpu/drm/rockchip/rockchip_drm_gem.c
38f993b7c59e261 Tomasz Figa 2016-06-24 119
38f993b7c59e261 Tomasz Figa 2016-06-24 120 static int
rockchip_gem_alloc_iommu(struct rockchip_gem_object *rk_obj,
38f993b7c59e261 Tomasz Figa 2016-06-24 121
bool alloc_kmap)
38f993b7c59e261 Tomasz Figa 2016-06-24 122 {
38f993b7c59e261 Tomasz Figa 2016-06-24 123 int ret;
38f993b7c59e261 Tomasz Figa 2016-06-24 124
38f993b7c59e261 Tomasz Figa 2016-06-24 125 ret =
rockchip_gem_get_pages(rk_obj);
38f993b7c59e261 Tomasz Figa 2016-06-24 126 if (ret < 0)
38f993b7c59e261 Tomasz Figa 2016-06-24 127 return ret;
38f993b7c59e261 Tomasz Figa 2016-06-24 128
38f993b7c59e261 Tomasz Figa 2016-06-24 129 ret =
rockchip_gem_iommu_map(rk_obj);
38f993b7c59e261 Tomasz Figa 2016-06-24 130 if (ret < 0)
38f993b7c59e261 Tomasz Figa 2016-06-24 131 goto err_free;
38f993b7c59e261 Tomasz Figa 2016-06-24 132
38f993b7c59e261 Tomasz Figa 2016-06-24 133 if (alloc_kmap) {
38f993b7c59e261 Tomasz Figa 2016-06-24 @134 rk_obj->kvaddr
= vmap(rk_obj->pages, rk_obj->num_pages, VM_MAP,
38f993b7c59e261 Tomasz Figa 2016-06-24 135
pgprot_writecombine(PAGE_KERNEL));
38f993b7c59e261 Tomasz Figa 2016-06-24 136 if
(!rk_obj->kvaddr) {
38f993b7c59e261 Tomasz Figa 2016-06-24 137
DRM_ERROR("failed to vmap() buffer\n");
38f993b7c59e261 Tomasz Figa 2016-06-24 138 ret =
-ENOMEM;
38f993b7c59e261 Tomasz Figa 2016-06-24 139 goto
err_unmap;
38f993b7c59e261 Tomasz Figa 2016-06-24 140 }
38f993b7c59e261 Tomasz Figa 2016-06-24 141 }
38f993b7c59e261 Tomasz Figa 2016-06-24 142
38f993b7c59e261 Tomasz Figa 2016-06-24 143 return 0;
38f993b7c59e261 Tomasz Figa 2016-06-24 144
38f993b7c59e261 Tomasz Figa 2016-06-24 145 err_unmap:
38f993b7c59e261 Tomasz Figa 2016-06-24 146
rockchip_gem_iommu_unmap(rk_obj);
38f993b7c59e261 Tomasz Figa 2016-06-24 147 err_free:
38f993b7c59e261 Tomasz Figa 2016-06-24 148
rockchip_gem_put_pages(rk_obj);
38f993b7c59e261 Tomasz Figa 2016-06-24 149
38f993b7c5
Re: [PATCH v2 3/3] iommu/virtio: Enable x86 support
Hi Jean-Philippe,
I love your patch! Perhaps something to improve:
[auto build test WARNING on iommu/next]
[cannot apply to pci/next linus/master v5.6-rc3 next-20200228]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Jean-Philippe-Brucker/virtio-iommu-on-x86-and-non-devicetree-platforms/20200229-085019
base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-173-ge0787745-dirty
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
>> drivers/iommu/virtio-iommu.c:1024:9: sparse: sparse: incompatible types in
>> comparison expression (different base types):
>> drivers/iommu/virtio-iommu.c:1024:9: sparse:restricted __le64 *
>> drivers/iommu/virtio-iommu.c:1024:9: sparse:unsigned long long *
drivers/iommu/virtio-iommu.c:1036:9: sparse: sparse: incompatible types in
comparison expression (different base types):
drivers/iommu/virtio-iommu.c:1036:9: sparse:restricted __le64 *
drivers/iommu/virtio-iommu.c:1036:9: sparse:unsigned long long *
drivers/iommu/virtio-iommu.c:1040:9: sparse: sparse: incompatible types in
comparison expression (different base types):
drivers/iommu/virtio-iommu.c:1040:9: sparse:restricted __le64 *
drivers/iommu/virtio-iommu.c:1040:9: sparse:unsigned long long *
drivers/iommu/virtio-iommu.c:1044:9: sparse: sparse: incompatible types in
comparison expression (different base types):
>> drivers/iommu/virtio-iommu.c:1044:9: sparse:restricted __le32 *
>> drivers/iommu/virtio-iommu.c:1044:9: sparse:unsigned int *
drivers/iommu/virtio-iommu.c:1048:9: sparse: sparse: incompatible types in
comparison expression (different base types):
drivers/iommu/virtio-iommu.c:1048:9: sparse:restricted __le32 *
drivers/iommu/virtio-iommu.c:1048:9: sparse:unsigned int *
drivers/iommu/virtio-iommu.c:1052:9: sparse: sparse: incompatible types in
comparison expression (different base types):
drivers/iommu/virtio-iommu.c:1052:9: sparse:restricted __le32 *
drivers/iommu/virtio-iommu.c:1052:9: sparse:unsigned int *
vim +1024 drivers/iommu/virtio-iommu.c
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 996
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 997 static int
viommu_probe(struct virtio_device *vdev)
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 998 {
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 999 struct device
*parent_dev = vdev->dev.parent;
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1000 struct viommu_dev
*viommu = NULL;
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1001 struct device *dev =
>dev;
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1002 u64 input_start = 0;
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1003 u64 input_end = -1UL;
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1004 int ret;
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1005
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1006 if
(!virtio_has_feature(vdev, VIRTIO_F_VERSION_1) ||
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1007
!virtio_has_feature(vdev, VIRTIO_IOMMU_F_MAP_UNMAP))
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1008 return -ENODEV;
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1009
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1010 viommu =
devm_kzalloc(dev, sizeof(*viommu), GFP_KERNEL);
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1011 if (!viommu)
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1012 return -ENOMEM;
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1013
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1014
spin_lock_init(>request_lock);
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1015
ida_init(>domain_ids);
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1016 viommu->dev = dev;
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1017 viommu->vdev = vdev;
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1018
INIT_LIST_HEAD(>requests);
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1019
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1020 ret =
viommu_init_vqs(viommu);
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1021 if (ret)
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1022 return ret;
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 1023
edcd69ab9a323b Jean-Philippe Brucker 2019-01-15 @1024 virtio_cread(vdev,
struct virtio_iommu_config, page_size_mask,
edcd69ab9a323b Jean-P
Re: [PATCH 02/14] drm/msm/mdp5: Remove direct access of dev->iommu_fwspec
Hi Joerg,
I love your patch! Yet something to improve:
[auto build test ERROR on pm/linux-next]
[also build test ERROR on tegra/for-next linux/master linus/master v5.6-rc3
next-20200228]
[cannot apply to iommu/next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Joerg-Roedel/iommu-Move-iommu_fwspec-out-of-struct-device/20200229-075740
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git
linux-next
config: arm-imx_v6_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c: In function 'mdp5_kms_init':
>> drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c:728:8: error: implicit declaration
>> of function 'dev_iommu_fwspec_get'; did you mean 'iommu_fwspec_free'?
>> [-Werror=implicit-function-declaration]
if (!dev_iommu_fwspec_get(iommu_dev))
^~~~
iommu_fwspec_free
cc1: some warnings being treated as errors
vim +728 drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c
677
678 struct msm_kms *mdp5_kms_init(struct drm_device *dev)
679 {
680 struct msm_drm_private *priv = dev->dev_private;
681 struct platform_device *pdev;
682 struct mdp5_kms *mdp5_kms;
683 struct mdp5_cfg *config;
684 struct msm_kms *kms;
685 struct msm_gem_address_space *aspace;
686 int irq, i, ret;
687 struct device *iommu_dev;
688
689 /* priv->kms would have been populated by the MDP5 driver */
690 kms = priv->kms;
691 if (!kms)
692 return NULL;
693
694 mdp5_kms = to_mdp5_kms(to_mdp_kms(kms));
695
696 mdp_kms_init(_kms->base, _funcs);
697
698 pdev = mdp5_kms->pdev;
699
700 irq = irq_of_parse_and_map(pdev->dev.of_node, 0);
701 if (irq < 0) {
702 ret = irq;
703 DRM_DEV_ERROR(>dev, "failed to get irq: %d\n",
ret);
704 goto fail;
705 }
706
707 kms->irq = irq;
708
709 config = mdp5_cfg_get_config(mdp5_kms->cfg);
710
711 /* make sure things are off before attaching iommu (bootloader
could
712 * have left things on, in which case we'll start getting
faults if
713 * we don't disable):
714 */
715 pm_runtime_get_sync(>dev);
716 for (i = 0; i < MDP5_INTF_NUM_MAX; i++) {
717 if
(mdp5_cfg_intf_is_virtual(config->hw->intf.connect[i]) ||
718 !config->hw->intf.base[i])
719 continue;
720 mdp5_write(mdp5_kms, REG_MDP5_INTF_TIMING_ENGINE_EN(i),
0);
721
722 mdp5_write(mdp5_kms,
REG_MDP5_INTF_FRAME_LINE_COUNT_EN(i), 0x3);
723 }
724 mdelay(16);
725
726 if (config->platform.iommu) {
727 iommu_dev = >dev;
> 728 if (!dev_iommu_fwspec_get(iommu_dev))
729 iommu_dev = iommu_dev->parent;
730
731 aspace = msm_gem_address_space_create(iommu_dev,
732 config->platform.iommu, "mdp5");
733 if (IS_ERR(aspace)) {
734 ret = PTR_ERR(aspace);
735 goto fail;
736 }
737
738 kms->aspace = aspace;
739
740 ret = aspace->mmu->funcs->attach(aspace->mmu);
741 if (ret) {
742 DRM_DEV_ERROR(>dev, "failed to attach
iommu: %d\n",
743 ret);
744 goto fail;
745 }
746 } else {
747 DRM_DEV_INFO(>dev,
748 "no iommu, fallback to phys contig buffers for
scanout\n");
749 aspace = NULL;
750 }
751
752 pm_runtime_put_sync(>dev);
753
754 ret = modeset_init(mdp5_kms);
755 if (ret) {
756
Re: [PATCH 3/3] iommu: Enable compile testing for some of drivers
Hi Krzysztof, I love your patch! Perhaps something to improve: [auto build test WARNING on iommu/next] [also build test WARNING on v5.5-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Krzysztof-Kozlowski/iommu-omap-Fix-pointer-cast-Wpointer-to-int-cast-warnings-on-64-bit/20191231-022212 base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 7.5.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.5.0 make.cross ARCH=ia64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All warnings (new ones prefixed by >>): In file included from drivers/iommu/omap-iommu.c:33:0: drivers/iommu/omap-iommu.c: In function 'omap_iommu_iova_to_phys': >> drivers/iommu/omap-iopgtable.h:44:21: warning: large integer implicitly >> truncated to unsigned type [-Woverflow] #define IOPTE_MASK (~(IOPTE_SIZE - 1)) ^ >> drivers/iommu/omap-iommu.c:1641:41: note: in expansion of macro 'IOPTE_MASK' ret = omap_iommu_translate(*pte, da, IOPTE_MASK); ^~ drivers/iommu/omap-iopgtable.h:51:23: warning: large integer implicitly truncated to unsigned type [-Woverflow] #define IOLARGE_MASK (~(IOLARGE_SIZE - 1)) ^ >> drivers/iommu/omap-iommu.c:1643:41: note: in expansion of macro >> 'IOLARGE_MASK' ret = omap_iommu_translate(*pte, da, IOLARGE_MASK); ^~~~ drivers/iommu/omap-iopgtable.h:27:25: warning: large integer implicitly truncated to unsigned type [-Woverflow] #define IOSECTION_MASK (~(IOSECTION_SIZE - 1)) ^ >> drivers/iommu/omap-iommu.c:1649:41: note: in expansion of macro >> 'IOSECTION_MASK' ret = omap_iommu_translate(*pgd, da, IOSECTION_MASK); ^~ drivers/iommu/omap-iopgtable.h:34:23: warning: large integer implicitly truncated to unsigned type [-Woverflow] #define IOSUPER_MASK (~(IOSUPER_SIZE - 1)) ^ >> drivers/iommu/omap-iommu.c:1651:41: note: in expansion of macro >> 'IOSUPER_MASK' ret = omap_iommu_translate(*pgd, da, IOSUPER_MASK); ^~~~ vim +44 drivers/iommu/omap-iopgtable.h 97ec7d585b33bb arch/arm/plat-omap/iopgtable.h Hiroshi DOYU 2010-02-15 38 97ec7d585b33bb arch/arm/plat-omap/iopgtable.h Hiroshi DOYU 2010-02-15 39 /* 97ec7d585b33bb arch/arm/plat-omap/iopgtable.h Hiroshi DOYU 2010-02-15 40 * "small page" address mask and size definitions. 97ec7d585b33bb arch/arm/plat-omap/iopgtable.h Hiroshi DOYU 2010-02-15 41 */ a9dcad5e375800 arch/arm/plat-omap/iopgtable.h Hiroshi DOYU 2009-01-26 42 #define IOPTE_SHIFT 12 5ff98fa68c88d7 drivers/iommu/omap-iopgtable.h Suman Anna 2015-07-20 43 #define IOPTE_SIZE BIT(IOPTE_SHIFT) a9dcad5e375800 arch/arm/plat-omap/iopgtable.h Hiroshi DOYU 2009-01-26 @44 #define IOPTE_MASK (~(IOPTE_SIZE - 1)) a9dcad5e375800 arch/arm/plat-omap/iopgtable.h Hiroshi DOYU 2009-01-26 45 :: The code at line 44 was first introduced by commit :: a9dcad5e375800fcb07f7617dba23b3aade8f09d omap iommu: tlb and pagetable primitives :: TO: Hiroshi DOYU :: CC: Hiroshi DOYU --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org Intel Corporation .config.gz Description: application/gzip ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 3/3] iommu: Enable compile testing for some of drivers
Hi Krzysztof,
I love your patch! Yet something to improve:
[auto build test ERROR on iommu/next]
[also build test ERROR on v5.5-rc4 next-20191219]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Krzysztof-Kozlowski/iommu-omap-Fix-pointer-cast-Wpointer-to-int-cast-warnings-on-64-bit/20191231-022212
base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.5.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
drivers/gpu/drm/rockchip/rockchip_drm_gem.c: In function
'rockchip_gem_alloc_iommu':
>> drivers/gpu/drm/rockchip/rockchip_drm_gem.c:134:20: error: implicit
>> declaration of function 'vmap'; did you mean 'bmap'?
>> [-Werror=implicit-function-declaration]
rk_obj->kvaddr = vmap(rk_obj->pages, rk_obj->num_pages, VM_MAP,
^~~~
bmap
>> drivers/gpu/drm/rockchip/rockchip_drm_gem.c:134:59: error: 'VM_MAP'
>> undeclared (first use in this function); did you mean 'VM_MPX'?
rk_obj->kvaddr = vmap(rk_obj->pages, rk_obj->num_pages, VM_MAP,
^~
VM_MPX
drivers/gpu/drm/rockchip/rockchip_drm_gem.c:134:59: note: each undeclared
identifier is reported only once for each function it appears in
drivers/gpu/drm/rockchip/rockchip_drm_gem.c: In function
'rockchip_gem_free_iommu':
>> drivers/gpu/drm/rockchip/rockchip_drm_gem.c:190:2: error: implicit
>> declaration of function 'vunmap'; did you mean 'iounmap'?
>> [-Werror=implicit-function-declaration]
vunmap(rk_obj->kvaddr);
^~
iounmap
drivers/gpu/drm/rockchip/rockchip_drm_gem.c: In function
'rockchip_gem_prime_vmap':
drivers/gpu/drm/rockchip/rockchip_drm_gem.c:547:49: error: 'VM_MAP'
undeclared (first use in this function); did you mean 'VM_MPX'?
return vmap(rk_obj->pages, rk_obj->num_pages, VM_MAP,
^~
VM_MPX
cc1: some warnings being treated as errors
vim +134 drivers/gpu/drm/rockchip/rockchip_drm_gem.c
38f993b7c59e26 Tomasz Figa 2016-06-24 119
38f993b7c59e26 Tomasz Figa 2016-06-24 120 static int
rockchip_gem_alloc_iommu(struct rockchip_gem_object *rk_obj,
38f993b7c59e26 Tomasz Figa 2016-06-24 121
bool alloc_kmap)
38f993b7c59e26 Tomasz Figa 2016-06-24 122 {
38f993b7c59e26 Tomasz Figa 2016-06-24 123 int ret;
38f993b7c59e26 Tomasz Figa 2016-06-24 124
38f993b7c59e26 Tomasz Figa 2016-06-24 125 ret =
rockchip_gem_get_pages(rk_obj);
38f993b7c59e26 Tomasz Figa 2016-06-24 126 if (ret < 0)
38f993b7c59e26 Tomasz Figa 2016-06-24 127 return ret;
38f993b7c59e26 Tomasz Figa 2016-06-24 128
38f993b7c59e26 Tomasz Figa 2016-06-24 129 ret =
rockchip_gem_iommu_map(rk_obj);
38f993b7c59e26 Tomasz Figa 2016-06-24 130 if (ret < 0)
38f993b7c59e26 Tomasz Figa 2016-06-24 131 goto err_free;
38f993b7c59e26 Tomasz Figa 2016-06-24 132
38f993b7c59e26 Tomasz Figa 2016-06-24 133 if (alloc_kmap) {
38f993b7c59e26 Tomasz Figa 2016-06-24 @134 rk_obj->kvaddr
= vmap(rk_obj->pages, rk_obj->num_pages, VM_MAP,
38f993b7c59e26 Tomasz Figa 2016-06-24 135
pgprot_writecombine(PAGE_KERNEL));
38f993b7c59e26 Tomasz Figa 2016-06-24 136 if
(!rk_obj->kvaddr) {
38f993b7c59e26 Tomasz Figa 2016-06-24 137
DRM_ERROR("failed to vmap() buffer\n");
38f993b7c59e26 Tomasz Figa 2016-06-24 138 ret =
-ENOMEM;
38f993b7c59e26 Tomasz Figa 2016-06-24 139 goto
err_unmap;
38f993b7c59e26 Tomasz Figa 2016-06-24 140 }
38f993b7c59e26 Tomasz Figa 2016-06-24 141 }
38f993b7c59e26 Tomasz Figa 2016-06-24 142
38f993b7c59e26 Tomasz Figa 2016-06-24 143 return 0;
38f993b7c59e26 Tomasz Figa 2016-06-24 144
38f993b7c59e26 Tomasz Figa 2016-06-24 145 err_unm
Re: [PATCH 6/8] iommu: allow the dma-iommu api to use bounce buffers
Hi Tom,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on rockchip/for-next]
[cannot apply to iommu/next tegra/for-next vfio/next linus/master v5.5-rc3
next-20191219]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Tom-Murphy/Convert-the-intel-iommu-driver-to-the-dma-iommu-api/20191224-171249
base:
https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git
for-next
config: x86_64-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.5.0-3) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All warnings (new ones prefixed by >>):
drivers//iommu/dma-iommu.c: In function '__iommu_dma_map':
>> drivers//iommu/dma-iommu.c:568:3: warning: ISO C90 forbids mixed
>> declarations and code [-Wdeclaration-after-statement]
void *padding_start = phys_to_virt(phys);
^~~~
vim +568 drivers//iommu/dma-iommu.c
537
538 static dma_addr_t __iommu_dma_map(struct device *dev, phys_addr_t phys,
539 size_t org_size, dma_addr_t dma_mask, bool coherent,
540 enum dma_data_direction dir, unsigned long attrs)
541 {
542 int prot = dma_info_to_prot(dir, coherent, attrs);
543 struct iommu_domain *domain = iommu_get_dma_domain(dev);
544 struct iommu_dma_cookie *cookie = domain->iova_cookie;
545 struct iova_domain *iovad = >iovad;
546 size_t iova_off = iova_offset(iovad, phys);
547 size_t aligned_size = iova_align(iovad, org_size + iova_off);
548 dma_addr_t iova;
549
550 if (unlikely(iommu_dma_deferred_attach(dev, domain)))
551 return DMA_MAPPING_ERROR;
552
553 #ifdef CONFIG_SWIOTLB
554 /*
555 * If both the physical buffer start address and size are
556 * page aligned, we don't need to use a bounce page.
557 */
558 if (iommu_needs_bounce_buffer(dev)
559 && !iova_offset(iovad, phys | org_size)) {
560 phys = swiotlb_tbl_map_single(dev,
561 __phys_to_dma(dev, io_tlb_start),
562 phys, org_size, aligned_size, dir,
attrs);
563
564 if (phys == DMA_MAPPING_ERROR)
565 return DMA_MAPPING_ERROR;
566
567 /* Cleanup the padding area. */
> 568 void *padding_start = phys_to_virt(phys);
569 size_t padding_size = aligned_size;
570
571 if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC) &&
572 (dir == DMA_TO_DEVICE ||
573 dir == DMA_BIDIRECTIONAL)) {
574 padding_start += org_size;
575 padding_size -= org_size;
576 }
577
578 memset(padding_start, 0, padding_size);
579 }
580 #endif
581
582 iova = iommu_dma_alloc_iova(domain, aligned_size, dma_mask,
dev);
583 if (!iova)
584 return DMA_MAPPING_ERROR;
585
586 if (iommu_map_atomic(domain, iova, phys - iova_off,
aligned_size,
587 prot)) {
588
589 if (unlikely(is_swiotlb_buffer(phys)))
590 swiotlb_tbl_unmap_single(dev, phys,
aligned_size,
591 aligned_size, dir, attrs);
592 iommu_dma_free_iova(cookie, iova, aligned_size, NULL);
593 return DMA_MAPPING_ERROR;
594 }
595 return iova + iova_off;
596 }
597
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [RESEND PATCH v9 2/4] uacce: add uacce driver
Hi Zhangfei,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on cryptodev/master]
[also build test ERROR on crypto/master char-misc/char-misc-testing v5.5-rc1
next-20191210]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Zhangfei-Gao/Add-uacce-module-for-Accelerator/20191210-160210
base:
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.5.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
drivers/misc/uacce/uacce.c:112:15: error: variable 'uacce_sva_ops' has
initializer but incomplete type
static struct iommu_sva_ops uacce_sva_ops = {
^
drivers/misc/uacce/uacce.c:113:3: error: 'struct iommu_sva_ops' has no
member named 'mm_exit'
.mm_exit = uacce_sva_exit,
^~~
drivers/misc/uacce/uacce.c:113:13: warning: excess elements in struct
initializer
.mm_exit = uacce_sva_exit,
^~
drivers/misc/uacce/uacce.c:113:13: note: (near initialization for
'uacce_sva_ops')
drivers/misc/uacce/uacce.c: In function 'uacce_mm_get':
drivers/misc/uacce/uacce.c:144:12: error: implicit declaration of function
'iommu_sva_bind_device'; did you mean 'bus_find_device'?
[-Werror=implicit-function-declaration]
handle = iommu_sva_bind_device(uacce->parent, mm, uacce_mm);
^
bus_find_device
drivers/misc/uacce/uacce.c:144:10: warning: assignment makes pointer from
integer without a cast [-Wint-conversion]
handle = iommu_sva_bind_device(uacce->parent, mm, uacce_mm);
^
drivers/misc/uacce/uacce.c:148:9: error: implicit declaration of function
'iommu_sva_set_ops'; did you mean 'iommu_setup_dma_ops'?
[-Werror=implicit-function-declaration]
ret = iommu_sva_set_ops(handle, _sva_ops);
^
iommu_setup_dma_ops
drivers/misc/uacce/uacce.c:152:21: error: implicit declaration of function
'iommu_sva_get_pasid' [-Werror=implicit-function-declaration]
uacce_mm->pasid = iommu_sva_get_pasid(handle);
^~~
>> drivers/misc/uacce/uacce.c:153:26: error: 'IOMMU_PASID_INVALID' undeclared
>> (first use in this function); did you mean 'HV_MSIVALID_INVALID'?
if (uacce_mm->pasid == IOMMU_PASID_INVALID)
^~~
HV_MSIVALID_INVALID
drivers/misc/uacce/uacce.c:153:26: note: each undeclared identifier is
reported only once for each function it appears in
drivers/misc/uacce/uacce.c:168:3: error: implicit declaration of function
'iommu_sva_unbind_device'; did you mean 'bus_find_device'?
[-Werror=implicit-function-declaration]
iommu_sva_unbind_device(handle);
^~~
bus_find_device
drivers/misc/uacce/uacce.c: At top level:
>> drivers/misc/uacce/uacce.c:274:21: error: variable 'uacce_vm_ops' has
>> initializer but incomplete type
static const struct vm_operations_struct uacce_vm_ops = {
^~~~
>> drivers/misc/uacce/uacce.c:275:3: error: 'const struct vm_operations_struct'
>> has no member named 'close'
.close = uacce_vma_close,
^
drivers/misc/uacce/uacce.c:275:11: warning: excess elements in struct
initializer
.close = uacce_vma_close,
^~~
drivers/misc/uacce/uacce.c:275:11: note: (near initialization for
'uacce_vm_ops')
drivers/misc/uacce/uacce.c: In function 'uacce_fops_mmap':
>> drivers/misc/uacce/uacce.c:295:19: error: 'VM_DONTCOPY' undeclared (first
>> use in this function)
vma->vm_flags |= VM_DONTCOPY | VM_DONTEXPAND | VM_WIPEONFORK;
^~~
>> drivers/misc/uacce/uacce.c:295:33: error: 'VM_DONTEXPAND' undeclared (first
>> use in this function); did you mean 'VM_DONTCOPY'?
vma->vm_flags |= VM_DONTCOPY | VM_DONTEXPAND | VM_WIPEONFORK;
^
VM_DONTCOPY
>> drivers/misc/uacce/uacce.c:295:49: error: 'VM_WIPEONFORK' undeclared (first
>> use in this function)
vma->vm_flags |= VM_DONTCOPY | VM_DONTEXPAND | VM_WIPEONFORK;
Re: [RESEND PATCH v9 2/4] uacce: add uacce driver
Hi Zhangfei,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on cryptodev/master]
[also build test ERROR on crypto/master char-misc/char-misc-testing v5.5-rc1
next-20191209]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Zhangfei-Gao/Add-uacce-module-for-Accelerator/20191210-160210
base:
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: s390-allmodconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 7.5.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All error/warnings (new ones prefixed by >>):
>> drivers/misc/uacce/uacce.c:112:15: error: variable 'uacce_sva_ops' has
>> initializer but incomplete type
static struct iommu_sva_ops uacce_sva_ops = {
^
>> drivers/misc/uacce/uacce.c:113:3: error: 'struct iommu_sva_ops' has no
>> member named 'mm_exit'
.mm_exit = uacce_sva_exit,
^~~
>> drivers/misc/uacce/uacce.c:113:13: warning: excess elements in struct
>> initializer
.mm_exit = uacce_sva_exit,
^~
drivers/misc/uacce/uacce.c:113:13: note: (near initialization for
'uacce_sva_ops')
drivers/misc/uacce/uacce.c: In function 'uacce_mm_get':
>> drivers/misc/uacce/uacce.c:144:12: error: implicit declaration of function
>> 'iommu_sva_bind_device'; did you mean 'bus_find_device'?
>> [-Werror=implicit-function-declaration]
handle = iommu_sva_bind_device(uacce->parent, mm, uacce_mm);
^
bus_find_device
>> drivers/misc/uacce/uacce.c:144:10: warning: assignment makes pointer from
>> integer without a cast [-Wint-conversion]
handle = iommu_sva_bind_device(uacce->parent, mm, uacce_mm);
^
>> drivers/misc/uacce/uacce.c:148:9: error: implicit declaration of function
>> 'iommu_sva_set_ops'; did you mean 'iommu_setup_dma_ops'?
>> [-Werror=implicit-function-declaration]
ret = iommu_sva_set_ops(handle, _sva_ops);
^
iommu_setup_dma_ops
>> drivers/misc/uacce/uacce.c:152:21: error: implicit declaration of function
>> 'iommu_sva_get_pasid' [-Werror=implicit-function-declaration]
uacce_mm->pasid = iommu_sva_get_pasid(handle);
^~~
>> drivers/misc/uacce/uacce.c:153:26: error: 'IOMMU_PASID_INVALID' undeclared
>> (first use in this function); did you mean '_PAGE_INVALID'?
if (uacce_mm->pasid == IOMMU_PASID_INVALID)
^~~
_PAGE_INVALID
drivers/misc/uacce/uacce.c:153:26: note: each undeclared identifier is
reported only once for each function it appears in
>> drivers/misc/uacce/uacce.c:168:3: error: implicit declaration of function
>> 'iommu_sva_unbind_device'; did you mean 'bus_find_device'?
>> [-Werror=implicit-function-declaration]
iommu_sva_unbind_device(handle);
^~~
bus_find_device
drivers/misc/uacce/uacce.c: In function 'uacce_alloc':
>> drivers/misc/uacce/uacce.c:502:9: error: implicit declaration of function
>> 'iommu_dev_enable_feature'; did you mean 'module_enable_ro'?
>> [-Werror=implicit-function-declaration]
ret = iommu_dev_enable_feature(parent, IOMMU_DEV_FEAT_SVA);
^~~~
module_enable_ro
>> drivers/misc/uacce/uacce.c:502:42: error: 'IOMMU_DEV_FEAT_SVA' undeclared
>> (first use in this function); did you mean 'NOMMU_VMFLAGS'?
ret = iommu_dev_enable_feature(parent, IOMMU_DEV_FEAT_SVA);
^~
NOMMU_VMFLAGS
>> drivers/misc/uacce/uacce.c:530:3: error: implicit declaration of function
>> 'iommu_dev_disable_feature'; did you mean 'module_disable_ro'?
>> [-Werror=implicit-function-declaration]
iommu_dev_disable_feature(uacce->parent, IOMMU_DEV_FEAT_SVA);
^
module_disable_ro
drivers/misc/uacce/uacce.c: In function 'uacce_remove':
drivers/misc/uacce/uacce.c:592:44: error: 'IOMMU_DEV_FEAT_SVA' undeclared
(first use in this function); did you mean 'NOMMU_VMFLAGS'?
iommu_dev_disable_feature(uacce->parent, IOMMU_DEV_FEAT_SVA);
Re: [PATCH] swiotlb: Adjust SWIOTBL bounce buffer size for SEV guests.
Hi Ashish,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on hch-configfs/for-next]
[cannot apply to linus/master v5.4 next-20191206]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Ashish-Kalra/swiotlb-Adjust-SWIOTBL-bounce-buffer-size-for-SEV-guests/20191207-184151
base: git://git.infradead.org/users/hch/configfs.git for-next
config: x86_64-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.5.0-1) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All warnings (new ones prefixed by >>):
In file included from kernel/dma/swiotlb.c:24:0:
include/linux/dma-direct.h:49:1: error: expected identifier or '(' before
'{' token
{
^
In file included from kernel/dma/swiotlb.c:24:0:
>> include/linux/dma-direct.h:47:29: warning: 'adjust_swiotlb_default_size'
>> used but never defined
static inline unsigned long adjust_swiotlb_default_size
^~~
vim +/adjust_swiotlb_default_size +47 include/linux/dma-direct.h
43
44 #ifdef CONFIG_ARCH_HAS_ADJUST_SWIOTLB_DEFAULT
45 unsigned long adjust_swiotlb_default_size(unsigned long default_size);
46 #else
> 47 static inline unsigned long adjust_swiotlb_default_size
48 (unsigned long default_size);
> 49 {
50 return default_size;
51 }
52 #endif /* CONFIG_ARCH_HAS_ADJUST_SWIOTLB_DEFAULT */
53
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v6 2/3] PCI: Add parameter nr_devfns to pci_add_dma_alias
Hi James,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on v5.4-rc8]
[also build test WARNING on next-20191206]
[cannot apply to pci/next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/James-Sewart/PCI-Fix-off-by-one-in-dma_alias_mask-allocation-size/20191204-034421
base:af42d3466bdc8f39806b26f593604fdc54140bcb
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-91-g817270f-dirty
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
>> drivers/iommu/amd_iommu.c:288:34: sparse: sparse: not enough arguments for
>> function pci_add_dma_alias
vim +288 drivers/iommu/amd_iommu.c
e3156048346c28 Joerg Roedel 2016-04-08 234
e3156048346c28 Joerg Roedel 2016-04-08 235 static u16 get_alias(struct
device *dev)
e3156048346c28 Joerg Roedel 2016-04-08 236 {
e3156048346c28 Joerg Roedel 2016-04-08 237 struct pci_dev *pdev =
to_pci_dev(dev);
e3156048346c28 Joerg Roedel 2016-04-08 238 u16 devid, ivrs_alias,
pci_alias;
e3156048346c28 Joerg Roedel 2016-04-08 239
6c0b43df74f900 Joerg Roedel 2016-05-09 240 /* The callers make sure that
get_device_id() does not fail here */
e3156048346c28 Joerg Roedel 2016-04-08 241 devid = get_device_id(dev);
5ebb1bc2d63d90 Arindam Nath 2018-09-18 242
5ebb1bc2d63d90 Arindam Nath 2018-09-18 243 /* For ACPI HID devices, we
simply return the devid as such */
5ebb1bc2d63d90 Arindam Nath 2018-09-18 244 if (!dev_is_pci(dev))
5ebb1bc2d63d90 Arindam Nath 2018-09-18 245 return devid;
5ebb1bc2d63d90 Arindam Nath 2018-09-18 246
e3156048346c28 Joerg Roedel 2016-04-08 247 ivrs_alias =
amd_iommu_alias_table[devid];
5ebb1bc2d63d90 Arindam Nath 2018-09-18 248
e3156048346c28 Joerg Roedel 2016-04-08 249 pci_for_each_dma_alias(pdev,
__last_alias, _alias);
e3156048346c28 Joerg Roedel 2016-04-08 250
e3156048346c28 Joerg Roedel 2016-04-08 251 if (ivrs_alias == pci_alias)
e3156048346c28 Joerg Roedel 2016-04-08 252 return ivrs_alias;
e3156048346c28 Joerg Roedel 2016-04-08 253
e3156048346c28 Joerg Roedel 2016-04-08 254 /*
e3156048346c28 Joerg Roedel 2016-04-08 255* DMA alias showdown
e3156048346c28 Joerg Roedel 2016-04-08 256*
e3156048346c28 Joerg Roedel 2016-04-08 257* The IVRS is fairly reliable
in telling us about aliases, but it
e3156048346c28 Joerg Roedel 2016-04-08 258* can't know about every
screwy device. If we don't have an IVRS
e3156048346c28 Joerg Roedel 2016-04-08 259* reported alias, use the PCI
reported alias. In that case we may
e3156048346c28 Joerg Roedel 2016-04-08 260* still need to initialize the
rlookup and dev_table entries if the
e3156048346c28 Joerg Roedel 2016-04-08 261* alias is to a non-existent
device.
e3156048346c28 Joerg Roedel 2016-04-08 262*/
e3156048346c28 Joerg Roedel 2016-04-08 263 if (ivrs_alias == devid) {
e3156048346c28 Joerg Roedel 2016-04-08 264 if
(!amd_iommu_rlookup_table[pci_alias]) {
e3156048346c28 Joerg Roedel 2016-04-08 265
amd_iommu_rlookup_table[pci_alias] =
e3156048346c28 Joerg Roedel 2016-04-08 266
amd_iommu_rlookup_table[devid];
e3156048346c28 Joerg Roedel 2016-04-08 267
memcpy(amd_iommu_dev_table[pci_alias].data,
e3156048346c28 Joerg Roedel 2016-04-08 268
amd_iommu_dev_table[devid].data,
e3156048346c28 Joerg Roedel 2016-04-08 269
sizeof(amd_iommu_dev_table[pci_alias].data));
e3156048346c28 Joerg Roedel 2016-04-08 270 }
e3156048346c28 Joerg Roedel 2016-04-08 271
e3156048346c28 Joerg Roedel 2016-04-08 272 return pci_alias;
e3156048346c28 Joerg Roedel 2016-04-08 273 }
e3156048346c28 Joerg Roedel 2016-04-08 274
5f226da1b1d706 Bjorn Helgaas 2019-02-08 275 pci_info(pdev, "Using IVRS
reported alias %02x:%02x.%d "
5f226da1b1d706 Bjorn Helgaas 2019-02-08 276 "for device
[%04x:%04x], kernel reported alias "
e3156048346c28 Joerg Roedel 2016-04-08 277 "%02x:%02x.%d\n",
PCI_BUS_NUM(ivrs_alias), PCI_SLOT(ivrs_alias),
5f226da1b1d706 Bjorn Helgaas 2019-02-08 278 PCI_FUNC(ivrs_alias),
pdev->vendor, pdev->device,
e3156048346c28 Joerg Roedel 2016-04-08 279 PCI_BUS_NUM(pci_alias),
PCI_SLOT(pci_alias),
e3156048346c28 Joerg Roedel 2016-04-08 280 PCI_FUNC(pci_alias));
e3156048346c28 Joerg Roedel 2016-04-0
Re: [PATCH] swiotlb: Adjust SWIOTBL bounce buffer size for SEV guests.
Hi Ashish,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on hch-configfs/for-next]
[also build test ERROR on linus/master v5.4 next-20191202]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Ashish-Kalra/swiotlb-Adjust-SWIOTBL-bounce-buffer-size-for-SEV-guests/20191207-184151
base: git://git.infradead.org/users/hch/configfs.git for-next
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.5.0-1) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
In file included from arch/x86/kernel/pci-dma.c:2:0:
>> include/linux/dma-direct.h:49:1: error: expected identifier or '(' before
>> '{' token
{
^
include/linux/dma-direct.h:47:29: warning: 'adjust_swiotlb_default_size'
declared 'static' but never defined [-Wunused-function]
static inline unsigned long adjust_swiotlb_default_size
^~~
vim +49 include/linux/dma-direct.h
43
44 #ifdef CONFIG_ARCH_HAS_ADJUST_SWIOTLB_DEFAULT
45 unsigned long adjust_swiotlb_default_size(unsigned long default_size);
46 #else
47 static inline unsigned long adjust_swiotlb_default_size
48 (unsigned long default_size);
> 49 {
50 return default_size;
51 }
52 #endif /* CONFIG_ARCH_HAS_ADJUST_SWIOTLB_DEFAULT */
53
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v2 1/3] dma-mapping: introduce new dma unmap and sync api variants
Hi Laurentiu,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
[also build test ERROR on v5.4-rc5 next-20191029]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Laurentiu-Tudor/dma-mapping-introduce-new-dma-unmap-and-sync-variants/20191027-173418
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
503a64635d5ef7351657c78ad77f8b5ff658d5fc
config: um-x86_64_defconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=um SUBARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
In file included from include/linux/skbuff.h:31:0,
from include/net/net_namespace.h:38,
from include/linux/inet.h:42,
from include/linux/sunrpc/msg_prot.h:204,
from include/linux/sunrpc/auth.h:16,
from include/linux/nfs_fs.h:31,
from init/do_mounts.c:23:
include/linux/dma-mapping.h: In function 'dma_sync_single_for_cpu_desc':
include/linux/dma-mapping.h:539:1: warning: no return statement in function
returning non-void [-Wreturn-type]
}
^
include/linux/dma-mapping.h: In function 'dma_unmap_single_attrs_desc':
>> include/linux/dma-mapping.h:638:34: error: implicit declaration of function
>> 'get_dma_ops'; did you mean 'get_mm_rss'?
>> [-Werror=implicit-function-declaration]
const struct dma_map_ops *ops = get_dma_ops(dev);
^~~
get_mm_rss
include/linux/dma-mapping.h:638:34: warning: initialization makes pointer
from integer without a cast [-Wint-conversion]
cc1: some warnings being treated as errors
vim +638 include/linux/dma-mapping.h
534
535 static inline void *
536 dma_sync_single_for_cpu_desc(struct device *dev, dma_addr_t addr,
size_t size,
537 enum dma_data_direction dir)
538 {
> 539 }
540 static inline void dma_sync_single_for_device(struct device *dev,
541 dma_addr_t addr, size_t size, enum dma_data_direction
dir)
542 {
543 }
544 static inline void dma_sync_sg_for_cpu(struct device *dev,
545 struct scatterlist *sg, int nelems, enum
dma_data_direction dir)
546 {
547 }
548 static inline void dma_sync_sg_for_device(struct device *dev,
549 struct scatterlist *sg, int nelems, enum
dma_data_direction dir)
550 {
551 }
552 static inline int dma_mapping_error(struct device *dev, dma_addr_t
dma_addr)
553 {
554 return -ENOMEM;
555 }
556 static inline void *dma_alloc_attrs(struct device *dev, size_t size,
557 dma_addr_t *dma_handle, gfp_t flag, unsigned long attrs)
558 {
559 return NULL;
560 }
561 static void dma_free_attrs(struct device *dev, size_t size, void
*cpu_addr,
562 dma_addr_t dma_handle, unsigned long attrs)
563 {
564 }
565 static inline void *dmam_alloc_attrs(struct device *dev, size_t size,
566 dma_addr_t *dma_handle, gfp_t gfp, unsigned long attrs)
567 {
568 return NULL;
569 }
570 static inline void dmam_free_coherent(struct device *dev, size_t size,
571 void *vaddr, dma_addr_t dma_handle)
572 {
573 }
574 static inline void dma_cache_sync(struct device *dev, void *vaddr,
size_t size,
575 enum dma_data_direction dir)
576 {
577 }
578 static inline int dma_get_sgtable_attrs(struct device *dev,
579 struct sg_table *sgt, void *cpu_addr, dma_addr_t
dma_addr,
580 size_t size, unsigned long attrs)
581 {
582 return -ENXIO;
583 }
584 static inline int dma_mmap_attrs(struct device *dev, struct
vm_area_struct *vma,
585 void *cpu_addr, dma_addr_t dma_addr, size_t size,
586 unsigned long attrs)
587 {
588 return -ENXIO;
589 }
590 static inline bool dma_can_mmap(struct device *dev)
591 {
592 return false;
593 }
594 static inline int dma_supported(struct device *dev, u64 mask)
595 {
596 return 0;
597 }
598 static inline int dma_set_mask(struct device *dev, u64 mask)
599 {
600 return -EIO;
601 }
602 static inline int dma_set_coherent_mask(struct device *dev, u64 mask)
603 {
604 return -EIO;
605 }
606 static inline u64 dma_get_requi
[linux-next:master 4470/4908] drivers/iommu/iommu.c:1857:5: sparse: sparse: symbol '__iommu_map' was not declared. Should it be static?
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 78662bffde37ccbb66ac3311fa709d8960435e98 commit: 781ca2de89bae1b1d2c96df9ef33e9a324415995 [4470/4908] iommu: Add gfp parameter to iommu_ops::map reproduce: # apt-get install sparse # sparse version: v0.6.1-dirty git checkout 781ca2de89bae1b1d2c96df9ef33e9a324415995 make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) drivers/iommu/iommu.c:292:5: sparse: sparse: symbol 'iommu_insert_resv_region' was not declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
[RFC PATCH linux-next] iommu: Add gfp parameter to iommu_ops:: __iommu_map() can be static
Fixes: 781ca2de89ba ("iommu: Add gfp parameter to iommu_ops::map")
Signed-off-by: kbuild test robot
---
iommu.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index f8853dbf1c4eb..89bfdbbfaa11b 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -1854,7 +1854,7 @@ static size_t iommu_pgsize(struct iommu_domain *domain,
return pgsize;
}
-int __iommu_map(struct iommu_domain *domain, unsigned long iova,
+static int __iommu_map(struct iommu_domain *domain, unsigned long iova,
phys_addr_t paddr, size_t size, int prot, gfp_t gfp)
{
const struct iommu_ops *ops = domain->ops;
Re: [PATCH v2] dma-mapping: Move vmap address checks into dma_map_single()
Hi Kees,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to v5.4-rc2 next-20191010]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Kees-Cook/dma-mapping-Move-vmap-address-checks-into-dma_map_single/20191005-073954
config: sh-magicpanelr2_defconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.4.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
In file included from arch/sh/include/asm/bug.h:112:0,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/preempt.h:5,
from ./arch/sh/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:51,
from include/linux/seqlock.h:36,
from include/linux/time.h:6,
from include/linux/stat.h:19,
from include/linux/module.h:10,
from arch/sh/kernel/io.c:8:
include/linux/dma-mapping.h: In function 'dma_map_single_attrs':
>> include/linux/dma-mapping.h:588:9: error: format '%lu' expects argument of
>> type 'long unsigned int', but argument 4 has type 'size_t {aka unsigned
>> int}' [-Werror=format=]
"%s %s: driver maps %lu bytes from vmalloc area\n",
^
include/asm-generic/bug.h:92:17: note: in definition of macro '__WARN_printf'
__warn_printk(arg); \
^~~
include/asm-generic/bug.h:155:3: note: in expansion of macro 'WARN'
WARN(1, format);\
^~~~
include/linux/dma-mapping.h:587:6: note: in expansion of macro 'WARN_ONCE'
if (WARN_ONCE(is_vmalloc_addr(ptr),
^
cc1: all warnings being treated as errors
vim +588 include/linux/dma-mapping.h
582
583 static inline dma_addr_t dma_map_single_attrs(struct device *dev, void
*ptr,
584 size_t size, enum dma_data_direction dir, unsigned long
attrs)
585 {
586 /* DMA must never operate on areas that might be remapped. */
587 if (WARN_ONCE(is_vmalloc_addr(ptr),
> 588"%s %s: driver maps %lu bytes from vmalloc
> area\n",
589dev ? dev_driver_string(dev) : "unknown driver",
590dev ? dev_name(dev) : "unknown device", size))
591 return DMA_MAPPING_ERROR;
592
593 debug_dma_map_single(dev, ptr, size);
594 return dma_map_page_attrs(dev, virt_to_page(ptr),
offset_in_page(ptr),
595 size, dir, attrs);
596 }
597
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH v2] dma-mapping: Move vmap address checks into dma_map_single()
Hi Kees,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[cannot apply to v5.4-rc1 next-20191004]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Kees-Cook/dma-mapping-Move-vmap-address-checks-into-dma_map_single/20191005-073954
config: i386-randconfig-d001-201939 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-13) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All warnings (new ones prefixed by >>):
In file included from include/linux/init.h:5:0,
from sound/pci/ad1889.c:23:
include/linux/dma-mapping.h: In function 'dma_map_single_attrs':
include/linux/dma-mapping.h:588:9: warning: format '%lu' expects argument of
type 'long unsigned int', but argument 4 has type 'size_t {aka unsigned int}'
[-Wformat=]
"%s %s: driver maps %lu bytes from vmalloc area\n",
^
include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) :
__trace_if_value(cond))
^~~~
>> include/linux/dma-mapping.h:587:2: note: in expansion of macro 'if'
if (WARN_ONCE(is_vmalloc_addr(ptr),
^~
include/asm-generic/bug.h:124:3: note: in expansion of macro '__WARN_printf'
__WARN_printf(TAINT_WARN, format); \
^
include/asm-generic/bug.h:155:3: note: in expansion of macro 'WARN'
WARN(1, format);\
^~~~
include/linux/dma-mapping.h:587:6: note: in expansion of macro 'WARN_ONCE'
if (WARN_ONCE(is_vmalloc_addr(ptr),
^
include/linux/dma-mapping.h:588:9: warning: format '%lu' expects argument of
type 'long unsigned int', but argument 4 has type 'size_t {aka unsigned int}'
[-Wformat=]
"%s %s: driver maps %lu bytes from vmalloc area\n",
^
include/linux/compiler.h:58:61: note: in definition of macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) :
__trace_if_value(cond))
^~~~
>> include/linux/dma-mapping.h:587:2: note: in expansion of macro 'if'
if (WARN_ONCE(is_vmalloc_addr(ptr),
^~
include/asm-generic/bug.h:124:3: note: in expansion of macro '__WARN_printf'
__WARN_printf(TAINT_WARN, format); \
^
include/asm-generic/bug.h:155:3: note: in expansion of macro 'WARN'
WARN(1, format);\
^~~~
include/linux/dma-mapping.h:587:6: note: in expansion of macro 'WARN_ONCE'
if (WARN_ONCE(is_vmalloc_addr(ptr),
^
include/linux/dma-mapping.h:588:9: warning: format '%lu' expects argument of
type 'long unsigned int', but argument 4 has type 'size_t {aka unsigned int}'
[-Wformat=]
"%s %s: driver maps %lu bytes from vmalloc area\n",
^
include/linux/compiler.h:69:3: note: in definition of macro
'__trace_if_value'
(cond) ? \
^~~~
include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var'
#define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
^~
>> include/linux/dma-mapping.h:587:2: note: in expansion of macro 'if'
if (WARN_ONCE(is_vmalloc_addr(ptr),
^~
include/asm-generic/bug.h:124:3: note: in expansion of macro '__WARN_printf'
__WARN_printf(TAINT_WARN, format); \
^
include/asm-generic/bug.h:155:3: note: in expansion of macro 'WARN'
WARN(1, format);\
^~~~
include/linux/dma-mapping.h:587:6: note: in expansion of macro 'WARN_ONCE'
if (WARN_ONCE(is_vmalloc_addr(ptr),
^
--
In file included from include/linux/export.h:44:0,
from include/linux/linkage.h:7,
from include/linux/kernel.h:8,
from include/linux/delay.h:22,
from sound/pci//hda/hda_intel.c:23:
include/linux/dma-mapping.h: In function 'dma_map_single_attrs':
include/linux/dma-mapping.h:588:9: warning: format '%lu' expects argument of
type 'long unsigned int', but argument 4 has type 'size_t {aka unsigned int}'
[-Wformat=]
"%s %s: driver maps %lu bytes from vmalloc area\n",
^
include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) :
__trace_if_value(cond))
^~~~
>> include/linux/dm
Re: [PATCH] dma-mapping: Lift address space checks out of debug code
Hi Kees,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to v5.4-rc1 next-20191002]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Kees-Cook/dma-mapping-Lift-address-space-checks-out-of-debug-code/20191003-060622
config: i386-randconfig-c004-201939 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-13) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
In file included from arch/x86/include/asm/bug.h:83:0,
from include/linux/bug.h:5,
from include/linux/debug_locks.h:7,
from include/linux/lockdep.h:28,
from include/linux/spinlock_types.h:18,
from include/linux/mutex.h:16,
from include/linux/kernfs.h:12,
from include/linux/sysfs.h:16,
from include/linux/kobject.h:20,
from include/linux/of.h:17,
from include/linux/irqdomain.h:35,
from include/linux/acpi.h:13,
from drivers/gpu/drm/i915/i915_drv.c:30:
include/linux/dma-mapping.h: In function 'dma_map_single_attrs':
>> include/linux/dma-mapping.h:588:3: error: format '%lu' expects argument of
>> type 'long unsigned int', but argument 4 has type 'size_t {aka unsigned
>> int}' [-Werror=format=]
"%s %s: driver maps %lu bytes from %s area\n",
^
include/asm-generic/bug.h:92:17: note: in definition of macro '__WARN_printf'
__warn_printk(arg); \
^~~
include/asm-generic/bug.h:155:3: note: in expansion of macro 'WARN'
WARN(1, format);\
^~~~
include/linux/dma-mapping.h:587:2: note: in expansion of macro 'WARN_ONCE'
WARN_ONCE(is_vmalloc_addr(ptr) || !virt_addr_valid(ptr),
^
cc1: all warnings being treated as errors
vim +588 include/linux/dma-mapping.h
582
583 static inline dma_addr_t dma_map_single_attrs(struct device *dev, void
*ptr,
584 size_t size, enum dma_data_direction dir, unsigned long
attrs)
585 {
586 /* DMA must never operate on stack or other remappable places.
*/
587 WARN_ONCE(is_vmalloc_addr(ptr) || !virt_addr_valid(ptr),
> 588 "%s %s: driver maps %lu bytes from %s area\n",
589 dev ? dev_driver_string(dev) : "unknown driver",
590 dev ? dev_name(dev) : "unknown device", size,
591 is_vmalloc_addr(ptr) ? "vmalloc" : "invalid");
592
593 return dma_map_page_attrs(dev, virt_to_page(ptr),
offset_in_page(ptr),
594 size, dir, attrs);
595 }
596
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH] dma-mapping: Lift address space checks out of debug code
Hi Kees,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[cannot apply to v5.4-rc1 next-20191002]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Kees-Cook/dma-mapping-Lift-address-space-checks-out-of-debug-code/20191003-060622
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-13) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All warnings (new ones prefixed by >>):
In file included from include/linux/kernel.h:15:0,
from include/linux/list.h:9,
from include/linux/module.h:9,
from init/do_mounts.c:2:
include/linux/dma-mapping.h: In function 'dma_map_single_attrs':
>> include/linux/dma-mapping.h:588:3: warning: format '%lu' expects argument of
>> type 'long unsigned int', but argument 4 has type 'size_t {aka unsigned
>> int}' [-Wformat=]
"%s %s: driver maps %lu bytes from %s area\n",
^
include/linux/printk.h:137:10: note: in definition of macro 'no_printk'
printk(fmt, ##__VA_ARGS__); \
^~~
include/asm-generic/bug.h:196:41: note: in expansion of macro 'WARN'
#define WARN_ONCE(condition, format...) WARN(condition, format)
^~~~
>> include/linux/dma-mapping.h:587:2: note: in expansion of macro 'WARN_ONCE'
WARN_ONCE(is_vmalloc_addr(ptr) || !virt_addr_valid(ptr),
^
vim +588 include/linux/dma-mapping.h
582
583 static inline dma_addr_t dma_map_single_attrs(struct device *dev, void
*ptr,
584 size_t size, enum dma_data_direction dir, unsigned long
attrs)
585 {
586 /* DMA must never operate on stack or other remappable places.
*/
> 587 WARN_ONCE(is_vmalloc_addr(ptr) || !virt_addr_valid(ptr),
> 588 "%s %s: driver maps %lu bytes from %s area\n",
589 dev ? dev_driver_string(dev) : "unknown driver",
590 dev ? dev_name(dev) : "unknown device", size,
591 is_vmalloc_addr(ptr) ? "vmalloc" : "invalid");
592
593 return dma_map_page_attrs(dev, virt_to_page(ptr),
offset_in_page(ptr),
594 size, dir, attrs);
595 }
596
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v1 4/5] mmc: sdhci-acpi: Switch to use acpi_dev_hid_uid_match()
Hi Andy,
I love your patch! Yet something to improve:
[auto build test ERROR on pm/linux-next]
[cannot apply to v5.3 next-20190920]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Andy-Shevchenko/ACPI-utils-Describe-function-parameters-in-kernel-doc/20190924-230504
base:
https://kernel.googlesource.com/pub/scm/linux/kernel/git/rafael/linux-pm.git
linux-next
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.4.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
In file included from include/linux/acpi.h:32:0,
from drivers/mmc/host/sdhci-acpi.c:22:
include/acpi/acpi_bus.h:78:36: warning: 'struct acpi_device' declared inside
parameter list will not be visible outside of this definition or declaration
bool acpi_dev_hid_uid_match(struct acpi_device *adev,
^~~
drivers/mmc/host/sdhci-acpi.c: In function 'intel_probe_slot':
>> drivers/mmc/host/sdhci-acpi.c:381:29: error: passing argument 1 of
>> 'acpi_dev_hid_uid_match' from incompatible pointer type
>> [-Werror=incompatible-pointer-types]
if (acpi_dev_hid_uid_match(adev, "80860F14", "1") &&
^~~~
In file included from include/linux/acpi.h:32:0,
from drivers/mmc/host/sdhci-acpi.c:22:
include/acpi/acpi_bus.h:78:6: note: expected 'struct acpi_device *' but
argument is of type 'struct acpi_device *'
bool acpi_dev_hid_uid_match(struct acpi_device *adev,
^~
drivers/mmc/host/sdhci-acpi.c:386:29: error: passing argument 1 of
'acpi_dev_hid_uid_match' from incompatible pointer type
[-Werror=incompatible-pointer-types]
if (acpi_dev_hid_uid_match(adev, "80865ACA", NULL))
^~~~
In file included from include/linux/acpi.h:32:0,
from drivers/mmc/host/sdhci-acpi.c:22:
include/acpi/acpi_bus.h:78:6: note: expected 'struct acpi_device *' but
argument is of type 'struct acpi_device *'
bool acpi_dev_hid_uid_match(struct acpi_device *adev,
^~
drivers/mmc/host/sdhci-acpi.c: In function 'qcom_probe_slot':
drivers/mmc/host/sdhci-acpi.c:480:29: error: passing argument 1 of
'acpi_dev_hid_uid_match' from incompatible pointer type
[-Werror=incompatible-pointer-types]
if (acpi_dev_hid_uid_match(adev, "QCOM8051", NULL))
^~~~
In file included from include/linux/acpi.h:32:0,
from drivers/mmc/host/sdhci-acpi.c:22:
include/acpi/acpi_bus.h:78:6: note: expected 'struct acpi_device *' but
argument is of type 'struct acpi_device *'
bool acpi_dev_hid_uid_match(struct acpi_device *adev,
^~
drivers/mmc/host/sdhci-acpi.c: In function 'qcom_free_slot':
drivers/mmc/host/sdhci-acpi.c:504:30: error: passing argument 1 of
'acpi_dev_hid_uid_match' from incompatible pointer type
[-Werror=incompatible-pointer-types]
if (!acpi_dev_hid_uid_match(adev, "QCOM8051", NULL))
^~~~
In file included from include/linux/acpi.h:32:0,
from drivers/mmc/host/sdhci-acpi.c:22:
include/acpi/acpi_bus.h:78:6: note: expected 'struct acpi_device *' but
argument is of type 'struct acpi_device *'
bool acpi_dev_hid_uid_match(struct acpi_device *adev,
^~
drivers/mmc/host/sdhci-acpi.c: In function 'sdhci_acpi_get_slot':
drivers/mmc/host/sdhci-acpi.c:655:30: error: passing argument 1 of
'acpi_dev_hid_uid_match' from incompatible pointer type
[-Werror=incompatible-pointer-types]
if (acpi_dev_hid_uid_match(adev, u->hid, u->uid))
^~~~
In file included from include/linux/acpi.h:32:0,
from drivers/mmc/host/sdhci-acpi.c:22:
include/acpi/acpi_bus.h:78:6: note: expected 'struct acpi_device *' but
argument is of type 'struct acpi_device *'
bool acpi_dev_hid_uid_match(struct acpi_device *adev,
^~
cc1: some warnings being treated as errors
vim +/acpi_dev_hid_uid_match +381 drivers/mmc/host/sdhci-acpi.c
374
375 static int intel_probe_slot(struct platform_device *pdev, struct
acpi_device *adev)
376 {
377 struct sdhci_acpi_host *c = platform_get_d
Re: [PATCH v1 2/5] ACPI / utils: Introduce acpi_dev_hid_uid_match() helper
Hi Andy,
I love your patch! Yet something to improve:
[auto build test ERROR on pm/linux-next]
[cannot apply to v5.3 next-20190920]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Andy-Shevchenko/ACPI-utils-Describe-function-parameters-in-kernel-doc/20190924-230504
base:
https://kernel.googlesource.com/pub/scm/linux/kernel/git/rafael/linux-pm.git
linux-next
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.4.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All error/warnings (new ones prefixed by >>):
In file included from include/linux/acpi.h:32:0,
from include/linux/i2c.h:13,
from drivers//media/radio/si4713/si4713.c:15:
>> include/acpi/acpi_bus.h:78:36: warning: 'struct acpi_device' declared inside
>> parameter list will not be visible outside of this definition or declaration
bool acpi_dev_hid_uid_match(struct acpi_device *adev,
^~~
--
In file included from include/linux/acpi.h:32:0,
from drivers/acpi/utils.c:15:
>> include/acpi/acpi_bus.h:78:36: warning: 'struct acpi_device' declared inside
>> parameter list will not be visible outside of this definition or declaration
bool acpi_dev_hid_uid_match(struct acpi_device *adev,
^~~
>> drivers/acpi/utils.c:713:6: error: conflicting types for
>> 'acpi_dev_hid_uid_match'
bool acpi_dev_hid_uid_match(struct acpi_device *adev,
^~
In file included from include/linux/acpi.h:32:0,
from drivers/acpi/utils.c:15:
include/acpi/acpi_bus.h:78:6: note: previous declaration of
'acpi_dev_hid_uid_match' was here
bool acpi_dev_hid_uid_match(struct acpi_device *adev,
^~
In file included from include/linux/linkage.h:7:0,
from include/linux/kernel.h:8,
from drivers/acpi/utils.c:9:
drivers/acpi/utils.c:727:15: error: conflicting types for
'acpi_dev_hid_uid_match'
EXPORT_SYMBOL(acpi_dev_hid_uid_match);
^
include/linux/export.h:79:21: note: in definition of macro '___EXPORT_SYMBOL'
extern typeof(sym) sym; \
^~~
>> drivers/acpi/utils.c:727:1: note: in expansion of macro 'EXPORT_SYMBOL'
EXPORT_SYMBOL(acpi_dev_hid_uid_match);
^
In file included from include/linux/acpi.h:32:0,
from drivers/acpi/utils.c:15:
include/acpi/acpi_bus.h:78:6: note: previous declaration of
'acpi_dev_hid_uid_match' was here
bool acpi_dev_hid_uid_match(struct acpi_device *adev,
^~
--
In file included from include/linux/acpi.h:32:0,
from drivers/cpufreq/ia64-acpi-cpufreq.c:24:
>> include/acpi/acpi_bus.h:78:36: warning: 'struct acpi_device' declared inside
>> parameter list will not be visible outside of this definition or declaration
bool acpi_dev_hid_uid_match(struct acpi_device *adev,
^~~
drivers/cpufreq/ia64-acpi-cpufreq.c: In function 'processor_set_pstate':
:0:16: warning: format '%lx' expects argument of type 'long
unsigned int', but argument 4 has type 's64 {aka long long int}' [-Wformat=]
drivers/cpufreq/ia64-acpi-cpufreq.c:12:21: note: in expansion of macro
'KBUILD_MODNAME'
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
^~
include/linux/dynamic_debug.h:125:15: note: in expansion of macro 'pr_fmt'
func(, ##__VA_ARGS__); \
^~~
include/linux/dynamic_debug.h:143:2: note: in expansion of macro
'__dynamic_func_call'
__dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
^~~
include/linux/dynamic_debug.h:153:2: note: in expansion of macro
'_dynamic_func_call'
_dynamic_func_call(fmt, __dynamic_pr_debug, \
^~
include/linux/printk.h:336:2: note: in expansion of macro 'dynamic_pr_debug'
dynamic_pr_debug(fmt, ##__VA_ARGS__)
^~~~
drivers/cpufreq/ia64-acpi-cpufreq.c:57:3: note: in expansion of macro
'pr_debug'
pr_debug("Failed to set freq to 0x%x, with error 0x%lx\n",
^~~~
drivers/cpufreq/ia64-acpi-cpufreq.c: In function 'processor_get_pstate':
:0:16: warning
Re: [PATCH v1 2/5] ACPI / utils: Introduce acpi_dev_hid_uid_match() helper
Hi Andy,
I love your patch! Perhaps something to improve:
[auto build test WARNING on pm/linux-next]
[cannot apply to v5.3 next-20190920]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Andy-Shevchenko/ACPI-utils-Describe-function-parameters-in-kernel-doc/20190924-230504
base:
https://kernel.googlesource.com/pub/scm/linux/kernel/git/rafael/linux-pm.git
linux-next
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-13) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All warnings (new ones prefixed by >>):
In file included from init/main.c:30:0:
>> include/linux/acpi.h:665:50: warning: 'struct acpi_device' declared inside
>> parameter list will not be visible outside of this definition or declaration
static inline bool acpi_dev_hid_uid_match(struct acpi_device *adev,
^~~
vim +665 include/linux/acpi.h
664
> 665 static inline bool acpi_dev_hid_uid_match(struct acpi_device *adev,
666const char *hid2, const char
*uid2)
667 {
668 return false;
669 }
670
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v1 3/5] ACPI / LPSS: Switch to use acpi_dev_hid_uid_match()
Hi Andy,
I love your patch! Yet something to improve:
[auto build test ERROR on pm/linux-next]
[cannot apply to v5.3 next-20190920]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Andy-Shevchenko/ACPI-utils-Describe-function-parameters-in-kernel-doc/20190924-230504
base:
https://kernel.googlesource.com/pub/scm/linux/kernel/git/rafael/linux-pm.git
linux-next
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-13) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
In file included from include/linux/acpi.h:32:0,
from drivers/acpi/acpi_lpss.c:10:
include/acpi/acpi_bus.h:78:36: warning: 'struct acpi_device' declared inside
parameter list will not be visible outside of this definition or declaration
bool acpi_dev_hid_uid_match(struct acpi_device *adev,
^~~
drivers/acpi/acpi_lpss.c: In function 'acpi_lpss_is_supplier':
>> drivers/acpi/acpi_lpss.c:484:32: error: passing argument 1 of
>> 'acpi_dev_hid_uid_match' from incompatible pointer type
>> [-Werror=incompatible-pointer-types]
return acpi_dev_hid_uid_match(adev, link->supplier_hid,
link->supplier_uid);
^~~~
In file included from include/linux/acpi.h:32:0,
from drivers/acpi/acpi_lpss.c:10:
include/acpi/acpi_bus.h:78:6: note: expected 'struct acpi_device *' but
argument is of type 'struct acpi_device *'
bool acpi_dev_hid_uid_match(struct acpi_device *adev,
^~
drivers/acpi/acpi_lpss.c: In function 'acpi_lpss_is_consumer':
drivers/acpi/acpi_lpss.c:490:32: error: passing argument 1 of
'acpi_dev_hid_uid_match' from incompatible pointer type
[-Werror=incompatible-pointer-types]
return acpi_dev_hid_uid_match(adev, link->consumer_hid,
link->consumer_uid);
^~~~
In file included from include/linux/acpi.h:32:0,
from drivers/acpi/acpi_lpss.c:10:
include/acpi/acpi_bus.h:78:6: note: expected 'struct acpi_device *' but
argument is of type 'struct acpi_device *'
bool acpi_dev_hid_uid_match(struct acpi_device *adev,
^~
drivers/acpi/acpi_lpss.c: In function 'match_hid_uid':
drivers/acpi/acpi_lpss.c:506:32: error: passing argument 1 of
'acpi_dev_hid_uid_match' from incompatible pointer type
[-Werror=incompatible-pointer-types]
return acpi_dev_hid_uid_match(adev, id->hid, id->uid);
^~~~
In file included from include/linux/acpi.h:32:0,
from drivers/acpi/acpi_lpss.c:10:
include/acpi/acpi_bus.h:78:6: note: expected 'struct acpi_device *' but
argument is of type 'struct acpi_device *'
bool acpi_dev_hid_uid_match(struct acpi_device *adev,
^~
cc1: some warnings being treated as errors
vim +/acpi_dev_hid_uid_match +484 drivers/acpi/acpi_lpss.c
480
481 static bool acpi_lpss_is_supplier(struct acpi_device *adev,
482const struct lpss_device_links *link)
483 {
> 484 return acpi_dev_hid_uid_match(adev, link->supplier_hid,
> link->supplier_uid);
485 }
486
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v2 2/4] iommu: Add I/O ASID allocator
Hi Jacob,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to v5.3 next-20190920]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Jacob-Pan/User-API-for-nested-shared-virtual-address-SVA/20190922-080736
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.4.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
Note: the
linux-review/Jacob-Pan/User-API-for-nested-shared-virtual-address-SVA/20190922-080736
HEAD 4ca1ca48104795307d26d3ef975d85991f86b5fa builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
In file included from :0:0:
include/linux/ioasid.h: In function 'ioasid_set_data':
>> include/linux/ioasid.h:43:10: error: 'ENODEV' undeclared (first use in this
>> function)
return -ENODEV;
^~
include/linux/ioasid.h:43:10: note: each undeclared identifier is reported
only once for each function it appears in
vim +/ENODEV +43 include/linux/ioasid.h
40
41 static inline int ioasid_set_data(ioasid_t ioasid, void *data)
42 {
> 43 return -ENODEV;
44 }
45
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 2/4] iommu: Add I/O ASID allocator
Hi Jacob,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to v5.3 next-20190918]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Jacob-Pan/iommu-Introduce-cache_invalidate-API/20190919-072517
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.4.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
In file included from :0:0:
include/linux/ioasid.h: In function 'ioasid_set_data':
>> include/linux/ioasid.h:43:10: error: 'ENODEV' undeclared (first use in this
>> function)
return -ENODEV;
^~
include/linux/ioasid.h:43:10: note: each undeclared identifier is reported
only once for each function it appears in
vim +/ENODEV +43 include/linux/ioasid.h
40
41 static inline int ioasid_set_data(ioasid_t ioasid, void *data)
42 {
> 43 return -ENODEV;
44 }
45
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH] PCI: Remove unused includes and superfluous struct declaration
Hi Krzysztof, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3-rc6 next-20190830] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Krzysztof-Wilczynski/PCI-Remove-unused-includes-and-superfluous-struct-declaration/20190902-040019 config: arm64-defconfig (attached as .config) compiler: aarch64-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=arm64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All error/warnings (new ones prefixed by >>): In file included from include/linux/list.h:9:0, from include/linux/kobject.h:19, from include/linux/of.h:17, from include/linux/irqdomain.h:35, from include/linux/acpi.h:13, from include/linux/acpi_iort.h:10, from drivers/irqchip/irq-gic-v3-its-pci-msi.c:7: drivers/irqchip/irq-gic-v3-its-pci-msi.c: In function 'its_pci_msi_vec_count': >> drivers/irqchip/irq-gic-v3-its-pci-msi.c:37:12: error: implicit declaration >> of function 'pci_msi_vec_count'; did you mean 'its_pci_msi_vec_count'? >> [-Werror=implicit-function-declaration] msi = max(pci_msi_vec_count(pdev), 0); ^ include/linux/kernel.h:821:22: note: in definition of macro '__typecheck' (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) ^ include/linux/kernel.h:845:24: note: in expansion of macro '__safe_cmp' __builtin_choose_expr(__safe_cmp(x, y), \ ^~ include/linux/kernel.h:861:19: note: in expansion of macro '__careful_cmp' #define max(x, y) __careful_cmp(x, y, >) ^ >> drivers/irqchip/irq-gic-v3-its-pci-msi.c:37:8: note: in expansion of macro >> 'max' msi = max(pci_msi_vec_count(pdev), 0); ^~~ >> drivers/irqchip/irq-gic-v3-its-pci-msi.c:38:13: error: implicit declaration >> of function 'pci_msix_vec_count'; did you mean 'its_pci_msi_vec_count'? >> [-Werror=implicit-function-declaration] msix = max(pci_msix_vec_count(pdev), 0); ^ include/linux/kernel.h:821:22: note: in definition of macro '__typecheck' (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) ^ include/linux/kernel.h:845:24: note: in expansion of macro '__safe_cmp' __builtin_choose_expr(__safe_cmp(x, y), \ ^~ include/linux/kernel.h:861:19: note: in expansion of macro '__careful_cmp' #define max(x, y) __careful_cmp(x, y, >) ^ drivers/irqchip/irq-gic-v3-its-pci-msi.c:38:9: note: in expansion of macro 'max' msix = max(pci_msix_vec_count(pdev), 0); ^~~ drivers/irqchip/irq-gic-v3-its-pci-msi.c: In function 'its_pci_msi_prepare': >> drivers/irqchip/irq-gic-v3-its-pci-msi.c:60:7: error: implicit declaration >> of function 'dev_is_pci'; did you mean 'dev_to_psd'? >> [-Werror=implicit-function-declaration] if (!dev_is_pci(dev)) ^~ dev_to_psd >> drivers/irqchip/irq-gic-v3-its-pci-msi.c:65:9: error: implicit declaration >> of function 'to_pci_dev'; did you mean 'atomic_dec'? >> [-Werror=implicit-function-declaration] pdev = to_pci_dev(dev); ^~ atomic_dec >> drivers/irqchip/irq-gic-v3-its-pci-msi.c:65:7: warning: assignment makes >> pointer from integer without a cast [-Wint-conversion] pdev = to_pci_dev(dev); ^ >> drivers/irqchip/irq-gic-v3-its-pci-msi.c:70:2: error: implicit declaration >> of function 'pci_for_each_dma_alias'; did you mean 'xas_for_each_conflict'? >> [-Werror=implicit-function-declaration] pci_for_each_dma_alias(pdev, its_get_pci_alias, _dev); ^~ xas_for_each_conflict >> drivers/irqchip/irq-gic-v3-its-pci-msi.c:71:36: error: dereferencing pointer >> to incomplete type 'struct pci_dev' if (alias_dev != pdev && alias_dev->subordinate) ^~ >> drivers/irqchip/irq-gic-v3-its-pci-msi.c:72:3: error: implicit declaration >> of function 'pci_walk_bus' [-Werror=implicit-function-declaration] pci_walk_bus(alias_dev->subordinate, its_pci_msi_vec_count, ^~~~ cc1: some warnings being treated as errors -- drivers/irqchip/irq-gic-v2m.c: In function 'gicv2m_acpi_init': >> drivers/irqchip/irq-gic-v2m.c:558:2: error: implicit declaration of function >
Re: [PATCH] PCI: Remove unused includes and superfluous struct declaration
Hi Krzysztof,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc6 next-20190830]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Krzysztof-Wilczynski/PCI-Remove-unused-includes-and-superfluous-struct-declaration/20190902-040019
config: x86_64-randconfig-f004-201935 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-11) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
In file included from :0:0:
include/linux/of_pci.h: In function 'of_pci_get_devfn':
>> include/linux/of_pci.h:24:10: error: 'EINVAL' undeclared (first use in this
>> function)
return -EINVAL;
^~
include/linux/of_pci.h:24:10: note: each undeclared identifier is reported
only once for each function it appears in
vim +/EINVAL +24 include/linux/of_pci.h
64c5c759084e153 Arnd Bergmann 2014-06-04 21
64c5c759084e153 Arnd Bergmann 2014-06-04 22 static inline int
of_pci_get_devfn(struct device_node *np)
64c5c759084e153 Arnd Bergmann 2014-06-04 23 {
64c5c759084e153 Arnd Bergmann 2014-06-04 @24return -EINVAL;
64c5c759084e153 Arnd Bergmann 2014-06-04 25 }
64c5c759084e153 Arnd Bergmann 2014-06-04 26
:: The code at line 24 was first introduced by commit
:: 64c5c759084e153272eb05f4103de3e0adf5a88a of/irq: provide more wrappers
for !CONFIG_OF
:: TO: Arnd Bergmann
:: CC: Rob Herring
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 2/2] ARM: OMAP2+: Add pdata for OMAP3 ISP IOMMU
Hi Suman,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on arm/for-next]
[cannot apply to v5.3-rc6 next-20190827]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Suman-Anna/OMAP-IOMMU-fixes-to-go-with-5-4-OMAP-IOMMU-changes/20190827-121217
base: git://git.armlinux.org.uk/~rmk/linux-arm.git for-next
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
arch/arm/mach-omap2/pdata-quirks.c:92:3: error: 'struct iommu_platform_data'
has no member named 'device_enable'
.device_enable = omap_device_enable,
^
arch/arm/mach-omap2/pdata-quirks.c:92:19: warning: excess elements in struct
initializer
.device_enable = omap_device_enable,
^~
arch/arm/mach-omap2/pdata-quirks.c:92:19: note: (near initialization for
'omap3_iommu_pdata')
arch/arm/mach-omap2/pdata-quirks.c:93:3: error: 'struct iommu_platform_data'
has no member named 'device_idle'
.device_idle = omap_device_idle,
^~~
arch/arm/mach-omap2/pdata-quirks.c:93:17: warning: excess elements in struct
initializer
.device_idle = omap_device_idle,
^~~~
arch/arm/mach-omap2/pdata-quirks.c:93:17: note: (near initialization for
'omap3_iommu_pdata')
arch/arm/mach-omap2/pdata-quirks.c:97:3: error: 'struct iommu_platform_data'
has no member named 'device_enable'
.device_enable = omap_device_enable,
^
>> arch/arm/mach-omap2/pdata-quirks.c:97:19: error: initialization from
>> incompatible pointer type [-Werror=incompatible-pointer-types]
.device_enable = omap_device_enable,
^~
arch/arm/mach-omap2/pdata-quirks.c:97:19: note: (near initialization for
'omap3_iommu_isp_pdata.reset_name')
arch/arm/mach-omap2/pdata-quirks.c:98:3: error: 'struct iommu_platform_data'
has no member named 'device_idle'
.device_idle = omap_device_idle,
^~~
arch/arm/mach-omap2/pdata-quirks.c:98:17: error: initialization from
incompatible pointer type [-Werror=incompatible-pointer-types]
.device_idle = omap_device_idle,
^~~~
arch/arm/mach-omap2/pdata-quirks.c:98:17: note: (near initialization for
'omap3_iommu_isp_pdata.assert_reset')
arch/arm/mach-omap2/pdata-quirks.c:434:3: error: 'struct
iommu_platform_data' has no member named 'device_enable'
.device_enable = omap_device_enable,
^
arch/arm/mach-omap2/pdata-quirks.c:434:19: warning: excess elements in
struct initializer
.device_enable = omap_device_enable,
^~
arch/arm/mach-omap2/pdata-quirks.c:434:19: note: (near initialization for
'omap4_iommu_pdata')
arch/arm/mach-omap2/pdata-quirks.c:435:3: error: 'struct
iommu_platform_data' has no member named 'device_idle'
.device_idle = omap_device_idle,
^~~
arch/arm/mach-omap2/pdata-quirks.c:435:17: warning: excess elements in
struct initializer
.device_idle = omap_device_idle,
^~~~
arch/arm/mach-omap2/pdata-quirks.c:435:17: note: (near initialization for
'omap4_iommu_pdata')
cc1: some warnings being treated as errors
vim +97 arch/arm/mach-omap2/pdata-quirks.c
87
88 static struct iommu_platform_data omap3_iommu_pdata = {
89 .reset_name = "mmu",
90 .assert_reset = omap_device_assert_hardreset,
91 .deassert_reset = omap_device_deassert_hardreset,
92 .device_enable = omap_device_enable,
> 93 .device_idle = omap_device_idle,
94 };
95
96 static struct iommu_platform_data omap3_iommu_isp_pdata = {
> 97 .device_enable = omap_device_enable,
98 .device_idle = omap_device_idle,
99 };
100
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 1/2] ARM: OMAP2+: Plug in device_enable/idle ops for IOMMUs
Hi Suman,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on arm/for-next]
[cannot apply to v5.3-rc6 next-20190826]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Suman-Anna/OMAP-IOMMU-fixes-to-go-with-5-4-OMAP-IOMMU-changes/20190827-121217
base: git://git.armlinux.org.uk/~rmk/linux-arm.git for-next
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All error/warnings (new ones prefixed by >>):
>> arch/arm/mach-omap2/pdata-quirks.c:92:3: error: 'struct iommu_platform_data'
>> has no member named 'device_enable'
.device_enable = omap_device_enable,
^
>> arch/arm/mach-omap2/pdata-quirks.c:92:19: warning: excess elements in struct
>> initializer
.device_enable = omap_device_enable,
^~
arch/arm/mach-omap2/pdata-quirks.c:92:19: note: (near initialization for
'omap3_iommu_pdata')
>> arch/arm/mach-omap2/pdata-quirks.c:93:3: error: 'struct iommu_platform_data'
>> has no member named 'device_idle'
.device_idle = omap_device_idle,
^~~
arch/arm/mach-omap2/pdata-quirks.c:93:17: warning: excess elements in struct
initializer
.device_idle = omap_device_idle,
^~~~
arch/arm/mach-omap2/pdata-quirks.c:93:17: note: (near initialization for
'omap3_iommu_pdata')
arch/arm/mach-omap2/pdata-quirks.c:429:3: error: 'struct
iommu_platform_data' has no member named 'device_enable'
.device_enable = omap_device_enable,
^
arch/arm/mach-omap2/pdata-quirks.c:429:19: warning: excess elements in
struct initializer
.device_enable = omap_device_enable,
^~
arch/arm/mach-omap2/pdata-quirks.c:429:19: note: (near initialization for
'omap4_iommu_pdata')
arch/arm/mach-omap2/pdata-quirks.c:430:3: error: 'struct
iommu_platform_data' has no member named 'device_idle'
.device_idle = omap_device_idle,
^~~
arch/arm/mach-omap2/pdata-quirks.c:430:17: warning: excess elements in
struct initializer
.device_idle = omap_device_idle,
^~~~
arch/arm/mach-omap2/pdata-quirks.c:430:17: note: (near initialization for
'omap4_iommu_pdata')
vim +92 arch/arm/mach-omap2/pdata-quirks.c
87
88 static struct iommu_platform_data omap3_iommu_pdata = {
89 .reset_name = "mmu",
90 .assert_reset = omap_device_assert_hardreset,
91 .deassert_reset = omap_device_deassert_hardreset,
> 92 .device_enable = omap_device_enable,
> 93 .device_idle = omap_device_idle,
94 };
95
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v2] iommu/amd: Override wrong IVRS IOAPIC on Raven Ridge systems
Hi Kai-Heng,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc5 next-20190816]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Kai-Heng-Feng/iommu-amd-Override-wrong-IVRS-IOAPIC-on-Raven-Ridge-systems/20190819-133843
config: x86_64-randconfig-f001-201933 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
>> drivers//iommu/amd_iommu_quirks.c:87:13: error: redefinition of
>> 'amd_iommu_apply_ivrs_quirks'
void __init amd_iommu_apply_ivrs_quirks(void)
^~~
In file included from drivers//iommu/amd_iommu_quirks.c:11:0:
drivers//iommu/amd_iommu.h:11:13: note: previous definition of
'amd_iommu_apply_ivrs_quirks' was here
static void amd_iommu_apply_ivrs_quirks(void) { }
^~~
drivers//iommu/amd_iommu.h:11:13: warning: 'amd_iommu_apply_ivrs_quirks'
defined but not used [-Wunused-function]
vim +/amd_iommu_apply_ivrs_quirks +87 drivers//iommu/amd_iommu_quirks.c
86
> 87 void __init amd_iommu_apply_ivrs_quirks(void)
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 2/3] DMA mapping: Move SME handling to x86-specific files
Hi Thiago,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to v5.2 next-20190718]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Thiago-Jung-Bauermann/Remove-x86-specific-code-from-generic-headers/20190715-063006
config: s390-allnoconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 7.4.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
kernel/dma/swiotlb.c: In function 'swiotlb_tbl_map_single':
>> kernel/dma/swiotlb.c:461:6: error: implicit declaration of function
>> 'mem_encrypt_active'; did you mean 'set_cpu_active'?
>> [-Werror=implicit-function-declaration]
if (mem_encrypt_active())
^~
set_cpu_active
cc1: some warnings being treated as errors
vim +461 kernel/dma/swiotlb.c
1b548f667c1487d lib/swiotlb.c Jeremy Fitzhardinge 2008-12-16 442
e05ed4d1fad9e73 lib/swiotlb.c Alexander Duyck 2012-10-15 443
phys_addr_t swiotlb_tbl_map_single(struct device *hwdev,
e05ed4d1fad9e73 lib/swiotlb.c Alexander Duyck 2012-10-15 444
dma_addr_t tbl_dma_addr,
e05ed4d1fad9e73 lib/swiotlb.c Alexander Duyck 2012-10-15 445
phys_addr_t orig_addr, size_t size,
0443fa003fa199f lib/swiotlb.c Alexander Duyck 2016-11-02 446
enum dma_data_direction dir,
0443fa003fa199f lib/swiotlb.c Alexander Duyck 2016-11-02 447
unsigned long attrs)
^1da177e4c3f415 arch/ia64/lib/swiotlb.c Linus Torvalds2005-04-16 448 {
^1da177e4c3f415 arch/ia64/lib/swiotlb.c Linus Torvalds2005-04-16 449
unsigned long flags;
e05ed4d1fad9e73 lib/swiotlb.c Alexander Duyck 2012-10-15 450
phys_addr_t tlb_addr;
^1da177e4c3f415 arch/ia64/lib/swiotlb.c Linus Torvalds2005-04-16 451
unsigned int nslots, stride, index, wrap;
^1da177e4c3f415 arch/ia64/lib/swiotlb.c Linus Torvalds2005-04-16 452
int i;
681cc5cd3efbeaf lib/swiotlb.c FUJITA Tomonori 2008-02-04 453
unsigned long mask;
681cc5cd3efbeaf lib/swiotlb.c FUJITA Tomonori 2008-02-04 454
unsigned long offset_slots;
681cc5cd3efbeaf lib/swiotlb.c FUJITA Tomonori 2008-02-04 455
unsigned long max_slots;
53b29c336830db4 kernel/dma/swiotlb.cDongli Zhang 2019-04-12 456
unsigned long tmp_io_tlb_used;
681cc5cd3efbeaf lib/swiotlb.c FUJITA Tomonori 2008-02-04 457
ac2cbab21f318e1 lib/swiotlb.c Yinghai Lu2013-01-24 458
if (no_iotlb_memory)
ac2cbab21f318e1 lib/swiotlb.c Yinghai Lu2013-01-24 459
panic("Can not allocate SWIOTLB buffer earlier and can't now provide
you with the DMA bounce buffer");
ac2cbab21f318e1 lib/swiotlb.c Yinghai Lu2013-01-24 460
d7b417fa08d1187 lib/swiotlb.c Tom Lendacky 2017-10-20 @461
if (mem_encrypt_active())
aa4d0dc3e029b79 kernel/dma/swiotlb.cThiago Jung Bauermann 2019-07-12 462
pr_warn_once("Memory encryption is active and system is using DMA
bounce buffers\n");
648babb7078c631 lib/swiotlb.c Tom Lendacky 2017-07-17 463
681cc5cd3efbeaf lib/swiotlb.c FUJITA Tomonori 2008-02-04 464
mask = dma_get_seg_boundary(hwdev);
681cc5cd3efbeaf lib/swiotlb.c FUJITA Tomonori 2008-02-04 465
eb605a5754d050a lib/swiotlb.c FUJITA Tomonori 2010-05-10 466
tbl_dma_addr &= mask;
eb605a5754d050a lib/swiotlb.c FUJITA Tomonori 2010-05-10 467
eb605a5754d050a lib/swiotlb.c FUJITA Tomonori 2010-05-10 468
offset_slots = ALIGN(tbl_dma_addr, 1 << IO_TLB_SHIFT) >> IO_TLB_SHIFT;
a5ddde4a558b3bd lib/swiotlb.c Ian Campbell 2008-12-16 469
a5ddde4a558b3bd lib/swiotlb.c Ian Campbell 2008-12-16 470
/*
a5ddde4a558b3bd lib/swiotlb.c Ian Campbell 2008-12-16 471
* Carefully handle integer overflow which can occur when mask == ~0UL.
a5ddde4a558b3bd lib/swiotlb.c Ian Campbell 2008-12-16 472
*/
b15a3891c916f32 lib/swiotlb.c Jan Beulich 2008-03-13 473
max_slots = mask + 1
b15a3891c916f32 lib/swiotlb.c Jan Beulich 2008-03-13 474
? ALIGN(mask + 1, 1 << IO_TLB_SHIFT) &
[RFC PATCH] vfio: vfio_iommu_type1: vfio_iommu_type1_caps() can be static
Fixes: f10b2b74bbea ("vfio: vfio_iommu_type1: implement
VFIO_IOMMU_INFO_CAPABILITIES")
Signed-off-by: kbuild test robot
---
vfio_iommu_type1.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c
index 9435647..46a4939 100644
--- a/drivers/vfio/vfio_iommu_type1.c
+++ b/drivers/vfio/vfio_iommu_type1.c
@@ -1704,8 +1704,8 @@ static int vfio_iommu_type1_zpci_grp(struct iommu_domain
*domain,
return ret;
}
-int vfio_iommu_type1_caps(struct vfio_iommu *iommu, struct vfio_info_cap *caps,
- size_t size)
+static int vfio_iommu_type1_caps(struct vfio_iommu *iommu, struct
vfio_info_cap *caps,
+size_t size)
{
struct vfio_domain *d;
unsigned long total_size, fn_size, grp_size;
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v2 4/4] vfio: vfio_iommu_type1: implement VFIO_IOMMU_INFO_CAPABILITIES
Hi Pierre, I love your patch! Perhaps something to improve: [auto build test WARNING on s390/features] [also build test WARNING on v5.1 next-20190517] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Pierre-Morel/s390-pci-Exporting-access-to-CLP-PCI-function-and-PCI-group/20190520-025155 base: https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) >> drivers/vfio/vfio_iommu_type1.c:1707:5: sparse: sparse: symbol >> 'vfio_iommu_type1_caps' was not declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
[iommu:hyper-v 1/3] arch/x86//kernel/cpu/mshyperv.c:339:3: error: 'x2apic_phys' undeclared; did you mean 'x2apic_mode'?
tree: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git hyper-v head: bb564d53ed035865e85f16acf217dee93705e518 commit: 67938046f7991474f94ad85da3f8e43c0cf510c0 [1/3] x86/Hyper-V: Set x2apic destination mode to physical when x2apic is available config: x86_64-randconfig-x014-201908 (attached as .config) compiler: gcc-8 (Debian 8.2.0-20) 8.2.0 reproduce: git checkout 67938046f7991474f94ad85da3f8e43c0cf510c0 # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): arch/x86//kernel/cpu/mshyperv.c: In function 'ms_hyperv_init_platform': >> arch/x86//kernel/cpu/mshyperv.c:339:3: error: 'x2apic_phys' undeclared >> (first use in this function); did you mean 'x2apic_mode'? x2apic_phys = 1; ^~~ x2apic_mode arch/x86//kernel/cpu/mshyperv.c:339:3: note: each undeclared identifier is reported only once for each function it appears in vim +339 arch/x86//kernel/cpu/mshyperv.c 331 332 /* 333 * Hyper-V doesn't provide irq remapping for IO-APIC. To enable x2apic, 334 * set x2apic destination mode to physcial mode when x2apic is available 335 * and Hyper-V IOMMU driver makes sure cpus assigned with IO-APIC irqs 336 * have 8-bit APIC id. 337 */ 338 if (IS_ENABLED(CONFIG_X86_X2APIC) && x2apic_supported()) > 339 x2apic_phys = 1; 340 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
[iommu:hyper-v 2/3] drivers/iommu/hyperv-iommu.c:62:14: error: 'apic_ack_irq' undeclared here (not in a function)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git hyper-v
head: bb564d53ed035865e85f16acf217dee93705e518
commit: 004240dcc222119271ce9559af4250ab00053621 [2/3] iommu/hyper-v: Add
Hyper-V stub IOMMU driver
config: x86_64-randconfig-r0-02270133 (attached as .config)
compiler: gcc-6 (Debian 6.5.0-2) 6.5.0 20181026
reproduce:
git checkout 004240dcc222119271ce9559af4250ab00053621
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
>> drivers/iommu/hyperv-iommu.c:62:14: error: 'apic_ack_irq' undeclared here
>> (not in a function)
.irq_ack = apic_ack_irq,
^~~~
drivers/iommu/hyperv-iommu.c: In function 'hyperv_prepare_irq_remapping':
>> drivers/iommu/hyperv-iommu.c:144:7: error: implicit declaration of function
>> 'x2apic_supported' [-Werror=implicit-function-declaration]
!x2apic_supported())
^~~~
>> drivers/iommu/hyperv-iommu.c:169:7: error: implicit declaration of function
>> 'cpu_physical_id' [-Werror=implicit-function-declaration]
if (cpu_physical_id(i) < 256)
^~~
cc1: some warnings being treated as errors
vim +/apic_ack_irq +62 drivers/iommu/hyperv-iommu.c
59
60 static struct irq_chip hyperv_ir_chip = {
61 .name = "HYPERV-IR",
> 62 .irq_ack= apic_ack_irq,
63 .irq_set_affinity = hyperv_ir_set_affinity,
64 };
65
66 static int hyperv_irq_remapping_alloc(struct irq_domain *domain,
67 unsigned int virq, unsigned int
nr_irqs,
68 void *arg)
69 {
70 struct irq_alloc_info *info = arg;
71 struct irq_data *irq_data;
72 struct irq_desc *desc;
73 int ret = 0;
74
75 if (!info || info->type != X86_IRQ_ALLOC_TYPE_IOAPIC || nr_irqs
> 1)
76 return -EINVAL;
77
78 ret = irq_domain_alloc_irqs_parent(domain, virq, nr_irqs, arg);
79 if (ret < 0)
80 return ret;
81
82 irq_data = irq_domain_get_irq_data(domain, virq);
83 if (!irq_data) {
84 irq_domain_free_irqs_common(domain, virq, nr_irqs);
85 return -EINVAL;
86 }
87
88 irq_data->chip = _ir_chip;
89
90 /*
91 * If there is interrupt remapping function of IOMMU, setting
irq
92 * affinity only needs to change IRTE of IOMMU. But Hyper-V
doesn't
93 * support interrupt remapping function, setting irq affinity
of IO-APIC
94 * interrupts still needs to change IO-APIC registers. But
ioapic_
95 * configure_entry() will ignore value of cfg->vector and cfg->
96 * dest_apicid when IO-APIC's parent irq domain is not the
vector
97 * domain.(See ioapic_configure_entry()) In order to setting
vector
98 * and dest_apicid to IO-APIC register, IO-APIC entry pointer
is saved
99 * in the chip_data and
hyperv_irq_remapping_activate()/hyperv_ir_set_
100 * affinity() set vector and dest_apicid directly into IO-APIC
entry.
101 */
102 irq_data->chip_data = info->ioapic_entry;
103
104 /*
105 * Hypver-V IO APIC irq affinity should be in the scope of
106 * ioapic_max_cpumask because no irq remapping support.
107 */
108 desc = irq_data_to_desc(irq_data);
109 cpumask_copy(desc->irq_common_data.affinity,
_max_cpumask);
110
111 return 0;
112 }
113
114 static void hyperv_irq_remapping_free(struct irq_domain *domain,
115 unsigned int virq, unsigned int
nr_irqs)
116 {
117 irq_domain_free_irqs_common(domain, virq, nr_irqs);
118 }
119
120 static int hyperv_irq_remapping_activate(struct irq_domain *domain,
121struct irq_data *irq_data, bool reserve)
122 {
123 struct irq_cfg *cfg = irqd_cfg(irq_data);
124 struct IO_APIC_route_entry *entry = irq_data->chip_data;
125
126 entry->dest = cfg->dest_apicid;
127 entry->vector = cfg->vector;
128
129 return 0;
130 }
131
132 static struct irq_domain_ops hyperv_ir_domain_ops = {
133 .alloc = hyperv_irq_remapping_alloc,
134 .free = hyperv_irq_remapping_free,
135 .activate = hyperv_irq_remapping_activate,
136 };
137
138 static int __init hyperv_prepare_irq_remapping(void)
139 {
140 struct fwnode_handle *fn;
141 int i;
142
143 if (!hypervisor_is_type(X86_HYPER_MS_HYPERV) ||
> 144
[iommu:hyper-v 2/3] drivers//iommu/hyperv-iommu.c:62:14: error: 'apic_ack_irq' undeclared here (not in a function); did you mean 'apic_ack_edge'?
tree: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git hyper-v
head: bb564d53ed035865e85f16acf217dee93705e518
commit: 004240dcc222119271ce9559af4250ab00053621 [2/3] iommu/hyper-v: Add
Hyper-V stub IOMMU driver
config: x86_64-randconfig-s3-02270001 (attached as .config)
compiler: gcc-8 (Debian 8.2.0-20) 8.2.0
reproduce:
git checkout 004240dcc222119271ce9559af4250ab00053621
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
>> drivers//iommu/hyperv-iommu.c:62:14: error: 'apic_ack_irq' undeclared here
>> (not in a function); did you mean 'apic_ack_edge'?
.irq_ack = apic_ack_irq,
^~~~
apic_ack_edge
drivers//iommu/hyperv-iommu.c: In function 'hyperv_prepare_irq_remapping':
>> drivers//iommu/hyperv-iommu.c:144:7: error: implicit declaration of function
>> 'x2apic_supported'; did you mean 'device_dma_supported'?
>> [-Werror=implicit-function-declaration]
!x2apic_supported())
^~~~
device_dma_supported
>> drivers//iommu/hyperv-iommu.c:169:7: error: implicit declaration of function
>> 'cpu_physical_id'; did you mean 'cpu_possible'?
>> [-Werror=implicit-function-declaration]
if (cpu_physical_id(i) < 256)
^~~
cpu_possible
cc1: some warnings being treated as errors
vim +62 drivers//iommu/hyperv-iommu.c
59
60 static struct irq_chip hyperv_ir_chip = {
61 .name = "HYPERV-IR",
> 62 .irq_ack= apic_ack_irq,
63 .irq_set_affinity = hyperv_ir_set_affinity,
64 };
65
66 static int hyperv_irq_remapping_alloc(struct irq_domain *domain,
67 unsigned int virq, unsigned int
nr_irqs,
68 void *arg)
69 {
70 struct irq_alloc_info *info = arg;
71 struct irq_data *irq_data;
72 struct irq_desc *desc;
73 int ret = 0;
74
75 if (!info || info->type != X86_IRQ_ALLOC_TYPE_IOAPIC || nr_irqs
> 1)
76 return -EINVAL;
77
78 ret = irq_domain_alloc_irqs_parent(domain, virq, nr_irqs, arg);
79 if (ret < 0)
80 return ret;
81
82 irq_data = irq_domain_get_irq_data(domain, virq);
83 if (!irq_data) {
84 irq_domain_free_irqs_common(domain, virq, nr_irqs);
85 return -EINVAL;
86 }
87
88 irq_data->chip = _ir_chip;
89
90 /*
91 * If there is interrupt remapping function of IOMMU, setting
irq
92 * affinity only needs to change IRTE of IOMMU. But Hyper-V
doesn't
93 * support interrupt remapping function, setting irq affinity
of IO-APIC
94 * interrupts still needs to change IO-APIC registers. But
ioapic_
95 * configure_entry() will ignore value of cfg->vector and cfg->
96 * dest_apicid when IO-APIC's parent irq domain is not the
vector
97 * domain.(See ioapic_configure_entry()) In order to setting
vector
98 * and dest_apicid to IO-APIC register, IO-APIC entry pointer
is saved
99 * in the chip_data and
hyperv_irq_remapping_activate()/hyperv_ir_set_
100 * affinity() set vector and dest_apicid directly into IO-APIC
entry.
101 */
102 irq_data->chip_data = info->ioapic_entry;
103
104 /*
105 * Hypver-V IO APIC irq affinity should be in the scope of
106 * ioapic_max_cpumask because no irq remapping support.
107 */
108 desc = irq_data_to_desc(irq_data);
109 cpumask_copy(desc->irq_common_data.affinity,
_max_cpumask);
110
111 return 0;
112 }
113
114 static void hyperv_irq_remapping_free(struct irq_domain *domain,
115 unsigned int virq, unsigned int
nr_irqs)
116 {
117 irq_domain_free_irqs_common(domain, virq, nr_irqs);
118 }
119
120 static int hyperv_irq_remapping_activate(struct irq_domain *domain,
121struct irq_data *irq_data, bool reserve)
122 {
123 struct irq_cfg *cfg = irqd_cfg(irq_data);
124 struct IO_APIC_route_entry *entry = irq_data->chip_data;
125
126 entry->dest = cfg->dest_apicid;
127 entry->vector = cfg->vector;
128
129 return 0;
130 }
131
132 static struct irq_domain_ops hyperv_ir_domain_ops = {
133 .alloc = hyperv_irq_remapping_alloc,
134 .free = hyperv_irq_remapping_free,
135 .activate = hyperv_irq_remapping_activate,
136 };
137
138 static int __init
[iommu:hyper-v 1/3] arch/x86//kernel/cpu/mshyperv.c:339:3: error: 'x2apic_phys' undeclared
tree: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git hyper-v head: bb564d53ed035865e85f16acf217dee93705e518 commit: 67938046f7991474f94ad85da3f8e43c0cf510c0 [1/3] x86/Hyper-V: Set x2apic destination mode to physical when x2apic is available config: x86_64-randconfig-s2-02270010 (attached as .config) compiler: gcc-6 (Debian 6.5.0-2) 6.5.0 20181026 reproduce: git checkout 67938046f7991474f94ad85da3f8e43c0cf510c0 # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): arch/x86//kernel/cpu/mshyperv.c: In function 'ms_hyperv_init_platform': >> arch/x86//kernel/cpu/mshyperv.c:339:3: error: 'x2apic_phys' undeclared >> (first use in this function) x2apic_phys = 1; ^~~ arch/x86//kernel/cpu/mshyperv.c:339:3: note: each undeclared identifier is reported only once for each function it appears in vim +/x2apic_phys +339 arch/x86//kernel/cpu/mshyperv.c 331 332 /* 333 * Hyper-V doesn't provide irq remapping for IO-APIC. To enable x2apic, 334 * set x2apic destination mode to physcial mode when x2apic is available 335 * and Hyper-V IOMMU driver makes sure cpus assigned with IO-APIC irqs 336 * have 8-bit APIC id. 337 */ 338 if (IS_ENABLED(CONFIG_X86_X2APIC) && x2apic_supported()) > 339 x2apic_phys = 1; 340 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH V2 1/3] x86/Hyper-V: Set x2apic destination mode to physical when x2apic is available
Hi Lan, Thank you for the patch! Yet something to improve: [auto build test ERROR on iommu/next] [also build test ERROR on v5.0-rc4 next-20190204] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/lantianyu1986-gmail-com/x86-Hyper-V-IOMMU-Add-Hyper-V-IOMMU-driver-to-support-x2apic-mode/20190204-132009 base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next config: i386-randconfig-a3-02040849 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): arch/x86/kernel/cpu/mshyperv.c: In function 'ms_hyperv_init_platform': >> arch/x86/kernel/cpu/mshyperv.c:339:3: error: 'x2apic_phys' undeclared (first >> use in this function) x2apic_phys = 1; ^ arch/x86/kernel/cpu/mshyperv.c:339:3: note: each undeclared identifier is reported only once for each function it appears in vim +/x2apic_phys +339 arch/x86/kernel/cpu/mshyperv.c 331 332 /* 333 * Hyper-V doesn't provide irq remapping for IO-APIC. To enable x2apic, 334 * set x2apic destination mode to physcial mode when x2apic is available 335 * and Hyper-V IOMMU driver makes sure cpus assigned with IO-APIC irqs 336 * have 8-bit APIC id. 337 */ 338 if (IS_ENABLED(CONFIG_HYPERV_IOMMU) && x2apic_supported()) > 339 x2apic_phys = 1; 340 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH V2 1/3] x86/Hyper-V: Set x2apic destination mode to physical when x2apic is available
Hi Lan, Thank you for the patch! Yet something to improve: [auto build test ERROR on iommu/next] [also build test ERROR on v5.0-rc4 next-20190201] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/lantianyu1986-gmail-com/x86-Hyper-V-IOMMU-Add-Hyper-V-IOMMU-driver-to-support-x2apic-mode/20190204-132009 base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next config: x86_64-randconfig-x005-201905 (attached as .config) compiler: gcc-8 (Debian 8.2.0-14) 8.2.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): arch/x86//kernel/cpu/mshyperv.c: In function 'ms_hyperv_init_platform': >> arch/x86//kernel/cpu/mshyperv.c:339:3: error: 'x2apic_phys' undeclared >> (first use in this function); did you mean 'x2apic_mode'? x2apic_phys = 1; ^~~ x2apic_mode arch/x86//kernel/cpu/mshyperv.c:339:3: note: each undeclared identifier is reported only once for each function it appears in vim +339 arch/x86//kernel/cpu/mshyperv.c 331 332 /* 333 * Hyper-V doesn't provide irq remapping for IO-APIC. To enable x2apic, 334 * set x2apic destination mode to physcial mode when x2apic is available 335 * and Hyper-V IOMMU driver makes sure cpus assigned with IO-APIC irqs 336 * have 8-bit APIC id. 337 */ 338 if (IS_ENABLED(CONFIG_HYPERV_IOMMU) && x2apic_supported()) > 339 x2apic_phys = 1; 340 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH] swiotlb: Return error from swiotlb_init_with_tbl()
Hi Joerg,
I love your patch! Perhaps something to improve:
[auto build test WARNING on swiotlb/linux-next]
[also build test WARNING on v5.0-rc4]
[cannot apply to next-20190201]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Joerg-Roedel/swiotlb-Return-error-from-swiotlb_init_with_tbl/20190203-013129
base: https://git.kernel.org/pub/scm/linux/kernel/git/konrad/swiotlb.git
linux-next
config: riscv-tinyconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 8.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=8.2.0 make.cross ARCH=riscv
All warnings (new ones prefixed by >>):
kernel/dma/swiotlb.c: In function 'swiotlb_init_with_tbl':
>> kernel/dma/swiotlb.c:230:17: warning: passing argument 1 of 'memblock_free'
>> makes integer from pointer without a cast [-Wint-conversion]
memblock_free(io_tlb_list,
^~~
In file included from kernel/dma/swiotlb.c:42:
include/linux/memblock.h:123:31: note: expected 'phys_addr_t' {aka 'long
long unsigned int'} but argument is of type 'unsigned int *'
int memblock_free(phys_addr_t base, phys_addr_t size);
^~~~
kernel/dma/swiotlb.c:234:17: warning: passing argument 1 of 'memblock_free'
makes integer from pointer without a cast [-Wint-conversion]
memblock_free(io_tlb_orig_addr,
^~~~
In file included from kernel/dma/swiotlb.c:42:
include/linux/memblock.h:123:31: note: expected 'phys_addr_t' {aka 'long
long unsigned int'} but argument is of type 'phys_addr_t *' {aka 'long long
unsigned int *'}
int memblock_free(phys_addr_t base, phys_addr_t size);
^~~~
vim +/memblock_free +230 kernel/dma/swiotlb.c
190
191 int __init swiotlb_init_with_tbl(char *tlb, unsigned long nslabs, int
verbose)
192 {
193 unsigned long i, bytes;
194
195 bytes = nslabs << IO_TLB_SHIFT;
196
197 io_tlb_nslabs = nslabs;
198 io_tlb_start = __pa(tlb);
199 io_tlb_end = io_tlb_start + bytes;
200
201 /*
202 * Allocate and initialize the free list array. This array is
used
203 * to find contiguous free memory regions of size up to
IO_TLB_SEGSIZE
204 * between io_tlb_start and io_tlb_end.
205 */
206 io_tlb_list = memblock_alloc_nopanic(
207 PAGE_ALIGN(io_tlb_nslabs * sizeof(int)),
208 PAGE_SIZE);
209 io_tlb_orig_addr = memblock_alloc_nopanic(
210 PAGE_ALIGN(io_tlb_nslabs *
sizeof(phys_addr_t)),
211 PAGE_SIZE);
212 if (io_tlb_list == NULL || io_tlb_orig_addr == NULL)
213 goto out_fail;
214
215 for (i = 0; i < io_tlb_nslabs; i++) {
216 io_tlb_list[i] = IO_TLB_SEGSIZE - OFFSET(i,
IO_TLB_SEGSIZE);
217 io_tlb_orig_addr[i] = INVALID_PHYS_ADDR;
218 }
219 io_tlb_index = 0;
220
221 if (verbose)
222 swiotlb_print_info();
223
224 swiotlb_set_max_segment(io_tlb_nslabs << IO_TLB_SHIFT);
225
226 return 0;
227
228 out_fail:
229 if (io_tlb_list)
> 230 memblock_free(io_tlb_list,
231PAGE_ALIGN(io_tlb_nslabs * sizeof(int)));
232
233 if (io_tlb_orig_addr)
234 memblock_free(io_tlb_orig_addr,
235PAGE_ALIGN(io_tlb_nslabs *
sizeof(phys_addr_t)));
236
237 io_tlb_list = NULL;
238 io_tlb_orig_addr = NULL;
239 io_tlb_end = 0;
240 io_tlb_start = 0;
241 io_tlb_nslabs= 0;
242 max_segment = 0;
243
244 return -ENOMEM;
245 }
246
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 3/3] iommu/tegra194_smmu: Add Tegra194 SMMU driver
Hi Krishna, Thank you for the patch! Yet something to improve: [auto build test ERROR on iommu/next] [also build test ERROR on next-20181019] [cannot apply to v4.19] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Krishna-Reddy/Add-Tegra194-Dual-ARM-SMMU-driver/20181024-123501 base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next config: arm-multi_v7_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=arm All errors (new ones prefixed by >>): drivers/iommu/tegra194-smmu.o: In function `arm_smmu_attach_dev': >> tegra194-smmu.c:(.text+0x1800): undefined reference to `alloc_io_pgtable_ops' drivers/iommu/tegra194-smmu.o: In function `arm_smmu_domain_free': >> tegra194-smmu.c:(.text+0x1af8): undefined reference to `free_io_pgtable_ops' --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 3/7] vfio: add sdmdev support
Hi Kenneth,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on cryptodev/master]
[also build test WARNING on v4.19-rc2 next-20180831]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Kenneth-Lee/A-General-Accelerator-Framework-WarpDrive/20180903-162733
base:
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
:: branch date: 2 hours ago
:: commit date: 2 hours ago
All warnings (new ones prefixed by >>):
drivers/vfio/sdmdev/vfio_sdmdev.c: In function 'vfio_sdmdev_mdev_remove':
>> drivers/vfio/sdmdev/vfio_sdmdev.c:178:2: warning: this 'if' clause does not
>> guard... [-Wmisleading-indentation]
if (sdmdev->ops->put_queue);
^~
drivers/vfio/sdmdev/vfio_sdmdev.c:179:3: note: ...this statement, but the
latter is misleadingly indented as if it were guarded by the 'if'
sdmdev->ops->put_queue(q);
^~
#
https://github.com/0day-ci/linux/commit/1e47d5e608652b4a2c813dbeaf5aa6811f6ceaf7
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 1e47d5e608652b4a2c813dbeaf5aa6811f6ceaf7
vim +/if +178 drivers/vfio/sdmdev/vfio_sdmdev.c
1e47d5e6 Kenneth Lee 2018-09-03 168
1e47d5e6 Kenneth Lee 2018-09-03 169 static int vfio_sdmdev_mdev_remove(struct
mdev_device *mdev)
1e47d5e6 Kenneth Lee 2018-09-03 170 {
1e47d5e6 Kenneth Lee 2018-09-03 171struct vfio_sdmdev_queue *q =
1e47d5e6 Kenneth Lee 2018-09-03 172(struct vfio_sdmdev_queue
*)mdev_get_drvdata(mdev);
1e47d5e6 Kenneth Lee 2018-09-03 173struct vfio_sdmdev *sdmdev = q->sdmdev;
1e47d5e6 Kenneth Lee 2018-09-03 174struct device *pdev =
mdev_parent_dev(mdev);
1e47d5e6 Kenneth Lee 2018-09-03 175
1e47d5e6 Kenneth Lee 2018-09-03 176put_device(pdev);
1e47d5e6 Kenneth Lee 2018-09-03 177
1e47d5e6 Kenneth Lee 2018-09-03 @178if (sdmdev->ops->put_queue);
1e47d5e6 Kenneth Lee 2018-09-03 179sdmdev->ops->put_queue(q);
1e47d5e6 Kenneth Lee 2018-09-03 180
1e47d5e6 Kenneth Lee 2018-09-03 181return 0;
1e47d5e6 Kenneth Lee 2018-09-03 182 }
1e47d5e6 Kenneth Lee 2018-09-03 183
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 3/7] vfio: add sdmdev support
Hi Kenneth, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on cryptodev/master] [also build test WARNING on v4.19-rc2 next-20180831] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Kenneth-Lee/A-General-Accelerator-Framework-WarpDrive/20180903-162733 base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ :: branch date: 3 hours ago :: commit date: 3 hours ago >> drivers/vfio/sdmdev/vfio_sdmdev.c:106:30: sparse: symbol >> 'vfio_sdmdev_groups' was not declared. Should it be static? drivers/vfio/sdmdev/vfio_sdmdev.c: In function 'vfio_sdmdev_mdev_remove': drivers/vfio/sdmdev/vfio_sdmdev.c:178:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (sdmdev->ops->put_queue); ^~ drivers/vfio/sdmdev/vfio_sdmdev.c:179:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if' sdmdev->ops->put_queue(q); ^~ Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
[RFC PATCH] vfio: vfio_sdmdev_groups[] can be static
Fixes: 1e47d5e60865 ("vfio: add sdmdev support")
Signed-off-by: kbuild test robot
---
vfio_sdmdev.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vfio/sdmdev/vfio_sdmdev.c
b/drivers/vfio/sdmdev/vfio_sdmdev.c
index c6eb5d4..e7d3c23 100644
--- a/drivers/vfio/sdmdev/vfio_sdmdev.c
+++ b/drivers/vfio/sdmdev/vfio_sdmdev.c
@@ -103,7 +103,7 @@ static const struct attribute_group vfio_sdmdev_group = {
.name = VFIO_SDMDEV_PDEV_ATTRS_GRP_NAME,
.attrs = vfio_sdmdev_attrs,
};
-const struct attribute_group *vfio_sdmdev_groups[] = {
+static const struct attribute_group *vfio_sdmdev_groups[] = {
_sdmdev_group,
NULL,
};
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 5/5 V4] Help to dump the old memory encrypted into vmcore file
Hi Lianbo,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.18-rc2 next-20180628]
[cannot apply to tip/x86/core]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Lianbo-Jiang/Add-a-function-ioremap_encrypted-for-kdump-when-AMD-sme-enabled/20180628-173357
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=arm64
All errors (new ones prefixed by >>):
fs/proc/vmcore.c: In function 'elfcorehdr_read':
>> fs/proc/vmcore.c:180:9: error: implicit declaration of function 'memremap';
>> did you mean 'memset_p'? [-Werror=implicit-function-declaration]
kbuf = memremap(offset, count, MEMREMAP_WB);
^~~~
memset_p
fs/proc/vmcore.c:180:33: error: 'MEMREMAP_WB' undeclared (first use in this
function)
kbuf = memremap(offset, count, MEMREMAP_WB);
^~~
fs/proc/vmcore.c:180:33: note: each undeclared identifier is reported only
once for each function it appears in
fs/proc/vmcore.c:185:2: error: implicit declaration of function 'memunmap';
did you mean 'vm_munmap'? [-Werror=implicit-function-declaration]
memunmap(kbuf);
^~~~
vm_munmap
cc1: some warnings being treated as errors
vim +180 fs/proc/vmcore.c
158
159 /*
160 * Architectures may override this function to read from ELF header.
161 * The kexec-tools will allocated the memory and build the elf header
162 * in the first kernel, subsequently, we will copy the data in the
163 * memory to the reserved crash memory. In kdump mode, we will read the
164 * elf header from the reserved crash memory, from this point of view,
165 * which is not an old memory, the original function called may mislead
166 * and do unnecessary things.
167 * For SME, it copies the elf header from the memory encrypted(user
space)
168 * to the memory unencrypted(kernel space) when SME is activated in the
169 * first kernel, this operation just leads to decryption.
170 */
171 ssize_t __weak elfcorehdr_read(char *buf, size_t count, u64 *ppos)
172 {
173 char *kbuf;
174 resource_size_t offset;
175
176 if (!count)
177 return 0;
178
179 offset = (resource_size_t)*ppos;
> 180 kbuf = memremap(offset, count, MEMREMAP_WB);
181 if (!kbuf)
182 return 0;
183
184 memcpy(buf, kbuf, count);
185 memunmap(kbuf);
186
187 return count;
188 }
189
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 5/5 V4] Help to dump the old memory encrypted into vmcore file
Hi Lianbo,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.18-rc2 next-20180628]
[cannot apply to tip/x86/core]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Lianbo-Jiang/Add-a-function-ioremap_encrypted-for-kdump-when-AMD-sme-enabled/20180628-173357
config: s390-allyesconfig (attached as .config)
compiler: s390x-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=s390
All errors (new ones prefixed by >>):
fs/proc/vmcore.c: In function 'elfcorehdr_read':
>> fs/proc/vmcore.c:180:9: error: implicit declaration of function 'memremap';
>> did you mean 'ioremap'? [-Werror=implicit-function-declaration]
kbuf = memremap(offset, count, MEMREMAP_WB);
^~~~
ioremap
>> fs/proc/vmcore.c:180:33: error: 'MEMREMAP_WB' undeclared (first use in this
>> function)
kbuf = memremap(offset, count, MEMREMAP_WB);
^~~
fs/proc/vmcore.c:180:33: note: each undeclared identifier is reported only
once for each function it appears in
>> fs/proc/vmcore.c:185:2: error: implicit declaration of function 'memunmap';
>> did you mean 'vm_munmap'? [-Werror=implicit-function-declaration]
memunmap(kbuf);
^~~~
vm_munmap
cc1: some warnings being treated as errors
vim +180 fs/proc/vmcore.c
158
159 /*
160 * Architectures may override this function to read from ELF header.
161 * The kexec-tools will allocated the memory and build the elf header
162 * in the first kernel, subsequently, we will copy the data in the
163 * memory to the reserved crash memory. In kdump mode, we will read the
164 * elf header from the reserved crash memory, from this point of view,
165 * which is not an old memory, the original function called may mislead
166 * and do unnecessary things.
167 * For SME, it copies the elf header from the memory encrypted(user
space)
168 * to the memory unencrypted(kernel space) when SME is activated in the
169 * first kernel, this operation just leads to decryption.
170 */
171 ssize_t __weak elfcorehdr_read(char *buf, size_t count, u64 *ppos)
172 {
173 char *kbuf;
174 resource_size_t offset;
175
176 if (!count)
177 return 0;
178
179 offset = (resource_size_t)*ppos;
> 180 kbuf = memremap(offset, count, MEMREMAP_WB);
181 if (!kbuf)
182 return 0;
183
184 memcpy(buf, kbuf, count);
> 185 memunmap(kbuf);
186
187 return count;
188 }
189
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 3/3] iommu/amd: Add support for IOMMU XT mode
Hi Suravee, I love your patch! Perhaps something to improve: [auto build test WARNING on iommu/next] [also build test WARNING on v4.18-rc1 next-20180622] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Suravee-Suthikulpanit/iommu-amd-Enable-x2APIC-support/20180623-032902 base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
[RFC PATCH] iommu/amd: amd_iommu_xt_mode can be static
Fixes: fec2da987eac ("iommu/amd: Add support for IOMMU XT mode")
Signed-off-by: kbuild test robot
---
amd_iommu_init.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
index 1c6f813..f6dd63f 100644
--- a/drivers/iommu/amd_iommu_init.c
+++ b/drivers/iommu/amd_iommu_init.c
@@ -153,7 +153,7 @@ bool amd_iommu_dump;
bool amd_iommu_irq_remap __read_mostly;
int amd_iommu_guest_ir = AMD_IOMMU_GUEST_IR_VAPIC;
-int amd_iommu_xt_mode = IRQ_REMAP_X2APIC_MODE;
+static int amd_iommu_xt_mode = IRQ_REMAP_X2APIC_MODE;
static bool amd_iommu_detected;
static bool __initdata amd_iommu_disabled;
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 1/2] iommu: Introduce interface for unsetting bus IOMMU
Hi Suravee, I love your patch! Perhaps something to improve: [auto build test WARNING on iommu/next] [also build test WARNING on v4.18-rc1 next-20180619] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Suravee-Suthikulpanit/iommu-amd-Handle-IOMMU-initialization-failure/20180620-022013 base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next reproduce: make htmldocs All warnings (new ones prefixed by >>): WARNING: convert(1) not found, for SVG to PDF conversion install ImageMagick (https://www.imagemagick.org) include/net/cfg80211.h:4216: warning: Function parameter or member 'wext.ibss' not described in 'wireless_dev' include/net/cfg80211.h:4216: warning: Function parameter or member 'wext.connect' not described in 'wireless_dev' include/net/cfg80211.h:4216: warning: Function parameter or member 'wext.keys' not described in 'wireless_dev' include/net/cfg80211.h:4216: warning: Function parameter or member 'wext.ie' not described in 'wireless_dev' include/net/cfg80211.h:4216: warning: Function parameter or member 'wext.ie_len' not described in 'wireless_dev' include/net/cfg80211.h:4216: warning: Function parameter or member 'wext.bssid' not described in 'wireless_dev' include/net/cfg80211.h:4216: warning: Function parameter or member 'wext.ssid' not described in 'wireless_dev' include/net/cfg80211.h:4216: warning: Function parameter or member 'wext.default_key' not described in 'wireless_dev' include/net/cfg80211.h:4216: warning: Function parameter or member 'wext.default_mgmt_key' not described in 'wireless_dev' include/net/cfg80211.h:4216: warning: Function parameter or member 'wext.prev_bssid_valid' not described in 'wireless_dev' include/net/mac80211.h:2282: warning: Function parameter or member 'radiotap_timestamp.units_pos' not described in 'ieee80211_hw' include/net/mac80211.h:2282: warning: Function parameter or member 'radiotap_timestamp.accuracy' not described in 'ieee80211_hw' include/net/mac80211.h:955: warning: Function parameter or member 'control.rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.rts_cts_rate_idx' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.use_rts' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.use_cts_prot' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.short_preamble' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.skip_table' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.jiffies' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.vif' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.hw_key' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.flags' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.enqueue_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'ack' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'ack.cookie' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.ampdu_ack_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.ampdu_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.antenna' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.tx_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.is_valid_ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.status_driver_data' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'driver_rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'pad' not described in 'ieee80211_tx_info'
Re: [PATCH] mm: convert return type of handle_mm_fault() caller to vm_fault_t
Hi Souptick,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on v4.17]
[cannot apply to linus/master powerpc/next sparc-next/master next-20180615]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Souptick-Joarder/mm-convert-return-type-of-handle_mm_fault-caller-to-vm_fault_t/20180615-030636
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=powerpc
All warnings (new ones prefixed by >>):
arch/powerpc/mm/copro_fault.c:36:5: error: conflicting types for
'copro_handle_mm_fault'
int copro_handle_mm_fault(struct mm_struct *mm, unsigned long ea,
^
In file included from arch/powerpc/mm/copro_fault.c:27:0:
arch/powerpc/include/asm/copro.h:18:5: note: previous declaration of
'copro_handle_mm_fault' was here
int copro_handle_mm_fault(struct mm_struct *mm, unsigned long ea,
^
In file included from include/linux/linkage.h:7:0,
from include/linux/kernel.h:7,
from include/asm-generic/bug.h:18,
from arch/powerpc/include/asm/bug.h:128,
from include/linux/bug.h:5,
from arch/powerpc/include/asm/mmu.h:126,
from arch/powerpc/include/asm/lppaca.h:36,
from arch/powerpc/include/asm/paca.h:21,
from arch/powerpc/include/asm/current.h:16,
from include/linux/sched.h:12,
from arch/powerpc/mm/copro_fault.c:23:
arch/powerpc/mm/copro_fault.c:101:19: error: conflicting types for
'copro_handle_mm_fault'
EXPORT_SYMBOL_GPL(copro_handle_mm_fault);
^
include/linux/export.h:65:21: note: in definition of macro '___EXPORT_SYMBOL'
extern typeof(sym) sym; \
^~~
>> arch/powerpc/mm/copro_fault.c:101:1: note: in expansion of macro
>> 'EXPORT_SYMBOL_GPL'
EXPORT_SYMBOL_GPL(copro_handle_mm_fault);
^
In file included from arch/powerpc/mm/copro_fault.c:27:0:
arch/powerpc/include/asm/copro.h:18:5: note: previous declaration of
'copro_handle_mm_fault' was here
int copro_handle_mm_fault(struct mm_struct *mm, unsigned long ea,
^
vim +/EXPORT_SYMBOL_GPL +101 arch/powerpc/mm/copro_fault.c
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
@23 #include
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
24 #include
4b16f8e2d arch/powerpc/platforms/cell/spu_fault.c Paul Gortmaker 2011-07-22
25 #include
e83d01697 arch/powerpc/mm/copro_fault.c Ian Munsie 2014-10-08
26 #include
73d16a6e0 arch/powerpc/mm/copro_fault.c Ian Munsie 2014-10-08
27 #include
be3ebfe82 arch/powerpc/mm/copro_fault.c Ian Munsie 2014-10-08
28 #include
ec249dd86 arch/powerpc/mm/copro_fault.c Michael Neuling2015-05-27
29 #include
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
30
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
31 /*
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
32 * This ought to be kept in sync with the powerpc specific do_page_fault
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
33 * function. Currently, there are a few corner cases that we haven't had
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
34 * to handle fortunately.
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
35 */
e83d01697 arch/powerpc/mm/copro_fault.c Ian Munsie 2014-10-08
36 int copro_handle_mm_fault(struct mm_struct *mm, unsigned long ea,
7c71e54a4 arch/powerpc/mm/copro_fault.c Souptick Joarder 2018-06-15
37unsigned long dsisr, vm_fault_t *flt)
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
38 {
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
39struct vm_area_struct *vma;
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
40unsigned long is_write;
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
41int ret;
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
42
60ee03194 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2009-02-17
43if (mm ==
Re: [PATCH] mm: convert return type of handle_mm_fault() caller to vm_fault_t
Hi Souptick,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on v4.17]
[cannot apply to linus/master powerpc/next sparc-next/master next-20180614]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Souptick-Joarder/mm-convert-return-type-of-handle_mm_fault-caller-to-vm_fault_t/20180615-030636
config: powerpc-defconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=powerpc
All errors (new ones prefixed by >>):
>> arch/powerpc/mm/copro_fault.c:36:5: error: conflicting types for
>> 'copro_handle_mm_fault'
int copro_handle_mm_fault(struct mm_struct *mm, unsigned long ea,
^
In file included from arch/powerpc/mm/copro_fault.c:27:0:
arch/powerpc/include/asm/copro.h:18:5: note: previous declaration of
'copro_handle_mm_fault' was here
int copro_handle_mm_fault(struct mm_struct *mm, unsigned long ea,
^
In file included from include/linux/linkage.h:7:0,
from include/linux/kernel.h:7,
from include/asm-generic/bug.h:18,
from arch/powerpc/include/asm/bug.h:128,
from include/linux/bug.h:5,
from arch/powerpc/include/asm/mmu.h:126,
from arch/powerpc/include/asm/lppaca.h:36,
from arch/powerpc/include/asm/paca.h:21,
from arch/powerpc/include/asm/current.h:16,
from include/linux/sched.h:12,
from arch/powerpc/mm/copro_fault.c:23:
arch/powerpc/mm/copro_fault.c:101:19: error: conflicting types for
'copro_handle_mm_fault'
EXPORT_SYMBOL_GPL(copro_handle_mm_fault);
^
include/linux/export.h:65:21: note: in definition of macro '___EXPORT_SYMBOL'
extern typeof(sym) sym; \
^~~
arch/powerpc/mm/copro_fault.c:101:1: note: in expansion of macro
'EXPORT_SYMBOL_GPL'
EXPORT_SYMBOL_GPL(copro_handle_mm_fault);
^
In file included from arch/powerpc/mm/copro_fault.c:27:0:
arch/powerpc/include/asm/copro.h:18:5: note: previous declaration of
'copro_handle_mm_fault' was here
int copro_handle_mm_fault(struct mm_struct *mm, unsigned long ea,
^
vim +/copro_handle_mm_fault +36 arch/powerpc/mm/copro_fault.c
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
30
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
31 /*
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
32 * This ought to be kept in sync with the powerpc specific do_page_fault
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
33 * function. Currently, there are a few corner cases that we haven't had
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
34 * to handle fortunately.
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
35 */
e83d01697 arch/powerpc/mm/copro_fault.c Ian Munsie 2014-10-08
@36 int copro_handle_mm_fault(struct mm_struct *mm, unsigned long ea,
7c71e54a4 arch/powerpc/mm/copro_fault.c Souptick Joarder 2018-06-15
37unsigned long dsisr, vm_fault_t *flt)
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
38 {
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
39struct vm_area_struct *vma;
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
40unsigned long is_write;
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
41int ret;
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
42
60ee03194 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2009-02-17
43if (mm == NULL)
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
44return -EFAULT;
60ee03194 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2009-02-17
45
60ee03194 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2009-02-17
46if (mm->pgd == NULL)
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
47return -EFAULT;
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
48
7cd58e438 arch/powerpc/platforms/cell/spu_fault.c Jeremy Kerr2007-12-20
49down_read(>mmap_sem);
60ee03194 arch/powerpc/platforms/cell/spu_fault.c Jeremy
Re: [PATCH 2/2] iommu/vt-d: fix dev iotlb pfsid use
Hi Jacob,
I love your patch! Yet something to improve:
[auto build test ERROR on iommu/next]
[also build test ERROR on v4.17 next-20180606]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Jacob-Pan/iommu-vt-d-pfsid-fix/20180607-134305
base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: ia64-defconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 8.1.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=ia64
All errors (new ones prefixed by >>):
In file included from drivers//iommu/intel-iommu.c:31:
drivers//iommu/intel-iommu.c: In function 'iommu_enable_dev_iotlb':
>> drivers//iommu/intel-iommu.c:1488:33: error: 'struct pci_dev' has no member
>> named 'physfn'; did you mean 'is_physfn'?
info->pfsid = PCI_DEVID(pdev->physfn->bus->number, pdev->physfn->devfn);
^~
include/linux/pci.h:51:40: note: in definition of macro 'PCI_DEVID'
#define PCI_DEVID(bus, devfn) u16)(bus)) << 8) | (devfn))
^~~
drivers//iommu/intel-iommu.c:1488:60: error: 'struct pci_dev' has no member
named 'physfn'; did you mean 'is_physfn'?
info->pfsid = PCI_DEVID(pdev->physfn->bus->number, pdev->physfn->devfn);
^~
include/linux/pci.h:51:55: note: in definition of macro 'PCI_DEVID'
#define PCI_DEVID(bus, devfn) u16)(bus)) << 8) | (devfn))
^
vim +1488 drivers//iommu/intel-iommu.c
1467
1468 static void iommu_enable_dev_iotlb(struct device_domain_info *info)
1469 {
1470 struct pci_dev *pdev;
1471
1472 assert_spin_locked(_domain_lock);
1473
1474 if (!info || !dev_is_pci(info->dev))
1475 return;
1476
1477 pdev = to_pci_dev(info->dev);
1478 /* For IOMMU that supports device IOTLB throttling (DIT), we
assign
1479 * PFSID to the invalidation desc of a VF such that IOMMU HW
can gauge
1480 * queue depth at PF level. If DIT is not set, PFSID will be
treated as
1481 * reserved, which should be set to 0.
1482 */
1483 if (!ecap_dit(info->iommu->ecap))
1484 info->pfsid = 0;
1485 else if (pdev && pdev->is_virtfn) {
1486 if (ecap_dit(info->iommu->ecap))
1487 dev_warn(>dev, "SRIOV VF device IOTLB
enabled without flow control\n");
> 1488 info->pfsid = PCI_DEVID(pdev->physfn->bus->number,
> pdev->physfn->devfn);
1489 } else
1490 info->pfsid = PCI_DEVID(info->bus, info->devfn);
1491
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 5/7] iommu/dma: add support for non-strict mode
Hi Zhen,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v4.17-rc7 next-20180601]
[cannot apply to iommu/next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Zhen-Lei/add-non-strict-mode-support-for-arm-smmu-v3/20180602-000418
config: x86_64-randconfig-x008-201821 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
drivers//iommu/amd_iommu.c: In function 'amd_iommu_capable':
>> drivers//iommu/amd_iommu.c:3053:2: warning: enumeration value
>> 'IOMMU_CAP_NON_STRICT' not handled in switch [-Wswitch]
switch (cap) {
^~
vim +/IOMMU_CAP_NON_STRICT +3053 drivers//iommu/amd_iommu.c
645c4c8d arch/x86/kernel/amd_iommu.c Joerg Roedel 2008-12-02 3050
ab636481 drivers/iommu/amd_iommu.c Joerg Roedel 2014-09-05 3051 static bool
amd_iommu_capable(enum iommu_cap cap)
dbb9fd86 arch/x86/kernel/amd_iommu.c Sheng Yang 2009-03-18 3052 {
80a506b8 arch/x86/kernel/amd_iommu.c Joerg Roedel 2010-07-27 @3053 switch
(cap) {
80a506b8 arch/x86/kernel/amd_iommu.c Joerg Roedel 2010-07-27 3054 case
IOMMU_CAP_CACHE_COHERENCY:
ab636481 drivers/iommu/amd_iommu.c Joerg Roedel 2014-09-05 3055
return true;
bdddadcb drivers/iommu/amd_iommu.c Joerg Roedel 2012-07-02 3056 case
IOMMU_CAP_INTR_REMAP:
ab636481 drivers/iommu/amd_iommu.c Joerg Roedel 2014-09-05 3057
return (irq_remapping_enabled == 1);
cfdeec22 drivers/iommu/amd_iommu.c Will Deacon 2014-10-27 3058 case
IOMMU_CAP_NOEXEC:
cfdeec22 drivers/iommu/amd_iommu.c Will Deacon 2014-10-27 3059
return false;
80a506b8 arch/x86/kernel/amd_iommu.c Joerg Roedel 2010-07-27 3060 }
80a506b8 arch/x86/kernel/amd_iommu.c Joerg Roedel 2010-07-27 3061
ab636481 drivers/iommu/amd_iommu.c Joerg Roedel 2014-09-05 3062 return
false;
dbb9fd86 arch/x86/kernel/amd_iommu.c Sheng Yang 2009-03-18 3063 }
dbb9fd86 arch/x86/kernel/amd_iommu.c Sheng Yang 2009-03-18 3064
:: The code at line 3053 was first introduced by commit
:: 80a506b8fdcfa868bb53eb740f928217d0966fc1 x86/amd-iommu: Export
cache-coherency capability
:: TO: Joerg Roedel
:: CC: Joerg Roedel
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v2] dma-debug: Check scatterlist segments
Hi Robin,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v4.17-rc5 next-20180517]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Robin-Murphy/dma-debug-Check-scatterlist-segments/20180514-220916
config: sh-allyesconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=sh
All warnings (new ones prefixed by >>):
In file included from arch/sh/include/asm/bug.h:112:0,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/current.h:5,
from ./arch/sh/include/generated/asm/current.h:1,
from include/linux/sched.h:12,
from include/linux/sched/task_stack.h:9,
from lib/dma-debug.c:20:
lib/dma-debug.c: In function 'check_sg_segment':
>> lib/dma-debug.c:232:12: warning: format '%llx' expects argument of type
>> 'long long unsigned int', but argument 4 has type 'dma_addr_t {aka unsigned
>> int}' [-Wformat=]
WARN(1, "%s %s: " format, \
^
include/asm-generic/bug.h:98:50: note: in definition of macro '__WARN_printf'
#define __WARN_printf(arg...) do { __warn_printk(arg); __WARN(); } while (0)
^~~
>> lib/dma-debug.c:232:4: note: in expansion of macro 'WARN'
WARN(1, "%s %s: " format, \
^~~~
>> lib/dma-debug.c:1317:3: note: in expansion of macro 'err_printk'
err_printk(dev, NULL, "DMA-API: mapping sg segment across boundary
[start=0x%016llx] [end=0x%016llx] [boundary=0x%016llx]\n",
^~
lib/dma-debug.c:1317:85: note: format string is defined here
err_printk(dev, NULL, "DMA-API: mapping sg segment across boundary
[start=0x%016llx] [end=0x%016llx] [boundary=0x%016llx]\n",
~~^
%016x
In file included from arch/sh/include/asm/bug.h:112:0,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/current.h:5,
from ./arch/sh/include/generated/asm/current.h:1,
from include/linux/sched.h:12,
from include/linux/sched/task_stack.h:9,
from lib/dma-debug.c:20:
lib/dma-debug.c:232:12: warning: format '%llx' expects argument of type
'long long unsigned int', but argument 5 has type 'dma_addr_t {aka unsigned
int}' [-Wformat=]
WARN(1, "%s %s: " format, \
^
include/asm-generic/bug.h:98:50: note: in definition of macro '__WARN_printf'
#define __WARN_printf(arg...) do { __warn_printk(arg); __WARN(); } while (0)
^~~
>> lib/dma-debug.c:232:4: note: in expansion of macro 'WARN'
WARN(1, "%s %s: " format, \
^~~~
>> lib/dma-debug.c:1317:3: note: in expansion of macro 'err_printk'
err_printk(dev, NULL, "DMA-API: mapping sg segment across boundary
[start=0x%016llx] [end=0x%016llx] [boundary=0x%016llx]\n",
^~
lib/dma-debug.c:1317:101: note: format string is defined here
err_printk(dev, NULL, "DMA-API: mapping sg segment across boundary
[start=0x%016llx] [end=0x%016llx] [boundary=0x%016llx]\n",
~~^
%016x
In file included from arch/sh/include/asm/bug.h:112:0,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/current.h:5,
from ./arch/sh/include/generated/asm/current.h:1,
from include/linux/sched.h:12,
from include/linux/sched/task_stack.h:9,
from lib/dma-debug.c:20:
lib/dma-debug.c:232:12: warning: format '%llx' expects argument of type
'long long unsigned int', but argument 6 has type 'dma_addr_t {aka unsigned
int}' [-Wformat=]
WARN(1, "%s %s: " format, \
^
include/asm-generic/bug.h:98:50: note: in definition of macro '__WARN_printf'
#define __WARN_printf(arg...) do { __warn_printk(arg); __WARN(); } while (0)
^~~
>> lib/dma-debug.c:232:4: note: in expansion of macro 'WARN'
Re: [PATCH v5 08/23] iommu/vt-d: support flushing more translation cache types
Hi Jacob,
I love your patch! Perhaps something to improve:
[auto build test WARNING on iommu/next]
[also build test WARNING on v4.17-rc5 next-20180516]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Jacob-Pan/IOMMU-and-VT-d-driver-support-for-Shared-Virtual-Address-SVA/20180512-114854
base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: x86_64-rhel-7.2 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
drivers/iommu/dmar.c: In function 'qi_flush_dev_eiotlb':
>> drivers/iommu/dmar.c:1382:12: warning: 'desc.high' is used uninitialized in
>> this function [-Wuninitialized]
desc.high |= QI_DEV_EIOTLB_GLOB(granu);
^~
vim +1382 drivers/iommu/dmar.c
1374
1375 void qi_flush_dev_eiotlb(struct intel_iommu *iommu, u16 sid,
1376 u32 pasid, u16 qdep, u64 addr, unsigned size, u64
granu)
1377 {
1378 struct qi_desc desc;
1379
1380 desc.low = QI_DEV_EIOTLB_PASID(pasid) | QI_DEV_EIOTLB_SID(sid) |
1381 QI_DEV_EIOTLB_QDEP(qdep) | QI_DEIOTLB_TYPE;
> 1382 desc.high |= QI_DEV_EIOTLB_GLOB(granu);
1383
1384 /* If S bit is 0, we only flush a single page. If S bit is set,
1385 * The least significant zero bit indicates the size. VT-d spec
1386 * 6.5.2.6
1387 */
1388 if (!size)
1389 desc.high = QI_DEV_EIOTLB_ADDR(addr) &
~QI_DEV_EIOTLB_SIZE;
1390 else {
1391 unsigned long mask = 1UL << (VTD_PAGE_SHIFT + size);
1392
1393 desc.high = QI_DEV_EIOTLB_ADDR(addr & ~mask) |
QI_DEV_EIOTLB_SIZE;
1394 }
1395 qi_submit_sync(, iommu);
1396 }
1397
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v5 1/2] iommu - Enable debugfs exposure of IOMMU driver internals
Hi Gary,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on iommu/next]
[also build test ERROR on v4.17-rc4 next-20180507]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Gary-R-Hook/iommu-Enable-debugfs-exposure-of-IOMMU-driver-internals/20180508-062918
base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: x86_64-randconfig-x016-201818 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All error/warnings (new ones prefixed by >>):
In file included from include/linux/intel-iommu.h:32:0,
from drivers/gpu/drm/i915/i915_drv.h:41,
from drivers/gpu/drm/i915/i915_oa_bxt.c:31:
include/linux/iommu.h: In function 'iommu_debugfs_new_driver_dir':
>> include/linux/iommu.h:706:8: error: parameter name omitted
struct dentry *iommu_debugfs_new_driver_dir(char *) {};
^~
In file included from include/linux/intel-iommu.h:32:0,
from drivers/gpu/drm/i915/i915_drv.h:41,
from drivers/gpu/drm/i915/i915_oa_bxt.c:31:
>> include/linux/iommu.h:706:8: warning: control reaches end of non-void
>> function [-Wreturn-type]
struct dentry *iommu_debugfs_new_driver_dir(char *) {};
^~
vim +706 include/linux/iommu.h
700
701 #ifdef CONFIG_IOMMU_DEBUGFS
702 void iommu_debugfs_setup(void);
703 struct dentry *iommu_debugfs_new_driver_dir(char *);
704 #else
705 static inline void iommu_debugfs_setup(void) {}
> 706 struct dentry *iommu_debugfs_new_driver_dir(char *) {};
707 #endif
708
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v4 5/6] bus: fsl-mc: supoprt dma configure for devices on fsl-mc bus
Hi Nipun,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.17-rc3 next-20180430]
[cannot apply to iommu/next glikely/devicetree/next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Nipun-Gupta/Support-for-fsl-mc-bus-and-its-devices-in-SMMU/20180501-125745
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/bus/fsl-mc/fsl-mc-bus.c: In function 'fsl_mc_dma_configure':
>> drivers/bus/fsl-mc/fsl-mc-bus.c:137:9: error: too many arguments to function
>> 'of_dma_configure'
return of_dma_configure(dev, dma_dev->of_node, 0);
^~~~
In file included from drivers/bus/fsl-mc/fsl-mc-bus.c:13:0:
include/linux/of_device.h:58:5: note: declared here
int of_dma_configure(struct device *dev, struct device_node *np);
^~~~
drivers/bus/fsl-mc/fsl-mc-bus.c: At top level:
>> drivers/bus/fsl-mc/fsl-mc-bus.c:161:3: error: 'struct bus_type' has no
>> member named 'dma_configure'
.dma_configure = fsl_mc_dma_configure,
^
vim +/of_dma_configure +137 drivers/bus/fsl-mc/fsl-mc-bus.c
129
130 static int fsl_mc_dma_configure(struct device *dev)
131 {
132 struct device *dma_dev = dev;
133
134 while (dev_is_fsl_mc(dma_dev))
135 dma_dev = dma_dev->parent;
136
> 137 return of_dma_configure(dev, dma_dev->of_node, 0);
138 }
139
140 static ssize_t modalias_show(struct device *dev, struct
device_attribute *attr,
141 char *buf)
142 {
143 struct fsl_mc_device *mc_dev = to_fsl_mc_device(dev);
144
145 return sprintf(buf, "fsl-mc:v%08Xd%s\n",
mc_dev->obj_desc.vendor,
146 mc_dev->obj_desc.type);
147 }
148 static DEVICE_ATTR_RO(modalias);
149
150 static struct attribute *fsl_mc_dev_attrs[] = {
151 _attr_modalias.attr,
152 NULL,
153 };
154
155 ATTRIBUTE_GROUPS(fsl_mc_dev);
156
157 struct bus_type fsl_mc_bus_type = {
158 .name = "fsl-mc",
159 .match = fsl_mc_bus_match,
160 .uevent = fsl_mc_bus_uevent,
> 161 .dma_configure = fsl_mc_dma_configure,
162 .dev_groups = fsl_mc_dev_groups,
163 };
164 EXPORT_SYMBOL_GPL(fsl_mc_bus_type);
165
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 2/6 v3] iommu: of: make of_pci_map_rid() available for other devices too
Hi Nipun, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.17-rc2 next-20180426] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Nipun-Gupta/Docs-dt-add-fsl-mc-iommu-map-device-tree-binding/20180428-111415 config: sparc64-allyesconfig (attached as .config) compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=sparc64 All errors (new ones prefixed by >>): `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o drivers/iommu/of_iommu.o: In function `of_pci_iommu_init': >> of_iommu.c:(.text+0x398): undefined reference to `of_map_rid' --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 3/4] ARM: dma-mapping: Implement arch_iommu_detach_device()
Hi Thierry,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.17-rc2 next-20180424]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Thierry-Reding/drm-nouveau-tegra-Detach-from-ARM-DMA-IOMMU-mapping/20180426-140854
config: arm-omap2plus_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm
All error/warnings (new ones prefixed by >>):
arch/arm/mm/dma-mapping.c: In function 'arch_iommu_detach_device':
>> arch/arm/mm/dma-mapping.c:2380:12: error: implicit declaration of function
>> 'arm_get_dma_map_ops'; did you mean 'arm_get_iommu_dma_map_ops'?
>> [-Werror=implicit-function-declaration]
dma_ops = arm_get_dma_map_ops(dev->archdata.dma_coherent);
^~~
arm_get_iommu_dma_map_ops
>> arch/arm/mm/dma-mapping.c:2380:10: warning: assignment makes pointer from
>> integer without a cast [-Wint-conversion]
dma_ops = arm_get_dma_map_ops(dev->archdata.dma_coherent);
^
arch/arm/mm/dma-mapping.c: At top level:
>> arch/arm/mm/dma-mapping.c:2402:34: error: conflicting types for
>> 'arm_get_dma_map_ops'
static const struct dma_map_ops *arm_get_dma_map_ops(bool coherent)
^~~
arch/arm/mm/dma-mapping.c:2380:12: note: previous implicit declaration of
'arm_get_dma_map_ops' was here
dma_ops = arm_get_dma_map_ops(dev->archdata.dma_coherent);
^~~
cc1: some warnings being treated as errors
vim +2380 arch/arm/mm/dma-mapping.c
2368
2369 void arch_iommu_detach_device(struct device *dev)
2370 {
2371 struct dma_iommu_mapping *mapping = to_dma_iommu_mapping(dev);
2372 const struct dma_map_ops *dma_ops;
2373
2374 if (!mapping)
2375 return;
2376
2377 arm_iommu_release_mapping(mapping);
2378 arm_iommu_detach_device(dev);
2379
> 2380 dma_ops = arm_get_dma_map_ops(dev->archdata.dma_coherent);
2381 set_dma_ops(dev, dma_ops);
2382 }
2383
2384 #else
2385
2386 static bool arm_setup_iommu_dma_ops(struct device *dev, u64 dma_base,
u64 size,
2387 const struct iommu_ops *iommu)
2388 {
2389 return false;
2390 }
2391
2392 static void arm_teardown_iommu_dma_ops(struct device *dev) { }
2393
2394 #define arm_get_iommu_dma_map_ops arm_get_dma_map_ops
2395
2396 void arch_iommu_detach_device(struct device *dev)
2397 {
2398 }
2399
2400 #endif /* CONFIG_ARM_DMA_USE_IOMMU */
2401
> 2402 static const struct dma_map_ops *arm_get_dma_map_ops(bool coherent)
2403 {
2404 return coherent ? _coherent_dma_ops : _dma_ops;
2405 }
2406
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 5/6 v2] bus: fsl-mc: supoprt dma configure for devices on fsl-mc bus
Hi Nipun,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.17-rc2 next-20180424]
[cannot apply to iommu/next glikely/devicetree/next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Nipun-Gupta/Support-for-fsl-mc-bus-and-its-devices-in-SMMU/20180418-034931
config: powerpc64-allmodconfig (attached as .config)
compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=powerpc64
All errors (new ones prefixed by >>):
drivers/bus/fsl-mc/fsl-mc-bus.c: In function 'fsl_mc_dma_configure':
>> drivers/bus/fsl-mc/fsl-mc-bus.c:137:9: error: too many arguments to function
>> 'of_dma_configure'
return of_dma_configure(dev, dma_dev->of_node, 0);
^~~~
In file included from drivers/bus/fsl-mc/fsl-mc-bus.c:13:0:
include/linux/of_device.h:58:5: note: declared here
int of_dma_configure(struct device *dev, struct device_node *np);
^~~~
drivers/bus/fsl-mc/fsl-mc-bus.c: At top level:
>> drivers/bus/fsl-mc/fsl-mc-bus.c:161:3: error: 'struct bus_type' has no
>> member named 'dma_configure'
.dma_configure = fsl_mc_dma_configure,
^
vim +/of_dma_configure +137 drivers/bus/fsl-mc/fsl-mc-bus.c
129
130 static int fsl_mc_dma_configure(struct device *dev)
131 {
132 struct device *dma_dev = dev;
133
134 while (dev_is_fsl_mc(dma_dev))
135 dma_dev = dma_dev->parent;
136
> 137 return of_dma_configure(dev, dma_dev->of_node, 0);
138 }
139
140 static ssize_t modalias_show(struct device *dev, struct
device_attribute *attr,
141 char *buf)
142 {
143 struct fsl_mc_device *mc_dev = to_fsl_mc_device(dev);
144
145 return sprintf(buf, "fsl-mc:v%08Xd%s\n",
mc_dev->obj_desc.vendor,
146 mc_dev->obj_desc.type);
147 }
148 static DEVICE_ATTR_RO(modalias);
149
150 static struct attribute *fsl_mc_dev_attrs[] = {
151 _attr_modalias.attr,
152 NULL,
153 };
154
155 ATTRIBUTE_GROUPS(fsl_mc_dev);
156
157 struct bus_type fsl_mc_bus_type = {
158 .name = "fsl-mc",
159 .match = fsl_mc_bus_match,
160 .uevent = fsl_mc_bus_uevent,
> 161 .dma_configure = fsl_mc_dma_configure,
162 .dev_groups = fsl_mc_dev_groups,
163 };
164 EXPORT_SYMBOL_GPL(fsl_mc_bus_type);
165
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH] dma-debug: Check scatterlist segments
Hi Robin,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v4.17-rc2 next-20180424]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Robin-Murphy/dma-debug-Check-scatterlist-segments/20180425-070135
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=sh
All warnings (new ones prefixed by >>):
In file included from arch/sh/include/asm/bug.h:112:0,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/current.h:5,
from ./arch/sh/include/generated/asm/current.h:1,
from include/linux/sched.h:12,
from include/linux/sched/task_stack.h:9,
from lib/dma-debug.c:20:
lib/dma-debug.c: In function 'check_sg_segment':
>> lib/dma-debug.c:232:12: warning: format '%llx' expects argument of type
>> 'long long unsigned int', but argument 4 has type 'dma_addr_t {aka unsigned
>> int}' [-Wformat=]
WARN(1, "%s %s: " format, \
^
include/asm-generic/bug.h:98:50: note: in definition of macro '__WARN_printf'
#define __WARN_printf(arg...) do { __warn_printk(arg); __WARN(); } while (0)
^~~
>> lib/dma-debug.c:232:4: note: in expansion of macro 'WARN'
WARN(1, "%s %s: " format, \
^~~~
>> lib/dma-debug.c:1316:3: note: in expansion of macro 'err_printk'
err_printk(dev, NULL, "DMA-API: mapping sg segment across boundary
[start=0x%016llx] [end=0x%016llx] [boundary=0x%016llx]\n",
^~
lib/dma-debug.c:1316:85: note: format string is defined here
err_printk(dev, NULL, "DMA-API: mapping sg segment across boundary
[start=0x%016llx] [end=0x%016llx] [boundary=0x%016llx]\n",
~~^
%016x
In file included from arch/sh/include/asm/bug.h:112:0,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/current.h:5,
from ./arch/sh/include/generated/asm/current.h:1,
from include/linux/sched.h:12,
from include/linux/sched/task_stack.h:9,
from lib/dma-debug.c:20:
lib/dma-debug.c:232:12: warning: format '%llx' expects argument of type
'long long unsigned int', but argument 5 has type 'dma_addr_t {aka unsigned
int}' [-Wformat=]
WARN(1, "%s %s: " format, \
^
include/asm-generic/bug.h:98:50: note: in definition of macro '__WARN_printf'
#define __WARN_printf(arg...) do { __warn_printk(arg); __WARN(); } while (0)
^~~
>> lib/dma-debug.c:232:4: note: in expansion of macro 'WARN'
WARN(1, "%s %s: " format, \
^~~~
>> lib/dma-debug.c:1316:3: note: in expansion of macro 'err_printk'
err_printk(dev, NULL, "DMA-API: mapping sg segment across boundary
[start=0x%016llx] [end=0x%016llx] [boundary=0x%016llx]\n",
^~
lib/dma-debug.c:1316:101: note: format string is defined here
err_printk(dev, NULL, "DMA-API: mapping sg segment across boundary
[start=0x%016llx] [end=0x%016llx] [boundary=0x%016llx]\n",
~~^
%016x
In file included from arch/sh/include/asm/bug.h:112:0,
from include/linux/bug.h:5,
from include/linux/thread_info.h:12,
from include/asm-generic/current.h:5,
from ./arch/sh/include/generated/asm/current.h:1,
from include/linux/sched.h:12,
from include/linux/sched/task_stack.h:9,
from lib/dma-debug.c:20:
lib/dma-debug.c:232:12: warning: format '%llx' expects argument of type
'long long unsigned int', but argument 6 has type 'dma_addr_t {aka unsigned
int}' [-Wformat=]
WARN(1, "%s %s: " format, \
^
include/asm-generic/bug.h:98:50: note: in definition of macro '__WARN_printf'
#define __WARN_printf(arg...) do { __warn_printk(arg); __WARN(); } while (0)
^~~
>> lib/dma-debug.c:232:4: note: in expansion of macro 'WARN'
Re: [PATCH v2 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU
Hi Gary,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on iommu/next]
[also build test ERROR on v4.16 next-20180405]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Gary-R-Hook/iommu-Enable-debugfs-exposure-of-the-IOMMU/20180405-151608
base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: x86_64-randconfig-s2-04060234 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers//iommu/amd_iommu_debugfs.c: In function 'amd_iommu_debugfs_setup':
>> drivers//iommu/amd_iommu_debugfs.c:31:11: error: implicit declaration of
>> function 'iommu_debugfs_setup' [-Werror=implicit-function-declaration]
d_top = iommu_debugfs_setup();
^~~
drivers//iommu/amd_iommu_debugfs.c:31:9: warning: assignment makes pointer
from integer without a cast [-Wint-conversion]
d_top = iommu_debugfs_setup();
^
cc1: some warnings being treated as errors
vim +/iommu_debugfs_setup +31 drivers//iommu/amd_iommu_debugfs.c
20
21 void amd_iommu_debugfs_setup(struct amd_iommu *iommu)
22 {
23 char name[MAX_NAME_LEN + 1];
24 struct dentry *d_top;
25
26 if (!debugfs_initialized())
27 return;
28
29 mutex_lock(_iommu_debugfs_lock);
30 if (!amd_iommu_debugfs) {
> 31 d_top = iommu_debugfs_setup();
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v2 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU
Hi Gary,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on iommu/next]
[also build test ERROR on v4.16 next-20180404]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Gary-R-Hook/iommu-Enable-debugfs-exposure-of-the-IOMMU/20180405-151608
base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: x86_64-randconfig-x002-201813 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All error/warnings (new ones prefixed by >>):
drivers//iommu/amd_iommu_debugfs.c: In function 'amd_iommu_debugfs_setup':
>> drivers//iommu/amd_iommu_debugfs.c:31:11: error: implicit declaration of
>> function 'iommu_debugfs_setup'; did you mean 'amd_iommu_debugfs_setup'?
>> [-Werror=implicit-function-declaration]
d_top = iommu_debugfs_setup();
^~~
amd_iommu_debugfs_setup
>> drivers//iommu/amd_iommu_debugfs.c:31:9: warning: assignment makes pointer
>> from integer without a cast [-Wint-conversion]
d_top = iommu_debugfs_setup();
^
cc1: some warnings being treated as errors
vim +31 drivers//iommu/amd_iommu_debugfs.c
20
21 void amd_iommu_debugfs_setup(struct amd_iommu *iommu)
22 {
23 char name[MAX_NAME_LEN + 1];
24 struct dentry *d_top;
25
26 if (!debugfs_initialized())
27 return;
28
29 mutex_lock(_iommu_debugfs_lock);
30 if (!amd_iommu_debugfs) {
> 31 d_top = iommu_debugfs_setup();
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
[RFC PATCH] iommu/vt-d: intel_iommu_page_response() can be static
Fixes: 49c5977b4ee7 ("iommu/vt-d: add intel iommu page response function")
Signed-off-by: Fengguang Wu
---
intel-iommu.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index 8d73ff0..06be796 100644
--- a/drivers/iommu/intel-iommu.c
+++ b/drivers/iommu/intel-iommu.c
@@ -5195,7 +5195,7 @@ static int intel_iommu_sva_invalidate(struct iommu_domain
*domain,
return ret;
}
-int intel_iommu_page_response(struct device *dev, struct page_response_msg
*msg)
+static int intel_iommu_page_response(struct device *dev, struct
page_response_msg *msg)
{
struct qi_desc resp;
struct intel_iommu *iommu;
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v4 20/22] iommu/vt-d: add intel iommu page response function
Hi Jacob, I love your patch! Perhaps something to improve: [auto build test WARNING on iommu/next] [also build test WARNING on v4.16-rc6 next-20180323] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jacob-Pan/IOMMU-and-VT-d-driver-support-for-Shared-Virtual-Address-SVA/20180325-024555 base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) drivers/iommu/intel-iommu.c:500:5: sparse: symbol 'intel_iommu_gfx_mapped' was not declared. Should it be static? drivers/iommu/intel-iommu.c:3066:41: sparse: incorrect type in argument 1 (different address spaces) @@expected void volatile [noderef] *addr @@got ile [noderef] *addr @@ drivers/iommu/intel-iommu.c:3066:41:expected void volatile [noderef] *addr drivers/iommu/intel-iommu.c:3066:41:got struct context_entry *old_ce >> drivers/iommu/intel-iommu.c:5198:5: sparse: symbol >> 'intel_iommu_page_response' was not declared. Should it be static? >> drivers/iommu/intel-iommu.c:5224:48: sparse: right shift by bigger than >> source value Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v2 1/2] dma-mapping: move dma configuration to bus infrastructure
Hi Nipun, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Nipun-Gupta/dma-mapping-move-dma-configuration-to-bus-infrastructure/20180323-232307 config: score-spct6600_defconfig (attached as .config) compiler: score-elf-gcc (GCC) 4.9.4 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=score All errors (new ones prefixed by >>): init/main.o: In function `try_to_run_init_process': main.c:(.text+0x40): relocation truncated to fit: R_SCORE_24 against `run_init_process' main.c:(.text+0x78): relocation truncated to fit: R_SCORE_24 against `.L36' init/main.o: In function `.L132': main.c:(.text+0x190): relocation truncated to fit: R_SCORE_24 against `.L129' main.c:(.text+0x200): relocation truncated to fit: R_SCORE_24 against `.L132' init/main.o: In function `loglevel': main.c:(.init.text+0xa4): relocation truncated to fit: R_SCORE_24 against `get_option' init/main.o: In function `.L15': main.c:(.init.text+0x110): relocation truncated to fit: R_SCORE_24 against `strcmp' main.c:(.init.text+0x124): relocation truncated to fit: R_SCORE_24 against `parameq' main.c:(.init.text+0x14c): relocation truncated to fit: R_SCORE_24 against `printk' init/main.o: In function `.L31': main.c:(.init.text+0x160): relocation truncated to fit: R_SCORE_24 against `strcmp' init/main.o: In function `.L21': main.c:(.init.text+0x170): relocation truncated to fit: R_SCORE_24 against `.L15' init/main.o: In function `initcall_blacklist': main.c:(.init.text+0x198): additional relocation overflows omitted from the output drivers/base/platform.o: In function `platform_dma_configure': >> platform.c:(.text.platform_dma_configure+0x0): undefined reference to >> `dma_common_configure' --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v2 2/2] drivers: remove force dma flag from buses
Hi Nipun,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.16-rc6 next-20180323]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Nipun-Gupta/dma-mapping-move-dma-configuration-to-bus-infrastructure/20180323-232307
config: i386-randconfig-x014-201811 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers//bcma/main.c: In function 'bcma_of_fill_device':
>> drivers//bcma/main.c:210:2: error: too many arguments to function
>> 'of_dma_configure'
of_dma_configure(>dev, node, false);
^~~~
In file included from include/linux/of_platform.h:12:0,
from drivers//bcma/main.c:17:
include/linux/of_device.h:110:19: note: declared here
static inline int of_dma_configure(struct device *dev, struct device_node
*np)
^~~~
vim +/of_dma_configure +210 drivers//bcma/main.c
198
199 static void bcma_of_fill_device(struct device *parent,
200 struct bcma_device *core)
201 {
202 struct device_node *node;
203
204 node = bcma_of_find_child_device(parent, core);
205 if (node)
206 core->dev.of_node = node;
207
208 core->irq = bcma_of_get_irq(parent, core, 0);
209
> 210 of_dma_configure(>dev, node, false);
211 }
212
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v2 2/2] drivers: remove force dma flag from buses
Hi Nipun,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.16-rc6 next-20180323]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Nipun-Gupta/dma-mapping-move-dma-configuration-to-bus-infrastructure/20180323-232307
config: i386-randconfig-x013-201811 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers/base/dma-mapping.c: In function 'dma_common_configure':
>> drivers/base/dma-mapping.c:344:9: error: too many arguments to function
>> 'of_dma_configure'
ret = of_dma_configure(dev, dev->of_node, force_dma);
^~~~
In file included from drivers/base/dma-mapping.c:13:0:
include/linux/of_device.h:110:19: note: declared here
static inline int of_dma_configure(struct device *dev, struct device_node
*np)
^~~~
--
drivers/pci/pci-driver.c: In function 'pci_dma_configure':
>> drivers/pci/pci-driver.c:1544:9: error: too many arguments to function
>> 'of_dma_configure'
ret = of_dma_configure(dev, bridge->parent->of_node, true);
^~~~
In file included from drivers/pci/pci-driver.c:21:0:
include/linux/of_device.h:110:19: note: declared here
static inline int of_dma_configure(struct device *dev, struct device_node
*np)
^~~~
vim +/of_dma_configure +344 drivers/base/dma-mapping.c
332
333 /*
334 * Common configuration to enable DMA API use for a device.
335 * A bus can use this function in its 'dma_configure' callback, if
336 * suitable for the bus.
337 */
338 int dma_common_configure(struct device *dev, bool force_dma)
339 {
340 enum dev_dma_attr attr;
341 int ret = 0;
342
343 if (dev->of_node) {
> 344 ret = of_dma_configure(dev, dev->of_node, force_dma);
345 } else if (has_acpi_companion(dev)) {
346 attr =
acpi_get_dma_attr(to_acpi_device_node(dev->fwnode));
347 if (attr != DEV_DMA_NOT_SUPPORTED)
348 ret = acpi_dma_configure(dev, attr);
349 }
350
351 return ret;
352 }
353
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v3 5/5] iommu/amd - Add a debugfs entry to specify a IOMMU device table entry
Hi Gary,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on v4.16-rc4]
[also build test WARNING on next-20180316]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Gary-R-Hook/Add-debugfs-info-for-the-AMD-IOMMU/20180317-232302
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
drivers/iommu/amd_iommu_debugfs.c: In function
'amd_iommu_debugfs_devid_write':
>> drivers/iommu/amd_iommu_debugfs.c:145:3: warning: ignoring return value of
>> 'kstrtoint', declared with attribute warn_unused_result [-Wunused-result]
kstrtoint(obuf, 0, _iommu_devid);
^~~~
vim +/kstrtoint +145 drivers/iommu/amd_iommu_debugfs.c
123
124 static ssize_t amd_iommu_debugfs_devid_write(struct file *filp,
125 const char __user *ubuf,
126 size_t count, loff_t *offp)
127 {
128 unsigned int pci_id, pci_slot, pci_func;
129 unsigned int obuflen = 80;
130 ssize_t ret;
131 char *obuf;
132
133 obuf = kmalloc(OBUFLEN, GFP_KERNEL);
134 if (!obuf)
135 return -ENOMEM;
136
137 ret = simple_write_to_buffer(obuf, OBUFLEN, offp, ubuf, count);
138
139 if (strnchr(obuf, OBUFLEN, ':')) {
140 int n;
141 n = sscanf(obuf, "%x:%x.%x", _id, _slot,
_func);
142 if (n == 3)
143 amd_iommu_devid = PCI_DEVID(pci_id,
PCI_DEVFN(pci_slot, pci_func));
144 } else {
> 145 kstrtoint(obuf, 0, _iommu_devid);
146 }
147
148 kfree(obuf);
149
150 return ret;
151 }
152
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH] dma-mapping: move dma configuration to bus infrastructure
Hi Nipun, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.16-rc5 next-20180313] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Nipun-Gupta/dma-mapping-move-dma-configuration-to-bus-infrastructure/20180313-225250 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/base/platform.c:1133:5: sparse: symbol 'platform_dma_configure' was >> not declared. Should it be static? >> drivers/base/platform.c:1149:6: sparse: symbol 'platform_dma_deconfigure' >> was not declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
[RFC PATCH] dma-mapping: platform_dma_configure() can be static
Fixes: 9a019f425175 ("dma-mapping: move dma configuration to bus
infrastructure")
Signed-off-by: Fengguang Wu
---
platform.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index adf94eb..dc9c790 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -1130,7 +1130,7 @@ int platform_pm_restore(struct device *dev)
#endif /* CONFIG_HIBERNATE_CALLBACKS */
-int platform_dma_configure(struct device *dev)
+static int platform_dma_configure(struct device *dev)
{
enum dev_dma_attr attr;
int ret = 0;
@@ -1146,7 +1146,7 @@ int platform_dma_configure(struct device *dev)
return ret;
}
-void platform_dma_deconfigure(struct device *dev)
+static void platform_dma_deconfigure(struct device *dev)
{
of_dma_deconfigure(dev);
acpi_dma_deconfigure(dev);
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 3/4] iommu/virtio: Add event queue
Hi Jean-Philippe, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc2 next-20180221] [cannot apply to iommu/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jean-Philippe-Brucker/Add-virtio-iommu-driver/20180217-075417 config: parisc-allmodconfig (attached as .config) compiler: hppa-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=parisc All errors (new ones prefixed by >>): drivers/iommu/virtio-iommu.o: In function `virtio_iommu_drv_init': (.init.text+0x24): undefined reference to `register_virtio_driver' drivers/iommu/virtio-iommu.o: In function `viommu_send_reqs_sync': (.text.viommu_send_reqs_sync+0xdc): undefined reference to `virtqueue_add_sgs' (.text.viommu_send_reqs_sync+0x12c): undefined reference to `virtqueue_kick' (.text.viommu_send_reqs_sync+0x29c): undefined reference to `virtqueue_get_buf' drivers/iommu/virtio-iommu.o: In function `viommu_event_handler': >> (.text.viommu_event_handler+0x288): undefined reference to >> `virtqueue_add_inbuf' >> (.text.viommu_event_handler+0x2a8): undefined reference to >> `virtqueue_get_buf' >> (.text.viommu_event_handler+0x2b8): undefined reference to `virtqueue_kick' drivers/iommu/virtio-iommu.o: In function `viommu_probe': (.text.viommu_probe+0x1a0): undefined reference to `virtio_check_driver_offered_feature' (.text.viommu_probe+0x248): undefined reference to `virtio_check_driver_offered_feature' (.text.viommu_probe+0x2ec): undefined reference to `virtio_check_driver_offered_feature' (.text.viommu_probe+0x328): undefined reference to `virtio_check_driver_offered_feature' >> (.text.viommu_probe+0x428): undefined reference to `virtqueue_add_inbuf' >> (.text.viommu_probe+0x440): undefined reference to `virtqueue_kick' drivers/iommu/virtio-iommu.o: In function `virtio_iommu_drv_exit': (.exit.text+0x18): undefined reference to `unregister_virtio_driver' --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 1/4] iommu: Add virtio-iommu driver
Hi Jean-Philippe, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc2 next-20180221] [cannot apply to iommu/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jean-Philippe-Brucker/Add-virtio-iommu-driver/20180217-075417 config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=ia64 All errors (new ones prefixed by >>): drivers/iommu/virtio-iommu.o: In function `viommu_send_reqs_sync': >> virtio-iommu.c:(.text+0xa82): undefined reference to `virtqueue_add_sgs' >> virtio-iommu.c:(.text+0xb52): undefined reference to `virtqueue_kick' >> virtio-iommu.c:(.text+0xd82): undefined reference to `virtqueue_get_buf' drivers/iommu/virtio-iommu.o: In function `viommu_probe': >> virtio-iommu.c:(.text+0x23f2): undefined reference to >> `virtio_check_driver_offered_feature' virtio-iommu.c:(.text+0x2572): undefined reference to `virtio_check_driver_offered_feature' virtio-iommu.c:(.text+0x26f2): undefined reference to `virtio_check_driver_offered_feature' drivers/iommu/virtio-iommu.o: In function `virtio_iommu_drv_init': >> virtio-iommu.c:(.init.text+0x22): undefined reference to >> `register_virtio_driver' --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 1/4] iommu: Add virtio-iommu driver
Hi Jean-Philippe, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc2 next-20180221] [cannot apply to iommu/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jean-Philippe-Brucker/Add-virtio-iommu-driver/20180217-075417 config: arm64-allmodconfig (attached as .config) compiler: aarch64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=arm64 All errors (new ones prefixed by >>): aarch64-linux-gnu-ld: arch/arm64/kernel/head.o: relocation R_AARCH64_ABS32 against `_kernel_offset_le_lo32' can not be used when making a shared object arch/arm64/kernel/head.o: In function `kimage_vaddr': (.idmap.text+0x0): dangerous relocation: unsupported relocation arch/arm64/kernel/head.o: In function `__primary_switch': (.idmap.text+0x340): dangerous relocation: unsupported relocation (.idmap.text+0x348): dangerous relocation: unsupported relocation drivers/iommu/virtio-iommu.o: In function `viommu_probe': virtio-iommu.c:(.text+0xbdc): undefined reference to `virtio_check_driver_offered_feature' virtio-iommu.c:(.text+0xcfc): undefined reference to `virtio_check_driver_offered_feature' virtio-iommu.c:(.text+0xe10): undefined reference to `virtio_check_driver_offered_feature' drivers/iommu/virtio-iommu.o: In function `viommu_send_reqs_sync': virtio-iommu.c:(.text+0x130c): undefined reference to `virtqueue_add_sgs' virtio-iommu.c:(.text+0x1398): undefined reference to `virtqueue_kick' virtio-iommu.c:(.text+0x14d4): undefined reference to `virtqueue_get_buf' drivers/iommu/virtio-iommu.o: In function `virtio_iommu_drv_init': virtio-iommu.c:(.init.text+0x1c): undefined reference to `register_virtio_driver' drivers/iommu/virtio-iommu.o: In function `virtio_iommu_drv_exit': >> virtio-iommu.c:(.exit.text+0x14): undefined reference to >> `unregister_virtio_driver' --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 1/2] iommu: Fix iommu_unmap and iommu_unmap_fast return type
Hi Suravee,
I love your patch! Perhaps something to improve:
[auto build test WARNING on iommu/next]
[also build test WARNING on v4.15 next-20180202]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Suravee-Suthikulpanit/iommu-Fix-iommu_unmap-and-iommu_unmap_fast-return-type/20180203-015316
base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> drivers/iommu/qcom_iommu.c:592:27: sparse: incorrect type in initializer
>> (different signedness) @@ expected long ( )( ... ) @@ got unsigned long ( )(
>> ... ) @@
drivers/iommu/qcom_iommu.c:592:27: expected long ( )( ... )
drivers/iommu/qcom_iommu.c:592:27: got unsigned long ( )( ... )
drivers/iommu/qcom_iommu.c:592:12: error: initialization from incompatible
pointer type
.unmap = qcom_iommu_unmap,
^~~~
drivers/iommu/qcom_iommu.c:592:12: note: (near initialization for
'qcom_iommu_ops.unmap')
cc1: some warnings being treated as errors
vim +592 drivers/iommu/qcom_iommu.c
0ae349a0f3 Rob Clark2017-08-09 584
0ae349a0f3 Rob Clark2017-08-09 585 static const struct iommu_ops
qcom_iommu_ops = {
0ae349a0f3 Rob Clark2017-08-09 586 .capable=
qcom_iommu_capable,
0ae349a0f3 Rob Clark2017-08-09 587 .domain_alloc =
qcom_iommu_domain_alloc,
0ae349a0f3 Rob Clark2017-08-09 588 .domain_free=
qcom_iommu_domain_free,
0ae349a0f3 Rob Clark2017-08-09 589 .attach_dev =
qcom_iommu_attach_dev,
0ae349a0f3 Rob Clark2017-08-09 590 .detach_dev =
qcom_iommu_detach_dev,
0ae349a0f3 Rob Clark2017-08-09 591 .map=
qcom_iommu_map,
0ae349a0f3 Rob Clark2017-08-09 @592 .unmap =
qcom_iommu_unmap,
0ae349a0f3 Rob Clark2017-08-09 593 .map_sg =
default_iommu_map_sg,
4d689b6194 Robin Murphy 2017-09-28 594 .flush_iotlb_all =
qcom_iommu_iotlb_sync,
4d689b6194 Robin Murphy 2017-09-28 595 .iotlb_sync =
qcom_iommu_iotlb_sync,
0ae349a0f3 Rob Clark2017-08-09 596 .iova_to_phys =
qcom_iommu_iova_to_phys,
0ae349a0f3 Rob Clark2017-08-09 597 .add_device =
qcom_iommu_add_device,
0ae349a0f3 Rob Clark2017-08-09 598 .remove_device =
qcom_iommu_remove_device,
0ae349a0f3 Rob Clark2017-08-09 599 .device_group =
generic_device_group,
0ae349a0f3 Rob Clark2017-08-09 600 .of_xlate =
qcom_iommu_of_xlate,
0ae349a0f3 Rob Clark2017-08-09 601 .pgsize_bitmap = SZ_4K |
SZ_64K | SZ_1M | SZ_16M,
0ae349a0f3 Rob Clark2017-08-09 602 };
0ae349a0f3 Rob Clark2017-08-09 603
:: The code at line 592 was first introduced by commit
:: 0ae349a0f33fb040a2bc228fdc6d60111455feab iommu/qcom: Add qcom_iommu
:: TO: Rob Clark
:: CC: Joerg Roedel
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 1/2] iommu: Fix iommu_unmap and iommu_unmap_fast return type
Hi Suravee,
I love your patch! Yet something to improve:
[auto build test ERROR on iommu/next]
[also build test ERROR on v4.15 next-20180202]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Suravee-Suthikulpanit/iommu-Fix-iommu_unmap-and-iommu_unmap_fast-return-type/20180203-015316
base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: sparc64-allyesconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=sparc64
All errors (new ones prefixed by >>):
>> drivers/iommu/qcom_iommu.c:592:12: error: initialization from incompatible
>> pointer type [-Werror=incompatible-pointer-types]
.unmap = qcom_iommu_unmap,
^~~~
drivers/iommu/qcom_iommu.c:592:12: note: (near initialization for
'qcom_iommu_ops.unmap')
cc1: some warnings being treated as errors
vim +592 drivers/iommu/qcom_iommu.c
0ae349a0f3 Rob Clark2017-08-09 584
0ae349a0f3 Rob Clark2017-08-09 585 static const struct iommu_ops
qcom_iommu_ops = {
0ae349a0f3 Rob Clark2017-08-09 586 .capable=
qcom_iommu_capable,
0ae349a0f3 Rob Clark2017-08-09 587 .domain_alloc =
qcom_iommu_domain_alloc,
0ae349a0f3 Rob Clark2017-08-09 588 .domain_free=
qcom_iommu_domain_free,
0ae349a0f3 Rob Clark2017-08-09 589 .attach_dev =
qcom_iommu_attach_dev,
0ae349a0f3 Rob Clark2017-08-09 590 .detach_dev =
qcom_iommu_detach_dev,
0ae349a0f3 Rob Clark2017-08-09 591 .map=
qcom_iommu_map,
0ae349a0f3 Rob Clark2017-08-09 @592 .unmap =
qcom_iommu_unmap,
0ae349a0f3 Rob Clark2017-08-09 593 .map_sg =
default_iommu_map_sg,
4d689b6194 Robin Murphy 2017-09-28 594 .flush_iotlb_all =
qcom_iommu_iotlb_sync,
4d689b6194 Robin Murphy 2017-09-28 595 .iotlb_sync =
qcom_iommu_iotlb_sync,
0ae349a0f3 Rob Clark2017-08-09 596 .iova_to_phys =
qcom_iommu_iova_to_phys,
0ae349a0f3 Rob Clark2017-08-09 597 .add_device =
qcom_iommu_add_device,
0ae349a0f3 Rob Clark2017-08-09 598 .remove_device =
qcom_iommu_remove_device,
0ae349a0f3 Rob Clark2017-08-09 599 .device_group =
generic_device_group,
0ae349a0f3 Rob Clark2017-08-09 600 .of_xlate =
qcom_iommu_of_xlate,
0ae349a0f3 Rob Clark2017-08-09 601 .pgsize_bitmap = SZ_4K |
SZ_64K | SZ_1M | SZ_16M,
0ae349a0f3 Rob Clark2017-08-09 602 };
0ae349a0f3 Rob Clark2017-08-09 603
:: The code at line 592 was first introduced by commit
:: 0ae349a0f33fb040a2bc228fdc6d60111455feab iommu/qcom: Add qcom_iommu
:: TO: Rob Clark
:: CC: Joerg Roedel
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
