Re: [PATCH] Documentation: DMA-API: fix a function name of max_mapping_size
On Fri, 7 Jun 2019 16:47:13 +0900
Yoshihiro Shimoda wrote:
> The exported function name is dma_max_mapping_size(), not
> dma_direct_max_mapping_size() so that this patch fixes
> the function name in the documentation.
>
> Fixes: 133d624b1cee ("dma: Introduce dma_max_mapping_size()")
> Signed-off-by: Yoshihiro Shimoda
> ---
> Documentation/DMA-API.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/DMA-API.txt b/Documentation/DMA-API.txt
> index 0076150..e47c63b 100644
> --- a/Documentation/DMA-API.txt
> +++ b/Documentation/DMA-API.txt
> @@ -198,7 +198,7 @@ call to set the mask to the value returned.
> ::
>
> size_t
> - dma_direct_max_mapping_size(struct device *dev);
> + dma_max_mapping_size(struct device *dev);
>
> Returns the maximum size of a mapping for the device. The size parameter
> of the mapping functions like dma_map_single(), dma_map_page() and
Applied, thanks.
jon
RE: [PATCH] Documentation: DMA-API: fix a function name of max_mapping_size
Hi Christoph, > From: Christoph Hellwig, Sent: Friday, June 7, 2019 5:35 PM > > On Fri, Jun 07, 2019 at 08:19:08AM +, Yoshihiro Shimoda wrote: > > Hi Christoph, > > > > > From: Christoph Hellwig, Sent: Friday, June 7, 2019 5:08 PM > > > > > > Looks good. And it seems like you've also found the solution to > > > your usb storage problem, but I'm going to post the variant I just > > > hacked up nevertheless. > > > > Thank you for your reply! I think this API is related to my problem, > > but I don't have any actual solution (a patch) for now. So, I'll wait > > for your patch! > > Turns out it isn't as simple as I thought, as there doesn't seem to > be an easy way to get to the struct device used for DMA mapping > from USB drivers. I'll need to think a bit more how to handle that > best. Thank you for your reply. I sent an email on the original report as below. https://marc.info/?l=linux-block&m=155990883224615&w=2 Best regards, Yoshihiro Shimoda
Re: [PATCH] Documentation: DMA-API: fix a function name of max_mapping_size
On Fri, Jun 07, 2019 at 08:19:08AM +, Yoshihiro Shimoda wrote: > Hi Christoph, > > > From: Christoph Hellwig, Sent: Friday, June 7, 2019 5:08 PM > > > > Looks good. And it seems like you've also found the solution to > > your usb storage problem, but I'm going to post the variant I just > > hacked up nevertheless. > > Thank you for your reply! I think this API is related to my problem, > but I don't have any actual solution (a patch) for now. So, I'll wait > for your patch! Turns out it isn't as simple as I thought, as there doesn't seem to be an easy way to get to the struct device used for DMA mapping from USB drivers. I'll need to think a bit more how to handle that best.
RE: [PATCH] Documentation: DMA-API: fix a function name of max_mapping_size
Hi Christoph, > From: Christoph Hellwig, Sent: Friday, June 7, 2019 5:08 PM > > Looks good. And it seems like you've also found the solution to > your usb storage problem, but I'm going to post the variant I just > hacked up nevertheless. Thank you for your reply! I think this API is related to my problem, but I don't have any actual solution (a patch) for now. So, I'll wait for your patch! Best regards, Yoshihiro Shimoda
Re: [PATCH] Documentation: DMA-API: fix a function name of max_mapping_size
Looks good. And it seems like you've also found the solution to your usb storage problem, but I'm going to post the variant I just hacked up nevertheless.
[PATCH] Documentation: DMA-API: fix a function name of max_mapping_size
The exported function name is dma_max_mapping_size(), not
dma_direct_max_mapping_size() so that this patch fixes
the function name in the documentation.
Fixes: 133d624b1cee ("dma: Introduce dma_max_mapping_size()")
Signed-off-by: Yoshihiro Shimoda
---
Documentation/DMA-API.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/DMA-API.txt b/Documentation/DMA-API.txt
index 0076150..e47c63b 100644
--- a/Documentation/DMA-API.txt
+++ b/Documentation/DMA-API.txt
@@ -198,7 +198,7 @@ call to set the mask to the value returned.
::
size_t
- dma_direct_max_mapping_size(struct device *dev);
+ dma_max_mapping_size(struct device *dev);
Returns the maximum size of a mapping for the device. The size parameter
of the mapping functions like dma_map_single(), dma_map_page() and
--
2.7.4
