Re: [PATCH] iommu/renesas: fix unused-function warning
On Sat, May 09, 2020 at 12:02:16AM +0200, Arnd Bergmann wrote: > gcc warns because the only reference to ipmmu_find_group > is inside of an #ifdef: > > drivers/iommu/ipmmu-vmsa.c:878:28: error: 'ipmmu_find_group' defined but not > used [-Werror=unused-function] > > Change the #ifdef to an equivalent IS_ENABLED(). > > Fixes: 6580c8a78424 ("iommu/renesas: Convert to probe/release_device() > call-backs") > Signed-off-by: Arnd Bergmann > --- > drivers/iommu/ipmmu-vmsa.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) Applied, thanks. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH] iommu/renesas: fix unused-function warning
On Sat, May 09, 2020 at 12:02:16AM +0200, Arnd Bergmann wrote: > gcc warns because the only reference to ipmmu_find_group > is inside of an #ifdef: > > drivers/iommu/ipmmu-vmsa.c:878:28: error: 'ipmmu_find_group' defined but not > used [-Werror=unused-function] > > Change the #ifdef to an equivalent IS_ENABLED(). > > Fixes: 6580c8a78424 ("iommu/renesas: Convert to probe/release_device() > call-backs") > Signed-off-by: Arnd Bergmann Reviewed-by: Simon Horman > --- > drivers/iommu/ipmmu-vmsa.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c > index fb7e702dee23..4c2972f3153b 100644 > --- a/drivers/iommu/ipmmu-vmsa.c > +++ b/drivers/iommu/ipmmu-vmsa.c > @@ -903,11 +903,8 @@ static const struct iommu_ops ipmmu_ops = { > .probe_device = ipmmu_probe_device, > .release_device = ipmmu_release_device, > .probe_finalize = ipmmu_probe_finalize, > -#if defined(CONFIG_ARM) && !defined(CONFIG_IOMMU_DMA) > - .device_group = generic_device_group, > -#else > - .device_group = ipmmu_find_group, > -#endif > + .device_group = IS_ENABLED(CONFIG_ARM) && !IS_ENABLED(CONFIG_IOMMU_DMA) > + ? generic_device_group : ipmmu_find_group, > .pgsize_bitmap = SZ_1G | SZ_2M | SZ_4K, > .of_xlate = ipmmu_of_xlate, > }; > -- > 2.26.0 > ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
[PATCH] iommu/renesas: fix unused-function warning
gcc warns because the only reference to ipmmu_find_group is inside of an #ifdef: drivers/iommu/ipmmu-vmsa.c:878:28: error: 'ipmmu_find_group' defined but not used [-Werror=unused-function] Change the #ifdef to an equivalent IS_ENABLED(). Fixes: 6580c8a78424 ("iommu/renesas: Convert to probe/release_device() call-backs") Signed-off-by: Arnd Bergmann --- drivers/iommu/ipmmu-vmsa.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/iommu/ipmmu-vmsa.c b/drivers/iommu/ipmmu-vmsa.c index fb7e702dee23..4c2972f3153b 100644 --- a/drivers/iommu/ipmmu-vmsa.c +++ b/drivers/iommu/ipmmu-vmsa.c @@ -903,11 +903,8 @@ static const struct iommu_ops ipmmu_ops = { .probe_device = ipmmu_probe_device, .release_device = ipmmu_release_device, .probe_finalize = ipmmu_probe_finalize, -#if defined(CONFIG_ARM) && !defined(CONFIG_IOMMU_DMA) - .device_group = generic_device_group, -#else - .device_group = ipmmu_find_group, -#endif + .device_group = IS_ENABLED(CONFIG_ARM) && !IS_ENABLED(CONFIG_IOMMU_DMA) + ? generic_device_group : ipmmu_find_group, .pgsize_bitmap = SZ_1G | SZ_2M | SZ_4K, .of_xlate = ipmmu_of_xlate, }; -- 2.26.0 ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu