Re: [PATCH v2 02/13] iommu/rockchip: Suppress unbinding

2018-01-16 Thread JeffyChen 

Hi Tomasz,

On 01/17/2018 01:32 PM, Tomasz Figa wrote:

On Wed, Jan 17, 2018 at 1:23 PM, Tomasz Figa  wrote:

On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen  wrote:

It's not safe to unbind rockchip IOMMU driver.


Might be good to explain why it is not safe and actually add that it
does not make any sense for such low level devices.


Actually, shouldn't we also remove support for .remove() and module
exit? I don't think it's actually feasible to unload this driver. We
actually even have ROCKCHIP_IOMMU Kconfig entry defined as bool, so
the driver can be only built-in.


right, will do it in the next version.

Best regards,
Tomasz






___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v2 02/13] iommu/rockchip: Suppress unbinding

2018-01-16 Thread Tomasz Figa 
On Wed, Jan 17, 2018 at 1:23 PM, Tomasz Figa  wrote:
> On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen  
> wrote:
>> It's not safe to unbind rockchip IOMMU driver.
>
> Might be good to explain why it is not safe and actually add that it
> does not make any sense for such low level devices.

Actually, shouldn't we also remove support for .remove() and module
exit? I don't think it's actually feasible to unload this driver. We
actually even have ROCKCHIP_IOMMU Kconfig entry defined as bool, so
the driver can be only built-in.

Best regards,
Tomasz
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH v2 02/13] iommu/rockchip: Suppress unbinding

2018-01-16 Thread Tomasz Figa 
On Tue, Jan 16, 2018 at 10:25 PM, Jeffy Chen  wrote:
> It's not safe to unbind rockchip IOMMU driver.

Might be good to explain why it is not safe and actually add that it
does not make any sense for such low level devices.

Best regards,
Tomasz
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

[PATCH v2 02/13] iommu/rockchip: Suppress unbinding

2018-01-16 Thread Jeffy Chen 
It's not safe to unbind rockchip IOMMU driver.

Signed-off-by: Jeffy Chen 
---

Changes in v2: None

 drivers/iommu/rockchip-iommu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c
index 4a12d4746095..da4afe016a4e 100644
--- a/drivers/iommu/rockchip-iommu.c
+++ b/drivers/iommu/rockchip-iommu.c
@@ -1205,6 +1205,7 @@ static struct platform_driver rk_iommu_driver = {
.driver = {
   .name = "rk_iommu",
   .of_match_table = rk_iommu_dt_ids,
+  .suppress_bind_attrs = true,
},
 };
 
-- 
2.11.0


___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu