Re: [PATCH v4 00/13] iommu/rockchip: Use OF_IOMMU
Hi Joerg, Thanks for your reply. On 01/18/2018 08:44 PM, Joerg Roedel wrote: On Thu, Jan 18, 2018 at 07:52:38PM +0800, Jeffy Chen wrote: Jeffy Chen (9): iommu/rockchip: Prohibit unbind and remove iommu/rockchip: Fix error handling in probe iommu/rockchip: Request irqs in rk_iommu_probe() ARM: dts: rockchip: add clocks in vop iommu nodes iommu/rockchip: Use IOMMU device for dma mapping operations iommu/rockchip: Use OF_IOMMU to attach devices automatically iommu/rockchip: Fix error handling in init iommu/rockchip: Add runtime PM support iommu/rockchip: Support sharing IOMMU between masters Tomasz Figa (4): iommu/rockchip: Fix error handling in attach iommu/rockchip: Use iopoll helpers to wait for hardware iommu/rockchip: Fix TLB flush of secondary IOMMUs iommu/rockchip: Control clocks needed to access the IOMMU Please stop resending this every day with minimal changes. I am not going to take it for v4.16, as we are late in the cycle already and there are still review comments. Just collect all feedback, update the patches, rebase them to v4.16-rc1 when its out, and send a new version. oops, sorry, i send v4 today is mainly because i found v3 would break some of the rk platforms, which needs an extra patch [7] (ARM: dts: rockchip: add clocks in vop iommu nodes), but forgot to mention it in the change log... will send new version after all the rest patches been reviewed :) Joerg ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v4 00/13] iommu/rockchip: Use OF_IOMMU
On Thu, Jan 18, 2018 at 07:52:38PM +0800, Jeffy Chen wrote: > Jeffy Chen (9): > iommu/rockchip: Prohibit unbind and remove > iommu/rockchip: Fix error handling in probe > iommu/rockchip: Request irqs in rk_iommu_probe() > ARM: dts: rockchip: add clocks in vop iommu nodes > iommu/rockchip: Use IOMMU device for dma mapping operations > iommu/rockchip: Use OF_IOMMU to attach devices automatically > iommu/rockchip: Fix error handling in init > iommu/rockchip: Add runtime PM support > iommu/rockchip: Support sharing IOMMU between masters > > Tomasz Figa (4): > iommu/rockchip: Fix error handling in attach > iommu/rockchip: Use iopoll helpers to wait for hardware > iommu/rockchip: Fix TLB flush of secondary IOMMUs > iommu/rockchip: Control clocks needed to access the IOMMU Please stop resending this every day with minimal changes. I am not going to take it for v4.16, as we are late in the cycle already and there are still review comments. Just collect all feedback, update the patches, rebase them to v4.16-rc1 when its out, and send a new version. Joerg ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
[PATCH v4 00/13] iommu/rockchip: Use OF_IOMMU
This series fixes some issues in rockchip iommu driver, and add of_iommu support in it. Changes in v4: Rewrite commit message. Changes in v3: Also remove remove() and module_exit() as Tomasz suggested. Loop platform_get_irq() as Robin suggested. Add struct rk_iommudata. Squash iommu/rockchip: Use iommu_group_get_for_dev() for add_device Only call startup() and shutdown() when iommu attached. Remove pm_mutex. Check runtime PM disabled. Check pm_runtime in rk_iommu_irq(). Remove rk_iommudata->domain. Changes in v2: Move irq request to probe(in patch[0]) Move bus_set_iommu() to rk_iommu_probe(). Jeffy Chen (9): iommu/rockchip: Prohibit unbind and remove iommu/rockchip: Fix error handling in probe iommu/rockchip: Request irqs in rk_iommu_probe() ARM: dts: rockchip: add clocks in vop iommu nodes iommu/rockchip: Use IOMMU device for dma mapping operations iommu/rockchip: Use OF_IOMMU to attach devices automatically iommu/rockchip: Fix error handling in init iommu/rockchip: Add runtime PM support iommu/rockchip: Support sharing IOMMU between masters Tomasz Figa (4): iommu/rockchip: Fix error handling in attach iommu/rockchip: Use iopoll helpers to wait for hardware iommu/rockchip: Fix TLB flush of secondary IOMMUs iommu/rockchip: Control clocks needed to access the IOMMU .../devicetree/bindings/iommu/rockchip,iommu.txt | 8 + arch/arm/boot/dts/rk3036.dtsi | 2 + arch/arm/boot/dts/rk3288.dtsi | 4 + drivers/iommu/rockchip-iommu.c | 653 - 4 files changed, 386 insertions(+), 281 deletions(-) -- 2.11.0 ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
