Re: [PATCHv2] iommu/arm-smmu: Make remove callback message more informative
On Thu, 23 Apr 2020 15:25:31 +0530, Sai Prakash Ranjan wrote: > Currently on reboot/shutdown, the following messages are > displayed on the console as error messages before the > system reboots/shutdown as part of remove callback. > > On SC7180: > > arm-smmu 1500.iommu: removing device with active domains! > arm-smmu 504.iommu: removing device with active domains! > > [...] Applied to will (for-joerg/arm-smmu/updates), thanks! [1/1] iommu/arm-smmu: Make remove callback message more informative https://git.kernel.org/will/c/02782f3d60f1 Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCHv2] iommu/arm-smmu: Make remove callback message more informative
On 2020-05-07 16:03, Robin Murphy wrote: On 2020-05-07 11:04 am, Sai Prakash Ranjan wrote: Hi, On 2020-05-07 05:40, Doug Anderson wrote: Hi, On Thu, Apr 23, 2020 at 7:35 AM Doug Anderson wrote: Hi, On Thu, Apr 23, 2020 at 2:55 AM Sai Prakash Ranjan wrote: > > Currently on reboot/shutdown, the following messages are > displayed on the console as error messages before the > system reboots/shutdown as part of remove callback. > > On SC7180: > > arm-smmu 1500.iommu: removing device with active domains! > arm-smmu 504.iommu: removing device with active domains! > > Make this error message more informative and less scary. > > Reported-by: Douglas Anderson > Suggested-by: Robin Murphy > Signed-off-by: Sai Prakash Ranjan > --- > drivers/iommu/arm-smmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Douglas Anderson Is this patch waiting on anything in particular now? Do we need reviews from Robin and/or Will? Waiting for their reviews as they are the maintainers/reviewers :) Sorry, this did register at the time, I just felt that it's a bit redundant to give a review tag to say "yes, this is exactly what I suggested" :) That said, I do wish I hadn't forgotten about the dev_notice message level, but I think that lies over in the conceptual purity corner rather than making any practical difference, so I'm still OK with the patch as-is. Will? I can change to dev_notice if you have strong preference for that. I chose dev_info since we see the messages on every reboot and that makes it more informational than something to notice everytime. p.s. whoever has this entry in their address book for the IOMMU list (Doug?): "l...@263.net:IOMMU DRIVERS , Joerg Roedel ," it really messes up Thunderbird's ability to generate working headers for a reply ;) Not me ;) Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCHv2] iommu/arm-smmu: Make remove callback message more informative
On 2020-05-07 11:04 am, Sai Prakash Ranjan wrote: Hi, On 2020-05-07 05:40, Doug Anderson wrote: Hi, On Thu, Apr 23, 2020 at 7:35 AM Doug Anderson wrote: Hi, On Thu, Apr 23, 2020 at 2:55 AM Sai Prakash Ranjan wrote: > > Currently on reboot/shutdown, the following messages are > displayed on the console as error messages before the > system reboots/shutdown as part of remove callback. > > On SC7180: > > arm-smmu 1500.iommu: removing device with active domains! > arm-smmu 504.iommu: removing device with active domains! > > Make this error message more informative and less scary. > > Reported-by: Douglas Anderson > Suggested-by: Robin Murphy > Signed-off-by: Sai Prakash Ranjan > --- > drivers/iommu/arm-smmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Douglas Anderson Is this patch waiting on anything in particular now? Do we need reviews from Robin and/or Will? Waiting for their reviews as they are the maintainers/reviewers :) Sorry, this did register at the time, I just felt that it's a bit redundant to give a review tag to say "yes, this is exactly what I suggested" :) That said, I do wish I hadn't forgotten about the dev_notice message level, but I think that lies over in the conceptual purity corner rather than making any practical difference, so I'm still OK with the patch as-is. Will? Robin. p.s. whoever has this entry in their address book for the IOMMU list (Doug?): "l...@263.net:IOMMU DRIVERS , Joerg Roedel ," it really messes up Thunderbird's ability to generate working headers for a reply ;) ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCHv2] iommu/arm-smmu: Make remove callback message more informative
Hi, On 2020-05-07 05:40, Doug Anderson wrote: Hi, On Thu, Apr 23, 2020 at 7:35 AM Doug Anderson wrote: Hi, On Thu, Apr 23, 2020 at 2:55 AM Sai Prakash Ranjan wrote: > > Currently on reboot/shutdown, the following messages are > displayed on the console as error messages before the > system reboots/shutdown as part of remove callback. > > On SC7180: > > arm-smmu 1500.iommu: removing device with active domains! > arm-smmu 504.iommu: removing device with active domains! > > Make this error message more informative and less scary. > > Reported-by: Douglas Anderson > Suggested-by: Robin Murphy > Signed-off-by: Sai Prakash Ranjan > --- > drivers/iommu/arm-smmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Douglas Anderson Is this patch waiting on anything in particular now? Do we need reviews from Robin and/or Will? Waiting for their reviews as they are the maintainers/reviewers :) -Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCHv2] iommu/arm-smmu: Make remove callback message more informative
Hi, On Thu, Apr 23, 2020 at 7:35 AM Doug Anderson wrote: > > Hi, > > On Thu, Apr 23, 2020 at 2:55 AM Sai Prakash Ranjan > wrote: > > > > Currently on reboot/shutdown, the following messages are > > displayed on the console as error messages before the > > system reboots/shutdown as part of remove callback. > > > > On SC7180: > > > > arm-smmu 1500.iommu: removing device with active domains! > > arm-smmu 504.iommu: removing device with active domains! > > > > Make this error message more informative and less scary. > > > > Reported-by: Douglas Anderson > > Suggested-by: Robin Murphy > > Signed-off-by: Sai Prakash Ranjan > > --- > > drivers/iommu/arm-smmu.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Douglas Anderson Is this patch waiting on anything in particular now? Do we need reviews from Robin and/or Will? -Doug ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCHv2] iommu/arm-smmu: Make remove callback message more informative
Hi, On Thu, Apr 23, 2020 at 2:55 AM Sai Prakash Ranjan wrote: > > Currently on reboot/shutdown, the following messages are > displayed on the console as error messages before the > system reboots/shutdown as part of remove callback. > > On SC7180: > > arm-smmu 1500.iommu: removing device with active domains! > arm-smmu 504.iommu: removing device with active domains! > > Make this error message more informative and less scary. > > Reported-by: Douglas Anderson > Suggested-by: Robin Murphy > Signed-off-by: Sai Prakash Ranjan > --- > drivers/iommu/arm-smmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Douglas Anderson ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
[PATCHv2] iommu/arm-smmu: Make remove callback message more informative
Currently on reboot/shutdown, the following messages are displayed on the console as error messages before the system reboots/shutdown as part of remove callback. On SC7180: arm-smmu 1500.iommu: removing device with active domains! arm-smmu 504.iommu: removing device with active domains! Make this error message more informative and less scary. Reported-by: Douglas Anderson Suggested-by: Robin Murphy Signed-off-by: Sai Prakash Ranjan --- drivers/iommu/arm-smmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c index e622f4e33379..8ea634876e6c 100644 --- a/drivers/iommu/arm-smmu.c +++ b/drivers/iommu/arm-smmu.c @@ -2244,7 +2244,7 @@ static int arm_smmu_device_remove(struct platform_device *pdev) return -ENODEV; if (!bitmap_empty(smmu->context_map, ARM_SMMU_MAX_CBS)) - dev_err(>dev, "removing device with active domains!\n"); + dev_info(>dev, "disabling translation\n"); arm_smmu_bus_init(NULL); iommu_device_unregister(>iommu); -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
