Re: [PATCH 0/4] iommu/fsl: Freescale PAMU driver and IOMMU API implementation.
Hi Varun, On Thu, Jan 03, 2013 at 05:21:09AM +, Sethi Varun-B16395 wrote: > It's been a while since I submitted this patch. I have tried to > address your comments regarding the subwindow attribute. I would > really appreciate if I can get some feedback on this patch. I have some ideas in mind how we can abstract this in the IOMMU-API (with an extension to the API). I will send a RFC patchset soon to add these changes and then we can discuss it. Joerg ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
RE: [PATCH 0/4] iommu/fsl: Freescale PAMU driver and IOMMU API implementation.
Hi Joerg, It's been a while since I submitted this patch. I have tried to address your comments regarding the subwindow attribute. I would really appreciate if I can get some feedback on this patch. Regards Varun > -Original Message- > From: Sethi Varun-B16395 > Sent: Friday, December 21, 2012 7:17 AM > To: 'Joerg Roedel' > Cc: Sethi Varun-B16395; joerg.roe...@amd.com; iommu@lists.linux- > foundation.org; linuxppc-...@lists.ozlabs.org; linux- > ker...@vger.kernel.org; Tabi Timur-B04825; Wood Scott-B07421 > Subject: RE: [PATCH 0/4] iommu/fsl: Freescale PAMU driver and IOMMU API > implementation. > > ping!! > > > -Original Message- > > From: Sethi Varun-B16395 > > Sent: Friday, December 14, 2012 7:22 PM > > To: joerg.roe...@amd.com; iommu@lists.linux-foundation.org; linuxppc- > > d...@lists.ozlabs.org; linux-ker...@vger.kernel.org; Tabi Timur-B04825; > > Wood Scott-B07421 > > Cc: Sethi Varun-B16395 > > Subject: [PATCH 0/4] iommu/fsl: Freescale PAMU driver and IOMMU API > > implementation. > > > > This patchset provides the Freescale PAMU (Peripheral Access > > Management > > Unit) driver and the corresponding IOMMU API implementation. PAMU is > > the IOMMU present on Freescale QorIQ platforms. PAMU can authorize > > memory access, remap the memory address, and remap the I/O transaction > type. > > > > This set consists of the following patches: > > 1. Addition of new field in the device (powerpc) archdata structure > > for storing iommu domain information > >pointer. This pointer is stored when the device is attached to a > > particular iommu domain. > > 2. Add PAMU bypass enable register to the ccsr_guts structure. > > 3. Addition of domain attributes required by the PAMU driver IOMMU API. > > 4. PAMU driver and IOMMU API implementation. > > > > This patch set is based on the next branch of the iommu git tree > > maintained by Joerg. > > > > Varun Sethi (4): > > store iommu domain info in device arch data. > > add pamu bypass enable register to guts. > > Add iommu attributes for PAMU > > FSL PAMU driver. > > > > arch/powerpc/include/asm/device.h |4 + > > arch/powerpc/include/asm/fsl_guts.h |4 +- > > drivers/iommu/Kconfig |8 + > > drivers/iommu/Makefile |1 + > > drivers/iommu/fsl_pamu.c| 1152 > > +++ > > drivers/iommu/fsl_pamu.h| 398 > > drivers/iommu/fsl_pamu_domain.c | 1033 > > +++ > > drivers/iommu/fsl_pamu_domain.h | 96 +++ > > include/linux/iommu.h | 49 ++ > > 9 files changed, 2744 insertions(+), 1 deletions(-) create mode > > 100644 drivers/iommu/fsl_pamu.c create mode 100644 > > drivers/iommu/fsl_pamu.h create mode 100644 > > drivers/iommu/fsl_pamu_domain.c create mode 100644 > > drivers/iommu/fsl_pamu_domain.h > > > > -- > > 1.7.4.1 ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
RE: [PATCH 0/4] iommu/fsl: Freescale PAMU driver and IOMMU API implementation.
Hi Joerg, Do you have any comments on the patchset? Regards Varun > -Original Message- > From: Sethi Varun-B16395 > Sent: Friday, December 21, 2012 7:17 AM > To: 'Joerg Roedel' > Cc: Sethi Varun-B16395; joerg.roe...@amd.com; iommu@lists.linux- > foundation.org; linuxppc-...@lists.ozlabs.org; linux- > ker...@vger.kernel.org; Tabi Timur-B04825; Wood Scott-B07421 > Subject: RE: [PATCH 0/4] iommu/fsl: Freescale PAMU driver and IOMMU API > implementation. > > ping!! > > > -Original Message- > > From: Sethi Varun-B16395 > > Sent: Friday, December 14, 2012 7:22 PM > > To: joerg.roe...@amd.com; iommu@lists.linux-foundation.org; linuxppc- > > d...@lists.ozlabs.org; linux-ker...@vger.kernel.org; Tabi Timur-B04825; > > Wood Scott-B07421 > > Cc: Sethi Varun-B16395 > > Subject: [PATCH 0/4] iommu/fsl: Freescale PAMU driver and IOMMU API > > implementation. > > > > This patchset provides the Freescale PAMU (Peripheral Access > > Management > > Unit) driver and the corresponding IOMMU API implementation. PAMU is > > the IOMMU present on Freescale QorIQ platforms. PAMU can authorize > > memory access, remap the memory address, and remap the I/O transaction > type. > > > > This set consists of the following patches: > > 1. Addition of new field in the device (powerpc) archdata structure > > for storing iommu domain information > >pointer. This pointer is stored when the device is attached to a > > particular iommu domain. > > 2. Add PAMU bypass enable register to the ccsr_guts structure. > > 3. Addition of domain attributes required by the PAMU driver IOMMU API. > > 4. PAMU driver and IOMMU API implementation. > > > > This patch set is based on the next branch of the iommu git tree > > maintained by Joerg. > > > > Varun Sethi (4): > > store iommu domain info in device arch data. > > add pamu bypass enable register to guts. > > Add iommu attributes for PAMU > > FSL PAMU driver. > > > > arch/powerpc/include/asm/device.h |4 + > > arch/powerpc/include/asm/fsl_guts.h |4 +- > > drivers/iommu/Kconfig |8 + > > drivers/iommu/Makefile |1 + > > drivers/iommu/fsl_pamu.c| 1152 > > +++ > > drivers/iommu/fsl_pamu.h| 398 > > drivers/iommu/fsl_pamu_domain.c | 1033 > > +++ > > drivers/iommu/fsl_pamu_domain.h | 96 +++ > > include/linux/iommu.h | 49 ++ > > 9 files changed, 2744 insertions(+), 1 deletions(-) create mode > > 100644 drivers/iommu/fsl_pamu.c create mode 100644 > > drivers/iommu/fsl_pamu.h create mode 100644 > > drivers/iommu/fsl_pamu_domain.c create mode 100644 > > drivers/iommu/fsl_pamu_domain.h > > > > -- > > 1.7.4.1 ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
RE: [PATCH 0/4] iommu/fsl: Freescale PAMU driver and IOMMU API implementation.
ping!! > -Original Message- > From: Sethi Varun-B16395 > Sent: Friday, December 14, 2012 7:22 PM > To: joerg.roe...@amd.com; iommu@lists.linux-foundation.org; linuxppc- > d...@lists.ozlabs.org; linux-ker...@vger.kernel.org; Tabi Timur-B04825; > Wood Scott-B07421 > Cc: Sethi Varun-B16395 > Subject: [PATCH 0/4] iommu/fsl: Freescale PAMU driver and IOMMU API > implementation. > > This patchset provides the Freescale PAMU (Peripheral Access Management > Unit) driver and the corresponding IOMMU API implementation. PAMU is the > IOMMU present on Freescale QorIQ platforms. PAMU can authorize memory > access, remap the memory address, and remap the I/O transaction type. > > This set consists of the following patches: > 1. Addition of new field in the device (powerpc) archdata structure for > storing iommu domain information >pointer. This pointer is stored when the device is attached to a > particular iommu domain. > 2. Add PAMU bypass enable register to the ccsr_guts structure. > 3. Addition of domain attributes required by the PAMU driver IOMMU API. > 4. PAMU driver and IOMMU API implementation. > > This patch set is based on the next branch of the iommu git tree > maintained by Joerg. > > Varun Sethi (4): > store iommu domain info in device arch data. > add pamu bypass enable register to guts. > Add iommu attributes for PAMU > FSL PAMU driver. > > arch/powerpc/include/asm/device.h |4 + > arch/powerpc/include/asm/fsl_guts.h |4 +- > drivers/iommu/Kconfig |8 + > drivers/iommu/Makefile |1 + > drivers/iommu/fsl_pamu.c| 1152 > +++ > drivers/iommu/fsl_pamu.h| 398 > drivers/iommu/fsl_pamu_domain.c | 1033 > +++ > drivers/iommu/fsl_pamu_domain.h | 96 +++ > include/linux/iommu.h | 49 ++ > 9 files changed, 2744 insertions(+), 1 deletions(-) create mode 100644 > drivers/iommu/fsl_pamu.c create mode 100644 drivers/iommu/fsl_pamu.h > create mode 100644 drivers/iommu/fsl_pamu_domain.c create mode 100644 > drivers/iommu/fsl_pamu_domain.h > > -- > 1.7.4.1 ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 0/4] iommu/fsl: Freescale PAMU driver and IOMMU API implementation.
Varun Sethi wrote: > This patchset provides the Freescale PAMU (Peripheral Access Management Unit) > driver > and the corresponding IOMMU API implementation. PAMU is the IOMMU present on > Freescale > QorIQ platforms. PAMU can authorize memory access, remap the memory address, > and remap > the I/O transaction type. You forgot to send post these patches to linuxppc-rele...@linux.freescale.net. May I suggest the following git-send-email ... --bcc linuxppc-rele...@linux.freescale.net ... whenever you post a patch upstream? > This set consists of the following patches: > 1. Addition of new field in the device (powerpc) archdata structure for > storing iommu domain information >pointer. This pointer is stored when the device is attached to a > particular iommu domain. > 2. Add PAMU bypass enable register to the ccsr_guts structure. I don't see patch 2/4 posted anywhere. -- Timur Tabi Linux kernel developer at Freescale ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu