Re: [PATCH 4/5] iommu: Add domain window handling functions
On Mon, Feb 04, 2013 at 05:31:51PM -0600, Stuart Yoder wrote: On Mon, Feb 4, 2013 at 12:56 PM, Joerg Roedel j...@8bytes.org wrote: Okay. So if your architecture supports sizes over 2^32 then size_t probably is already 64bits, right? No, on a 32-bit platform size_t would generally be 32-bits. But the PAMU is independent of that. I think we should just make it a u64. Okay, you can find the patches in the 'core' branch of the iommu-tree. They are also included in my next branch. You can use them now to base the PAMU patches on it. Joerg ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
RE: [PATCH 4/5] iommu: Add domain window handling functions
Thanks Joerg. -Original Message- From: Joerg Roedel [mailto:j...@8bytes.org] Sent: Wednesday, February 06, 2013 3:56 PM To: Stuart Yoder Cc: Sethi Varun-B16395; iommu@lists.linux-foundation.org; linux- ker...@vger.kernel.org Subject: Re: [PATCH 4/5] iommu: Add domain window handling functions On Mon, Feb 04, 2013 at 05:31:51PM -0600, Stuart Yoder wrote: On Mon, Feb 4, 2013 at 12:56 PM, Joerg Roedel j...@8bytes.org wrote: Okay. So if your architecture supports sizes over 2^32 then size_t probably is already 64bits, right? No, on a 32-bit platform size_t would generally be 32-bits. But the PAMU is independent of that. I think we should just make it a u64. Okay, you can find the patches in the 'core' branch of the iommu-tree. They are also included in my next branch. You can use them now to base the PAMU patches on it. Joerg ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH 4/5] iommu: Add domain window handling functions
On Mon, Feb 04, 2013 at 05:31:51PM -0600, Stuart Yoder wrote:
On Mon, Feb 4, 2013 at 12:56 PM, Joerg Roedel j...@8bytes.org wrote:
On Mon, Feb 04, 2013 at 12:10:51PM -0600, Stuart Yoder wrote:
On Mon, Feb 4, 2013 at 7:18 AM, Joerg Roedel j...@8bytes.org wrote:
+static inline int iommu_domain_window_enable(struct iommu_domain
*domain,
+u32 wnd_nr, phys_addr_t
paddr,
+size_t size)
+{
+ return -ENODEV;
+}
+
+static inline void iommu_domain_window_disable(struct iommu_domain
*domain,
+ u32 wnd_nr)
+{
+}
+
static inline phys_addr_t iommu_iova_to_phys(struct iommu_domain
*domain,
unsigned long iova)
{
This API looks workable. The one change we need is that the size
argument in
the enable API needs to be 64 bits. Our window sizes can exceed 4GB.
Okay. So if your architecture supports sizes over 2^32 then size_t
probably is already 64bits, right?
No, on a 32-bit platform size_t would generally be 32-bits. But the PAMU
is independent of that. I think we should just make it a u64.
Okay, I will change that. Will push the updated branch once Sethi agrees
on the interface changes.
Joerg
___
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
