Re: [PATCH v4 11/23] nvme-pci: convert to using dma_map_sgtable()
On 2021-12-13 3:21 p.m., Chaitanya Kulkarni wrote: > >> static blk_status_t nvme_pci_setup_sgls(struct nvme_dev *dev, >> -struct request *req, struct nvme_rw_command *cmd, int entries) >> +struct request *req, struct nvme_rw_command *cmd) >> { >> struct nvme_iod *iod = blk_mq_rq_to_pdu(req); >> struct dma_pool *pool; >> struct nvme_sgl_desc *sg_list; >> -struct scatterlist *sg = iod->sg; >> +struct scatterlist *sg = iod->sgt.sgl; >> +int entries = iod->sgt.nents; > > I don't see use of newly added entries variable anywhere in > nvme_pci_setup_sgls(), what am I missing ? 'entries' is being moved out from the argument list of nvme_pci_setup_sgls(), so there are already uses in the function that don't show in the diff. > Also, type of entries variable should be unsigned int to match > the iod->sgt.nents. Sure, I will fix that in the next version. Thanks for the reviews! Logan ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: [PATCH v4 11/23] nvme-pci: convert to using dma_map_sgtable()
> static blk_status_t nvme_pci_setup_sgls(struct nvme_dev *dev, > - struct request *req, struct nvme_rw_command *cmd, int entries) > + struct request *req, struct nvme_rw_command *cmd) > { > struct nvme_iod *iod = blk_mq_rq_to_pdu(req); > struct dma_pool *pool; > struct nvme_sgl_desc *sg_list; > - struct scatterlist *sg = iod->sg; > + struct scatterlist *sg = iod->sgt.sgl; > + int entries = iod->sgt.nents; I don't see use of newly added entries variable anywhere in nvme_pci_setup_sgls(), what am I missing ? Also, type of entries variable should be unsigned int to match the iod->sgt.nents. > dma_addr_t sgl_dma; > int i = 0; > > @@ -848,7 +838,7 @@ static blk_status_t nvme_map_data(struct nvme_dev *dev, > struct request *req, > { > struct nvme_iod *iod = blk_mq_rq_to_pdu(req); > blk_status_t ret = BLK_STS_RESOURCE; > - int nr_mapped; > + int rc; > > if (blk_rq_nr_phys_segments(req) == 1) { > struct bio_vec bv = req_bvec(req); ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu