Re: implement generic dma_map_ops for IOMMUs v5
On Mon, May 27, 2019 at 05:38:29PM +0200, Christoph Hellwig wrote: > On Mon, May 27, 2019 at 05:37:51PM +0200, Joerg Roedel wrote: > > I applied this series to a new generic-dma-ops branch in the iommu > > tree and plan to send it upstream in the next merge window. > > Thanks! Can you push the branch out ASAP, as I'll need to pull it > into the dma-mapping tree to avoid creating nasty conflicts for the > pending rework of the DMA CMA and contigous allocators? Done, pushed this one branch. Have a lot of fun! Joerg
Re: implement generic dma_map_ops for IOMMUs v5
On Mon, May 27, 2019 at 05:37:51PM +0200, Joerg Roedel wrote: > I applied this series to a new generic-dma-ops branch in the iommu > tree and plan to send it upstream in the next merge window. Thanks! Can you push the branch out ASAP, as I'll need to pull it into the dma-mapping tree to avoid creating nasty conflicts for the pending rework of the DMA CMA and contigous allocators?
Re: implement generic dma_map_ops for IOMMUs v5
Hi Christoph, Hi Robin, On Mon, May 20, 2019 at 09:29:24AM +0200, Christoph Hellwig wrote: > I think we are finally ready for the generic dma-iommu series. I have > various DMA API changes pending, and Tom has patches ready to convert > the AMD and Intel iommu drivers over to it. I'd love to have this > in a stable branch shared between the dma-mapping and iommu trees > the day after rc2 is released. I volunteer to create the branch, > but I'm fine with it living in the iommu tree as well. Before that > Will has already said he wants to send the first patch in the series > to Linus for this merge window. First a big "THANK YOU" for working on this and getting it ready. It is an important step towards generic dma-ops for all iommu drivers, something I wished to have for years and planned to work on myself, but didn't find the time. I applied this series to a new generic-dma-ops branch in the iommu tree and plan to send it upstream in the next merge window. Thanks again, Joerg
Re: implement generic dma_map_ops for IOMMUs v6
On 23/05/2019 08:00, Christoph Hellwig wrote: Hi Robin and Joerg, I think we are finally ready for the generic dma-iommu series. I have various DMA API changes pending, and Tom has patches ready to convert the AMD and Intel iommu drivers over to it. I'd love to have this in a stable branch shared between the dma-mapping and iommu trees the day after rc2 is released. I volunteer to create the branch, but I'm fine with it living in the iommu tree as well. Yup, I'd also like to see this in -next ASAP in the hope that board farms and maybe even real users can start chewing on it. Thanks for persevering :) Robin. A git tree is also available at: git://git.infradead.org/users/hch/misc.git dma-iommu-ops.6 Gitweb: http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/dma-iommu-ops.6 Changes since v5: - rebased to latest linus tree and dropped a patch now merged - remove the now pointless __dma_iommu_mmap function - restore a cleanup from Robin that would have caused a conflict in last merge winow, but is fine now Changes since v4: - rebased to 5.2-rc1 Changes since v3: - fold the separate patch to refactor mmap bounds checking - don't warn on not finding a vm_area - improve a commit log - refactor __dma_iommu_free a little differently - remove a minor MSI map cleanup to avoid a conflict with the "Split iommu_dma_map_msi_msg" series Changes since v2: - address various review comments and include patches from Robin Changes since v1: - only include other headers in dma-iommu.h if CONFIG_DMA_IOMMU is enabled - keep using a scatterlist in iommu_dma_alloc - split out mmap/sgtable fixes and move them early in the series - updated a few commit logs ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: implement generic dma_map_ops for IOMMUs v4
On Fri, May 03, 2019 at 12:47:31PM +0100, Catalin Marinas wrote: > On Thu, May 02, 2019 at 03:22:08PM +0200, Christoph Hellwig wrote: > > can you quickly look over the arm64 parts? I'd really like to still > > get this series in for this merge window as it would conflict with > > a lot of dma-mapping work for next merge window, and we also have > > the amd and possibly intel iommu conversions to use it waiting. > > Done. They look fine to me. Ok, great. Although I have to admit I feel about uneasy about merging them for 5.2 unless Linus ends up doing an rc8. I plan to pull the prep_coherent patch into the dma-mapping tree as we'll need it as a prepation for other things as well, and then we can just have an immutable tree with the dma-iommu changes, so that it doesn't block other DMA mapping changes that will touch this code as well. > > -- > Catalin ---end quoted text--- ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: implement generic dma_map_ops for IOMMUs v4
On Thu, May 02, 2019 at 03:22:08PM +0200, Christoph Hellwig wrote: > can you quickly look over the arm64 parts? I'd really like to still > get this series in for this merge window as it would conflict with > a lot of dma-mapping work for next merge window, and we also have > the amd and possibly intel iommu conversions to use it waiting. Done. They look fine to me. -- Catalin ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: implement generic dma_map_ops for IOMMUs v4
Hi Catalin and Will, can you quickly look over the arm64 parts? I'd really like to still get this series in for this merge window as it would conflict with a lot of dma-mapping work for next merge window, and we also have the amd and possibly intel iommu conversions to use it waiting. On Tue, Apr 30, 2019 at 06:51:49AM -0400, Christoph Hellwig wrote: > Hi Robin, > > please take a look at this series, which implements a completely generic > set of dma_map_ops for IOMMU drivers. This is done by taking the > existing arm64 code, moving it to drivers/iommu and then massaging it > so that it can also work for architectures with DMA remapping. This > should help future ports to support IOMMUs more easily, and also allow > to remove various custom IOMMU dma_map_ops implementations, like Tom > was planning to for the AMD one. > > A git tree is also available at: > > git://git.infradead.org/users/hch/misc.git dma-iommu-ops.3 > > Gitweb: > > > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/dma-iommu-ops.3 > > Changes since v3: > - fold the separate patch to refactor mmap bounds checking > - don't warn on not finding a vm_area > - improve a commit log > - refactor __dma_iommu_free a little differently > - remove a minor MSI map cleanup to avoid a conflict with the >"Split iommu_dma_map_msi_msg" series > > Changes since v2: > - address various review comments and include patches from Robin > > Changes since v1: > - only include other headers in dma-iommu.h if CONFIG_DMA_IOMMU is enabled > - keep using a scatterlist in iommu_dma_alloc > - split out mmap/sgtable fixes and move them early in the series > - updated a few commit logs > ___ > iommu mailing list > iommu@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/iommu ---end quoted text--- ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: implement generic dma_map_ops for IOMMUs v3
On 22/04/2019 18:59, Christoph Hellwig wrote: Hi Robin, please take a look at this series, which implements a completely generic set of dma_map_ops for IOMMU drivers. This is done by taking the existing arm64 code, moving it to drivers/iommu and then massaging it so that it can also work for architectures with DMA remapping. This should help future ports to support IOMMUs more easily, and also allow to remove various custom IOMMU dma_map_ops implementations, like Tom was planning to for the AMD one. Modulo a few nits, I think this looks pretty much good to go, and it would certainly be good to get as much as reasonable queued soon for the sake of progress elsewhere. Catalin, Will, I think the arm64 parts are all OK but please take a look to confirm. Thanks, Robin. A git tree is also available at: git://git.infradead.org/users/hch/misc.git dma-iommu-ops.3 Gitweb: http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/dma-iommu-ops.3 Changes since v2: - address various review comments and include patches from Robin Changes since v1: - only include other headers in dma-iommu.h if CONFIG_DMA_IOMMU is enabled - keep using a scatterlist in iommu_dma_alloc - split out mmap/sgtable fixes and move them early in the series - updated a few commit logs ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: implement generic dma_map_ops for IOMMUs v2
Sorry, plese ignore this thread. This just resend the start of the dma-mapping for-next branch instead of the actual series that sits on top of it. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: implement generic dma_map_ops for IOMMUs
Any chance to get a review on this one? On Mon, Jan 14, 2019 at 10:41:40AM +0100, Christoph Hellwig wrote: > Hi Robin, > > please take a look at this series, which implements a completely generic > set of dma_map_ops for IOMMU drivers. This is done by taking the > existing arm64 code, moving it to drivers/iommu and then massaging it > so that it can also work for architectures with DMA remapping. This > should help future ports to support IOMMUs more easily, and also allow > to remove various custom IOMMU dma_map_ops implementations, like Tom > was planning to for the AMD one. > > A git tree is also available at: > > git://git.infradead.org/users/hch/misc.git dma-iommu-ops > > Gitweb: > > > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/dma-iommu-ops > ___ > iommu mailing list > iommu@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/iommu ---end quoted text--- ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
