Re: move the arm arch_dma_alloc implementation to common code
On 27/11/2018 07:37, Christoph Hellwig wrote: On Thu, Nov 15, 2018 at 12:58:04PM -0800, Robin Murphy wrote: On 2018-11-15 11:50 am, Will Deacon wrote: On Fri, Nov 09, 2018 at 08:52:38AM +0100, Christoph Hellwig wrote: Can I get a quick review from the arm64 folks? I think it should be fine there as it basically is a code move, but an additional pair or two of eyes always helps to weed out bugs. I reviewed the arm64 parts, but it would be ideal if Robin could have a look as well. Yup, from a quick skim the general shape of the whole series looks pleasing, but I've been holding off going through it in detail until I've figured out what's up with the last thing I thought I'd reviewed exhaustively... Either way I'll make some time for a proper look next week once I'm back. Did you get a chance to look over this? Sorry, it took a little longer than expected to catch up, but I'm looking at it now. Robin. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: move the arm arch_dma_alloc implementation to common code
On Thu, Nov 15, 2018 at 12:58:04PM -0800, Robin Murphy wrote: > On 2018-11-15 11:50 am, Will Deacon wrote: >> On Fri, Nov 09, 2018 at 08:52:38AM +0100, Christoph Hellwig wrote: >>> Can I get a quick review from the arm64 folks? I think it should >>> be fine there as it basically is a code move, but an additional pair >>> or two of eyes always helps to weed out bugs. >> >> I reviewed the arm64 parts, but it would be ideal if Robin could have a look >> as well. > > Yup, from a quick skim the general shape of the whole series looks > pleasing, but I've been holding off going through it in detail until I've > figured out what's up with the last thing I thought I'd reviewed > exhaustively... > > Either way I'll make some time for a proper look next week once I'm back. Did you get a chance to look over this? ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: move the arm arch_dma_alloc implementation to common code
On 2018-11-15 11:50 am, Will Deacon wrote: On Fri, Nov 09, 2018 at 08:52:38AM +0100, Christoph Hellwig wrote: Can I get a quick review from the arm64 folks? I think it should be fine there as it basically is a code move, but an additional pair or two of eyes always helps to weed out bugs. I reviewed the arm64 parts, but it would be ideal if Robin could have a look as well. Yup, from a quick skim the general shape of the whole series looks pleasing, but I've been holding off going through it in detail until I've figured out what's up with the last thing I thought I'd reviewed exhaustively... Either way I'll make some time for a proper look next week once I'm back. Robin. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: move the arm arch_dma_alloc implementation to common code
On Fri, Nov 09, 2018 at 08:52:38AM +0100, Christoph Hellwig wrote: > Can I get a quick review from the arm64 folks? I think it should > be fine there as it basically is a code move, but an additional pair > or two of eyes always helps to weed out bugs. I reviewed the arm64 parts, but it would be ideal if Robin could have a look as well. Will ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
Re: move the arm arch_dma_alloc implementation to common code
Can I get a quick review from the arm64 folks? I think it should be fine there as it basically is a code move, but an additional pair or two of eyes always helps to weed out bugs. On Mon, Nov 05, 2018 at 01:19:22PM +0100, Christoph Hellwig wrote: > Hi all, > > this series moves the existing arm64 implementation of arch_dma_alloc and > arch_dma_free to common code given that it is not arm64-specific, and > then also uses it for csky. Given how many architectures remap memory > for the DMA coherent implementation it should be usable for many more, > and the new cache flushing hook and the generic atomic pool are also > enablers for implementing the IOMMU API dma ops in common code in a > follow on series. > ___ > iommu mailing list > iommu@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/iommu ---end quoted text--- ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
move the arm arch_dma_alloc implementation to common code
Hi all, this series moves the existing arm64 implementation of arch_dma_alloc and arch_dma_free to common code given that it is not arm64-specific, and then also uses it for csky. Given how many architectures remap memory for the DMA coherent implementation it should be usable for many more, and the new cache flushing hook and the generic atomic pool are also enablers for implementing the IOMMU API dma ops in common code in a follow on series. ___ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
