Re: [ipxe-devel] [ipxe/ipxe] Fixed bug in intel 10M/100M/1G NIC driver. (#52)
This was cleaned up into commit https://github.com/ipxe/ipxe/commit/2d79b20f2 -- Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/52#issuecomment-1036448623 You are receiving this because you commented. Message ID: ___ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/listinfo/ipxe-devel
Re: [ipxe-devel] [ipxe/ipxe] Fixed bug in intel 10M/100M/1G NIC driver. (#52)
Closed #52. -- Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/52#event-6052904769 You are receiving this because you commented. Message ID: ___ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/listinfo/ipxe-devel
Re: [ipxe-devel] [ipxe/ipxe] Fixed bug in intel 10M/100M/1G NIC driver. (#52)
Is this still an issue in current master? -- Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/52#issuecomment-1036405097 You are receiving this because you commented. Message ID: ___ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/listinfo/ipxe-devel
Re: [ipxe-devel] [ipxe/ipxe] Fixed bug in intel 10M/100M/1G NIC driver. (#52)
@olivernie pushed 1 commit. 5425c7d59e58c74e7834cf83c1c16d9a2da8901d Merge branch 'master' into master -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/ipxe/ipxe/pull/52/files/2de4c4441a06c94a0dbbb6366167502c5a602080..5425c7d59e58c74e7834cf83c1c16d9a2da8901d ___ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/listinfo.cgi/ipxe-devel
Re: [ipxe-devel] [ipxe/ipxe] Fixed bug in intel 10M/100M/1G NIC driver. (#52)
@robinsmidsrod I got another board which has two NICs. Net0 is using intel 82567lm, net1 is using intel 82576eb. My patch is on 82576eb. Following are the results on loopback tests. Enabled debugging level 3 for intel and netdevice. The failed case shows 1 packet transmitted but nothing received, even packet with error. Since I am not sure 82567lm is a known working NIC or not, regarding to intel driver in IPXE, I can't tell the problem is on which side. I have no supported USB3 NICs in my hand to do further test. - Loopback --- lotest net0 net1 --- Pass; lotest net1 net0 --- Pass - High-MTU loopback --- lotest -m 1504 net0 net1 --- Fail; loest -m 1504 net1 net0 --- Pass - VLAN loopback --- lotest net0-123 net1-123 --- Pass; loest net1-123 net0-123 --- Pass --- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/52#issuecomment-216301534___ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/listinfo.cgi/ipxe-devel
Re: [ipxe-devel] [ipxe/ipxe] Fixed bug in intel 10M/100M/1G NIC driver. (#52)
@olivernie Thanks for the test feedback. The loopback tests are most of the time tested with two NICs in the same system, with one being the one under test and the other one a known working NIC. This ensures that there is no packet drop in the receive and transmit data paths and that VLAN features work as intended. If it's a laptop and it's impossible to attach another NIC then it's quite hard to test that, but doable if you have one of the supported USB3 NICs. --- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/52#issuecomment-216119831___ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/listinfo.cgi/ipxe-devel
Re: [ipxe-devel] [ipxe/ipxe] Fixed bug in intel 10M/100M/1G NIC driver. (#52)
OK. Here are results of [ipxe.org/dev/driver](ipxe.org/dev/driver) - Link detection--- Pass - Basic DHCP --- Pass - Close and reopen --- Pass - Large file transfer correctness --- Pass - Large file transfer speed--- 4.6s on 512MB - Link interruption --- Transfer finished with no error - Loopback --- Not Applicable since I have only one port on intel 82576 - High-MTU loopback --- Not Applicable - VLAN loopback --- Not Applicable --- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/52#issuecomment-215895475___ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/listinfo.cgi/ipxe-devel
Re: [ipxe-devel] [ipxe/ipxe] Fixed bug in intel 10M/100M/1G NIC driver. (#52)
Ok. I will take a look at ipxe.org/dev/driver to see how to run those tests. Update the result later. --- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/52#issuecomment-215482990___ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/listinfo.cgi/ipxe-devel
Re: [ipxe-devel] [ipxe/ipxe] Fixed bug in intel 10M/100M/1G NIC driver. (#52)
It would be beneficial if you provide the results from the tests located at ipxe.org/dev/driver both with and without the provided patch, so that it is clear what this patch fixes. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/52#issuecomment-215170505___ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/listinfo.cgi/ipxe-devel
Re: [ipxe-devel] [ipxe/ipxe] Fixed bug in intel 10M/100M/1G NIC driver. (#52)
Yes. In my board, intel 82576EB is connected to BCM8359(copper on board). The builtin PXE in NIC can DHCP and load the IPXE binary from server. But IPXE can't even the ifstat shows link is up. This patch fix this bug. IPXE could DHCP again and chainload the other image. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/52#issuecomment-215117466___ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/listinfo.cgi/ipxe-devel
Re: [ipxe-devel] [ipxe/ipxe] Fixed bug in intel 10M/100M/1G NIC driver. (#52)
Does this fix an actual problem, or is it just for datasheet compliance? From what I can remember, we try to avoid flags on new drivers unless absolutely required (usually for strange hardware issues/bugs). --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/52#issuecomment-214988808___ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/listinfo.cgi/ipxe-devel
[ipxe-devel] [ipxe/ipxe] Fixed bug in intel 10M/100M/1G NIC driver. (#52)
Bit CTRL_ASDE is reserved and must be set to 0b according intel 82576EB datasheet. You can view, comment on, or merge this pull request online at: https://github.com/ipxe/ipxe/pull/52 -- Commit Summary -- * Fixed bug in intel 10M/100M/1G NIC driver. bit CTRL_ASDE is reserved and must be set to 0b according intel 82576EB datasheet. -- File Changes -- M src/drivers/net/intel.c (9) M src/drivers/net/intel.h (2) -- Patch Links -- https://github.com/ipxe/ipxe/pull/52.patch https://github.com/ipxe/ipxe/pull/52.diff --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/ipxe/ipxe/pull/52 ___ ipxe-devel mailing list ipxe-devel@lists.ipxe.org https://lists.ipxe.org/mailman/listinfo.cgi/ipxe-devel