[jira] [Commented] (ARTEMIS-292) isSameHost doesn't work

2015-11-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987235#comment-14987235
 ] 

ASF GitHub Bot commented on ARTEMIS-292:


GitHub user andytaylor opened a pull request:

https://github.com/apache/activemq-artemis/pull/229

ARTEMIS-292 - fix isSameHost on TransportConfiguration

Ive renamed the current isSameHost method to isSameparams as thats what it 
checked and added a new method for isSameHost that cjecks the appropriate 
params for the connector. Ive changed ClientSessionFactoryImp to use this to 
correct the behaviour.

https://issues.apache.org/jira/browse/ARTEMIS-292

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andytaylor/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/229.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #229


commit 3d80133756701fc432fbe4c0a283ca214693e604
Author: Andy Taylor 
Date:   2015-11-03T10:53:07Z

ARTEMIS-292 - fix isSameHost on TransportConfiguration

Ive renamed the current isSameHost method to isSameparams as thats what it 
checked and added a new method for isSameHost that cjecks the appropriate 
params for the connector. Ive changed ClientSessionFactoryImp to use this to 
correct the behaviour.

https://issues.apache.org/jira/browse/ARTEMIS-292




> isSameHost doesn't work
> ---
>
> Key: ARTEMIS-292
> URL: https://issues.apache.org/jira/browse/ARTEMIS-292
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 1.1.0
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> TransportConfiguration.isSameHost(...) does a comparison on all the params 
> which is incorrect for some scenarios. It needs to check the host/port or 
> serverID but only be changed for the calls that needs  it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ARTEMIS-292) isSameHost doesn't work

2015-11-03 Thread Andy Taylor (JIRA) 
Andy Taylor created ARTEMIS-292:
---

 Summary: isSameHost doesn't work
 Key: ARTEMIS-292
 URL: https://issues.apache.org/jira/browse/ARTEMIS-292
 Project: ActiveMQ Artemis
  Issue Type: Bug
  Components: Broker
Affects Versions: 1.1.0
Reporter: Andy Taylor
Assignee: Andy Taylor


TransportConfiguration.isSameHost(...) does a comparison on all the params 
which is incorrect for some scenarios. It needs to check the host/port or 
serverID but only be changed for the calls that needs  it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-292) isSameHost doesn't work

2015-11-03 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987463#comment-14987463
 ] 

ASF subversion and git services commented on ARTEMIS-292:
-

Commit b73e61ac528443b7978a9c70e5b76a1a0b8aeefc in activemq-artemis's branch 
refs/heads/master from [~andytaylor]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=b73e61a ]

ARTEMIS-292 - fix isSameHost on TransportConfiguration

Ive renamed the current isSameHost method to isSameparams as thats what it 
checked and added a new method for isSameHost that checks the appropriate 
params for the connector. Ive changed ClientSessionFactoryImp to use this to 
correct the behaviour.

https://issues.apache.org/jira/browse/ARTEMIS-292


> isSameHost doesn't work
> ---
>
> Key: ARTEMIS-292
> URL: https://issues.apache.org/jira/browse/ARTEMIS-292
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 1.1.0
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> TransportConfiguration.isSameHost(...) does a comparison on all the params 
> which is incorrect for some scenarios. It needs to check the host/port or 
> serverID but only be changed for the calls that needs  it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-292) isSameHost doesn't work

2015-11-03 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14987464#comment-14987464
 ] 

ASF subversion and git services commented on ARTEMIS-292:
-

Commit b73e61ac528443b7978a9c70e5b76a1a0b8aeefc in activemq-artemis's branch 
refs/heads/master from [~andytaylor]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=b73e61a ]

ARTEMIS-292 - fix isSameHost on TransportConfiguration

Ive renamed the current isSameHost method to isSameparams as thats what it 
checked and added a new method for isSameHost that checks the appropriate 
params for the connector. Ive changed ClientSessionFactoryImp to use this to 
correct the behaviour.

https://issues.apache.org/jira/browse/ARTEMIS-292


> isSameHost doesn't work
> ---
>
> Key: ARTEMIS-292
> URL: https://issues.apache.org/jira/browse/ARTEMIS-292
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 1.1.0
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>
> TransportConfiguration.isSameHost(...) does a comparison on all the params 
> which is incorrect for some scenarios. It needs to check the host/port or 
> serverID but only be changed for the calls that needs  it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-293) Rebalance JCA RA inflow connections when cluster topology changes

2015-11-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14988039#comment-14988039
 ] 

ASF GitHub Bot commented on ARTEMIS-293:


GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/230

ARTEMIS-293 rebalance inflow on topology change



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-293

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/230.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #230


commit 538fc99594ea748463c0693216c3e3ecc470375c
Author: jbertram 
Date:   2015-10-30T16:20:06Z

ARTEMIS-293 rebalance inflow on topology change




> Rebalance JCA RA inflow connections when cluster topology changes
> -
>
> Key: ARTEMIS-293
> URL: https://issues.apache.org/jira/browse/ARTEMIS-293
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>Affects Versions: 1.1.0
>Reporter: Justin Bertram
>Assignee: Justin Bertram
> Fix For: 1.1.1
>
>
> The inflow connections for an MDB (or other JCA inflow component) are 
> typically long-lived. This is normally a good thing. However, when MDBs are 
> consuming messages from a remote cluster and the topology of that cluster 
> changes (i.e. a node is added to increase capacity or removed for 
> maintenance) the inflow connections don't react in an efficient way. The RA 
> should detect topology changes and re-balance the inflow connections across 
> the new topology.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (ARTEMIS-293) Rebalance JCA RA inflow connections when cluster topology changes

2015-11-03 Thread Justin Bertram (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram resolved ARTEMIS-293.

Resolution: Fixed

> Rebalance JCA RA inflow connections when cluster topology changes
> -
>
> Key: ARTEMIS-293
> URL: https://issues.apache.org/jira/browse/ARTEMIS-293
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>Affects Versions: 1.1.0
>Reporter: Justin Bertram
>Assignee: Justin Bertram
> Fix For: 1.1.1
>
>
> The inflow connections for an MDB (or other JCA inflow component) are 
> typically long-lived. This is normally a good thing. However, when MDBs are 
> consuming messages from a remote cluster and the topology of that cluster 
> changes (i.e. a node is added to increase capacity or removed for 
> maintenance) the inflow connections don't react in an efficient way. The RA 
> should detect topology changes and re-balance the inflow connections across 
> the new topology.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ARTEMIS-293) Rebalance JCA RA inflow connections when cluster topology changes

2015-11-03 Thread Justin Bertram (JIRA) 
Justin Bertram created ARTEMIS-293:
--

 Summary: Rebalance JCA RA inflow connections when cluster topology 
changes
 Key: ARTEMIS-293
 URL: https://issues.apache.org/jira/browse/ARTEMIS-293
 Project: ActiveMQ Artemis
  Issue Type: New Feature
Affects Versions: 1.1.0
Reporter: Justin Bertram
Assignee: Justin Bertram
 Fix For: 1.1.1


The inflow connections for an MDB (or other JCA inflow component) are typically 
long-lived. This is normally a good thing. However, when MDBs are consuming 
messages from a remote cluster and the topology of that cluster changes (i.e. a 
node is added to increase capacity or removed for maintenance) the inflow 
connections don't react in an efficient way. The RA should detect topology 
changes and re-balance the inflow connections across the new topology.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)