[jira] [Created] (ARTEMIS-474) replication fails with colocated topologies

2016-04-07 Thread clebert suconic (JIRA) 
clebert suconic created ARTEMIS-474:
---

 Summary: replication fails with colocated topologies
 Key: ARTEMIS-474
 URL: https://issues.apache.org/jira/browse/ARTEMIS-474
 Project: ActiveMQ Artemis
  Issue Type: Bug
Affects Versions: 1.2.0
Reporter: clebert suconic
Assignee: clebert suconic
 Fix For: 1.3.0






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (AMQ-2748) Jboss Adapter Configuration : connection-factory datasource does not overload ra.xml

2016-04-07 Thread Timothy Bish (JIRA) 

 [ 
https://issues.apache.org/jira/browse/AMQ-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothy Bish closed AMQ-2748.
-
Resolution: Incomplete

> Jboss Adapter Configuration : connection-factory datasource does not overload 
> ra.xml
> 
>
> Key: AMQ-2748
> URL: https://issues.apache.org/jira/browse/AMQ-2748
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Connector
>Affects Versions: 5.3.2
>Reporter: Marc Schöchlin
> Fix For: NEEDS_REVIEW
>
>
> I defined a connection-facory datasource in jboss 5.1
> {code}
> 
>  PUBLIC "-//JBoss//DTD JBOSS JCA Config 1.5//EN"
> "http://www.jboss.org/j2ee/dtd/jboss-ds_1_5.dtd;>
> 
>
>   activemq/QueueConnectionFactory
>   
>   
>   activemq-rar-5.3.2.rar
>   
> javax.jms.QueueConnectionFactory
>   tcp://foo.bar.org:61616
>   
>   1
>   20
>   3
>   3
>
>  ...
>  ...
> 
> {code}
> My message driven beans are using this factory. The default 
> "tcp://localhost:61616", defined in activemq-ra-5.3.2.rar/META-INF/ra.xml, is 
> not overloaded.
> {code}
> 
> 
> org.apache.activemq.ra.ActiveMQResourceAdapter
> 
> 
>   The URL to the ActiveMQ server that you want this connection to 
> connect to.  If using
>   an embedded broker, this value should be 'vm://localhost'.
> 
> ServerUrl
> java.lang.String
> tcp://localhost:61616
> {code}
> My application never connects to "tcp://foo.bar.org:61616" until i configure 
> this in activemq-ra-5.3.2.rar/META-INF/ra.xml.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (AMQ-6142) ActiveMQBytesMessage decompress throws DataFormatException incorrect header check

2016-04-07 Thread Gary Tully (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMQ-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230472#comment-15230472
 ] 

Gary Tully edited comment on AMQ-6142 at 4/7/16 6:35 PM:
-

[~cshannon] I think rolling back the sync is best, then thinking of mutation 
being ok on your own copy which implies maybe doing more copies and those not 
sharing mutable state. Client side there is typically a copy per consumer. 
Broker side there is a single copy of the message at the moment and the 
reduceMemoryFootPrint policy can control whacking the duplicate state on 
send/store for a queue. concurrentStoreAndDispatch muddies that a bit.



was (Author: gtully):
[~cshannon] I think rolling back the sync is best, then thinking of mutation 
being ok on your own copy which implies maybe doing more copies and those not 
sharing mutable state. Client side there is typically a copy per consumer. 
Broker side there is a single copy of the message at the moment and the 
reduceMemoryFootPrint policy can control whacking the duplicate state on 
send/store for a queue. concurrentStoreAndDispatch muddies that a bit.
For topics, maybe when the message is invm, we force a marshall/store on the 
send and can be done with a single shared message. Because each consumer may or 
may not want marshalling it is a little tricky, but it is only vm consumers 
that would not marshall.

> ActiveMQBytesMessage decompress throws DataFormatException incorrect header 
> check
> -
>
> Key: AMQ-6142
> URL: https://issues.apache.org/jira/browse/AMQ-6142
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 5.10.2, 5.12.1, 5.11.3, 5.13.0
>Reporter: Claudio Tagliola
>Assignee: Christopher L. Shannon
> Fix For: 5.13.1, 5.14.0
>
> Attachments: Client.java, MessageListener.java, Server.java, 
> amq-6142.diff, pom.xml
>
>
> In our environment we use an embedded broker. On one topic where compression 
> is enabled, the server is also listening in on the messages. From ActiveMQ 
> 5.10.0 up to 5.13.0, we encounter DataFormatException: incorrect header check 
> exceptions on the tcp clients due to corruption of the payload. Attached are 
> a test server and client. At some point, the client will exit due to 
> mentioned exception. Increase chances by running multiple clients. This 
> scenario works with 5.8.0 and 5.9.1.
> If the server has multiple consumers on the same topic, they will encounter 
> corruption as well, but this has other side-effects.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-468) Fix openwire redelivery related regressions under integration-tests

2016-04-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230719#comment-15230719
 ] 

ASF GitHub Bot commented on ARTEMIS-468:


Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/440


> Fix openwire redelivery related regressions under integration-tests
> ---
>
> Key: ARTEMIS-468
> URL: https://issues.apache.org/jira/browse/ARTEMIS-468
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: OpenWire
>Affects Versions: 1.2.0
>Reporter: Howard Gao
>Assignee: Howard Gao
> Fix For: 1.3.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-468) Fix openwire redelivery related regressions under integration-tests

2016-04-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230721#comment-15230721
 ] 

ASF GitHub Bot commented on ARTEMIS-468:


Github user clebertsuconic commented on the pull request:

https://github.com/apache/activemq-artemis/pull/440#issuecomment-207029891
  
@gaohoward  I have merged with my commit ammending this. if you could take 
a look please?

if you need to amend the rule at least we have a single place to do that 
now.


> Fix openwire redelivery related regressions under integration-tests
> ---
>
> Key: ARTEMIS-468
> URL: https://issues.apache.org/jira/browse/ARTEMIS-468
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: OpenWire
>Affects Versions: 1.2.0
>Reporter: Howard Gao
>Assignee: Howard Gao
> Fix For: 1.3.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-468) Fix openwire redelivery related regressions under integration-tests

2016-04-07 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230717#comment-15230717
 ] 

ASF subversion and git services commented on ARTEMIS-468:
-

Commit 50eac7c824e586aa858fb1f56676feffd4be7523 in activemq-artemis's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=50eac7c ]

ARTEMIS-468 Amendments to how redelivery count is handled on openwire


> Fix openwire redelivery related regressions under integration-tests
> ---
>
> Key: ARTEMIS-468
> URL: https://issues.apache.org/jira/browse/ARTEMIS-468
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: OpenWire
>Affects Versions: 1.2.0
>Reporter: Howard Gao
>Assignee: Howard Gao
> Fix For: 1.3.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-468) Fix openwire redelivery related regressions under integration-tests

2016-04-07 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230716#comment-15230716
 ] 

ASF subversion and git services commented on ARTEMIS-468:
-

Commit 8a998ad805e88ef2bf4cdb01c19c1d0ba1217a30 in activemq-artemis's branch 
refs/heads/master from [~gaohoward]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=8a998ad ]

ARTEMIS-468 Fix openwire redelivery related regressions under integration-tests


> Fix openwire redelivery related regressions under integration-tests
> ---
>
> Key: ARTEMIS-468
> URL: https://issues.apache.org/jira/browse/ARTEMIS-468
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: OpenWire
>Affects Versions: 1.2.0
>Reporter: Howard Gao
>Assignee: Howard Gao
> Fix For: 1.3.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-468) Fix openwire redelivery related regressions under integration-tests

2016-04-07 Thread clebert suconic (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230623#comment-15230623
 ] 

clebert suconic commented on ARTEMIS-468:
-

What tests were being fixed?

> Fix openwire redelivery related regressions under integration-tests
> ---
>
> Key: ARTEMIS-468
> URL: https://issues.apache.org/jira/browse/ARTEMIS-468
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: OpenWire
>Affects Versions: 1.2.0
>Reporter: Howard Gao
>Assignee: Howard Gao
> Fix For: 1.3.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMQ-6142) ActiveMQBytesMessage decompress throws DataFormatException incorrect header check

2016-04-07 Thread Gary Tully (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMQ-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230472#comment-15230472
 ] 

Gary Tully commented on AMQ-6142:
-

[~cshannon] I think rolling back the sync is best, then thinking of mutation 
being ok on your own copy which implies maybe doing more copies and those not 
sharing mutable state. Client side there is typically a copy per consumer. 
Broker side there is a single copy of the message at the moment and the 
reduceMemoryFootPrint policy can control whacking the duplicate state on 
send/store for a queue. concurrentStoreAndDispatch muddies that a bit.
For topics, maybe when the message is invm, we force a marshall/store on the 
send and can be done with a single shared message. Because each consumer may or 
may not want marshalling it is a little tricky, but it is only vm consumers 
that would not marshall.

> ActiveMQBytesMessage decompress throws DataFormatException incorrect header 
> check
> -
>
> Key: AMQ-6142
> URL: https://issues.apache.org/jira/browse/AMQ-6142
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 5.10.2, 5.12.1, 5.11.3, 5.13.0
>Reporter: Claudio Tagliola
>Assignee: Christopher L. Shannon
> Fix For: 5.13.1, 5.14.0
>
> Attachments: Client.java, MessageListener.java, Server.java, 
> amq-6142.diff, pom.xml
>
>
> In our environment we use an embedded broker. On one topic where compression 
> is enabled, the server is also listening in on the messages. From ActiveMQ 
> 5.10.0 up to 5.13.0, we encounter DataFormatException: incorrect header check 
> exceptions on the tcp clients due to corruption of the payload. Attached are 
> a test server and client. At some point, the client will exit due to 
> mentioned exception. Increase chances by running multiple clients. This 
> scenario works with 5.8.0 and 5.9.1.
> If the server has multiple consumers on the same topic, they will encounter 
> corruption as well, but this has other side-effects.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-468) Fix openwire redelivery related regressions under integration-tests

2016-04-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230465#comment-15230465
 ] 

ASF GitHub Bot commented on ARTEMIS-468:


Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/440#discussion_r58897288
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQConsumer.java
 ---
@@ -303,6 +307,22 @@ public void setPrefetchSize(int prefetchSize) {
   }
}
 
+   @Override
+   public void updateForCanceledRef(MessageReference ref) {
+  long seqId = ref.getMessage().getMessageID();
+  long lastDelSeqId = info.getLastDeliveredSequenceId();
+  ServerMessage coreMessage = ref.getMessage();
+  int redeliveryCounter = 
coreMessage.getIntProperty(OpenWireMessageConverter.AMQ_MSG_REDELIVER_COUNTER);
+  if (openwireDestination.isTopic()) {
+ redeliveryCounter++;
+ 
coreMessage.putIntProperty(OpenWireMessageConverter.AMQ_MSG_REDELIVER_COUNTER, 
redeliveryCounter);
--- End diff --

This is wrong anyways Howard, The same message could be delivered to 
another Queue (another topic for instance).

DeliveryCount is a property of the MessageReference, not message.


> Fix openwire redelivery related regressions under integration-tests
> ---
>
> Key: ARTEMIS-468
> URL: https://issues.apache.org/jira/browse/ARTEMIS-468
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: OpenWire
>Affects Versions: 1.2.0
>Reporter: Howard Gao
>Assignee: Howard Gao
> Fix For: 1.3.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-471) Potential NPE when sending journal file during replication

2016-04-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230426#comment-15230426
 ] 

ASF GitHub Bot commented on ARTEMIS-471:


Github user jbertram closed the pull request at:

https://github.com/apache/activemq-artemis/pull/441


> Potential NPE when sending journal file during replication
> --
>
> Key: ARTEMIS-471
> URL: https://issues.apache.org/jira/browse/ARTEMIS-471
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 1.2.0
>Reporter: Justin Bertram
>Assignee: Justin Bertram
> Fix For: 1.3.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-468) Fix openwire redelivery related regressions under integration-tests

2016-04-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230372#comment-15230372
 ] 

ASF GitHub Bot commented on ARTEMIS-468:


Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/440#discussion_r58887712
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ConsumerListener.java
 ---
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.core.server;
+
+/**
+ */
--- End diff --

I don't like this...

We have the SessionCallback to support protocol specific things.

the protocolData should be accessed by Protocol specific classes only only. 
We shouldn't be doing any sort of weird conversions here. 

I'm trying to keep the implementation clean and easy to understand.

Add a method on SessionCallback:

canceledDelivery(ServerConsumer, MessageReference, boolean failed);

And simply call:

callback.canceledDelivery(this, ref, failed) from ServerConsumer where you 
were calling ConsumerListener,


And remove this interface please.



> Fix openwire redelivery related regressions under integration-tests
> ---
>
> Key: ARTEMIS-468
> URL: https://issues.apache.org/jira/browse/ARTEMIS-468
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: OpenWire
>Affects Versions: 1.2.0
>Reporter: Howard Gao
>Assignee: Howard Gao
> Fix For: 1.3.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-467) Potential NPE in JMSServerManagerImpl#shutdownConnectionFactory

2016-04-07 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230351#comment-15230351
 ] 

ASF subversion and git services commented on ARTEMIS-467:
-

Commit dbf0eced4b451a59ac0cc3ccc2155d99fbae42ce in activemq-artemis's branch 
refs/heads/master from [~jbertram]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=dbf0ece ]

ARTEMIS-467 Potential NPE


> Potential NPE in JMSServerManagerImpl#shutdownConnectionFactory
> ---
>
> Key: ARTEMIS-467
> URL: https://issues.apache.org/jira/browse/ARTEMIS-467
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
> Fix For: 1.3.0
>
>
> I saw an NPE here on some local tests I was running.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-467) Potential NPE in JMSServerManagerImpl#shutdownConnectionFactory

2016-04-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230353#comment-15230353
 ] 

ASF GitHub Bot commented on ARTEMIS-467:


Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/439


> Potential NPE in JMSServerManagerImpl#shutdownConnectionFactory
> ---
>
> Key: ARTEMIS-467
> URL: https://issues.apache.org/jira/browse/ARTEMIS-467
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
> Fix For: 1.3.0
>
>
> I saw an NPE here on some local tests I was running.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMQ-6142) ActiveMQBytesMessage decompress throws DataFormatException incorrect header check

2016-04-07 Thread Gary Tully (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMQ-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230280#comment-15230280
 ] 

Gary Tully commented on AMQ-6142:
-

there is some more context in https://issues.apache.org/jira/browse/AMQ-2103

> ActiveMQBytesMessage decompress throws DataFormatException incorrect header 
> check
> -
>
> Key: AMQ-6142
> URL: https://issues.apache.org/jira/browse/AMQ-6142
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 5.10.2, 5.12.1, 5.11.3, 5.13.0
>Reporter: Claudio Tagliola
>Assignee: Christopher L. Shannon
> Fix For: 5.13.1, 5.14.0
>
> Attachments: Client.java, MessageListener.java, Server.java, 
> amq-6142.diff, pom.xml
>
>
> In our environment we use an embedded broker. On one topic where compression 
> is enabled, the server is also listening in on the messages. From ActiveMQ 
> 5.10.0 up to 5.13.0, we encounter DataFormatException: incorrect header check 
> exceptions on the tcp clients due to corruption of the payload. Attached are 
> a test server and client. At some point, the client will exit due to 
> mentioned exception. Increase chances by running multiple clients. This 
> scenario works with 5.8.0 and 5.9.1.
> If the server has multiple consumers on the same topic, they will encounter 
> corruption as well, but this has other side-effects.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (AMQ-6229) java.io.EOFException from org.apache.activemq.transport.tcp.TcpTransport

2016-04-07 Thread Timothy Bish (JIRA) 

 [ 
https://issues.apache.org/jira/browse/AMQ-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothy Bish closed AMQ-6229.
-
Resolution: Cannot Reproduce

This is expected behaviour when the connection drops unexpectedly.  I wouldn't 
classify this as a bug without some proof otherwise since in general these 
errors are trying to tell you that something is not right.  

> java.io.EOFException from org.apache.activemq.transport.tcp.TcpTransport
> 
>
> Key: AMQ-6229
> URL: https://issues.apache.org/jira/browse/AMQ-6229
> Project: ActiveMQ
>  Issue Type: Bug
>Affects Versions: 5.13.0
>Reporter: Henrik
>Priority: Minor
>
> We get the following in a two-server activemq setup, a couple of times every 
> minute:
> {code}
> [ERROR] [2016-04-06T09:06:24,748] [ActiveMQ Transport: 
> tcp:///xxx.yy.86.186:46768@7250] java.io.EOFException  [ErrorStreamLogger]
> [ERROR] [2016-04-06T09:06:24,748] [ActiveMQ Transport: 
> tcp:///xxx.yy.86.186:46768@7250] at 
> java.io.DataInputStream.readInt(DataInputStream.java:392)  [ErrorStreamLogger]
> [ERROR] [2016-04-06T09:06:24,749] [ActiveMQ Transport: 
> tcp:///xxx.yy.86.186:46768@7250] at 
> org.apache.activemq.openwire.OpenWireFormat.unmarshal(OpenWireFormat.java:267)
>   [ErrorStreamLogger]
> [ERROR] [2016-04-06T09:06:24,749] [ActiveMQ Transport: 
> tcp:///152.90.86.186:46768@7250] at 
> org.apache.activemq.transport.tcp.TcpTransport.readCommand(TcpTransport.java:240)
>   [ErrorStreamLogger]
> [ERROR] [2016-04-06T09:06:24,749] [ActiveMQ Transport: 
> tcp:///xxx.yy.86.186:46768@7250] at 
> org.apache.activemq.transport.tcp.TcpTransport.doRun(TcpTransport.java:232)  
> [ErrorStreamLogger]
> [ERROR] [2016-04-06T09:06:24,749] [ActiveMQ Transport: 
> tcp:///xxx.yy.86.186:46768@7250] at 
> org.apache.activemq.transport.tcp.TcpTransport.run(TcpTransport.java:215)  
> [ErrorStreamLogger]
> [ERROR] [2016-04-06T09:06:24,749] [ActiveMQ Transport: 
> tcp:///xxx.yy.86.186:46768@7250] at 
> java.lang.Thread.run(Thread.java:745)  [ErrorStreamLogger]
> {code}
> A similar issue is described in AMQ-2730, but I can't see a solution there.  
> ActiveMQ is run in a tomcat instance with {{-Xmx1536m -Xms1536m}}, so memory 
> usage should be OK.
> The setup seems to work fine regardless of the exceptions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (AMQ-6229) java.io.EOFException from org.apache.activemq.transport.tcp.TcpTransport

2016-04-07 Thread Henrik (JIRA) 

[ 
https://issues.apache.org/jira/browse/AMQ-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230041#comment-15230041
 ] 

Henrik commented on AMQ-6229:
-

Everything seems to work as it should.  I guess I need to put some debugging 
effort into this...

> java.io.EOFException from org.apache.activemq.transport.tcp.TcpTransport
> 
>
> Key: AMQ-6229
> URL: https://issues.apache.org/jira/browse/AMQ-6229
> Project: ActiveMQ
>  Issue Type: Bug
>Affects Versions: 5.13.0
>Reporter: Henrik
>Priority: Minor
>
> We get the following in a two-server activemq setup, a couple of times every 
> minute:
> {code}
> [ERROR] [2016-04-06T09:06:24,748] [ActiveMQ Transport: 
> tcp:///xxx.yy.86.186:46768@7250] java.io.EOFException  [ErrorStreamLogger]
> [ERROR] [2016-04-06T09:06:24,748] [ActiveMQ Transport: 
> tcp:///xxx.yy.86.186:46768@7250] at 
> java.io.DataInputStream.readInt(DataInputStream.java:392)  [ErrorStreamLogger]
> [ERROR] [2016-04-06T09:06:24,749] [ActiveMQ Transport: 
> tcp:///xxx.yy.86.186:46768@7250] at 
> org.apache.activemq.openwire.OpenWireFormat.unmarshal(OpenWireFormat.java:267)
>   [ErrorStreamLogger]
> [ERROR] [2016-04-06T09:06:24,749] [ActiveMQ Transport: 
> tcp:///152.90.86.186:46768@7250] at 
> org.apache.activemq.transport.tcp.TcpTransport.readCommand(TcpTransport.java:240)
>   [ErrorStreamLogger]
> [ERROR] [2016-04-06T09:06:24,749] [ActiveMQ Transport: 
> tcp:///xxx.yy.86.186:46768@7250] at 
> org.apache.activemq.transport.tcp.TcpTransport.doRun(TcpTransport.java:232)  
> [ErrorStreamLogger]
> [ERROR] [2016-04-06T09:06:24,749] [ActiveMQ Transport: 
> tcp:///xxx.yy.86.186:46768@7250] at 
> org.apache.activemq.transport.tcp.TcpTransport.run(TcpTransport.java:215)  
> [ErrorStreamLogger]
> [ERROR] [2016-04-06T09:06:24,749] [ActiveMQ Transport: 
> tcp:///xxx.yy.86.186:46768@7250] at 
> java.lang.Thread.run(Thread.java:745)  [ErrorStreamLogger]
> {code}
> A similar issue is described in AMQ-2730, but I can't see a solution there.  
> ActiveMQ is run in a tomcat instance with {{-Xmx1536m -Xms1536m}}, so memory 
> usage should be OK.
> The setup seems to work fine regardless of the exceptions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ARTEMIS-473) Activate server with most up-to-date journal from live/backup pair

2016-04-07 Thread Miroslav Novak (JIRA) 
Miroslav Novak created ARTEMIS-473:
--

 Summary: Activate server with most up-to-date journal from 
live/backup pair
 Key: ARTEMIS-473
 URL: https://issues.apache.org/jira/browse/ARTEMIS-473
 Project: ActiveMQ Artemis
  Issue Type: New Feature
  Components: Broker
Affects Versions: 1.2.0
Reporter: Miroslav Novak
Priority: Critical


if there are 2 live/backup pairs with replicated journal in colocated topology 
Artemis1(L1/B2) <-> Artemis2(L2/B1) then there is no easy way to start them if 
they're all shutdown.

Problem is that there is no way how to start the servers with most up-to-date 
journal. If administrator shutdown servers in sequence Artemis1 and then 
Artemis 2. Then Artemis 2 has the most up-to-date journals because backup B1 on 
server2 activated.
Then If administrator decides to start Artemis2 then live L2 activates and 
backup B1 waits for live L1 in Artemis 1 to start. But once L1 starts then L1 
replicates its own "old" journal to B1.

So L1 started with bad old journal. I would suggest that L1 and B1 compares 
theirs journals and figure out which one is more up-to-date. Then server with 
more up-to-date journal activates.

In scenario described above it would be backup B1 which will activate first. 
Live L1 will synchronize its own journal from B1 and then failback happens.





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-472) AMQ222137 warning does not display the cause of the problem

2016-04-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229966#comment-15229966
 ] 

ASF GitHub Bot commented on ARTEMIS-472:


Github user jmesnil commented on the pull request:

https://github.com/apache/activemq-artemis/pull/442#issuecomment-206777033
  
@mtaylor I amended the PR. Thanks!


> AMQ222137 warning does not display the cause of the problem
> ---
>
> Key: ARTEMIS-472
> URL: https://issues.apache.org/jira/browse/ARTEMIS-472
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 1.2.0
>Reporter: Jeff Mesnil
>
> While creating a cluster of Artemis servers, I encountered this warning:
> {noformat}
> 18:01:45,009 WARN  [org.apache.activemq.artemis.core.server] (Thread-2 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$2@491444
> ff-1205056429)) AMQ222137: Unable to announce backup, retrying
> {noformat}
> The cause of the error was not displayed and I had to debug to figure out 
> that I forgot to set the cluster user credentials to let the node join the 
> cluster.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ARTEMIS-472) AMQ222137 warning does not display the cause of the problem

2016-04-07 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229885#comment-15229885
 ] 

ASF GitHub Bot commented on ARTEMIS-472:


GitHub user jmesnil opened a pull request:

https://github.com/apache/activemq-artemis/pull/442

[ARTEMIS-472] add cause to AMQ222137 warning

JIRA: https://issues.apache.org/jira/browse/ARTEMIS-472

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jmesnil/activemq-artemis 
ARTEMIS-472_AMQ222137_warning

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/442.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #442


commit c113b910ed3618356cc24c65a0ff3afe80c7e105
Author: Jeff Mesnil 
Date:   2016-04-07T08:16:38Z

[ARTEMIS-472] add cause to AMQ222137 warning

JIRA: https://issues.apache.org/jira/browse/ARTEMIS-472




> AMQ222137 warning does not display the cause of the problem
> ---
>
> Key: ARTEMIS-472
> URL: https://issues.apache.org/jira/browse/ARTEMIS-472
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 1.2.0
>Reporter: Jeff Mesnil
>
> While creating a cluster of Artemis servers, I encountered this warning:
> {noformat}
> 18:01:45,009 WARN  [org.apache.activemq.artemis.core.server] (Thread-2 
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$2@491444
> ff-1205056429)) AMQ222137: Unable to announce backup, retrying
> {noformat}
> The cause of the error was not displayed and I had to debug to figure out 
> that I forgot to set the cluster user credentials to let the node join the 
> cluster.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)