[jira] [Commented] (AMQ-6363) Memory leak in activemq-jdbc-store
[ https://issues.apache.org/jira/browse/AMQ-6363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393460#comment-15393460 ] Kirill Danilov commented on AMQ-6363: - Also I found out memory leak in Queue and Topic. During new destination creation storeUsage in systemUsage object is created too, but it isn't cleared during destination removing and stays in memory forever. I did patch that fixes both problems. And I tested it with creation and destroying 500 000 queues with different names and with JDBC persistence. Now everything works fine. Patch was created for 5.13.1 version as I use it in my system. But all changes are clear to be injected in other versions even if changed code little bit different. > Memory leak in activemq-jdbc-store > -- > > Key: AMQ-6363 > URL: https://issues.apache.org/jira/browse/AMQ-6363 > Project: ActiveMQ > Issue Type: Bug > Components: JDBC >Affects Versions: 5.13.3 >Reporter: Kirill Danilov > > Hi! > ActiveMQ has memory leak in activemq-jdbc-store module. > In this class org.apache.activemq.store.jdbc.JdbcMemoryTransactionStore there > are two HashMaps: topicStores and queueStore. And these maps are filled with > topics and queues meta information when new topic or queue is created. But > there is no code that removes data from these maps. > So when dynamic queue or topic creation with following auto deleting of empty > destinations is used broker gets OutOfMemoryError after some time. > It's needed to remove destination from these maps and may be other similar > collections when auto deleting mechanism deletes inactive destination. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (AMQ-6363) Memory leak in activemq-jdbc-store
[ https://issues.apache.org/jira/browse/AMQ-6363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirill Danilov updated AMQ-6363: Attachment: Fixed_memory_leak_in_JDBCMemoryTransactionStore, Queue and Topic.patch > Memory leak in activemq-jdbc-store > -- > > Key: AMQ-6363 > URL: https://issues.apache.org/jira/browse/AMQ-6363 > Project: ActiveMQ > Issue Type: Bug > Components: JDBC >Affects Versions: 5.13.3 >Reporter: Kirill Danilov > Attachments: Fixed_memory_leak_in_JDBCMemoryTransactionStore, Queue > and Topic.patch > > > Hi! > ActiveMQ has memory leak in activemq-jdbc-store module. > In this class org.apache.activemq.store.jdbc.JdbcMemoryTransactionStore there > are two HashMaps: topicStores and queueStore. And these maps are filled with > topics and queues meta information when new topic or queue is created. But > there is no code that removes data from these maps. > So when dynamic queue or topic creation with following auto deleting of empty > destinations is used broker gets OutOfMemoryError after some time. > It's needed to remove destination from these maps and may be other similar > collections when auto deleting mechanism deletes inactive destination. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (AMQ-6363) Memory leak in activemq-jdbc-store
[ https://issues.apache.org/jira/browse/AMQ-6363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirill Danilov updated AMQ-6363: Component/s: Broker > Memory leak in activemq-jdbc-store > -- > > Key: AMQ-6363 > URL: https://issues.apache.org/jira/browse/AMQ-6363 > Project: ActiveMQ > Issue Type: Bug > Components: Broker, JDBC >Affects Versions: 5.13.3 >Reporter: Kirill Danilov > Attachments: Fixed_memory_leak_in_JDBCMemoryTransactionStore, Queue > and Topic.patch > > > Hi! > ActiveMQ has memory leak in activemq-jdbc-store module. > In this class org.apache.activemq.store.jdbc.JdbcMemoryTransactionStore there > are two HashMaps: topicStores and queueStore. And these maps are filled with > topics and queues meta information when new topic or queue is created. But > there is no code that removes data from these maps. > So when dynamic queue or topic creation with following auto deleting of empty > destinations is used broker gets OutOfMemoryError after some time. > It's needed to remove destination from these maps and may be other similar > collections when auto deleting mechanism deletes inactive destination. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Reopened] (ARTEMIS-43) Replace License Headers on codebase
[ https://issues.apache.org/jira/browse/ARTEMIS-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Tully reopened ARTEMIS-43: --- Assignee: (was: Howard Gao) The NOTICE file should have been updated with this change to reflect the original copyright attributions from the source. see: http://incubator.apache.org/guides/mentor.html#initial-clean-up Thanks to Tim Fox for pointing this out in ARTEMIS-87 > Replace License Headers on codebase > --- > > Key: ARTEMIS-43 > URL: https://issues.apache.org/jira/browse/ARTEMIS-43 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: clebert suconic >Priority: Critical > Fix For: 1.0.0 > > > The code was relicensed / donated to Apache, hence we need to replace the old > license headers. > I suggest we use this one, taken / copied from Apollo... I think it's a no > brainer and nobody would object it.. but if anyone objects is please let us > know here: > /** > * Licensed to the Apache Software Foundation (ASF) under one or more > * contributor license agreements. See the NOTICE file distributed with > * this work for additional information regarding copyright ownership. > * The ASF licenses this file to You under the Apache License, Version 2.0 > * (the "License"); you may not use this file except in compliance with > * the License. You may obtain a copy of the License at > * > * http://www.apache.org/licenses/LICENSE-2.0 > * > * Unless required by applicable law or agreed to in writing, software > * distributed under the License is distributed on an "AS IS" BASIS, > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > * See the License for the specific language governing permissions and > * limitations under the License. > */ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-87) Strip @author tags from Java source
[ https://issues.apache.org/jira/browse/ARTEMIS-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393501#comment-15393501 ] Gary Tully commented on ARTEMIS-87: --- reopened ARTEMIS-43 to capture the need to update the NOTICE file. > Strip @author tags from Java source > --- > > Key: ARTEMIS-87 > URL: https://issues.apache.org/jira/browse/ARTEMIS-87 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 1.0.0 >Reporter: Justin Bertram >Assignee: Justin Bertram > Fix For: 1.0.0 > > > Way back in 2004 [the Apache Board officially discouraged the use of 'author' > tags|http://www.apache.org/foundation/records/minutes/2004/board_minutes_2004_02_18.txt] > in source code. They are not _banned_, but merely discouraged. However, I > think it's probably a good idea to strip them from our source all the same. > Other projects (e.g. > [Camel|https://issues.apache.org/jira/browse/CAMEL-1812]) have done the same. > Here are a few other reasons to remove them (taken from > [here|https://issues.jboss.org/browse/JBRULES-2895]): > The author tags in the java files are a maintenance nightmare: > - A large percentage is wrong, incomplete or inaccurate. > - Most of the time, it only contains the original author. Many files are > completely refactored/expanded by other authors. > - Git is accurate, that is the canonical source to find the correct author. > To find the correct author of a piece of code, you always have to double > check with git, you cannot suppose the author on the author tag alone. > - Author tags promote "code ownership", which is bad in the long run. > - If people work on a piece they perceive as being owned by someone else, > they tend to: > -- only fix what they are assigned to fix, not everything that's broken. > -- discard responsibility if that code doesn't work properly. > -- be scared of stepping of the feet of the owner > - Instead of "code ownership", we need "module leadership" and "peer reviews". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (AMQ-6363) Memory leak in activemq-jdbc-store
[ https://issues.apache.org/jira/browse/AMQ-6363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirill Danilov updated AMQ-6363: Affects Version/s: 5.13.1 > Memory leak in activemq-jdbc-store > -- > > Key: AMQ-6363 > URL: https://issues.apache.org/jira/browse/AMQ-6363 > Project: ActiveMQ > Issue Type: Bug > Components: Broker, JDBC >Affects Versions: 5.13.1, 5.13.3 >Reporter: Kirill Danilov > Attachments: Fixed_memory_leak_in_JDBCMemoryTransactionStore, Queue > and Topic.patch > > > Hi! > ActiveMQ has memory leak in activemq-jdbc-store module. > In this class org.apache.activemq.store.jdbc.JdbcMemoryTransactionStore there > are two HashMaps: topicStores and queueStore. And these maps are filled with > topics and queues meta information when new topic or queue is created. But > there is no code that removes data from these maps. > So when dynamic queue or topic creation with following auto deleting of empty > destinations is used broker gets OutOfMemoryError after some time. > It's needed to remove destination from these maps and may be other similar > collections when auto deleting mechanism deletes inactive destination. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (ARTEMIS-43) Replace License Headers on codebase
[ https://issues.apache.org/jira/browse/ARTEMIS-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393497#comment-15393497 ] Gary Tully edited comment on ARTEMIS-43 at 7/26/16 11:24 AM: - The NOTICE file could have been updated with this change to reflect the original copyright attributions from the source. see: http://incubator.apache.org/guides/mentor.html#initial-clean-up Thanks to Tim Fox for pointing this out in ARTEMIS-87 note: this is not a strict requirement, because option a) from http://www.apache.org/legal/src-headers.html#headers which is complete is sufficient. However, I think option b) would be more reflective of the code history. was (Author: gtully): The NOTICE file should have been updated with this change to reflect the original copyright attributions from the source. see: http://incubator.apache.org/guides/mentor.html#initial-clean-up Thanks to Tim Fox for pointing this out in ARTEMIS-87 > Replace License Headers on codebase > --- > > Key: ARTEMIS-43 > URL: https://issues.apache.org/jira/browse/ARTEMIS-43 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: clebert suconic >Priority: Critical > Fix For: 1.0.0 > > > The code was relicensed / donated to Apache, hence we need to replace the old > license headers. > I suggest we use this one, taken / copied from Apollo... I think it's a no > brainer and nobody would object it.. but if anyone objects is please let us > know here: > /** > * Licensed to the Apache Software Foundation (ASF) under one or more > * contributor license agreements. See the NOTICE file distributed with > * this work for additional information regarding copyright ownership. > * The ASF licenses this file to You under the Apache License, Version 2.0 > * (the "License"); you may not use this file except in compliance with > * the License. You may obtain a copy of the License at > * > * http://www.apache.org/licenses/LICENSE-2.0 > * > * Unless required by applicable law or agreed to in writing, software > * distributed under the License is distributed on an "AS IS" BASIS, > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > * See the License for the specific language governing permissions and > * limitations under the License. > */ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ARTEMIS-655) [AMQP] On transacted session.commit() of receiver client, messages are read, but queue is not cleared out
Andy Taylor created ARTEMIS-655: --- Summary: [AMQP] On transacted session.commit() of receiver client, messages are read, but queue is not cleared out Key: ARTEMIS-655 URL: https://issues.apache.org/jira/browse/ARTEMIS-655 Project: ActiveMQ Artemis Issue Type: Bug Components: AMQP Affects Versions: 1.3.0 Reporter: Andy Taylor Assignee: Andy Taylor -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-655) [AMQP] On transacted session.commit() of receiver client, messages are read, but queue is not cleared out
[ https://issues.apache.org/jira/browse/ARTEMIS-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393674#comment-15393674 ] ASF GitHub Bot commented on ARTEMIS-655: GitHub user andytaylor opened a pull request: https://github.com/apache/activemq-artemis/pull/666 ARTEMIS-655 - [AMQP] On transacted session.commit() of receiver clien… …t, messages are read, but queue is not cleared out Making sure that when a transaction state of accepted is returned we actually ack the message https://issues.apache.org/jira/browse/ARTEMIS-655 You can merge this pull request into a Git repository by running: $ git pull https://github.com/andytaylor/activemq-artemis master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/666.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #666 commit 9b6bd4c990af652f5e38f8516dd4818477d370bd Author: Andy Taylor Date: 2016-07-26T11:46:11Z ARTEMIS-655 - [AMQP] On transacted session.commit() of receiver client, messages are read, but queue is not cleared out Making sure that when a transaction state of accepted is returned we actually ack the message https://issues.apache.org/jira/browse/ARTEMIS-655 > [AMQP] On transacted session.commit() of receiver client, messages are read, > but queue is not cleared out > - > > Key: ARTEMIS-655 > URL: https://issues.apache.org/jira/browse/ARTEMIS-655 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 1.3.0 >Reporter: Andy Taylor >Assignee: Andy Taylor > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-6361) Message can remain inflight after consumer side expiration acknowledgements
[ https://issues.apache.org/jira/browse/AMQ-6361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393738#comment-15393738 ] ASF subversion and git services commented on AMQ-6361: -- Commit 01cfa7727dfb6e680e3a94789fd0798c36dbc87c in activemq's branch refs/heads/master from [~gtully] [ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=01cfa77 ] AMQ-6361 - fix additional test regression on topic sub expiry AMQ4083Test,MessageEvictionTest > Message can remain inflight after consumer side expiration acknowledgements > --- > > Key: AMQ-6361 > URL: https://issues.apache.org/jira/browse/AMQ-6361 > Project: ActiveMQ > Issue Type: Bug > Components: Broker >Affects Versions: 5.13.3 >Reporter: Timothy Bish >Assignee: Gary Tully > Fix For: 5.14.0 > > > If the client clock is slightly ahead of the brokers clock a message could be > expired on the client but not considered expired on the broker. > When the expiry ACK is sent to the broker it checks if the message is also > considered expired on the broker side. If the broker clock is behind the > client side clock the message could be considered not expired on the broker > and not > removed from the broker's dispatched list. This leaves the broker reporting a > message inflight from the broker's perspective even though the message has > been expired on the consumer(client) side > The broker should treat the expired ACK as the authority on whether a message > is expired and process it as such regardless of the broker side clock. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-6370) JDBC message store - jdbc connection pool - potential deadlock with cleanup task when pool exhausted
[ https://issues.apache.org/jira/browse/AMQ-6370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393758#comment-15393758 ] ASF subversion and git services commented on AMQ-6370: -- Commit 29856516098ba3edc0d1cd5d68bc70beeae1e73d in activemq's branch refs/heads/master from [~gtully] [ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=2985651 ] AMQ-6370 - speed up the test and wait a bit longer for sends in slow ci > JDBC message store - jdbc connection pool - potential deadlock with cleanup > task when pool exhausted > > > Key: AMQ-6370 > URL: https://issues.apache.org/jira/browse/AMQ-6370 > Project: ActiveMQ > Issue Type: Bug > Components: JDBC, Message Store, XA >Affects Versions: 5.13.0 >Reporter: Gary Tully >Assignee: Gary Tully > Fix For: 5.14.0 > > > There is an read/write lock guarding the cleanup task and other jdbc ops in > the jdbc message store. > Typically the read lock is obtained before the connection from the jdbc > connection pool. > In the case of xa transactions, the connection is obtained before the read > lock, in transactioncontext.begin, leaving a window between which readlock > holders can be blocked pending the connection release. > If there is a cleanup (and write lock) request before release, the xa > transaction cannot obtain a read lock and we are stuck. > Disabling the cleanup task avoids this issue, but that is only an option if > there are no durable subs or if the durable sub cleanup task can be tackled > through db admin. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ARTEMIS-611) Refactor STOMP connection TTL & heart-beat functionality
[
https://issues.apache.org/jira/browse/ARTEMIS-611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Bertram updated ARTEMIS-611:
---
Summary: Refactor STOMP connection TTL & heart-beat functionality (was:
STOMP 1.0 consumers are killed after some time)
> Refactor STOMP connection TTL & heart-beat functionality
>
>
> Key: ARTEMIS-611
> URL: https://issues.apache.org/jira/browse/ARTEMIS-611
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 1.3.0
>Reporter: Lionel Cons
>Assignee: Justin Bertram
> Fix For: 1.4.0
>
>
> With the default configuration, a STOMP 1.0 consumer that subscribes to a
> destination and waits for messages to come gets killed after some time (in
> case there are no messages coming).
> The broker logs:
> {code}
> 2016-07-04 09:34:31,260 [org.apache.activemq.artemis.core.server] WARN
> AMQ222067: Connection failure has been detected: AMQ119014: Did not receive
> data from /192.168.47.193:54716. It is likely the client has exited or
> crashed without closing its connection, or the network between the server and
> client has failed. You also might have configured connection-ttl and
> client-failure-check-period incorrectly. Please check user manual for more
> information. The connection will now be closed. [code=CONNECTION_TIMEDOUT]
> 2016-07-04 09:34:31,261 [org.apache.activemq.artemis.core.server] WARN
> AMQ222061: Client connection failed, clearing up resources for session
> 9ae78c80-41b9-11e6-8647-02163e018512
> 2016-07-04 09:34:31,263 [org.apache.activemq.artemis.core.server] WARN
> AMQ222107: Cleared up resources for session
> 9ae78c80-41b9-11e6-8647-02163e018512
> {code}
> STOMP 1.0 clients do not support heart-beats and the broker should not kill
> connections after some period of inactivity.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ARTEMIS-43) Replace License Headers on codebase
[ https://issues.apache.org/jira/browse/ARTEMIS-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393953#comment-15393953 ] ASF GitHub Bot commented on ARTEMIS-43: --- GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/667 ARTEMIS-43 Adding notice about HornetQ donation and adding a history You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/activemq-artemis history Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/667.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #667 commit 1c7bd5604ecb903daf5ba1c419236565f3dba3bb Author: Clebert Suconic Date: 2016-07-25T20:26:54Z ARTEMIS-43 Adding notice about HornetQ donation and adding a history session > Replace License Headers on codebase > --- > > Key: ARTEMIS-43 > URL: https://issues.apache.org/jira/browse/ARTEMIS-43 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: clebert suconic >Priority: Critical > Fix For: 1.0.0 > > > The code was relicensed / donated to Apache, hence we need to replace the old > license headers. > I suggest we use this one, taken / copied from Apollo... I think it's a no > brainer and nobody would object it.. but if anyone objects is please let us > know here: > /** > * Licensed to the Apache Software Foundation (ASF) under one or more > * contributor license agreements. See the NOTICE file distributed with > * this work for additional information regarding copyright ownership. > * The ASF licenses this file to You under the Apache License, Version 2.0 > * (the "License"); you may not use this file except in compliance with > * the License. You may obtain a copy of the License at > * > * http://www.apache.org/licenses/LICENSE-2.0 > * > * Unless required by applicable law or agreed to in writing, software > * distributed under the License is distributed on an "AS IS" BASIS, > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > * See the License for the specific language governing permissions and > * limitations under the License. > */ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-587) Expose connection and subscription information via JMX
[ https://issues.apache.org/jira/browse/ARTEMIS-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393963#comment-15393963 ] ASF subversion and git services commented on ARTEMIS-587: - Commit 5d71ffc5e6e9275a966c66e2c2832e20d1ea361c in activemq-artemis's branch refs/heads/master from [~jbertram] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=5d71ffc ] ARTEMIS-587 add more JSON JMX mgmt methods to core > Expose connection and subscription information via JMX > -- > > Key: ARTEMIS-587 > URL: https://issues.apache.org/jira/browse/ARTEMIS-587 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Lionel Cons >Assignee: Justin Bertram > > ActiveMQ 5.x does expose connection information via JMX. > This allows to find out who is connected to a broker but also who consumes > from which queue or topic. One can also delete connections, for instance to > kill a stuck consumer. > I did not find the equivalent functionality in Artemis. > Could Artemis be improved to expose in JMX the list of connections (with > remote address, port number, credential used to authenticate, list of > subscriptions...) as well as (at least) an operation to force the end of a > given connection? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-587) Expose connection and subscription information via JMX
[ https://issues.apache.org/jira/browse/ARTEMIS-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393964#comment-15393964 ] ASF GitHub Bot commented on ARTEMIS-587: Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/662 > Expose connection and subscription information via JMX > -- > > Key: ARTEMIS-587 > URL: https://issues.apache.org/jira/browse/ARTEMIS-587 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Lionel Cons >Assignee: Justin Bertram > > ActiveMQ 5.x does expose connection information via JMX. > This allows to find out who is connected to a broker but also who consumes > from which queue or topic. One can also delete connections, for instance to > kill a stuck consumer. > I did not find the equivalent functionality in Artemis. > Could Artemis be improved to expose in JMX the list of connections (with > remote address, port number, credential used to authenticate, list of > subscriptions...) as well as (at least) an operation to force the end of a > given connection? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (ARTEMIS-587) Expose connection and subscription information via JMX
[ https://issues.apache.org/jira/browse/ARTEMIS-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram resolved ARTEMIS-587. Resolution: Fixed [~lionel.cons], try those new management methods out and let me know how that works for you. > Expose connection and subscription information via JMX > -- > > Key: ARTEMIS-587 > URL: https://issues.apache.org/jira/browse/ARTEMIS-587 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 1.3.0 >Reporter: Lionel Cons >Assignee: Justin Bertram > > ActiveMQ 5.x does expose connection information via JMX. > This allows to find out who is connected to a broker but also who consumes > from which queue or topic. One can also delete connections, for instance to > kill a stuck consumer. > I did not find the equivalent functionality in Artemis. > Could Artemis be improved to expose in JMX the list of connections (with > remote address, port number, credential used to authenticate, list of > subscriptions...) as well as (at least) an operation to force the end of a > given connection? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ARTEMIS-587) Expose connection and subscription information via JMX
[ https://issues.apache.org/jira/browse/ARTEMIS-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram updated ARTEMIS-587: --- Fix Version/s: 1.4.0 > Expose connection and subscription information via JMX > -- > > Key: ARTEMIS-587 > URL: https://issues.apache.org/jira/browse/ARTEMIS-587 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 1.3.0 >Reporter: Lionel Cons >Assignee: Justin Bertram > Fix For: 1.4.0 > > > ActiveMQ 5.x does expose connection information via JMX. > This allows to find out who is connected to a broker but also who consumes > from which queue or topic. One can also delete connections, for instance to > kill a stuck consumer. > I did not find the equivalent functionality in Artemis. > Could Artemis be improved to expose in JMX the list of connections (with > remote address, port number, credential used to authenticate, list of > subscriptions...) as well as (at least) an operation to force the end of a > given connection? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ARTEMIS-587) Expose connection and subscription information via JMX
[ https://issues.apache.org/jira/browse/ARTEMIS-587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram updated ARTEMIS-587: --- Affects Version/s: 1.3.0 > Expose connection and subscription information via JMX > -- > > Key: ARTEMIS-587 > URL: https://issues.apache.org/jira/browse/ARTEMIS-587 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 1.3.0 >Reporter: Lionel Cons >Assignee: Justin Bertram > Fix For: 1.4.0 > > > ActiveMQ 5.x does expose connection information via JMX. > This allows to find out who is connected to a broker but also who consumes > from which queue or topic. One can also delete connections, for instance to > kill a stuck consumer. > I did not find the equivalent functionality in Artemis. > Could Artemis be improved to expose in JMX the list of connections (with > remote address, port number, credential used to authenticate, list of > subscriptions...) as well as (at least) an operation to force the end of a > given connection? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (AMQ-6375) Add non-blocking subscription statistics to KahaDB
Christopher L. Shannon created AMQ-6375: --- Summary: Add non-blocking subscription statistics to KahaDB Key: AMQ-6375 URL: https://issues.apache.org/jira/browse/AMQ-6375 Project: ActiveMQ Issue Type: New Feature Components: Broker, KahaDB Affects Versions: 5.13.4 Reporter: Christopher L. Shannon Assignee: Christopher L. Shannon Currently KahaDB TopicMessageStore supports returning the messageCount and messageSize for subscription but this requires locking the index and iterating to compute the information. I have a use case where I query this information regularly for the status of the broker and the performance takes a hit because of the locking. There should be an option to enable statistics counters to keep track of this information so that it can be queried without locking, such like the store currently tracks the total count and size but for each subscription also. This should be disabled by default because there will be some overhead for computing the metrics if there are a lot of subscriptions in the store. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-6375) Add non-blocking subscription statistics to KahaDB
[ https://issues.apache.org/jira/browse/AMQ-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394005#comment-15394005 ] ASF subversion and git services commented on AMQ-6375: -- Commit cf3d419528e5596c1226b5ca11ed37e8039bc006 in activemq's branch refs/heads/master from [~cshannon] [ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=cf3d419 ] https://issues.apache.org/jira/browse/AMQ-6375 Adding non-blocking metrics to KahaDB to track message counts and sizes for subscriptions. Turned off by default but can be enabled on the KahaDBPersistenceAdapter > Add non-blocking subscription statistics to KahaDB > -- > > Key: AMQ-6375 > URL: https://issues.apache.org/jira/browse/AMQ-6375 > Project: ActiveMQ > Issue Type: New Feature > Components: Broker, KahaDB >Affects Versions: 5.13.4 >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon > > Currently KahaDB TopicMessageStore supports returning the messageCount and > messageSize for subscription but this requires locking the index and > iterating to compute the information. I have a use case where I query this > information regularly for the status of the broker and the performance takes > a hit because of the locking. > There should be an option to enable statistics counters to keep track of this > information so that it can be queried without locking, such like the store > currently tracks the total count and size but for each subscription also. > This should be disabled by default because there will be some overhead for > computing the metrics if there are a lot of subscriptions in the store. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (AMQ-6375) Add non-blocking subscription statistics to KahaDB
[ https://issues.apache.org/jira/browse/AMQ-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher L. Shannon updated AMQ-6375: Fix Version/s: 5.14.0 > Add non-blocking subscription statistics to KahaDB > -- > > Key: AMQ-6375 > URL: https://issues.apache.org/jira/browse/AMQ-6375 > Project: ActiveMQ > Issue Type: New Feature > Components: Broker, KahaDB >Affects Versions: 5.13.4 >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon > Fix For: 5.14.0 > > > Currently KahaDB TopicMessageStore supports returning the messageCount and > messageSize for subscription but this requires locking the index and > iterating to compute the information. I have a use case where I query this > information regularly for the status of the broker and the performance takes > a hit because of the locking. > There should be an option to enable statistics counters to keep track of this > information so that it can be queried without locking, such like the store > currently tracks the total count and size but for each subscription also. > This should be disabled by default because there will be some overhead for > computing the metrics if there are a lot of subscriptions in the store. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-6375) Add non-blocking subscription statistics to KahaDB
[ https://issues.apache.org/jira/browse/AMQ-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394010#comment-15394010 ] Christopher L. Shannon commented on AMQ-6375: - I will let CI run and if there are no regressions then I will close this out. > Add non-blocking subscription statistics to KahaDB > -- > > Key: AMQ-6375 > URL: https://issues.apache.org/jira/browse/AMQ-6375 > Project: ActiveMQ > Issue Type: New Feature > Components: Broker, KahaDB >Affects Versions: 5.13.4 >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon > Fix For: 5.14.0 > > > Currently KahaDB TopicMessageStore supports returning the messageCount and > messageSize for subscription but this requires locking the index and > iterating to compute the information. I have a use case where I query this > information regularly for the status of the broker and the performance takes > a hit because of the locking. > There should be an option to enable statistics counters to keep track of this > information so that it can be queried without locking, such like the store > currently tracks the total count and size but for each subscription also. > This should be disabled by default because there will be some overhead for > computing the metrics if there are a lot of subscriptions in the store. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-43) Replace License Headers on codebase
[ https://issues.apache.org/jira/browse/ARTEMIS-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394038#comment-15394038 ] ASF GitHub Bot commented on ARTEMIS-43: --- Github user mtaylor commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/667#discussion_r72286070 --- Diff: docs/hacking-guide/en/history.md --- @@ -0,0 +1,19 @@ +History +=== + +Artemis started with a code donation grant by RedHat in Oct 2014. During this process we took a snapshot of codebase and included it as an initial commit on the apache repository. --- End diff -- Red Hat > Replace License Headers on codebase > --- > > Key: ARTEMIS-43 > URL: https://issues.apache.org/jira/browse/ARTEMIS-43 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: clebert suconic >Priority: Critical > Fix For: 1.0.0 > > > The code was relicensed / donated to Apache, hence we need to replace the old > license headers. > I suggest we use this one, taken / copied from Apollo... I think it's a no > brainer and nobody would object it.. but if anyone objects is please let us > know here: > /** > * Licensed to the Apache Software Foundation (ASF) under one or more > * contributor license agreements. See the NOTICE file distributed with > * this work for additional information regarding copyright ownership. > * The ASF licenses this file to You under the Apache License, Version 2.0 > * (the "License"); you may not use this file except in compliance with > * the License. You may obtain a copy of the License at > * > * http://www.apache.org/licenses/LICENSE-2.0 > * > * Unless required by applicable law or agreed to in writing, software > * distributed under the License is distributed on an "AS IS" BASIS, > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > * See the License for the specific language governing permissions and > * limitations under the License. > */ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-43) Replace License Headers on codebase
[ https://issues.apache.org/jira/browse/ARTEMIS-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394045#comment-15394045 ] ASF GitHub Bot commented on ARTEMIS-43: --- Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/667#discussion_r72286860 --- Diff: docs/hacking-guide/en/history.md --- @@ -0,0 +1,19 @@ +History +=== + +Artemis started with a code donation grant by RedHat in Oct 2014. During this process we took a snapshot of codebase and included it as an initial commit on the apache repository. --- End diff -- duh.. thanks > Replace License Headers on codebase > --- > > Key: ARTEMIS-43 > URL: https://issues.apache.org/jira/browse/ARTEMIS-43 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: clebert suconic >Priority: Critical > Fix For: 1.0.0 > > > The code was relicensed / donated to Apache, hence we need to replace the old > license headers. > I suggest we use this one, taken / copied from Apollo... I think it's a no > brainer and nobody would object it.. but if anyone objects is please let us > know here: > /** > * Licensed to the Apache Software Foundation (ASF) under one or more > * contributor license agreements. See the NOTICE file distributed with > * this work for additional information regarding copyright ownership. > * The ASF licenses this file to You under the Apache License, Version 2.0 > * (the "License"); you may not use this file except in compliance with > * the License. You may obtain a copy of the License at > * > * http://www.apache.org/licenses/LICENSE-2.0 > * > * Unless required by applicable law or agreed to in writing, software > * distributed under the License is distributed on an "AS IS" BASIS, > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > * See the License for the specific language governing permissions and > * limitations under the License. > */ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-43) Replace License Headers on codebase
[ https://issues.apache.org/jira/browse/ARTEMIS-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394054#comment-15394054 ] ASF GitHub Bot commented on ARTEMIS-43: --- Github user mtaylor commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/667#discussion_r72287865 --- Diff: docs/hacking-guide/en/history.md --- @@ -0,0 +1,19 @@ +History +=== + +Artemis started with a code donation grant by RedHat in Oct 2014. During this process we took a snapshot of codebase and included it as an initial commit on the apache repository. --- End diff -- Perhaps reword this slightly. The Apache ActiveMQ Artemis project was started in October 2014. The Artemis code base was seeded with a code donation, granted by Red Hat, of the HornetQ project. The code donation process consisted of taking a snapshot of the latest HornetQ code base and contributing this snapshot as an initial git commit into the Artemis git repository. The HornetQ commit history is preserved, and can be accessed here: <> Credit should be given to those developers who contributed to the HornetQ project. The top 10 committers are highlighted here: <> For more information please visit the [HornetQ GitHub project]. > Replace License Headers on codebase > --- > > Key: ARTEMIS-43 > URL: https://issues.apache.org/jira/browse/ARTEMIS-43 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: clebert suconic >Priority: Critical > Fix For: 1.0.0 > > > The code was relicensed / donated to Apache, hence we need to replace the old > license headers. > I suggest we use this one, taken / copied from Apollo... I think it's a no > brainer and nobody would object it.. but if anyone objects is please let us > know here: > /** > * Licensed to the Apache Software Foundation (ASF) under one or more > * contributor license agreements. See the NOTICE file distributed with > * this work for additional information regarding copyright ownership. > * The ASF licenses this file to You under the Apache License, Version 2.0 > * (the "License"); you may not use this file except in compliance with > * the License. You may obtain a copy of the License at > * > * http://www.apache.org/licenses/LICENSE-2.0 > * > * Unless required by applicable law or agreed to in writing, software > * distributed under the License is distributed on an "AS IS" BASIS, > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > * See the License for the specific language governing permissions and > * limitations under the License. > */ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-43) Replace License Headers on codebase
[ https://issues.apache.org/jira/browse/ARTEMIS-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394097#comment-15394097 ] ASF GitHub Bot commented on ARTEMIS-43: --- Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/667#discussion_r72292777 --- Diff: NOTICE --- @@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). + + +Portions of this software were developed at --- End diff -- Since the code was donated via SGA, this should not be in your NOTICE. > Replace License Headers on codebase > --- > > Key: ARTEMIS-43 > URL: https://issues.apache.org/jira/browse/ARTEMIS-43 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: clebert suconic >Priority: Critical > Fix For: 1.0.0 > > > The code was relicensed / donated to Apache, hence we need to replace the old > license headers. > I suggest we use this one, taken / copied from Apollo... I think it's a no > brainer and nobody would object it.. but if anyone objects is please let us > know here: > /** > * Licensed to the Apache Software Foundation (ASF) under one or more > * contributor license agreements. See the NOTICE file distributed with > * this work for additional information regarding copyright ownership. > * The ASF licenses this file to You under the Apache License, Version 2.0 > * (the "License"); you may not use this file except in compliance with > * the License. You may obtain a copy of the License at > * > * http://www.apache.org/licenses/LICENSE-2.0 > * > * Unless required by applicable law or agreed to in writing, software > * distributed under the License is distributed on an "AS IS" BASIS, > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > * See the License for the specific language governing permissions and > * limitations under the License. > */ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-43) Replace License Headers on codebase
[ https://issues.apache.org/jira/browse/ARTEMIS-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394114#comment-15394114 ] ASF GitHub Bot commented on ARTEMIS-43: --- Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/667#discussion_r72294553 --- Diff: NOTICE --- @@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). + + +Portions of this software were developed at --- End diff -- why not? I have seen other cases done that way on other projects at apache. I believe we need something on the Notice. > Replace License Headers on codebase > --- > > Key: ARTEMIS-43 > URL: https://issues.apache.org/jira/browse/ARTEMIS-43 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: clebert suconic >Priority: Critical > Fix For: 1.0.0 > > > The code was relicensed / donated to Apache, hence we need to replace the old > license headers. > I suggest we use this one, taken / copied from Apollo... I think it's a no > brainer and nobody would object it.. but if anyone objects is please let us > know here: > /** > * Licensed to the Apache Software Foundation (ASF) under one or more > * contributor license agreements. See the NOTICE file distributed with > * this work for additional information regarding copyright ownership. > * The ASF licenses this file to You under the Apache License, Version 2.0 > * (the "License"); you may not use this file except in compliance with > * the License. You may obtain a copy of the License at > * > * http://www.apache.org/licenses/LICENSE-2.0 > * > * Unless required by applicable law or agreed to in writing, software > * distributed under the License is distributed on an "AS IS" BASIS, > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > * See the License for the specific language governing permissions and > * limitations under the License. > */ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-43) Replace License Headers on codebase
[ https://issues.apache.org/jira/browse/ARTEMIS-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394117#comment-15394117 ] ASF GitHub Bot commented on ARTEMIS-43: --- Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/667#discussion_r72294894 --- Diff: docs/hacking-guide/en/history.md --- @@ -0,0 +1,19 @@ +History +=== + +Artemis started with a code donation grant by RedHat in Oct 2014. During this process we took a snapshot of codebase and included it as an initial commit on the apache repository. --- End diff -- Not my style.. I usually prefer text very concise and straight to the point.. but I can include yours. > Replace License Headers on codebase > --- > > Key: ARTEMIS-43 > URL: https://issues.apache.org/jira/browse/ARTEMIS-43 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: clebert suconic >Priority: Critical > Fix For: 1.0.0 > > > The code was relicensed / donated to Apache, hence we need to replace the old > license headers. > I suggest we use this one, taken / copied from Apollo... I think it's a no > brainer and nobody would object it.. but if anyone objects is please let us > know here: > /** > * Licensed to the Apache Software Foundation (ASF) under one or more > * contributor license agreements. See the NOTICE file distributed with > * this work for additional information regarding copyright ownership. > * The ASF licenses this file to You under the Apache License, Version 2.0 > * (the "License"); you may not use this file except in compliance with > * the License. You may obtain a copy of the License at > * > * http://www.apache.org/licenses/LICENSE-2.0 > * > * Unless required by applicable law or agreed to in writing, software > * distributed under the License is distributed on an "AS IS" BASIS, > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > * See the License for the specific language governing permissions and > * limitations under the License. > */ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-43) Replace License Headers on codebase
[ https://issues.apache.org/jira/browse/ARTEMIS-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394126#comment-15394126 ] ASF GitHub Bot commented on ARTEMIS-43: --- Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/667#discussion_r72296232 --- Diff: NOTICE --- @@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). + + +Portions of this software were developed at --- End diff -- @clebertsuconic can you link to me an example of where you've seen it? Usually NOTICE is only when code is imported via non-SGA, e.g. a compatible OS license where modifications are done. > Replace License Headers on codebase > --- > > Key: ARTEMIS-43 > URL: https://issues.apache.org/jira/browse/ARTEMIS-43 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: clebert suconic >Priority: Critical > Fix For: 1.0.0 > > > The code was relicensed / donated to Apache, hence we need to replace the old > license headers. > I suggest we use this one, taken / copied from Apollo... I think it's a no > brainer and nobody would object it.. but if anyone objects is please let us > know here: > /** > * Licensed to the Apache Software Foundation (ASF) under one or more > * contributor license agreements. See the NOTICE file distributed with > * this work for additional information regarding copyright ownership. > * The ASF licenses this file to You under the Apache License, Version 2.0 > * (the "License"); you may not use this file except in compliance with > * the License. You may obtain a copy of the License at > * > * http://www.apache.org/licenses/LICENSE-2.0 > * > * Unless required by applicable law or agreed to in writing, software > * distributed under the License is distributed on an "AS IS" BASIS, > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > * See the License for the specific language governing permissions and > * limitations under the License. > */ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-43) Replace License Headers on codebase
[ https://issues.apache.org/jira/browse/ARTEMIS-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394170#comment-15394170 ] ASF GitHub Bot commented on ARTEMIS-43: --- Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/667#discussion_r72299763 --- Diff: NOTICE --- @@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). + + +Portions of this software were developed at --- End diff -- http://www.apache.org/legal/src-headers.html#notice in special: ```... The NOTICE file may also include copyright notices moved from source files submitted to the ASF. ``` I found at least one example doing this.. I have seen others but I have the link for this one now: https://github.com/apache/incubator-mynewt-core/blob/master/NOTICE > Replace License Headers on codebase > --- > > Key: ARTEMIS-43 > URL: https://issues.apache.org/jira/browse/ARTEMIS-43 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: clebert suconic >Priority: Critical > Fix For: 1.0.0 > > > The code was relicensed / donated to Apache, hence we need to replace the old > license headers. > I suggest we use this one, taken / copied from Apollo... I think it's a no > brainer and nobody would object it.. but if anyone objects is please let us > know here: > /** > * Licensed to the Apache Software Foundation (ASF) under one or more > * contributor license agreements. See the NOTICE file distributed with > * this work for additional information regarding copyright ownership. > * The ASF licenses this file to You under the Apache License, Version 2.0 > * (the "License"); you may not use this file except in compliance with > * the License. You may obtain a copy of the License at > * > * http://www.apache.org/licenses/LICENSE-2.0 > * > * Unless required by applicable law or agreed to in writing, software > * distributed under the License is distributed on an "AS IS" BASIS, > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > * See the License for the specific language governing permissions and > * limitations under the License. > */ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-43) Replace License Headers on codebase
[ https://issues.apache.org/jira/browse/ARTEMIS-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394199#comment-15394199 ] ASF GitHub Bot commented on ARTEMIS-43: --- Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/667#discussion_r72302279 --- Diff: NOTICE --- @@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). + + +Portions of this software were developed at --- End diff -- I just pinged someone who's better at this than I am. I wouldn't use Mynewt as an example as they are incubating, but you are correct (and I even +1'd their release that included this). I will point the link you're quoting includes this: ``` - remove such notices, or - move them to the NOTICE file associated with each applicable project release, or - provide written permission for the ASF to make such removal or relocation of the notices. ``` Which the SGA should fall under the 1st or 3rd bullet point > Replace License Headers on codebase > --- > > Key: ARTEMIS-43 > URL: https://issues.apache.org/jira/browse/ARTEMIS-43 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: clebert suconic >Priority: Critical > Fix For: 1.0.0 > > > The code was relicensed / donated to Apache, hence we need to replace the old > license headers. > I suggest we use this one, taken / copied from Apollo... I think it's a no > brainer and nobody would object it.. but if anyone objects is please let us > know here: > /** > * Licensed to the Apache Software Foundation (ASF) under one or more > * contributor license agreements. See the NOTICE file distributed with > * this work for additional information regarding copyright ownership. > * The ASF licenses this file to You under the Apache License, Version 2.0 > * (the "License"); you may not use this file except in compliance with > * the License. You may obtain a copy of the License at > * > * http://www.apache.org/licenses/LICENSE-2.0 > * > * Unless required by applicable law or agreed to in writing, software > * distributed under the License is distributed on an "AS IS" BASIS, > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > * See the License for the specific language governing permissions and > * limitations under the License. > */ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-43) Replace License Headers on codebase
[ https://issues.apache.org/jira/browse/ARTEMIS-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394222#comment-15394222 ] ASF GitHub Bot commented on ARTEMIS-43: --- Github user clebertsuconic commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/667#discussion_r72304637 --- Diff: NOTICE --- @@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). + + +Portions of this software were developed at --- End diff -- I just want to give hornetq contributor the credit for their contributions on what became Artemis today. We took a snapshot of hornetq during the Artemis, as it seemed the right decision at the time given the lengthy history logs existing on the donation. I think it's reasonable to include a word about their contributions. > Replace License Headers on codebase > --- > > Key: ARTEMIS-43 > URL: https://issues.apache.org/jira/browse/ARTEMIS-43 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: clebert suconic >Priority: Critical > Fix For: 1.0.0 > > > The code was relicensed / donated to Apache, hence we need to replace the old > license headers. > I suggest we use this one, taken / copied from Apollo... I think it's a no > brainer and nobody would object it.. but if anyone objects is please let us > know here: > /** > * Licensed to the Apache Software Foundation (ASF) under one or more > * contributor license agreements. See the NOTICE file distributed with > * this work for additional information regarding copyright ownership. > * The ASF licenses this file to You under the Apache License, Version 2.0 > * (the "License"); you may not use this file except in compliance with > * the License. You may obtain a copy of the License at > * > * http://www.apache.org/licenses/LICENSE-2.0 > * > * Unless required by applicable law or agreed to in writing, software > * distributed under the License is distributed on an "AS IS" BASIS, > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > * See the License for the specific language governing permissions and > * limitations under the License. > */ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-43) Replace License Headers on codebase
[ https://issues.apache.org/jira/browse/ARTEMIS-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394245#comment-15394245 ] ASF GitHub Bot commented on ARTEMIS-43: --- Github user johnament commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/667#discussion_r72306219 --- Diff: NOTICE --- @@ -3,3 +3,7 @@ Copyright [2014-2016] The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://www.apache.org/). + + +Portions of this software were developed at --- End diff -- Right, I'm not saying that's a bad thing. My concern is this page: http://www.apache.org/dev/licensing-howto.html#mod-notice, which includes Do not add anything to NOTICE which is not legally required. > Replace License Headers on codebase > --- > > Key: ARTEMIS-43 > URL: https://issues.apache.org/jira/browse/ARTEMIS-43 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: clebert suconic >Priority: Critical > Fix For: 1.0.0 > > > The code was relicensed / donated to Apache, hence we need to replace the old > license headers. > I suggest we use this one, taken / copied from Apollo... I think it's a no > brainer and nobody would object it.. but if anyone objects is please let us > know here: > /** > * Licensed to the Apache Software Foundation (ASF) under one or more > * contributor license agreements. See the NOTICE file distributed with > * this work for additional information regarding copyright ownership. > * The ASF licenses this file to You under the Apache License, Version 2.0 > * (the "License"); you may not use this file except in compliance with > * the License. You may obtain a copy of the License at > * > * http://www.apache.org/licenses/LICENSE-2.0 > * > * Unless required by applicable law or agreed to in writing, software > * distributed under the License is distributed on an "AS IS" BASIS, > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > * See the License for the specific language governing permissions and > * limitations under the License. > */ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-565) Artemis use no free json.org
[ https://issues.apache.org/jira/browse/ARTEMIS-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394260#comment-15394260 ] ASF GitHub Bot commented on ARTEMIS-565: GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/668 ARTEMIS-565 A few fixes around the JSON change You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/activemq-artemis json Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/668.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #668 commit b7efd5db3b800e2ec507198264105fe14893b578 Author: Clebert Suconic Date: 2016-07-26T15:56:28Z ARTEMIS-565 A few fixes around the JSON change > Artemis use no free json.org > > > Key: ARTEMIS-565 > URL: https://issues.apache.org/jira/browse/ARTEMIS-565 > Project: ActiveMQ Artemis > Issue Type: Bug > Environment: Linux all >Reporter: gil cattaneo > > Hi, > Fedora [1] is a popular distribution of the Linux operating system, and > we wish to include the latest version of ActiveMQ Artemis [2] in our OS. > Fedora only contains Free and Open Source licensed works. > Your project is licensed under Apache License Version 2, > but your code pulls in code from json.org under Douglas Crockford’s bad > licence [3], and is non-free [4]. > Such usage restriction makes the license incompatible with The Open Source > Definition and > The Free Software Definition. Because ActiveMQ Artemis binary distribution > includes this software, > it effectively becomes proprietary software itself. > You may also comment that the json.org license is valid for You [5] but for > many Linux distributions it is not acceptable. > Hoping in the future to be able to use ActiveMQ Artemis in Fedora, without > having to run into this problem. > Please try to replace it with one of the many free alternatives. > Regards > [1] https://fedoraproject.org/wiki/Fedora_Project_Wiki > [2] https://bugzilla.redhat.com/show_bug.cgi?id=1343063 > [3] > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONArray.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONException.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONObject.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONString.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONTokener.java > [4] > https://wiki.debian.org/qa.debian.org/jsonevil > http://www.sonatype.com/people/2012/03/use-json-well-youd-better-not-be-evil/ > http://tanguy.ortolo.eu/blog/article46/json-license > [5] http://www.apache.org/legal/resolved.html#json -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-565) Artemis use no free json.org
[ https://issues.apache.org/jira/browse/ARTEMIS-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394268#comment-15394268 ] ASF GitHub Bot commented on ARTEMIS-565: Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/668 @johnament if you could take a look here. just to let you know about this one given you mentioned you would make more changes. > Artemis use no free json.org > > > Key: ARTEMIS-565 > URL: https://issues.apache.org/jira/browse/ARTEMIS-565 > Project: ActiveMQ Artemis > Issue Type: Bug > Environment: Linux all >Reporter: gil cattaneo > > Hi, > Fedora [1] is a popular distribution of the Linux operating system, and > we wish to include the latest version of ActiveMQ Artemis [2] in our OS. > Fedora only contains Free and Open Source licensed works. > Your project is licensed under Apache License Version 2, > but your code pulls in code from json.org under Douglas Crockford’s bad > licence [3], and is non-free [4]. > Such usage restriction makes the license incompatible with The Open Source > Definition and > The Free Software Definition. Because ActiveMQ Artemis binary distribution > includes this software, > it effectively becomes proprietary software itself. > You may also comment that the json.org license is valid for You [5] but for > many Linux distributions it is not acceptable. > Hoping in the future to be able to use ActiveMQ Artemis in Fedora, without > having to run into this problem. > Please try to replace it with one of the many free alternatives. > Regards > [1] https://fedoraproject.org/wiki/Fedora_Project_Wiki > [2] https://bugzilla.redhat.com/show_bug.cgi?id=1343063 > [3] > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONArray.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONException.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONObject.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONString.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONTokener.java > [4] > https://wiki.debian.org/qa.debian.org/jsonevil > http://www.sonatype.com/people/2012/03/use-json-well-youd-better-not-be-evil/ > http://tanguy.ortolo.eu/blog/article46/json-license > [5] http://www.apache.org/legal/resolved.html#json -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-565) Artemis use no free json.org
[ https://issues.apache.org/jira/browse/ARTEMIS-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394274#comment-15394274 ] ASF GitHub Bot commented on ARTEMIS-565: Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/668 > Artemis use no free json.org > > > Key: ARTEMIS-565 > URL: https://issues.apache.org/jira/browse/ARTEMIS-565 > Project: ActiveMQ Artemis > Issue Type: Bug > Environment: Linux all >Reporter: gil cattaneo > > Hi, > Fedora [1] is a popular distribution of the Linux operating system, and > we wish to include the latest version of ActiveMQ Artemis [2] in our OS. > Fedora only contains Free and Open Source licensed works. > Your project is licensed under Apache License Version 2, > but your code pulls in code from json.org under Douglas Crockford’s bad > licence [3], and is non-free [4]. > Such usage restriction makes the license incompatible with The Open Source > Definition and > The Free Software Definition. Because ActiveMQ Artemis binary distribution > includes this software, > it effectively becomes proprietary software itself. > You may also comment that the json.org license is valid for You [5] but for > many Linux distributions it is not acceptable. > Hoping in the future to be able to use ActiveMQ Artemis in Fedora, without > having to run into this problem. > Please try to replace it with one of the many free alternatives. > Regards > [1] https://fedoraproject.org/wiki/Fedora_Project_Wiki > [2] https://bugzilla.redhat.com/show_bug.cgi?id=1343063 > [3] > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONArray.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONException.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONObject.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONString.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONTokener.java > [4] > https://wiki.debian.org/qa.debian.org/jsonevil > http://www.sonatype.com/people/2012/03/use-json-well-youd-better-not-be-evil/ > http://tanguy.ortolo.eu/blog/article46/json-license > [5] http://www.apache.org/legal/resolved.html#json -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-565) Artemis use no free json.org
[ https://issues.apache.org/jira/browse/ARTEMIS-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394273#comment-15394273 ] ASF subversion and git services commented on ARTEMIS-565: - Commit b7efd5db3b800e2ec507198264105fe14893b578 in activemq-artemis's branch refs/heads/master from Clebert Suconic [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=b7efd5d ] ARTEMIS-565 A few fixes around the JSON change > Artemis use no free json.org > > > Key: ARTEMIS-565 > URL: https://issues.apache.org/jira/browse/ARTEMIS-565 > Project: ActiveMQ Artemis > Issue Type: Bug > Environment: Linux all >Reporter: gil cattaneo > > Hi, > Fedora [1] is a popular distribution of the Linux operating system, and > we wish to include the latest version of ActiveMQ Artemis [2] in our OS. > Fedora only contains Free and Open Source licensed works. > Your project is licensed under Apache License Version 2, > but your code pulls in code from json.org under Douglas Crockford’s bad > licence [3], and is non-free [4]. > Such usage restriction makes the license incompatible with The Open Source > Definition and > The Free Software Definition. Because ActiveMQ Artemis binary distribution > includes this software, > it effectively becomes proprietary software itself. > You may also comment that the json.org license is valid for You [5] but for > many Linux distributions it is not acceptable. > Hoping in the future to be able to use ActiveMQ Artemis in Fedora, without > having to run into this problem. > Please try to replace it with one of the many free alternatives. > Regards > [1] https://fedoraproject.org/wiki/Fedora_Project_Wiki > [2] https://bugzilla.redhat.com/show_bug.cgi?id=1343063 > [3] > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONArray.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONException.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONObject.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONString.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONTokener.java > [4] > https://wiki.debian.org/qa.debian.org/jsonevil > http://www.sonatype.com/people/2012/03/use-json-well-youd-better-not-be-evil/ > http://tanguy.ortolo.eu/blog/article46/json-license > [5] http://www.apache.org/legal/resolved.html#json -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-655) [AMQP] On transacted session.commit() of receiver client, messages are read, but queue is not cleared out
[ https://issues.apache.org/jira/browse/ARTEMIS-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394277#comment-15394277 ] ASF GitHub Bot commented on ARTEMIS-655: Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/666 @andytaylor I am not merging this one.. it's #666 lol > [AMQP] On transacted session.commit() of receiver client, messages are read, > but queue is not cleared out > - > > Key: ARTEMIS-655 > URL: https://issues.apache.org/jira/browse/ARTEMIS-655 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 1.3.0 >Reporter: Andy Taylor >Assignee: Andy Taylor > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-655) [AMQP] On transacted session.commit() of receiver client, messages are read, but queue is not cleared out
[ https://issues.apache.org/jira/browse/ARTEMIS-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394280#comment-15394280 ] ASF subversion and git services commented on ARTEMIS-655: - Commit 85ede22c3cbb5f258d46fe5063c76a20d3b045c1 in activemq-artemis's branch refs/heads/master from [~andytaylor] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=85ede22 ] ARTEMIS-655 - [AMQP] On transacted session.commit() of receiver client, messages are read, but queue is not cleared out Making sure that when a transaction state of accepted is returned we actually ack the message https://issues.apache.org/jira/browse/ARTEMIS-655 > [AMQP] On transacted session.commit() of receiver client, messages are read, > but queue is not cleared out > - > > Key: ARTEMIS-655 > URL: https://issues.apache.org/jira/browse/ARTEMIS-655 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 1.3.0 >Reporter: Andy Taylor >Assignee: Andy Taylor > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-565) Artemis use no free json.org
[ https://issues.apache.org/jira/browse/ARTEMIS-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394282#comment-15394282 ] ASF GitHub Bot commented on ARTEMIS-565: GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/669 ARTEMIS-565 fix more broken Json stuff You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/669.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #669 commit 6a0942cbe83a6f4743b9c362611d36d9560a668b Author: jbertram Date: 2016-07-26T16:11:07Z ARTEMIS-565 fix more broken Json stuff > Artemis use no free json.org > > > Key: ARTEMIS-565 > URL: https://issues.apache.org/jira/browse/ARTEMIS-565 > Project: ActiveMQ Artemis > Issue Type: Bug > Environment: Linux all >Reporter: gil cattaneo > > Hi, > Fedora [1] is a popular distribution of the Linux operating system, and > we wish to include the latest version of ActiveMQ Artemis [2] in our OS. > Fedora only contains Free and Open Source licensed works. > Your project is licensed under Apache License Version 2, > but your code pulls in code from json.org under Douglas Crockford’s bad > licence [3], and is non-free [4]. > Such usage restriction makes the license incompatible with The Open Source > Definition and > The Free Software Definition. Because ActiveMQ Artemis binary distribution > includes this software, > it effectively becomes proprietary software itself. > You may also comment that the json.org license is valid for You [5] but for > many Linux distributions it is not acceptable. > Hoping in the future to be able to use ActiveMQ Artemis in Fedora, without > having to run into this problem. > Please try to replace it with one of the many free alternatives. > Regards > [1] https://fedoraproject.org/wiki/Fedora_Project_Wiki > [2] https://bugzilla.redhat.com/show_bug.cgi?id=1343063 > [3] > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONArray.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONException.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONObject.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONString.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONTokener.java > [4] > https://wiki.debian.org/qa.debian.org/jsonevil > http://www.sonatype.com/people/2012/03/use-json-well-youd-better-not-be-evil/ > http://tanguy.ortolo.eu/blog/article46/json-license > [5] http://www.apache.org/legal/resolved.html#json -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-655) [AMQP] On transacted session.commit() of receiver client, messages are read, but queue is not cleared out
[ https://issues.apache.org/jira/browse/ARTEMIS-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394281#comment-15394281 ] ASF GitHub Bot commented on ARTEMIS-655: Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/666 > [AMQP] On transacted session.commit() of receiver client, messages are read, > but queue is not cleared out > - > > Key: ARTEMIS-655 > URL: https://issues.apache.org/jira/browse/ARTEMIS-655 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 1.3.0 >Reporter: Andy Taylor >Assignee: Andy Taylor > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-655) [AMQP] On transacted session.commit() of receiver client, messages are read, but queue is not cleared out
[ https://issues.apache.org/jira/browse/ARTEMIS-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394279#comment-15394279 ] ASF subversion and git services commented on ARTEMIS-655: - Commit 85ede22c3cbb5f258d46fe5063c76a20d3b045c1 in activemq-artemis's branch refs/heads/master from [~andytaylor] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=85ede22 ] ARTEMIS-655 - [AMQP] On transacted session.commit() of receiver client, messages are read, but queue is not cleared out Making sure that when a transaction state of accepted is returned we actually ack the message https://issues.apache.org/jira/browse/ARTEMIS-655 > [AMQP] On transacted session.commit() of receiver client, messages are read, > but queue is not cleared out > - > > Key: ARTEMIS-655 > URL: https://issues.apache.org/jira/browse/ARTEMIS-655 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 1.3.0 >Reporter: Andy Taylor >Assignee: Andy Taylor > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-565) Artemis use no free json.org
[ https://issues.apache.org/jira/browse/ARTEMIS-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394286#comment-15394286 ] ASF subversion and git services commented on ARTEMIS-565: - Commit 1de4dbbe2739c171b20aa7a9e4528c23ae06adcf in activemq-artemis's branch refs/heads/master from [~jbertram] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=1de4dbb ] ARTEMIS-565 fix more broken Json stuff > Artemis use no free json.org > > > Key: ARTEMIS-565 > URL: https://issues.apache.org/jira/browse/ARTEMIS-565 > Project: ActiveMQ Artemis > Issue Type: Bug > Environment: Linux all >Reporter: gil cattaneo > > Hi, > Fedora [1] is a popular distribution of the Linux operating system, and > we wish to include the latest version of ActiveMQ Artemis [2] in our OS. > Fedora only contains Free and Open Source licensed works. > Your project is licensed under Apache License Version 2, > but your code pulls in code from json.org under Douglas Crockford’s bad > licence [3], and is non-free [4]. > Such usage restriction makes the license incompatible with The Open Source > Definition and > The Free Software Definition. Because ActiveMQ Artemis binary distribution > includes this software, > it effectively becomes proprietary software itself. > You may also comment that the json.org license is valid for You [5] but for > many Linux distributions it is not acceptable. > Hoping in the future to be able to use ActiveMQ Artemis in Fedora, without > having to run into this problem. > Please try to replace it with one of the many free alternatives. > Regards > [1] https://fedoraproject.org/wiki/Fedora_Project_Wiki > [2] https://bugzilla.redhat.com/show_bug.cgi?id=1343063 > [3] > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONArray.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONException.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONObject.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONString.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONTokener.java > [4] > https://wiki.debian.org/qa.debian.org/jsonevil > http://www.sonatype.com/people/2012/03/use-json-well-youd-better-not-be-evil/ > http://tanguy.ortolo.eu/blog/article46/json-license > [5] http://www.apache.org/legal/resolved.html#json -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-565) Artemis use no free json.org
[ https://issues.apache.org/jira/browse/ARTEMIS-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394289#comment-15394289 ] ASF GitHub Bot commented on ARTEMIS-565: Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/669 > Artemis use no free json.org > > > Key: ARTEMIS-565 > URL: https://issues.apache.org/jira/browse/ARTEMIS-565 > Project: ActiveMQ Artemis > Issue Type: Bug > Environment: Linux all >Reporter: gil cattaneo > > Hi, > Fedora [1] is a popular distribution of the Linux operating system, and > we wish to include the latest version of ActiveMQ Artemis [2] in our OS. > Fedora only contains Free and Open Source licensed works. > Your project is licensed under Apache License Version 2, > but your code pulls in code from json.org under Douglas Crockford’s bad > licence [3], and is non-free [4]. > Such usage restriction makes the license incompatible with The Open Source > Definition and > The Free Software Definition. Because ActiveMQ Artemis binary distribution > includes this software, > it effectively becomes proprietary software itself. > You may also comment that the json.org license is valid for You [5] but for > many Linux distributions it is not acceptable. > Hoping in the future to be able to use ActiveMQ Artemis in Fedora, without > having to run into this problem. > Please try to replace it with one of the many free alternatives. > Regards > [1] https://fedoraproject.org/wiki/Fedora_Project_Wiki > [2] https://bugzilla.redhat.com/show_bug.cgi?id=1343063 > [3] > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONArray.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONException.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONObject.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONString.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONTokener.java > [4] > https://wiki.debian.org/qa.debian.org/jsonevil > http://www.sonatype.com/people/2012/03/use-json-well-youd-better-not-be-evil/ > http://tanguy.ortolo.eu/blog/article46/json-license > [5] http://www.apache.org/legal/resolved.html#json -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (AMQCPP-600) Segfault in MutexProperties after shutdownLibrary was called and returned
Josh Schwartz created AMQCPP-600: Summary: Segfault in MutexProperties after shutdownLibrary was called and returned Key: AMQCPP-600 URL: https://issues.apache.org/jira/browse/AMQCPP-600 Project: ActiveMQ C++ Client Issue Type: Bug Components: Decaf Affects Versions: 3.9.1, 3.8.4 Environment: $ cat /etc/redhat-release Red Hat Enterprise Linux Server release 6.8 (Santiago) $ cat /proc/version Linux version 2.6.32-642.el6.x86_64 (mockbu...@x86-033.build.eng.bos.redhat.com) (gcc version 4.4.7 20120313 (Red Hat 4.4.7-17) (GCC) ) #1 SMP Wed Apr 13 00:51:26 EDT 2016 Reporter: Josh Schwartz Assignee: Timothy Bish During shutdown of our application there seem to still be ActiveMQ-CPP threads running which rarely cause a segfault. Attached is an analysis of the core file from one of these instances. The stack trace of the thread which caused the segfault was: Program terminated with signal 11, Segmentation fault. #0 0x003619689adf in memcpy () from /lib64/libc.so.6 #0 0x003619689adf in memcpy () from /lib64/libc.so.6 #1 0x003624a9dadc in std::basic_string, std::allocator >::append(std::basic_string, std::allocator > const&) () from /usr/lib64/libstdc++.so.6 #2 0x2ba8ca62d152 in MutexProperties (this=0x2ba8d81ffb40) at decaf/util/concurrent/Mutex.cpp:50 #3 decaf::util::concurrent::Mutex::Mutex (this=0x2ba8d81ffb40) at decaf/util/concurrent/Mutex.cpp:78 #4 0x2ba8ca63c3ee in AbstractCollection (this=0x22bd960) at ./decaf/util/AbstractCollection.h:65 #5 AbstractList (this=0x22bd960) at ./decaf/util/AbstractList.h:341 #6 AbstractSequentialList (this=0x22bd960) at ./decaf/util/AbstractSequentialList.h:59 #7 LinkedList (this=0x22bd960) at ./decaf/util/LinkedList.h:91 #8 decaf::util::concurrent::ExecutorKernel::WorkerKiller::run (this=0x22bd960) at decaf/util/concurrent/ThreadPoolExecutor.cpp:248 #9 0x2ba8ca6270c2 in decaf::util::TimerImpl::run (this=0x23b32a0) at decaf/util/Timer.cpp:156 #10 0x2ba8ca5a612f in (anonymous namespace)::runCallback (arg=0x226a890) at decaf/internal/util/concurrent/Threading.cpp:268 #11 0x2ba8ca5a5ea4 in (anonymous namespace)::threadEntryMethod (arg=0x226a890) at decaf/internal/util/concurrent/Threading.cpp:256 #12 0x00361a207aa1 in start_thread () from /lib64/libpthread.so.0 #13 0x0036196e8aad in clone () from /lib64/libc.so.6 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (AMQCPP-600) Segfault in MutexProperties after shutdownLibrary was called and returned
[ https://issues.apache.org/jira/browse/AMQCPP-600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Schwartz updated AMQCPP-600: - Attachment: core.13553-gdb.log > Segfault in MutexProperties after shutdownLibrary was called and returned > - > > Key: AMQCPP-600 > URL: https://issues.apache.org/jira/browse/AMQCPP-600 > Project: ActiveMQ C++ Client > Issue Type: Bug > Components: Decaf >Affects Versions: 3.8.4, 3.9.1 > Environment: $ cat /etc/redhat-release > Red Hat Enterprise Linux Server release 6.8 (Santiago) > $ cat /proc/version > Linux version 2.6.32-642.el6.x86_64 > (mockbu...@x86-033.build.eng.bos.redhat.com) (gcc version 4.4.7 20120313 (Red > Hat 4.4.7-17) (GCC) ) #1 SMP Wed Apr 13 00:51:26 EDT 2016 >Reporter: Josh Schwartz >Assignee: Timothy Bish > Attachments: core.13553-gdb.log > > > During shutdown of our application there seem to still be ActiveMQ-CPP > threads running which rarely cause a segfault. Attached is an analysis of > the core file from one of these instances. The stack trace of the thread > which caused the segfault was: > Program terminated with signal 11, Segmentation fault. > #0 0x003619689adf in memcpy () from /lib64/libc.so.6 > #0 0x003619689adf in memcpy () from /lib64/libc.so.6 > #1 0x003624a9dadc in std::basic_string, > std::allocator >::append(std::basic_string std::char_traits, std::allocator > const&) () from > /usr/lib64/libstdc++.so.6 > #2 0x2ba8ca62d152 in MutexProperties (this=0x2ba8d81ffb40) at > decaf/util/concurrent/Mutex.cpp:50 > #3 decaf::util::concurrent::Mutex::Mutex (this=0x2ba8d81ffb40) at > decaf/util/concurrent/Mutex.cpp:78 > #4 0x2ba8ca63c3ee in AbstractCollection (this=0x22bd960) at > ./decaf/util/AbstractCollection.h:65 > #5 AbstractList (this=0x22bd960) at ./decaf/util/AbstractList.h:341 > #6 AbstractSequentialList (this=0x22bd960) at > ./decaf/util/AbstractSequentialList.h:59 > #7 LinkedList (this=0x22bd960) at ./decaf/util/LinkedList.h:91 > #8 decaf::util::concurrent::ExecutorKernel::WorkerKiller::run > (this=0x22bd960) at decaf/util/concurrent/ThreadPoolExecutor.cpp:248 > #9 0x2ba8ca6270c2 in decaf::util::TimerImpl::run (this=0x23b32a0) at > decaf/util/Timer.cpp:156 > #10 0x2ba8ca5a612f in (anonymous namespace)::runCallback (arg=0x226a890) > at decaf/internal/util/concurrent/Threading.cpp:268 > #11 0x2ba8ca5a5ea4 in (anonymous namespace)::threadEntryMethod > (arg=0x226a890) at decaf/internal/util/concurrent/Threading.cpp:256 > #12 0x00361a207aa1 in start_thread () from /lib64/libpthread.so.0 > #13 0x0036196e8aad in clone () from /lib64/libc.so.6 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-565) Artemis use no free json.org
[ https://issues.apache.org/jira/browse/ARTEMIS-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394469#comment-15394469 ] ASF GitHub Bot commented on ARTEMIS-565: GitHub user clebertsuconic opened a pull request: https://github.com/apache/activemq-artemis/pull/670 ARTEMIS-565 more tweaks on the JSON replacement You can merge this pull request into a Git repository by running: $ git pull https://github.com/clebertsuconic/activemq-artemis json Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/670.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #670 commit 76938fe44a98eb802a707ae630cc4f2d3008085e Author: Clebert Suconic Date: 2016-07-26T20:01:36Z ARTEMIS-565 more tweaks on the JSON replacement > Artemis use no free json.org > > > Key: ARTEMIS-565 > URL: https://issues.apache.org/jira/browse/ARTEMIS-565 > Project: ActiveMQ Artemis > Issue Type: Bug > Environment: Linux all >Reporter: gil cattaneo > > Hi, > Fedora [1] is a popular distribution of the Linux operating system, and > we wish to include the latest version of ActiveMQ Artemis [2] in our OS. > Fedora only contains Free and Open Source licensed works. > Your project is licensed under Apache License Version 2, > but your code pulls in code from json.org under Douglas Crockford’s bad > licence [3], and is non-free [4]. > Such usage restriction makes the license incompatible with The Open Source > Definition and > The Free Software Definition. Because ActiveMQ Artemis binary distribution > includes this software, > it effectively becomes proprietary software itself. > You may also comment that the json.org license is valid for You [5] but for > many Linux distributions it is not acceptable. > Hoping in the future to be able to use ActiveMQ Artemis in Fedora, without > having to run into this problem. > Please try to replace it with one of the many free alternatives. > Regards > [1] https://fedoraproject.org/wiki/Fedora_Project_Wiki > [2] https://bugzilla.redhat.com/show_bug.cgi?id=1343063 > [3] > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONArray.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONException.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONObject.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONString.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONTokener.java > [4] > https://wiki.debian.org/qa.debian.org/jsonevil > http://www.sonatype.com/people/2012/03/use-json-well-youd-better-not-be-evil/ > http://tanguy.ortolo.eu/blog/article46/json-license > [5] http://www.apache.org/legal/resolved.html#json -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-565) Artemis use no free json.org
[ https://issues.apache.org/jira/browse/ARTEMIS-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394471#comment-15394471 ] ASF GitHub Bot commented on ARTEMIS-565: Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/670 > Artemis use no free json.org > > > Key: ARTEMIS-565 > URL: https://issues.apache.org/jira/browse/ARTEMIS-565 > Project: ActiveMQ Artemis > Issue Type: Bug > Environment: Linux all >Reporter: gil cattaneo > > Hi, > Fedora [1] is a popular distribution of the Linux operating system, and > we wish to include the latest version of ActiveMQ Artemis [2] in our OS. > Fedora only contains Free and Open Source licensed works. > Your project is licensed under Apache License Version 2, > but your code pulls in code from json.org under Douglas Crockford’s bad > licence [3], and is non-free [4]. > Such usage restriction makes the license incompatible with The Open Source > Definition and > The Free Software Definition. Because ActiveMQ Artemis binary distribution > includes this software, > it effectively becomes proprietary software itself. > You may also comment that the json.org license is valid for You [5] but for > many Linux distributions it is not acceptable. > Hoping in the future to be able to use ActiveMQ Artemis in Fedora, without > having to run into this problem. > Please try to replace it with one of the many free alternatives. > Regards > [1] https://fedoraproject.org/wiki/Fedora_Project_Wiki > [2] https://bugzilla.redhat.com/show_bug.cgi?id=1343063 > [3] > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONArray.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONException.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONObject.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONString.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONTokener.java > [4] > https://wiki.debian.org/qa.debian.org/jsonevil > http://www.sonatype.com/people/2012/03/use-json-well-youd-better-not-be-evil/ > http://tanguy.ortolo.eu/blog/article46/json-license > [5] http://www.apache.org/legal/resolved.html#json -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARTEMIS-565) Artemis use no free json.org
[ https://issues.apache.org/jira/browse/ARTEMIS-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394470#comment-15394470 ] ASF subversion and git services commented on ARTEMIS-565: - Commit 76938fe44a98eb802a707ae630cc4f2d3008085e in activemq-artemis's branch refs/heads/master from Clebert Suconic [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=76938fe ] ARTEMIS-565 more tweaks on the JSON replacement > Artemis use no free json.org > > > Key: ARTEMIS-565 > URL: https://issues.apache.org/jira/browse/ARTEMIS-565 > Project: ActiveMQ Artemis > Issue Type: Bug > Environment: Linux all >Reporter: gil cattaneo > > Hi, > Fedora [1] is a popular distribution of the Linux operating system, and > we wish to include the latest version of ActiveMQ Artemis [2] in our OS. > Fedora only contains Free and Open Source licensed works. > Your project is licensed under Apache License Version 2, > but your code pulls in code from json.org under Douglas Crockford’s bad > licence [3], and is non-free [4]. > Such usage restriction makes the license incompatible with The Open Source > Definition and > The Free Software Definition. Because ActiveMQ Artemis binary distribution > includes this software, > it effectively becomes proprietary software itself. > You may also comment that the json.org license is valid for You [5] but for > many Linux distributions it is not acceptable. > Hoping in the future to be able to use ActiveMQ Artemis in Fedora, without > having to run into this problem. > Please try to replace it with one of the many free alternatives. > Regards > [1] https://fedoraproject.org/wiki/Fedora_Project_Wiki > [2] https://bugzilla.redhat.com/show_bug.cgi?id=1343063 > [3] > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONArray.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONException.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONObject.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONString.java > ./artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/json/JSONTokener.java > [4] > https://wiki.debian.org/qa.debian.org/jsonevil > http://www.sonatype.com/people/2012/03/use-json-well-youd-better-not-be-evil/ > http://tanguy.ortolo.eu/blog/article46/json-license > [5] http://www.apache.org/legal/resolved.html#json -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-6375) Add non-blocking subscription statistics to KahaDB
[ https://issues.apache.org/jira/browse/AMQ-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394529#comment-15394529 ] ASF subversion and git services commented on AMQ-6375: -- Commit 37da75e0e48800317d1a36d7d0b8adab0d2b06b7 in activemq's branch refs/heads/master from [~tabish121] [ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=37da75e ] https://issues.apache.org/jira/browse/AMQ-6375 Quick fix the build after broken by previous commit on this issue, no actual stats tracking implemented in LevelDB by this commit. > Add non-blocking subscription statistics to KahaDB > -- > > Key: AMQ-6375 > URL: https://issues.apache.org/jira/browse/AMQ-6375 > Project: ActiveMQ > Issue Type: New Feature > Components: Broker, KahaDB >Affects Versions: 5.13.4 >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon > Fix For: 5.14.0 > > > Currently KahaDB TopicMessageStore supports returning the messageCount and > messageSize for subscription but this requires locking the index and > iterating to compute the information. I have a use case where I query this > information regularly for the status of the broker and the performance takes > a hit because of the locking. > There should be an option to enable statistics counters to keep track of this > information so that it can be queried without locking, such like the store > currently tracks the total count and size but for each subscription also. > This should be disabled by default because there will be some overhead for > computing the metrics if there are a lot of subscriptions in the store. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ARTEMIS-646) Add a JMX attribute for the number of expired messages
[
https://issues.apache.org/jira/browse/ARTEMIS-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Bertram updated ARTEMIS-646:
---
Fix Version/s: 1.4.0
> Add a JMX attribute for the number of expired messages
> --
>
> Key: ARTEMIS-646
> URL: https://issues.apache.org/jira/browse/ARTEMIS-646
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Affects Versions: 1.3.0
>Reporter: Lionel Cons
>Assignee: Justin Bertram
> Fix For: 1.4.0
>
>
> ActiveMQ 5.x exposes in JMX an {{ExpiredCount}} attribute representing the
> number of messages that have been removed from the destination because they
> have expired. This works both for queues and for topics.
> This information is missing from Artemis, could it please be added?
> Ideally this attribute should appear both in Core and in JMS, like
> {{MessagesAdded}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (ARTEMIS-646) Add a JMX attribute for the number of expired messages
[
https://issues.apache.org/jira/browse/ARTEMIS-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Bertram reassigned ARTEMIS-646:
--
Assignee: Justin Bertram
> Add a JMX attribute for the number of expired messages
> --
>
> Key: ARTEMIS-646
> URL: https://issues.apache.org/jira/browse/ARTEMIS-646
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Lionel Cons
>Assignee: Justin Bertram
>
> ActiveMQ 5.x exposes in JMX an {{ExpiredCount}} attribute representing the
> number of messages that have been removed from the destination because they
> have expired. This works both for queues and for topics.
> This information is missing from Artemis, could it please be added?
> Ideally this attribute should appear both in Core and in JMS, like
> {{MessagesAdded}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (ARTEMIS-646) Add a JMX attribute for the number of expired messages
[
https://issues.apache.org/jira/browse/ARTEMIS-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Bertram updated ARTEMIS-646:
---
Affects Version/s: 1.3.0
> Add a JMX attribute for the number of expired messages
> --
>
> Key: ARTEMIS-646
> URL: https://issues.apache.org/jira/browse/ARTEMIS-646
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Affects Versions: 1.3.0
>Reporter: Lionel Cons
>Assignee: Justin Bertram
> Fix For: 1.4.0
>
>
> ActiveMQ 5.x exposes in JMX an {{ExpiredCount}} attribute representing the
> number of messages that have been removed from the destination because they
> have expired. This works both for queues and for topics.
> This information is missing from Artemis, could it please be added?
> Ideally this attribute should appear both in Core and in JMS, like
> {{MessagesAdded}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ARTEMIS-646) Add a JMX attribute for the number of expired messages
[
https://issues.apache.org/jira/browse/ARTEMIS-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394563#comment-15394563
]
ASF GitHub Bot commented on ARTEMIS-646:
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/671
ARTEMIS-646 track expired msg count on queue
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-646
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/671.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #671
commit 32abe61876d388b6d1208de8f74968d86be24872
Author: jbertram
Date: 2016-07-26T21:06:01Z
ARTEMIS-646 track expired msg count on queue
> Add a JMX attribute for the number of expired messages
> --
>
> Key: ARTEMIS-646
> URL: https://issues.apache.org/jira/browse/ARTEMIS-646
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Affects Versions: 1.3.0
>Reporter: Lionel Cons
>Assignee: Justin Bertram
> Fix For: 1.4.0
>
>
> ActiveMQ 5.x exposes in JMX an {{ExpiredCount}} attribute representing the
> number of messages that have been removed from the destination because they
> have expired. This works both for queues and for topics.
> This information is missing from Artemis, could it please be added?
> Ideally this attribute should appear both in Core and in JMS, like
> {{MessagesAdded}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ARTEMIS-646) Add a JMX attribute for the number of expired messages
[
https://issues.apache.org/jira/browse/ARTEMIS-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394666#comment-15394666
]
ASF GitHub Bot commented on ARTEMIS-646:
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/671
> Add a JMX attribute for the number of expired messages
> --
>
> Key: ARTEMIS-646
> URL: https://issues.apache.org/jira/browse/ARTEMIS-646
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Affects Versions: 1.3.0
>Reporter: Lionel Cons
>Assignee: Justin Bertram
> Fix For: 1.4.0
>
>
> ActiveMQ 5.x exposes in JMX an {{ExpiredCount}} attribute representing the
> number of messages that have been removed from the destination because they
> have expired. This works both for queues and for topics.
> This information is missing from Artemis, could it please be added?
> Ideally this attribute should appear both in Core and in JMS, like
> {{MessagesAdded}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ARTEMIS-646) Add a JMX attribute for the number of expired messages
[
https://issues.apache.org/jira/browse/ARTEMIS-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394664#comment-15394664
]
ASF subversion and git services commented on ARTEMIS-646:
-
Commit 32abe61876d388b6d1208de8f74968d86be24872 in activemq-artemis's branch
refs/heads/master from [~jbertram]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=32abe61 ]
ARTEMIS-646 track expired msg count on queue
> Add a JMX attribute for the number of expired messages
> --
>
> Key: ARTEMIS-646
> URL: https://issues.apache.org/jira/browse/ARTEMIS-646
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Affects Versions: 1.3.0
>Reporter: Lionel Cons
>Assignee: Justin Bertram
> Fix For: 1.4.0
>
>
> ActiveMQ 5.x exposes in JMX an {{ExpiredCount}} attribute representing the
> number of messages that have been removed from the destination because they
> have expired. This works both for queues and for topics.
> This information is missing from Artemis, could it please be added?
> Ideally this attribute should appear both in Core and in JMS, like
> {{MessagesAdded}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (ARTEMIS-646) Add a JMX attribute for the number of expired messages
[
https://issues.apache.org/jira/browse/ARTEMIS-646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Bertram resolved ARTEMIS-646.
Resolution: Fixed
> Add a JMX attribute for the number of expired messages
> --
>
> Key: ARTEMIS-646
> URL: https://issues.apache.org/jira/browse/ARTEMIS-646
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Affects Versions: 1.3.0
>Reporter: Lionel Cons
>Assignee: Justin Bertram
> Fix For: 1.4.0
>
>
> ActiveMQ 5.x exposes in JMX an {{ExpiredCount}} attribute representing the
> number of messages that have been removed from the destination because they
> have expired. This works both for queues and for topics.
> This information is missing from Artemis, could it please be added?
> Ideally this attribute should appear both in Core and in JMS, like
> {{MessagesAdded}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (ARTEMIS-647) Add a JMX attribute for the number of messages sent to the DLQ
[ https://issues.apache.org/jira/browse/ARTEMIS-647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram reassigned ARTEMIS-647: -- Assignee: Justin Bertram > Add a JMX attribute for the number of messages sent to the DLQ > -- > > Key: ARTEMIS-647 > URL: https://issues.apache.org/jira/browse/ARTEMIS-647 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Lionel Cons >Assignee: Justin Bertram > > Similarly to the expired messages (see ARTEMIS-646), messages that fail to be > delivered may end up in the DLQ. In this case, it would be very useful to > monitor these unsuccessful deliveries via matching JMX attributes. > Could you please add (ideally to Core and JMS) a JMX attribute counting the > number of messages that have been removed from the destination to be put in a > DLQ? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
