[jira] [Commented] (ARTEMIS-1572) UTF-8 Encoding is not translating ASCII edge cases correctly

2018-01-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309100#comment-16309100
 ] 

ASF GitHub Bot commented on ARTEMIS-1572:
-

Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/1739
  
@franz1981 can you re-open this? I got the PR number wrong while doing 
another merge. 
Sorry about that.


> UTF-8 Encoding is not translating ASCII edge cases correctly 
> -
>
> Key: ARTEMIS-1572
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1572
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>Priority: Minor
>
> The current implementation of UTF encoding/decoding isn't translating 
> correctly ASCII edge cases (ie bytes 0 and 127).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1406) FindBugs: impossible instanceof in exception handler in MappedSequentialFile.java

2018-01-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309095#comment-16309095
 ] 

ASF GitHub Bot commented on ARTEMIS-1406:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1745


> FindBugs: impossible instanceof in exception handler in 
> MappedSequentialFile.java
> -
>
> Key: ARTEMIS-1406
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1406
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.4.0
>Reporter: Jiri Daněk
>
> {noformat}
> 360   @Override
> 361   public void renameTo(String newFileName) throws Exception {
> 362  try {
> 363 close();
> 364  } catch (Exception e) {
>   
> CID 1418586 (#1 of 1): BC: Bad casts of object references 
> (FB.BC_IMPOSSIBLE_INSTANCEOF)
> 1. defect: instanceof will always return false, since a RuntimeException 
> can't be a java.io.IOException.
> 365 if (e instanceof IOException) {
> 366factory.onIOError(new ActiveMQIOErrorException(e.getMessage(), 
> e), e.getMessage(), this);
> 367 }
> 368 throw e;
> 369  }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1406) FindBugs: impossible instanceof in exception handler in MappedSequentialFile.java

2018-01-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309094#comment-16309094
 ] 

ASF GitHub Bot commented on ARTEMIS-1406:
-

Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/1745
  
I think I got the pr# wrong.


> FindBugs: impossible instanceof in exception handler in 
> MappedSequentialFile.java
> -
>
> Key: ARTEMIS-1406
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1406
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.4.0
>Reporter: Jiri Daněk
>
> {noformat}
> 360   @Override
> 361   public void renameTo(String newFileName) throws Exception {
> 362  try {
> 363 close();
> 364  } catch (Exception e) {
>   
> CID 1418586 (#1 of 1): BC: Bad casts of object references 
> (FB.BC_IMPOSSIBLE_INSTANCEOF)
> 1. defect: instanceof will always return false, since a RuntimeException 
> can't be a java.io.IOException.
> 365 if (e instanceof IOException) {
> 366factory.onIOError(new ActiveMQIOErrorException(e.getMessage(), 
> e), e.getMessage(), this);
> 367 }
> 368 throw e;
> 369  }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1406) FindBugs: impossible instanceof in exception handler in MappedSequentialFile.java

2018-01-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309073#comment-16309073
 ] 

ASF GitHub Bot commented on ARTEMIS-1406:
-

Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/1745
  
@jbertram I've done the merge, how can I close this PR?


> FindBugs: impossible instanceof in exception handler in 
> MappedSequentialFile.java
> -
>
> Key: ARTEMIS-1406
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1406
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.4.0
>Reporter: Jiri Daněk
>
> {noformat}
> 360   @Override
> 361   public void renameTo(String newFileName) throws Exception {
> 362  try {
> 363 close();
> 364  } catch (Exception e) {
>   
> CID 1418586 (#1 of 1): BC: Bad casts of object references 
> (FB.BC_IMPOSSIBLE_INSTANCEOF)
> 1. defect: instanceof will always return false, since a RuntimeException 
> can't be a java.io.IOException.
> 365 if (e instanceof IOException) {
> 366factory.onIOError(new ActiveMQIOErrorException(e.getMessage(), 
> e), e.getMessage(), this);
> 367 }
> 368 throw e;
> 369  }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1572) UTF-8 Encoding is not translating ASCII edge cases correctly

2018-01-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309070#comment-16309070
 ] 

ASF GitHub Bot commented on ARTEMIS-1572:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1739


> UTF-8 Encoding is not translating ASCII edge cases correctly 
> -
>
> Key: ARTEMIS-1572
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1572
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>Priority: Minor
>
> The current implementation of UTF encoding/decoding isn't translating 
> correctly ASCII edge cases (ie bytes 0 and 127).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1406) FindBugs: impossible instanceof in exception handler in MappedSequentialFile.java

2018-01-02 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309069#comment-16309069
 ] 

ASF subversion and git services commented on ARTEMIS-1406:
--

Commit 94b53c67c0e346d9fa89fa652ff5aaa64ec60415 in activemq-artemis's branch 
refs/heads/master from [~jbertram]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=94b53c6 ]

ARTEMIS-1406 removing impossible instanceof


> FindBugs: impossible instanceof in exception handler in 
> MappedSequentialFile.java
> -
>
> Key: ARTEMIS-1406
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1406
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.4.0
>Reporter: Jiri Daněk
>
> {noformat}
> 360   @Override
> 361   public void renameTo(String newFileName) throws Exception {
> 362  try {
> 363 close();
> 364  } catch (Exception e) {
>   
> CID 1418586 (#1 of 1): BC: Bad casts of object references 
> (FB.BC_IMPOSSIBLE_INSTANCEOF)
> 1. defect: instanceof will always return false, since a RuntimeException 
> can't be a java.io.IOException.
> 365 if (e instanceof IOException) {
> 366factory.onIOError(new ActiveMQIOErrorException(e.getMessage(), 
> e), e.getMessage(), this);
> 367 }
> 368 throw e;
> 369  }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1406) FindBugs: impossible instanceof in exception handler in MappedSequentialFile.java

2018-01-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309027#comment-16309027
 ] 

ASF GitHub Bot commented on ARTEMIS-1406:
-

Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/1745
  
This one seems obvious. Let me handle this merge pls. :)


> FindBugs: impossible instanceof in exception handler in 
> MappedSequentialFile.java
> -
>
> Key: ARTEMIS-1406
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1406
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.4.0
>Reporter: Jiri Daněk
>
> {noformat}
> 360   @Override
> 361   public void renameTo(String newFileName) throws Exception {
> 362  try {
> 363 close();
> 364  } catch (Exception e) {
>   
> CID 1418586 (#1 of 1): BC: Bad casts of object references 
> (FB.BC_IMPOSSIBLE_INSTANCEOF)
> 1. defect: instanceof will always return false, since a RuntimeException 
> can't be a java.io.IOException.
> 365 if (e instanceof IOException) {
> 366factory.onIOError(new ActiveMQIOErrorException(e.getMessage(), 
> e), e.getMessage(), this);
> 367 }
> 368 throw e;
> 369  }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1406) FindBugs: impossible instanceof in exception handler in MappedSequentialFile.java

2018-01-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308443#comment-16308443
 ] 

ASF GitHub Bot commented on ARTEMIS-1406:
-

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/1745

ARTEMIS-1406 removing impossible instanceof



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1406

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1745.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1745


commit 3bedd42ea3844d3a018731a009adea32170d7471
Author: Justin Bertram 
Date:   2017-09-29T20:21:37Z

ARTEMIS-1406 removing impossible instanceof




> FindBugs: impossible instanceof in exception handler in 
> MappedSequentialFile.java
> -
>
> Key: ARTEMIS-1406
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1406
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.4.0
>Reporter: Jiri Daněk
>
> {noformat}
> 360   @Override
> 361   public void renameTo(String newFileName) throws Exception {
> 362  try {
> 363 close();
> 364  } catch (Exception e) {
>   
> CID 1418586 (#1 of 1): BC: Bad casts of object references 
> (FB.BC_IMPOSSIBLE_INSTANCEOF)
> 1. defect: instanceof will always return false, since a RuntimeException 
> can't be a java.io.IOException.
> 365 if (e instanceof IOException) {
> 366factory.onIOError(new ActiveMQIOErrorException(e.getMessage(), 
> e), e.getMessage(), this);
> 367 }
> 368 throw e;
> 369  }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (ARTEMIS-1553) JSON values all being converted to String

2018-01-02 Thread Justin Bertram (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram resolved ARTEMIS-1553.
-
Resolution: Fixed

> JSON values all being converted to String
> -
>
> Key: ARTEMIS-1553
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1553
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (ARTEMIS-1562) Refactor example documentation

2018-01-02 Thread Justin Bertram (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram resolved ARTEMIS-1562.
-
   Resolution: Fixed
Fix Version/s: 2.5.0

> Refactor example documentation
> --
>
> Key: ARTEMIS-1562
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1562
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.4.0
>Reporter: Justin Bertram
>Assignee: Justin Bertram
> Fix For: 2.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (ARTEMIS-1576) Sending AMQP message to autocreating multicast address creates anycast address

2018-01-02 Thread Johan (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308427#comment-16308427
 ] 

Johan edited comment on ARTEMIS-1576 at 1/2/18 5:52 PM:


Seems to be similar to https://issues.apache.org/jira/browse/ARTEMIS-918 , 
https://issues.apache.org/jira/browse/ARTEMIS-1352 and 
https://issues.jboss.org/browse/ENTMQBR-519


was (Author: johan1):
Seems to be similar to https://issues.apache.org/jira/browse/ARTEMIS-1352 and 
https://issues.jboss.org/browse/ENTMQBR-519

> Sending AMQP message to autocreating multicast address creates anycast address
> --
>
> Key: ARTEMIS-1576
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1576
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 2.4.0
>Reporter: Johan
> Attachments: ArtemisTest.java, pom.xml
>
>
> When publishing a message to an autocreated multicast address where no 
> consumer is subscribed to yet, an anycast address is created. Resulting in 
> "Address XYZ is not configured for topic support"
> I tested this with the latest QPID JMS Client 0.2.8 and the latest Artemis 
> 2.5.0-SNAPSHOT.
> I attached a test class that reproduces the issue.
> {noformat}
> Exception in thread "main" javax.jms.JMSRuntimeException: Address 
> topics.myTopic is not configured for topic support [condition = 
> amqp:illegal-state]
>   at 
> org.apache.qpid.jms.exceptions.JmsExceptionSupport.createRuntimeException(JmsExceptionSupport.java:207)
>   at org.apache.qpid.jms.JmsContext.createConsumer(JmsContext.java:314)
>   at ArtemisTest.main(ArtemisTest.java:93)
> Caused by: javax.jms.JMSException: Address topics.myTopic is not configured 
> for topic support [condition = amqp:illegal-state]
>   at 
> org.apache.qpid.jms.provider.amqp.AmqpSupport.convertToException(AmqpSupport.java:164)
>   at 
> org.apache.qpid.jms.provider.amqp.AmqpSupport.convertToException(AmqpSupport.java:117)
>   at 
> org.apache.qpid.jms.provider.amqp.builders.AmqpResourceBuilder.handleClosed(AmqpResourceBuilder.java:185)
>   at 
> org.apache.qpid.jms.provider.amqp.builders.AmqpResourceBuilder.processRemoteClose(AmqpResourceBuilder.java:129)
>   at 
> org.apache.qpid.jms.provider.amqp.AmqpProvider.processUpdates(AmqpProvider.java:906)
>   at 
> org.apache.qpid.jms.provider.amqp.AmqpProvider.access$1800(AmqpProvider.java:102)
>   at 
> org.apache.qpid.jms.provider.amqp.AmqpProvider$17.run(AmqpProvider.java:792)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
>   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>   at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (ARTEMIS-1576) Sending AMQP message to autocreating multicast address creates anycast address

2018-01-02 Thread Johan (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308427#comment-16308427
 ] 

Johan edited comment on ARTEMIS-1576 at 1/2/18 5:50 PM:


Seems to be similar to https://issues.apache.org/jira/browse/ARTEMIS-1352 and 
https://issues.jboss.org/browse/ENTMQBR-519


was (Author: johan1):
Seems to be similar to https://issues.apache.org/jira/browse/ARTEMIS-1352

> Sending AMQP message to autocreating multicast address creates anycast address
> --
>
> Key: ARTEMIS-1576
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1576
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 2.4.0
>Reporter: Johan
> Attachments: ArtemisTest.java, pom.xml
>
>
> When publishing a message to an autocreated multicast address where no 
> consumer is subscribed to yet, an anycast address is created. Resulting in 
> "Address XYZ is not configured for topic support"
> I tested this with the latest QPID JMS Client 0.2.8 and the latest Artemis 
> 2.5.0-SNAPSHOT.
> I attached a test class that reproduces the issue.
> {noformat}
> Exception in thread "main" javax.jms.JMSRuntimeException: Address 
> topics.myTopic is not configured for topic support [condition = 
> amqp:illegal-state]
>   at 
> org.apache.qpid.jms.exceptions.JmsExceptionSupport.createRuntimeException(JmsExceptionSupport.java:207)
>   at org.apache.qpid.jms.JmsContext.createConsumer(JmsContext.java:314)
>   at ArtemisTest.main(ArtemisTest.java:93)
> Caused by: javax.jms.JMSException: Address topics.myTopic is not configured 
> for topic support [condition = amqp:illegal-state]
>   at 
> org.apache.qpid.jms.provider.amqp.AmqpSupport.convertToException(AmqpSupport.java:164)
>   at 
> org.apache.qpid.jms.provider.amqp.AmqpSupport.convertToException(AmqpSupport.java:117)
>   at 
> org.apache.qpid.jms.provider.amqp.builders.AmqpResourceBuilder.handleClosed(AmqpResourceBuilder.java:185)
>   at 
> org.apache.qpid.jms.provider.amqp.builders.AmqpResourceBuilder.processRemoteClose(AmqpResourceBuilder.java:129)
>   at 
> org.apache.qpid.jms.provider.amqp.AmqpProvider.processUpdates(AmqpProvider.java:906)
>   at 
> org.apache.qpid.jms.provider.amqp.AmqpProvider.access$1800(AmqpProvider.java:102)
>   at 
> org.apache.qpid.jms.provider.amqp.AmqpProvider$17.run(AmqpProvider.java:792)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
>   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>   at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1576) Sending AMQP message to autocreating multicast address creates anycast address

2018-01-02 Thread Johan (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308427#comment-16308427
 ] 

Johan commented on ARTEMIS-1576:


Seems to be similar to https://issues.apache.org/jira/browse/ARTEMIS-1352

> Sending AMQP message to autocreating multicast address creates anycast address
> --
>
> Key: ARTEMIS-1576
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1576
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 2.4.0
>Reporter: Johan
> Attachments: ArtemisTest.java, pom.xml
>
>
> When publishing a message to an autocreated multicast address where no 
> consumer is subscribed to yet, an anycast address is created. Resulting in 
> "Address XYZ is not configured for topic support"
> I tested this with the latest QPID JMS Client 0.2.8 and the latest Artemis 
> 2.5.0-SNAPSHOT.
> I attached a test class that reproduces the issue.
> {noformat}
> Exception in thread "main" javax.jms.JMSRuntimeException: Address 
> topics.myTopic is not configured for topic support [condition = 
> amqp:illegal-state]
>   at 
> org.apache.qpid.jms.exceptions.JmsExceptionSupport.createRuntimeException(JmsExceptionSupport.java:207)
>   at org.apache.qpid.jms.JmsContext.createConsumer(JmsContext.java:314)
>   at ArtemisTest.main(ArtemisTest.java:93)
> Caused by: javax.jms.JMSException: Address topics.myTopic is not configured 
> for topic support [condition = amqp:illegal-state]
>   at 
> org.apache.qpid.jms.provider.amqp.AmqpSupport.convertToException(AmqpSupport.java:164)
>   at 
> org.apache.qpid.jms.provider.amqp.AmqpSupport.convertToException(AmqpSupport.java:117)
>   at 
> org.apache.qpid.jms.provider.amqp.builders.AmqpResourceBuilder.handleClosed(AmqpResourceBuilder.java:185)
>   at 
> org.apache.qpid.jms.provider.amqp.builders.AmqpResourceBuilder.processRemoteClose(AmqpResourceBuilder.java:129)
>   at 
> org.apache.qpid.jms.provider.amqp.AmqpProvider.processUpdates(AmqpProvider.java:906)
>   at 
> org.apache.qpid.jms.provider.amqp.AmqpProvider.access$1800(AmqpProvider.java:102)
>   at 
> org.apache.qpid.jms.provider.amqp.AmqpProvider$17.run(AmqpProvider.java:792)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
>   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>   at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (ARTEMIS-1576) Sending AMQP message to autocreating multicast address creates anycast address

2018-01-02 Thread Johan (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Johan updated ARTEMIS-1576:
---
Summary: Sending AMQP message to autocreating multicast address creates 
anycast address  (was: Sending AMQP message to autocreated multicast address 
creates anycast address)

> Sending AMQP message to autocreating multicast address creates anycast address
> --
>
> Key: ARTEMIS-1576
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1576
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP
>Affects Versions: 2.4.0
>Reporter: Johan
> Attachments: ArtemisTest.java, pom.xml
>
>
> When publishing a message to an autocreated multicast address where no 
> consumer is subscribed to yet, an anycast address is created. Resulting in 
> "Address XYZ is not configured for topic support"
> I tested this with the latest QPID JMS Client 0.2.8 and the latest Artemis 
> 2.5.0-SNAPSHOT.
> I attached a test class that reproduces the issue.
> {noformat}
> Exception in thread "main" javax.jms.JMSRuntimeException: Address 
> topics.myTopic is not configured for topic support [condition = 
> amqp:illegal-state]
>   at 
> org.apache.qpid.jms.exceptions.JmsExceptionSupport.createRuntimeException(JmsExceptionSupport.java:207)
>   at org.apache.qpid.jms.JmsContext.createConsumer(JmsContext.java:314)
>   at ArtemisTest.main(ArtemisTest.java:93)
> Caused by: javax.jms.JMSException: Address topics.myTopic is not configured 
> for topic support [condition = amqp:illegal-state]
>   at 
> org.apache.qpid.jms.provider.amqp.AmqpSupport.convertToException(AmqpSupport.java:164)
>   at 
> org.apache.qpid.jms.provider.amqp.AmqpSupport.convertToException(AmqpSupport.java:117)
>   at 
> org.apache.qpid.jms.provider.amqp.builders.AmqpResourceBuilder.handleClosed(AmqpResourceBuilder.java:185)
>   at 
> org.apache.qpid.jms.provider.amqp.builders.AmqpResourceBuilder.processRemoteClose(AmqpResourceBuilder.java:129)
>   at 
> org.apache.qpid.jms.provider.amqp.AmqpProvider.processUpdates(AmqpProvider.java:906)
>   at 
> org.apache.qpid.jms.provider.amqp.AmqpProvider.access$1800(AmqpProvider.java:102)
>   at 
> org.apache.qpid.jms.provider.amqp.AmqpProvider$17.run(AmqpProvider.java:792)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
>   at 
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>   at java.lang.Thread.run(Thread.java:748)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1577) Address-settings policies aren't being applied when using an older version of JMS client

2018-01-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308024#comment-16308024
 ] 

ASF GitHub Bot commented on ARTEMIS-1577:
-

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1744
  
This breaks anyone actually wanting to name their addresses with prefixes. 


> Address-settings policies aren't being applied when using an older version of 
> JMS client
> 
>
> Key: ARTEMIS-1577
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1577
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.4.0
>Reporter: Shailendra Kumar singh
> Attachments: broker.xml
>
>
> Address-settings policies aren't being applied when using an older version of 
> JMS client.
> Example:-
> #broker.xml
> {code:java}
> 
> FAIL
> 10
>  
> {code}
> When using JMS client(artemis-jms-client) version 1.5.5, Address-settings 
> policies are not applied.
> When using latest client version, it works as expected.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1577) Address-settings policies aren't being applied when using an older version of JMS client

2018-01-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307891#comment-16307891
 ] 

ASF GitHub Bot commented on ARTEMIS-1577:
-

GitHub user shailendra14k opened a pull request:

https://github.com/apache/activemq-artemis/pull/1744

[ARTEMIS-1577] Address-settings policies aren't being applied when using an 
older version of JMS client

JIRA :-  https://issues.apache.org/jira/browse/ARTEMIS-1577

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shailendra14k/activemq-artemis ARTEMIS-1577

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1744.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1744


commit 19390150fee5ee716a67ffa707b65f3291a07ed8
Author: Shailendra Kumar Singh 
Date:   2018-01-02T11:07:13Z

[ARTEMIS-1577] Address-settings policies aren't being applied when using an 
older version of JMS client




> Address-settings policies aren't being applied when using an older version of 
> JMS client
> 
>
> Key: ARTEMIS-1577
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1577
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.4.0
>Reporter: Shailendra Kumar singh
> Attachments: broker.xml
>
>
> Address-settings policies aren't being applied when using an older version of 
> JMS client.
> Example:-
> #broker.xml
> {code:java}
> 
> FAIL
> 10
>  
> {code}
> When using JMS client(artemis-jms-client) version 1.5.5, Address-settings 
> policies are not applied.
> When using latest client version, it works as expected.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1577) Address-settings policies aren't being applied when using an older version of JMS client

2018-01-02 Thread Shailendra Kumar singh (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307828#comment-16307828
 ] 

Shailendra Kumar singh commented on ARTEMIS-1577:
-

Issue seem due to the old queue prefix  *"jms.queue."*
 
When getting the ProducerCredits [1], prefix is removed before getting the 
store from PagingManager.
{code:java}
public void requestProducerCredits(SimpleString address, final int credits) 
throws Exception {
  final SimpleString addr = removePrefix(address);
  PagingStore store = server.getPagingManager().getPageStore(addr);

  if (!store.checkMemory(new Runnable() {
 @Override
 public void run() {
callback.sendProducerCreditsMessage(credits, address);
 }
  })) {
 callback.sendProducerCreditsFailMessage(credits, address);
  }
   }
{code}

However, while updating/inserting [2] a store address prefix is not removed 
which creates an additional store with key using jms.queue.

{code:java}
 private void setPagingStore(final Message message) throws Exception {
  PagingStore store = 
pagingManager.getPageStore(message.getAddressSimpleString());

  message.setContext(store);
   }
{code}

[1] 
https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java#L1412-L1424

[2] 
https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java#L1043-L1047

> Address-settings policies aren't being applied when using an older version of 
> JMS client
> 
>
> Key: ARTEMIS-1577
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1577
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.4.0
>Reporter: Shailendra Kumar singh
> Attachments: broker.xml
>
>
> Address-settings policies aren't being applied when using an older version of 
> JMS client.
> Example:-
> #broker.xml
> {code:java}
> 
> FAIL
> 10
>  
> {code}
> When using JMS client(artemis-jms-client) version 1.5.5, Address-settings 
> policies are not applied.
> When using latest client version, it works as expected.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1548) Support CRL

2018-01-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307818#comment-16307818
 ] 

ASF GitHub Bot commented on ARTEMIS-1548:
-

Github user Skiler commented on the issue:

https://github.com/apache/activemq-artemis/pull/1715
  
Hi @jbertram 

Do I need to do anything else?

Thanks in advance


> Support CRL
> ---
>
> Key: ARTEMIS-1548
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1548
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ARTEMIS-1577) Address-settings policies aren't being applied when using an older version of JMS client

2018-01-02 Thread Shailendra Kumar singh (JIRA) 
Shailendra Kumar singh created ARTEMIS-1577:
---

 Summary: Address-settings policies aren't being applied when using 
an older version of JMS client
 Key: ARTEMIS-1577
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1577
 Project: ActiveMQ Artemis
  Issue Type: Bug
  Components: Broker
Affects Versions: 2.4.0
Reporter: Shailendra Kumar singh
 Attachments: broker.xml

Address-settings policies aren't being applied when using an older version of 
JMS client.

Example:-

#broker.xml

{code:java}

FAIL
10
 
{code}

When using JMS client(artemis-jms-client) version 1.5.5, Address-settings 
policies are not applied.

When using latest client version, it works as expected.









--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (ARTEMIS-1565) A Replica should retry a quorum vote

2018-01-02 Thread Andy Taylor (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy Taylor resolved ARTEMIS-1565.
--
   Resolution: Fixed
Fix Version/s: 2.5.0

> A Replica should retry a quorum vote
> 
>
> Key: ARTEMIS-1565
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1565
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Reporter: Andy Taylor
>Assignee: Andy Taylor
> Fix For: 2.5.0
>
>
> When a replica detects failure of the master it will vote for quorum. 
> Currently if that fails it restarts as a backup. What should  happen is t hat 
> it should keep retrying the vote until either it gains quorum or it detects 
> the master is still live



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)