[jira] [Commented] (ARTEMIS-2172) Broker drops connection during throughput test
[
https://issues.apache.org/jira/browse/ARTEMIS-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750820#comment-16750820
]
Simon Chalmers commented on ARTEMIS-2172:
-
Hi [[~clebertsuconic] my colleague Rachel will be taking over this testing and
analysis work now on the Artemis from our side.
She will jump in here shortly and update the JIRA accordingly.
> Broker drops connection during throughput test
> --
>
> Key: ARTEMIS-2172
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2172
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
>Affects Versions: 2.7.0, 2.6.3
> Environment: * Host OS: Linux node1 4.9.0-8-amd64 #1 SMP Debian
> 4.9.110-3+deb9u6 (2018-10-08) x86_64 GNU/Linux
> * Dotnet2.1 SDK installed as per these instructions:
> https://www.microsoft.com/net/download/linux-package-manager/debian9/sdk-current
> * Test client attached, to run the test: dotnet AmqpBrokerThroughputTest.dll
> -h -u -p , e.g. dotnet AmqpBrokerThroughputTest.dll
> -h 172.31.0.175 -u mimqadmin -p dogcat123
> * Broker.xml attached.
>Reporter: Simon Chalmers
>Priority: Major
> Attachments: AmqpBrokerThroughputTest.zip, broker.xml
>
>
> When running a continual test against a broker setup as a master-slave, after
> an arbitrary length of time, the test client disconnects and stops working.
> The only message thrown in the artemis.log file is:
> {{2018-10-31 09:32:07,368 WARN [org.apache.activemq.artemis.core.client]
> AMQ212037: Connection failure has been detected: AMQ229014: Did not receive
> data from /172.31.15.214:38325 within the 60,000ms connection TTL. The
> connection will now be closed. [code=CONNECTION_TIMEDOUT]
> 2018-10-31 09:32:07,370 WARN [org.apache.activemq.artemis.core.server]
> AMQ222061: Client connection failed, clearing up resources for session
> 4610a425-dcbf-11e8-b83f-0284a4757140
> 2018-10-31 09:32:07,371 WARN [org.apache.activemq.artemis.core.server]
> AMQ222107: Cleared up resources for session
> 4610a425-dcbf-11e8-b83f-0284a4757140}}
> I wondered if this issue (https://issues.apache.org/jira/browse/ARTEMIS-2146)
> was related, but I tried the test against 2.6.x and the same result happened.
> I've tried it against the current version 2.6.3 and the 2.6.x master in
> github.
> Question: Is there more information available to see why a connection failed?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2113) When AMQP links are opened and closed in quick succession, Artemis doesn’t always respond with attach/detach frames confirming the opening/closing of the links
[
https://issues.apache.org/jira/browse/ARTEMIS-2113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750821#comment-16750821
]
Simon Chalmers commented on ARTEMIS-2113:
-
HI [~clebertsuconic] - my colleague Rachel will be taking over this testing and
analysis work now on the Artemis from our side.
She will jump in here shortly and update the JIRA accordingly.
> When AMQP links are opened and closed in quick succession, Artemis doesn’t
> always respond with attach/detach frames confirming the opening/closing of
> the links
> ---
>
> Key: ARTEMIS-2113
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2113
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
>Affects Versions: 2.6.3
> Environment: This test was done in .NET using the Amqp.Net Lite
> library 2.1.4 (which is the latest version).
>Reporter: Simon Chalmers
>Priority: Major
> Attachments: ArtemisTest.zip, artemis-2.6.3.log, artemis-2.7.0.log,
> dotnet-artemis-2.6.3.txt, dotnet-artemis-2.7.0.txt
>
>
> A trace of a message exchange with Artemis where this has occurred is below.
> The lines highlighted in yellow show opening and then closing two AMQP links,
> but Artemis doesn’t respond after that with its own attach/detach frames,
> which acknowledge the opening/closing of those links. The lines highlighted
> in green are heartbeat frames sent to Artemis, sent every 15 seconds, which
> illustrates that one minute passed without receiving the attach/detach frames
> from Artemis.
> SEND AMQP 3 1 0 0
> RECV sasl-mechanisms(sasl-server-mechanisms:[PLAIN,ANONYMOUS])
> SEND sasl-init(mechanism:PLAIN,initial-response:...,hostname:localhost)
> RECV sasl-outcome(code:0)
> SEND AMQP 0 1.0.0
> SEND (ch=0)
> open(container-id:AMQPNetLite-43a6c9ad,host-name:localhost,max-frame-size:262144,channel-max:255,idle-time-out:2147483647)
> RECV AMQP 0 1 0 0
> SEND (ch=0)
> begin(next-outgoing-id:4294967293,incoming-window:2048,outgoing-window:2048,handle-max:63)
> RECV (ch=0)
> open(container-id:0.0.0.0,max-frame-size:131072,channel-max:65535,idle-time-out:3,offered-capabilities:[sole-connection-for-container,DELAYED_DELIVERY,SHARED-SUBS,ANONYMOUS-RELAY],properties:[product:apache-activemq-artemis,version:2.6.3])
> {color:#f6c342}SEND (ch=0)
> attach(name:link1,handle:0,role:False,source:source(),target:target(address:q1),initial-delivery-count:0)
> SEND (ch=0) detach(handle:0,closed:True)
> SEND (ch=0)
> attach(name:link0,handle:1,role:False,source:source(),target:target(address:q0),initial-delivery-count:0)
> SEND (ch=0) detach(handle:1,closed:True){color}
> RECV (ch=0)
> begin(remote-channel:0,next-outgoing-id:1,incoming-window:2147483647,outgoing-window:2147483647,handle-max:65535)
> {color:#14892c}SEND (ch=0) empty
> SEND (ch=0) empty
> SEND (ch=0) empty
> SEND (ch=0) empty{color}
> Note that this doesn’t always happen. Sometimes Artemis does respond, as
> shown by the lines highlighted in bold/grey in the trace below.
> SEND AMQP 3 1 0 0
> RECV sasl-mechanisms(sasl-server-mechanisms:[PLAIN,ANONYMOUS])
> SEND sasl-init(mechanism:PLAIN,initial-response:...,hostname:localhost)
> RECV sasl-outcome(code:0)
> SEND AMQP 0 1.0.0
> SEND (ch=0)
> open(container-id:AMQPNetLite-b00e0be7,host-name:localhost,max-frame-size:262144,channel-max:255,idle-time-out:2147483647)
> RECV AMQP 0 1 0 0
> RECV (ch=0)
> open(container-id:0.0.0.0,max-frame-size:131072,channel-max:65535,idle-time-out:3,offered-capabilities:[sole-connection-for-container,DELAYED_DELIVERY,SHARED-SUBS,ANONYMOUS-RELAY],properties:[product:apache-activemq-artemis,version:2.6.3])
> SEND (ch=0)
> begin(next-outgoing-id:4294967293,incoming-window:2048,outgoing-window:2048,handle-max:63)
> RECV (ch=0)
> begin(remote-channel:0,next-outgoing-id:1,incoming-window:2147483647,outgoing-window:2147483647,handle-max:65535)
> {color:#f6c342}SEND (ch=0)
> attach(name:link1,handle:0,role:False,source:source(),target:target(address:q1),initial-delivery-count:0)
> SEND (ch=0) detach(handle:0,closed:True)
> SEND (ch=0)
> attach(name:link0,handle:1,role:False,source:source(),target:target(address:q0),initial-delivery-count:0)
> SEND (ch=0) detach(handle:1,closed:True){color}
> *{color:#707070}RECV (ch=0)
> attach(name:link1,handle:0,role:True,snd-settle-mode:2,rcv-settle-mode:0,source:source(),target:target(address:q1)){color}*
> RECV (ch=0)
> flow(next-in-id:4294967293,in-window:2147483647,next-out-id:1,out-window:2147483647,handle:0,delivery-count:0,link-credit:1000)
> *{color:#707070}RECV (ch=0) detach(handle:0,closed:True){color}*
> {color:#f6c342}SEND (ch=0)
> attach(name:link1,handle:0,role:False,source:source(),target:target(add
[jira] [Commented] (ARTEMIS-2180) Host and broker runs out of memory when stopping a backup in a cluster
[ https://issues.apache.org/jira/browse/ARTEMIS-2180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750819#comment-16750819 ] Simon Chalmers commented on ARTEMIS-2180: - HI [~jbertram] - my colleague Rachel will be taking over this testing and analysis work now on the Artemis from our side. She will jump in here shortly and update the JIRA accordingly. > Host and broker runs out of memory when stopping a backup in a cluster > -- > > Key: ARTEMIS-2180 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2180 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.6.3 >Reporter: Simon Chalmers >Priority: Critical > Attachments: hs_err_pid15534.log > > > When running a live-backup cluster pair and stopping the backup, the live > broker starts leaking memory, runs out of memory and core dumps. > This occurs during a performance test when the broker is under load; the > slave has been running successfully but is then terminated whilst the broker > is still under load. > Core dump attached. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2176) RA connection properties are not propagated to XARecoveryConfig
[ https://issues.apache.org/jira/browse/ARTEMIS-2176?focusedWorklogId=189327&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189327 ] ASF GitHub Bot logged work on ARTEMIS-2176: --- Author: ASF GitHub Bot Created on: 24/Jan/19 06:42 Start Date: 24/Jan/19 06:42 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on pull request #2432: [ARTEMIS-2176] RA connection properties are not propagated to XARecov… URL: https://github.com/apache/activemq-artemis/pull/2432#discussion_r250482029 ## File path: artemis-service-extensions/src/main/java/org/apache/activemq/artemis/service/extensions/xa/recovery/XARecoveryConfig.java ## @@ -45,16 +45,41 @@ private final Map properties; private final ClientProtocolManagerFactory clientProtocolManager; + // ServerLocator properties Review comment: This simply will be a nightmare to keep this in sync as we add more. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189327) Time Spent: 10m Remaining Estimate: 0h > RA connection properties are not propagated to XARecoveryConfig > --- > > Key: ARTEMIS-2176 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2176 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.6.3 >Reporter: Bartosz Spyrko-Smietanko >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > XARecoveryConfig#createServerLocator uses only > TransportConfiguration/DiscoveryGroupConfiguration to create a new instance > of ServerLocator. That means that connection properties like connectionTTL or > callFailoverTime are ignored. This can lead to network issues - eg. > [https://issues.jboss.org/browse/WFLY-10725] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2176) RA connection properties are not propagated to XARecoveryConfig
[ https://issues.apache.org/jira/browse/ARTEMIS-2176?focusedWorklogId=189328&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189328 ] ASF GitHub Bot logged work on ARTEMIS-2176: --- Author: ASF GitHub Bot Created on: 24/Jan/19 06:44 Start Date: 24/Jan/19 06:44 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on pull request #2432: [ARTEMIS-2176] RA connection properties are not propagated to XARecov… URL: https://github.com/apache/activemq-artemis/pull/2432#discussion_r250482029 ## File path: artemis-service-extensions/src/main/java/org/apache/activemq/artemis/service/extensions/xa/recovery/XARecoveryConfig.java ## @@ -45,16 +45,41 @@ private final Map properties; private final ClientProtocolManagerFactory clientProtocolManager; + // ServerLocator properties Review comment: This is really ba duplication, it simply will be a nightmare to keep this in sync as we add more and too brittle. A better solution has to exist, even if it’s some work to abstract This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189328) Time Spent: 20m (was: 10m) > RA connection properties are not propagated to XARecoveryConfig > --- > > Key: ARTEMIS-2176 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2176 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.6.3 >Reporter: Bartosz Spyrko-Smietanko >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > XARecoveryConfig#createServerLocator uses only > TransportConfiguration/DiscoveryGroupConfiguration to create a new instance > of ServerLocator. That means that connection properties like connectionTTL or > callFailoverTime are ignored. This can lead to network issues - eg. > [https://issues.jboss.org/browse/WFLY-10725] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2176) RA connection properties are not propagated to XARecoveryConfig
[ https://issues.apache.org/jira/browse/ARTEMIS-2176?focusedWorklogId=189329&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189329 ] ASF GitHub Bot logged work on ARTEMIS-2176: --- Author: ASF GitHub Bot Created on: 24/Jan/19 06:44 Start Date: 24/Jan/19 06:44 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on pull request #2432: [ARTEMIS-2176] RA connection properties are not propagated to XARecov… URL: https://github.com/apache/activemq-artemis/pull/2432#discussion_r250482029 ## File path: artemis-service-extensions/src/main/java/org/apache/activemq/artemis/service/extensions/xa/recovery/XARecoveryConfig.java ## @@ -45,16 +45,41 @@ private final Map properties; private final ClientProtocolManagerFactory clientProtocolManager; + // ServerLocator properties Review comment: This is really bad duplication, it simply will be a nightmare to keep this in sync as we add more and too brittle. A better solution has to exist, even if it’s some work to abstract This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189329) Time Spent: 0.5h (was: 20m) > RA connection properties are not propagated to XARecoveryConfig > --- > > Key: ARTEMIS-2176 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2176 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.6.3 >Reporter: Bartosz Spyrko-Smietanko >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > XARecoveryConfig#createServerLocator uses only > TransportConfiguration/DiscoveryGroupConfiguration to create a new instance > of ServerLocator. That means that connection properties like connectionTTL or > callFailoverTime are ignored. This can lead to network issues - eg. > [https://issues.jboss.org/browse/WFLY-10725] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2170) Optimized CoreMessage's checkProperties and cleanupInternalProperties methods
[ https://issues.apache.org/jira/browse/ARTEMIS-2170?focusedWorklogId=189326&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189326 ] ASF GitHub Bot logged work on ARTEMIS-2170: --- Author: ASF GitHub Bot Created on: 24/Jan/19 06:38 Start Date: 24/Jan/19 06:38 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-457084424 @michaelandrepearce yep, it seems ok from the CI pov: there are just a couple of failures that seems unrelated to this PR :+1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189326) Time Spent: 6h 50m (was: 6h 40m) > Optimized CoreMessage's checkProperties and cleanupInternalProperties methods > - > > Key: ARTEMIS-2170 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2170 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Reporter: Francesco Nigro >Assignee: Francesco Nigro >Priority: Minor > Time Spent: 6h 50m > Remaining Estimate: 0h > > CoreMessage::checkProperties perform too many volatile read/write and has a > too big body just to handle exceptional cases, while > cleanupInternalProperties is called on the hot path of session send, but is > performing too many synchronized operations and loopup on TypedProperties. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2088) Page.write() should throw exception if file is closed
[ https://issues.apache.org/jira/browse/ARTEMIS-2088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750641#comment-16750641 ] ASF subversion and git services commented on ARTEMIS-2088: -- Commit 90ca87c5e16df9812a65db37d05306f444dd7fb1 in activemq-artemis's branch refs/heads/master from Howard Gao [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=90ca87c ] ARTEMIS-2088 - Page.write() should throw exception if file is closed In Page.write(final PagedMessage message) if the page file is closed it returns silently. The caller has no way to know that if the message is paged to file or not. It should throw an exception so that the caller can handle it correctly. This causes random failure PagingTest#testExpireLargeMessageOnPaging(). The test shows that when the server stops it closes the page file. In the mean time a message is expired to the expiry queue and if the expiry queue is in paging mode, it goes to Page.write() and returns without any error. The result is that the message is removed from the original queue and not added to the expiry queue. If we throw exception here it makes the expiration failed, the message will not be removed from the orginal queue. Next time broker is started, the message will be reloaded and expired again. no message lost. > Page.write() should throw exception if file is closed > - > > Key: ARTEMIS-2088 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2088 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.6.3 >Reporter: Howard Gao >Assignee: Howard Gao >Priority: Major > Fix For: 2.6.5 > > > In Page.write(final PagedMessage message) if the page file is closed it > returns silently. The caller has no way to know that if the message is paged > to file or not. > It should throw an exception so that the caller can handle it correctly. > This causes random failure in test > org.hornetq.tests.integration.client.PagingTest#testExpireLargeMessageOnPaging(). > The test shows that when the server stops it closes the page file. In the > mean time a message is expired to the expiry queue. > and if the expiry queue is in paging mode, it goes to Page.write() and > returns without any error. The result is that the message is removed from the > original queue and not added to the expiry queue. > If we throw exception here it make the expiration failed, the message will > not be removed from the orginal queue. Next time broker is started, the > message will be reloaded and expired again. no message lost. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2059) NettyWritable should use UTF-8 exact length to encode strings
[ https://issues.apache.org/jira/browse/ARTEMIS-2059?focusedWorklogId=189176&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189176 ] ASF GitHub Bot logged work on ARTEMIS-2059: --- Author: ASF GitHub Bot Created on: 23/Jan/19 20:21 Start Date: 23/Jan/19 20:21 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2274: ARTEMIS-2059 NettyWritable should use UTF-8 exact length to encode strings URL: https://github.com/apache/activemq-artemis/pull/2274#issuecomment-456951676 @franz1981 Can we close and reopen later once some more progress or discussion is done. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189176) Time Spent: 10m Remaining Estimate: 0h > NettyWritable should use UTF-8 exact length to encode strings > - > > Key: ARTEMIS-2059 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2059 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Reporter: Francesco Nigro >Assignee: Francesco Nigro >Priority: Minor > Fix For: 2.7.0 > > Time Spent: 10m > Remaining Estimate: 0h > > NettyWritable.put(String) tries to enlarge the buffer used to write a UTF-8 > string until ByteBufUtil.utf8MaxBytes. > That means that it will fail or will enlarge any ByteBuf that is perfectly > sized to contain the encoded string. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (AMQCPP-643) Add an option to time out connection attempts when blocked in ensureConnectionInfoSent
[ https://issues.apache.org/jira/browse/AMQCPP-643?focusedWorklogId=189177&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189177 ] ASF GitHub Bot logged work on AMQCPP-643: - Author: ASF GitHub Bot Created on: 23/Jan/19 20:21 Start Date: 23/Jan/19 20:21 Worklog Time Spent: 10m Work Description: tabish121 commented on issue #17: AMQCPP-643: Add an option to time out connection attempts when blocked in ensureConnectionInfoSent URL: https://github.com/apache/activemq-cpp/pull/17#issuecomment-456951888 This is targeted at 3.9.x but would also need to go into master, can you target this at master so it can go into there and then be cherry picked to the patch branches This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189177) Time Spent: 10m Remaining Estimate: 0h > Add an option to time out connection attempts when blocked in > ensureConnectionInfoSent > -- > > Key: AMQCPP-643 > URL: https://issues.apache.org/jira/browse/AMQCPP-643 > Project: ActiveMQ C++ Client > Issue Type: New Feature > Components: Transports >Affects Versions: 3.9.4 > Environment: HP-UX > Fedora 27 / gcc >Reporter: Roddie Kieley >Assignee: Timothy Bish >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > In some rare cases client side stack traces show that the client can be stuck > in ensureConnectionInfoSent waiting forever for a response from the broker. > We will add an optional timeout to allow this operation to fail which > defaults to off via a default timeout of 0. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-1787) Openwire message should not contain internal property
[ https://issues.apache.org/jira/browse/ARTEMIS-1787?focusedWorklogId=189172&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189172 ] ASF GitHub Bot logged work on ARTEMIS-1787: --- Author: ASF GitHub Bot Created on: 23/Jan/19 20:18 Start Date: 23/Jan/19 20:18 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #1994: ARTEMIS-1787 Openwire message should not contain internal property URL: https://github.com/apache/activemq-artemis/pull/1994#issuecomment-456950879 As noted effort should go to native openwire message support #1793. Can we close this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189172) Time Spent: 10m Remaining Estimate: 0h > Openwire message should not contain internal property > - > > Key: ARTEMIS-1787 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1787 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Stanislav Knot >Assignee: Stanislav Knot >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Openwire message contains __AMQ_CID property. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-1194) SOCKS proxy support
[ https://issues.apache.org/jira/browse/ARTEMIS-1194?focusedWorklogId=189170&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189170 ] ASF GitHub Bot logged work on ARTEMIS-1194: --- Author: ASF GitHub Bot Created on: 23/Jan/19 20:16 Start Date: 23/Jan/19 20:16 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #1293: ARTEMIS-1194: SOCKS proxy support URL: https://github.com/apache/activemq-artemis/pull/1293#issuecomment-456950321 @clebertsuconic whats occuring on this, we ok to merge? And simply mark feature beta until some decent tests? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189170) Time Spent: 10m Remaining Estimate: 0h > SOCKS proxy support > --- > > Key: ARTEMIS-1194 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1194 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Andrius Dagys >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Add SOCKS4a & 5 support to the NettyConnector. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2170) Optimized CoreMessage's checkProperties and cleanupInternalProperties methods
[ https://issues.apache.org/jira/browse/ARTEMIS-2170?focusedWorklogId=189168&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189168 ] ASF GitHub Bot logged work on ARTEMIS-2170: --- Author: ASF GitHub Bot Created on: 23/Jan/19 20:07 Start Date: 23/Jan/19 20:07 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-456947342 @franz1981 I happy to merge this if you are ready. Have been waiting for your ci build check. But from the checks i did it seems good This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189168) Time Spent: 6.5h (was: 6h 20m) > Optimized CoreMessage's checkProperties and cleanupInternalProperties methods > - > > Key: ARTEMIS-2170 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2170 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Reporter: Francesco Nigro >Assignee: Francesco Nigro >Priority: Minor > Time Spent: 6.5h > Remaining Estimate: 0h > > CoreMessage::checkProperties perform too many volatile read/write and has a > too big body just to handle exceptional cases, while > cleanupInternalProperties is called on the hot path of session send, but is > performing too many synchronized operations and loopup on TypedProperties. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2170) Optimized CoreMessage's checkProperties and cleanupInternalProperties methods
[ https://issues.apache.org/jira/browse/ARTEMIS-2170?focusedWorklogId=189169&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189169 ] ASF GitHub Bot logged work on ARTEMIS-2170: --- Author: ASF GitHub Bot Created on: 23/Jan/19 20:07 Start Date: 23/Jan/19 20:07 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-456947342 @franz1981 I happy to merge this if you are ready. Have been waiting for you to report back on the ci build check you wanted todo. But from the checks i did it seems good This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189169) Time Spent: 6h 40m (was: 6.5h) > Optimized CoreMessage's checkProperties and cleanupInternalProperties methods > - > > Key: ARTEMIS-2170 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2170 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Reporter: Francesco Nigro >Assignee: Francesco Nigro >Priority: Minor > Time Spent: 6h 40m > Remaining Estimate: 0h > > CoreMessage::checkProperties perform too many volatile read/write and has a > too big body just to handle exceptional cases, while > cleanupInternalProperties is called on the hot path of session send, but is > performing too many synchronized operations and loopup on TypedProperties. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2170) Optimized CoreMessage's checkProperties and cleanupInternalProperties methods
[ https://issues.apache.org/jira/browse/ARTEMIS-2170?focusedWorklogId=189167&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189167 ] ASF GitHub Bot logged work on ARTEMIS-2170: --- Author: ASF GitHub Bot Created on: 23/Jan/19 20:06 Start Date: 23/Jan/19 20:06 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods URL: https://github.com/apache/activemq-artemis/pull/2427#issuecomment-456947342 I happy to merge this if you are ready. Have been waiting for your ci build check. But from the checks i did it seems good This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189167) Time Spent: 6h 20m (was: 6h 10m) > Optimized CoreMessage's checkProperties and cleanupInternalProperties methods > - > > Key: ARTEMIS-2170 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2170 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Reporter: Francesco Nigro >Assignee: Francesco Nigro >Priority: Minor > Time Spent: 6h 20m > Remaining Estimate: 0h > > CoreMessage::checkProperties perform too many volatile read/write and has a > too big body just to handle exceptional cases, while > cleanupInternalProperties is called on the hot path of session send, but is > performing too many synchronized operations and loopup on TypedProperties. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (ARTEMIS-2192) LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types
[ https://issues.apache.org/jira/browse/ARTEMIS-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] clebert suconic closed ARTEMIS-2192. Resolution: Fixed > LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types > - > > Key: ARTEMIS-2192 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2192 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.6.4 >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Fix For: 2.7.0, 2.6.5 > > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ARTEMIS-2192) LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types
[ https://issues.apache.org/jira/browse/ARTEMIS-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] clebert suconic updated ARTEMIS-2192: - Affects Version/s: (was: 2.6.3) 2.6.4 Fix Version/s: 2.6.5 2.7.0 > LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types > - > > Key: ARTEMIS-2192 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2192 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.6.4 >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Fix For: 2.7.0, 2.6.5 > > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ARTEMIS-1867) Support FQQN for producers
[ https://issues.apache.org/jira/browse/ARTEMIS-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram resolved ARTEMIS-1867. - Resolution: Fixed > Support FQQN for producers > -- > > Key: ARTEMIS-1867 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1867 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Fix For: 2.7.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > Allow clients to send messages directly to a fully-qualified queue rather > than just an address. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ARTEMIS-1867) Support FQQN for producers
[ https://issues.apache.org/jira/browse/ARTEMIS-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram updated ARTEMIS-1867: Affects Version/s: 2.6.4 > Support FQQN for producers > -- > > Key: ARTEMIS-1867 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1867 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.6.4 >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Fix For: 2.7.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > Allow clients to send messages directly to a fully-qualified queue rather > than just an address. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-196) Implementing Consumer Priority
[ https://issues.apache.org/jira/browse/ARTEMIS-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750301#comment-16750301 ] ASF subversion and git services commented on ARTEMIS-196: - Commit 5a19c54f9faf549aea5d14682593815e1de3a1c6 in activemq-artemis's branch refs/heads/master from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=5a19c54 ] ARTEMIS-196 Removing dead variables Fixing build after removing variable used by FieldUpdater > Implementing Consumer Priority > -- > > Key: ARTEMIS-196 > URL: https://issues.apache.org/jira/browse/ARTEMIS-196 > Project: ActiveMQ Artemis > Issue Type: Sub-task > Components: OpenWire >Affects Versions: 1.0.0 >Reporter: Howard Gao >Priority: Major > Fix For: unscheduled > > Time Spent: 6h 40m > Remaining Estimate: 0h > > ref: http://activemq.apache.org/consumer-priority.html > org.apache.activemq.QueueConsumerPriorityTest -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1867) Support FQQN for producers
[ https://issues.apache.org/jira/browse/ARTEMIS-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750302#comment-16750302 ] ASF subversion and git services commented on ARTEMIS-1867: -- Commit a4a929a154285116581371fde8a400d0249eb130 in activemq-artemis's branch refs/heads/master from Justin Graham Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=a4a929a ] ARTEMIS-1867 fix FQQNOpenWireTest > Support FQQN for producers > -- > > Key: ARTEMIS-1867 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1867 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Fix For: 2.7.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Allow clients to send messages directly to a fully-qualified queue rather > than just an address. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-1867) Support FQQN for producers
[ https://issues.apache.org/jira/browse/ARTEMIS-1867?focusedWorklogId=189121&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189121 ] ASF GitHub Bot logged work on ARTEMIS-1867: --- Author: ASF GitHub Bot Created on: 23/Jan/19 18:32 Start Date: 23/Jan/19 18:32 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2515: ARTEMIS-1867 fix FQQNOpenWireTest URL: https://github.com/apache/activemq-artemis/pull/2515 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189121) Time Spent: 1.5h (was: 1h 20m) > Support FQQN for producers > -- > > Key: ARTEMIS-1867 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1867 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Fix For: 2.7.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > Allow clients to send messages directly to a fully-qualified queue rather > than just an address. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ARTEMIS-2237) initial reconnect attempts doesn't round robin
Ryan Yeats created ARTEMIS-2237: --- Summary: initial reconnect attempts doesn't round robin Key: ARTEMIS-2237 URL: https://issues.apache.org/jira/browse/ARTEMIS-2237 Project: ActiveMQ Artemis Issue Type: Bug Components: Broker Affects Versions: 2.6.3 Reporter: Ryan Yeats connectionFactory.setInitialConnectAttempts(-1) will only ever connect to the first host in the list. On a related note, it looks like setFailoverOnInitialConnection value isn't used either. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-196) Implementing Consumer Priority
[ https://issues.apache.org/jira/browse/ARTEMIS-196?focusedWorklogId=189119&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189119 ] ASF GitHub Bot logged work on ARTEMIS-196: -- Author: ASF GitHub Bot Created on: 23/Jan/19 18:26 Start Date: 23/Jan/19 18:26 Worklog Time Spent: 10m Work Description: clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-456913156 @michaelandrepearce duh.. thanks This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189119) Time Spent: 6h 40m (was: 6.5h) > Implementing Consumer Priority > -- > > Key: ARTEMIS-196 > URL: https://issues.apache.org/jira/browse/ARTEMIS-196 > Project: ActiveMQ Artemis > Issue Type: Sub-task > Components: OpenWire >Affects Versions: 1.0.0 >Reporter: Howard Gao >Priority: Major > Fix For: unscheduled > > Time Spent: 6h 40m > Remaining Estimate: 0h > > ref: http://activemq.apache.org/consumer-priority.html > org.apache.activemq.QueueConsumerPriorityTest -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ARTEMIS-1867) Support FQQN for producers
[ https://issues.apache.org/jira/browse/ARTEMIS-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram updated ARTEMIS-1867: Description: Allow clients to send messages directly to a fully-qualified queue rather than just an address. (was: Allow STOMP clients to send messages directly to a fully-qualified queue rather than just an address.) > Support FQQN for producers > -- > > Key: ARTEMIS-1867 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1867 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Fix For: 2.7.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Allow clients to send messages directly to a fully-qualified queue rather > than just an address. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (ARTEMIS-1867) Support FQQN for producers
[ https://issues.apache.org/jira/browse/ARTEMIS-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram reassigned ARTEMIS-1867: --- Assignee: Justin Bertram > Support FQQN for producers > -- > > Key: ARTEMIS-1867 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1867 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: STOMP >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Fix For: 2.7.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Allow STOMP clients to send messages directly to a fully-qualified queue > rather than just an address. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ARTEMIS-1867) Support FQQN for producers
[ https://issues.apache.org/jira/browse/ARTEMIS-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram updated ARTEMIS-1867: Component/s: (was: STOMP) > Support FQQN for producers > -- > > Key: ARTEMIS-1867 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1867 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Fix For: 2.7.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Allow STOMP clients to send messages directly to a fully-qualified queue > rather than just an address. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ARTEMIS-1867) Support FQQN for producers
[ https://issues.apache.org/jira/browse/ARTEMIS-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram updated ARTEMIS-1867: Fix Version/s: 2.7.0 > Support FQQN for producers > -- > > Key: ARTEMIS-1867 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1867 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: STOMP >Reporter: Justin Bertram >Priority: Major > Fix For: 2.7.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Allow STOMP clients to send messages directly to a fully-qualified queue > rather than just an address. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-1867) Support FQQN for producers
[ https://issues.apache.org/jira/browse/ARTEMIS-1867?focusedWorklogId=189085&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189085 ] ASF GitHub Bot logged work on ARTEMIS-1867: --- Author: ASF GitHub Bot Created on: 23/Jan/19 17:33 Start Date: 23/Jan/19 17:33 Worklog Time Spent: 10m Work Description: jbertram commented on pull request #2515: ARTEMIS-1867 fix FQQNOpenWireTest URL: https://github.com/apache/activemq-artemis/pull/2515 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189085) Time Spent: 1h 20m (was: 1h 10m) > Support FQQN for producers > -- > > Key: ARTEMIS-1867 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1867 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: STOMP >Reporter: Justin Bertram >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > Allow STOMP clients to send messages directly to a fully-qualified queue > rather than just an address. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-196) Implementing Consumer Priority
[ https://issues.apache.org/jira/browse/ARTEMIS-196?focusedWorklogId=189063&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189063 ] ASF GitHub Bot logged work on ARTEMIS-196: -- Author: ASF GitHub Bot Created on: 23/Jan/19 16:48 Start Date: 23/Jan/19 16:48 Worklog Time Spent: 10m Work Description: clebertsuconic commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-456877360 I added one change on top of yours during merge... to remove unused variables.. merged! you are the man! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189063) Time Spent: 6h 20m (was: 6h 10m) > Implementing Consumer Priority > -- > > Key: ARTEMIS-196 > URL: https://issues.apache.org/jira/browse/ARTEMIS-196 > Project: ActiveMQ Artemis > Issue Type: Sub-task > Components: OpenWire >Affects Versions: 1.0.0 >Reporter: Howard Gao >Priority: Major > Fix For: unscheduled > > Time Spent: 6h 20m > Remaining Estimate: 0h > > ref: http://activemq.apache.org/consumer-priority.html > org.apache.activemq.QueueConsumerPriorityTest -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-196) Implementing Consumer Priority
[ https://issues.apache.org/jira/browse/ARTEMIS-196?focusedWorklogId=189070&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189070 ] ASF GitHub Bot logged work on ARTEMIS-196: -- Author: ASF GitHub Bot Created on: 23/Jan/19 16:58 Start Date: 23/Jan/19 16:58 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490#issuecomment-456881694 @clebertsuconic some of those variables are used but accesed by atomic updaters. Have commented on your commit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189070) Time Spent: 6.5h (was: 6h 20m) > Implementing Consumer Priority > -- > > Key: ARTEMIS-196 > URL: https://issues.apache.org/jira/browse/ARTEMIS-196 > Project: ActiveMQ Artemis > Issue Type: Sub-task > Components: OpenWire >Affects Versions: 1.0.0 >Reporter: Howard Gao >Priority: Major > Fix For: unscheduled > > Time Spent: 6.5h > Remaining Estimate: 0h > > ref: http://activemq.apache.org/consumer-priority.html > org.apache.activemq.QueueConsumerPriorityTest -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2192) LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types
[ https://issues.apache.org/jira/browse/ARTEMIS-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750212#comment-16750212 ] ASF subversion and git services commented on ARTEMIS-2192: -- Commit 1f706544366f6f03e7944903729c9ca1a93f5f15 in activemq-artemis's branch refs/heads/2.6.x from Justin Graham Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=1f70654 ] ARTEMIS-2192 LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types Change the LegacyLDAPSecuritySettingPlugin to interpret the search results based on the order of the returned RDNs rather than hard-coded types. (cherry picked from commit 8d7d78074c9d53b420e375c891f91a3627ea87b9) > LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types > - > > Key: ARTEMIS-2192 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2192 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.6.3 >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2192) LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types
[ https://issues.apache.org/jira/browse/ARTEMIS-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750210#comment-16750210 ] ASF subversion and git services commented on ARTEMIS-2192: -- Commit 8d7d78074c9d53b420e375c891f91a3627ea87b9 in activemq-artemis's branch refs/heads/master from Justin Graham Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=8d7d780 ] ARTEMIS-2192 LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types Change the LegacyLDAPSecuritySettingPlugin to interpret the search results based on the order of the returned RDNs rather than hard-coded types. > LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types > - > > Key: ARTEMIS-2192 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2192 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.6.3 >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2192) LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types
[ https://issues.apache.org/jira/browse/ARTEMIS-2192?focusedWorklogId=189066&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189066 ] ASF GitHub Bot logged work on ARTEMIS-2192: --- Author: ASF GitHub Bot Created on: 23/Jan/19 16:52 Start Date: 23/Jan/19 16:52 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2451: ARTEMIS-2192 LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types URL: https://github.com/apache/activemq-artemis/pull/2451 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189066) Time Spent: 50m (was: 40m) > LegacyLDAPSecuritySettingPlugin uses hard-coded RDN types > - > > Key: ARTEMIS-2192 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2192 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.6.3 >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-196) Implementing Consumer Priority
[ https://issues.apache.org/jira/browse/ARTEMIS-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750188#comment-16750188 ] ASF subversion and git services commented on ARTEMIS-196: - Commit f225a4e166c741910d065166d0a5c6da5a2823ea in activemq-artemis's branch refs/heads/master from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=f225a4e ] ARTEMIS-196 Removing dead variables This is really a NO-JIRA however it was done in the context of merging ARTEMIS-196 > Implementing Consumer Priority > -- > > Key: ARTEMIS-196 > URL: https://issues.apache.org/jira/browse/ARTEMIS-196 > Project: ActiveMQ Artemis > Issue Type: Sub-task > Components: OpenWire >Affects Versions: 1.0.0 >Reporter: Howard Gao >Priority: Major > Fix For: unscheduled > > Time Spent: 6h > Remaining Estimate: 0h > > ref: http://activemq.apache.org/consumer-priority.html > org.apache.activemq.QueueConsumerPriorityTest -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-196) Implementing Consumer Priority
[ https://issues.apache.org/jira/browse/ARTEMIS-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750189#comment-16750189 ] ASF subversion and git services commented on ARTEMIS-196: - Commit f225a4e166c741910d065166d0a5c6da5a2823ea in activemq-artemis's branch refs/heads/master from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=f225a4e ] ARTEMIS-196 Removing dead variables This is really a NO-JIRA however it was done in the context of merging ARTEMIS-196 > Implementing Consumer Priority > -- > > Key: ARTEMIS-196 > URL: https://issues.apache.org/jira/browse/ARTEMIS-196 > Project: ActiveMQ Artemis > Issue Type: Sub-task > Components: OpenWire >Affects Versions: 1.0.0 >Reporter: Howard Gao >Priority: Major > Fix For: unscheduled > > Time Spent: 6h 10m > Remaining Estimate: 0h > > ref: http://activemq.apache.org/consumer-priority.html > org.apache.activemq.QueueConsumerPriorityTest -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-196) Implementing Consumer Priority
[ https://issues.apache.org/jira/browse/ARTEMIS-196?focusedWorklogId=189050&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189050 ] ASF GitHub Bot logged work on ARTEMIS-196: -- Author: ASF GitHub Bot Created on: 23/Jan/19 16:32 Start Date: 23/Jan/19 16:32 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2490: ARTEMIS-196 Implement Consumer Priority URL: https://github.com/apache/activemq-artemis/pull/2490 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189050) Time Spent: 6h 10m (was: 6h) > Implementing Consumer Priority > -- > > Key: ARTEMIS-196 > URL: https://issues.apache.org/jira/browse/ARTEMIS-196 > Project: ActiveMQ Artemis > Issue Type: Sub-task > Components: OpenWire >Affects Versions: 1.0.0 >Reporter: Howard Gao >Priority: Major > Fix For: unscheduled > > Time Spent: 6h 10m > Remaining Estimate: 0h > > ref: http://activemq.apache.org/consumer-priority.html > org.apache.activemq.QueueConsumerPriorityTest -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-196) Implementing Consumer Priority
[ https://issues.apache.org/jira/browse/ARTEMIS-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750186#comment-16750186 ] ASF subversion and git services commented on ARTEMIS-196: - Commit 7dfa0fe7f43012f2f4ee5715049878019fe0bef7 in activemq-artemis's branch refs/heads/master from Michael André Pearce [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=7dfa0fe ] ARTEMIS-196 Implement Consumer Priority Add consumer priority support Includes refactor of consumer iterating in QueueImpl to its own logical class, to be able to implement. Add OpenWire JMS Test - taken from ActiveMQ5 Add Core JMS Test Add AMQP Test Add Docs > Implementing Consumer Priority > -- > > Key: ARTEMIS-196 > URL: https://issues.apache.org/jira/browse/ARTEMIS-196 > Project: ActiveMQ Artemis > Issue Type: Sub-task > Components: OpenWire >Affects Versions: 1.0.0 >Reporter: Howard Gao >Priority: Major > Fix For: unscheduled > > Time Spent: 6h > Remaining Estimate: 0h > > ref: http://activemq.apache.org/consumer-priority.html > org.apache.activemq.QueueConsumerPriorityTest -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2156) Message Duplication when using exclusive divert and clustering
[
https://issues.apache.org/jira/browse/ARTEMIS-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750136#comment-16750136
]
ASF subversion and git services commented on ARTEMIS-2156:
--
Commit f60bfbc0cb795883635bb20f631de21f7fd13806 in activemq-artemis's branch
refs/heads/2.6.x from Luis De Bello
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=f60bfbc ]
ARTEMIS-2156 Message Duplication when using exclusive divert and clustering
(cherry picked from commit d78eeb05cd25297fda7f6e31040131d984b6731b)
> Message Duplication when using exclusive divert and clustering
> --
>
> Key: ARTEMIS-2156
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2156
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 1.5.5, 2.6.3
>Reporter: Luis Miguel De Bello
>Priority: Major
> Attachments: ArtemisClient1.5.5.gif, ArtemisClient2.6.2.gif,
> Consumer.java, ConsumerClient2-6-0.java, Duplicate Object.png, Producer.java,
> ProducerClient2-6-0.java, broker1.xml, broker1Server2-6-3.xml, broker2.xml,
> broker2Server2-6-3.xml
>
> Time Spent: 7h 10m
> Remaining Estimate: 0h
>
> We bumped into the following issue, we start getting duplicate message after
> doing some analysis we saw the "exclusiveBindings" in
> "org.apache.activemq.artemis.core.postoffice.impl.BindingsImpl" got the same
> binding twice.
> The if statement in "addBinding"
> {code:java}
> if (binding.isExclusive()) {
>exclusiveBindings.add(binding);
> } else {
>SimpleString routingName = binding.getRoutingName();
>List bindings = routingNameBindingMap.get(routingName);
>if (bindings == null) {
> bindings = new CopyOnWriteArrayList<>();
> List oldBindings =
> routingNameBindingMap.putIfAbsent(routingName, bindings);
> if (oldBindings != null) {
> bindings = oldBindings;
> }
>}
>if (!bindings.contains(binding)) {
> bindings.add(binding);
>}
> }{code}
> Does not do any check in case the binding already exists, this kind of test
> is done for non exclusive binding.
> I was not able to create an automatic test in the base code because the issue
> seems related to the client version.
> Scenario:
> - Cluster of two instances (UDP) Artemis Server 1.5.5
> - Clean Up /data/bindings/\*, ../data/journal/\*, ../data/paging/\*
> - Exclusive Divert from jms.queue.\*.Provider.\*.Agent.\*.Status to
> jms.queue.Notifications
> - Java program using artemis client
> - Start Consumer in Instance 1 (jms.queue.Notifications)
> - Send Message to Instance 1
> - Send Message to Instance 2
> - Send Message to Instance 1
> Expectations:
> - We expect to get 3 message
> Results:
> We got 3 messages when the client uses version 1.5.5
> We got 5 messages when the client uses version 2.6.2
>
> I enclose two gif one for client
> "org.apache.activemq:artemis-jms-client:1.5.5" where it works ok and another
> for "org.apache.activemq:artemis-jms-client:2.6.2" where you can appreciate
> the issue.
> Also I enclose one screenshot where you can see the same object is added
> twice.
> I will also include the broker.xml file to configure the udp cluster + the
> code use for the producer and consumer.
> Note: The only difference when using client 1.5.5 is the queue name
> definition I needed to remove the jms.queue prefix.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2156) Message Duplication when using exclusive divert and clustering
[
https://issues.apache.org/jira/browse/ARTEMIS-2156?focusedWorklogId=189015&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189015
]
ASF GitHub Bot logged work on ARTEMIS-2156:
---
Author: ASF GitHub Bot
Created on: 23/Jan/19 15:23
Start Date: 23/Jan/19 15:23
Worklog Time Spent: 10m
Work Description: ldebello commented on issue #2510: [ARTEMIS-2156]
Message Duplication when using exclusive divert and clustering
URL: https://github.com/apache/activemq-artemis/pull/2510#issuecomment-456842951
@clebertsuconic sorry just one question to understand the workflow is common
to see the PR close which indicates `branch has unmerged commits.` but in
master I see the changes
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 189015)
Time Spent: 7h 10m (was: 7h)
> Message Duplication when using exclusive divert and clustering
> --
>
> Key: ARTEMIS-2156
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2156
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 1.5.5, 2.6.3
>Reporter: Luis Miguel De Bello
>Priority: Major
> Attachments: ArtemisClient1.5.5.gif, ArtemisClient2.6.2.gif,
> Consumer.java, ConsumerClient2-6-0.java, Duplicate Object.png, Producer.java,
> ProducerClient2-6-0.java, broker1.xml, broker1Server2-6-3.xml, broker2.xml,
> broker2Server2-6-3.xml
>
> Time Spent: 7h 10m
> Remaining Estimate: 0h
>
> We bumped into the following issue, we start getting duplicate message after
> doing some analysis we saw the "exclusiveBindings" in
> "org.apache.activemq.artemis.core.postoffice.impl.BindingsImpl" got the same
> binding twice.
> The if statement in "addBinding"
> {code:java}
> if (binding.isExclusive()) {
>exclusiveBindings.add(binding);
> } else {
>SimpleString routingName = binding.getRoutingName();
>List bindings = routingNameBindingMap.get(routingName);
>if (bindings == null) {
> bindings = new CopyOnWriteArrayList<>();
> List oldBindings =
> routingNameBindingMap.putIfAbsent(routingName, bindings);
> if (oldBindings != null) {
> bindings = oldBindings;
> }
>}
>if (!bindings.contains(binding)) {
> bindings.add(binding);
>}
> }{code}
> Does not do any check in case the binding already exists, this kind of test
> is done for non exclusive binding.
> I was not able to create an automatic test in the base code because the issue
> seems related to the client version.
> Scenario:
> - Cluster of two instances (UDP) Artemis Server 1.5.5
> - Clean Up /data/bindings/\*, ../data/journal/\*, ../data/paging/\*
> - Exclusive Divert from jms.queue.\*.Provider.\*.Agent.\*.Status to
> jms.queue.Notifications
> - Java program using artemis client
> - Start Consumer in Instance 1 (jms.queue.Notifications)
> - Send Message to Instance 1
> - Send Message to Instance 2
> - Send Message to Instance 1
> Expectations:
> - We expect to get 3 message
> Results:
> We got 3 messages when the client uses version 1.5.5
> We got 5 messages when the client uses version 2.6.2
>
> I enclose two gif one for client
> "org.apache.activemq:artemis-jms-client:1.5.5" where it works ok and another
> for "org.apache.activemq:artemis-jms-client:2.6.2" where you can appreciate
> the issue.
> Also I enclose one screenshot where you can see the same object is added
> twice.
> I will also include the broker.xml file to configure the udp cluster + the
> code use for the producer and consumer.
> Note: The only difference when using client 1.5.5 is the queue name
> definition I needed to remove the jms.queue prefix.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=189004&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189004 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 15:10 Start Date: 23/Jan/19 15:10 Worklog Time Spent: 10m Work Description: clebertsuconic commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456837511 Oh shoot.. I don't know how I missed this.. I'm the one who merged it.. I wouldn't have merged it if I had fully understood the change. I'm merging it now, cherry-picking it into 2.6.x This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189004) Time Spent: 13h 10m (was: 13h) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 13h 10m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2156) Message Duplication when using exclusive divert and clustering
[
https://issues.apache.org/jira/browse/ARTEMIS-2156?focusedWorklogId=189010&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189010
]
ASF GitHub Bot logged work on ARTEMIS-2156:
---
Author: ASF GitHub Bot
Created on: 23/Jan/19 15:17
Start Date: 23/Jan/19 15:17
Worklog Time Spent: 10m
Work Description: asfgit commented on pull request #2510: [ARTEMIS-2156]
Message Duplication when using exclusive divert and clustering
URL: https://github.com/apache/activemq-artemis/pull/2510
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 189010)
Time Spent: 7h (was: 6h 50m)
> Message Duplication when using exclusive divert and clustering
> --
>
> Key: ARTEMIS-2156
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2156
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 1.5.5, 2.6.3
>Reporter: Luis Miguel De Bello
>Priority: Major
> Attachments: ArtemisClient1.5.5.gif, ArtemisClient2.6.2.gif,
> Consumer.java, ConsumerClient2-6-0.java, Duplicate Object.png, Producer.java,
> ProducerClient2-6-0.java, broker1.xml, broker1Server2-6-3.xml, broker2.xml,
> broker2Server2-6-3.xml
>
> Time Spent: 7h
> Remaining Estimate: 0h
>
> We bumped into the following issue, we start getting duplicate message after
> doing some analysis we saw the "exclusiveBindings" in
> "org.apache.activemq.artemis.core.postoffice.impl.BindingsImpl" got the same
> binding twice.
> The if statement in "addBinding"
> {code:java}
> if (binding.isExclusive()) {
>exclusiveBindings.add(binding);
> } else {
>SimpleString routingName = binding.getRoutingName();
>List bindings = routingNameBindingMap.get(routingName);
>if (bindings == null) {
> bindings = new CopyOnWriteArrayList<>();
> List oldBindings =
> routingNameBindingMap.putIfAbsent(routingName, bindings);
> if (oldBindings != null) {
> bindings = oldBindings;
> }
>}
>if (!bindings.contains(binding)) {
> bindings.add(binding);
>}
> }{code}
> Does not do any check in case the binding already exists, this kind of test
> is done for non exclusive binding.
> I was not able to create an automatic test in the base code because the issue
> seems related to the client version.
> Scenario:
> - Cluster of two instances (UDP) Artemis Server 1.5.5
> - Clean Up /data/bindings/\*, ../data/journal/\*, ../data/paging/\*
> - Exclusive Divert from jms.queue.\*.Provider.\*.Agent.\*.Status to
> jms.queue.Notifications
> - Java program using artemis client
> - Start Consumer in Instance 1 (jms.queue.Notifications)
> - Send Message to Instance 1
> - Send Message to Instance 2
> - Send Message to Instance 1
> Expectations:
> - We expect to get 3 message
> Results:
> We got 3 messages when the client uses version 1.5.5
> We got 5 messages when the client uses version 2.6.2
>
> I enclose two gif one for client
> "org.apache.activemq:artemis-jms-client:1.5.5" where it works ok and another
> for "org.apache.activemq:artemis-jms-client:2.6.2" where you can appreciate
> the issue.
> Also I enclose one screenshot where you can see the same object is added
> twice.
> I will also include the broker.xml file to configure the udp cluster + the
> code use for the producer and consumer.
> Note: The only difference when using client 1.5.5 is the queue name
> definition I needed to remove the jms.queue prefix.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2156) Message Duplication when using exclusive divert and clustering
[
https://issues.apache.org/jira/browse/ARTEMIS-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750108#comment-16750108
]
ASF subversion and git services commented on ARTEMIS-2156:
--
Commit d78eeb05cd25297fda7f6e31040131d984b6731b in activemq-artemis's branch
refs/heads/master from Luis De Bello
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=d78eeb0 ]
ARTEMIS-2156 Message Duplication when using exclusive divert and clustering
> Message Duplication when using exclusive divert and clustering
> --
>
> Key: ARTEMIS-2156
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2156
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 1.5.5, 2.6.3
>Reporter: Luis Miguel De Bello
>Priority: Major
> Attachments: ArtemisClient1.5.5.gif, ArtemisClient2.6.2.gif,
> Consumer.java, ConsumerClient2-6-0.java, Duplicate Object.png, Producer.java,
> ProducerClient2-6-0.java, broker1.xml, broker1Server2-6-3.xml, broker2.xml,
> broker2Server2-6-3.xml
>
> Time Spent: 6h 50m
> Remaining Estimate: 0h
>
> We bumped into the following issue, we start getting duplicate message after
> doing some analysis we saw the "exclusiveBindings" in
> "org.apache.activemq.artemis.core.postoffice.impl.BindingsImpl" got the same
> binding twice.
> The if statement in "addBinding"
> {code:java}
> if (binding.isExclusive()) {
>exclusiveBindings.add(binding);
> } else {
>SimpleString routingName = binding.getRoutingName();
>List bindings = routingNameBindingMap.get(routingName);
>if (bindings == null) {
> bindings = new CopyOnWriteArrayList<>();
> List oldBindings =
> routingNameBindingMap.putIfAbsent(routingName, bindings);
> if (oldBindings != null) {
> bindings = oldBindings;
> }
>}
>if (!bindings.contains(binding)) {
> bindings.add(binding);
>}
> }{code}
> Does not do any check in case the binding already exists, this kind of test
> is done for non exclusive binding.
> I was not able to create an automatic test in the base code because the issue
> seems related to the client version.
> Scenario:
> - Cluster of two instances (UDP) Artemis Server 1.5.5
> - Clean Up /data/bindings/\*, ../data/journal/\*, ../data/paging/\*
> - Exclusive Divert from jms.queue.\*.Provider.\*.Agent.\*.Status to
> jms.queue.Notifications
> - Java program using artemis client
> - Start Consumer in Instance 1 (jms.queue.Notifications)
> - Send Message to Instance 1
> - Send Message to Instance 2
> - Send Message to Instance 1
> Expectations:
> - We expect to get 3 message
> Results:
> We got 3 messages when the client uses version 1.5.5
> We got 5 messages when the client uses version 2.6.2
>
> I enclose two gif one for client
> "org.apache.activemq:artemis-jms-client:1.5.5" where it works ok and another
> for "org.apache.activemq:artemis-jms-client:2.6.2" where you can appreciate
> the issue.
> Also I enclose one screenshot where you can see the same object is added
> twice.
> I will also include the broker.xml file to configure the udp cluster + the
> code use for the producer and consumer.
> Note: The only difference when using client 1.5.5 is the queue name
> definition I needed to remove the jms.queue prefix.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750103#comment-16750103 ] ASF subversion and git services commented on ARTEMIS-2236: -- Commit c4ea7a78db0e4cf0a24def5ba21140004a498071 in activemq-artemis's branch refs/heads/2.6.x from Michael André Pearce [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=c4ea7a7 ] ARTEMIS-2236 - Revert Original ARTEMIS-1451 This reverts commit f8b758d1 (cherry picked from commit b9a063f2e715eeac05860dc4977dac9221e6aa93) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 13h 20m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1451) Remove synchronization on ActiveMQThreadPoolExecutor
[ https://issues.apache.org/jira/browse/ARTEMIS-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750104#comment-16750104 ] ASF subversion and git services commented on ARTEMIS-1451: -- Commit c4ea7a78db0e4cf0a24def5ba21140004a498071 in activemq-artemis's branch refs/heads/2.6.x from Michael André Pearce [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=c4ea7a7 ] ARTEMIS-2236 - Revert Original ARTEMIS-1451 This reverts commit f8b758d1 (cherry picked from commit b9a063f2e715eeac05860dc4977dac9221e6aa93) > Remove synchronization on ActiveMQThreadPoolExecutor > > > Key: ARTEMIS-1451 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1451 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.3.0 >Reporter: Luis Barreiro >Priority: Critical > Fix For: 2.4.0 > > > Leverage extension points on ThreadPoolExecutor to remove all the > synchronization from ActiveMQThreadPoolExecutor -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1451) Remove synchronization on ActiveMQThreadPoolExecutor
[ https://issues.apache.org/jira/browse/ARTEMIS-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750106#comment-16750106 ] ASF subversion and git services commented on ARTEMIS-1451: -- Commit 87ddafc13d78605814c486178b39037df42ca3a0 in activemq-artemis's branch refs/heads/2.6.x from Michael André Pearce [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=87ddafc ] ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 Readdress ARTEMIS-1451 concern of sync blocks, remove synchronization by simplifying original code and using atomics. (cherry picked from commit d4c41e45bc762f2d8b7831529678bc4061bf9cd3) > Remove synchronization on ActiveMQThreadPoolExecutor > > > Key: ARTEMIS-1451 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1451 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.3.0 >Reporter: Luis Barreiro >Priority: Critical > Fix For: 2.4.0 > > > Leverage extension points on ThreadPoolExecutor to remove all the > synchronization from ActiveMQThreadPoolExecutor -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750105#comment-16750105 ] ASF subversion and git services commented on ARTEMIS-2236: -- Commit 87ddafc13d78605814c486178b39037df42ca3a0 in activemq-artemis's branch refs/heads/2.6.x from Michael André Pearce [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=87ddafc ] ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 Readdress ARTEMIS-1451 concern of sync blocks, remove synchronization by simplifying original code and using atomics. (cherry picked from commit d4c41e45bc762f2d8b7831529678bc4061bf9cd3) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 13h 20m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1451) Remove synchronization on ActiveMQThreadPoolExecutor
[ https://issues.apache.org/jira/browse/ARTEMIS-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750107#comment-16750107 ] ASF subversion and git services commented on ARTEMIS-1451: -- Commit 87ddafc13d78605814c486178b39037df42ca3a0 in activemq-artemis's branch refs/heads/2.6.x from Michael André Pearce [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=87ddafc ] ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 Readdress ARTEMIS-1451 concern of sync blocks, remove synchronization by simplifying original code and using atomics. (cherry picked from commit d4c41e45bc762f2d8b7831529678bc4061bf9cd3) > Remove synchronization on ActiveMQThreadPoolExecutor > > > Key: ARTEMIS-1451 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1451 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.3.0 >Reporter: Luis Barreiro >Priority: Critical > Fix For: 2.4.0 > > > Leverage extension points on ThreadPoolExecutor to remove all the > synchronization from ActiveMQThreadPoolExecutor -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1451) Remove synchronization on ActiveMQThreadPoolExecutor
[ https://issues.apache.org/jira/browse/ARTEMIS-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750098#comment-16750098 ] ASF subversion and git services commented on ARTEMIS-1451: -- Commit d4c41e45bc762f2d8b7831529678bc4061bf9cd3 in activemq-artemis's branch refs/heads/master from Michael André Pearce [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=d4c41e4 ] ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 Readdress ARTEMIS-1451 concern of sync blocks, remove synchronization by simplifying original code and using atomics. > Remove synchronization on ActiveMQThreadPoolExecutor > > > Key: ARTEMIS-1451 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1451 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.3.0 >Reporter: Luis Barreiro >Priority: Critical > Fix For: 2.4.0 > > > Leverage extension points on ThreadPoolExecutor to remove all the > synchronization from ActiveMQThreadPoolExecutor -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1451) Remove synchronization on ActiveMQThreadPoolExecutor
[ https://issues.apache.org/jira/browse/ARTEMIS-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750096#comment-16750096 ] ASF subversion and git services commented on ARTEMIS-1451: -- Commit b9a063f2e715eeac05860dc4977dac9221e6aa93 in activemq-artemis's branch refs/heads/master from Michael André Pearce [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=b9a063f ] ARTEMIS-2236 - Revert Original ARTEMIS-1451 This reverts commit f8b758d1 > Remove synchronization on ActiveMQThreadPoolExecutor > > > Key: ARTEMIS-1451 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1451 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.3.0 >Reporter: Luis Barreiro >Priority: Critical > Fix For: 2.4.0 > > > Leverage extension points on ThreadPoolExecutor to remove all the > synchronization from ActiveMQThreadPoolExecutor -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750097#comment-16750097 ] ASF subversion and git services commented on ARTEMIS-2236: -- Commit d4c41e45bc762f2d8b7831529678bc4061bf9cd3 in activemq-artemis's branch refs/heads/master from Michael André Pearce [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=d4c41e4 ] ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 Readdress ARTEMIS-1451 concern of sync blocks, remove synchronization by simplifying original code and using atomics. > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 13h 10m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=189005&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189005 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 15:11 Start Date: 23/Jan/19 15:11 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 189005) Time Spent: 13h 20m (was: 13h 10m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 13h 20m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-1451) Remove synchronization on ActiveMQThreadPoolExecutor
[ https://issues.apache.org/jira/browse/ARTEMIS-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750099#comment-16750099 ] ASF subversion and git services commented on ARTEMIS-1451: -- Commit d4c41e45bc762f2d8b7831529678bc4061bf9cd3 in activemq-artemis's branch refs/heads/master from Michael André Pearce [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=d4c41e4 ] ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 Readdress ARTEMIS-1451 concern of sync blocks, remove synchronization by simplifying original code and using atomics. > Remove synchronization on ActiveMQThreadPoolExecutor > > > Key: ARTEMIS-1451 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1451 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.3.0 >Reporter: Luis Barreiro >Priority: Critical > Fix For: 2.4.0 > > > Leverage extension points on ThreadPoolExecutor to remove all the > synchronization from ActiveMQThreadPoolExecutor -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16750095#comment-16750095 ] ASF subversion and git services commented on ARTEMIS-2236: -- Commit b9a063f2e715eeac05860dc4977dac9221e6aa93 in activemq-artemis's branch refs/heads/master from Michael André Pearce [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=b9a063f ] ARTEMIS-2236 - Revert Original ARTEMIS-1451 This reverts commit f8b758d1 > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 13h 10m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188981&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188981 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 14:29 Start Date: 23/Jan/19 14:29 Worklog Time Spent: 10m Work Description: clebertsuconic commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456821582 Give me some time to digest this, and I will bring it into 2.6.x as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188981) Time Spent: 13h (was: 12h 50m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 13h > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188871&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188871 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 11:43 Start Date: 23/Jan/19 11:43 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456771497 @franz1981 anything else do shout, it is appreciated to have the review :) as you know we enjoy the debates .. hehehe. Can i leave with you to merge once you've got yourself happy. Once merged, ill then do a cherry pick to 2.6.x This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188871) Time Spent: 12h 50m (was: 12h 40m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 12h 50m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188843&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188843 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 11:08 Start Date: 23/Jan/19 11:08 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456762201 Thanks to have verified, my laptop was giving weird results probably due to low core numbers :( This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188843) Time Spent: 12h 40m (was: 12.5h) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 12h 40m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188841&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188841 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 11:07 Start Date: 23/Jan/19 11:07 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456761882 No discussions bud, just an observation: I have written this old tests some time ago and given that I haven't enough cores I cannot run it with meaningful results :) Yep, there are some math errors but is just to give a broad idea of task distribution logic. I see that the results are similar so I'm happy about it :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188841) Time Spent: 12.5h (was: 12h 20m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 12.5h > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188836&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188836 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 10:49 Start Date: 23/Jan/19 10:49 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456756498 @franz1981 im getting very similar results in distribution, not sure what you are trying to discuss or if its relevant here? Apart from there is obviously some math rounding error in your test code as totals are 96% and 97% ARTEMIS-2236 2 % for consumer = 1 29 % for consumer = 2 2 % for consumer = 3 30 % for consumer = 4 2 % for consumer = 5 29 % for consumer = 6 2 % for consumer = 7 ARTEMIS-1451 2 % for consumer = 1 29 % for consumer = 2 2 % for consumer = 3 30 % for consumer = 4 2 % for consumer = 5 30 % for consumer = 6 2 % for consumer = 7 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188836) Time Spent: 12h 20m (was: 12h 10m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 12h 20m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[
https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188807&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188807
]
ASF GitHub Bot logged work on ARTEMIS-2236:
---
Author: ASF GitHub Bot
Created on: 23/Jan/19 10:27
Start Date: 23/Jan/19 10:27
Worklog Time Spent: 10m
Work Description: franz1981 commented on issue #2514: ARTEMIS-2236
Address Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456749562
@michaelandrepearce
PLease run this one:
```
public static void main(String[] args) throws Throwable {
final int consumers = 7;
final int producers = 1;
ExecutorService es = new ActiveMQThreadPoolExecutor(0, consumers,
60, TimeUnit.SECONDS, Thread::new);
ExecutorService producerExecutor =
Executors.newFixedThreadPool(producers);
final int tasks = 10_000_000;
final AtomicLongArray executedTasks = new AtomicLongArray(consumers);
final AtomicInteger consumerIndex = new AtomicInteger();
final ThreadLocal position =
ThreadLocal.withInitial(consumerIndex::getAndIncrement);
final Runnable producer = () -> {
for (int i = 0; i < tasks; i++) {
es.submit(() -> {
final int index = position.get();
executedTasks.lazySet(index, executedTasks.get(index) +
1);
if (index % 2 == 0) {
LockSupport.parkNanos(1);
}
});
}
};
for (int i = 0; i < producers; i++) {
producerExecutor.execute(producer);
}
final long expectedExecuted = tasks * producers;
long totalExecuted;
do {
totalExecuted = 0;
for (int i = 0; i < consumers; i++) {
totalExecuted += executedTasks.get(i);
}
if (totalExecuted == expectedExecuted) {
break;
} else {
TimeUnit.SECONDS.sleep(1);
}
} while (true);
//print execution summaries
for (int i = 0; i < consumers; i++) {
System.out.println(((executedTasks.get(i) * 100) /
expectedExecuted) + " % for consumer = " + (i + 1));
}
producerExecutor.shutdown();
es.shutdown();
}
```
You can run it with both the old version (the broken one) or the ones on
your PR and you can check what is the actual task distribution: you will see
that the behaviour is very different.
That's somthing to consider IMHO, but please try it and tell me wdyt
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 188807)
Time Spent: 12h 10m (was: 12h)
> Address Latency Impact caused by ARTEMIS-1451
> -
>
> Key: ARTEMIS-2236
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2236
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.4.0, 2.5.0, 2.6.0
>Reporter: Michael Andre Pearce
>Priority: Blocker
> Time Spent: 12h 10m
> Remaining Estimate: 0h
>
> h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as
> the overhead of creating a new thread vs re-using an idle one is significant.
> It is the main reason of a thread pool.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188797&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188797 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 10:18 Start Date: 23/Jan/19 10:18 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456746664 > Franz is the man He is indeed!! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188797) Time Spent: 12h (was: 11h 50m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 12h > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[
https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188794&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188794
]
ASF GitHub Bot logged work on ARTEMIS-2236:
---
Author: ASF GitHub Bot
Created on: 23/Jan/19 10:05
Start Date: 23/Jan/19 10:05
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2514:
ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#discussion_r250125913
##
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ActiveMQThreadPoolExecutor.java
##
@@ -64,20 +63,15 @@ public void setExecutor(ActiveMQThreadPoolExecutor
executor) {
public boolean offer(Runnable runnable) {
boolean retval = false;
- // Need to lock for 2 reasons:
- // 1. to safely handle poll timeouts
- // 2. to protect the delta from parallel updates
- synchronized (lock) {
-if ((executor.getPoolSize() >= executor.getMaximumPoolSize()) ||
(threadTaskDelta > 0)) {
- // A new task will be added to the queue if the maximum number
of threads has been reached
- // or if the delta is > 0, which means that there are enough
idle threads.
+ if (threadTaskDelta > 0 || (executor.getPoolSize() >=
executor.getMaximumPoolSize())) {
Review comment:
getPoolSize uses a re-entrant lock underneath in the ThreadPoolExecutor, so
we possible can avoid that when we have idle threads.
if threadTaskDelta > 0 (which means we have idle) then we can offer, we only
need to see if we are at max if we dont have idle.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 188794)
Time Spent: 11h 40m (was: 11.5h)
> Address Latency Impact caused by ARTEMIS-1451
> -
>
> Key: ARTEMIS-2236
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2236
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.4.0, 2.5.0, 2.6.0
>Reporter: Michael Andre Pearce
>Priority: Blocker
> Time Spent: 11h 40m
> Remaining Estimate: 0h
>
> h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as
> the overhead of creating a new thread vs re-using an idle one is significant.
> It is the main reason of a thread pool.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[
https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188792&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188792
]
ASF GitHub Bot logged work on ARTEMIS-2236:
---
Author: ASF GitHub Bot
Created on: 23/Jan/19 10:04
Start Date: 23/Jan/19 10:04
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2514:
ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#discussion_r250125913
##
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ActiveMQThreadPoolExecutor.java
##
@@ -64,20 +63,15 @@ public void setExecutor(ActiveMQThreadPoolExecutor
executor) {
public boolean offer(Runnable runnable) {
boolean retval = false;
- // Need to lock for 2 reasons:
- // 1. to safely handle poll timeouts
- // 2. to protect the delta from parallel updates
- synchronized (lock) {
-if ((executor.getPoolSize() >= executor.getMaximumPoolSize()) ||
(threadTaskDelta > 0)) {
- // A new task will be added to the queue if the maximum number
of threads has been reached
- // or if the delta is > 0, which means that there are enough
idle threads.
+ if (threadTaskDelta > 0 || (executor.getPoolSize() >=
executor.getMaximumPoolSize())) {
Review comment:
getPoolSize uses a lock underneath in the executor, so we possible can
avoid that when we have idle threads.
if threadTaskDelta > 0 (which means we have idle) then we can offer, we only
need to see if we are at max if we dont have idle.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 188792)
Time Spent: 11h 20m (was: 11h 10m)
> Address Latency Impact caused by ARTEMIS-1451
> -
>
> Key: ARTEMIS-2236
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2236
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.4.0, 2.5.0, 2.6.0
>Reporter: Michael Andre Pearce
>Priority: Blocker
> Time Spent: 11h 20m
> Remaining Estimate: 0h
>
> h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as
> the overhead of creating a new thread vs re-using an idle one is significant.
> It is the main reason of a thread pool.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188795&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188795 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 10:05 Start Date: 23/Jan/19 10:05 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456742777 @franz1981 @gemmellr split the commits (there is now 2) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188795) Time Spent: 11h 50m (was: 11h 40m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 11h 50m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[
https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188793&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188793
]
ASF GitHub Bot logged work on ARTEMIS-2236:
---
Author: ASF GitHub Bot
Created on: 23/Jan/19 10:04
Start Date: 23/Jan/19 10:04
Worklog Time Spent: 10m
Work Description: franz1981 commented on pull request #2514: ARTEMIS-2236
Address Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#discussion_r250126131
##
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ActiveMQThreadPoolExecutor.java
##
@@ -64,20 +63,15 @@ public void setExecutor(ActiveMQThreadPoolExecutor
executor) {
public boolean offer(Runnable runnable) {
boolean retval = false;
- // Need to lock for 2 reasons:
- // 1. to safely handle poll timeouts
- // 2. to protect the delta from parallel updates
- synchronized (lock) {
-if ((executor.getPoolSize() >= executor.getMaximumPoolSize()) ||
(threadTaskDelta > 0)) {
- // A new task will be added to the queue if the maximum number
of threads has been reached
- // or if the delta is > 0, which means that there are enough
idle threads.
+ if (threadTaskDelta > 0 || (executor.getPoolSize() >=
executor.getMaximumPoolSize())) {
Review comment:
Ahhh is see that there is a lock there, that's why!
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 188793)
Time Spent: 11.5h (was: 11h 20m)
> Address Latency Impact caused by ARTEMIS-1451
> -
>
> Key: ARTEMIS-2236
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2236
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.4.0, 2.5.0, 2.6.0
>Reporter: Michael Andre Pearce
>Priority: Blocker
> Time Spent: 11.5h
> Remaining Estimate: 0h
>
> h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as
> the overhead of creating a new thread vs re-using an idle one is significant.
> It is the main reason of a thread pool.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[
https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188791&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188791
]
ASF GitHub Bot logged work on ARTEMIS-2236:
---
Author: ASF GitHub Bot
Created on: 23/Jan/19 10:04
Start Date: 23/Jan/19 10:04
Worklog Time Spent: 10m
Work Description: franz1981 commented on pull request #2514: ARTEMIS-2236
Address Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#discussion_r250124916
##
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ActiveMQThreadPoolExecutor.java
##
@@ -64,20 +63,15 @@ public void setExecutor(ActiveMQThreadPoolExecutor
executor) {
public boolean offer(Runnable runnable) {
boolean retval = false;
- // Need to lock for 2 reasons:
- // 1. to safely handle poll timeouts
- // 2. to protect the delta from parallel updates
- synchronized (lock) {
-if ((executor.getPoolSize() >= executor.getMaximumPoolSize()) ||
(threadTaskDelta > 0)) {
- // A new task will be added to the queue if the maximum number
of threads has been reached
- // or if the delta is > 0, which means that there are enough
idle threads.
+ if (threadTaskDelta > 0 || (executor.getPoolSize() >=
executor.getMaximumPoolSize())) {
Review comment:
Not a significan change, but why you've inverted the checks here?
The common path should be that you have all the threads busy up and running
(so `executor.getPoolSize() >= executor.getMaximumPoolSize() = true`): it would
avoid checking the delta...
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 188791)
Time Spent: 11h 10m (was: 11h)
> Address Latency Impact caused by ARTEMIS-1451
> -
>
> Key: ARTEMIS-2236
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2236
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.4.0, 2.5.0, 2.6.0
>Reporter: Michael Andre Pearce
>Priority: Blocker
> Time Spent: 11h 10m
> Remaining Estimate: 0h
>
> h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as
> the overhead of creating a new thread vs re-using an idle one is significant.
> It is the main reason of a thread pool.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[
https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188789&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188789
]
ASF GitHub Bot logged work on ARTEMIS-2236:
---
Author: ASF GitHub Bot
Created on: 23/Jan/19 10:01
Start Date: 23/Jan/19 10:01
Worklog Time Spent: 10m
Work Description: franz1981 commented on pull request #2514: ARTEMIS-2236
Address Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#discussion_r250124916
##
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ActiveMQThreadPoolExecutor.java
##
@@ -64,20 +63,15 @@ public void setExecutor(ActiveMQThreadPoolExecutor
executor) {
public boolean offer(Runnable runnable) {
boolean retval = false;
- // Need to lock for 2 reasons:
- // 1. to safely handle poll timeouts
- // 2. to protect the delta from parallel updates
- synchronized (lock) {
-if ((executor.getPoolSize() >= executor.getMaximumPoolSize()) ||
(threadTaskDelta > 0)) {
- // A new task will be added to the queue if the maximum number
of threads has been reached
- // or if the delta is > 0, which means that there are enough
idle threads.
+ if (threadTaskDelta > 0 || (executor.getPoolSize() >=
executor.getMaximumPoolSize())) {
Review comment:
Not a significan change, but why you've reverted the checks here?
The common path should be that you have all the threads busy up and running
(so `executor.getPoolSize() >= executor.getMaximumPoolSize() = true`): it would
avoid checking the delta...
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 188789)
Time Spent: 11h (was: 10h 50m)
> Address Latency Impact caused by ARTEMIS-1451
> -
>
> Key: ARTEMIS-2236
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2236
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.4.0, 2.5.0, 2.6.0
>Reporter: Michael Andre Pearce
>Priority: Blocker
> Time Spent: 11h
> Remaining Estimate: 0h
>
> h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as
> the overhead of creating a new thread vs re-using an idle one is significant.
> It is the main reason of a thread pool.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188786&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188786 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 09:57 Start Date: 23/Jan/19 09:57 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-45673 @michaelandrepearce > but @gemmellr sold me. Ill split the commits I can say that's the right thing to do, @gemmellr has proposed something that worth to do :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188786) Time Spent: 10h 50m (was: 10h 40m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 10h 50m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188780&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188780 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 09:50 Start Date: 23/Jan/19 09:50 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456737591 @gemmellr @franz1981 i was in two minds as normally get asked to squash, but @gemmellr sold me. Ill split the commits This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188780) Time Spent: 10h 40m (was: 10.5h) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 10h 40m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188776&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188776 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 09:39 Start Date: 23/Jan/19 09:39 Worklog Time Spent: 10m Work Description: gemmellr commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456734370 Franz is the man for this type of thing so I'll leave him to the review, but I do think having a separate specific revert commit would have actually been a good idea given it looks to change so much, making it easier for someone looking at 'actual changes' from the original to do so easily. Essentially, in general I think if its worth actually reverting something, do that specifically. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188776) Time Spent: 10.5h (was: 10h 20m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 10.5h > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188751&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188751 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 09:09 Start Date: 23/Jan/19 09:09 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456724549 @franz1981 yup agree there are some improvements we could have done, but have left them out As right now, the main part is dealing with the behaviour/latency regression and still addressing 1451's concerns of sync blocks. As need this fixed also in 2.6.x branch as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188751) Time Spent: 7h 40m (was: 7.5h) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 7h 40m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188757&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188757 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 09:12 Start Date: 23/Jan/19 09:12 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456725467 @franz1981 no indeed, and thats not what im doing. Im reverting but also removed the need for the sync blocks, and using atomic updater to the threadTaskDelta which was the original 1451 goal. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188757) Time Spent: 8h 40m (was: 8.5h) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 8h 40m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188753&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188753 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 09:10 Start Date: 23/Jan/19 09:10 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456725073 @michaelandrepearce Yep, but consider that providing a lock-free implementation *is* an improvement that need to be reviewed: is not just a plain revert... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188753) Time Spent: 8h (was: 7h 50m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 8h > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188761&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188761 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 09:13 Start Date: 23/Jan/19 09:13 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456725981 I can make it a two stage commit if it helps? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188761) Time Spent: 9h 10m (was: 9h) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 9h 10m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188769&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188769 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 09:19 Start Date: 23/Jan/19 09:19 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456727829 Yess and sorry for the "interrogation": given that's a core part you know that I'm just concerned to understand it :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188769) Time Spent: 10h 20m (was: 10h 10m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 10h 20m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188768&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188768 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 09:18 Start Date: 23/Jan/19 09:18 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456727468 Please go ahread ? does this mean youre happy? If so could you merge? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188768) Time Spent: 10h 10m (was: 10h) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 10h 10m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188767&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188767 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 09:17 Start Date: 23/Jan/19 09:17 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456727468 Please go ahread ? does this mean youre happy? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188767) Time Spent: 10h (was: 9h 50m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 10h > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188764&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188764 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 09:17 Start Date: 23/Jan/19 09:17 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456727255 @michaelandrepearce no no, bud don't worry: this was my ignorance :) I've just look at the origianal version and I totally agree with you: the issues I've outlined exists (safe-construction etc etc), but was present in the original version too :O Please go ahread and I will post you a branch I've done in the past on this :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188764) Time Spent: 9h 40m (was: 9.5h) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 9h 40m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188766&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188766 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 09:17 Start Date: 23/Jan/19 09:17 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456727255 @michaelandrepearce no no, bud don't worry: this was my ignorance :) I've just look at the original version and I totally agree with you: the issues I've outlined exists (safe-construction etc etc), but was present in the original version too :O Please go ahread and I will post you a branch I've done in the past on this :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188766) Time Spent: 9h 50m (was: 9h 40m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 9h 50m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[
https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188763&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188763
]
ASF GitHub Bot logged work on ARTEMIS-2236:
---
Author: ASF GitHub Bot
Created on: 23/Jan/19 09:16
Start Date: 23/Jan/19 09:16
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2514:
ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#discussion_r250108599
##
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ActiveMQThreadPoolExecutor.java
##
@@ -29,33 +29,129 @@
* and will be removed after idling for a specified keep time.
* But in contrast to a standard cached executor, tasks are queued if the
* maximum pool size if reached, instead of rejected.
+ *
+ * This is achieved by using a specialized blocking queue, which checks the
+ * state of the associated executor in the offer method to decide whether to
+ * queue a task or have the executor create another thread.
+ *
+ * Since the thread pool's execute method is reentrant, more than one caller
+ * could try to offer a task into the queue. There is a small chance that
+ * (a few) more threads are created as it should be limited by max pool size.
+ * To allow for such a case not to reject a task, the underlying thread pool
+ * executor is not limited. Only the offer method checks the configured limit.
*/
public class ActiveMQThreadPoolExecutor extends ThreadPoolExecutor {
- // Handler executed when a task is submitted and a new thread cannot be
created (because maxSize was reached)
- // It queues the task on the executors's queue (using the add() method, see
ThreadPoolQueue class below)
- private static final RejectedExecutionHandler QUEUE_EXECUTION_HANDLER = (r,
e) -> {
- if (!e.isShutdown()) {
- e.getQueue().add(r);
- }
- };
-
- // A specialized LinkedBlockingQueue that takes new elements by calling
add() but not offer()
- // This is to force the ThreadPoolExecutor to always create new threads and
never queue
+ @SuppressWarnings("serial")
private static class ThreadPoolQueue extends LinkedBlockingQueue {
+ private ActiveMQThreadPoolExecutor executor = null;
+
+ // keep track of the difference between the number of idle threads and
+ // the number of queued tasks. If the delta is > 0, we have more
+ // idle threads than queued tasks and can add more tasks into the queue.
+ // The delta is incremented if a thread becomes idle or if a task is
taken from the queue.
+ // The delta is decremented if a thread leaves idle state or if a task
is added to the queue.
+ private static final AtomicIntegerFieldUpdater
DELTA_UPDATER = AtomicIntegerFieldUpdater.newUpdater(ThreadPoolQueue.class,
"threadTaskDelta");
+ private volatile int threadTaskDelta = 0;
+
+ public void setExecutor(ActiveMQThreadPoolExecutor executor) {
+ this.executor = executor;
+ }
+
@Override
public boolean offer(Runnable runnable) {
- return false;
+ boolean retval = false;
+
+ if (threadTaskDelta > 0 || (executor.getPoolSize() >=
executor.getMaximumPoolSize())) {
+// A new task will be added to the queue if the maximum number of
threads has been reached
+// or if the delta is > 0, which means that there are enough idle
threads.
+
+retval = super.offer(runnable);
+
+// Only decrement the delta if the task has actually been added to
the queue
+if (retval)
+ DELTA_UPDATER.incrementAndGet(this);
+ }
+
+
+ return retval;
+ }
+
+ @Override
+ public Runnable take() throws InterruptedException {
+ // Increment the delta as a thread becomes idle
+ // by waiting for a task to take from the queue
+ DELTA_UPDATER.incrementAndGet(this);
+
+
+ Runnable runnable = null;
+
+ try {
+runnable = super.take();
+return runnable;
+ } finally {
+// Now the thread is no longer idle waiting for a task
+// If it had taken a task, the delta remains the same
+// (decremented by the thread and incremented by the taken task)
+// Only if no task had been taken, we have to decrement the delta.
+if (runnable == null) {
+ DELTA_UPDATER.decrementAndGet(this);
+
+}
+ }
}
@Override
- public boolean add(Runnable runnable) {
- return super.offer( runnable );
+ public Runnable poll(long arg0, TimeUnit arg2) throws
InterruptedException {
+ // Increment the delta as a thread becomes idle
+ // by waiting for a task to poll from the queue
+ DELTA_UP
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188762&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188762 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 09:14 Start Date: 23/Jan/19 09:14 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456725981 I can un-squash and make it a two stage commit if it helps? e.g. revert commit, then remove sync block commit. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188762) Time Spent: 9h 20m (was: 9h 10m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 9h 20m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188694&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188694 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 08:18 Start Date: 23/Jan/19 08:18 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456709895 To show this, using a broker with persistance disabled (to remove external disk perf factors) Using CORE Producer -> Consume Result is latency in microseconds average per 1 messages (20 runs) CURRENT MASTER RESULT: 292 RESULT: 187 RESULT: 151 RESULT: 124 RESULT: 109 RESULT: 148 RESULT: 121 RESULT: 127 RESULT: 104 RESULT: 201 RESULT: 118 RESULT: 116 RESULT: 115 RESULT: 153 RESULT: 126 RESULT: 127 RESULT: 107 RESULT: 128 RESULT: 121 RESULT: 126 WITH REVERTING AND APPLYING THIS FIX RESULT: 249 RESULT: 173 RESULT: 150 RESULT: 120 RESULT: 127 RESULT: 124 RESULT: 140 RESULT: 122 RESULT: 106 RESULT: 100 RESULT: 96 RESULT: 104 RESULT: 103 RESULT: 96 RESULT: 92 RESULT: 94 RESULT: 100 RESULT: 91 RESULT: 101 RESULT: 100 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188694) Time Spent: 40m (was: 0.5h) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 40m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188760&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188760 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 09:12 Start Date: 23/Jan/19 09:12 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456725467 @franz1981 no indeed, and thats not what im doing. Im reverting but also removed the need for the sync blocks(which was the original 1451 goal.), and using atomic updater to the threadTaskDelta This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188760) Time Spent: 9h (was: 8h 50m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 9h > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188759&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188759 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 09:12 Start Date: 23/Jan/19 09:12 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456725789 > I'm reverting but also removed the need for the sync blocks, and using atomic updater to the threadTaskDelta Let me take a look to the original code and I can tell you :+1: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188759) Time Spent: 8h 50m (was: 8h 40m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 8h 50m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[
https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188756&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188756
]
ASF GitHub Bot logged work on ARTEMIS-2236:
---
Author: ASF GitHub Bot
Created on: 23/Jan/19 09:11
Start Date: 23/Jan/19 09:11
Worklog Time Spent: 10m
Work Description: franz1981 commented on pull request #2514: ARTEMIS-2236
Address Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#discussion_r250105709
##
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ActiveMQThreadPoolExecutor.java
##
@@ -29,33 +29,129 @@
* and will be removed after idling for a specified keep time.
* But in contrast to a standard cached executor, tasks are queued if the
* maximum pool size if reached, instead of rejected.
+ *
+ * This is achieved by using a specialized blocking queue, which checks the
+ * state of the associated executor in the offer method to decide whether to
+ * queue a task or have the executor create another thread.
+ *
+ * Since the thread pool's execute method is reentrant, more than one caller
+ * could try to offer a task into the queue. There is a small chance that
+ * (a few) more threads are created as it should be limited by max pool size.
+ * To allow for such a case not to reject a task, the underlying thread pool
+ * executor is not limited. Only the offer method checks the configured limit.
*/
public class ActiveMQThreadPoolExecutor extends ThreadPoolExecutor {
- // Handler executed when a task is submitted and a new thread cannot be
created (because maxSize was reached)
- // It queues the task on the executors's queue (using the add() method, see
ThreadPoolQueue class below)
- private static final RejectedExecutionHandler QUEUE_EXECUTION_HANDLER = (r,
e) -> {
- if (!e.isShutdown()) {
- e.getQueue().add(r);
- }
- };
-
- // A specialized LinkedBlockingQueue that takes new elements by calling
add() but not offer()
- // This is to force the ThreadPoolExecutor to always create new threads and
never queue
+ @SuppressWarnings("serial")
private static class ThreadPoolQueue extends LinkedBlockingQueue {
+ private ActiveMQThreadPoolExecutor executor = null;
+
+ // keep track of the difference between the number of idle threads and
+ // the number of queued tasks. If the delta is > 0, we have more
+ // idle threads than queued tasks and can add more tasks into the queue.
+ // The delta is incremented if a thread becomes idle or if a task is
taken from the queue.
+ // The delta is decremented if a thread leaves idle state or if a task
is added to the queue.
+ private static final AtomicIntegerFieldUpdater
DELTA_UPDATER = AtomicIntegerFieldUpdater.newUpdater(ThreadPoolQueue.class,
"threadTaskDelta");
+ private volatile int threadTaskDelta = 0;
+
+ public void setExecutor(ActiveMQThreadPoolExecutor executor) {
+ this.executor = executor;
+ }
+
@Override
public boolean offer(Runnable runnable) {
- return false;
+ boolean retval = false;
+
+ if (threadTaskDelta > 0 || (executor.getPoolSize() >=
executor.getMaximumPoolSize())) {
+// A new task will be added to the queue if the maximum number of
threads has been reached
+// or if the delta is > 0, which means that there are enough idle
threads.
+
+retval = super.offer(runnable);
+
+// Only decrement the delta if the task has actually been added to
the queue
+if (retval)
+ DELTA_UPDATER.incrementAndGet(this);
+ }
+
+
+ return retval;
+ }
+
+ @Override
+ public Runnable take() throws InterruptedException {
+ // Increment the delta as a thread becomes idle
+ // by waiting for a task to take from the queue
+ DELTA_UPDATER.incrementAndGet(this);
+
+
+ Runnable runnable = null;
+
+ try {
+runnable = super.take();
+return runnable;
+ } finally {
+// Now the thread is no longer idle waiting for a task
+// If it had taken a task, the delta remains the same
+// (decremented by the thread and incremented by the taken task)
+// Only if no task had been taken, we have to decrement the delta.
+if (runnable == null) {
+ DELTA_UPDATER.decrementAndGet(this);
+
+}
+ }
}
@Override
- public boolean add(Runnable runnable) {
- return super.offer( runnable );
+ public Runnable poll(long arg0, TimeUnit arg2) throws
InterruptedException {
+ // Increment the delta as a thread becomes idle
+ // by waiting for a task to poll from the queue
+ DELTA_UPDATER.inc
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188755&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188755 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 09:11 Start Date: 23/Jan/19 09:11 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456725467 @franz1981 no indeed, and thats not what im doing. Im reverting but also removed the need for the sync blocks, and using atomic updater to the threadTaskDelta This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188755) Time Spent: 8h 20m (was: 8h 10m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 8h 20m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188752&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188752 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 09:10 Start Date: 23/Jan/19 09:10 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456724549 @franz1981 yup agree there are some improvements we could have done, but have left them out. As right now, the main priority (and this PR) is dealing with the behaviour/latency regression and still addressing 1451's concerns of sync blocks. As need this fixed also in 2.6.x branch as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188752) Time Spent: 7h 50m (was: 7h 40m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 7h 50m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[
https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188754&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188754
]
ASF GitHub Bot logged work on ARTEMIS-2236:
---
Author: ASF GitHub Bot
Created on: 23/Jan/19 09:10
Start Date: 23/Jan/19 09:10
Worklog Time Spent: 10m
Work Description: franz1981 commented on pull request #2514: ARTEMIS-2236
Address Latency Impact caused by ARTEMIS-1451
URL: https://github.com/apache/activemq-artemis/pull/2514#discussion_r250105709
##
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ActiveMQThreadPoolExecutor.java
##
@@ -29,33 +29,129 @@
* and will be removed after idling for a specified keep time.
* But in contrast to a standard cached executor, tasks are queued if the
* maximum pool size if reached, instead of rejected.
+ *
+ * This is achieved by using a specialized blocking queue, which checks the
+ * state of the associated executor in the offer method to decide whether to
+ * queue a task or have the executor create another thread.
+ *
+ * Since the thread pool's execute method is reentrant, more than one caller
+ * could try to offer a task into the queue. There is a small chance that
+ * (a few) more threads are created as it should be limited by max pool size.
+ * To allow for such a case not to reject a task, the underlying thread pool
+ * executor is not limited. Only the offer method checks the configured limit.
*/
public class ActiveMQThreadPoolExecutor extends ThreadPoolExecutor {
- // Handler executed when a task is submitted and a new thread cannot be
created (because maxSize was reached)
- // It queues the task on the executors's queue (using the add() method, see
ThreadPoolQueue class below)
- private static final RejectedExecutionHandler QUEUE_EXECUTION_HANDLER = (r,
e) -> {
- if (!e.isShutdown()) {
- e.getQueue().add(r);
- }
- };
-
- // A specialized LinkedBlockingQueue that takes new elements by calling
add() but not offer()
- // This is to force the ThreadPoolExecutor to always create new threads and
never queue
+ @SuppressWarnings("serial")
private static class ThreadPoolQueue extends LinkedBlockingQueue {
+ private ActiveMQThreadPoolExecutor executor = null;
+
+ // keep track of the difference between the number of idle threads and
+ // the number of queued tasks. If the delta is > 0, we have more
+ // idle threads than queued tasks and can add more tasks into the queue.
+ // The delta is incremented if a thread becomes idle or if a task is
taken from the queue.
+ // The delta is decremented if a thread leaves idle state or if a task
is added to the queue.
+ private static final AtomicIntegerFieldUpdater
DELTA_UPDATER = AtomicIntegerFieldUpdater.newUpdater(ThreadPoolQueue.class,
"threadTaskDelta");
+ private volatile int threadTaskDelta = 0;
+
+ public void setExecutor(ActiveMQThreadPoolExecutor executor) {
+ this.executor = executor;
+ }
+
@Override
public boolean offer(Runnable runnable) {
- return false;
+ boolean retval = false;
+
+ if (threadTaskDelta > 0 || (executor.getPoolSize() >=
executor.getMaximumPoolSize())) {
+// A new task will be added to the queue if the maximum number of
threads has been reached
+// or if the delta is > 0, which means that there are enough idle
threads.
+
+retval = super.offer(runnable);
+
+// Only decrement the delta if the task has actually been added to
the queue
+if (retval)
+ DELTA_UPDATER.incrementAndGet(this);
+ }
+
+
+ return retval;
+ }
+
+ @Override
+ public Runnable take() throws InterruptedException {
+ // Increment the delta as a thread becomes idle
+ // by waiting for a task to take from the queue
+ DELTA_UPDATER.incrementAndGet(this);
+
+
+ Runnable runnable = null;
+
+ try {
+runnable = super.take();
+return runnable;
+ } finally {
+// Now the thread is no longer idle waiting for a task
+// If it had taken a task, the delta remains the same
+// (decremented by the thread and incremented by the taken task)
+// Only if no task had been taken, we have to decrement the delta.
+if (runnable == null) {
+ DELTA_UPDATER.decrementAndGet(this);
+
+}
+ }
}
@Override
- public boolean add(Runnable runnable) {
- return super.offer( runnable );
+ public Runnable poll(long arg0, TimeUnit arg2) throws
InterruptedException {
+ // Increment the delta as a thread becomes idle
+ // by waiting for a task to poll from the queue
+ DELTA_UPDATER.inc
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188749&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188749 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 09:08 Start Date: 23/Jan/19 09:08 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456724549 @franz1981 yup agree there are some improvements we could have done, but have left them out As right now, the main part is dealing with the behaviour/latency regression and still addressing 1451's concerns of sync blocks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188749) Time Spent: 7h 20m (was: 7h 10m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 7h 20m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188750&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188750 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 09:09 Start Date: 23/Jan/19 09:09 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456724549 @franz1981 yup agree there are some improvements we could have done, but have left them out As right now, the main part is dealing with the behaviour/latency regression and still addressing 1451's concerns of sync blocks. As need this also in 2.6.x branch as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188750) Time Spent: 7.5h (was: 7h 20m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 7.5h > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188748&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188748 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 09:04 Start Date: 23/Jan/19 09:04 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456723336 Yep I see that there are a couple of things that could be addressed due to this + a possible improvement: I will propose the improvement separately, but I believe you will like it :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188748) Time Spent: 7h 10m (was: 7h) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 7h 10m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188747&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188747 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 09:04 Start Date: 23/Jan/19 09:04 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456722769 So all ive done, is revert that change of 1451 to put back semantics. Streamlined the code a tad, so then we can remove sync blocks, and can just make the updating of threadTaskDelta using an atomic updater rather than doing it inside a sync block. Which then re-addresses concern of 1451 which was perf overhead of the sync blocks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188747) Time Spent: 7h (was: 6h 50m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 7h > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188735&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188735 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 08:53 Start Date: 23/Jan/19 08:53 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456719988 Ok, if that's the problem I agree with you that need to be addressed: is not the behaviour of a thread-pool, that we expect to have, but it is mostly hitting when the system is got idle and suddenly start to process messages This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188735) Time Spent: 5h 50m (was: 5h 40m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 5h 50m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188746&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188746 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 09:02 Start Date: 23/Jan/19 09:02 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456722769 So all ive done, is revert that change of 1451 to put back semantics. Streamlined the code a tad, so then we can remove sync blocks, and can just make the updating of threadTaskDelta using an atomic updater rather than doing it inside a sync block. Which then re-addresses concern of 1451 which was sync blocks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188746) Time Spent: 6h 50m (was: 6h 40m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 6h 50m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188742&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188742 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 08:59 Start Date: 23/Jan/19 08:59 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456721762 Now that you've helped me to understand the issue I believe that's correct: let me take a look to the current impl, because there is another thing I have on my "bag" re this one :) Well done to have found it, as you have said, that PR has stealthy entered into the code-base without having clue about the implications :O This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188742) Time Spent: 6.5h (was: 6h 20m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 6.5h > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188743&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188743 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 08:59 Start Date: 23/Jan/19 08:59 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456721762 Now that you've helped me to understand the issue I believe that's correct: let me take a look to the PR code, because there is another thing I have on my "bag" re this one :) Well done to have found it, as you have said, that PR has stealthy entered into the code-base without having clue about the implications :O This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188743) Time Spent: 6h 40m (was: 6.5h) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 6h 40m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188734&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188734 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 08:51 Start Date: 23/Jan/19 08:51 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456719095 @michaelandrepearce Ok and the old thread-pool, assuming max thread count already reached, was equally distributing the load across threads? > roughly correct If I've missed anything, please correct me, it helps me to understand ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188734) Time Spent: 5h 40m (was: 5.5h) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 5h 40m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188733&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188733 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 08:51 Start Date: 23/Jan/19 08:51 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456719095 @michaelandrepearce Ok and the old thread-pool, assuming max thread count already reached, was equally distributing the load across threads? > roughly correct If I've missed anything, please correct me, it helps me to understand ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188733) Time Spent: 5.5h (was: 5h 20m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 5.5h > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188739&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188739 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 08:54 Start Date: 23/Jan/19 08:54 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456720353 So the result i show provide the variance of 200,000 message as its split per 10,000 Just total run time is 15% faster: MASTER = 2801 THIS = 2388 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188739) Time Spent: 6h 20m (was: 6h 10m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 6h 20m > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2236) Address Latency Impact caused by ARTEMIS-1451
[ https://issues.apache.org/jira/browse/ARTEMIS-2236?focusedWorklogId=188737&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188737 ] ASF GitHub Bot logged work on ARTEMIS-2236: --- Author: ASF GitHub Bot Created on: 23/Jan/19 08:53 Start Date: 23/Jan/19 08:53 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2514: ARTEMIS-2236 Address Latency Impact caused by ARTEMIS-1451 URL: https://github.com/apache/activemq-artemis/pull/2514#issuecomment-456719988 Ok, if that's the problem I agree with you that need to be addressed: is not the behaviour of a thread-pool that we expect to have, but it is mostly hitting when the system is got idle and suddenly start to process messages This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 188737) Time Spent: 6h (was: 5h 50m) > Address Latency Impact caused by ARTEMIS-1451 > - > > Key: ARTEMIS-2236 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2236 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.4.0, 2.5.0, 2.6.0 >Reporter: Michael Andre Pearce >Priority: Blocker > Time Spent: 6h > Remaining Estimate: 0h > > h1. ARTEMIS-1451 whilst may have removed syncronisation, increased latency as > the overhead of creating a new thread vs re-using an idle one is significant. > It is the main reason of a thread pool. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
