[jira] [Work logged] (ARTEMIS-2336) Use zero copy to replicate journal/page/large message file
[ https://issues.apache.org/jira/browse/ARTEMIS-2336?focusedWorklogId=270643&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-270643 ] ASF GitHub Bot logged work on ARTEMIS-2336: --- Author: ASF GitHub Bot Created on: 02/Jul/19 06:59 Start Date: 02/Jul/19 06:59 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2666: ARTEMIS-2336 Use zero copy to replicate journal/page/large message file URL: https://github.com/apache/activemq-artemis/pull/2666#issuecomment-507546804 @jbertram I would like to profile the improvement, but it seems ok to me bud, can be merged! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 270643) Time Spent: 7h 40m (was: 7.5h) > Use zero copy to replicate journal/page/large message file > -- > > Key: ARTEMIS-2336 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2336 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Reporter: yangwei >Priority: Major > Time Spent: 7h 40m > Remaining Estimate: 0h > > Use sendfile to replicate files during backup sever bootstrap. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2407) Large message file not deleted if broker crashes between page deleted and pending large message written
[ https://issues.apache.org/jira/browse/ARTEMIS-2407?focusedWorklogId=270648&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-270648 ] ASF GitHub Bot logged work on ARTEMIS-2407: --- Author: ASF GitHub Bot Created on: 02/Jul/19 07:05 Start Date: 02/Jul/19 07:05 Worklog Time Spent: 10m Work Description: wy96f commented on pull request #2738: ARTEMIS-2407 Large message file not deleted if broker crashes between page deleted and pending large message written URL: https://github.com/apache/activemq-artemis/pull/2738 #2549 fixed the problem in journal mode. It ensures pending large message is inserted following by appending delete message record. But in page mode, the problem still exists. We should delete page file after pending large message record is written into disk and before deleting page complete record. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 270648) Time Spent: 10m Remaining Estimate: 0h > Large message file not deleted if broker crashes between page deleted and > pending large message written > --- > > Key: ARTEMIS-2407 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2407 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: yangwei >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > In paging mode, when the broker crashes between page file is deleted and > pending large message is written into disk, the large message file would > never be deleted after startup. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2394) Improve scheduling synchronization for AMQPConnectionContext
[
https://issues.apache.org/jira/browse/ARTEMIS-2394?focusedWorklogId=270768&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-270768
]
ASF GitHub Bot logged work on ARTEMIS-2394:
---
Author: ASF GitHub Bot
Created on: 02/Jul/19 10:03
Start Date: 02/Jul/19 10:03
Worklog Time Spent: 10m
Work Description: franz1981 commented on pull request #2727: ARTEMIS-2394
Improve scheduling sync for AMQPConnectionContext
URL: https://github.com/apache/activemq-artemis/pull/2727#discussion_r299404743
##
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPConnectionContext.java
##
@@ -87,9 +89,8 @@
private final boolean useCoreSubscriptionNaming;
- private boolean isSchedulingCancelled;
- private ScheduledFuture scheduledFuture;
- private final Object schedulingLock = new Object();
+ private static final FutureTask voidFuture = new FutureTask<>(() -> {
}, null);
Review comment:
I suppose that @michaelandrepearce means to rename the variable from
`voidFuture` to `VOID_FUTURE`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 270768)
Time Spent: 3h (was: 2h 50m)
> Improve scheduling synchronization for AMQPConnectionContext
>
>
> Key: ARTEMIS-2394
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2394
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Domenico Bruscino
>Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Locks in connection stuff, artemis was built on the premise of being
> nonblocking. As time goes on more and more blocking locks are being added to
> core code paths.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (ARTEMIS-2401) Implement the Pause method for a Topic
[
https://issues.apache.org/jira/browse/ARTEMIS-2401?focusedWorklogId=270844&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-270844
]
ASF GitHub Bot logged work on ARTEMIS-2401:
---
Author: ASF GitHub Bot
Created on: 02/Jul/19 12:41
Start Date: 02/Jul/19 12:41
Worklog Time Spent: 10m
Work Description: ehsavoie commented on pull request #2731:
[ARTEMIS-2401]: Implement the Pause method for a Topic
URL: https://github.com/apache/activemq-artemis/pull/2731#discussion_r299461586
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/AddressControlImpl.java
##
@@ -373,6 +372,86 @@ public String sendMessage(final Map
headers,
return MBeanInfoHelper.getMBeanAttributesInfo(AddressControl.class);
}
+ @Override
+ public void pause() throws Exception {
+ pause(false);
+ }
+
+ @Override
+ public void pause(boolean persist) throws Exception {
+ if (AuditLogger.isEnabled()) {
+ AuditLogger.pause(addressInfo);
+ }
+ checkStarted();
+
+ clearIO();
+ try {
+ if (!addressInfo.isPaused()) {
+addressInfo.pause();
+if (persist) {
+
server.getStorageManager().storeAddressStatus(addressInfo.getId(),
AddressStatus.PAUSED);
+}
Review comment:
ok
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 270844)
Time Spent: 6h 20m (was: 6h 10m)
> Implement the Pause method for a Topic
> --
>
> Key: ARTEMIS-2401
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2401
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: Broker
>Affects Versions: 2.9.0
>Reporter: Emmanuel Hugonnet
>Priority: Major
> Time Spent: 6h 20m
> Remaining Estimate: 0h
>
> Enable to pause all the consumers of a topic. New subscriptions being
> registered while the topic is in pause will be paused also.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (ARTEMIS-2408) Too many opened FDs after server stops
Domenico Bruscino created ARTEMIS-2408: -- Summary: Too many opened FDs after server stops Key: ARTEMIS-2408 URL: https://issues.apache.org/jira/browse/ARTEMIS-2408 Project: ActiveMQ Artemis Issue Type: Bug Reporter: Domenico Bruscino The number of opened FDs after stop the server on the testsuite is much higher than the number before the server is started, when default netty configuration is used. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ARTEMIS-2129) Cannot delete badly named queue
[
https://issues.apache.org/jira/browse/ARTEMIS-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Bertram resolved ARTEMIS-2129.
-
Resolution: Fixed
Fix Version/s: 2.7.0
The {{::}} syntax is special in Artemis as it denotes a
fully-qualified-queue-name (FQQN). In 2.6.3 you hit this bug, but in 2.7.0 this
was fixed via ARTEMIS-1867.
> Cannot delete badly named queue
> ---
>
> Key: ARTEMIS-2129
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2129
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.6.3
>Reporter: Jan Šmucr
>Priority: Major
> Fix For: 2.7.0
>
>
> I tried to create a queue with something like a prefix and ended up with
> something I cannot use or even delete.
> To try it out:
> # Go to the management console.
> # Create an address:
> {noformat}
> test-address{noformat}
> # Below that address, create a queue:
> {noformat}
> test-address::test-queue{noformat}
> # Try to delete that queue.
> # This appears in the browser console:
> {noformat}
> [Core] Operation destroyQueue(java.lang.String) failed due to:
> org.apache.activemq.artemis.api.core.ActiveMQNonExistentQueueException :
> AMQ119017: Queue test-address::test-queue does not exist{noformat}
> Is there any other way how to delete the invalid binding?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (ARTEMIS-2128) Replication - 2nd backup server is unable to go into passive mode
[
https://issues.apache.org/jira/browse/ARTEMIS-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Bertram resolved ARTEMIS-2128.
-
Resolution: Fixed
Fix Version/s: 2.10.0
I just tested with with 2.10.0-SNAPSHOT and the 2nd backup attached to the live
once the 1st backup once killed.
> Replication - 2nd backup server is unable to go into passive mode
> -
>
> Key: ARTEMIS-2128
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2128
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.6.3
>Reporter: Pawel
>Priority: Major
> Fix For: 2.10.0
>
>
> I've created basic cluster containing master (master) and 2 backups (slave1,
> slave2). When I started cluster, the master is live, the slave1 is backup in
> passive mode, the slave2 is spare backup.
> If I shutdown master, everything is ok (slave1 becomes live and slave2
> becomes passive backup).
> But when I shoutdown slave1 first (master is still live), slave2 is unable to
> go into passive mode (so there are no backup ready to become live).
> Example config:
> master:
> {code:xml}
> ...
> cluster-user
> cluster-password
>
>
> netty-connector
> true
>
> slave1
> slave2
>
>
>
>
>
>
> true
> true
> internal-broker
> my-cluster
>
>
>
> ...
> {code}
> slave1:
> {code:xml}
> ...
> cluster-user
> cluster-password
>
>
> netty-connector
> true
>
> master
> slave2
>
>
>
>
>
>
> internal-broker
> my-cluster
> true
>
>
>
> ...
> {code}
> slave2:
>
> {code:xml}
> ...
> cluster-user
> cluster-password
>
>
> netty-connector
> true
>
> master
> slave1
>
>
>
>
>
>
> internal-broker
> my-cluster
> true
>
>
>
> ...
> {code}
>
> And I've additional question: is it possible to create quorum based on only
> one live server in cluster, so 3 nodes (master, slave1, slave2) would be able
> to vote?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARTEMIS-2128) Replication - 2nd backup server is unable to go into passive mode
[
https://issues.apache.org/jira/browse/ARTEMIS-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16877264#comment-16877264
]
Justin Bertram commented on ARTEMIS-2128:
-
bq. is it possible to create quorum based on only one live server in cluster,
so 3 nodes (master, slave1, slave2) would be able to vote?
No. Slaves don't participate in quorum voting.
> Replication - 2nd backup server is unable to go into passive mode
> -
>
> Key: ARTEMIS-2128
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2128
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.6.3
>Reporter: Pawel
>Priority: Major
> Fix For: 2.10.0
>
>
> I've created basic cluster containing master (master) and 2 backups (slave1,
> slave2). When I started cluster, the master is live, the slave1 is backup in
> passive mode, the slave2 is spare backup.
> If I shutdown master, everything is ok (slave1 becomes live and slave2
> becomes passive backup).
> But when I shoutdown slave1 first (master is still live), slave2 is unable to
> go into passive mode (so there are no backup ready to become live).
> Example config:
> master:
> {code:xml}
> ...
> cluster-user
> cluster-password
>
>
> netty-connector
> true
>
> slave1
> slave2
>
>
>
>
>
>
> true
> true
> internal-broker
> my-cluster
>
>
>
> ...
> {code}
> slave1:
> {code:xml}
> ...
> cluster-user
> cluster-password
>
>
> netty-connector
> true
>
> master
> slave2
>
>
>
>
>
>
> internal-broker
> my-cluster
> true
>
>
>
> ...
> {code}
> slave2:
>
> {code:xml}
> ...
> cluster-user
> cluster-password
>
>
> netty-connector
> true
>
> master
> slave1
>
>
>
>
>
>
> internal-broker
> my-cluster
> true
>
>
>
> ...
> {code}
>
> And I've additional question: is it possible to create quorum based on only
> one live server in cluster, so 3 nodes (master, slave1, slave2) would be able
> to vote?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (ARTEMIS-2132) Multicast consumer via HTTP transport: AMQ212037 Connection failure has been detected
[
https://issues.apache.org/jira/browse/ARTEMIS-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Bertram resolved ARTEMIS-2132.
-
Resolution: Workaround
At this point the HTTP transport just isn't a priority. In fact, it's never
been heavily used. I think the work-arounds discussed in the description should
suffice.
> Multicast consumer via HTTP transport: AMQ212037 Connection failure has been
> detected
> -
>
> Key: ARTEMIS-2132
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2132
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.6.2, 2.6.3
> Environment: - {code:none|title=$ java -version}
> java version "1.8.0_181"
> Java(TM) SE Runtime Environment (build 1.8.0_181-b13)
> Java HotSpot(TM) 64-Bit Server VM (build 25.181-b13, mixed mode)
> {code}
> - OS: Windows 7
>Reporter: Thomas Küstermann
>Priority: Major
>
> Nabble forum reference: [\[Artemis 2.6.3\] Multicast consumer via HTTP
> transport: AMQ212037 Connection failure has been
> detected|http://activemq.2283324.n4.nabble.com/Artemis-2-6-3-Multicast-consumer-via-HTTP-transport-AMQ212037-Connection-failure-has-been-detected-td4744416.html]
> I want to consume messages from a multicast address via HTTP transport. I
> tweaked the http-transport example
> (apache-artemis-2.6.3/examples/features/standard/http-transport) for my
> purpose. The code I'm working on is to be found on
> [Github|https://github.com/thokuest/activemq-artemis-http-transport-multicast].
> The code produces 10 messages and a consumer receives these 10 messages. If I
> add a delay as in {{Thread.sleep()}} between each call to
> {{MessageConsumer.receive()}}, let's say 1 second, then I receive the
> following exceptions:
> {code:none|title=Client Side}
> java.lang.reflect.InvocationTargetException
> at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:498)
> at org.apache.activemq.artemis.maven.ArtemisClientPlugin.doExecute
> (ArtemisClientPlugin.java:61)
> at org.apache.activemq.artemis.maven.ArtemisAbstractPlugin.execute
> (ArtemisAbstractPlugin.java:74)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:134)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:208)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:154)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:146)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:51)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:309)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
> at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:498)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:289)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:229)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:415)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:356)
> Caused by: javax.jms.IllegalStateException: AMQ119017: Consumer is closed
> at
> org.apache.activemq.artemis.core.client.impl.ClientConsumerImpl.checkClosed
> (ClientConsumerImpl.java:952)
> at
> org.apache.activemq.artemis.core.client.impl.ClientConsumerImpl.receive
> (ClientConsumerImpl.java:195)
> at
> org.apache.activemq.artemis.core.client.impl.ClientConsumerImpl.receive
> (ClientConsumerImpl.java:379)
> at
> org.apache.act
