[jira] [Work logged] (ARTEMIS-2451) Limit size of destination cache
[ https://issues.apache.org/jira/browse/ARTEMIS-2451?focusedWorklogId=294526&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294526 ] ASF GitHub Bot logged work on ARTEMIS-2451: --- Author: ASF GitHub Bot Created on: 14/Aug/19 06:52 Start Date: 14/Aug/19 06:52 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on pull request #2794: ARTEMIS-2451 limit size of destination cache URL: https://github.com/apache/activemq-artemis/pull/2794#discussion_r313726708 ## File path: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQConnection.java ## @@ -97,7 +98,7 @@ private final Set tempQueues = new ConcurrentHashSet<>(); - private final Set knownDestinations = new ConcurrentHashSet<>(); + private final ConcurrentMaxSizeCache knownDestinations = new ConcurrentMaxSizeCache<>(100); Review comment: Can we make this configurable (e.g. a setting in the CF), 100 is a bit of a magic number. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 294526) Time Spent: 20m (was: 10m) > Limit size of destination cache > --- > > Key: ARTEMIS-2451 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2451 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > This is the client-side version of ARTEMIS-2449. Simply put, there is no > limit on the destination cache for a core JMS client. For a long-lived > connection sending to lots of different destinations (e.g. in a request-reply > use-case involving temporary queues) this can present a significant problem. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2437) AMQP message conversion fails if annotations contain values outwith simple property types
[ https://issues.apache.org/jira/browse/ARTEMIS-2437?focusedWorklogId=294524&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294524 ] ASF GitHub Bot logged work on ARTEMIS-2437: --- Author: ASF GitHub Bot Created on: 14/Aug/19 06:48 Start Date: 14/Aug/19 06:48 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core URL: https://github.com/apache/activemq-artemis/pull/2795#issuecomment-521123570 So i checked, the bridging code (e.g. intra cluster etc) encodes the message natively then embeds inside a core, as such the original message is fully preserved as is. This just then leaves two issue areas: 1) Large Messages 2) Conversion to Core Currently core doesn't support complex types, as such i think its wrong to leach AMQP encoding into core, as people could start relying on that. Either we should support complex types in core properly or we don't support and those are dropped. Reason for this is what occurs when other protocols support complex types we will be left with a legacy of AMQP encoded inside core. Re large messages this just sounds like we simply aren't fully supporting AMQP large messages, this is known, either we need to support them or we don't. As such i see a few better options here: 1) Support Large Messages for AMQP fully 2) Support complex types in CORE 3) Support 1 & 2 Im against having a solution that leaks AMQP encoding into CORE. just as much as i know we dont like to modify AMQP in transit. I think this should be a no go area. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 294524) Time Spent: 1h (was: 50m) > AMQP message conversion fails if annotations contain values outwith simple > property types > - > > Key: ARTEMIS-2437 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2437 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.9.0 >Reporter: Jiri Daněk >Assignee: Timothy Bish >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > {noformat} > $ bin/artemis browser --destination example > Consumer:: filter = null > Consumer ActiveMQQueue[example], thread=0 trying to browse 1000 messages > [...] > Consumer ActiveMQQueue[example], thread=0 browsing Alert!!! > Consumer ActiveMQQueue[example], thread=0 browsed: 4 messages > Consumer ActiveMQQueue[example], thread=0 Browser thread finished > {noformat} > In fact, there is 5 messages in the queue, and probably when browsing last > one, the following error is printed to broker stdout. > {noformat} > 2019-07-31 15:07:30,742 ERROR [org.apache.activemq.artemis.core.server] > AMQ224046: Exception while browser handled from > Reference[627]:NON-RELIABLE:AMQPMessage [durable=false, messageID=627, > address=example, size=121, applicationProperties=null, > properties=Properties{messageId=null, userId=null, to='null', subject='null', > replyTo='null', correlationId=null, contentType=null, contentEncoding=null, > absoluteExpiryTime=null, creationTime=null, groupId='null', > groupSequence=null, replyToGroupId='null'}, extraProperties = > TypedProperties[_AMQ_AD=example]]: java.lang.RuntimeException: class > java.util.LinkedHashMap is not a valid property type > at > org.apache.activemq.artemis.protocol.amqp.broker.AMQPMessage.toCore(AMQPMessage.java:695) > [artemis-amqp-protocol-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.core.protocol.core.impl.CoreSessionCallback.sendMessage(CoreSessionCallback.java:123) > [artemis-server-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1168) > [artemis-server-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:510) > [artemis-server-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl$BrowserDeliverer.run(ServerConsumerImpl.java:1484) > [artemis-server-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42) > [artemis-commons-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTa
[jira] [Updated] (ARTEMIS-2447) Allow mapping admin permission to manage permission in LegacyLDAPSecuritySettingsPlugin
[ https://issues.apache.org/jira/browse/ARTEMIS-2447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram updated ARTEMIS-2447: Fix Version/s: 2.10.0 > Allow mapping admin permission to manage permission in > LegacyLDAPSecuritySettingsPlugin > --- > > Key: ARTEMIS-2447 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2447 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Fix For: 2.10.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARTEMIS-2447) Allow mapping admin permission to manage permission in LegacyLDAPSecuritySettingsPlugin
[ https://issues.apache.org/jira/browse/ARTEMIS-2447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram resolved ARTEMIS-2447. - Resolution: Fixed > Allow mapping admin permission to manage permission in > LegacyLDAPSecuritySettingsPlugin > --- > > Key: ARTEMIS-2447 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2447 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2437) AMQP message conversion fails if annotations contain values outwith simple property types
[ https://issues.apache.org/jira/browse/ARTEMIS-2437?focusedWorklogId=294182&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294182 ] ASF GitHub Bot logged work on ARTEMIS-2437: --- Author: ASF GitHub Bot Created on: 13/Aug/19 21:02 Start Date: 13/Aug/19 21:02 Worklog Time Spent: 10m Work Description: tabish121 commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core URL: https://github.com/apache/activemq-artemis/pull/2795#issuecomment-521008001 As reported in the original JIRA when an AMQP message is converted to core that contains complex AMQP types inside annotation sections the converter currently blows up instead of handling the message which is not correct as a core client should still be able to receive the message. For the cases of conversions due to large messages or moving over clusters the current broker again cannot handle those and so this is a reasonable fix as it preserves the AMQP data. If you want to contribute a complete solution such that AMQP to AMQP the message is never converted that would be welcome however until that time a fix is needed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 294182) Time Spent: 50m (was: 40m) > AMQP message conversion fails if annotations contain values outwith simple > property types > - > > Key: ARTEMIS-2437 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2437 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.9.0 >Reporter: Jiri Daněk >Assignee: Timothy Bish >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > {noformat} > $ bin/artemis browser --destination example > Consumer:: filter = null > Consumer ActiveMQQueue[example], thread=0 trying to browse 1000 messages > [...] > Consumer ActiveMQQueue[example], thread=0 browsing Alert!!! > Consumer ActiveMQQueue[example], thread=0 browsed: 4 messages > Consumer ActiveMQQueue[example], thread=0 Browser thread finished > {noformat} > In fact, there is 5 messages in the queue, and probably when browsing last > one, the following error is printed to broker stdout. > {noformat} > 2019-07-31 15:07:30,742 ERROR [org.apache.activemq.artemis.core.server] > AMQ224046: Exception while browser handled from > Reference[627]:NON-RELIABLE:AMQPMessage [durable=false, messageID=627, > address=example, size=121, applicationProperties=null, > properties=Properties{messageId=null, userId=null, to='null', subject='null', > replyTo='null', correlationId=null, contentType=null, contentEncoding=null, > absoluteExpiryTime=null, creationTime=null, groupId='null', > groupSequence=null, replyToGroupId='null'}, extraProperties = > TypedProperties[_AMQ_AD=example]]: java.lang.RuntimeException: class > java.util.LinkedHashMap is not a valid property type > at > org.apache.activemq.artemis.protocol.amqp.broker.AMQPMessage.toCore(AMQPMessage.java:695) > [artemis-amqp-protocol-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.core.protocol.core.impl.CoreSessionCallback.sendMessage(CoreSessionCallback.java:123) > [artemis-server-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1168) > [artemis-server-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:510) > [artemis-server-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl$BrowserDeliverer.run(ServerConsumerImpl.java:1484) > [artemis-server-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42) > [artemis-commons-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31) > [artemis-commons-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66) > [artemis-commons-2.9.0.jar:2.9.0] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > [rt.jar:1.8.0_212] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > [rt.jar:1.8.0_212] > at > org.apache.activemq.artemis.util
[jira] [Work logged] (ARTEMIS-2437) AMQP message conversion fails if annotations contain values outwith simple property types
[ https://issues.apache.org/jira/browse/ARTEMIS-2437?focusedWorklogId=294177&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294177 ] ASF GitHub Bot logged work on ARTEMIS-2437: --- Author: ASF GitHub Bot Created on: 13/Aug/19 20:56 Start Date: 13/Aug/19 20:56 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core URL: https://github.com/apache/activemq-artemis/pull/2795#issuecomment-521005728 Rather than this, would it not be better address those then to avoid the conversion. I know clebert wanted at one time to make amqp large message support a required feature for 2.8.0 obv that didnt happen but maybe doing that and addressing the other bit maybe better than adding further workarounds that will need to be maintained This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 294177) Time Spent: 40m (was: 0.5h) > AMQP message conversion fails if annotations contain values outwith simple > property types > - > > Key: ARTEMIS-2437 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2437 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.9.0 >Reporter: Jiri Daněk >Assignee: Timothy Bish >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > {noformat} > $ bin/artemis browser --destination example > Consumer:: filter = null > Consumer ActiveMQQueue[example], thread=0 trying to browse 1000 messages > [...] > Consumer ActiveMQQueue[example], thread=0 browsing Alert!!! > Consumer ActiveMQQueue[example], thread=0 browsed: 4 messages > Consumer ActiveMQQueue[example], thread=0 Browser thread finished > {noformat} > In fact, there is 5 messages in the queue, and probably when browsing last > one, the following error is printed to broker stdout. > {noformat} > 2019-07-31 15:07:30,742 ERROR [org.apache.activemq.artemis.core.server] > AMQ224046: Exception while browser handled from > Reference[627]:NON-RELIABLE:AMQPMessage [durable=false, messageID=627, > address=example, size=121, applicationProperties=null, > properties=Properties{messageId=null, userId=null, to='null', subject='null', > replyTo='null', correlationId=null, contentType=null, contentEncoding=null, > absoluteExpiryTime=null, creationTime=null, groupId='null', > groupSequence=null, replyToGroupId='null'}, extraProperties = > TypedProperties[_AMQ_AD=example]]: java.lang.RuntimeException: class > java.util.LinkedHashMap is not a valid property type > at > org.apache.activemq.artemis.protocol.amqp.broker.AMQPMessage.toCore(AMQPMessage.java:695) > [artemis-amqp-protocol-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.core.protocol.core.impl.CoreSessionCallback.sendMessage(CoreSessionCallback.java:123) > [artemis-server-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1168) > [artemis-server-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:510) > [artemis-server-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl$BrowserDeliverer.run(ServerConsumerImpl.java:1484) > [artemis-server-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42) > [artemis-commons-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31) > [artemis-commons-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66) > [artemis-commons-2.9.0.jar:2.9.0] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > [rt.jar:1.8.0_212] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > [rt.jar:1.8.0_212] > at > org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118) > [artemis-commons-2.9.0.jar:2.9.0] > Caused by: > org.apache.activemq.artemis.api.core.ActiveMQPropertyConversionException: > class java.util.LinkedHashMap is not a valid property type > at > org.apache.activemq.artemis.
[jira] [Resolved] (AMQ-7274) Update to proton-j 0.33.2 and fix type used to recreate message Footer map
[ https://issues.apache.org/jira/browse/AMQ-7274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Bish resolved AMQ-7274. --- Resolution: Fixed > Update to proton-j 0.33.2 and fix type used to recreate message Footer map > -- > > Key: AMQ-7274 > URL: https://issues.apache.org/jira/browse/AMQ-7274 > Project: ActiveMQ > Issue Type: Task > Components: AMQP >Affects Versions: 5.15.9 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Major > Fix For: 5.15.10 > > > Update to latest proton-j release to fix issue with encoding annotations with > embedded maps or other complex AMQP types and fix issue of using string key > in footer annotations map when converting back to an AMQP message. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (AMQ-7274) Update to proton-j 0.33.2 and fix type used to recreate message Footer map
[ https://issues.apache.org/jira/browse/AMQ-7274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906538#comment-16906538 ] ASF subversion and git services commented on AMQ-7274: -- Commit 2c33f0d7e428545fc0d67dcf2ce8f24d7704f807 in activemq's branch refs/heads/activemq-5.15.x from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=2c33f0d ] AMQ-7274 Update proton-j and fix footer key type on outbound transform Footer annotations maps should be using Symbol keys not strings. (cherry picked from commit 122745b5b8b55b41d329e5457796229a15146d19) > Update to proton-j 0.33.2 and fix type used to recreate message Footer map > -- > > Key: AMQ-7274 > URL: https://issues.apache.org/jira/browse/AMQ-7274 > Project: ActiveMQ > Issue Type: Task > Components: AMQP >Affects Versions: 5.15.9 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Major > Fix For: 5.15.10 > > > Update to latest proton-j release to fix issue with encoding annotations with > embedded maps or other complex AMQP types and fix issue of using string key > in footer annotations map when converting back to an AMQP message. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (AMQ-7274) Update to proton-j 0.33.2 and fix type used to recreate message Footer map
[ https://issues.apache.org/jira/browse/AMQ-7274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906535#comment-16906535 ] ASF subversion and git services commented on AMQ-7274: -- Commit 122745b5b8b55b41d329e5457796229a15146d19 in activemq's branch refs/heads/master from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=122745b ] AMQ-7274 Update proton-j and fix footer key type on outbound transform Footer annotations maps should be using Symbol keys not strings. > Update to proton-j 0.33.2 and fix type used to recreate message Footer map > -- > > Key: AMQ-7274 > URL: https://issues.apache.org/jira/browse/AMQ-7274 > Project: ActiveMQ > Issue Type: Task > Components: AMQP >Affects Versions: 5.15.9 >Reporter: Timothy Bish >Assignee: Timothy Bish >Priority: Major > Fix For: 5.15.10 > > > Update to latest proton-j release to fix issue with encoding annotations with > embedded maps or other complex AMQP types and fix issue of using string key > in footer annotations map when converting back to an AMQP message. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (AMQ-7274) Update to proton-j 0.33.2 and fix type used to recreate message Footer map
Timothy Bish created AMQ-7274: - Summary: Update to proton-j 0.33.2 and fix type used to recreate message Footer map Key: AMQ-7274 URL: https://issues.apache.org/jira/browse/AMQ-7274 Project: ActiveMQ Issue Type: Task Components: AMQP Affects Versions: 5.15.9 Reporter: Timothy Bish Assignee: Timothy Bish Fix For: 5.15.10 Update to latest proton-j release to fix issue with encoding annotations with embedded maps or other complex AMQP types and fix issue of using string key in footer annotations map when converting back to an AMQP message. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (ARTEMIS-2444) Artemis hawtio plugin overriding sublevel tabs
[ https://issues.apache.org/jira/browse/ARTEMIS-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram resolved ARTEMIS-2444. - Resolution: Fixed Fix Version/s: 2.10.0 > Artemis hawtio plugin overriding sublevel tabs > -- > > Key: ARTEMIS-2444 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2444 > Project: ActiveMQ Artemis > Issue Type: Bug > Environment: > >Reporter: Anthony Julin >Priority: Major > Fix For: 2.10.0 > > Attachments: hawtio_plugin_before_camelview.PNG, > hawtio_plugin_before_camelview_artemisinactive.PNG > > Time Spent: 20m > Remaining Estimate: 0h > > The Artemis HawtIO plugin is currently overriding the workspace sublevel > tabs, thereby causing the HawtIO Camel plugin to only display a limited > number of tabs in the UI. > With the Artemis plugin active, only the 'Attributes', 'Operations' and > 'Chart' sublevel tabs are being shown on the Camel plugin. The ability to > view `Route Diagrams`, `Tracing`, and other important Camel tabs is lost. The > attachments below are screenshots of the HawtIO UI with the Camel plugin and > the Artemis tab active and inactive to see the difference. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ARTEMIS-2444) Artemis hawtio plugin overriding sublevel tabs
[ https://issues.apache.org/jira/browse/ARTEMIS-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906471#comment-16906471 ] ASF subversion and git services commented on ARTEMIS-2444: -- Commit 24c55c8eba1e40dc904e7a1ffc478c4074a7a906 in activemq-artemis's branch refs/heads/master from TonyJulin [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=24c55c8 ] ARTEMIS-2444 Artemis hawtio plugin overriding sublevel tabs > Artemis hawtio plugin overriding sublevel tabs > -- > > Key: ARTEMIS-2444 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2444 > Project: ActiveMQ Artemis > Issue Type: Bug > Environment: > >Reporter: Anthony Julin >Priority: Major > Attachments: hawtio_plugin_before_camelview.PNG, > hawtio_plugin_before_camelview_artemisinactive.PNG > > Time Spent: 10m > Remaining Estimate: 0h > > The Artemis HawtIO plugin is currently overriding the workspace sublevel > tabs, thereby causing the HawtIO Camel plugin to only display a limited > number of tabs in the UI. > With the Artemis plugin active, only the 'Attributes', 'Operations' and > 'Chart' sublevel tabs are being shown on the Camel plugin. The ability to > view `Route Diagrams`, `Tracing`, and other important Camel tabs is lost. The > attachments below are screenshots of the HawtIO UI with the Camel plugin and > the Artemis tab active and inactive to see the difference. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2444) Artemis hawtio plugin overriding sublevel tabs
[ https://issues.apache.org/jira/browse/ARTEMIS-2444?focusedWorklogId=294075&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294075 ] ASF GitHub Bot logged work on ARTEMIS-2444: --- Author: ASF GitHub Bot Created on: 13/Aug/19 18:07 Start Date: 13/Aug/19 18:07 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2779: ARTEMIS-2444 Artemis hawtio plugin overriding sublevel tabs URL: https://github.com/apache/activemq-artemis/pull/2779 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 294075) Time Spent: 20m (was: 10m) > Artemis hawtio plugin overriding sublevel tabs > -- > > Key: ARTEMIS-2444 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2444 > Project: ActiveMQ Artemis > Issue Type: Bug > Environment: > >Reporter: Anthony Julin >Priority: Major > Attachments: hawtio_plugin_before_camelview.PNG, > hawtio_plugin_before_camelview_artemisinactive.PNG > > Time Spent: 20m > Remaining Estimate: 0h > > The Artemis HawtIO plugin is currently overriding the workspace sublevel > tabs, thereby causing the HawtIO Camel plugin to only display a limited > number of tabs in the UI. > With the Artemis plugin active, only the 'Attributes', 'Operations' and > 'Chart' sublevel tabs are being shown on the Camel plugin. The ability to > view `Route Diagrams`, `Tracing`, and other important Camel tabs is lost. The > attachments below are screenshots of the HawtIO UI with the Camel plugin and > the Artemis tab active and inactive to see the difference. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2364) Implement collision avoidance for redelivery
[ https://issues.apache.org/jira/browse/ARTEMIS-2364?focusedWorklogId=294054&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294054 ] ASF GitHub Bot logged work on ARTEMIS-2364: --- Author: ASF GitHub Bot Created on: 13/Aug/19 17:42 Start Date: 13/Aug/19 17:42 Worklog Time Spent: 10m Work Description: jbertram commented on pull request #2691: ARTEMIS-2364 collision avoidance for redelivery URL: https://github.com/apache/activemq-artemis/pull/2691#discussion_r313526420 ## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java ## @@ -1037,6 +1039,11 @@ public SecuritySettingPlugin run() { addressSettings.setRedeliveryDelay(XMLUtil.parseLong(child)); } else if (REDELIVERY_DELAY_MULTIPLIER_NODE_NAME.equalsIgnoreCase(name)) { addressSettings.setRedeliveryMultiplier(XMLUtil.parseDouble(child)); + } else if (REDELIVERY_COLLISION_AVOIDANCE_FACTOR_NODE_NAME.equalsIgnoreCase(name)) { +double redeliveryCollisionAvoidanceFactor = XMLUtil.parseDouble(child); + Validators.GE_ZERO.validate(REDELIVERY_COLLISION_AVOIDANCE_FACTOR_NODE_NAME, redeliveryCollisionAvoidanceFactor); + Validators.LE_ONE.validate(REDELIVERY_COLLISION_AVOIDANCE_FACTOR_NODE_NAME, redeliveryCollisionAvoidanceFactor); + addressSettings.setRedeliveryCollisionAvoidanceFactor(redeliveryCollisionAvoidanceFactor); Review comment: For continuity with 5.x I think the configuration should use `redelivery-collision-avoidance-factor` since 5.x uses `collisionAvoidanceFactor`. That said, this is really just a matter of opinion and not strict correctness. It could be implemented any number of ways. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 294054) Time Spent: 1h 10m (was: 1h) > Implement collision avoidance for redelivery > > > Key: ARTEMIS-2364 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2364 > Project: ActiveMQ Artemis > Issue Type: New Feature >Affects Versions: 2.9.0 >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > This the essentially the same as what was implemented in 5.x via > https://issues.apache.org/jira/browse/AMQ-747. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2437) AMQP message conversion fails if annotations contain values outwith simple property types
[ https://issues.apache.org/jira/browse/ARTEMIS-2437?focusedWorklogId=294038&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294038 ] ASF GitHub Bot logged work on ARTEMIS-2437: --- Author: ASF GitHub Bot Created on: 13/Aug/19 17:21 Start Date: 13/Aug/19 17:21 Worklog Time Spent: 10m Work Description: tabish121 commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core URL: https://github.com/apache/activemq-artemis/pull/2795#issuecomment-520927162 Large messages or messages that travel across a cluster are still converted This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 294038) Time Spent: 0.5h (was: 20m) > AMQP message conversion fails if annotations contain values outwith simple > property types > - > > Key: ARTEMIS-2437 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2437 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.9.0 >Reporter: Jiri Daněk >Assignee: Timothy Bish >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > {noformat} > $ bin/artemis browser --destination example > Consumer:: filter = null > Consumer ActiveMQQueue[example], thread=0 trying to browse 1000 messages > [...] > Consumer ActiveMQQueue[example], thread=0 browsing Alert!!! > Consumer ActiveMQQueue[example], thread=0 browsed: 4 messages > Consumer ActiveMQQueue[example], thread=0 Browser thread finished > {noformat} > In fact, there is 5 messages in the queue, and probably when browsing last > one, the following error is printed to broker stdout. > {noformat} > 2019-07-31 15:07:30,742 ERROR [org.apache.activemq.artemis.core.server] > AMQ224046: Exception while browser handled from > Reference[627]:NON-RELIABLE:AMQPMessage [durable=false, messageID=627, > address=example, size=121, applicationProperties=null, > properties=Properties{messageId=null, userId=null, to='null', subject='null', > replyTo='null', correlationId=null, contentType=null, contentEncoding=null, > absoluteExpiryTime=null, creationTime=null, groupId='null', > groupSequence=null, replyToGroupId='null'}, extraProperties = > TypedProperties[_AMQ_AD=example]]: java.lang.RuntimeException: class > java.util.LinkedHashMap is not a valid property type > at > org.apache.activemq.artemis.protocol.amqp.broker.AMQPMessage.toCore(AMQPMessage.java:695) > [artemis-amqp-protocol-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.core.protocol.core.impl.CoreSessionCallback.sendMessage(CoreSessionCallback.java:123) > [artemis-server-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1168) > [artemis-server-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:510) > [artemis-server-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl$BrowserDeliverer.run(ServerConsumerImpl.java:1484) > [artemis-server-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42) > [artemis-commons-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31) > [artemis-commons-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66) > [artemis-commons-2.9.0.jar:2.9.0] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > [rt.jar:1.8.0_212] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > [rt.jar:1.8.0_212] > at > org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118) > [artemis-commons-2.9.0.jar:2.9.0] > Caused by: > org.apache.activemq.artemis.api.core.ActiveMQPropertyConversionException: > class java.util.LinkedHashMap is not a valid property type > at > org.apache.activemq.artemis.utils.collections.TypedProperties.setObjectProperty(TypedProperties.java:1112) > [artemis-commons-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.core.message.impl.CoreMessage.putObjectProperty(CoreMessage.java:1014) > [artemis-core-client-2.9.0.jar:2.9
[jira] [Work logged] (ARTEMIS-2437) AMQP message conversion fails if annotations contain values outwith simple property types
[ https://issues.apache.org/jira/browse/ARTEMIS-2437?focusedWorklogId=294036&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-294036 ] ASF GitHub Bot logged work on ARTEMIS-2437: --- Author: ASF GitHub Bot Created on: 13/Aug/19 17:19 Start Date: 13/Aug/19 17:19 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core URL: https://github.com/apache/activemq-artemis/pull/2795#issuecomment-520926445 Im a bit lost why this is needed. I thought if amqp in and amqp out we did no conversion This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 294036) Time Spent: 20m (was: 10m) > AMQP message conversion fails if annotations contain values outwith simple > property types > - > > Key: ARTEMIS-2437 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2437 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.9.0 >Reporter: Jiri Daněk >Assignee: Timothy Bish >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > {noformat} > $ bin/artemis browser --destination example > Consumer:: filter = null > Consumer ActiveMQQueue[example], thread=0 trying to browse 1000 messages > [...] > Consumer ActiveMQQueue[example], thread=0 browsing Alert!!! > Consumer ActiveMQQueue[example], thread=0 browsed: 4 messages > Consumer ActiveMQQueue[example], thread=0 Browser thread finished > {noformat} > In fact, there is 5 messages in the queue, and probably when browsing last > one, the following error is printed to broker stdout. > {noformat} > 2019-07-31 15:07:30,742 ERROR [org.apache.activemq.artemis.core.server] > AMQ224046: Exception while browser handled from > Reference[627]:NON-RELIABLE:AMQPMessage [durable=false, messageID=627, > address=example, size=121, applicationProperties=null, > properties=Properties{messageId=null, userId=null, to='null', subject='null', > replyTo='null', correlationId=null, contentType=null, contentEncoding=null, > absoluteExpiryTime=null, creationTime=null, groupId='null', > groupSequence=null, replyToGroupId='null'}, extraProperties = > TypedProperties[_AMQ_AD=example]]: java.lang.RuntimeException: class > java.util.LinkedHashMap is not a valid property type > at > org.apache.activemq.artemis.protocol.amqp.broker.AMQPMessage.toCore(AMQPMessage.java:695) > [artemis-amqp-protocol-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.core.protocol.core.impl.CoreSessionCallback.sendMessage(CoreSessionCallback.java:123) > [artemis-server-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1168) > [artemis-server-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:510) > [artemis-server-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl$BrowserDeliverer.run(ServerConsumerImpl.java:1484) > [artemis-server-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42) > [artemis-commons-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31) > [artemis-commons-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66) > [artemis-commons-2.9.0.jar:2.9.0] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > [rt.jar:1.8.0_212] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > [rt.jar:1.8.0_212] > at > org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118) > [artemis-commons-2.9.0.jar:2.9.0] > Caused by: > org.apache.activemq.artemis.api.core.ActiveMQPropertyConversionException: > class java.util.LinkedHashMap is not a valid property type > at > org.apache.activemq.artemis.utils.collections.TypedProperties.setObjectProperty(TypedProperties.java:1112) > [artemis-commons-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.core.message.impl.CoreMessage.putObjectProperty(CoreMessage.java:1014) > [artemis-core
[jira] [Work logged] (ARTEMIS-2437) AMQP message conversion fails if annotations contain values outwith simple property types
[ https://issues.apache.org/jira/browse/ARTEMIS-2437?focusedWorklogId=293986&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293986 ] ASF GitHub Bot logged work on ARTEMIS-2437: --- Author: ASF GitHub Bot Created on: 13/Aug/19 16:05 Start Date: 13/Aug/19 16:05 Worklog Time Spent: 10m Work Description: tabish121 commented on pull request #2795: ARTEMIS-2437 Allow extended types in annotations in AMQP to Core URL: https://github.com/apache/activemq-artemis/pull/2795 When converting from AMQP to core and back again support annotations that aren't able to be placed into Core message properties by storing the bytes from encoding the types to AMQP encodings and then decoding them again when converting back into AMQP messages. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 293986) Time Spent: 10m Remaining Estimate: 0h > AMQP message conversion fails if annotations contain values outwith simple > property types > - > > Key: ARTEMIS-2437 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2437 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.9.0 >Reporter: Jiri Daněk >Assignee: Timothy Bish >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > {noformat} > $ bin/artemis browser --destination example > Consumer:: filter = null > Consumer ActiveMQQueue[example], thread=0 trying to browse 1000 messages > [...] > Consumer ActiveMQQueue[example], thread=0 browsing Alert!!! > Consumer ActiveMQQueue[example], thread=0 browsed: 4 messages > Consumer ActiveMQQueue[example], thread=0 Browser thread finished > {noformat} > In fact, there is 5 messages in the queue, and probably when browsing last > one, the following error is printed to broker stdout. > {noformat} > 2019-07-31 15:07:30,742 ERROR [org.apache.activemq.artemis.core.server] > AMQ224046: Exception while browser handled from > Reference[627]:NON-RELIABLE:AMQPMessage [durable=false, messageID=627, > address=example, size=121, applicationProperties=null, > properties=Properties{messageId=null, userId=null, to='null', subject='null', > replyTo='null', correlationId=null, contentType=null, contentEncoding=null, > absoluteExpiryTime=null, creationTime=null, groupId='null', > groupSequence=null, replyToGroupId='null'}, extraProperties = > TypedProperties[_AMQ_AD=example]]: java.lang.RuntimeException: class > java.util.LinkedHashMap is not a valid property type > at > org.apache.activemq.artemis.protocol.amqp.broker.AMQPMessage.toCore(AMQPMessage.java:695) > [artemis-amqp-protocol-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.core.protocol.core.impl.CoreSessionCallback.sendMessage(CoreSessionCallback.java:123) > [artemis-server-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1168) > [artemis-server-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:510) > [artemis-server-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl$BrowserDeliverer.run(ServerConsumerImpl.java:1484) > [artemis-server-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42) > [artemis-commons-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31) > [artemis-commons-2.9.0.jar:2.9.0] > at > org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66) > [artemis-commons-2.9.0.jar:2.9.0] > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) > [rt.jar:1.8.0_212] > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) > [rt.jar:1.8.0_212] > at > org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118) > [artemis-commons-2.9.0.jar:2.9.0] > Caused by: > org.apache.activemq.artemis.api.core.ActiveMQPropertyConversionException: > class java.util.LinkedHashMap is not a valid property type > at > org.apache.activemq.artemis.utils.collections.TypedProperties.setObjectProperty(TypedProp
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=293972&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293972 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 13/Aug/19 15:42 Start Date: 13/Aug/19 15:42 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-520889867 @howardgao @jbertram wdyt? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 293972) Time Spent: 0.5h (was: 20m) > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2451) Limit size of destination cache
[ https://issues.apache.org/jira/browse/ARTEMIS-2451?focusedWorklogId=293970&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293970 ] ASF GitHub Bot logged work on ARTEMIS-2451: --- Author: ASF GitHub Bot Created on: 13/Aug/19 15:39 Start Date: 13/Aug/19 15:39 Worklog Time Spent: 10m Work Description: jbertram commented on pull request #2794: ARTEMIS-2451 limit size of destination cache URL: https://github.com/apache/activemq-artemis/pull/2794 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 293970) Time Spent: 10m Remaining Estimate: 0h > Limit size of destination cache > --- > > Key: ARTEMIS-2451 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2451 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > This is the client-side version of ARTEMIS-2449. Simply put, there is no > limit on the destination cache for a core JMS client. For a long-lived > connection sending to lots of different destinations (e.g. in a request-reply > use-case involving temporary queues) this can present a significant problem. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=293969&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293969 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 13/Aug/19 15:38 Start Date: 13/Aug/19 15:38 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-520888383 This PR is adding `BackupRequestMessage`'s `nodeID` information for shared store colocated setup, to enable proper validation of backup group names: I don't know yet how to handle the case where old brokers are communicating with new ones, but throwing an exception + logging a warn message. I'm opened to other approaches ;) I will add some tests on my PTO return, but I've left this here to make it available for comment/reviewes :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 293969) Time Spent: 20m (was: 10m) > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=293964&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293964 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 13/Aug/19 15:34 Start Date: 13/Aug/19 15:34 Worklog Time Spent: 10m Work Description: franz1981 commented on pull request #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 293964) Time Spent: 10m Remaining Estimate: 0h > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906315#comment-16906315 ] Francesco Nigro commented on ARTEMIS-2452: -- Both share some common code paths > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (ARTEMIS-2452) group-name ignored in shared store colocated setup
Francesco Nigro created ARTEMIS-2452: Summary: group-name ignored in shared store colocated setup Key: ARTEMIS-2452 URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 Project: ActiveMQ Artemis Issue Type: Bug Components: Broker Affects Versions: 2.9.0 Reporter: Francesco Nigro -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (AMQNET-591) Transactions Support
[ https://issues.apache.org/jira/browse/AMQNET-591?focusedWorklogId=293908&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293908 ] ASF GitHub Bot logged work on AMQNET-591: - Author: ASF GitHub Bot Created on: 13/Aug/19 14:00 Start Date: 13/Aug/19 14:00 Worklog Time Spent: 10m Work Description: cjwmorgan-sol commented on issue #14: AMQNET-591: Transactions support URL: https://github.com/apache/activemq-nms-amqp/pull/14#issuecomment-520846837 > @cjwmorgan-sol i think the current workaround is safer, than setting something arbitarily, that may cause other unexpected issues. At the end of the day this is only temp until AMQPNetlite release. Alright looks fine to me then. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 293908) Time Spent: 4h 40m (was: 4.5h) > Transactions Support > > > Key: AMQNET-591 > URL: https://issues.apache.org/jira/browse/AMQNET-591 > Project: ActiveMQ .Net > Issue Type: Improvement > Components: AMQP, NMS >Reporter: Krzysztof Porebski >Priority: Major > Time Spent: 4h 40m > Remaining Estimate: 0h > > A session may be optionally specified as transacted. Each transacted > session supports a single series of transactions. Each transaction groups a > set of produced messages and a set of consumed messages into an atomic > unit of work. In effect, transactions organize a session’s input message > stream and output message stream into a series of atomic units. When a > transaction commits, its atomic unit of input is acknowledged and its > associated atomic unit of output is sent. If a transaction rollback is done, > its produced messages are destroyed and its consumed messages are > automatically recovered. > A transaction is completed using either its session’s Commit() or > Rollback() method. The completion of a session’s current transaction > automatically begins the next. The result is that a transacted session > always has a current transaction within which its work is done. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (AMQ-7249) Security Vulnerabilities in the ActiveMQ dependent jars.
[ https://issues.apache.org/jira/browse/AMQ-7249?focusedWorklogId=293889&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293889 ] ASF GitHub Bot logged work on AMQ-7249: --- Author: ASF GitHub Bot Created on: 13/Aug/19 13:32 Start Date: 13/Aug/19 13:32 Worklog Time Spent: 10m Work Description: coheigea commented on issue #387: [AMQ-7249] Upgrade to Jetty 9.4.19.v20190610 URL: https://github.com/apache/activemq/pull/387#issuecomment-520835904 @jbonofre I have a fix for the failing tests in the http module. The karaf itests are also failing though. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 293889) Time Spent: 1h 20m (was: 1h 10m) > Security Vulnerabilities in the ActiveMQ dependent jars. > > > Key: AMQ-7249 > URL: https://issues.apache.org/jira/browse/AMQ-7249 > Project: ActiveMQ > Issue Type: Bug > Components: activemq-camel >Affects Versions: 5.15.9 >Reporter: Harish Kumar >Assignee: Jean-Baptiste Onofré >Priority: Critical > Labels: Apache, camel-core > Fix For: 5.16.0, 5.15.10 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Latest version of ActiveMQ(5.15.9) which has dependent jars has Security > Vulnerabilities. > *Below are the jars with Security Vulnerabilities.* > > *1) camel-core-2.19.5.jar :* To be updated to latest > version(camel-core-2.24.1.jar or above). > *Reference* : CVE-2019-0188 > *Path :* org.apache.activemq-5.15.9_1/lib/camel/camel-core-2.19.5.jar > > *2) apache-jsp-9.2.25.v20180606.jar:* To be updated to latest version > (apache-jsp-9.4.19.v20190610.jar) > *Reference:* CVE-2018-8014 , CVE-2018-8034, CVE-2019-10241, > CVE-2019-10247,CVE-2017-6056 > > *Path:* org.apache.activemq-5.15.9_1/lib/web/apache-jsp-8.0.33.jar > : org.apache.activemq-5.15.9_1/lib/web/apache-jsp-9.2.25.v20180606.jar > > 3) *scala-library-2.11.0.jar:* To be updated to 2.13.0 version. ActiveMQ > library has dependency with scala-library.jar > *Path:* org.apache.activemq-5.15.9_1/lib/optional/scala-library-2.11.0.jar > *Reference:* [https://nvd.nist.gov/vuln/detail/CVE-2017-15288] > Need to upgrade the above jars to the the recommended version or provide an > alternative way to replace the existing jar version with the updated versions. > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (AMQ-7149) activemq-client using HTTP transport requires Stomp
[ https://issues.apache.org/jira/browse/AMQ-7149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906116#comment-16906116 ] Jean-Baptiste Onofré commented on AMQ-7149: --- Agree, it was a mistake when I changed some jira tickets. > activemq-client using HTTP transport requires Stomp > --- > > Key: AMQ-7149 > URL: https://issues.apache.org/jira/browse/AMQ-7149 > Project: ActiveMQ > Issue Type: Bug > Components: JMS client, stomp, Transport >Affects Versions: 5.14.6, 5.16.0, 5.15.8, 5.15.9 >Reporter: Bruno Baptista >Assignee: Jean-Baptiste Onofré >Priority: Major > Labels: httpclient, stomp > Fix For: 5.16.0 > > Attachments: activemq.diff > > Time Spent: 10m > Remaining Estimate: 0h > > Both the Stomp and HTTP connectors use the XStream library for serializing > and deserializing objects on the wire (to/from XML). The XStreamSupport class > sets up XStream with some configuration on what classes can/can't be > deserialized to prevent deserialization vulnerabilities. > > In order to avoid duplicating that code, it was placed in the stomp module, > and then referenced in the http module. This was introduced around 5.13. This > can cause a client side class not found exception when using simple http > communication: > > {code:java} > "Exception in thread "ActiveMQ Transport: HTTP Reader http://localhost:9090/"; > java.lang.NoClassDefFoundError: > org/apache/activemq/transport/stomp/XStreamSupport > at > org.apache.activemq.transport.xstream.XStreamWireFormat.createXStream(XStreamWireFormat.java:127) > at > org.apache.activemq.transport.xstream.XStreamWireFormat.getXStream(XStreamWireFormat.java:113) > at > org.apache.activemq.transport.xstream.XStreamWireFormat.unmarshalText(XStreamWireFormat.java:66) > at > org.apache.activemq.transport.util.TextWireFormat.unmarshal(TextWireFormat.java:56) > at > org.apache.activemq.transport.http.HttpClientTransport.run(HttpClientTransport.java:199) > ..." > {code} > > The proposed patch places the XStreamSupport class in activemq-client, thus > correcting this issue without requiring the inclusion of the optional > activemq-stomp library in the client. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (AMQNET-600) Equals and GetHashCode methods are not overridden for IDestination implementations
[ https://issues.apache.org/jira/browse/AMQNET-600?focusedWorklogId=293822&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293822 ] ASF GitHub Bot logged work on AMQNET-600: - Author: ASF GitHub Bot Created on: 13/Aug/19 11:31 Start Date: 13/Aug/19 11:31 Worklog Time Spent: 10m Work Description: HavretGC commented on pull request #19: AMQNET-600: Equals and GetHashCode should be overridden for IDestination implementations URL: https://github.com/apache/activemq-nms-amqp/pull/19 This change is vital if one wants to use NMS AMQP with Spring CachingConnectionFactory, as current implementation prevents it from caching senders and consumers by destination. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 293822) Time Spent: 10m Remaining Estimate: 0h > Equals and GetHashCode methods are not overridden for IDestination > implementations > -- > > Key: AMQNET-600 > URL: https://issues.apache.org/jira/browse/AMQNET-600 > Project: ActiveMQ .Net > Issue Type: Bug > Components: AMQP, NMS >Affects Versions: 1.8.0 >Reporter: Krzysztof Porebski >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Equals and GetHashCode should be overridden in NmsTopic, NmsQueue, > NmsTemporaryTopic, and NmsTemporaryQueue. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (AMQNET-600) Equals and GetHashCode methods are not overridden for IDestination implementations
Krzysztof Porebski created AMQNET-600: - Summary: Equals and GetHashCode methods are not overridden for IDestination implementations Key: AMQNET-600 URL: https://issues.apache.org/jira/browse/AMQNET-600 Project: ActiveMQ .Net Issue Type: Bug Components: AMQP, NMS Affects Versions: 1.8.0 Reporter: Krzysztof Porebski Equals and GetHashCode should be overridden in NmsTopic, NmsQueue, NmsTemporaryTopic, and NmsTemporaryQueue. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Closed] (AMQNET-597) Remotely closed session is not removed from AmqpConnection
[ https://issues.apache.org/jira/browse/AMQNET-597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krzysztof Porebski closed AMQNET-597. - Resolution: Fixed Fix Version/s: 1.8.0 > Remotely closed session is not removed from AmqpConnection > -- > > Key: AMQNET-597 > URL: https://issues.apache.org/jira/browse/AMQNET-597 > Project: ActiveMQ .Net > Issue Type: Bug > Components: AMQP, NMS >Reporter: Krzysztof Porebski >Priority: Major > Fix For: 1.8.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The closed callback for sessions does not remove the AmqpSession from the > AmqpConnection, unlike AmqpComsumer. Removing the explicit call to close > leaves references in the AmqpConnection list for its AmqpSessions. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Closed] (AMQNET-599) Message NMSDeliveryMode is not applied on Amqp.Message Header durable field
[ https://issues.apache.org/jira/browse/AMQNET-599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krzysztof Porebski closed AMQNET-599. - Resolution: Fixed Fix Version/s: 1.8.0 > Message NMSDeliveryMode is not applied on Amqp.Message Header durable field > --- > > Key: AMQNET-599 > URL: https://issues.apache.org/jira/browse/AMQNET-599 > Project: ActiveMQ .Net > Issue Type: Bug > Components: AMQP, NMS >Affects Versions: 1.8.0 >Reporter: Krzysztof Porebski >Priority: Major > Fix For: 1.8.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Changing Message NMSDeliveryMode property should set Amqp.Message Header > durable field. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Closed] (AMQNET-598) Session Acknowledge awaiter in never unwrapped
[ https://issues.apache.org/jira/browse/AMQNET-598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krzysztof Porebski closed AMQNET-598. - Resolution: Fixed Fix Version/s: 1.8.0 > Session Acknowledge awaiter in never unwrapped > -- > > Key: AMQNET-598 > URL: https://issues.apache.org/jira/browse/AMQNET-598 > Project: ActiveMQ .Net > Issue Type: Bug > Components: AMQP, NMS >Affects Versions: 1.8.0 >Reporter: Krzysztof Porebski >Priority: Major > Fix For: 1.8.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Session Acknowledge awaiter in never unwrapped. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (AMQ-7149) activemq-client using HTTP transport requires Stomp
[ https://issues.apache.org/jira/browse/AMQ-7149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906061#comment-16906061 ] Christopher L. Shannon commented on AMQ-7149: - [~jbonofre] This definitely shouldn't be part of any 5.15.x release as it is a breaking change if a class changes to a new jar. It should be 5.16.0 if at all. > activemq-client using HTTP transport requires Stomp > --- > > Key: AMQ-7149 > URL: https://issues.apache.org/jira/browse/AMQ-7149 > Project: ActiveMQ > Issue Type: Bug > Components: JMS client, stomp, Transport >Affects Versions: 5.14.6, 5.16.0, 5.15.8, 5.15.9 >Reporter: Bruno Baptista >Assignee: Jean-Baptiste Onofré >Priority: Major > Labels: httpclient, stomp > Fix For: 5.16.0 > > Attachments: activemq.diff > > Time Spent: 10m > Remaining Estimate: 0h > > Both the Stomp and HTTP connectors use the XStream library for serializing > and deserializing objects on the wire (to/from XML). The XStreamSupport class > sets up XStream with some configuration on what classes can/can't be > deserialized to prevent deserialization vulnerabilities. > > In order to avoid duplicating that code, it was placed in the stomp module, > and then referenced in the http module. This was introduced around 5.13. This > can cause a client side class not found exception when using simple http > communication: > > {code:java} > "Exception in thread "ActiveMQ Transport: HTTP Reader http://localhost:9090/"; > java.lang.NoClassDefFoundError: > org/apache/activemq/transport/stomp/XStreamSupport > at > org.apache.activemq.transport.xstream.XStreamWireFormat.createXStream(XStreamWireFormat.java:127) > at > org.apache.activemq.transport.xstream.XStreamWireFormat.getXStream(XStreamWireFormat.java:113) > at > org.apache.activemq.transport.xstream.XStreamWireFormat.unmarshalText(XStreamWireFormat.java:66) > at > org.apache.activemq.transport.util.TextWireFormat.unmarshal(TextWireFormat.java:56) > at > org.apache.activemq.transport.http.HttpClientTransport.run(HttpClientTransport.java:199) > ..." > {code} > > The proposed patch places the XStreamSupport class in activemq-client, thus > correcting this issue without requiring the inclusion of the optional > activemq-stomp library in the client. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (AMQ-7149) activemq-client using HTTP transport requires Stomp
[ https://issues.apache.org/jira/browse/AMQ-7149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher L. Shannon updated AMQ-7149: Fix Version/s: (was: 5.15.10) > activemq-client using HTTP transport requires Stomp > --- > > Key: AMQ-7149 > URL: https://issues.apache.org/jira/browse/AMQ-7149 > Project: ActiveMQ > Issue Type: Bug > Components: JMS client, stomp, Transport >Affects Versions: 5.14.6, 5.16.0, 5.15.8, 5.15.9 >Reporter: Bruno Baptista >Assignee: Jean-Baptiste Onofré >Priority: Major > Labels: httpclient, stomp > Fix For: 5.16.0 > > Attachments: activemq.diff > > Time Spent: 10m > Remaining Estimate: 0h > > Both the Stomp and HTTP connectors use the XStream library for serializing > and deserializing objects on the wire (to/from XML). The XStreamSupport class > sets up XStream with some configuration on what classes can/can't be > deserialized to prevent deserialization vulnerabilities. > > In order to avoid duplicating that code, it was placed in the stomp module, > and then referenced in the http module. This was introduced around 5.13. This > can cause a client side class not found exception when using simple http > communication: > > {code:java} > "Exception in thread "ActiveMQ Transport: HTTP Reader http://localhost:9090/"; > java.lang.NoClassDefFoundError: > org/apache/activemq/transport/stomp/XStreamSupport > at > org.apache.activemq.transport.xstream.XStreamWireFormat.createXStream(XStreamWireFormat.java:127) > at > org.apache.activemq.transport.xstream.XStreamWireFormat.getXStream(XStreamWireFormat.java:113) > at > org.apache.activemq.transport.xstream.XStreamWireFormat.unmarshalText(XStreamWireFormat.java:66) > at > org.apache.activemq.transport.util.TextWireFormat.unmarshal(TextWireFormat.java:56) > at > org.apache.activemq.transport.http.HttpClientTransport.run(HttpClientTransport.java:199) > ..." > {code} > > The proposed patch places the XStreamSupport class in activemq-client, thus > correcting this issue without requiring the inclusion of the optional > activemq-stomp library in the client. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (AMQNET-591) Transactions Support
[ https://issues.apache.org/jira/browse/AMQNET-591?focusedWorklogId=293756&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293756 ] ASF GitHub Bot logged work on AMQNET-591: - Author: ASF GitHub Bot Created on: 13/Aug/19 09:05 Start Date: 13/Aug/19 09:05 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #14: AMQNET-591: Transactions support URL: https://github.com/apache/activemq-nms-amqp/pull/14#issuecomment-520753478 @cjwmorgan-sol i think the current workaround is safer, than setting something arbitarily, that may cause other unexpected issues. At the end of the day this is only temp until AMQPNetlite release. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 293756) Time Spent: 4.5h (was: 4h 20m) > Transactions Support > > > Key: AMQNET-591 > URL: https://issues.apache.org/jira/browse/AMQNET-591 > Project: ActiveMQ .Net > Issue Type: Improvement > Components: AMQP, NMS >Reporter: Krzysztof Porebski >Priority: Major > Time Spent: 4.5h > Remaining Estimate: 0h > > A session may be optionally specified as transacted. Each transacted > session supports a single series of transactions. Each transaction groups a > set of produced messages and a set of consumed messages into an atomic > unit of work. In effect, transactions organize a session’s input message > stream and output message stream into a series of atomic units. When a > transaction commits, its atomic unit of input is acknowledged and its > associated atomic unit of output is sent. If a transaction rollback is done, > its produced messages are destroyed and its consumed messages are > automatically recovered. > A transaction is completed using either its session’s Commit() or > Rollback() method. The completion of a session’s current transaction > automatically begins the next. The result is that a transacted session > always has a current transaction within which its work is done. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (AMQNET-596) Support LocalMessageExpiry property for NMS AMQP
[ https://issues.apache.org/jira/browse/AMQNET-596?focusedWorklogId=293710&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293710 ] ASF GitHub Bot logged work on AMQNET-596: - Author: ASF GitHub Bot Created on: 13/Aug/19 08:06 Start Date: 13/Aug/19 08:06 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on pull request #15: AMQNET-596: Added local message expiry connection uri connection property URL: https://github.com/apache/activemq-nms-amqp/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 293710) Time Spent: 1h 50m (was: 1h 40m) > Support LocalMessageExpiry property for NMS AMQP > > > Key: AMQNET-596 > URL: https://issues.apache.org/jira/browse/AMQNET-596 > Project: ActiveMQ .Net > Issue Type: Improvement > Components: AMQP, NMS >Reporter: Chris Morgan >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > Qpid Jms has a connection property to Enable/Disable LocalMessageExpiry. The > nms amqp provider should support this property as some amqp brokers do not > support LocalMessageExpiry at the protocol level over amqp. > > This property should be added to the NmsConnectionFactory, along with the > ConnectionInfo Class and the ConsumerInfo Class and applied at consumer > message receive. > > The default value in qpid jms is true to have the nms amqp provider should > have the same default. > > The string name of the property will be "nms.localMessagePriority". -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (AMQNET-596) Support LocalMessageExpiry property for NMS AMQP
[ https://issues.apache.org/jira/browse/AMQNET-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905917#comment-16905917 ] ASF subversion and git services commented on AMQNET-596: Commit 0e336f4efb887de26b424add66b0759d39f50eb8 in activemq-nms-amqp's branch refs/heads/master from Michael André Pearce [ https://gitbox.apache.org/repos/asf?p=activemq-nms-amqp.git;h=0e336f4 ] Merge pull request #15 from cjwmorgan-sol/localMessageExpiry AMQNET-596: Added local message expiry connection uri connection property > Support LocalMessageExpiry property for NMS AMQP > > > Key: AMQNET-596 > URL: https://issues.apache.org/jira/browse/AMQNET-596 > Project: ActiveMQ .Net > Issue Type: Improvement > Components: AMQP, NMS >Reporter: Chris Morgan >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > Qpid Jms has a connection property to Enable/Disable LocalMessageExpiry. The > nms amqp provider should support this property as some amqp brokers do not > support LocalMessageExpiry at the protocol level over amqp. > > This property should be added to the NmsConnectionFactory, along with the > ConnectionInfo Class and the ConsumerInfo Class and applied at consumer > message receive. > > The default value in qpid jms is true to have the nms amqp provider should > have the same default. > > The string name of the property will be "nms.localMessagePriority". -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (AMQNET-596) Support LocalMessageExpiry property for NMS AMQP
[ https://issues.apache.org/jira/browse/AMQNET-596?focusedWorklogId=293709&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293709 ] ASF GitHub Bot logged work on AMQNET-596: - Author: ASF GitHub Bot Created on: 13/Aug/19 08:06 Start Date: 13/Aug/19 08:06 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #15: AMQNET-596: Added local message expiry connection uri connection property URL: https://github.com/apache/activemq-nms-amqp/pull/15#issuecomment-520733543 @cjwmorgan-sol great thanks, merging. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 293709) Time Spent: 1h 40m (was: 1.5h) > Support LocalMessageExpiry property for NMS AMQP > > > Key: AMQNET-596 > URL: https://issues.apache.org/jira/browse/AMQNET-596 > Project: ActiveMQ .Net > Issue Type: Improvement > Components: AMQP, NMS >Reporter: Chris Morgan >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > Qpid Jms has a connection property to Enable/Disable LocalMessageExpiry. The > nms amqp provider should support this property as some amqp brokers do not > support LocalMessageExpiry at the protocol level over amqp. > > This property should be added to the NmsConnectionFactory, along with the > ConnectionInfo Class and the ConsumerInfo Class and applied at consumer > message receive. > > The default value in qpid jms is true to have the nms amqp provider should > have the same default. > > The string name of the property will be "nms.localMessagePriority". -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (AMQNET-596) Support LocalMessageExpiry property for NMS AMQP
[ https://issues.apache.org/jira/browse/AMQNET-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905916#comment-16905916 ] ASF subversion and git services commented on AMQNET-596: Commit d579e062f500a409333e7af14bfe9ecbc37fe3b2 in activemq-nms-amqp's branch refs/heads/master from cmorgan-sol [ https://gitbox.apache.org/repos/asf?p=activemq-nms-amqp.git;h=d579e06 ] AMQNET-596: Added local message expiry connection uri connection property message consumer only filter expired messages when local message expiry is enabled added message expiration integration test Signed-off-by: cjwmorgan-sol Changed property name to LocalMessageExpiry to make the uri query parameter property match qpid jms Signed-off-by: cjwmorgan-sol > Support LocalMessageExpiry property for NMS AMQP > > > Key: AMQNET-596 > URL: https://issues.apache.org/jira/browse/AMQNET-596 > Project: ActiveMQ .Net > Issue Type: Improvement > Components: AMQP, NMS >Reporter: Chris Morgan >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > Qpid Jms has a connection property to Enable/Disable LocalMessageExpiry. The > nms amqp provider should support this property as some amqp brokers do not > support LocalMessageExpiry at the protocol level over amqp. > > This property should be added to the NmsConnectionFactory, along with the > ConnectionInfo Class and the ConsumerInfo Class and applied at consumer > message receive. > > The default value in qpid jms is true to have the nms amqp provider should > have the same default. > > The string name of the property will be "nms.localMessagePriority". -- This message was sent by Atlassian JIRA (v7.6.14#76016)