[jira] [Work logged] (AMQ-7320) Upgrade to Jackson 2.10.0
[ https://issues.apache.org/jira/browse/AMQ-7320?focusedWorklogId=341368&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-341368 ] ASF GitHub Bot logged work on AMQ-7320: --- Author: ASF GitHub Bot Created on: 11/Nov/19 16:39 Start Date: 11/Nov/19 16:39 Worklog Time Spent: 10m Work Description: coheigea commented on issue #412: [AMQ-7320] Upgrade to Jackson 2.10.0 URL: https://github.com/apache/activemq/pull/412#issuecomment-552518689 @jbonofre 2.10.1 is out now This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 341368) Time Spent: 20m (was: 10m) > Upgrade to Jackson 2.10.0 > - > > Key: AMQ-7320 > URL: https://issues.apache.org/jira/browse/AMQ-7320 > Project: ActiveMQ > Issue Type: Task > Components: Broker, Web Console >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 5.16.0, 5.15.11 > > Time Spent: 20m > Remaining Estimate: 0h > > In order to fix new CVE, we have to update to Jackson 2.10.0. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2547) AMQP Client reconnect fails on broker stop start
[ https://issues.apache.org/jira/browse/ARTEMIS-2547?focusedWorklogId=341358&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-341358 ] ASF GitHub Bot logged work on ARTEMIS-2547: --- Author: ASF GitHub Bot Created on: 11/Nov/19 16:23 Start Date: 11/Nov/19 16:23 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2891: ARTEMIS-2547 fix AMQP Client reconnect fails on broker stop start URL: https://github.com/apache/activemq-artemis/pull/2891#issuecomment-552512570 Just fyi the issue became apparent when network pinger detected unhealthy network and stopped the server and subsequently started yet amqp clients didnt reconnect. The test simulates that This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 341358) Time Spent: 20m (was: 10m) > AMQP Client reconnect fails on broker stop start > > > Key: ARTEMIS-2547 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2547 > Project: ActiveMQ Artemis > Issue Type: Task > Components: AMQP, Broker >Affects Versions: 2.7.0, 2.10.1 >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Major > Fix For: 2.11.0 > > Time Spent: 20m > Remaining Estimate: 0h > > When a broker is stopped and started, e.g. network pinger or other reasons, > amqp clients with reconnect logic, e.g. qpid jms client, do not successfully > reconnect. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (AMQ-7303) Unnecessary stack trace in case of invalid credentials
[
https://issues.apache.org/jira/browse/AMQ-7303?focusedWorklogId=341350&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-341350
]
ASF GitHub Bot logged work on AMQ-7303:
---
Author: ASF GitHub Bot
Created on: 11/Nov/19 15:58
Start Date: 11/Nov/19 15:58
Worklog Time Spent: 10m
Work Description: jbonofre commented on pull request #413: [AMQ-7303]
Limit trace to SecurityException in the authentication broker
URL: https://github.com/apache/activemq/pull/413
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 341350)
Remaining Estimate: 0h
Time Spent: 10m
> Unnecessary stack trace in case of invalid credentials
> --
>
> Key: AMQ-7303
> URL: https://issues.apache.org/jira/browse/AMQ-7303
> Project: ActiveMQ
> Issue Type: Bug
> Components: Security/JAAS
>Affects Versions: 5.15.10
> Environment: ActiveMQ 5.15.10 as standalone broker
>Reporter: Lionel Cons
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 5.16.0, 5.15.11
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When connecting via STOMP using invalid credentials, we get a complete stack
> trace:
> {code}
> 2019-09-10 14:30:16,765 [ActiveMQ NIO Worker 9] WARN Transport - Transport
> Connection to: tcp://192.168.1.1:50196 failed: java.io.IOException: User name
> [foo] or password is invalid.
> 2019-09-10 14:43:56,518 [ActiveMQ NIO Worker 9] WARN TransportConnection -
> Failed to add Connection id=ID:broker.acme.com-24724-1568103966879-1:1005,
> clientId=ID:broker.acme.com-24724-1568103966879-1:1005 due to {}
> java.lang.SecurityException: User name [foo] or password is invalid.
> at
> org.apache.activemq.security.JaasAuthenticationBroker.authenticate(JaasAuthenticationBroker.java:97)
> at
> org.apache.activemq.security.JaasAuthenticationBroker.addConnection(JaasAuthenticationBroker.java:68)
> at
> org.apache.activemq.security.JaasDualAuthenticationBroker.addConnection(JaasDualAuthenticationBroker.java:94)
> at
> org.apache.activemq.broker.BrokerFilter.addConnection(BrokerFilter.java:99)
> at
> org.apache.activemq.plugin.AbstractRuntimeConfigurationBroker.addConnection(AbstractRuntimeConfigurationBroker.java:118)
> at
> org.apache.activemq.broker.BrokerFilter.addConnection(BrokerFilter.java:99)
> at
> org.apache.activemq.broker.BrokerFilter.addConnection(BrokerFilter.java:99)
> at
> org.apache.activemq.broker.TransportConnection.processAddConnection(TransportConnection.java:849)
> at
> org.apache.activemq.broker.jmx.ManagedTransportConnection.processAddConnection(ManagedTransportConnection.java:77)
> at
> org.apache.activemq.command.ConnectionInfo.visit(ConnectionInfo.java:139)
> at
> org.apache.activemq.broker.TransportConnection.service(TransportConnection.java:336)
> at
> org.apache.activemq.broker.TransportConnection$1.onCommand(TransportConnection.java:200)
> at
> org.apache.activemq.transport.MutexTransport.onCommand(MutexTransport.java:45)
> at
> org.apache.activemq.transport.AbstractInactivityMonitor.onCommand(AbstractInactivityMonitor.java:301)
> at
> org.apache.activemq.transport.stomp.StompTransportFilter.sendToActiveMQ(StompTransportFilter.java:97)
> at
> org.apache.activemq.transport.stomp.ProtocolConverter.sendToActiveMQ(ProtocolConverter.java:177)
> at
> org.apache.activemq.transport.stomp.ProtocolConverter.onStompConnect(ProtocolConverter.java:746)
> at
> org.apache.activemq.transport.stomp.ProtocolConverter.onStompCommand(ProtocolConverter.java:240)
> at
> org.apache.activemq.transport.stomp.StompTransportFilter.onCommand(StompTransportFilter.java:85)
> at
> org.apache.activemq.transport.TransportSupport.doConsume(TransportSupport.java:83)
> at
> org.apache.activemq.transport.stomp.StompCodec.processCommand(StompCodec.java:133)
> at
> org.apache.activemq.transport.stomp.StompCodec.parse(StompCodec.java:100)
> at
> org.apache.activemq.transport.stomp.StompNIOTransport.processBuffer(StompNIOTransport.java:136)
> at
> org.apache.activemq.transport.stomp.StompNIOTransport.serviceRead(StompNIOTransport.java:121)
> at
> org.apache.activemq.transport.stomp.StompNIOTransport.access$000(StompNIOTransport.java:44)
> at
> org.apache.activemq.transport.stomp.StompNIOTransport$1.onSelect(Stomp
[jira] [Work logged] (AMQ-7320) Upgrade to Jackson 2.10.0
[ https://issues.apache.org/jira/browse/AMQ-7320?focusedWorklogId=341342&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-341342 ] ASF GitHub Bot logged work on AMQ-7320: --- Author: ASF GitHub Bot Created on: 11/Nov/19 15:27 Start Date: 11/Nov/19 15:27 Worklog Time Spent: 10m Work Description: jbonofre commented on pull request #412: [AMQ-7320] Upgrade to Jackson 2.10.0 URL: https://github.com/apache/activemq/pull/412 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 341342) Remaining Estimate: 0h Time Spent: 10m > Upgrade to Jackson 2.10.0 > - > > Key: AMQ-7320 > URL: https://issues.apache.org/jira/browse/AMQ-7320 > Project: ActiveMQ > Issue Type: Task > Components: Broker, Web Console >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 5.16.0, 5.15.11 > > Time Spent: 10m > Remaining Estimate: 0h > > In order to fix new CVE, we have to update to Jackson 2.10.0. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2547) AMQP Client reconnect fails on broker stop start
[ https://issues.apache.org/jira/browse/ARTEMIS-2547?focusedWorklogId=341280&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-341280 ] ASF GitHub Bot logged work on ARTEMIS-2547: --- Author: ASF GitHub Bot Created on: 11/Nov/19 12:43 Start Date: 11/Nov/19 12:43 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on pull request #2891: ARTEMIS-2547 fix AMQP Client reconnect fails on broker stop start URL: https://github.com/apache/activemq-artemis/pull/2891 Add unit test Add fix to clear clientids when server is stopped. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 341280) Remaining Estimate: 0h Time Spent: 10m > AMQP Client reconnect fails on broker stop start > > > Key: ARTEMIS-2547 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2547 > Project: ActiveMQ Artemis > Issue Type: Task > Components: AMQP, Broker >Affects Versions: 2.7.0, 2.10.1 >Reporter: Michael Andre Pearce >Assignee: Michael Andre Pearce >Priority: Major > Fix For: 2.11.0 > > Time Spent: 10m > Remaining Estimate: 0h > > When a broker is stopped and started, e.g. network pinger or other reasons, > amqp clients with reconnect logic, e.g. qpid jms client, do not successfully > reconnect. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ARTEMIS-2547) AMQP Client reconnect fails on broker stop start
Michael Andre Pearce created ARTEMIS-2547: - Summary: AMQP Client reconnect fails on broker stop start Key: ARTEMIS-2547 URL: https://issues.apache.org/jira/browse/ARTEMIS-2547 Project: ActiveMQ Artemis Issue Type: Task Components: AMQP, Broker Affects Versions: 2.10.1, 2.7.0 Reporter: Michael Andre Pearce Assignee: Michael Andre Pearce Fix For: 2.11.0 When a broker is stopped and started, e.g. network pinger or other reasons, amqp clients with reconnect logic, e.g. qpid jms client, do not successfully reconnect. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ARTEMIS-2546) Message loss when consumers consume and disapper without acknowledging
[
https://issues.apache.org/jira/browse/ARTEMIS-2546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16971392#comment-16971392
]
Viliam Durina commented on ARTEMIS-2546:
Note that in the reproducer I only use 2 XIDs and I always roll back the
transaction before starting the consumption, so the missing messages should not
be waiting unacknowledged in a transaction, however I didn't check it.
> Message loss when consumers consume and disapper without acknowledging
> --
>
> Key: ARTEMIS-2546
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2546
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.10.1
> Environment: I'm on Windows 10, Oracle JVM 11.0.1
>Reporter: Viliam Durina
>Priority: Major
>
> I do a stress testing of my product where I check that I commit messages
> properly and that I get exactly-once delivery. I have multiple parallel
> consumers of a queue and I restart them and check for correct results. But
> occasionally I miss the initial messages. By checking the logs I found out
> that those were never returned from the `MessageConsumer.receive()` method,
> so I thought it's not me incorrectly committing and rolling back. I managed
> to write a standalone test that reproduces this issue. On my machine it fails
> in about 50% of cases, but I surmise that it might be micro-timing dependent,
> so you might tweak sleep times and what not.
> The test code:
> {noformat}
> import org.apache.activemq.artemis.jms.client.ActiveMQXAConnectionFactory;
> import org.apache.activemq.artemis.junit.EmbeddedActiveMQResource;
> import org.junit.ClassRule;
> import org.junit.Test;
> import javax.jms.Connection;
> import javax.jms.ConnectionFactory;
> import javax.jms.JMSException;
> import javax.jms.MessageConsumer;
> import javax.jms.MessageProducer;
> import javax.jms.Session;
> import javax.jms.TextMessage;
> import javax.jms.XAConnection;
> import javax.jms.XAConnectionFactory;
> import javax.jms.XASession;
> import javax.transaction.xa.XAException;
> import javax.transaction.xa.XAResource;
> import javax.transaction.xa.Xid;
> import java.util.Arrays;
> import java.util.concurrent.ThreadLocalRandom;
> import java.util.concurrent.atomic.AtomicBoolean;
> import static java.util.concurrent.TimeUnit.NANOSECONDS;
> import static javax.jms.Session.AUTO_ACKNOWLEDGE;
> import static org.junit.Assert.assertTrue;
> public class ArtemisTest_NoInterrupts {
> @ClassRule
> public static EmbeddedActiveMQResource resource = new
> EmbeddedActiveMQResource();
> private volatile boolean receivedMsg0;
> @Test
> public void test() throws InterruptedException {
> AtomicBoolean driverShutdownFlag = new AtomicBoolean();
> Thread consumerDriverThread = new Thread(() ->
> consumerDriver(driverShutdownFlag));
> Thread producerThread = new Thread(this::producer);
> producerThread.start();
> consumerDriverThread.start();
> producerThread.join();
> driverShutdownFlag.set(true);
> consumerDriverThread.join();
> assertTrue("msg-0 not received", receivedMsg0);
> }
> private void consumerDriver(AtomicBoolean driverShutdownFlag) {
> try {
> Xid xid1 = new MyXid(new byte[] {1});
> Xid xid2 = new MyXid(new byte[] {2});
> for (int id = 0; !driverShutdownFlag.get(); id++) {
> int finalId = id;
> Thread thread1 = null;
> Thread thread2 = null;
> try {
> AtomicBoolean shutdownFlag = new AtomicBoolean();
> thread1 = new Thread(() -> consumer(xid1, finalId,
> shutdownFlag));
> thread2 = new Thread(() -> consumer(xid2, finalId,
> shutdownFlag));
> thread1.start();
> thread2.start();
> Thread.sleep(15 + id < 4 ? 0 :
> ThreadLocalRandom.current().nextInt(100));
> shutdownFlag.set(true);
> } finally {
> if (thread1 != null) {
> thread1.join();
> }
> if (thread2 != null) {
> thread2.join();
> }
> }
> }
> } catch (Exception e) {
> throw new RuntimeException(e);
> }
> }
> private void consumer(Xid xid, int id, AtomicBoolean shutdownFlag) {
> try (
> XAConnection conn =
> getConnectionFactory().createXAConnection();
> XASession sess = conn.createXASession()
> ) {
> conn.start();
> XAResource res = sess.getXAResource();
> // rollback the xid first
>
