[jira] [Work logged] (ARTEMIS-3522) Implement performance tools to evaluate throughput and Response Under Load performance of Artemis
[ https://issues.apache.org/jira/browse/ARTEMIS-3522?focusedWorklogId=735267&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735267 ] ASF GitHub Bot logged work on ARTEMIS-3522: --- Author: ASF GitHub Bot Created on: 02/Mar/22 12:30 Start Date: 02/Mar/22 12:30 Worklog Time Spent: 10m Work Description: franz1981 commented on pull request #3857: URL: https://github.com/apache/activemq-artemis/pull/3857#issuecomment-1056875939 Going to merge this now and keep on improving it as new feedbacks arrive -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 735267) Time Spent: 2.5h (was: 2h 20m) > Implement performance tools to evaluate throughput and Response Under Load > performance of Artemis > - > > Key: ARTEMIS-3522 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3522 > Project: ActiveMQ Artemis > Issue Type: New Feature > Components: Broker, JMS >Reporter: Francesco Nigro >Assignee: Francesco Nigro >Priority: Major > Time Spent: 2.5h > Remaining Estimate: 0h > > There are many performance benchmarks around eg [SoftwareMill > MqPerf|https://softwaremill.com/mqperf/] that could be used to test > performance of Artemis in specific scenario, but none is both simple and easy > to be composed with ad-hoc env setup scripts to perform a wide range of > different performance tests against the broker. > This JIRA aim to provide CLI commands that could be used as building blocks > to perform: > * all-out throughput tests > * responsiveness under load tests (with no [coordinated > omission|http://highscalability.com/blog/2015/10/5/your-load-generator-is-probably-lying-to-you-take-the-red-pi.html]) > ie fixed throughput (per producer) load > * scalability tests > The effort of this JIRA should produce CLI commands similar to [Apache Pulsar > Perf|https://pulsar.apache.org/docs/en/performance-pulsar-perf/] that could > be composed to create complete performance benchmark pipelines (eg using > [qDup|https://github.com/Hyperfoil/qDup] and > [Horreum|https://github.com/Hyperfoil/Horreum] on a CI/CD) or used as-it-is > by users to quickly check performance of the broker. > Requirements: > * support AMQP and Core protocol > * cross JVMs with microseconds time measurement granularity > * support parsable output format > * suitable to perform scale tests > The last requirement can be achieved both by using MessageListeners and async > producers available on [JMS > 2|https://javaee.github.io/jms-spec/pages/JMS20FinalRelease] although both > [qpid JMS|https://github.com/apache/qpid-jms] and Artemis Core protocols > blocks the producer caller thread ie the former on > [jmsConnection::send|https://github.com/apache/qpid-jms/blob/1622de679c3c6763db54e9ac506ef2412fbc4481/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnection.java#L773], > awaiting Netty threads to unblock it on > [AmqpFixedProducer::doSend|https://github.com/apache/qpid-jms/blob/1622de679c3c6763db54e9ac506ef2412fbc4481/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpFixedProducer.java#L169], > while the latter on > [ClientProducerImpl::sendRegularMessage|https://github.com/apache/activemq-artemis/blob/e364961c8f035613f3ce4e3bdb3430a17efb0ffd/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientProducerImpl.java#L284-L294]. > This seems odd because [JMS 2's > CompletionListener|https://docs.oracle.com/javaee/7/api/javax/jms/CompletionListener.html] > should save any previous send operation to ever block and the user should > take care (despite being tedious and error-prone) to track the amount of > in-flight messages and limit it accordly (ie [Reactive Messaging's > Emitter|https://smallrye.io/smallrye-reactive-messaging/smallrye-reactive-messaging/2/emitter/emitter.html#emitter-overflow] > abstract it with its overflow policies to save blocking the caller thread). > If JMS 2 both impl cannot be turned into non-blocking then there're just 2 > options: > # using the blocking variant: it means that scalability tests requires using > machines with high core numbers > # using [Reactive > Messaging|https://github.com/eclipse/microprofile-reactive-messaging], but > losing the ability to use local transactions (and maybe other JMS features) > With the first option the number of producers threads can easi
[jira] [Commented] (AMQ-8520) Default maven build does not build all modules
[ https://issues.apache.org/jira/browse/AMQ-8520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500116#comment-17500116 ] Jean-Baptiste Onofré commented on AMQ-8520: --- Sorry, jumping late. I think 5.16.x is fine (gonna check anyway). Let me check/test PR. > Default maven build does not build all modules > -- > > Key: AMQ-8520 > URL: https://issues.apache.org/jira/browse/AMQ-8520 > Project: ActiveMQ > Issue Type: Bug >Affects Versions: 5.16.4 >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 5.17.0, 5.16.5 > > Time Spent: 40m > Remaining Estimate: 0h > > There are some optional modules defined under the profile "full.test". These > modules need to be added by default back to the normal build so they are > compiled and installed as there are dependencies on them for other modules. > The tests can be skipped by default but the actual modules need to still > always be built. This is a problem as now version 5.18 fails to build without > old snapshots plus it means all of the testing in CI is using stale snapshots. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (ARTEMIS-3522) Implement performance tools to evaluate throughput and Response Under Load performance of Artemis
[ https://issues.apache.org/jira/browse/ARTEMIS-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500117#comment-17500117 ] ASF subversion and git services commented on ARTEMIS-3522: -- Commit f8b045bd2d95ec28c70c4d64c85400b28d8baef5 in activemq-artemis's branch refs/heads/main from franz1981 [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=f8b045b ] ARTEMIS-3522 Implement performance tool for RUL benchmarks Co-authored-by: gtully > Implement performance tools to evaluate throughput and Response Under Load > performance of Artemis > - > > Key: ARTEMIS-3522 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3522 > Project: ActiveMQ Artemis > Issue Type: New Feature > Components: Broker, JMS >Reporter: Francesco Nigro >Assignee: Francesco Nigro >Priority: Major > Time Spent: 2.5h > Remaining Estimate: 0h > > There are many performance benchmarks around eg [SoftwareMill > MqPerf|https://softwaremill.com/mqperf/] that could be used to test > performance of Artemis in specific scenario, but none is both simple and easy > to be composed with ad-hoc env setup scripts to perform a wide range of > different performance tests against the broker. > This JIRA aim to provide CLI commands that could be used as building blocks > to perform: > * all-out throughput tests > * responsiveness under load tests (with no [coordinated > omission|http://highscalability.com/blog/2015/10/5/your-load-generator-is-probably-lying-to-you-take-the-red-pi.html]) > ie fixed throughput (per producer) load > * scalability tests > The effort of this JIRA should produce CLI commands similar to [Apache Pulsar > Perf|https://pulsar.apache.org/docs/en/performance-pulsar-perf/] that could > be composed to create complete performance benchmark pipelines (eg using > [qDup|https://github.com/Hyperfoil/qDup] and > [Horreum|https://github.com/Hyperfoil/Horreum] on a CI/CD) or used as-it-is > by users to quickly check performance of the broker. > Requirements: > * support AMQP and Core protocol > * cross JVMs with microseconds time measurement granularity > * support parsable output format > * suitable to perform scale tests > The last requirement can be achieved both by using MessageListeners and async > producers available on [JMS > 2|https://javaee.github.io/jms-spec/pages/JMS20FinalRelease] although both > [qpid JMS|https://github.com/apache/qpid-jms] and Artemis Core protocols > blocks the producer caller thread ie the former on > [jmsConnection::send|https://github.com/apache/qpid-jms/blob/1622de679c3c6763db54e9ac506ef2412fbc4481/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnection.java#L773], > awaiting Netty threads to unblock it on > [AmqpFixedProducer::doSend|https://github.com/apache/qpid-jms/blob/1622de679c3c6763db54e9ac506ef2412fbc4481/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpFixedProducer.java#L169], > while the latter on > [ClientProducerImpl::sendRegularMessage|https://github.com/apache/activemq-artemis/blob/e364961c8f035613f3ce4e3bdb3430a17efb0ffd/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientProducerImpl.java#L284-L294]. > This seems odd because [JMS 2's > CompletionListener|https://docs.oracle.com/javaee/7/api/javax/jms/CompletionListener.html] > should save any previous send operation to ever block and the user should > take care (despite being tedious and error-prone) to track the amount of > in-flight messages and limit it accordly (ie [Reactive Messaging's > Emitter|https://smallrye.io/smallrye-reactive-messaging/smallrye-reactive-messaging/2/emitter/emitter.html#emitter-overflow] > abstract it with its overflow policies to save blocking the caller thread). > If JMS 2 both impl cannot be turned into non-blocking then there're just 2 > options: > # using the blocking variant: it means that scalability tests requires using > machines with high core numbers > # using [Reactive > Messaging|https://github.com/eclipse/microprofile-reactive-messaging], but > losing the ability to use local transactions (and maybe other JMS features) > With the first option the number of producers threads can easily be much more > then the available cores, causing the load generator to benchmark OS (or the > runtime) ability to context switch threads instead of the broker. That's why > a non-blocking approach should be preferred. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (ARTEMIS-3522) Implement performance tools to evaluate throughput and Response Under Load performance of Artemis
[ https://issues.apache.org/jira/browse/ARTEMIS-3522?focusedWorklogId=735274&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735274 ] ASF GitHub Bot logged work on ARTEMIS-3522: --- Author: ASF GitHub Bot Created on: 02/Mar/22 12:49 Start Date: 02/Mar/22 12:49 Worklog Time Spent: 10m Work Description: asfgit closed pull request #3857: URL: https://github.com/apache/activemq-artemis/pull/3857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 735274) Time Spent: 2h 40m (was: 2.5h) > Implement performance tools to evaluate throughput and Response Under Load > performance of Artemis > - > > Key: ARTEMIS-3522 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3522 > Project: ActiveMQ Artemis > Issue Type: New Feature > Components: Broker, JMS >Reporter: Francesco Nigro >Assignee: Francesco Nigro >Priority: Major > Time Spent: 2h 40m > Remaining Estimate: 0h > > There are many performance benchmarks around eg [SoftwareMill > MqPerf|https://softwaremill.com/mqperf/] that could be used to test > performance of Artemis in specific scenario, but none is both simple and easy > to be composed with ad-hoc env setup scripts to perform a wide range of > different performance tests against the broker. > This JIRA aim to provide CLI commands that could be used as building blocks > to perform: > * all-out throughput tests > * responsiveness under load tests (with no [coordinated > omission|http://highscalability.com/blog/2015/10/5/your-load-generator-is-probably-lying-to-you-take-the-red-pi.html]) > ie fixed throughput (per producer) load > * scalability tests > The effort of this JIRA should produce CLI commands similar to [Apache Pulsar > Perf|https://pulsar.apache.org/docs/en/performance-pulsar-perf/] that could > be composed to create complete performance benchmark pipelines (eg using > [qDup|https://github.com/Hyperfoil/qDup] and > [Horreum|https://github.com/Hyperfoil/Horreum] on a CI/CD) or used as-it-is > by users to quickly check performance of the broker. > Requirements: > * support AMQP and Core protocol > * cross JVMs with microseconds time measurement granularity > * support parsable output format > * suitable to perform scale tests > The last requirement can be achieved both by using MessageListeners and async > producers available on [JMS > 2|https://javaee.github.io/jms-spec/pages/JMS20FinalRelease] although both > [qpid JMS|https://github.com/apache/qpid-jms] and Artemis Core protocols > blocks the producer caller thread ie the former on > [jmsConnection::send|https://github.com/apache/qpid-jms/blob/1622de679c3c6763db54e9ac506ef2412fbc4481/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsConnection.java#L773], > awaiting Netty threads to unblock it on > [AmqpFixedProducer::doSend|https://github.com/apache/qpid-jms/blob/1622de679c3c6763db54e9ac506ef2412fbc4481/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpFixedProducer.java#L169], > while the latter on > [ClientProducerImpl::sendRegularMessage|https://github.com/apache/activemq-artemis/blob/e364961c8f035613f3ce4e3bdb3430a17efb0ffd/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientProducerImpl.java#L284-L294]. > This seems odd because [JMS 2's > CompletionListener|https://docs.oracle.com/javaee/7/api/javax/jms/CompletionListener.html] > should save any previous send operation to ever block and the user should > take care (despite being tedious and error-prone) to track the amount of > in-flight messages and limit it accordly (ie [Reactive Messaging's > Emitter|https://smallrye.io/smallrye-reactive-messaging/smallrye-reactive-messaging/2/emitter/emitter.html#emitter-overflow] > abstract it with its overflow policies to save blocking the caller thread). > If JMS 2 both impl cannot be turned into non-blocking then there're just 2 > options: > # using the blocking variant: it means that scalability tests requires using > machines with high core numbers > # using [Reactive > Messaging|https://github.com/eclipse/microprofile-reactive-messaging], but > losing the ability to use local transactions (and maybe other JMS features) > With the first option the number of producers threads can easily be much more > then the available cores, causing the load generator to benchmark OS (or the > runti
[jira] [Commented] (AMQ-8520) Default maven build does not build all modules
[ https://issues.apache.org/jira/browse/AMQ-8520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500203#comment-17500203 ] Jean-Baptiste Onofré commented on AMQ-8520: --- I confirm that 5.16.x is not impacted, only main/5.17.x. Testing the PR. > Default maven build does not build all modules > -- > > Key: AMQ-8520 > URL: https://issues.apache.org/jira/browse/AMQ-8520 > Project: ActiveMQ > Issue Type: Bug >Affects Versions: 5.16.4 >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 5.17.0, 5.16.5 > > Time Spent: 40m > Remaining Estimate: 0h > > There are some optional modules defined under the profile "full.test". These > modules need to be added by default back to the normal build so they are > compiled and installed as there are dependencies on them for other modules. > The tests can be skipped by default but the actual modules need to still > always be built. This is a problem as now version 5.18 fails to build without > old snapshots plus it means all of the testing in CI is using stale snapshots. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (AMQ-8520) Default maven build does not build all modules
[ https://issues.apache.org/jira/browse/AMQ-8520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré updated AMQ-8520: -- Fix Version/s: (was: 5.16.5) > Default maven build does not build all modules > -- > > Key: AMQ-8520 > URL: https://issues.apache.org/jira/browse/AMQ-8520 > Project: ActiveMQ > Issue Type: Bug >Affects Versions: 5.16.4 >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 5.17.0 > > Time Spent: 40m > Remaining Estimate: 0h > > There are some optional modules defined under the profile "full.test". These > modules need to be added by default back to the normal build so they are > compiled and installed as there are dependencies on them for other modules. > The tests can be skipped by default but the actual modules need to still > always be built. This is a problem as now version 5.18 fails to build without > old snapshots plus it means all of the testing in CI is using stale snapshots. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (AMQ-8520) Default maven build does not build all modules
[ https://issues.apache.org/jira/browse/AMQ-8520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré updated AMQ-8520: -- Affects Version/s: (was: 5.16.4) > Default maven build does not build all modules > -- > > Key: AMQ-8520 > URL: https://issues.apache.org/jira/browse/AMQ-8520 > Project: ActiveMQ > Issue Type: Bug >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 5.17.0 > > Time Spent: 40m > Remaining Estimate: 0h > > There are some optional modules defined under the profile "full.test". These > modules need to be added by default back to the normal build so they are > compiled and installed as there are dependencies on them for other modules. > The tests can be skipped by default but the actual modules need to still > always be built. This is a problem as now version 5.18 fails to build without > old snapshots plus it means all of the testing in CI is using stale snapshots. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (AMQ-8520) Default maven build does not build all modules
[ https://issues.apache.org/jira/browse/AMQ-8520?focusedWorklogId=735329&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735329 ] ASF GitHub Bot logged work on AMQ-8520: --- Author: ASF GitHub Bot Created on: 02/Mar/22 14:36 Start Date: 02/Mar/22 14:36 Worklog Time Spent: 10m Work Description: jbonofre commented on pull request #787: URL: https://github.com/apache/activemq/pull/787#issuecomment-105784 Testing the PR now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 735329) Time Spent: 50m (was: 40m) > Default maven build does not build all modules > -- > > Key: AMQ-8520 > URL: https://issues.apache.org/jira/browse/AMQ-8520 > Project: ActiveMQ > Issue Type: Bug >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 5.17.0 > > Time Spent: 50m > Remaining Estimate: 0h > > There are some optional modules defined under the profile "full.test". These > modules need to be added by default back to the normal build so they are > compiled and installed as there are dependencies on them for other modules. > The tests can be skipped by default but the actual modules need to still > always be built. This is a problem as now version 5.18 fails to build without > old snapshots plus it means all of the testing in CI is using stale snapshots. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (AMQ-8515) FailoverTransport should specifically handle MaxFrameSizeExceededException
[ https://issues.apache.org/jira/browse/AMQ-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500208#comment-17500208 ] Jean-Baptiste Onofré commented on AMQ-8515: --- Ah ok cool, cherry picking on 5.16.x then. > FailoverTransport should specifically handle MaxFrameSizeExceededException > -- > > Key: AMQ-8515 > URL: https://issues.apache.org/jira/browse/AMQ-8515 > Project: ActiveMQ > Issue Type: Improvement >Affects Versions: 5.16.4 >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Major > Fix For: 5.17.0, 5.16.5 > > Time Spent: 50m > Remaining Estimate: 0h > > Since MaxFrameSizeExceededException extends IOException, the failover > transport handles it as a reconnect scenario, instead of re-throwing > MaxFrameSizeExceededException to the caller > Note: client-side maxFrameSize=false, with failover=true and server-side > maxFrameSize= true results in infinite retries since the broker hard-closes > the connection and the failover transport resets the 'connection failure > counter' to zero upon successful reconnect (since the broker transport isn't > really offline). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (AMQ-8515) FailoverTransport should specifically handle MaxFrameSizeExceededException
[ https://issues.apache.org/jira/browse/AMQ-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré resolved AMQ-8515. --- Resolution: Fixed > FailoverTransport should specifically handle MaxFrameSizeExceededException > -- > > Key: AMQ-8515 > URL: https://issues.apache.org/jira/browse/AMQ-8515 > Project: ActiveMQ > Issue Type: Improvement >Affects Versions: 5.16.4 >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Major > Fix For: 5.17.0, 5.16.5 > > Time Spent: 50m > Remaining Estimate: 0h > > Since MaxFrameSizeExceededException extends IOException, the failover > transport handles it as a reconnect scenario, instead of re-throwing > MaxFrameSizeExceededException to the caller > Note: client-side maxFrameSize=false, with failover=true and server-side > maxFrameSize= true results in infinite retries since the broker hard-closes > the connection and the failover transport resets the 'connection failure > counter' to zero upon successful reconnect (since the broker transport isn't > really offline). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (AMQ-8515) FailoverTransport should specifically handle MaxFrameSizeExceededException
[ https://issues.apache.org/jira/browse/AMQ-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500212#comment-17500212 ] ASF subversion and git services commented on AMQ-8515: -- Commit 9db5f436cfa1a332f1dbd8e0f6a0563b5c1cab60 in activemq's branch refs/heads/activemq-5.16.x from Matt Pavlovich [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=9db5f43 ] [AMQ-8515] FailoverTransport should handle MaxFrameSizeExceededException (#785) (cherry picked from commit 094dbc89f3630691f1bd66d0d07fe879842fa51b) > FailoverTransport should specifically handle MaxFrameSizeExceededException > -- > > Key: AMQ-8515 > URL: https://issues.apache.org/jira/browse/AMQ-8515 > Project: ActiveMQ > Issue Type: Improvement >Affects Versions: 5.16.4 >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Major > Fix For: 5.17.0, 5.16.5 > > Time Spent: 50m > Remaining Estimate: 0h > > Since MaxFrameSizeExceededException extends IOException, the failover > transport handles it as a reconnect scenario, instead of re-throwing > MaxFrameSizeExceededException to the caller > Note: client-side maxFrameSize=false, with failover=true and server-side > maxFrameSize= true results in infinite retries since the broker hard-closes > the connection and the failover transport resets the 'connection failure > counter' to zero upon successful reconnect (since the broker transport isn't > really offline). -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (AMQ-8520) Default maven build does not build all modules
[
https://issues.apache.org/jira/browse/AMQ-8520?focusedWorklogId=735354&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735354
]
ASF GitHub Bot logged work on AMQ-8520:
---
Author: ASF GitHub Bot
Created on: 02/Mar/22 15:21
Start Date: 02/Mar/22 15:21
Worklog Time Spent: 10m
Work Description: jbonofre commented on a change in pull request #789:
URL: https://github.com/apache/activemq/pull/789#discussion_r817798807
##
File path:
activemq-unit-tests/src/test/java/org/apache/activemq/ProducerFlowControlTest.java
##
@@ -261,7 +261,7 @@ public void testDisableWarning() throws Exception {
Appender appender = new DefaultTestAppender() {
Review comment:
Instead of the DefaultTestAppender, you can now use log4j
AbstractAppender with var as I did in other modules.
##
File path:
activemq-unit-tests/src/test/java/org/apache/activemq/broker/region/QueuePurgeTest.java
##
@@ -108,31 +108,30 @@ private void testPurgeLargeQueue(boolean
prioritizedMessages) throws Exception {
QueueViewMBean proxy = getProxyToQueueViewMBean();
LOG.info("purging..");
-org.apache.log4j.Logger log4jLogger =
org.apache.log4j.Logger.getLogger(org.apache.activemq.broker.jmx.QueueView.class);
+org.apache.logging.log4j.core.Logger log4jLogger =
(org.apache.logging.log4j.core.Logger)LogManager.getLogger(org.apache.activemq.broker.jmx.QueueView.class);
+
final AtomicBoolean gotPurgeLogMessage = new AtomicBoolean(false);
Appender appender = new DefaultTestAppender() {
Review comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 735354)
Time Spent: 1h (was: 50m)
> Default maven build does not build all modules
> --
>
> Key: AMQ-8520
> URL: https://issues.apache.org/jira/browse/AMQ-8520
> Project: ActiveMQ
> Issue Type: Bug
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>Priority: Major
> Fix For: 5.17.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> There are some optional modules defined under the profile "full.test". These
> modules need to be added by default back to the normal build so they are
> compiled and installed as there are dependencies on them for other modules.
> The tests can be skipped by default but the actual modules need to still
> always be built. This is a problem as now version 5.18 fails to build without
> old snapshots plus it means all of the testing in CI is using stale snapshots.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (AMQ-8496) Add activemq-jaas in activemq-rar
[ https://issues.apache.org/jira/browse/AMQ-8496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré updated AMQ-8496: -- Fix Version/s: 5.18.0 (was: 5.17.0) (was: 5.16.5) > Add activemq-jaas in activemq-rar > - > > Key: AMQ-8496 > URL: https://issues.apache.org/jira/browse/AMQ-8496 > Project: ActiveMQ > Issue Type: Improvement > Components: RAR >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 5.18.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (AMQ-7358) Use Jetty atomic jar instead of jetty-all uber jar
[ https://issues.apache.org/jira/browse/AMQ-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré resolved AMQ-7358. --- Resolution: Fixed > Use Jetty atomic jar instead of jetty-all uber jar > -- > > Key: AMQ-7358 > URL: https://issues.apache.org/jira/browse/AMQ-7358 > Project: ActiveMQ > Issue Type: Improvement > Components: Broker, Web Console >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 5.17.0, 5.16.5 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (AMQ-8461) Upgrade to Jetty 9.4.45
[ https://issues.apache.org/jira/browse/AMQ-8461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500234#comment-17500234 ] ASF subversion and git services commented on AMQ-8461: -- Commit b9d24e586d8da9cd47c4364efefe311eb07eef37 in activemq's branch refs/heads/activemq-5.16.x from Jean-Baptiste Onofré [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=b9d24e5 ] Use Jetty atomic jar files instead of jetty-all (deprecated) and update to Jetty 9.4.45.v20220203 (#784) * [AMQ-7358] Use jetty atomic jar files instead of jetty-all uber jar (deprecated according to Jetty team) [AMQ-8461] Upgrade to Jetty 9.4.45.v20220203 (cherry picked from commit fa461c876abdced9906a865a9a47a819febb2fb9) > Upgrade to Jetty 9.4.45 > --- > > Key: AMQ-8461 > URL: https://issues.apache.org/jira/browse/AMQ-8461 > Project: ActiveMQ > Issue Type: Dependency upgrade > Components: Transport, Web Console >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 5.17.0, 5.16.5 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (AMQ-8461) Upgrade to Jetty 9.4.45
[ https://issues.apache.org/jira/browse/AMQ-8461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré resolved AMQ-8461. --- Resolution: Fixed > Upgrade to Jetty 9.4.45 > --- > > Key: AMQ-8461 > URL: https://issues.apache.org/jira/browse/AMQ-8461 > Project: ActiveMQ > Issue Type: Dependency upgrade > Components: Transport, Web Console >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 5.17.0, 5.16.5 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (AMQ-7358) Use Jetty atomic jar instead of jetty-all uber jar
[ https://issues.apache.org/jira/browse/AMQ-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500233#comment-17500233 ] ASF subversion and git services commented on AMQ-7358: -- Commit b9d24e586d8da9cd47c4364efefe311eb07eef37 in activemq's branch refs/heads/activemq-5.16.x from Jean-Baptiste Onofré [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=b9d24e5 ] Use Jetty atomic jar files instead of jetty-all (deprecated) and update to Jetty 9.4.45.v20220203 (#784) * [AMQ-7358] Use jetty atomic jar files instead of jetty-all uber jar (deprecated according to Jetty team) [AMQ-8461] Upgrade to Jetty 9.4.45.v20220203 (cherry picked from commit fa461c876abdced9906a865a9a47a819febb2fb9) > Use Jetty atomic jar instead of jetty-all uber jar > -- > > Key: AMQ-7358 > URL: https://issues.apache.org/jira/browse/AMQ-7358 > Project: ActiveMQ > Issue Type: Improvement > Components: Broker, Web Console >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 5.17.0, 5.16.5 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (AMQ-8520) Default maven build does not build all modules
[ https://issues.apache.org/jira/browse/AMQ-8520?focusedWorklogId=735363&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735363 ] ASF GitHub Bot logged work on AMQ-8520: --- Author: ASF GitHub Bot Created on: 02/Mar/22 15:33 Start Date: 02/Mar/22 15:33 Worklog Time Spent: 10m Work Description: cshannon commented on pull request #789: URL: https://github.com/apache/activemq/pull/789#issuecomment-1057064244 I'm looking now, we can probably merge my PR first and then rebase and merge in this one to keep the tree clean -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 735363) Time Spent: 1h 10m (was: 1h) > Default maven build does not build all modules > -- > > Key: AMQ-8520 > URL: https://issues.apache.org/jira/browse/AMQ-8520 > Project: ActiveMQ > Issue Type: Bug >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 5.17.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > There are some optional modules defined under the profile "full.test". These > modules need to be added by default back to the normal build so they are > compiled and installed as there are dependencies on them for other modules. > The tests can be skipped by default but the actual modules need to still > always be built. This is a problem as now version 5.18 fails to build without > old snapshots plus it means all of the testing in CI is using stale snapshots. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (AMQ-8520) Default maven build does not build all modules
[ https://issues.apache.org/jira/browse/AMQ-8520?focusedWorklogId=735372&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735372 ] ASF GitHub Bot logged work on AMQ-8520: --- Author: ASF GitHub Bot Created on: 02/Mar/22 15:55 Start Date: 02/Mar/22 15:55 Worklog Time Spent: 10m Work Description: cshannon commented on pull request #789: URL: https://github.com/apache/activemq/pull/789#issuecomment-1057086462 I'm getting compilation failures still when using this commit on top of my other PR and building -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 735372) Time Spent: 1h 20m (was: 1h 10m) > Default maven build does not build all modules > -- > > Key: AMQ-8520 > URL: https://issues.apache.org/jira/browse/AMQ-8520 > Project: ActiveMQ > Issue Type: Bug >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 5.17.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > There are some optional modules defined under the profile "full.test". These > modules need to be added by default back to the normal build so they are > compiled and installed as there are dependencies on them for other modules. > The tests can be skipped by default but the actual modules need to still > always be built. This is a problem as now version 5.18 fails to build without > old snapshots plus it means all of the testing in CI is using stale snapshots. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (AMQ-8520) Default maven build does not build all modules
[ https://issues.apache.org/jira/browse/AMQ-8520?focusedWorklogId=735374&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735374 ] ASF GitHub Bot logged work on AMQ-8520: --- Author: ASF GitHub Bot Created on: 02/Mar/22 16:02 Start Date: 02/Mar/22 16:02 Worklog Time Spent: 10m Work Description: cshannon commented on pull request #789: URL: https://github.com/apache/activemq/pull/789#issuecomment-1057093270 Still lots of classes broken: AMQ4221Test, AMQ4221Test, AMQ4221Test, AMQ3567Test, AMQ1936Test, AMQ3779Test, Log4JConfigTest.java And that's just some of them, there's a lot more -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 735374) Time Spent: 1.5h (was: 1h 20m) > Default maven build does not build all modules > -- > > Key: AMQ-8520 > URL: https://issues.apache.org/jira/browse/AMQ-8520 > Project: ActiveMQ > Issue Type: Bug >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 5.17.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > There are some optional modules defined under the profile "full.test". These > modules need to be added by default back to the normal build so they are > compiled and installed as there are dependencies on them for other modules. > The tests can be skipped by default but the actual modules need to still > always be built. This is a problem as now version 5.18 fails to build without > old snapshots plus it means all of the testing in CI is using stale snapshots. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (AMQ-8520) Default maven build does not build all modules
[ https://issues.apache.org/jira/browse/AMQ-8520?focusedWorklogId=735379&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735379 ] ASF GitHub Bot logged work on AMQ-8520: --- Author: ASF GitHub Bot Created on: 02/Mar/22 16:07 Start Date: 02/Mar/22 16:07 Worklog Time Spent: 10m Work Description: mattrpav commented on pull request #789: URL: https://github.com/apache/activemq/pull/789#issuecomment-1057098329 @cshannon yep. this is WIP -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 735379) Time Spent: 1h 40m (was: 1.5h) > Default maven build does not build all modules > -- > > Key: AMQ-8520 > URL: https://issues.apache.org/jira/browse/AMQ-8520 > Project: ActiveMQ > Issue Type: Bug >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 5.17.0 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > There are some optional modules defined under the profile "full.test". These > modules need to be added by default back to the normal build so they are > compiled and installed as there are dependencies on them for other modules. > The tests can be skipped by default but the actual modules need to still > always be built. This is a problem as now version 5.18 fails to build without > old snapshots plus it means all of the testing in CI is using stale snapshots. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (ARTEMIS-3700) Provide JakartaEE 10 artefacts and support
Emmanuel Hugonnet created ARTEMIS-3700: -- Summary: Provide JakartaEE 10 artefacts and support Key: ARTEMIS-3700 URL: https://issues.apache.org/jira/browse/ARTEMIS-3700 Project: ActiveMQ Artemis Issue Type: Improvement Components: API Affects Versions: 2.20.0 Reporter: Emmanuel Hugonnet With Jakarta Messaging 3.1 to be released we should plan to provide support of the new set of APIs. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (ARTEMIS-3700) Provide JakartaEE 10 artefacts and support
[ https://issues.apache.org/jira/browse/ARTEMIS-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500283#comment-17500283 ] Justin Bertram commented on ARTEMIS-3700: - Where's the 3.1 specification? I haven't been able to locate it. > Provide JakartaEE 10 artefacts and support > -- > > Key: ARTEMIS-3700 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3700 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: API >Affects Versions: 2.20.0 >Reporter: Emmanuel Hugonnet >Priority: Major > > With Jakarta Messaging 3.1 to be released we should plan to provide support > of the new set of APIs. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (ARTEMIS-3700) Provide JakartaEE 10 artefacts and support
[ https://issues.apache.org/jira/browse/ARTEMIS-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500284#comment-17500284 ] Emmanuel Hugonnet commented on ARTEMIS-3700: API is staged at https://jakarta.oss.sonatype.org/content/repositories/staging/jakarta/jms/jakarta.jms-api/3.1.0/ > Provide JakartaEE 10 artefacts and support > -- > > Key: ARTEMIS-3700 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3700 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: API >Affects Versions: 2.20.0 >Reporter: Emmanuel Hugonnet >Priority: Major > > With Jakarta Messaging 3.1 to be released we should plan to provide support > of the new set of APIs. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (ARTEMIS-3700) Provide JakartaEE 10 artefacts and support
[ https://issues.apache.org/jira/browse/ARTEMIS-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500288#comment-17500288 ] Justin Bertram commented on ARTEMIS-3700: - Is there no specification or even a clear list of additions/changes in 3.1? Even if there was just a list I could then go to the staged JavaDoc and get the details. At this point the only option I see is to compare & contrast the old JavaDoc with the new JavaDoc which would be a rather inefficient use of time. I'm not sure it will be viable to implement 3.1 until there's a clear specification. > Provide JakartaEE 10 artefacts and support > -- > > Key: ARTEMIS-3700 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3700 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: API >Affects Versions: 2.20.0 >Reporter: Emmanuel Hugonnet >Priority: Major > > With Jakarta Messaging 3.1 to be released we should plan to provide support > of the new set of APIs. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (ARTEMIS-3699) EmbeddedActiveMQ port configuration
[
https://issues.apache.org/jira/browse/ARTEMIS-3699?focusedWorklogId=735433&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735433
]
ASF GitHub Bot logged work on ARTEMIS-3699:
---
Author: ASF GitHub Bot
Created on: 02/Mar/22 17:34
Start Date: 02/Mar/22 17:34
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3969:
URL: https://github.com/apache/activemq-artemis/pull/3969#discussion_r817935136
##
File path:
tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/remoting/impl/netty/NettyAcceptorTest.java
##
@@ -123,4 +124,20 @@ public void testAutoStart() throws Exception {
assertTrue(server.getRemotingService().getAcceptor("start").isStarted());
assertFalse(server.getRemotingService().getAcceptor("noStart").isStarted());
}
+
+ @Test
+ public void testActualPort() throws Exception {
+ String acceptor1Name = RandomUtil.randomString();
+ String acceptor2Name = RandomUtil.randomString();
+ String acceptor3Name = RandomUtil.randomString();
+ ActiveMQServer server = createServer(false, createDefaultInVMConfig());
+ server.getConfiguration().addAcceptorConfiguration(acceptor1Name,
"tcp://127.0.0.1:0");
+ server.getConfiguration().addAcceptorConfiguration(acceptor2Name,
"tcp://127.0.0.1:0");
+ server.getConfiguration().addAcceptorConfiguration(acceptor3Name,
"tcp://127.0.0.1:61616");
+ server.start();
Review comment:
Are you sure the activation here is not asynchronous? meaning you should
use a Wait.assertTrue... or perhaps a Wait.assertTrue(server::isActive) before
you check the next assertions?
just trying to avoid an intermittent test failure here due to the async
start.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 735433)
Time Spent: 0.5h (was: 20m)
> EmbeddedActiveMQ port configuration
> ---
>
> Key: ARTEMIS-3699
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3699
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Robin
>Assignee: Justin Bertram
>Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When creating an instance of EmbeddedActiveMQ the port that the broker binds
> to is taken from the acceptor uri supplied to the configuration. Afterwards
> there is no easy way to get the port out of the broker instance. In addition,
> it would have been nice if one could provide 0 for port to have it start up
> on a random available port. Could this be implemented?
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (ARTEMIS-3700) Provide JakartaEE 10 artefacts and support
[ https://issues.apache.org/jira/browse/ARTEMIS-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500312#comment-17500312 ] Robbie Gemmell commented on ARTEMIS-3700: - Change log: [https://github.com/jakartaee/messaging/commit/eb973580f8bd976d8a47e689ac60d98cafc31338] Code diff: [https://github.com/jakartaee/messaging/compare/3.0.0-RELEASE...3.1.0-RELEASE] Looks almost the same. New exception constructors. Java 11 minimum. Tweak to an annotation. Mostly build changes and typos+fixups otherwise. > Provide JakartaEE 10 artefacts and support > -- > > Key: ARTEMIS-3700 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3700 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: API >Affects Versions: 2.20.0 >Reporter: Emmanuel Hugonnet >Priority: Major > > With Jakarta Messaging 3.1 to be released we should plan to provide support > of the new set of APIs. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Comment Edited] (ARTEMIS-3700) Provide JakartaEE 10 artefacts and support
[ https://issues.apache.org/jira/browse/ARTEMIS-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500312#comment-17500312 ] Robbie Gemmell edited comment on ARTEMIS-3700 at 3/2/22, 5:55 PM: -- Change log: [https://github.com/jakartaee/messaging/commit/eb973580f8bd976d8a47e689ac60d98cafc31338] Code diff: [https://github.com/jakartaee/messaging/compare/3.0.0-RELEASE...3.1.0-RELEASE#files_bucket] Looks almost the same. New exception constructors. Java 11 minimum. Tweak to an annotation. Mostly build changes and typos+fixups otherwise. was (Author: gemmellr): Change log: [https://github.com/jakartaee/messaging/commit/eb973580f8bd976d8a47e689ac60d98cafc31338] Code diff: [https://github.com/jakartaee/messaging/compare/3.0.0-RELEASE...3.1.0-RELEASE] Looks almost the same. New exception constructors. Java 11 minimum. Tweak to an annotation. Mostly build changes and typos+fixups otherwise. > Provide JakartaEE 10 artefacts and support > -- > > Key: ARTEMIS-3700 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3700 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: API >Affects Versions: 2.20.0 >Reporter: Emmanuel Hugonnet >Priority: Major > > With Jakarta Messaging 3.1 to be released we should plan to provide support > of the new set of APIs. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Comment Edited] (ARTEMIS-3700) Provide JakartaEE 10 artefacts and support
[ https://issues.apache.org/jira/browse/ARTEMIS-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500312#comment-17500312 ] Robbie Gemmell edited comment on ARTEMIS-3700 at 3/2/22, 6:00 PM: -- Change log: [https://github.com/jakartaee/messaging/blame/3.1.0-RELEASE/spec/src/main/asciidoc/messaging-spec.adoc#L6828-L6842] Code diff: [https://github.com/jakartaee/messaging/compare/3.0.0-RELEASE...3.1.0-RELEASE#files_bucket] Looks almost the same. New exception constructors. Java 11 minimum. Tweak to an annotation. Mostly build changes and typos+fixups otherwise. was (Author: gemmellr): Change log: [https://github.com/jakartaee/messaging/commit/eb973580f8bd976d8a47e689ac60d98cafc31338] Code diff: [https://github.com/jakartaee/messaging/compare/3.0.0-RELEASE...3.1.0-RELEASE#files_bucket] Looks almost the same. New exception constructors. Java 11 minimum. Tweak to an annotation. Mostly build changes and typos+fixups otherwise. > Provide JakartaEE 10 artefacts and support > -- > > Key: ARTEMIS-3700 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3700 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: API >Affects Versions: 2.20.0 >Reporter: Emmanuel Hugonnet >Priority: Major > > With Jakarta Messaging 3.1 to be released we should plan to provide support > of the new set of APIs. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (ARTEMIS-3699) EmbeddedActiveMQ port configuration
[
https://issues.apache.org/jira/browse/ARTEMIS-3699?focusedWorklogId=735478&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735478
]
ASF GitHub Bot logged work on ARTEMIS-3699:
---
Author: ASF GitHub Bot
Created on: 02/Mar/22 18:19
Start Date: 02/Mar/22 18:19
Worklog Time Spent: 10m
Work Description: gemmellr commented on a change in pull request #3969:
URL: https://github.com/apache/activemq-artemis/pull/3969#discussion_r817968168
##
File path:
tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/remoting/impl/netty/NettyAcceptorTest.java
##
@@ -123,4 +124,20 @@ public void testAutoStart() throws Exception {
assertTrue(server.getRemotingService().getAcceptor("start").isStarted());
assertFalse(server.getRemotingService().getAcceptor("noStart").isStarted());
}
+
+ @Test
+ public void testActualPort() throws Exception {
+ String acceptor1Name = RandomUtil.randomString();
+ String acceptor2Name = RandomUtil.randomString();
+ String acceptor3Name = RandomUtil.randomString();
+ ActiveMQServer server = createServer(false, createDefaultInVMConfig());
+ server.getConfiguration().addAcceptorConfiguration(acceptor1Name,
"tcp://127.0.0.1:0");
+ server.getConfiguration().addAcceptorConfiguration(acceptor2Name,
"tcp://127.0.0.1:0");
+ server.getConfiguration().addAcceptorConfiguration(acceptor3Name,
"tcp://127.0.0.1:61616");
+ server.start();
Review comment:
Yep I think it will be (thats what prompted my comment about the
volatile) so that is a good point.
##
File path:
tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/remoting/impl/netty/NettyAcceptorTest.java
##
@@ -123,4 +124,20 @@ public void testAutoStart() throws Exception {
assertTrue(server.getRemotingService().getAcceptor("start").isStarted());
assertFalse(server.getRemotingService().getAcceptor("noStart").isStarted());
}
+
+ @Test
+ public void testActualPort() throws Exception {
+ String acceptor1Name = RandomUtil.randomString();
+ String acceptor2Name = RandomUtil.randomString();
+ String acceptor3Name = RandomUtil.randomString();
+ ActiveMQServer server = createServer(false, createDefaultInVMConfig());
+ server.getConfiguration().addAcceptorConfiguration(acceptor1Name,
"tcp://127.0.0.1:0");
+ server.getConfiguration().addAcceptorConfiguration(acceptor2Name,
"tcp://127.0.0.1:0");
+ server.getConfiguration().addAcceptorConfiguration(acceptor3Name,
"tcp://127.0.0.1:61616");
+ server.start();
+
assertTrue(((NettyAcceptor)server.getRemotingService().getAcceptor(acceptor1Name)).getActualPort()
!= 0);
Review comment:
Having to get the remoting service from the server, then the acceptor
from that, then cast the acceptor to NettyAcceptor to then use this is still
all a bit ugly. Even getting rid of the last bit if nothing else would be a
decent improvement. The 'invm' acceptor seems to have an 'id' concept, could it
return that for this and let the interface have a method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 735478)
Time Spent: 40m (was: 0.5h)
> EmbeddedActiveMQ port configuration
> ---
>
> Key: ARTEMIS-3699
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3699
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Robin
>Assignee: Justin Bertram
>Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When creating an instance of EmbeddedActiveMQ the port that the broker binds
> to is taken from the acceptor uri supplied to the configuration. Afterwards
> there is no easy way to get the port out of the broker instance. In addition,
> it would have been nice if one could provide 0 for port to have it start up
> on a random available port. Could this be implemented?
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Work logged] (ARTEMIS-3699) EmbeddedActiveMQ port configuration
[
https://issues.apache.org/jira/browse/ARTEMIS-3699?focusedWorklogId=735489&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735489
]
ASF GitHub Bot logged work on ARTEMIS-3699:
---
Author: ASF GitHub Bot
Created on: 02/Mar/22 18:40
Start Date: 02/Mar/22 18:40
Worklog Time Spent: 10m
Work Description: jbertram commented on a change in pull request #3969:
URL: https://github.com/apache/activemq-artemis/pull/3969#discussion_r817992561
##
File path:
tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/remoting/impl/netty/NettyAcceptorTest.java
##
@@ -123,4 +124,20 @@ public void testAutoStart() throws Exception {
assertTrue(server.getRemotingService().getAcceptor("start").isStarted());
assertFalse(server.getRemotingService().getAcceptor("noStart").isStarted());
}
+
+ @Test
+ public void testActualPort() throws Exception {
+ String acceptor1Name = RandomUtil.randomString();
+ String acceptor2Name = RandomUtil.randomString();
+ String acceptor3Name = RandomUtil.randomString();
+ ActiveMQServer server = createServer(false, createDefaultInVMConfig());
+ server.getConfiguration().addAcceptorConfiguration(acceptor1Name,
"tcp://127.0.0.1:0");
+ server.getConfiguration().addAcceptorConfiguration(acceptor2Name,
"tcp://127.0.0.1:0");
+ server.getConfiguration().addAcceptorConfiguration(acceptor3Name,
"tcp://127.0.0.1:61616");
+ server.start();
+
assertTrue(((NettyAcceptor)server.getRemotingService().getAcceptor(acceptor1Name)).getActualPort()
!= 0);
Review comment:
Fair enough. Change made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 735489)
Time Spent: 1h (was: 50m)
> EmbeddedActiveMQ port configuration
> ---
>
> Key: ARTEMIS-3699
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3699
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Robin
>Assignee: Justin Bertram
>Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When creating an instance of EmbeddedActiveMQ the port that the broker binds
> to is taken from the acceptor uri supplied to the configuration. Afterwards
> there is no easy way to get the port out of the broker instance. In addition,
> it would have been nice if one could provide 0 for port to have it start up
> on a random available port. Could this be implemented?
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Work logged] (ARTEMIS-3699) EmbeddedActiveMQ port configuration
[
https://issues.apache.org/jira/browse/ARTEMIS-3699?focusedWorklogId=735487&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735487
]
ASF GitHub Bot logged work on ARTEMIS-3699:
---
Author: ASF GitHub Bot
Created on: 02/Mar/22 18:40
Start Date: 02/Mar/22 18:40
Worklog Time Spent: 10m
Work Description: jbertram commented on a change in pull request #3969:
URL: https://github.com/apache/activemq-artemis/pull/3969#discussion_r817992288
##
File path:
tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/remoting/impl/netty/NettyAcceptorTest.java
##
@@ -123,4 +124,20 @@ public void testAutoStart() throws Exception {
assertTrue(server.getRemotingService().getAcceptor("start").isStarted());
assertFalse(server.getRemotingService().getAcceptor("noStart").isStarted());
}
+
+ @Test
+ public void testActualPort() throws Exception {
+ String acceptor1Name = RandomUtil.randomString();
+ String acceptor2Name = RandomUtil.randomString();
+ String acceptor3Name = RandomUtil.randomString();
+ ActiveMQServer server = createServer(false, createDefaultInVMConfig());
+ server.getConfiguration().addAcceptorConfiguration(acceptor1Name,
"tcp://127.0.0.1:0");
+ server.getConfiguration().addAcceptorConfiguration(acceptor2Name,
"tcp://127.0.0.1:0");
+ server.getConfiguration().addAcceptorConfiguration(acceptor3Name,
"tcp://127.0.0.1:61616");
+ server.start();
Review comment:
Good point. Change made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 735487)
Time Spent: 50m (was: 40m)
> EmbeddedActiveMQ port configuration
> ---
>
> Key: ARTEMIS-3699
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3699
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Robin
>Assignee: Justin Bertram
>Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> When creating an instance of EmbeddedActiveMQ the port that the broker binds
> to is taken from the acceptor uri supplied to the configuration. Afterwards
> there is no easy way to get the port out of the broker instance. In addition,
> it would have been nice if one could provide 0 for port to have it start up
> on a random available port. Could this be implemented?
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Work logged] (AMQ-8520) Default maven build does not build all modules
[ https://issues.apache.org/jira/browse/AMQ-8520?focusedWorklogId=735534&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735534 ] ASF GitHub Bot logged work on AMQ-8520: --- Author: ASF GitHub Bot Created on: 02/Mar/22 20:02 Start Date: 02/Mar/22 20:02 Worklog Time Spent: 10m Work Description: cshannon merged pull request #787: URL: https://github.com/apache/activemq/pull/787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 735534) Time Spent: 1h 50m (was: 1h 40m) > Default maven build does not build all modules > -- > > Key: AMQ-8520 > URL: https://issues.apache.org/jira/browse/AMQ-8520 > Project: ActiveMQ > Issue Type: Bug >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 5.17.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > There are some optional modules defined under the profile "full.test". These > modules need to be added by default back to the normal build so they are > compiled and installed as there are dependencies on them for other modules. > The tests can be skipped by default but the actual modules need to still > always be built. This is a problem as now version 5.18 fails to build without > old snapshots plus it means all of the testing in CI is using stale snapshots. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (AMQ-8520) Default maven build does not build all modules
[ https://issues.apache.org/jira/browse/AMQ-8520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500371#comment-17500371 ] ASF subversion and git services commented on AMQ-8520: -- Commit c1b35058d3b3fd388aa714af0726e4063fa9d7e1 in activemq's branch refs/heads/main from Christopher L. Shannon [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=c1b3505 ] Merge pull request #787 from cshannon/AMQ-8520 AMQ-8520: Re-enable all modules to compile and build by default > Default maven build does not build all modules > -- > > Key: AMQ-8520 > URL: https://issues.apache.org/jira/browse/AMQ-8520 > Project: ActiveMQ > Issue Type: Bug >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 5.17.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > There are some optional modules defined under the profile "full.test". These > modules need to be added by default back to the normal build so they are > compiled and installed as there are dependencies on them for other modules. > The tests can be skipped by default but the actual modules need to still > always be built. This is a problem as now version 5.18 fails to build without > old snapshots plus it means all of the testing in CI is using stale snapshots. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (AMQ-8520) Default maven build does not build all modules
[ https://issues.apache.org/jira/browse/AMQ-8520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500370#comment-17500370 ] ASF subversion and git services commented on AMQ-8520: -- Commit f240cb58067636e1b32d17f8748c8028019da262 in activemq's branch refs/heads/main from Christopher L. Shannon (cshannon) [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=f240cb5 ] AMQ-8520: Re-enable all modules to compile and build by default Updates the modules part of the previous full.test profile to always build but skip running tests by default. Also fixed miss dependency updates including log4j and jetty > Default maven build does not build all modules > -- > > Key: AMQ-8520 > URL: https://issues.apache.org/jira/browse/AMQ-8520 > Project: ActiveMQ > Issue Type: Bug >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 5.17.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > There are some optional modules defined under the profile "full.test". These > modules need to be added by default back to the normal build so they are > compiled and installed as there are dependencies on them for other modules. > The tests can be skipped by default but the actual modules need to still > always be built. This is a problem as now version 5.18 fails to build without > old snapshots plus it means all of the testing in CI is using stale snapshots. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (AMQ-8520) Default maven build does not build all modules
[ https://issues.apache.org/jira/browse/AMQ-8520?focusedWorklogId=735539&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735539 ] ASF GitHub Bot logged work on AMQ-8520: --- Author: ASF GitHub Bot Created on: 02/Mar/22 20:06 Start Date: 02/Mar/22 20:06 Worklog Time Spent: 10m Work Description: cshannon commented on pull request #789: URL: https://github.com/apache/activemq/pull/789#issuecomment-1057330999 @mattrpav - I merged #787 so you can rebase off of that. Once we are happy with this PR and things are fixed we can cherry-pick the commits to 2.17.x and continue with the release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 735539) Time Spent: 2h (was: 1h 50m) > Default maven build does not build all modules > -- > > Key: AMQ-8520 > URL: https://issues.apache.org/jira/browse/AMQ-8520 > Project: ActiveMQ > Issue Type: Bug >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 5.17.0 > > Time Spent: 2h > Remaining Estimate: 0h > > There are some optional modules defined under the profile "full.test". These > modules need to be added by default back to the normal build so they are > compiled and installed as there are dependencies on them for other modules. > The tests can be skipped by default but the actual modules need to still > always be built. This is a problem as now version 5.18 fails to build without > old snapshots plus it means all of the testing in CI is using stale snapshots. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (AMQ-8520) Default maven build does not build all modules
[ https://issues.apache.org/jira/browse/AMQ-8520?focusedWorklogId=735795&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735795 ] ASF GitHub Bot logged work on AMQ-8520: --- Author: ASF GitHub Bot Created on: 03/Mar/22 06:59 Start Date: 03/Mar/22 06:59 Worklog Time Spent: 10m Work Description: jbonofre commented on pull request #789: URL: https://github.com/apache/activemq/pull/789#issuecomment-1057736165 Retesting this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 735795) Time Spent: 2h 10m (was: 2h) > Default maven build does not build all modules > -- > > Key: AMQ-8520 > URL: https://issues.apache.org/jira/browse/AMQ-8520 > Project: ActiveMQ > Issue Type: Bug >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 5.17.0 > > Time Spent: 2h 10m > Remaining Estimate: 0h > > There are some optional modules defined under the profile "full.test". These > modules need to be added by default back to the normal build so they are > compiled and installed as there are dependencies on them for other modules. > The tests can be skipped by default but the actual modules need to still > always be built. This is a problem as now version 5.18 fails to build without > old snapshots plus it means all of the testing in CI is using stale snapshots. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (ARTEMIS-3700) Provide JakartaEE 10 artefacts and support
[ https://issues.apache.org/jira/browse/ARTEMIS-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500539#comment-17500539 ] Emmanuel Hugonnet commented on ARTEMIS-3700: Yes that ils m'y understanding while Reading thé specs générateur locally > Provide JakartaEE 10 artefacts and support > -- > > Key: ARTEMIS-3700 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3700 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: API >Affects Versions: 2.20.0 >Reporter: Emmanuel Hugonnet >Priority: Major > > With Jakarta Messaging 3.1 to be released we should plan to provide support > of the new set of APIs. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (ARTEMIS-3700) Provide JakartaEE 10 artefacts and support
[ https://issues.apache.org/jira/browse/ARTEMIS-3700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17500549#comment-17500549 ] Emmanuel Hugonnet commented on ARTEMIS-3700: According to the spec pdf: A.1.1. API changes • issue_311 Bump maven-bundle-plugin version from 4.2.1 to 5.1.4 • issue_306 Remove useless parentheses • issue_298 Repeatable annotation for the connection factory • issue_298 Repeatable annotation for the destination definition A.1.2. Other improvements • issue_313 Update required JDK version to 11 • issue_309 Add a JPMS module-info • issue_291 Version bump from 3.0 to 3.1 • issue_289 Typo fixed • issue_287 Comment fixed • issue_284 Minor updates to spec copyright and version referenced in javadoc > Provide JakartaEE 10 artefacts and support > -- > > Key: ARTEMIS-3700 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3700 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: API >Affects Versions: 2.20.0 >Reporter: Emmanuel Hugonnet >Priority: Major > > With Jakarta Messaging 3.1 to be released we should plan to provide support > of the new set of APIs. -- This message was sent by Atlassian Jira (v8.20.1#820001)
