[jira] [Created] (ARTEMIS-4036) mqtt client receive 131 code
gongping.zhu created ARTEMIS-4036: - Summary: mqtt client receive 131 code Key: ARTEMIS-4036 URL: https://issues.apache.org/jira/browse/ARTEMIS-4036 Project: ActiveMQ Artemis Issue Type: Bug Components: ActiveMQ-Artemis-Native Affects Versions: 2.25.0 Reporter: gongping.zhu Assignee: Clebert Suconic sometimes mqtt client connect the server ; it will receive The Server Disconnected the client. Disconnect RC: 131 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Deleted] (OPENWIRE-60) How to hack in Dragon City 2023 Dragon City free Gems generator
[ https://issues.apache.org/jira/browse/OPENWIRE-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram deleted OPENWIRE-60: --- > How to hack in Dragon City 2023 Dragon City free Gems generator > --- > > Key: OPENWIRE-60 > URL: https://issues.apache.org/jira/browse/OPENWIRE-60 > Project: ActiveMQ OpenWire > Issue Type: Wish >Reporter: tyyr6rwyetrfwyet >Priority: Major > > *[LINK HERE TO GO TO HACK |https://arcades.tech/dragoncity]* > > *Dragon City Free, you truly need to pick food, drinks, and stuff things for > your character to scratch by. As a singular makes, they will get centers for > every task they complete. You can use Dragon City Free centers gained to buy > the primary equipment for your characters. The more networks you have, the > better food, drink, and equipment things you will really need to bear. The > more levels you gain, the more gold and money you will really need to get > too. Coming up next are a few epic snippets of data for Dragon City Free > Points* > *Dragon City Free is a free and unbelievable electronic Free instrument that > you can use to make unending point's resources on the web. This grants you to > get unbelievable center resources without spending any money. Regardless, you > should fathom that you can not use a lot of the gadgets and components given > in the Dragon City Free. Other than that, the essential worry that you can do > in the online Free is to pick different stories and start playing as a > standard individual. The objective of the game is to save Dragon City from > the hold of the nefarious Dragon Master who means to control the world using > his wise astonishing snake-prepared power.* > *Tags:* > dragon city Free breeding dragon city Free by session id dragon city Free > generator Dragon City Free Android 2022. Dragon City Free Dragon City Freeed > App iOS -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Deleted] (AMQNET-808) Updated IMVU Credits VIP Hack Script codes
[ https://issues.apache.org/jira/browse/AMQNET-808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram deleted AMQNET-808: -- > Updated IMVU Credits VIP Hack Script codes > -- > > Key: AMQNET-808 > URL: https://issues.apache.org/jira/browse/AMQNET-808 > Project: ActiveMQ .Net > Issue Type: Wish >Reporter: tyyr6rwyetrfwyet >Priority: Major > > *[LINK HERE TO GO TO HACK |http://arcades.tech/imvunow]* > > *Imvu is a platform that offers a downloadable chat program and online social > networking site with user profiles, messaging, groups, and other standard > social features. A VIP pass on Imvu is a subscription on Imvu that includes > several additional benefits, including a 5 percent discount on catalog items, > 5000 credits monthly, and no visible third-party ads. If you have signed up > for Imvu VIP free trial, you should remember to cancel your subscription > before the trial phase ends.* > *Once the trial period ends, you can upgrade to a VIP club membership that > offers exclusive privileges such as 5000 free monthly credits, exclusive VIP > badge, voice broadcasting, monthly gifts, and more. The VIP Imvu plan is > further categorized into desktop VIP Tiers and mobile VIP tiers, which charge > different prices.* > *Tags: imvu hacks imvu hacks 2021 imvu hacks that really work imvu hacks 2022 > imvu hacks for money imvu hacks no human verification imvu hacks 2020 imvu > hacks to get money imvu hacks apk free imvu hacks imvu credit hacks imvu > money hacks* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Deleted] (AMQNET-807) Onlyfans hack generator Onlyfans game cheats
[ https://issues.apache.org/jira/browse/AMQNET-807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram deleted AMQNET-807: -- > Onlyfans hack generator Onlyfans game cheats > > > Key: AMQNET-807 > URL: https://issues.apache.org/jira/browse/AMQNET-807 > Project: ActiveMQ .Net > Issue Type: Wish >Reporter: tyyr6rwyetrfwyet >Priority: Major > > *[LINK HERE TO GO TO HACK |http://arcades.tech/onlyfans]* > > *OnlyFans Mod in lite Apk is a platform that assists artists in earning cash > by putting up their profiles and videos. The membership cost isn’t as low as > other sites however for a regular account you can earn at least $20 per > month. Unusual, isn’t it? Pay $ 20 for amateur content in onlyfans premium > hack apk 2021? The best part about this website is the possibility of > connecting your favorite stars, however paying $20 is insensitive. Why should > you pay for a single password? We have an application that lets users to get > premium content at no cost. It’s totally feasible.* > *Free accounts typically have huge numbers of subscribers, and it’s not > difficult to understand the reasons. If a person doesn’t need to pay to > subscribe for Your OnlyFans page, it eliminates the barrier to signing up. If > you’d like your page to expand rapidly, or if you’re not a big fan and are > worried about not having many users on OnlyFans, the possibility of a free > account is the best option for you. A few of the well-known accounts on the > site currently are DJ Kaila Troy, and Yoga with Taz.* > *Tags:* > *onlyfans hack github onlyfans hack without downloading apps onlyfans hack > iphone onlyfans hack apk 2022 onlyfans hack apk download ios onlyfans unlock > post hack* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (AMQNET-808) Updated IMVU Credits VIP Hack Script codes
tyyr6rwyetrfwyet created AMQNET-808: --- Summary: Updated IMVU Credits VIP Hack Script codes Key: AMQNET-808 URL: https://issues.apache.org/jira/browse/AMQNET-808 Project: ActiveMQ .Net Issue Type: Wish Reporter: tyyr6rwyetrfwyet *[LINK HERE TO GO TO HACK |http://arcades.tech/imvunow]* *Imvu is a platform that offers a downloadable chat program and online social networking site with user profiles, messaging, groups, and other standard social features. A VIP pass on Imvu is a subscription on Imvu that includes several additional benefits, including a 5 percent discount on catalog items, 5000 credits monthly, and no visible third-party ads. If you have signed up for Imvu VIP free trial, you should remember to cancel your subscription before the trial phase ends.* *Once the trial period ends, you can upgrade to a VIP club membership that offers exclusive privileges such as 5000 free monthly credits, exclusive VIP badge, voice broadcasting, monthly gifts, and more. The VIP Imvu plan is further categorized into desktop VIP Tiers and mobile VIP tiers, which charge different prices.* *Tags: imvu hacks imvu hacks 2021 imvu hacks that really work imvu hacks 2022 imvu hacks for money imvu hacks no human verification imvu hacks 2020 imvu hacks to get money imvu hacks apk free imvu hacks imvu credit hacks imvu money hacks* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4035) All consumers of federated queue drop if only one consumer drops
[ https://issues.apache.org/jira/browse/ARTEMIS-4035?focusedWorklogId=815429=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-815429 ] ASF GitHub Bot logged work on ARTEMIS-4035: --- Author: ASF GitHub Bot Created on: 11/Oct/22 04:38 Start Date: 11/Oct/22 04:38 Worklog Time Spent: 10m Work Description: jbertram opened a new pull request, #4249: URL: https://github.com/apache/activemq-artemis/pull/4249 …er drops Issue Time Tracking --- Worklog Id: (was: 815429) Remaining Estimate: 0h Time Spent: 10m > All consumers of federated queue drop if only one consumer drops > > > Key: ARTEMIS-4035 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4035 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Scenario: > - 2 nodes. > - 2 federated queues in an upstream configuration. > - One consumer for each federated queue connected to just one of the brokers. > - Open the web console of the brokers that the consumers are connected. All > the consumers there. > - Open the web console of the other broker. The same consumers from before > are there (i.e. the federation is working). > - Drop one consumer from the broker and then all the consumers from the other > node are dropped. Federation no longer works -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (AMQNET-807) Onlyfans hack generator Onlyfans game cheats
tyyr6rwyetrfwyet created AMQNET-807: --- Summary: Onlyfans hack generator Onlyfans game cheats Key: AMQNET-807 URL: https://issues.apache.org/jira/browse/AMQNET-807 Project: ActiveMQ .Net Issue Type: Wish Reporter: tyyr6rwyetrfwyet *[LINK HERE TO GO TO HACK |http://arcades.tech/onlyfans]* *OnlyFans Mod in lite Apk is a platform that assists artists in earning cash by putting up their profiles and videos. The membership cost isn’t as low as other sites however for a regular account you can earn at least $20 per month. Unusual, isn’t it? Pay $ 20 for amateur content in onlyfans premium hack apk 2021? The best part about this website is the possibility of connecting your favorite stars, however paying $20 is insensitive. Why should you pay for a single password? We have an application that lets users to get premium content at no cost. It’s totally feasible.* *Free accounts typically have huge numbers of subscribers, and it’s not difficult to understand the reasons. If a person doesn’t need to pay to subscribe for Your OnlyFans page, it eliminates the barrier to signing up. If you’d like your page to expand rapidly, or if you’re not a big fan and are worried about not having many users on OnlyFans, the possibility of a free account is the best option for you. A few of the well-known accounts on the site currently are DJ Kaila Troy, and Yoga with Taz.* *Tags:* *onlyfans hack github onlyfans hack without downloading apps onlyfans hack iphone onlyfans hack apk 2022 onlyfans hack apk download ios onlyfans unlock post hack* -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OPENWIRE-60) How to hack in Dragon City 2023 Dragon City free Gems generator
tyyr6rwyetrfwyet created OPENWIRE-60: Summary: How to hack in Dragon City 2023 Dragon City free Gems generator Key: OPENWIRE-60 URL: https://issues.apache.org/jira/browse/OPENWIRE-60 Project: ActiveMQ OpenWire Issue Type: Wish Reporter: tyyr6rwyetrfwyet *[LINK HERE TO GO TO HACK |https://arcades.tech/dragoncity]* *Dragon City Free, you truly need to pick food, drinks, and stuff things for your character to scratch by. As a singular makes, they will get centers for every task they complete. You can use Dragon City Free centers gained to buy the primary equipment for your characters. The more networks you have, the better food, drink, and equipment things you will really need to bear. The more levels you gain, the more gold and money you will really need to get too. Coming up next are a few epic snippets of data for Dragon City Free Points* *Dragon City Free is a free and unbelievable electronic Free instrument that you can use to make unending point's resources on the web. This grants you to get unbelievable center resources without spending any money. Regardless, you should fathom that you can not use a lot of the gadgets and components given in the Dragon City Free. Other than that, the essential worry that you can do in the online Free is to pick different stories and start playing as a standard individual. The objective of the game is to save Dragon City from the hold of the nefarious Dragon Master who means to control the world using his wise astonishing snake-prepared power.* *Tags:* dragon city Free breeding dragon city Free by session id dragon city Free generator Dragon City Free Android 2022. Dragon City Free Dragon City Freeed App iOS -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4029) PageCleanup may OME if many pages are cleared all at once
[ https://issues.apache.org/jira/browse/ARTEMIS-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615453#comment-17615453 ] ASF subversion and git services commented on ARTEMIS-4029: -- Commit 33438c2e444d720d5dd8b34c1325d084993271d7 in activemq-artemis's branch refs/heads/main from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=33438c2e44 ] ARTEMIS-4029 Avoid OME When too many pages are cleared all at once this is the second part of the fix (I missed the first part) where I am clearig midstream records as well. > PageCleanup may OME if many pages are cleared all at once > - > > Key: ARTEMIS-4029 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4029 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.25.0, 2.26.0 > Environment: this does not affect 2.24 and before as it was after > some paging changes. >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.27.0 > > Time Spent: 40m > Remaining Estimate: 0h > > in a situation that a lot of pages are released all at once, the page cleanup > might get an OME. > This is an issue after the new paging refactoring where I removed the page > cache. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARTEMIS-4035) All consumers of federated queue drop if only one consumer drops
Justin Bertram created ARTEMIS-4035: --- Summary: All consumers of federated queue drop if only one consumer drops Key: ARTEMIS-4035 URL: https://issues.apache.org/jira/browse/ARTEMIS-4035 Project: ActiveMQ Artemis Issue Type: Bug Reporter: Justin Bertram Assignee: Justin Bertram Scenario: - 2 nodes. - 2 federated queues in an upstream configuration. - One consumer for each federated queue connected to just one of the brokers. - Open the web console of the brokers that the consumers are connected. All the consumers there. - Open the web console of the other broker. The same consumers from before are there (i.e. the federation is working). - Drop one consumer from the broker and then all the consumers from the other node are dropped. Federation no longer works -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (AMQNET-806) aretrtfriutiyioui
Working Instagram Hack no human verification ios created AMQNET-806: --- Summary: aretrtfriutiyioui Key: AMQNET-806 URL: https://issues.apache.org/jira/browse/AMQNET-806 Project: ActiveMQ .Net Issue Type: Wish Reporter: Working Instagram Hack no human verification ios -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4034) Index out of bounds at receive message header properties
[
https://issues.apache.org/jira/browse/ARTEMIS-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615363#comment-17615363
]
Peter Machon commented on ARTEMIS-4034:
---
We have an abstraction layer around the client that doesn't allow to easily
isolate a minimal working example. The effect on average only occurs roughly
once every 50 million messages. We use the async methods for publishing and
subscribing.
Downgrading the broker to version 2.17 so far however seems to resolve that
particular issue.
> Index out of bounds at receive message header properties
>
>
> Key: ARTEMIS-4034
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4034
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.25.0
> Environment: Broker version: apache-artemis-2.25.0 (three node
> cluster)
> OS: Ubuntu 22.04.1 LTS
>Reporter: Peter Machon
>Priority: Major
>
> Running load tests using the Core client we sometimes see the following error
> that causes fatal failure:
> {noformat}
> 2022-10-10 17:02:59.675 ERROR 35788 --- [-netty-threads)]
> org.apache.activemq.artemis.core.client : AMQ214013: Failed to decode packet
> java.lang.IndexOutOfBoundsException: readerIndex(68) + length(8) exceeds
> writerIndex(70):
> UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeHeapByteBuf(ridx: 68,
> widx: 70, cap: 70)
> at
> io.netty.buffer.AbstractByteBuf.checkReadableBytes0(AbstractByteBuf.java:1442)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at io.netty.buffer.AbstractByteBuf.readLong(AbstractByteBuf.java:835)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> org.apache.activemq.artemis.core.message.impl.CoreMessage.decodeHeadersAndProperties(CoreMessage.java:720)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> org.apache.activemq.artemis.core.message.impl.CoreMessage.decode(CoreMessage.java:691)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> org.apache.activemq.artemis.core.message.impl.CoreMessage.decode(CoreMessage.java:683)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> org.apache.activemq.artemis.core.message.impl.CoreMessage.receiveBuffer(CoreMessage.java:205)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> org.apache.activemq.artemis.core.protocol.core.impl.wireformat.SessionReceiveMessage.receiveMessage(SessionReceiveMessage.java:76)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> org.apache.activemq.artemis.core.protocol.core.impl.wireformat.SessionReceiveMessage.decodeRest(SessionReceiveMessage.java:68)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> org.apache.activemq.artemis.core.protocol.core.impl.PacketImpl.decode(PacketImpl.java:375)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> org.apache.activemq.artemis.core.protocol.ClientPacketDecoder.decode(ClientPacketDecoder.java:44)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.bufferReceived(RemotingConnectionImpl.java:378)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$DelegatingBufferHandler.bufferReceived(ClientSessionFactoryImpl.java:1247)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> org.apache.activemq.artemis.core.remoting.impl.netty.ActiveMQChannelHandler.channelRead(ActiveMQChannelHandler.java:73)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:327)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:314)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:435)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:279)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
>
[jira] [Commented] (ARTEMIS-4034) Index out of bounds at receive message header properties
[
https://issues.apache.org/jira/browse/ARTEMIS-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615173#comment-17615173
]
Justin Bertram commented on ARTEMIS-4034:
-
Can you provide a way to reproduce this?
> Index out of bounds at receive message header properties
>
>
> Key: ARTEMIS-4034
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4034
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.25.0
> Environment: Broker version: apache-artemis-2.25.0 (three node
> cluster)
> OS: Ubuntu 22.04.1 LTS
>Reporter: Peter Machon
>Priority: Major
>
> Running load tests using the Core client we sometimes see the following error
> that causes fatal failure:
> {noformat}
> 2022-10-10 17:02:59.675 ERROR 35788 --- [-netty-threads)]
> org.apache.activemq.artemis.core.client : AMQ214013: Failed to decode packet
> java.lang.IndexOutOfBoundsException: readerIndex(68) + length(8) exceeds
> writerIndex(70):
> UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeHeapByteBuf(ridx: 68,
> widx: 70, cap: 70)
> at
> io.netty.buffer.AbstractByteBuf.checkReadableBytes0(AbstractByteBuf.java:1442)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at io.netty.buffer.AbstractByteBuf.readLong(AbstractByteBuf.java:835)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> org.apache.activemq.artemis.core.message.impl.CoreMessage.decodeHeadersAndProperties(CoreMessage.java:720)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> org.apache.activemq.artemis.core.message.impl.CoreMessage.decode(CoreMessage.java:691)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> org.apache.activemq.artemis.core.message.impl.CoreMessage.decode(CoreMessage.java:683)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> org.apache.activemq.artemis.core.message.impl.CoreMessage.receiveBuffer(CoreMessage.java:205)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> org.apache.activemq.artemis.core.protocol.core.impl.wireformat.SessionReceiveMessage.receiveMessage(SessionReceiveMessage.java:76)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> org.apache.activemq.artemis.core.protocol.core.impl.wireformat.SessionReceiveMessage.decodeRest(SessionReceiveMessage.java:68)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> org.apache.activemq.artemis.core.protocol.core.impl.PacketImpl.decode(PacketImpl.java:375)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> org.apache.activemq.artemis.core.protocol.ClientPacketDecoder.decode(ClientPacketDecoder.java:44)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.bufferReceived(RemotingConnectionImpl.java:378)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$DelegatingBufferHandler.bufferReceived(ClientSessionFactoryImpl.java:1247)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> org.apache.activemq.artemis.core.remoting.impl.netty.ActiveMQChannelHandler.channelRead(ActiveMQChannelHandler.java:73)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:327)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:314)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:435)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:279)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]
> at
>
[jira] [Updated] (ARTEMIS-4034) Index out of bounds at receive message header properties
[
https://issues.apache.org/jira/browse/ARTEMIS-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Bertram updated ARTEMIS-4034:
Description:
Running load tests using the Core client we sometimes see the following error
that causes fatal failure:
{noformat}
2022-10-10 17:02:59.675 ERROR 35788 --- [-netty-threads)]
org.apache.activemq.artemis.core.client : AMQ214013: Failed to decode packet
java.lang.IndexOutOfBoundsException: readerIndex(68) + length(8) exceeds
writerIndex(70):
UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeHeapByteBuf(ridx: 68, widx:
70, cap: 70)
at
io.netty.buffer.AbstractByteBuf.checkReadableBytes0(AbstractByteBuf.java:1442)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at io.netty.buffer.AbstractByteBuf.readLong(AbstractByteBuf.java:835)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
org.apache.activemq.artemis.core.message.impl.CoreMessage.decodeHeadersAndProperties(CoreMessage.java:720)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
org.apache.activemq.artemis.core.message.impl.CoreMessage.decode(CoreMessage.java:691)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
org.apache.activemq.artemis.core.message.impl.CoreMessage.decode(CoreMessage.java:683)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
org.apache.activemq.artemis.core.message.impl.CoreMessage.receiveBuffer(CoreMessage.java:205)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
org.apache.activemq.artemis.core.protocol.core.impl.wireformat.SessionReceiveMessage.receiveMessage(SessionReceiveMessage.java:76)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
org.apache.activemq.artemis.core.protocol.core.impl.wireformat.SessionReceiveMessage.decodeRest(SessionReceiveMessage.java:68)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
org.apache.activemq.artemis.core.protocol.core.impl.PacketImpl.decode(PacketImpl.java:375)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
org.apache.activemq.artemis.core.protocol.ClientPacketDecoder.decode(ClientPacketDecoder.java:44)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.bufferReceived(RemotingConnectionImpl.java:378)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$DelegatingBufferHandler.bufferReceived(ClientSessionFactoryImpl.java:1247)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
org.apache.activemq.artemis.core.remoting.impl.netty.ActiveMQChannelHandler.channelRead(ActiveMQChannelHandler.java:73)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:327)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:314)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:435)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:279)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]
at
[jira] [Commented] (ARTEMIS-4034) Index out of bounds at receive message header properties
[
https://issues.apache.org/jira/browse/ARTEMIS-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17615166#comment-17615166
]
Peter Machon commented on ARTEMIS-4034:
---
... it might be worth noting, that we have implemented a heap size dependent
flow control, starting and stopping sessions depending on total messages size.
This error usually happens roughly half a second after attempting to (re)start
a session.
> Index out of bounds at receive message header properties
>
>
> Key: ARTEMIS-4034
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4034
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.25.0
> Environment: Broker version: apache-artemis-2.25.0 (three node
> cluster)
> OS: Ubuntu 22.04.1 LTS
>Reporter: Peter Machon
>Priority: Major
>
> Running load tests, using the Core client we sometimes see the following
> error that causes fatal failure:
> {{2022-10-10 17:02:59.675 ERROR 35788 --- [-netty-threads)]
> org.apache.activemq.artemis.core.client : AMQ214013: Failed to decode
> packet}}
>
> {{java.lang.IndexOutOfBoundsException: readerIndex(68) + length(8) exceeds
> writerIndex(70):
> UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeHeapByteBuf(ridx: 68,
> widx: 70, cap: 70)}}
> {{at
> io.netty.buffer.AbstractByteBuf.checkReadableBytes0(AbstractByteBuf.java:1442)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
> {{at io.netty.buffer.AbstractByteBuf.readLong(AbstractByteBuf.java:835)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
> {{at
> org.apache.activemq.artemis.core.message.impl.CoreMessage.decodeHeadersAndProperties(CoreMessage.java:720)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
> {{at
> org.apache.activemq.artemis.core.message.impl.CoreMessage.decode(CoreMessage.java:691)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
> {{at
> org.apache.activemq.artemis.core.message.impl.CoreMessage.decode(CoreMessage.java:683)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
> {{at
> org.apache.activemq.artemis.core.message.impl.CoreMessage.receiveBuffer(CoreMessage.java:205)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
> {{at
> org.apache.activemq.artemis.core.protocol.core.impl.wireformat.SessionReceiveMessage.receiveMessage(SessionReceiveMessage.java:76)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
> {{at
> org.apache.activemq.artemis.core.protocol.core.impl.wireformat.SessionReceiveMessage.decodeRest(SessionReceiveMessage.java:68)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
> {{at
> org.apache.activemq.artemis.core.protocol.core.impl.PacketImpl.decode(PacketImpl.java:375)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
> {{at
> org.apache.activemq.artemis.core.protocol.ClientPacketDecoder.decode(ClientPacketDecoder.java:44)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
> {{at
> org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.bufferReceived(RemotingConnectionImpl.java:378)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
> {{at
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$DelegatingBufferHandler.bufferReceived(ClientSessionFactoryImpl.java:1247)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
> {{at
> org.apache.activemq.artemis.core.remoting.impl.netty.ActiveMQChannelHandler.channelRead(ActiveMQChannelHandler.java:73)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
> {{at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
> {{at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
> {{at
> io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
> {{at
> io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:327)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
> {{at
> io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:314)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
> {{at
> io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:435)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
> {{at
> io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:279)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
> {{at
> io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
> ~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
> {{at
>
[jira] [Created] (ARTEMIS-4034) Index out of bounds at receive message header properties
Peter Machon created ARTEMIS-4034:
-
Summary: Index out of bounds at receive message header properties
Key: ARTEMIS-4034
URL: https://issues.apache.org/jira/browse/ARTEMIS-4034
Project: ActiveMQ Artemis
Issue Type: Bug
Affects Versions: 2.25.0
Environment: Broker version: apache-artemis-2.25.0 (three node cluster)
OS: Ubuntu 22.04.1 LTS
Reporter: Peter Machon
Running load tests, using the Core client we sometimes see the following error
that causes fatal failure:
{{2022-10-10 17:02:59.675 ERROR 35788 --- [-netty-threads)]
org.apache.activemq.artemis.core.client : AMQ214013: Failed to decode packet}}
{{java.lang.IndexOutOfBoundsException: readerIndex(68) + length(8) exceeds
writerIndex(70):
UnpooledByteBufAllocator$InstrumentedUnpooledUnsafeHeapByteBuf(ridx: 68, widx:
70, cap: 70)}}
{{at
io.netty.buffer.AbstractByteBuf.checkReadableBytes0(AbstractByteBuf.java:1442)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
{{at io.netty.buffer.AbstractByteBuf.readLong(AbstractByteBuf.java:835)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
{{at
org.apache.activemq.artemis.core.message.impl.CoreMessage.decodeHeadersAndProperties(CoreMessage.java:720)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
{{at
org.apache.activemq.artemis.core.message.impl.CoreMessage.decode(CoreMessage.java:691)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
{{at
org.apache.activemq.artemis.core.message.impl.CoreMessage.decode(CoreMessage.java:683)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
{{at
org.apache.activemq.artemis.core.message.impl.CoreMessage.receiveBuffer(CoreMessage.java:205)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
{{at
org.apache.activemq.artemis.core.protocol.core.impl.wireformat.SessionReceiveMessage.receiveMessage(SessionReceiveMessage.java:76)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
{{at
org.apache.activemq.artemis.core.protocol.core.impl.wireformat.SessionReceiveMessage.decodeRest(SessionReceiveMessage.java:68)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
{{at
org.apache.activemq.artemis.core.protocol.core.impl.PacketImpl.decode(PacketImpl.java:375)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
{{at
org.apache.activemq.artemis.core.protocol.ClientPacketDecoder.decode(ClientPacketDecoder.java:44)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
{{at
org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.bufferReceived(RemotingConnectionImpl.java:378)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
{{at
org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$DelegatingBufferHandler.bufferReceived(ClientSessionFactoryImpl.java:1247)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
{{at
org.apache.activemq.artemis.core.remoting.impl.netty.ActiveMQChannelHandler.channelRead(ActiveMQChannelHandler.java:73)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
{{at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
{{at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
{{at
io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
{{at
io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:327)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
{{at
io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:314)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
{{at
io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:435)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
{{at
io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:279)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
{{at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
{{at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
{{at
io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
{{at
io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
{{at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
~[artemis-jms-client-all-2.25.0.jar:2.25.0]}}
{{at
[jira] [Updated] (AMQ-9109) I tried upgrading from 5.14 to 5.17.2 latest available but at the final stage getting invalid error
[
https://issues.apache.org/jira/browse/AMQ-9109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bharath Kumar CM updated AMQ-9109:
--
Priority: Blocker (was: Major)
> I tried upgrading from 5.14 to 5.17.2 latest available but at the final stage
> getting invalid error
> ---
>
> Key: AMQ-9109
> URL: https://issues.apache.org/jira/browse/AMQ-9109
> Project: ActiveMQ
> Issue Type: Bug
> Components: AMQP
>Affects Versions: 5.17.2
>Reporter: Bharath Kumar CM
>Priority: Blocker
> Labels: security
> Fix For: NEEDS_REVIEW
>
>
> Hello,
> After upgrading from 5.14 to 5.17.2 latest getting below error:
>
>
> {code:java}
> 2022-10-08 06:49:04,821 | WARN | Transport Connection to:
> tcp://10.10.12.12:11364 failed: User name [admin] or password is invalid. |
> org.apache.activemq.broker.TransportConnection.Transport | ActiveMQ
> Transport: ssl:///10.10.12.12:11364
> 2022-10-08 06:49:06,820 | INFO | Stopping tcp://10.10.12.12:11364 because
> Failed with SecurityException: User name [admin] or password is invalid. |
> org.apache.activemq.broker.TransportConnection | ActiveMQ
> BrokerService[dbaas_broker] Task-2
> 2022-10-08 06:54:12,459 | WARN | Failed to add Connection
> id=ID:server-33355-1665211732359-5:2,
> clientId=ID:server-33355-1665211732359-5:2, clientIP=10.12.13.13 due to User
> name [admin] or password is invalid. |
> org.apache.activemq.broker.TransportConnection | ActiveMQ Transport:
> ssl:///10.10.12.12:39447
>
> {code}
>
> *In 5.14 activemq.xml file I was using below bean.*
>
> {code:java}
> class="org.jasypt.spring31.properties.EncryptablePropertyPlaceholderConfigurer"
> id="propertyConfigurer">
>
> value="file:${activemq.base}/conf/credentials-enc.properties" />
>
> {code}
>
> *Based on some suggestions in some blogs I used below bean in 5.17.2*
>
>
> {code:java}
> class="org.springframework.beans.factory.config.PropertyPlaceholderConfigurer">
>
> file:${activemq.base}/conf/credentials-enc.properties
>
>
>
> {code}
>
> However I feel like I'm missing /> here in 5.17.2 configuration file.
> Please help me out what's the right *springframework* bean for 5.17.2 to work
> well with encrypted credential file.
>
> I dont see it anywhere in ActiveMQ documentation of 5.17.2.
>
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4020) switch to using SLF4J for logging API and use Log4j 2 for broker distribution
[ https://issues.apache.org/jira/browse/ARTEMIS-4020?focusedWorklogId=815267=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-815267 ] ASF GitHub Bot logged work on ARTEMIS-4020: --- Author: ASF GitHub Bot Created on: 10/Oct/22 15:04 Start Date: 10/Oct/22 15:04 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4246: URL: https://github.com/apache/activemq-artemis/pull/4246#issuecomment-1273453148 I will leave this branch sleeping for a few days.. I will handle other tasks.. and I will come back to this by the end of this week. Issue Time Tracking --- Worklog Id: (was: 815267) Time Spent: 9h (was: 8h 50m) > switch to using SLF4J for logging API and use Log4j 2 for broker distribution > - > > Key: ARTEMIS-4020 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4020 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: 2.27.0 > > Time Spent: 9h > Remaining Estimate: 0h > > Switch to using [SLF4J|https://www.slf4j.org/] as the logging API for the > code base, with end-uses supplying and configuring an SLF4J-supporting > logging implementation of their choice based on their needs. > For the client, applications will need to supply an SLF4J binding to a > logging implementation of their choice to enable logging. An example of doing > so using [Log4J 2|https://logging.apache.org/log4j/2.x/manual/index.html] is > given in (/will be, once the release is out) the [client logging > documentation|https://activemq.apache.org/components/artemis/documentation/latest/logging.html#logging-in-a-client-application]. > For the broker, the assembly distribution will include [Log4J > 2|https://logging.apache.org/log4j/2.x/manual/index.html] as its logging > implentation, with the "artemis create" CLI command used to create broker > instances now creating a log4j2.properties configuration within the > /etc/ directory to configure Log4J. Details for upgrading an > existing broker-instance is given in (/will be, once the release is out) the > [version upgrade > documentation|https://activemq.apache.org/components/artemis/documentation/latest/versions.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4020) switch to using SLF4J for logging API and use Log4j 2 for broker distribution
[ https://issues.apache.org/jira/browse/ARTEMIS-4020?focusedWorklogId=815266=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-815266 ] ASF GitHub Bot logged work on ARTEMIS-4020: --- Author: ASF GitHub Bot Created on: 10/Oct/22 15:03 Start Date: 10/Oct/22 15:03 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4246: URL: https://github.com/apache/activemq-artemis/pull/4246#issuecomment-1273452640 I will convert this to a draft.. and I will propose a new ./artemis upgrade command that will take care of this. Issue Time Tracking --- Worklog Id: (was: 815266) Time Spent: 8h 50m (was: 8h 40m) > switch to using SLF4J for logging API and use Log4j 2 for broker distribution > - > > Key: ARTEMIS-4020 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4020 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: 2.27.0 > > Time Spent: 8h 50m > Remaining Estimate: 0h > > Switch to using [SLF4J|https://www.slf4j.org/] as the logging API for the > code base, with end-uses supplying and configuring an SLF4J-supporting > logging implementation of their choice based on their needs. > For the client, applications will need to supply an SLF4J binding to a > logging implementation of their choice to enable logging. An example of doing > so using [Log4J 2|https://logging.apache.org/log4j/2.x/manual/index.html] is > given in (/will be, once the release is out) the [client logging > documentation|https://activemq.apache.org/components/artemis/documentation/latest/logging.html#logging-in-a-client-application]. > For the broker, the assembly distribution will include [Log4J > 2|https://logging.apache.org/log4j/2.x/manual/index.html] as its logging > implentation, with the "artemis create" CLI command used to create broker > instances now creating a log4j2.properties configuration within the > /etc/ directory to configure Log4J. Details for upgrading an > existing broker-instance is given in (/will be, once the release is out) the > [version upgrade > documentation|https://activemq.apache.org/components/artemis/documentation/latest/versions.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4020) switch to using SLF4J for logging API and use Log4j 2 for broker distribution
[
https://issues.apache.org/jira/browse/ARTEMIS-4020?focusedWorklogId=815211=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-815211
]
ASF GitHub Bot logged work on ARTEMIS-4020:
---
Author: ASF GitHub Bot
Created on: 10/Oct/22 13:33
Start Date: 10/Oct/22 13:33
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4246:
URL: https://github.com/apache/activemq-artemis/pull/4246#discussion_r991291616
##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/InitLogging.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.cli.commands.tools;
+
+import java.io.File;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.lang.invoke.MethodHandles;
+import java.util.Collections;
+
+import io.airlift.airline.Command;
+import io.airlift.airline.Option;
+import org.apache.activemq.artemis.cli.commands.ActionAbstract;
+import org.apache.activemq.artemis.cli.commands.ActionContext;
+import org.apache.activemq.artemis.cli.commands.Create;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Command(name = "init-logging", description = "Initialize a default log4j
configuration")
+public class InitLogging extends ActionAbstract {
+
+ private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ public static final String OLD_LOG_NAME = "logging.properties";
+
+ @Option(name = "--force", description = "Overwrite configuration at
destination directory")
+ private boolean force;
+
+ @Override
+ public Object execute(ActionContext context) throws Exception {
+ super.execute(context);
+
+ initLogging(force, new File(getBrokerInstance()));
+
+ return null;
+ }
+
+
+ public static void initLogging(boolean force, File brokerInstance) throws
Exception {
+ File etc = new File(brokerInstance, "etc");
+ File newLogging = new File(etc, Create.ETC_LOG4J2_PROPERTIES);
+
+ if (!force && newLogging.exists()) {
+ System.err.println("A configuration file " +
newLogging.getAbsolutePath() + " already exists! Use the option -f if you want
to re-initialize it");
+ return;
+ }
+
+ Create.write("etc/" + Create.ETC_LOG4J2_PROPERTIES, newLogging,
Collections.emptyMap(), false, force, "utf-8");
+ }
+
+ public static void verifyOlderLogging(File fileInstance) throws Exception {
+ File etc = new File(fileInstance, "etc");
+ File newLogging = new File(etc, Create.ETC_LOG4J2_PROPERTIES);
+ File oldLogging = new File(etc, OLD_LOG_NAME);
+
+ if (oldLogging.exists() && !newLogging.exists()) {
+ logger.warn("Logging not initialized!");
Review Comment:
Yes, and I'm saying I really dont think we should try to fix it ourselves,
as I did time you tried, because we cant really fix it properly ourselves, and
we cant be sure of the effect doing it will have. Even with what you did it
still has no effect until the next startup even if they dont have alternative
valid config and it isnt interfering with other config.
The JBoss Logging stuff comes in via the scripts hardcoding it, scripts that
also wont have been updated if you dont follow the update instructions. Thats
then picked up when the Java Util Logging stuff in the Artemis class kicks in
and makes it go look for the JBoss LogManager as instructed by the script.
Issue Time Tracking
---
Worklog Id: (was: 815211)
Time Spent: 8h 40m (was: 8.5h)
> switch to using SLF4J for logging API and use Log4j 2 for broker distribution
> -
>
> Key: ARTEMIS-4020
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4020
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
>Priority: Major
> Fix For: 2.27.0
>
> Time Spent: 8h 40m
> Remaining Estimate: 0h
>
> Switch to
[jira] [Work logged] (ARTEMIS-4020) switch to using SLF4J for logging API and use Log4j 2 for broker distribution
[
https://issues.apache.org/jira/browse/ARTEMIS-4020?focusedWorklogId=815208=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-815208
]
ASF GitHub Bot logged work on ARTEMIS-4020:
---
Author: ASF GitHub Bot
Created on: 10/Oct/22 13:31
Start Date: 10/Oct/22 13:31
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4246:
URL: https://github.com/apache/activemq-artemis/pull/4246#discussion_r991291616
##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/InitLogging.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.cli.commands.tools;
+
+import java.io.File;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.lang.invoke.MethodHandles;
+import java.util.Collections;
+
+import io.airlift.airline.Command;
+import io.airlift.airline.Option;
+import org.apache.activemq.artemis.cli.commands.ActionAbstract;
+import org.apache.activemq.artemis.cli.commands.ActionContext;
+import org.apache.activemq.artemis.cli.commands.Create;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Command(name = "init-logging", description = "Initialize a default log4j
configuration")
+public class InitLogging extends ActionAbstract {
+
+ private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ public static final String OLD_LOG_NAME = "logging.properties";
+
+ @Option(name = "--force", description = "Overwrite configuration at
destination directory")
+ private boolean force;
+
+ @Override
+ public Object execute(ActionContext context) throws Exception {
+ super.execute(context);
+
+ initLogging(force, new File(getBrokerInstance()));
+
+ return null;
+ }
+
+
+ public static void initLogging(boolean force, File brokerInstance) throws
Exception {
+ File etc = new File(brokerInstance, "etc");
+ File newLogging = new File(etc, Create.ETC_LOG4J2_PROPERTIES);
+
+ if (!force && newLogging.exists()) {
+ System.err.println("A configuration file " +
newLogging.getAbsolutePath() + " already exists! Use the option -f if you want
to re-initialize it");
+ return;
+ }
+
+ Create.write("etc/" + Create.ETC_LOG4J2_PROPERTIES, newLogging,
Collections.emptyMap(), false, force, "utf-8");
+ }
+
+ public static void verifyOlderLogging(File fileInstance) throws Exception {
+ File etc = new File(fileInstance, "etc");
+ File newLogging = new File(etc, Create.ETC_LOG4J2_PROPERTIES);
+ File oldLogging = new File(etc, OLD_LOG_NAME);
+
+ if (oldLogging.exists() && !newLogging.exists()) {
+ logger.warn("Logging not initialized!");
Review Comment:
Yes, and I'm saying I really dont think we should try to fix it ourselves,
as I did time you tried, because we cant really fix it properly ourselves, and
we cant be sure of the effect doing it will have. Even with what you did it
still has no effect until the next startup even if they dont have alternative
valid config and it isnt interfering with other config.
The JBossLogging stuff comes in via the scripts hardcoding it, scripts that
also wont have been updated if you dont follow the update instructions.
Issue Time Tracking
---
Worklog Id: (was: 815208)
Time Spent: 8.5h (was: 8h 20m)
> switch to using SLF4J for logging API and use Log4j 2 for broker distribution
> -
>
> Key: ARTEMIS-4020
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4020
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
>Priority: Major
> Fix For: 2.27.0
>
> Time Spent: 8.5h
> Remaining Estimate: 0h
>
> Switch to using [SLF4J|https://www.slf4j.org/] as the logging API for the
> code base, with end-uses supplying and configuring an SLF4J-supporting
> logging implementation
[jira] [Work logged] (ARTEMIS-4020) switch to using SLF4J for logging API and use Log4j 2 for broker distribution
[
https://issues.apache.org/jira/browse/ARTEMIS-4020?focusedWorklogId=815201=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-815201
]
ASF GitHub Bot logged work on ARTEMIS-4020:
---
Author: ASF GitHub Bot
Created on: 10/Oct/22 13:13
Start Date: 10/Oct/22 13:13
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4246:
URL: https://github.com/apache/activemq-artemis/pull/4246#discussion_r991274636
##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/InitLogging.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.cli.commands.tools;
+
+import java.io.File;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.lang.invoke.MethodHandles;
+import java.util.Collections;
+
+import io.airlift.airline.Command;
+import io.airlift.airline.Option;
+import org.apache.activemq.artemis.cli.commands.ActionAbstract;
+import org.apache.activemq.artemis.cli.commands.ActionContext;
+import org.apache.activemq.artemis.cli.commands.Create;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Command(name = "init-logging", description = "Initialize a default log4j
configuration")
+public class InitLogging extends ActionAbstract {
+
+ private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ public static final String OLD_LOG_NAME = "logging.properties";
+
+ @Option(name = "--force", description = "Overwrite configuration at
destination directory")
+ private boolean force;
+
+ @Override
+ public Object execute(ActionContext context) throws Exception {
+ super.execute(context);
+
+ initLogging(force, new File(getBrokerInstance()));
+
+ return null;
+ }
+
+
+ public static void initLogging(boolean force, File brokerInstance) throws
Exception {
+ File etc = new File(brokerInstance, "etc");
+ File newLogging = new File(etc, Create.ETC_LOG4J2_PROPERTIES);
+
+ if (!force && newLogging.exists()) {
+ System.err.println("A configuration file " +
newLogging.getAbsolutePath() + " already exists! Use the option -f if you want
to re-initialize it");
+ return;
+ }
+
+ Create.write("etc/" + Create.ETC_LOG4J2_PROPERTIES, newLogging,
Collections.emptyMap(), false, force, "utf-8");
+ }
+
+ public static void verifyOlderLogging(File fileInstance) throws Exception {
+ File etc = new File(fileInstance, "etc");
+ File newLogging = new File(etc, Create.ETC_LOG4J2_PROPERTIES);
+ File oldLogging = new File(etc, OLD_LOG_NAME);
+
+ if (oldLogging.exists() && !newLogging.exists()) {
+ logger.warn("Logging not initialized!");
Review Comment:
Instead of telling the user call init-logger to fix it.. I'm just fixing
itself with a System.out.
I will check why it's calling the warning twice.. and where the Jboss
Logging is leaking into this.
Issue Time Tracking
---
Worklog Id: (was: 815201)
Time Spent: 8h 20m (was: 8h 10m)
> switch to using SLF4J for logging API and use Log4j 2 for broker distribution
> -
>
> Key: ARTEMIS-4020
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4020
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
>Priority: Major
> Fix For: 2.27.0
>
> Time Spent: 8h 20m
> Remaining Estimate: 0h
>
> Switch to using [SLF4J|https://www.slf4j.org/] as the logging API for the
> code base, with end-uses supplying and configuring an SLF4J-supporting
> logging implementation of their choice based on their needs.
> For the client, applications will need to supply an SLF4J binding to a
> logging implementation of their choice to enable logging. An example of doing
> so using [Log4J 2|https://logging.apache.org/log4j/2.x/manual/index.html] is
> given in (/will be, once the
[jira] [Work logged] (ARTEMIS-4020) switch to using SLF4J for logging API and use Log4j 2 for broker distribution
[
https://issues.apache.org/jira/browse/ARTEMIS-4020?focusedWorklogId=815198=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-815198
]
ASF GitHub Bot logged work on ARTEMIS-4020:
---
Author: ASF GitHub Bot
Created on: 10/Oct/22 13:11
Start Date: 10/Oct/22 13:11
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4246:
URL: https://github.com/apache/activemq-artemis/pull/4246#discussion_r991272362
##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/InitLogging.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.cli.commands.tools;
+
+import java.io.File;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.lang.invoke.MethodHandles;
+import java.util.Collections;
+
+import io.airlift.airline.Command;
+import io.airlift.airline.Option;
+import org.apache.activemq.artemis.cli.commands.ActionAbstract;
+import org.apache.activemq.artemis.cli.commands.ActionContext;
+import org.apache.activemq.artemis.cli.commands.Create;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Command(name = "init-logging", description = "Initialize a default log4j
configuration")
+public class InitLogging extends ActionAbstract {
+
+ private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ public static final String OLD_LOG_NAME = "logging.properties";
+
+ @Option(name = "--force", description = "Overwrite configuration at
destination directory")
+ private boolean force;
+
+ @Override
+ public Object execute(ActionContext context) throws Exception {
+ super.execute(context);
+
+ initLogging(force, new File(getBrokerInstance()));
+
+ return null;
+ }
+
+
+ public static void initLogging(boolean force, File brokerInstance) throws
Exception {
+ File etc = new File(brokerInstance, "etc");
+ File newLogging = new File(etc, Create.ETC_LOG4J2_PROPERTIES);
+
+ if (!force && newLogging.exists()) {
+ System.err.println("A configuration file " +
newLogging.getAbsolutePath() + " already exists! Use the option -f if you want
to re-initialize it");
+ return;
+ }
+
+ Create.write("etc/" + Create.ETC_LOG4J2_PROPERTIES, newLogging,
Collections.emptyMap(), false, force, "utf-8");
+ }
+
+ public static void verifyOlderLogging(File fileInstance) throws Exception {
+ File etc = new File(fileInstance, "etc");
+ File newLogging = new File(etc, Create.ETC_LOG4J2_PROPERTIES);
+ File oldLogging = new File(etc, OLD_LOG_NAME);
+
+ if (oldLogging.exists() && !newLogging.exists()) {
+ logger.warn("Logging not initialized!");
Review Comment:
It is calling logger.warn, and System.out
Issue Time Tracking
---
Worklog Id: (was: 815198)
Time Spent: 8h 10m (was: 8h)
> switch to using SLF4J for logging API and use Log4j 2 for broker distribution
> -
>
> Key: ARTEMIS-4020
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4020
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
>Priority: Major
> Fix For: 2.27.0
>
> Time Spent: 8h 10m
> Remaining Estimate: 0h
>
> Switch to using [SLF4J|https://www.slf4j.org/] as the logging API for the
> code base, with end-uses supplying and configuring an SLF4J-supporting
> logging implementation of their choice based on their needs.
> For the client, applications will need to supply an SLF4J binding to a
> logging implementation of their choice to enable logging. An example of doing
> so using [Log4J 2|https://logging.apache.org/log4j/2.x/manual/index.html] is
> given in (/will be, once the release is out) the [client logging
> documentation|https://activemq.apache.org/components/artemis/documentation/latest/logging.html#logging-in-a-client-application].
> For
[jira] [Work logged] (ARTEMIS-4020) switch to using SLF4J for logging API and use Log4j 2 for broker distribution
[
https://issues.apache.org/jira/browse/ARTEMIS-4020?focusedWorklogId=815187=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-815187
]
ASF GitHub Bot logged work on ARTEMIS-4020:
---
Author: ASF GitHub Bot
Created on: 10/Oct/22 12:46
Start Date: 10/Oct/22 12:46
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4246:
URL: https://github.com/apache/activemq-artemis/pull/4246#discussion_r991249012
##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/InitLogging.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.cli.commands.tools;
+
+import java.io.File;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.lang.invoke.MethodHandles;
+import java.util.Collections;
+
+import io.airlift.airline.Command;
+import io.airlift.airline.Option;
+import org.apache.activemq.artemis.cli.commands.ActionAbstract;
+import org.apache.activemq.artemis.cli.commands.ActionContext;
+import org.apache.activemq.artemis.cli.commands.Create;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Command(name = "init-logging", description = "Initialize a default log4j
configuration")
+public class InitLogging extends ActionAbstract {
+
+ private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ public static final String OLD_LOG_NAME = "logging.properties";
+
+ @Option(name = "--force", description = "Overwrite configuration at
destination directory")
+ private boolean force;
+
+ @Override
+ public Object execute(ActionContext context) throws Exception {
+ super.execute(context);
+
+ initLogging(force, new File(getBrokerInstance()));
+
+ return null;
+ }
+
+
+ public static void initLogging(boolean force, File brokerInstance) throws
Exception {
+ File etc = new File(brokerInstance, "etc");
+ File newLogging = new File(etc, Create.ETC_LOG4J2_PROPERTIES);
+
+ if (!force && newLogging.exists()) {
+ System.err.println("A configuration file " +
newLogging.getAbsolutePath() + " already exists! Use the option -f if you want
to re-initialize it");
+ return;
+ }
+
+ Create.write("etc/" + Create.ETC_LOG4J2_PROPERTIES, newLogging,
Collections.emptyMap(), false, force, "utf-8");
+ }
+
+ public static void verifyOlderLogging(File fileInstance) throws Exception {
+ File etc = new File(fileInstance, "etc");
+ File newLogging = new File(etc, Create.ETC_LOG4J2_PROPERTIES);
+ File oldLogging = new File(etc, OLD_LOG_NAME);
+
+ if (oldLogging.exists() && !newLogging.exists()) {
+ logger.warn("Logging not initialized!");
+ StringWriter out= new StringWriter();
+ PrintWriter writer = new PrintWriter(out);
+ writer.println("It seems you are migrating a previous version of an
artemis instance without the new log4j configuration");
+ writer.println();
+ writer.printf("A new logging configuration is being created at %s",
newLogging.getAbsolutePath());
+ writer.println();
+ writer.printf("The older configuration file %s should be manually
removed.", oldLogging.getAbsolutePath());
+ ActionContext.system().out.println(out);
+
+ initLogging(false, fileInstance);
+ }
Review Comment:
Which makes me realise that the Artemis class is using a JUL logger directly
to cause that.
Issue Time Tracking
---
Worklog Id: (was: 815187)
Time Spent: 8h (was: 7h 50m)
> switch to using SLF4J for logging API and use Log4j 2 for broker distribution
> -
>
> Key: ARTEMIS-4020
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4020
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
>Priority: Major
> Fix For: 2.27.0
>
> Time Spent: 8h
>
[jira] [Work logged] (ARTEMIS-4020) switch to using SLF4J for logging API and use Log4j 2 for broker distribution
[
https://issues.apache.org/jira/browse/ARTEMIS-4020?focusedWorklogId=815183=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-815183
]
ASF GitHub Bot logged work on ARTEMIS-4020:
---
Author: ASF GitHub Bot
Created on: 10/Oct/22 12:39
Start Date: 10/Oct/22 12:39
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4246:
URL: https://github.com/apache/activemq-artemis/pull/4246#discussion_r991242486
##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/InitLogging.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.cli.commands.tools;
+
+import java.io.File;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.lang.invoke.MethodHandles;
+import java.util.Collections;
+
+import io.airlift.airline.Command;
+import io.airlift.airline.Option;
+import org.apache.activemq.artemis.cli.commands.ActionAbstract;
+import org.apache.activemq.artemis.cli.commands.ActionContext;
+import org.apache.activemq.artemis.cli.commands.Create;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Command(name = "init-logging", description = "Initialize a default log4j
configuration")
+public class InitLogging extends ActionAbstract {
+
+ private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ public static final String OLD_LOG_NAME = "logging.properties";
+
+ @Option(name = "--force", description = "Overwrite configuration at
destination directory")
+ private boolean force;
+
+ @Override
+ public Object execute(ActionContext context) throws Exception {
+ super.execute(context);
+
+ initLogging(force, new File(getBrokerInstance()));
+
+ return null;
+ }
+
+
+ public static void initLogging(boolean force, File brokerInstance) throws
Exception {
+ File etc = new File(brokerInstance, "etc");
+ File newLogging = new File(etc, Create.ETC_LOG4J2_PROPERTIES);
+
+ if (!force && newLogging.exists()) {
+ System.err.println("A configuration file " +
newLogging.getAbsolutePath() + " already exists! Use the option -f if you want
to re-initialize it");
+ return;
+ }
+
+ Create.write("etc/" + Create.ETC_LOG4J2_PROPERTIES, newLogging,
Collections.emptyMap(), false, force, "utf-8");
+ }
+
+ public static void verifyOlderLogging(File fileInstance) throws Exception {
+ File etc = new File(fileInstance, "etc");
+ File newLogging = new File(etc, Create.ETC_LOG4J2_PROPERTIES);
+ File oldLogging = new File(etc, OLD_LOG_NAME);
+
+ if (oldLogging.exists() && !newLogging.exists()) {
+ logger.warn("Logging not initialized!");
+ StringWriter out= new StringWriter();
+ PrintWriter writer = new PrintWriter(out);
+ writer.println("It seems you are migrating a previous version of an
artemis instance without the new log4j configuration");
+ writer.println();
+ writer.printf("A new logging configuration is being created at %s",
newLogging.getAbsolutePath());
+ writer.println();
+ writer.printf("The older configuration file %s should be manually
removed.", oldLogging.getAbsolutePath());
+ ActionContext.system().out.println(out);
+
+ initLogging(false, fileInstance);
+ }
Review Comment:
On trying this as-is I notice it prints out 2 different 'old config should
be removed' style instructions twice in succession, and also interferes with
the first line of the 'Artemis' asciiart, presumably by not having a newline at
the end of the second one.
It then also has no effect on the first startup since the log4j2.properties
file is created too late to have an effect, meaning you have to restart the
broker anyway.
Someone trying an upgrade like this without actually e.g looking at the
script and config changes noted in the upgrade guide, is actually more likely
to stop and look due to lasck of regularly verbose startup output, and also the
big ClassNotFoundException stacktrace that comes
[jira] [Work logged] (ARTEMIS-4020) switch to using SLF4J for logging API and use Log4j 2 for broker distribution
[
https://issues.apache.org/jira/browse/ARTEMIS-4020?focusedWorklogId=815175=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-815175
]
ASF GitHub Bot logged work on ARTEMIS-4020:
---
Author: ASF GitHub Bot
Created on: 10/Oct/22 12:08
Start Date: 10/Oct/22 12:08
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4246:
URL: https://github.com/apache/activemq-artemis/pull/4246#discussion_r991209180
##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/InitLogging.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.cli.commands.tools;
+
+import java.io.File;
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.lang.invoke.MethodHandles;
+import java.util.Collections;
+
+import io.airlift.airline.Command;
+import io.airlift.airline.Option;
+import org.apache.activemq.artemis.cli.commands.ActionAbstract;
+import org.apache.activemq.artemis.cli.commands.ActionContext;
+import org.apache.activemq.artemis.cli.commands.Create;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Command(name = "init-logging", description = "Initialize a default log4j
configuration")
+public class InitLogging extends ActionAbstract {
+
+ private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ public static final String OLD_LOG_NAME = "logging.properties";
+
+ @Option(name = "--force", description = "Overwrite configuration at
destination directory")
+ private boolean force;
+
+ @Override
+ public Object execute(ActionContext context) throws Exception {
+ super.execute(context);
+
+ initLogging(force, new File(getBrokerInstance()));
+
+ return null;
+ }
+
+
+ public static void initLogging(boolean force, File brokerInstance) throws
Exception {
+ File etc = new File(brokerInstance, "etc");
+ File newLogging = new File(etc, Create.ETC_LOG4J2_PROPERTIES);
+
+ if (!force && newLogging.exists()) {
+ System.err.println("A configuration file " +
newLogging.getAbsolutePath() + " already exists! Use the option -f if you want
to re-initialize it");
+ return;
+ }
+
+ Create.write("etc/" + Create.ETC_LOG4J2_PROPERTIES, newLogging,
Collections.emptyMap(), false, force, "utf-8");
+ }
+
+ public static void verifyOlderLogging(File fileInstance) throws Exception {
+ File etc = new File(fileInstance, "etc");
+ File newLogging = new File(etc, Create.ETC_LOG4J2_PROPERTIES);
+ File oldLogging = new File(etc, OLD_LOG_NAME);
+
+ if (oldLogging.exists() && !newLogging.exists()) {
+ logger.warn("Logging not initialized!");
Review Comment:
Using logging to warn about logging doesnt necessarily make sense. In
particular it will probably do nothing if there is no config, as the default is
Error, and if there is configuration via one of the many other valid routes
this doesnt consider, it will then log this incorrectly.
##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/InitLogging.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.cli.commands.tools;
+
+import java.io.File;
+import java.io.PrintWriter;
+import
[jira] [Commented] (ARTEMIS-4020) switch to using SLF4J for logging API and use Log4j 2 for broker distribution
[ https://issues.apache.org/jira/browse/ARTEMIS-4020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17614978#comment-17614978 ] ASF subversion and git services commented on ARTEMIS-4020: -- Commit 7b3c185bba90fa50a7b78c1ac2534fe43dd41927 in activemq-artemis's branch refs/heads/main from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=7b3c185bba ] ARTEMIS-4020: restore some gates I had stashed changes to undo removals for > switch to using SLF4J for logging API and use Log4j 2 for broker distribution > - > > Key: ARTEMIS-4020 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4020 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: 2.27.0 > > Time Spent: 7.5h > Remaining Estimate: 0h > > Switch to using [SLF4J|https://www.slf4j.org/] as the logging API for the > code base, with end-uses supplying and configuring an SLF4J-supporting > logging implementation of their choice based on their needs. > For the client, applications will need to supply an SLF4J binding to a > logging implementation of their choice to enable logging. An example of doing > so using [Log4J 2|https://logging.apache.org/log4j/2.x/manual/index.html] is > given in (/will be, once the release is out) the [client logging > documentation|https://activemq.apache.org/components/artemis/documentation/latest/logging.html#logging-in-a-client-application]. > For the broker, the assembly distribution will include [Log4J > 2|https://logging.apache.org/log4j/2.x/manual/index.html] as its logging > implentation, with the "artemis create" CLI command used to create broker > instances now creating a log4j2.properties configuration within the > /etc/ directory to configure Log4J. Details for upgrading an > existing broker-instance is given in (/will be, once the release is out) the > [version upgrade > documentation|https://activemq.apache.org/components/artemis/documentation/latest/versions.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4020) switch to using SLF4J for logging API and use Log4j 2 for broker distribution
[ https://issues.apache.org/jira/browse/ARTEMIS-4020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17614945#comment-17614945 ] ASF subversion and git services commented on ARTEMIS-4020: -- Commit 617269319a7e6cbe98ae981743d2af24632e730c in activemq-artemis's branch refs/heads/main from Timothy Bish [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=617269319a ] ARTEMIS-4020: Remove string appends and various isXEnabled logger checks (add some where useful) Logger statements should use formatting syntax and let the normal framework checks take care of checking if a logger is enabled instead of string concats and isXEnabled logger checks except in cases there is known expense to the specifc logging message/arg preparation or passing. Changes from myself and Robbie Gemmell. Co-authored-by: Robbie Gemmell > switch to using SLF4J for logging API and use Log4j 2 for broker distribution > - > > Key: ARTEMIS-4020 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4020 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: 2.27.0 > > Time Spent: 7h 20m > Remaining Estimate: 0h > > Switch to using [SLF4J|https://www.slf4j.org/] as the logging API for the > code base, with end-uses supplying and configuring an SLF4J-supporting > logging implementation of their choice based on their needs. > For the client, applications will need to supply an SLF4J binding to a > logging implementation of their choice to enable logging. An example of doing > so using [Log4J 2|https://logging.apache.org/log4j/2.x/manual/index.html] is > given in (/will be, once the release is out) the [client logging > documentation|https://activemq.apache.org/components/artemis/documentation/latest/logging.html#logging-in-a-client-application]. > For the broker, the assembly distribution will include [Log4J > 2|https://logging.apache.org/log4j/2.x/manual/index.html] as its logging > implentation, with the "artemis create" CLI command used to create broker > instances now creating a log4j2.properties configuration within the > /etc/ directory to configure Log4J. Details for upgrading an > existing broker-instance is given in (/will be, once the release is out) the > [version upgrade > documentation|https://activemq.apache.org/components/artemis/documentation/latest/versions.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4020) switch to using SLF4J for logging API and use Log4j 2 for broker distribution
[ https://issues.apache.org/jira/browse/ARTEMIS-4020?focusedWorklogId=815115=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-815115 ] ASF GitHub Bot logged work on ARTEMIS-4020: --- Author: ASF GitHub Bot Created on: 10/Oct/22 07:55 Start Date: 10/Oct/22 07:55 Worklog Time Spent: 10m Work Description: asfgit merged PR #4247: URL: https://github.com/apache/activemq-artemis/pull/4247 Issue Time Tracking --- Worklog Id: (was: 815115) Time Spent: 7.5h (was: 7h 20m) > switch to using SLF4J for logging API and use Log4j 2 for broker distribution > - > > Key: ARTEMIS-4020 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4020 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: 2.27.0 > > Time Spent: 7.5h > Remaining Estimate: 0h > > Switch to using [SLF4J|https://www.slf4j.org/] as the logging API for the > code base, with end-uses supplying and configuring an SLF4J-supporting > logging implementation of their choice based on their needs. > For the client, applications will need to supply an SLF4J binding to a > logging implementation of their choice to enable logging. An example of doing > so using [Log4J 2|https://logging.apache.org/log4j/2.x/manual/index.html] is > given in (/will be, once the release is out) the [client logging > documentation|https://activemq.apache.org/components/artemis/documentation/latest/logging.html#logging-in-a-client-application]. > For the broker, the assembly distribution will include [Log4J > 2|https://logging.apache.org/log4j/2.x/manual/index.html] as its logging > implentation, with the "artemis create" CLI command used to create broker > instances now creating a log4j2.properties configuration within the > /etc/ directory to configure Log4J. Details for upgrading an > existing broker-instance is given in (/will be, once the release is out) the > [version upgrade > documentation|https://activemq.apache.org/components/artemis/documentation/latest/versions.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
