[jira] [Work logged] (ARTEMIS-4081) Upgrade command
[ https://issues.apache.org/jira/browse/ARTEMIS-4081?focusedWorklogId=822901=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822901 ] ASF GitHub Bot logged work on ARTEMIS-4081: --- Author: ASF GitHub Bot Created on: 03/Nov/22 00:32 Start Date: 03/Nov/22 00:32 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4246: URL: https://github.com/apache/activemq-artemis/pull/4246#issuecomment-1301521759 I'm finishing the tests... right now it's failing.. I will have some minor adjustments to do tomorrow.. but this is almost done. Issue Time Tracking --- Worklog Id: (was: 822901) Remaining Estimate: 0h Time Spent: 10m > Upgrade command > --- > > Key: ARTEMIS-4081 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4081 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.27.0 > > Time Spent: 10m > Remaining Estimate: 0h > > We should add a command to upgrade an instance from an older broker. > ./artemis upgrade should update the required scripts and files > to reflect a new broker home. > The touched files should be backed up for easy recovering in case of failure > and also for the user to compare eventual configuration they might have done > on scripts. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARTEMIS-4081) Upgrade command
Clebert Suconic created ARTEMIS-4081: Summary: Upgrade command Key: ARTEMIS-4081 URL: https://issues.apache.org/jira/browse/ARTEMIS-4081 Project: ActiveMQ Artemis Issue Type: Improvement Reporter: Clebert Suconic Assignee: Clebert Suconic Fix For: 2.27.0 We should add a command to upgrade an instance from an older broker. ./artemis upgrade should update the required scripts and files to reflect a new broker home. The touched files should be backed up for easy recovering in case of failure and also for the user to compare eventual configuration they might have done on scripts. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4020) switch to using SLF4J for logging API and use Log4j 2 for broker distribution
[ https://issues.apache.org/jira/browse/ARTEMIS-4020?focusedWorklogId=822812=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822812 ] ASF GitHub Bot logged work on ARTEMIS-4020: --- Author: ASF GitHub Bot Created on: 02/Nov/22 19:06 Start Date: 02/Nov/22 19:06 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #4277: URL: https://github.com/apache/activemq-artemis/pull/4277 Issue Time Tracking --- Worklog Id: (was: 822812) Time Spent: 18h (was: 17h 50m) > switch to using SLF4J for logging API and use Log4j 2 for broker distribution > - > > Key: ARTEMIS-4020 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4020 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: 2.27.0 > > Time Spent: 18h > Remaining Estimate: 0h > > Switch to using [SLF4J|https://www.slf4j.org/] as the logging API for the > code base, with end-uses supplying and configuring an SLF4J-supporting > logging implementation of their choice based on their needs. > For the client, applications will need to supply an SLF4J binding to a > logging implementation of their choice to enable logging. An example of doing > so using [Log4J 2|https://logging.apache.org/log4j/2.x/manual/index.html] is > given in (/will be, once the release is out) the [client logging > documentation|https://activemq.apache.org/components/artemis/documentation/latest/logging.html#logging-in-a-client-application]. > For the broker, the assembly distribution will include [Log4J > 2|https://logging.apache.org/log4j/2.x/manual/index.html] as its logging > implentation, with the "artemis create" CLI command used to create broker > instances now creating a log4j2.properties configuration within the > /etc/ directory to configure Log4J. Details for upgrading an > existing broker-instance is given in (/will be, once the release is out) the > [version upgrade > documentation|https://activemq.apache.org/components/artemis/documentation/latest/versions.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4020) switch to using SLF4J for logging API and use Log4j 2 for broker distribution
[ https://issues.apache.org/jira/browse/ARTEMIS-4020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627908#comment-17627908 ] ASF subversion and git services commented on ARTEMIS-4020: -- Commit db1338af5227fc016cf4ab37b2230a837f863688 in activemq-artemis's branch refs/heads/main from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=db1338af52 ] ARTEMIS-4020 Fixing Management DTO Parsing with custom ETC This is fixing an issue introduced by the logging changes where a custome ETC would not work correctly. > switch to using SLF4J for logging API and use Log4j 2 for broker distribution > - > > Key: ARTEMIS-4020 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4020 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: 2.27.0 > > Time Spent: 18h > Remaining Estimate: 0h > > Switch to using [SLF4J|https://www.slf4j.org/] as the logging API for the > code base, with end-uses supplying and configuring an SLF4J-supporting > logging implementation of their choice based on their needs. > For the client, applications will need to supply an SLF4J binding to a > logging implementation of their choice to enable logging. An example of doing > so using [Log4J 2|https://logging.apache.org/log4j/2.x/manual/index.html] is > given in (/will be, once the release is out) the [client logging > documentation|https://activemq.apache.org/components/artemis/documentation/latest/logging.html#logging-in-a-client-application]. > For the broker, the assembly distribution will include [Log4J > 2|https://logging.apache.org/log4j/2.x/manual/index.html] as its logging > implentation, with the "artemis create" CLI command used to create broker > instances now creating a log4j2.properties configuration within the > /etc/ directory to configure Log4J. Details for upgrading an > existing broker-instance is given in (/will be, once the release is out) the > [version upgrade > documentation|https://activemq.apache.org/components/artemis/documentation/latest/versions.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4020) switch to using SLF4J for logging API and use Log4j 2 for broker distribution
[
https://issues.apache.org/jira/browse/ARTEMIS-4020?focusedWorklogId=822786=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822786
]
ASF GitHub Bot logged work on ARTEMIS-4020:
---
Author: ASF GitHub Bot
Created on: 02/Nov/22 16:36
Start Date: 02/Nov/22 16:36
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4277:
URL: https://github.com/apache/activemq-artemis/pull/4277#discussion_r1012033973
##
tests/smoke-tests/pom.xml:
##
@@ -1197,6 +1197,24 @@
${basedir}/target/classes/servers/nettynative
+
+
+
+ test-compile
+ create-custom-eTC
Review Comment:
thanks :)
Issue Time Tracking
---
Worklog Id: (was: 822786)
Time Spent: 17h 50m (was: 17h 40m)
> switch to using SLF4J for logging API and use Log4j 2 for broker distribution
> -
>
> Key: ARTEMIS-4020
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4020
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
>Priority: Major
> Fix For: 2.27.0
>
> Time Spent: 17h 50m
> Remaining Estimate: 0h
>
> Switch to using [SLF4J|https://www.slf4j.org/] as the logging API for the
> code base, with end-uses supplying and configuring an SLF4J-supporting
> logging implementation of their choice based on their needs.
> For the client, applications will need to supply an SLF4J binding to a
> logging implementation of their choice to enable logging. An example of doing
> so using [Log4J 2|https://logging.apache.org/log4j/2.x/manual/index.html] is
> given in (/will be, once the release is out) the [client logging
> documentation|https://activemq.apache.org/components/artemis/documentation/latest/logging.html#logging-in-a-client-application].
> For the broker, the assembly distribution will include [Log4J
> 2|https://logging.apache.org/log4j/2.x/manual/index.html] as its logging
> implentation, with the "artemis create" CLI command used to create broker
> instances now creating a log4j2.properties configuration within the
> /etc/ directory to configure Log4J. Details for upgrading an
> existing broker-instance is given in (/will be, once the release is out) the
> [version upgrade
> documentation|https://activemq.apache.org/components/artemis/documentation/latest/versions.html].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4020) switch to using SLF4J for logging API and use Log4j 2 for broker distribution
[
https://issues.apache.org/jira/browse/ARTEMIS-4020?focusedWorklogId=822785=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822785
]
ASF GitHub Bot logged work on ARTEMIS-4020:
---
Author: ASF GitHub Bot
Created on: 02/Nov/22 16:34
Start Date: 02/Nov/22 16:34
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4277:
URL: https://github.com/apache/activemq-artemis/pull/4277#discussion_r1012030236
##
tests/smoke-tests/pom.xml:
##
@@ -1197,6 +1197,24 @@
${basedir}/target/classes/servers/nettynative
+
+
+
+ test-compile
+ create-custom-eTC
Review Comment:
ETC or etc?
Issue Time Tracking
---
Worklog Id: (was: 822785)
Time Spent: 17h 40m (was: 17.5h)
> switch to using SLF4J for logging API and use Log4j 2 for broker distribution
> -
>
> Key: ARTEMIS-4020
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4020
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Robbie Gemmell
>Assignee: Robbie Gemmell
>Priority: Major
> Fix For: 2.27.0
>
> Time Spent: 17h 40m
> Remaining Estimate: 0h
>
> Switch to using [SLF4J|https://www.slf4j.org/] as the logging API for the
> code base, with end-uses supplying and configuring an SLF4J-supporting
> logging implementation of their choice based on their needs.
> For the client, applications will need to supply an SLF4J binding to a
> logging implementation of their choice to enable logging. An example of doing
> so using [Log4J 2|https://logging.apache.org/log4j/2.x/manual/index.html] is
> given in (/will be, once the release is out) the [client logging
> documentation|https://activemq.apache.org/components/artemis/documentation/latest/logging.html#logging-in-a-client-application].
> For the broker, the assembly distribution will include [Log4J
> 2|https://logging.apache.org/log4j/2.x/manual/index.html] as its logging
> implentation, with the "artemis create" CLI command used to create broker
> instances now creating a log4j2.properties configuration within the
> /etc/ directory to configure Log4J. Details for upgrading an
> existing broker-instance is given in (/will be, once the release is out) the
> [version upgrade
> documentation|https://activemq.apache.org/components/artemis/documentation/latest/versions.html].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4071) Erroneus audit log messages due to console logouts
[
https://issues.apache.org/jira/browse/ARTEMIS-4071?focusedWorklogId=822747=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822747
]
ASF GitHub Bot logged work on ARTEMIS-4071:
---
Author: ASF GitHub Bot
Created on: 02/Nov/22 15:14
Start Date: 02/Nov/22 15:14
Worklog Time Spent: 10m
Work Description: brusdev commented on PR #4270:
URL:
https://github.com/apache/activemq-artemis/pull/4270#issuecomment-1300645284
@clebertsuconic adding a test would be very hard, I tested it manually
Issue Time Tracking
---
Worklog Id: (was: 822747)
Time Spent: 1h (was: 50m)
> Erroneus audit log messages due to console logouts
> --
>
> Key: ARTEMIS-4071
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4071
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Domenico Francesco Bruscino
>Assignee: Domenico Francesco Bruscino
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> After enabling audit logging the broker logs following messages in the audit
> log each time a user logs out of Artemis Web Console:
> {code}
> 2022-09-28 09:20:59,274 [AUDIT](qtp936931778-47) AMQ601716: User
> quickuser(amq)@192.168.1.100:51044 failed authentication, reason: 304
> 2022-09-28 09:20:59,294 [AUDIT](qtp936931778-47) AMQ601716: User
> quickuser(amq)@192.168.1.100:51044 failed authentication, reason: 304
> 2022-09-28 09:20:59,326 [AUDIT](qtp936931778-47) AMQ601716: User
> quickuser(amq)@192.168.1.100:51050 failed authentication, reason: 304
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4071) Erroneus audit log messages due to console logouts
[
https://issues.apache.org/jira/browse/ARTEMIS-4071?focusedWorklogId=822746=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822746
]
ASF GitHub Bot logged work on ARTEMIS-4071:
---
Author: ASF GitHub Bot
Created on: 02/Nov/22 15:13
Start Date: 02/Nov/22 15:13
Worklog Time Spent: 10m
Work Description: brusdev commented on code in PR #4270:
URL: https://github.com/apache/activemq-artemis/pull/4270#discussion_r1011917616
##
artemis-web/src/main/java/org/apache/activemq/artemis/component/AuthenticationFilter.java:
##
@@ -43,14 +43,21 @@ public void doFilter(ServletRequest servletRequest,
ServletResponse servletRespo
filterChain.doFilter(servletRequest, servletResponse);
if (AuditLogger.isAnyLoggingEnabled()) {
int status = ((Response) servletResponse).getStatus();
- //status 200 means that the user has been authenticated, anything
else must be a failure
- if (status == 200) {
+ if (status < 300) {
Review Comment:
Status ranges updated
Issue Time Tracking
---
Worklog Id: (was: 822746)
Time Spent: 50m (was: 40m)
> Erroneus audit log messages due to console logouts
> --
>
> Key: ARTEMIS-4071
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4071
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Domenico Francesco Bruscino
>Assignee: Domenico Francesco Bruscino
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> After enabling audit logging the broker logs following messages in the audit
> log each time a user logs out of Artemis Web Console:
> {code}
> 2022-09-28 09:20:59,274 [AUDIT](qtp936931778-47) AMQ601716: User
> quickuser(amq)@192.168.1.100:51044 failed authentication, reason: 304
> 2022-09-28 09:20:59,294 [AUDIT](qtp936931778-47) AMQ601716: User
> quickuser(amq)@192.168.1.100:51044 failed authentication, reason: 304
> 2022-09-28 09:20:59,326 [AUDIT](qtp936931778-47) AMQ601716: User
> quickuser(amq)@192.168.1.100:51050 failed authentication, reason: 304
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4020) switch to using SLF4J for logging API and use Log4j 2 for broker distribution
[ https://issues.apache.org/jira/browse/ARTEMIS-4020?focusedWorklogId=822744=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822744 ] ASF GitHub Bot logged work on ARTEMIS-4020: --- Author: ASF GitHub Bot Created on: 02/Nov/22 15:10 Start Date: 02/Nov/22 15:10 Worklog Time Spent: 10m Work Description: clebertsuconic opened a new pull request, #4277: URL: https://github.com/apache/activemq-artemis/pull/4277 This is fixing an issue introduced by the logging changes where a custome ETC would not work correctly. Issue Time Tracking --- Worklog Id: (was: 822744) Time Spent: 17.5h (was: 17h 20m) > switch to using SLF4J for logging API and use Log4j 2 for broker distribution > - > > Key: ARTEMIS-4020 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4020 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: 2.27.0 > > Time Spent: 17.5h > Remaining Estimate: 0h > > Switch to using [SLF4J|https://www.slf4j.org/] as the logging API for the > code base, with end-uses supplying and configuring an SLF4J-supporting > logging implementation of their choice based on their needs. > For the client, applications will need to supply an SLF4J binding to a > logging implementation of their choice to enable logging. An example of doing > so using [Log4J 2|https://logging.apache.org/log4j/2.x/manual/index.html] is > given in (/will be, once the release is out) the [client logging > documentation|https://activemq.apache.org/components/artemis/documentation/latest/logging.html#logging-in-a-client-application]. > For the broker, the assembly distribution will include [Log4J > 2|https://logging.apache.org/log4j/2.x/manual/index.html] as its logging > implentation, with the "artemis create" CLI command used to create broker > instances now creating a log4j2.properties configuration within the > /etc/ directory to configure Log4J. Details for upgrading an > existing broker-instance is given in (/will be, once the release is out) the > [version upgrade > documentation|https://activemq.apache.org/components/artemis/documentation/latest/versions.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4020) switch to using SLF4J for logging API and use Log4j 2 for broker distribution
[
https://issues.apache.org/jira/browse/ARTEMIS-4020?focusedWorklogId=822699=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822699
]
ASF GitHub Bot logged work on ARTEMIS-4020:
---
Author: ASF GitHub Bot
Created on: 02/Nov/22 14:00
Start Date: 02/Nov/22 14:00
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4246:
URL: https://github.com/apache/activemq-artemis/pull/4246#discussion_r1011811856
##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Upgrade.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.cli.commands;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.io.PrintStream;
+import java.nio.file.Files;
+import java.nio.file.StandardCopyOption;
+import java.util.Iterator;
+import java.util.stream.Stream;
+
+import io.airlift.airline.Command;
+
+@Command(name = "upgrade", description = "Update an artemis instance to the
current artemis.home, keeping all the data and broker.xml. Warning: backup your
instance before using this command and compare the files.")
+public class Upgrade extends InstallAbstract {
+
+ /**
+* Checks that the directory provided either exists and is writable or
doesn't exist but can be created.
+*/
+ protected void checkDirectory() {
+ if (!directory.exists()) {
+ throw new RuntimeException(String.format("Could not find path '%s' to
upgrade.", directory));
+ } else if (!directory.canWrite()) {
+ throw new RuntimeException(String.format("The path '%s' is not
writable.", directory));
+ }
+ }
+
+
+ @Override
+ public Object execute(ActionContext context) throws Exception {
+ this.checkDirectory();
+ super.execute(context);
+
+ return run(context);
+ }
+
+
+ public Object run(ActionContext context) throws Exception {
+ File bkpFolder = findBackup();
+ File bkpBin = new File(bkpFolder, "bin");
+ File etcBkp = new File(bkpFolder, "etc");
+ bkpBin.mkdirs();
+ etcBkp.mkdirs();
+
+ File bin = new File(directory, "bin");
+ File etcFolder = new File(directory, etc);
+
+ if (!bin.exists()) {
+ throw new IOException(bin.getAbsolutePath() + " does not exist");
+ }
+
+
System.out.println("***");
+ System.out.println("Upgrading broker instance " + directory + " to use
artemis.home=" + getBrokerHome());
+
+ upgradeArtemis(bkpBin, bin, etcFolder);
+ upgradeArtemisCmd(bkpBin, bin, etcFolder);
+ upgradeArtemisProfile(etcBkp, etcFolder, directory);
+ upgradeBootstrap(etcBkp, etcFolder, directory);
+ upgradeLogging(etcBkp, etcFolder, directory);
+ System.out.println();
+ System.out.println("Warning: ./artemis upgrade does not bring new
functionality on the script itself from newer artemis versions. Please check
for any differences on artemis script in the current release!");
+
System.out.println("***");
+
+ return null;
+ }
+
+ private void upgradeLogging(File bkpFolder, File etc, File instance) throws
Exception {
+ File oldLogging = new File(etc, "logging.properties");
+
+ if (oldLogging.exists()) {
+ System.out.println("Moving " + oldLogging + " under " + bkpFolder);
+ File oldLoggingCopy = new File(bkpFolder, "logging.properties");
+ Files.copy(oldLogging.toPath(), oldLoggingCopy.toPath(),
StandardCopyOption.REPLACE_EXISTING);
+ oldLogging.delete();
+ File newLogging = new File(etc, Create.ETC_LOG4J2_PROPERTIES);
+
+
+ if (!newLogging.exists()) {
+System.out.println("Creating " + newLogging);
+InputStream inputStream = getClass().getResourceAsStream("etc/" +
[jira] [Work logged] (ARTEMIS-4071) Erroneus audit log messages due to console logouts
[
https://issues.apache.org/jira/browse/ARTEMIS-4071?focusedWorklogId=822686=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822686
]
ASF GitHub Bot logged work on ARTEMIS-4071:
---
Author: ASF GitHub Bot
Created on: 02/Nov/22 13:20
Start Date: 02/Nov/22 13:20
Worklog Time Spent: 10m
Work Description: TheCycoONE commented on code in PR #4270:
URL: https://github.com/apache/activemq-artemis/pull/4270#discussion_r1011736748
##
artemis-web/src/main/java/org/apache/activemq/artemis/component/AuthenticationFilter.java:
##
@@ -43,14 +43,21 @@ public void doFilter(ServletRequest servletRequest,
ServletResponse servletRespo
filterChain.doFilter(servletRequest, servletResponse);
if (AuditLogger.isAnyLoggingEnabled()) {
int status = ((Response) servletResponse).getStatus();
- //status 200 means that the user has been authenticated, anything
else must be a failure
- if (status == 200) {
+ if (status < 300) {
Review Comment:
Does 100 continue need to be handled as well - would that ever reach here? I
think in general I would feel better if < 200 was skipped like 300-399.
Issue Time Tracking
---
Worklog Id: (was: 822686)
Time Spent: 40m (was: 0.5h)
> Erroneus audit log messages due to console logouts
> --
>
> Key: ARTEMIS-4071
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4071
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Domenico Francesco Bruscino
>Assignee: Domenico Francesco Bruscino
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> After enabling audit logging the broker logs following messages in the audit
> log each time a user logs out of Artemis Web Console:
> {code}
> 2022-09-28 09:20:59,274 [AUDIT](qtp936931778-47) AMQ601716: User
> quickuser(amq)@192.168.1.100:51044 failed authentication, reason: 304
> 2022-09-28 09:20:59,294 [AUDIT](qtp936931778-47) AMQ601716: User
> quickuser(amq)@192.168.1.100:51044 failed authentication, reason: 304
> 2022-09-28 09:20:59,326 [AUDIT](qtp936931778-47) AMQ601716: User
> quickuser(amq)@192.168.1.100:51050 failed authentication, reason: 304
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4020) switch to using SLF4J for logging API and use Log4j 2 for broker distribution
[ https://issues.apache.org/jira/browse/ARTEMIS-4020?focusedWorklogId=822685=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822685 ] ASF GitHub Bot logged work on ARTEMIS-4020: --- Author: ASF GitHub Bot Created on: 02/Nov/22 13:16 Start Date: 02/Nov/22 13:16 Worklog Time Spent: 10m Work Description: clebertsuconic closed pull request #4246: ARTEMIS-4020 Upgrade command to help move an instance to a different version URL: https://github.com/apache/activemq-artemis/pull/4246 Issue Time Tracking --- Worklog Id: (was: 822685) Time Spent: 17h 10m (was: 17h) > switch to using SLF4J for logging API and use Log4j 2 for broker distribution > - > > Key: ARTEMIS-4020 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4020 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: 2.27.0 > > Time Spent: 17h 10m > Remaining Estimate: 0h > > Switch to using [SLF4J|https://www.slf4j.org/] as the logging API for the > code base, with end-uses supplying and configuring an SLF4J-supporting > logging implementation of their choice based on their needs. > For the client, applications will need to supply an SLF4J binding to a > logging implementation of their choice to enable logging. An example of doing > so using [Log4J 2|https://logging.apache.org/log4j/2.x/manual/index.html] is > given in (/will be, once the release is out) the [client logging > documentation|https://activemq.apache.org/components/artemis/documentation/latest/logging.html#logging-in-a-client-application]. > For the broker, the assembly distribution will include [Log4J > 2|https://logging.apache.org/log4j/2.x/manual/index.html] as its logging > implentation, with the "artemis create" CLI command used to create broker > instances now creating a log4j2.properties configuration within the > /etc/ directory to configure Log4J. Details for upgrading an > existing broker-instance is given in (/will be, once the release is out) the > [version upgrade > documentation|https://activemq.apache.org/components/artemis/documentation/latest/versions.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4071) Erroneus audit log messages due to console logouts
[
https://issues.apache.org/jira/browse/ARTEMIS-4071?focusedWorklogId=822673=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822673
]
ASF GitHub Bot logged work on ARTEMIS-4071:
---
Author: ASF GitHub Bot
Created on: 02/Nov/22 13:07
Start Date: 02/Nov/22 13:07
Worklog Time Spent: 10m
Work Description: TheCycoONE commented on code in PR #4270:
URL: https://github.com/apache/activemq-artemis/pull/4270#discussion_r1011736748
##
artemis-web/src/main/java/org/apache/activemq/artemis/component/AuthenticationFilter.java:
##
@@ -43,14 +43,21 @@ public void doFilter(ServletRequest servletRequest,
ServletResponse servletRespo
filterChain.doFilter(servletRequest, servletResponse);
if (AuditLogger.isAnyLoggingEnabled()) {
int status = ((Response) servletResponse).getStatus();
- //status 200 means that the user has been authenticated, anything
else must be a failure
- if (status == 200) {
+ if (status < 300) {
Review Comment:
Does 100 continue need to be handled as well - would that ever reach here?
Issue Time Tracking
---
Worklog Id: (was: 822673)
Time Spent: 0.5h (was: 20m)
> Erroneus audit log messages due to console logouts
> --
>
> Key: ARTEMIS-4071
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4071
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Domenico Francesco Bruscino
>Assignee: Domenico Francesco Bruscino
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> After enabling audit logging the broker logs following messages in the audit
> log each time a user logs out of Artemis Web Console:
> {code}
> 2022-09-28 09:20:59,274 [AUDIT](qtp936931778-47) AMQ601716: User
> quickuser(amq)@192.168.1.100:51044 failed authentication, reason: 304
> 2022-09-28 09:20:59,294 [AUDIT](qtp936931778-47) AMQ601716: User
> quickuser(amq)@192.168.1.100:51044 failed authentication, reason: 304
> 2022-09-28 09:20:59,326 [AUDIT](qtp936931778-47) AMQ601716: User
> quickuser(amq)@192.168.1.100:51050 failed authentication, reason: 304
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4020) switch to using SLF4J for logging API and use Log4j 2 for broker distribution
[
https://issues.apache.org/jira/browse/ARTEMIS-4020?focusedWorklogId=822665=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822665
]
ASF GitHub Bot logged work on ARTEMIS-4020:
---
Author: ASF GitHub Bot
Created on: 02/Nov/22 12:51
Start Date: 02/Nov/22 12:51
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4246:
URL: https://github.com/apache/activemq-artemis/pull/4246#discussion_r1011713110
##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Upgrade.java:
##
@@ -0,0 +1,299 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.cli.commands;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.io.PrintStream;
+import java.nio.file.Files;
+import java.nio.file.StandardCopyOption;
+import java.util.Iterator;
+import java.util.stream.Stream;
+
+import io.airlift.airline.Command;
+
+@Command(name = "upgrade", description = "Update an artemis instance to the
current artemis.home, keeping all the data and broker.xml. Warning: backup your
instance before using this command and compare the files.")
+public class Upgrade extends InstallAbstract {
+
+ /**
+* Checks that the directory provided either exists and is writable or
doesn't exist but can be created.
+*/
+ protected void checkDirectory() {
+ if (!directory.exists()) {
+ throw new RuntimeException(String.format("Could not find path '%s' to
upgrade.", directory));
+ } else if (!directory.canWrite()) {
+ throw new RuntimeException(String.format("The path '%s' is not
writable.", directory));
+ }
+ }
+
+
+ @Override
+ public Object execute(ActionContext context) throws Exception {
+ this.checkDirectory();
+ super.execute(context);
+
+ return run(context);
+ }
+
+
+ public Object run(ActionContext context) throws Exception {
+ File bkpFolder = findBackup();
+ File bkpBin = new File(bkpFolder, "bin");
+ File etcBkp = new File(bkpFolder, "etc");
+ bkpBin.mkdirs();
+ etcBkp.mkdirs();
+
+ File bin = new File(directory, "bin");
+ File etcFolder = new File(directory, etc);
+
+ if (!bin.exists()) {
+ throw new IOException(bin.getAbsolutePath() + " does not exist");
+ }
+
+
System.out.println("***");
+ System.out.println("Upgrading broker instance " + directory + " to use
artemis.home=" + getBrokerHome());
+
+ upgradeArtemis(bkpBin, bin, etcFolder);
+ upgradeArtemisCmd(bkpBin, bin, etcFolder);
+ upgradeArtemisProfile(etcBkp, etcFolder, directory);
+ upgradeBootstrap(etcBkp, etcFolder, directory);
+ upgradeLogging(etcBkp, etcFolder, directory);
+ System.out.println();
+ System.out.println("Warning: ./artemis upgrade does not bring new
functionality on the script itself from newer artemis versions. Please check
for any differences on artemis script in the current release!");
+
System.out.println("***");
+
+ return null;
+ }
+
+ private void upgradeLogging(File bkpFolder, File etc, File instance) throws
Exception {
+ File oldLogging = new File(etc, "logging.properties");
+
+ if (oldLogging.exists()) {
+ System.out.println("Moving " + oldLogging + " under " + bkpFolder);
+ File oldLoggingCopy = new File(bkpFolder, "logging.properties");
+ Files.copy(oldLogging.toPath(), oldLoggingCopy.toPath(),
StandardCopyOption.REPLACE_EXISTING);
+ oldLogging.delete();
+ File newLogging = new File(etc, Create.ETC_LOG4J2_PROPERTIES);
+
+
+ if (!newLogging.exists()) {
+System.out.println("Creating " + newLogging);
+InputStream inputStream = getClass().getResourceAsStream("etc/" +
[jira] [Work logged] (ARTEMIS-4020) switch to using SLF4J for logging API and use Log4j 2 for broker distribution
[ https://issues.apache.org/jira/browse/ARTEMIS-4020?focusedWorklogId=822636=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822636 ] ASF GitHub Bot logged work on ARTEMIS-4020: --- Author: ASF GitHub Bot Created on: 02/Nov/22 11:57 Start Date: 02/Nov/22 11:57 Worklog Time Spent: 10m Work Description: TheCycoONE commented on code in PR #4246: URL: https://github.com/apache/activemq-artemis/pull/4246#discussion_r1011639590 ## tests/smoke-tests/src/main/resources/servers/toUpgradeTest/etc/artemis.profile: ## @@ -0,0 +1,63 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +ARTEMIS_HOME='/Users/someUser/Downloads/upgrade/apache-artemis-2.25.0' Review Comment: I was thinking similar, my understanding is this tool should work back to the last special upgrade procedure in 2.21 Issue Time Tracking --- Worklog Id: (was: 822636) Time Spent: 16h 50m (was: 16h 40m) > switch to using SLF4J for logging API and use Log4j 2 for broker distribution > - > > Key: ARTEMIS-4020 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4020 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: 2.27.0 > > Time Spent: 16h 50m > Remaining Estimate: 0h > > Switch to using [SLF4J|https://www.slf4j.org/] as the logging API for the > code base, with end-uses supplying and configuring an SLF4J-supporting > logging implementation of their choice based on their needs. > For the client, applications will need to supply an SLF4J binding to a > logging implementation of their choice to enable logging. An example of doing > so using [Log4J 2|https://logging.apache.org/log4j/2.x/manual/index.html] is > given in (/will be, once the release is out) the [client logging > documentation|https://activemq.apache.org/components/artemis/documentation/latest/logging.html#logging-in-a-client-application]. > For the broker, the assembly distribution will include [Log4J > 2|https://logging.apache.org/log4j/2.x/manual/index.html] as its logging > implentation, with the "artemis create" CLI command used to create broker > instances now creating a log4j2.properties configuration within the > /etc/ directory to configure Log4J. Details for upgrading an > existing broker-instance is given in (/will be, once the release is out) the > [version upgrade > documentation|https://activemq.apache.org/components/artemis/documentation/latest/versions.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (AMQ-9155) Alpilean Reviews – Shocking Side Effects Concern or Real Customer Results?
Nelli Nell created AMQ-9155: --- Summary: Alpilean Reviews – Shocking Side Effects Concern or Real Customer Results? Key: AMQ-9155 URL: https://issues.apache.org/jira/browse/AMQ-9155 Project: ActiveMQ Issue Type: Bug Reporter: Nelli Nell Alpilean is a weight loss supplement available exclusively online through [Alpilean|https://bit.ly/3wWpXGa]. By taking one capsule of [Alpilean Reviews|https://colab.research.google.com/drive/1CUCQTFaDAQOe8DkGQxByJZ6n-JkcjClC?usp=sharing] daily, anyone can purportedly lose weight using a “strange alpine method” that dissolves inches of deep fat without any side effects, concerns or adverse reactions according to the official website. But are there truly real Alpilean weight loss results for customers or is it just another lousy diet pill that offers nothing unique or worthy of purchasing? Keep reading to find out everything you need to know about Alpilean and how it works today in our review, but first a top down look at all of the most vital details pertaining to this highly touted formula: Product: * Alpilean Summary: * [Alpilean Reviews|https://hackmd.io/@pamelaromero/S1tYcFJBo] is a doctor-formulated weight loss supplement with clinically-proven ingredients based on an Alpine weight loss ice hack secret that regenerates low inner core body temperate by igniting this primitive calorie-burning switch using six anti-aging Alpine nutrients sourced directly from the healthy Thangu Valley that have an incredible power to restore core body temperature for optimal metabolic health, weight management and whole body wellness with no reported side effects. Dosage: * take one (1) Alpilean capsule daily, recommended with food in the morning or at lunchtime with at least 8 ounces of purified fresh filtered water Creators: * Zach Miller created Alpilean with the help of anti-aging metabolic specialist and British doctor Dr. Matthew Gibbs, along with medical doctor consultant and advisor Dr. Patla (both Professor Anders and Lubanzi get honorable mentions for their insightful contributions of turmeric and ginger respectively Official Site: * [Alpilean|https://bit.ly/3wWpXGa] (save the most buying directly from Alpilean official website) Ingredients: * Six Alpine superfood nutrient ingredients in [Alpilean Reviews|https://www.vingle.net/posts/4920542] are golden algae Fucoxanthin extract of 10%, Dika Nut African Mango Seed (Irvingia Gabonensis extract), Drumstick tree Moringa Leaf (moringa oleifera), Bigarade Orange Citrus Bioflavanoids extract (from Citrus aurantium fruit), and of course Turmeric Rhizome (Curcuma Longa) and Ginger Rhizome (Zingiber Officinale) in a 250mg capsule [Vitamin B12 (as Cyanocobalamin) 35mcg (417% daily value) and Chromium (as Chromium Picolinate) 10mcg (100% daily value) are also added] Price: * Alpilean Starter Package: 1 Bottle 30 Day Supply = $59 bottle * Alpilean Most Popular Package: 3 Bottles 90 Day Supply = $49 bottle (includes 2 free bonuses to download immediately accessible) * Alpilean Best Value Package: 6 bottles 180 day Supply = $39 bottle (includes 2 free bonuses and free shipping) * All Alpilean orders are backed by a 60-day money-back guarantee refund policy valid until two months from original order date Bonus: * 1-day Kickstart Detox (aids in Alpilean ingredient absorption for optimal results) * Renew You (gives the entire Alpilean weight loss journey a big boost) * note: the 2 free PDF bonus guides are only available for the three and six-month packages Consumer Safety: * Never buy Alpilean online from any other website but the official marketplace at Alpilean * Alpilean will never be made available at Amazon, Walmart, eBay, GNC or CVS * The rock-solid risk-free 60-day refund policy of [Alpilean Reviews|https://leetcode.com/discuss/interview-question/2769540/Alpilean-Reviews-Shocking-Side-Effects-Concern-or-Real-Customer-Results] is for customers who purchase directly from the company * all Alpilean supplement listings on Amazon are ripoffs * these various marketplaces should be avoided at all costs as they are 100% fraudulent and are not authorized to resell from the actual company, not to mention there are serious dangers and adverse reactions when it comes to negative complaints about Alpilean side effects using these fake look-a-like counterfeit knockoff products that do no testing or vetting of any kind. Customer Service: * use for the Alpilean customer service support email for a prompt and fast response How to Buy * [on the Alpilean official website Alpilean|https://bit.ly/3wWpXGa] *What is Alpilean?* Alpilean is a diet pill featuring a blend of proven natural ingredients to accelerate fat burning based on a strange alpine method that dissolves inches of deep fat using an odd
[jira] [Commented] (ARTEMIS-4036) mqtt client receive 131 code
[ https://issues.apache.org/jira/browse/ARTEMIS-4036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627534#comment-17627534 ] gongping.zhu commented on ARTEMIS-4036: --- 2022-11-01 13:54:48,205 ERROR [org.apache.activemq.artemis.core.server] AMQ224096: Error setting up connection from /47.101.154.149:55358 to /172.22.35.99:5672; protocol CORE not found in map: [AMQP] 2022-11-01 13:54:48,205 ERROR [org.apache.activemq.artemis.core.server] AMQ224096: Error setting up connection from /47.101.154.149:38734 to /172.22.35.99:1883; protocol CORE not found in map: [MQTT] 2022-11-01 17:04:19,146 ERROR [org.apache.activemq.artemis.core.server] AMQ224096: Error setting up connection from /101.133.147.20:41770 to /172.22.35.99:61613; protocol CORE not found in map: [STOMP] 2022-11-01 17:37:17,198 WARN [org.apache.activemq.artemis.core.server] AMQ222107: Cleared up resources for session c6313c66-59c8-11ed-a15c-aeb104d0d5a5 2022-11-01 17:37:17,198 WARN [org.apache.activemq.artemis.core.server] AMQ222061: Client connection failed, clearing up resources for session c6313c67-59c8-11ed-a15c-aeb104d0d5a5 > mqtt client receive 131 code > > > Key: ARTEMIS-4036 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4036 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.25.0 >Reporter: gongping.zhu >Priority: Major > > sometimes mqtt client connect the server ; it will receive The Server > Disconnected the client. Disconnect RC: 131 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARTEMIS-4080) mqtt client receive 131 code
gongping.zhu created ARTEMIS-4080: - Summary: mqtt client receive 131 code Key: ARTEMIS-4080 URL: https://issues.apache.org/jira/browse/ARTEMIS-4080 Project: ActiveMQ Artemis Issue Type: Bug Components: ActiveMQ-Artemis-Native Affects Versions: 2.26.0 Reporter: gongping.zhu Assignee: Clebert Suconic Recently, it has been found that some devices have successfully connected to the Artemis 2.26.0 version service. After a period of time, the device has not been able to connect to the service. At the same time, the client receives The Server Disconnected the Client, RC 131. Can you help diagnose and analyze the reason? -- This message was sent by Atlassian Jira (v8.20.10#820010)
