[jira] [Work logged] (ARTEMIS-4106) Do not set property with empty key name when converting to OpenWire
[
https://issues.apache.org/jira/browse/ARTEMIS-4106?focusedWorklogId=831629&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-831629
]
ASF GitHub Bot logged work on ARTEMIS-4106:
---
Author: ASF GitHub Bot
Created on: 07/Dec/22 05:59
Start Date: 07/Dec/22 05:59
Worklog Time Spent: 10m
Work Description: brusdev commented on code in PR #4302:
URL: https://github.com/apache/activemq-artemis/pull/4302#discussion_r1041789019
##
artemis-protocols/artemis-openwire-protocol/src/test/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverterTest.java:
##
@@ -248,6 +248,7 @@ public void testBadPropertyConversion() throws Exception {
coreMessage.putStringProperty(hdrBrokerInTime, "5678");
coreMessage.putStringProperty(hdrCommandId, "foo");
coreMessage.putStringProperty(hdrDroppable, "true");
+ coreMessage.putStringProperty("", "");
Review Comment:
@jbertram I see your point on backward compatibility for the CORE protocol
but from JMS point of view empty property names are not allowed. What would
happen if a core msg with an empty property name Is received by a qpid JMS
consumer or a core JMS consumer?
Issue Time Tracking
---
Worklog Id: (was: 831629)
Time Spent: 1h (was: 50m)
> Do not set property with empty key name when converting to OpenWire
> ---
>
> Key: ARTEMIS-4106
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4106
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> If a property with an empty key name is set on a core message and then
> converted to OpenWire this exception is thrown in accordance with the [JMS
> spec|https://docs.oracle.com/javaee/7/api/javax/jms/Message.html#setObjectProperty-java.lang.String-java.lang.Object-]:
> {noformat}
> java.lang.IllegalArgumentException: Property name cannot be empty or null
> at
> org.apache.activemq.command.ActiveMQMessage.setObjectProperty(ActiveMQMessage.java:497)
> at
> org.apache.activemq.command.ActiveMQMessage.setObjectProperty(ActiveMQMessage.java:488)
> at
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.setAMQMsgObjectProperties(OpenWireMessageConverter.java:945)
> at
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.toAMQMessage(OpenWireMessageConverter.java:677)
> at
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.createMessageDispatch(OpenWireMessageConverter.java:481)
> ...{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-3042) Official Docker Multistage Build as well as an official Docker image.
[ https://issues.apache.org/jira/browse/ARTEMIS-3042?focusedWorklogId=831627&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-831627 ] ASF GitHub Bot logged work on ARTEMIS-3042: --- Author: ASF GitHub Bot Created on: 07/Dec/22 05:47 Start Date: 07/Dec/22 05:47 Worklog Time Spent: 10m Work Description: SamTV12345 commented on PR #4307: URL: https://github.com/apache/activemq-artemis/pull/4307#issuecomment-1340403897 Thanks for the hint. I added a message according to your guidelines. This pr solves exactly that issue. Issue Time Tracking --- Worklog Id: (was: 831627) Time Spent: 20m (was: 10m) > Official Docker Multistage Build as well as an official Docker image. > - > > Key: ARTEMIS-3042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3042 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: John Behm >Priority: Minor > Labels: docker,, dockerfile,, kubernetes > Time Spent: 20m > Remaining Estimate: 0h > > It would be rather convenient to get people up and running with an easy to > build or to setup Docker image that automatically builds the project from > source, discards the build container and moves the necessary files over to > the final container that can simply be started. > The current docker image build is not really user firendly or convenient at > all. > > https://github.com/apache/activemq-artemis/tree/master/artemis-docker > The whole setup process of artemis in a containerized environment is very > far from even good. > The hurdle of using this software is gigantic, as the configuration is so > complex, one will not be able to do this within one month without having gone > through the whole documentation multiple times. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4108) AMQP Drain can fail with Large Messages under load
[ https://issues.apache.org/jira/browse/ARTEMIS-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17644037#comment-17644037 ] ASF subversion and git services commented on ARTEMIS-4108: -- Commit 33567fca8d6f9a0c8ca918f9393e0ca63c8ccf9a in activemq-artemis's branch refs/heads/main from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=33567fca8d ] ARTEMIS-4108 Improving flush on large message fix > AMQP Drain can fail with Large Messages under load > -- > > Key: ARTEMIS-4108 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4108 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.27.1 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.28.0 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4105) useGlobalPools=false or ActiveMQConnectionFactory.setUseGlobalPools(false) makes for dead services
[
https://issues.apache.org/jira/browse/ARTEMIS-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643842#comment-17643842
]
john lilley commented on ARTEMIS-4105:
--
We've resolved our threading issues with a single pool and this is not a
blocker for our project any longer. However, it does seem to be broken.
> useGlobalPools=false or ActiveMQConnectionFactory.setUseGlobalPools(false)
> makes for dead services
> --
>
> Key: ARTEMIS-4105
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4105
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: ActiveMQ-Artemis-Native
>Affects Versions: 2.27.1
>Reporter: john lilley
>Assignee: Clebert Suconic
>Priority: Major
> Attachments: amqtest.zip
>
>
> We have an application, which mostly interfaces with the vanilla JMS driver
> for Artemis, except for the connection factory.
> In an attempt to work around ARTEMIS-4104, I investigated using
> per-connection thread pools as per
> [https://activemq.apache.org/components/artemis/documentation/latest/thread-pooling.html],
> in the hope that I could divide services in categories, and have each
> category use an independent thread pool. Instead, I find that the
> application is completely dead. Nothing is ever delivered to services.
> Please tell me I'm just doing something stupid :)
> To validate, build the attached project using maven 3.8 and JDK 17. Run the
> Main, and ... nothing will happen after the requests are posted to the queue.
> This is a very small change from the sample posted to ARTEMIS-4104, which
> runs (albeit with a deadlock issue) so I don't think anything is different
> other than the attempt to use multiple connections, each with its own thread
> pool.
> PS: if this method
> {code:java}
> public static Connection getConnection(String label) {
>return connections.computeIfAbsent(label, k -> {
> try {
> Connection connection =
> getConnectionFactory().createConnection("admin", "admin");
> connection.start();
> return connection;
> } catch (Exception ex) {
> throw new RuntimeException("Failed to make AMQ connection", ex);
> }
>});
> } {code}
> Is simply changed to
> {code:java}
> public static Connection getConnection(String label) {
>return connections.computeIfAbsent("", k -> {
> ...
> } {code}
> So everything gets the same connection, it works. It also works if I don't
> call
> {{connectionFactory.setUseGlobalPools(false);}}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4042) DefaultSensitiveStringCodec - read ARTEMIS_DEFAULT_SENSITIVE_STRING_CODEC_KEY env if system property is not set
[ https://issues.apache.org/jira/browse/ARTEMIS-4042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643792#comment-17643792 ] Gary Tully commented on ARTEMIS-4042: - https://github.com/apache/activemq-artemis/pull/4306 > DefaultSensitiveStringCodec - read ARTEMIS_DEFAULT_SENSITIVE_STRING_CODEC_KEY > env if system property is not set > > > Key: ARTEMIS-4042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4042 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Configuration >Affects Versions: 2.26.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Fix For: 2.27.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Following up on ARTEMIS-3488, to avoid expansion of the env var on the > command line, if it is not set as a system property, attempt to read directly > from the environment. -- This message was sent by Atlassian Jira (v8.20.10#820010)
