[jira] [Work logged] (ARTEMIS-4161) AMQP and OpenWire have a few Leaks during open and close connections

2023-02-15 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4161?focusedWorklogId=845763=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-845763
 ]

ASF GitHub Bot logged work on ARTEMIS-4161:
---

Author: ASF GitHub Bot
Created on: 16/Feb/23 04:57
Start Date: 16/Feb/23 04:57
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on code in PR #4363:
URL: https://github.com/apache/activemq-artemis/pull/4363#discussion_r1108006085


##
tests/leak-tests/pom.xml:
##
@@ -0,0 +1,488 @@
+
> Key: ARTEMIS-4161
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4161
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.28.0
>Reporter: Clebert Suconic
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.29.0
>
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> OpenWire and AMQP are leaking objects in the following scenarios:
> AMQP:
> - Open Transactions, open connections, close connections, commit, send
> It appears these leaks are sustained as long as you keep closing and opening 
> sessions.
> OpenWire:
> - The leak here is not as critical as in AMQP, but a short term leak was 
> found while investigating the AMQP issue. (the AMQP connection would be 
> released after a TTL Timeout).
> To Validate this, I'm creating a new test suite:
> ./tests/leak-tests
> Which will use https://github.com/check-leak/check-leak to validate the 
> survival of these objects.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-4171) Potential large message file leak

2023-02-15 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4171?focusedWorklogId=845759=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-845759
 ]

ASF GitHub Bot logged work on ARTEMIS-4171:
---

Author: ASF GitHub Bot
Created on: 16/Feb/23 04:32
Start Date: 16/Feb/23 04:32
Worklog Time Spent: 10m 
  Work Description: jbertram closed pull request #4372: ARTEMIS-4171 
potential large message file leak
URL: https://github.com/apache/activemq-artemis/pull/4372




Issue Time Tracking
---

Worklog Id: (was: 845759)
Remaining Estimate: 0h
Time Spent: 10m

> Potential large message file leak
> -
>
> Key: ARTEMIS-4171
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4171
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> If an exception is thrown during the sending of a large message (e.g. from a 
> plugin) the large message file can be orphaned on disk.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-4171) Potential large message file leak

2023-02-15 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4171?focusedWorklogId=845760=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-845760
 ]

ASF GitHub Bot logged work on ARTEMIS-4171:
---

Author: ASF GitHub Bot
Created on: 16/Feb/23 04:32
Start Date: 16/Feb/23 04:32
Worklog Time Spent: 10m 
  Work Description: jbertram commented on PR #4372:
URL: 
https://github.com/apache/activemq-artemis/pull/4372#issuecomment-1432498585

   Replaced by #4373.




Issue Time Tracking
---

Worklog Id: (was: 845760)
Time Spent: 20m  (was: 10m)

> Potential large message file leak
> -
>
> Key: ARTEMIS-4171
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4171
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> If an exception is thrown during the sending of a large message (e.g. from a 
> plugin) the large message file can be orphaned on disk.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-4161) AMQP and OpenWire have a few Leaks during open and close connections

2023-02-15 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4161?focusedWorklogId=845747=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-845747
 ]

ASF GitHub Bot logged work on ARTEMIS-4161:
---

Author: ASF GitHub Bot
Created on: 16/Feb/23 02:04
Start Date: 16/Feb/23 02:04
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on code in PR #4363:
URL: https://github.com/apache/activemq-artemis/pull/4363#discussion_r1107930577


##
tests/leak-tests/pom.xml:
##
@@ -0,0 +1,488 @@
+
> Key: ARTEMIS-4161
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4161
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.28.0
>Reporter: Clebert Suconic
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.29.0
>
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> OpenWire and AMQP are leaking objects in the following scenarios:
> AMQP:
> - Open Transactions, open connections, close connections, commit, send
> It appears these leaks are sustained as long as you keep closing and opening 
> sessions.
> OpenWire:
> - The leak here is not as critical as in AMQP, but a short term leak was 
> found while investigating the AMQP issue. (the AMQP connection would be 
> released after a TTL Timeout).
> To Validate this, I'm creating a new test suite:
> ./tests/leak-tests
> Which will use https://github.com/check-leak/check-leak to validate the 
> survival of these objects.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (ARTEMIS-4172) Sending large message via core skips plugins & audit logging

2023-02-15 Thread Justin Bertram (Jira)
Justin Bertram created ARTEMIS-4172:
---

 Summary: Sending large message via core skips plugins & audit 
logging
 Key: ARTEMIS-4172
 URL: https://issues.apache.org/jira/browse/ARTEMIS-4172
 Project: ActiveMQ Artemis
  Issue Type: Bug
Reporter: Justin Bertram
Assignee: Justin Bertram






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (AMQ-7309) Add JMS 2.0 API support

2023-02-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AMQ-7309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689392#comment-17689392
 ] 

ASF subversion and git services commented on AMQ-7309:
--

Commit ee1477830511a71d89a1e987191c271cb8c0b5a7 in activemq's branch 
refs/heads/main from Christopher L. Shannon (cshannon)
[ https://gitbox.apache.org/repos/asf?p=activemq.git;h=ee1477830 ]

AMQ-7309 - remove test after adding support for jms 2 create session


> Add JMS 2.0 API support
> ---
>
> Key: AMQ-7309
> URL: https://issues.apache.org/jira/browse/AMQ-7309
> Project: ActiveMQ
>  Issue Type: New Feature
>  Components: Broker, JMS client
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
>  Labels: #jms2
> Fix For: 5.18.0
>
>  Time Spent: 18h
>  Remaining Estimate: 0h
>
> * API-only inclusion
> * JMS 2.0 objects throw UnsupportedOperationException



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-4161) AMQP and OpenWire have a few Leaks during open and close connections

2023-02-15 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4161?focusedWorklogId=845739=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-845739
 ]

ASF GitHub Bot logged work on ARTEMIS-4161:
---

Author: ASF GitHub Bot
Created on: 15/Feb/23 22:59
Start Date: 15/Feb/23 22:59
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on code in PR #4363:
URL: https://github.com/apache/activemq-artemis/pull/4363#discussion_r1107825940


##
tests/leak-tests/pom.xml:
##
@@ -0,0 +1,488 @@
+
> Key: ARTEMIS-4161
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4161
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.28.0
>Reporter: Clebert Suconic
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.29.0
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> OpenWire and AMQP are leaking objects in the following scenarios:
> AMQP:
> - Open Transactions, open connections, close connections, commit, send
> It appears these leaks are sustained as long as you keep closing and opening 
> sessions.
> OpenWire:
> - The leak here is not as critical as in AMQP, but a short term leak was 
> found while investigating the AMQP issue. (the AMQP connection would be 
> released after a TTL Timeout).
> To Validate this, I'm creating a new test suite:
> ./tests/leak-tests
> Which will use https://github.com/check-leak/check-leak to validate the 
> survival of these objects.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (AMQ-7309) Add JMS 2.0 API support

2023-02-15 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/AMQ-7309?focusedWorklogId=845738=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-845738
 ]

ASF GitHub Bot logged work on AMQ-7309:
---

Author: ASF GitHub Bot
Created on: 15/Feb/23 22:51
Start Date: 15/Feb/23 22:51
Worklog Time Spent: 10m 
  Work Description: cshannon commented on PR #979:
URL: https://github.com/apache/activemq/pull/979#issuecomment-1432182784

   I think this is ready for review now, I updated the getBody() method to copy 
into a new object. Can let the CI tests run to make sure I didn't break 
anything as I had to do a little refactoring to make copying the body simpler.




Issue Time Tracking
---

Worklog Id: (was: 845738)
Time Spent: 18h  (was: 17h 50m)

> Add JMS 2.0 API support
> ---
>
> Key: AMQ-7309
> URL: https://issues.apache.org/jira/browse/AMQ-7309
> Project: ActiveMQ
>  Issue Type: New Feature
>  Components: Broker, JMS client
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
>  Labels: #jms2
> Fix For: 5.18.0
>
>  Time Spent: 18h
>  Remaining Estimate: 0h
>
> * API-only inclusion
> * JMS 2.0 objects throw UnsupportedOperationException



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-4169) Auto detect dead-letter and expiry queues in the console

2023-02-15 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4169?focusedWorklogId=845737=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-845737
 ]

ASF GitHub Bot logged work on ARTEMIS-4169:
---

Author: ASF GitHub Bot
Created on: 15/Feb/23 22:50
Start Date: 15/Feb/23 22:50
Worklog Time Spent: 10m 
  Work Description: jbertram commented on PR #4370:
URL: 
https://github.com/apache/activemq-artemis/pull/4370#issuecomment-1432181782

   I pulled your branch and built a release in order to test it. However, when 
I create an address named `foo` with an anycast queue named `foo` and send a 
message to it nothing is showing up in the browse tab. If I send a message 
directly to `DLQ` I can browse messages there.
   
   Am I doing something wrong or is the PR broken somehow?




Issue Time Tracking
---

Worklog Id: (was: 845737)
Remaining Estimate: 0h
Time Spent: 10m

> Auto detect dead-letter and expiry queues in the console
> 
>
> Key: ARTEMIS-4169
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4169
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Domenico Francesco Bruscino
>Assignee: Domenico Francesco Bruscino
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The custom DLQ do not show some options/columns on hawtio. For this we have 
> to configure "Dead-letter address regex" on the management console. 
> The console browse plugin could auto-detect dead-letter and expiry queues by 
> checking the `_AMQ_ORIG_QUEUE` property.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (ARTEMIS-4171) Potential large message file leak

2023-02-15 Thread Justin Bertram (Jira)
Justin Bertram created ARTEMIS-4171:
---

 Summary: Potential large message file leak
 Key: ARTEMIS-4171
 URL: https://issues.apache.org/jira/browse/ARTEMIS-4171
 Project: ActiveMQ Artemis
  Issue Type: Bug
Reporter: Justin Bertram
Assignee: Justin Bertram


If an exception is thrown during the sending of a large message (e.g. from a 
plugin) the large message file can be orphaned on disk.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-4170) Remove redundant queue creation for OpenWire

2023-02-15 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4170?focusedWorklogId=845707=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-845707
 ]

ASF GitHub Bot logged work on ARTEMIS-4170:
---

Author: ASF GitHub Bot
Created on: 15/Feb/23 19:48
Start Date: 15/Feb/23 19:48
Worklog Time Spent: 10m 
  Work Description: jbertram opened a new pull request, #4371:
URL: https://github.com/apache/activemq-artemis/pull/4371

   o.a.a.a.c.p.o.a.AMQConsumer#init will *always* try to create a core queue 
when creating a consumer for a JMS queue. However, this is already done in 
o.a.a.a.c.p.o.a.AMQSession#createConsumer.




Issue Time Tracking
---

Worklog Id: (was: 845707)
Remaining Estimate: 0h
Time Spent: 10m

> Remove redundant queue creation for OpenWire
> 
>
> Key: ARTEMIS-4170
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4170
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (AMQNET-829) Add option to define allow, deny lists of types which can be binary serialized

2023-02-15 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/AMQNET-829?focusedWorklogId=845702=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-845702
 ]

ASF GitHub Bot logged work on AMQNET-829:
-

Author: ASF GitHub Bot
Created on: 15/Feb/23 19:05
Start Date: 15/Feb/23 19:05
Worklog Time Spent: 10m 
  Work Description: Havret opened a new pull request, #29:
URL: https://github.com/apache/activemq-nms-openwire/pull/29

   This is a version of https://github.com/apache/activemq-nms-amqp/pull/85 
customized for open-wire client. The API/tests are exactly the same. 
   
   @michaelandrepearce @lukeabsent guys, would you be so kind to take a look at 
this? 




Issue Time Tracking
---

Worklog Id: (was: 845702)
Remaining Estimate: 0h
Time Spent: 10m

> Add option to define allow, deny lists of types which can be binary serialized
> --
>
> Key: AMQNET-829
> URL: https://issues.apache.org/jira/browse/AMQNET-829
> Project: ActiveMQ .Net
>  Issue Type: New Feature
>Affects Versions: OpenWire-2.0.1
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
> Fix For: OpenWire-2.1.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (AMQNET-829) Add option to define allow, deny lists of types which can be binary serialized

2023-02-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AMQNET-829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689309#comment-17689309
 ] 

ASF subversion and git services commented on AMQNET-829:


Commit 6bedbb487cc4f321613bb68811c1656ebe9f52d7 in activemq-nms-openwire's 
branch refs/heads/allow_deny_list from Havret
[ https://gitbox.apache.org/repos/asf?p=activemq-nms-openwire.git;h=6bedbb4 ]

AMQNET-829 Add allow, deny types support


> Add option to define allow, deny lists of types which can be binary serialized
> --
>
> Key: AMQNET-829
> URL: https://issues.apache.org/jira/browse/AMQNET-829
> Project: ActiveMQ .Net
>  Issue Type: New Feature
>Affects Versions: OpenWire-2.0.1
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
> Fix For: OpenWire-2.1.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (AMQNET-829) Add option to define allow, deny lists of types which can be binary serialized

2023-02-15 Thread Jira


 [ 
https://issues.apache.org/jira/browse/AMQNET-829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krzysztof Porębski updated AMQNET-829:
--
Fix Version/s: OpenWire-2.1.0
   (was: OpenWire-2.0.1)

> Add option to define allow, deny lists of types which can be binary serialized
> --
>
> Key: AMQNET-829
> URL: https://issues.apache.org/jira/browse/AMQNET-829
> Project: ActiveMQ .Net
>  Issue Type: New Feature
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
> Fix For: OpenWire-2.1.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (AMQNET-829) Add option to define allow, deny lists of types which can be binary serialized

2023-02-15 Thread Jira


 [ 
https://issues.apache.org/jira/browse/AMQNET-829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krzysztof Porębski updated AMQNET-829:
--
Fix Version/s: OpenWire-2.0.1

> Add option to define allow, deny lists of types which can be binary serialized
> --
>
> Key: AMQNET-829
> URL: https://issues.apache.org/jira/browse/AMQNET-829
> Project: ActiveMQ .Net
>  Issue Type: New Feature
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
> Fix For: OpenWire-2.0.1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (AMQNET-829) Add option to define allow, deny lists of types which can be binary serialized

2023-02-15 Thread Jira
Krzysztof Porębski created AMQNET-829:
-

 Summary: Add option to define allow, deny lists of types which can 
be binary serialized
 Key: AMQNET-829
 URL: https://issues.apache.org/jira/browse/AMQNET-829
 Project: ActiveMQ .Net
  Issue Type: New Feature
Reporter: Krzysztof Porębski
Assignee: Krzysztof Porębski






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (AMQNET-829) Add option to define allow, deny lists of types which can be binary serialized

2023-02-15 Thread Jira


 [ 
https://issues.apache.org/jira/browse/AMQNET-829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Krzysztof Porębski updated AMQNET-829:
--
Affects Version/s: OpenWire-2.0.1

> Add option to define allow, deny lists of types which can be binary serialized
> --
>
> Key: AMQNET-829
> URL: https://issues.apache.org/jira/browse/AMQNET-829
> Project: ActiveMQ .Net
>  Issue Type: New Feature
>Affects Versions: OpenWire-2.0.1
>Reporter: Krzysztof Porębski
>Assignee: Krzysztof Porębski
>Priority: Major
> Fix For: OpenWire-2.1.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-4161) AMQP and OpenWire have a few Leaks during open and close connections

2023-02-15 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4161?focusedWorklogId=845698=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-845698
 ]

ASF GitHub Bot logged work on ARTEMIS-4161:
---

Author: ASF GitHub Bot
Created on: 15/Feb/23 18:36
Start Date: 15/Feb/23 18:36
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on code in PR #4363:
URL: https://github.com/apache/activemq-artemis/pull/4363#discussion_r1107548367


##
tests/leak-tests/pom.xml:
##
@@ -0,0 +1,488 @@
+
> Key: ARTEMIS-4161
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4161
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.28.0
>Reporter: Clebert Suconic
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.29.0
>
>  Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> OpenWire and AMQP are leaking objects in the following scenarios:
> AMQP:
> - Open Transactions, open connections, close connections, commit, send
> It appears these leaks are sustained as long as you keep closing and opening 
> sessions.
> OpenWire:
> - The leak here is not as critical as in AMQP, but a short term leak was 
> found while investigating the AMQP issue. (the AMQP connection would be 
> released after a TTL Timeout).
> To Validate this, I'm creating a new test suite:
> ./tests/leak-tests
> Which will use https://github.com/check-leak/check-leak to validate the 
> survival of these objects.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (ARTEMIS-4170) Remove redundant queue creation for OpenWire

2023-02-15 Thread Justin Bertram (Jira)
Justin Bertram created ARTEMIS-4170:
---

 Summary: Remove redundant queue creation for OpenWire
 Key: ARTEMIS-4170
 URL: https://issues.apache.org/jira/browse/ARTEMIS-4170
 Project: ActiveMQ Artemis
  Issue Type: Bug
Reporter: Justin Bertram
Assignee: Justin Bertram






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-4160) jolokia-access.xml getting invalid XML from hostname during instance creation

2023-02-15 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4160?focusedWorklogId=845693=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-845693
 ]

ASF GitHub Bot logged work on ARTEMIS-4160:
---

Author: ASF GitHub Bot
Created on: 15/Feb/23 17:29
Start Date: 15/Feb/23 17:29
Worklog Time Spent: 10m 
  Work Description: davidlanouette commented on PR #4362:
URL: 
https://github.com/apache/activemq-artemis/pull/4362#issuecomment-1431743200

   @jbertram @brusdev 
   
   Can I get someone to take a look at this PR again?
   
   I've added a test that will create the full jolokia-access.xml file, then 
test that it's valid xml.
   
   I'll likely do the same for the other xml files, but in another PR.
   




Issue Time Tracking
---

Worklog Id: (was: 845693)
Time Spent: 2h 20m  (was: 2h 10m)

> jolokia-access.xml getting invalid XML from hostname during instance creation
> -
>
> Key: ARTEMIS-4160
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4160
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Justin Bertram
>Priority: Major
>  Time Spent: 2h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (AMQ-7309) Add JMS 2.0 API support

2023-02-15 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/AMQ-7309?focusedWorklogId=845685=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-845685
 ]

ASF GitHub Bot logged work on AMQ-7309:
---

Author: ASF GitHub Bot
Created on: 15/Feb/23 16:40
Start Date: 15/Feb/23 16:40
Worklog Time Spent: 10m 
  Work Description: cshannon opened a new pull request, #979:
URL: https://github.com/apache/activemq/pull/979

   This still needs tests but wanted to push it up for people to review.




Issue Time Tracking
---

Worklog Id: (was: 845685)
Time Spent: 17h 50m  (was: 17h 40m)

> Add JMS 2.0 API support
> ---
>
> Key: AMQ-7309
> URL: https://issues.apache.org/jira/browse/AMQ-7309
> Project: ActiveMQ
>  Issue Type: New Feature
>  Components: Broker, JMS client
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
>  Labels: #jms2
> Fix For: 5.18.0
>
>  Time Spent: 17h 50m
>  Remaining Estimate: 0h
>
> * API-only inclusion
> * JMS 2.0 objects throw UnsupportedOperationException



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (AMQ-7309) Add JMS 2.0 API support

2023-02-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AMQ-7309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689229#comment-17689229
 ] 

ASF subversion and git services commented on AMQ-7309:
--

Commit 160840d3b33245dda3e6d4f851237acba4b232ca in activemq's branch 
refs/heads/main from Christopher L. Shannon
[ https://gitbox.apache.org/repos/asf?p=activemq.git;h=160840d3b ]

Merge pull request #978 from cshannon/AMQ-7309-session

AMQ-7309 - Implement JMS 2.0 createSession methods

> Add JMS 2.0 API support
> ---
>
> Key: AMQ-7309
> URL: https://issues.apache.org/jira/browse/AMQ-7309
> Project: ActiveMQ
>  Issue Type: New Feature
>  Components: Broker, JMS client
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
>  Labels: #jms2
> Fix For: 5.18.0
>
>  Time Spent: 17h 40m
>  Remaining Estimate: 0h
>
> * API-only inclusion
> * JMS 2.0 objects throw UnsupportedOperationException



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (AMQ-7309) Add JMS 2.0 API support

2023-02-15 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/AMQ-7309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17689228#comment-17689228
 ] 

ASF subversion and git services commented on AMQ-7309:
--

Commit 2c69e30748c361ac3d62b6b3b37e703ac64a220b in activemq's branch 
refs/heads/main from Christopher L. Shannon (cshannon)
[ https://gitbox.apache.org/repos/asf?p=activemq.git;h=2c69e3074 ]

AMQ-7309 - Implement JMS 2.0 createSession methods

Adds a real implemention for createSession() and createSession(ackMode)
methods on ActiveMQConnection


> Add JMS 2.0 API support
> ---
>
> Key: AMQ-7309
> URL: https://issues.apache.org/jira/browse/AMQ-7309
> Project: ActiveMQ
>  Issue Type: New Feature
>  Components: Broker, JMS client
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
>  Labels: #jms2
> Fix For: 5.18.0
>
>  Time Spent: 17h 40m
>  Remaining Estimate: 0h
>
> * API-only inclusion
> * JMS 2.0 objects throw UnsupportedOperationException



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (AMQ-7309) Add JMS 2.0 API support

2023-02-15 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/AMQ-7309?focusedWorklogId=845683=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-845683
 ]

ASF GitHub Bot logged work on AMQ-7309:
---

Author: ASF GitHub Bot
Created on: 15/Feb/23 16:35
Start Date: 15/Feb/23 16:35
Worklog Time Spent: 10m 
  Work Description: cshannon merged PR #978:
URL: https://github.com/apache/activemq/pull/978




Issue Time Tracking
---

Worklog Id: (was: 845683)
Time Spent: 17h 40m  (was: 17.5h)

> Add JMS 2.0 API support
> ---
>
> Key: AMQ-7309
> URL: https://issues.apache.org/jira/browse/AMQ-7309
> Project: ActiveMQ
>  Issue Type: New Feature
>  Components: Broker, JMS client
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
>  Labels: #jms2
> Fix For: 5.18.0
>
>  Time Spent: 17h 40m
>  Remaining Estimate: 0h
>
> * API-only inclusion
> * JMS 2.0 objects throw UnsupportedOperationException



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (AMQ-7309) Add JMS 2.0 API support

2023-02-15 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/AMQ-7309?focusedWorklogId=845637=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-845637
 ]

ASF GitHub Bot logged work on AMQ-7309:
---

Author: ASF GitHub Bot
Created on: 15/Feb/23 13:33
Start Date: 15/Feb/23 13:33
Worklog Time Spent: 10m 
  Work Description: cshannon opened a new pull request, #978:
URL: https://github.com/apache/activemq/pull/978

   Adds a real implemention for createSession() and createSession(ackMode) 
methods on ActiveMQConnection




Issue Time Tracking
---

Worklog Id: (was: 845637)
Time Spent: 17.5h  (was: 17h 20m)

> Add JMS 2.0 API support
> ---
>
> Key: AMQ-7309
> URL: https://issues.apache.org/jira/browse/AMQ-7309
> Project: ActiveMQ
>  Issue Type: New Feature
>  Components: Broker, JMS client
>Reporter: Jean-Baptiste Onofré
>Assignee: Jean-Baptiste Onofré
>Priority: Major
>  Labels: #jms2
> Fix For: 5.18.0
>
>  Time Spent: 17.5h
>  Remaining Estimate: 0h
>
> * API-only inclusion
> * JMS 2.0 objects throw UnsupportedOperationException



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (ARTEMIS-4169) Auto detect dead-letter and expiry queues in the console

2023-02-15 Thread Domenico Francesco Bruscino (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Domenico Francesco Bruscino updated ARTEMIS-4169:
-
Description: 
The custom DLQ do not show some options/columns on hawtio. For this we have to 
configure "Dead-letter address regex" on the management console. 
The console browse plugin could auto-detect dead-letter and expiry queues by 
checking the `_AMQ_ORIG_QUEUE` property.

  was:
The custom DLQ do not show some options/columns on hawtio. For this we have to 
configure "Dead-letter address regex" on the management console. 
The console browse plugin could auto-detect detect dead-letter and expiry 
queues checkin the `_AMQ_ORIG_QUEUE` property.


> Auto detect dead-letter and expiry queues in the console
> 
>
> Key: ARTEMIS-4169
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4169
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Domenico Francesco Bruscino
>Assignee: Domenico Francesco Bruscino
>Priority: Major
>
> The custom DLQ do not show some options/columns on hawtio. For this we have 
> to configure "Dead-letter address regex" on the management console. 
> The console browse plugin could auto-detect dead-letter and expiry queues by 
> checking the `_AMQ_ORIG_QUEUE` property.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (ARTEMIS-4169) Auto detect dead-letter and expiry queues in the console

2023-02-15 Thread Domenico Francesco Bruscino (Jira)
Domenico Francesco Bruscino created ARTEMIS-4169:


 Summary: Auto detect dead-letter and expiry queues in the console
 Key: ARTEMIS-4169
 URL: https://issues.apache.org/jira/browse/ARTEMIS-4169
 Project: ActiveMQ Artemis
  Issue Type: Improvement
Reporter: Domenico Francesco Bruscino
Assignee: Domenico Francesco Bruscino


The custom DLQ do not show some options/columns on hawtio. For this we have to 
configure "Dead-letter address regex" on the management console. 
The console browse plugin could auto-detect detect dead-letter and expiry 
queues checkin the `_AMQ_ORIG_QUEUE` property.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (AMQ-9219) Add activemq-client-jakarta transition module for 5.17.x

2023-02-15 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/AMQ-9219?focusedWorklogId=845625=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-845625
 ]

ASF GitHub Bot logged work on AMQ-9219:
---

Author: ASF GitHub Bot
Created on: 15/Feb/23 12:05
Start Date: 15/Feb/23 12:05
Worklog Time Spent: 10m 
  Work Description: cshannon commented on PR #969:
URL: https://github.com/apache/activemq/pull/969#issuecomment-1431265035

   I just noticed https://github.com/apache/activemq/pull/968/files so maybe 
this PR just gets closed and we go with that one instead if not using this for 
5.17.x anymore




Issue Time Tracking
---

Worklog Id: (was: 845625)
Time Spent: 0.5h  (was: 20m)

> Add activemq-client-jakarta transition module for 5.17.x
> 
>
> Key: AMQ-9219
> URL: https://issues.apache.org/jira/browse/AMQ-9219
> Project: ActiveMQ
>  Issue Type: Task
>Reporter: Matt Pavlovich
>Assignee: Matt Pavlovich
>Priority: Major
> Fix For: 5.17.4
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> This module throws UnsupportedOperationException for all JMS 2.0 methods



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (AMQ-9219) Add activemq-client-jakarta transition module for 5.17.x

2023-02-15 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/AMQ-9219?focusedWorklogId=845613=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-845613
 ]

ASF GitHub Bot logged work on AMQ-9219:
---

Author: ASF GitHub Bot
Created on: 15/Feb/23 11:14
Start Date: 15/Feb/23 11:14
Worklog Time Spent: 10m 
  Work Description: cshannon commented on code in PR #969:
URL: https://github.com/apache/activemq/pull/969#discussion_r1106987705


##
activemq-client-jakarta/src/main/java/org/apache/activemq/command/ActiveMQMessage.java:
##
@@ -0,0 +1,808 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.command;
+
+import java.io.IOException;
+import java.io.UnsupportedEncodingException;
+import java.util.Enumeration;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Vector;
+
+import jakarta.jms.DeliveryMode;
+import jakarta.jms.Destination;
+import jakarta.jms.JMSException;
+import jakarta.jms.MessageFormatException;
+import jakarta.jms.MessageNotWriteableException;
+import jakarta.jms.XAJMSContext;
+
+import org.apache.activemq.ActiveMQConnection;
+import org.apache.activemq.ScheduledMessage;
+import org.apache.activemq.broker.scheduler.CronParser;
+import org.apache.activemq.filter.PropertyExpression;
+import org.apache.activemq.state.CommandVisitor;
+import org.apache.activemq.util.Callback;
+import org.apache.activemq.util.JMSExceptionSupport;
+import org.apache.activemq.util.TypeConversionSupport;
+import org.fusesource.hawtbuf.UTF8Buffer;
+
+/**
+ *
+ * @openwire:marshaller code="23"
+ */
+public class ActiveMQMessage extends Message implements 
org.apache.activemq.Message, ScheduledMessage {
+public static final byte DATA_STRUCTURE_TYPE = 
CommandTypes.ACTIVEMQ_MESSAGE;
+public static final String DLQ_DELIVERY_FAILURE_CAUSE_PROPERTY = 
"dlqDeliveryFailureCause";
+public static final String BROKER_PATH_PROPERTY = "JMSActiveMQBrokerPath";
+
+private static final Map JMS_PROPERTY_SETERS = new 
HashMap();
+
+protected transient Callback acknowledgeCallback;
+
+@Override
+public byte getDataStructureType() {
+return DATA_STRUCTURE_TYPE;
+}
+
+@Override
+public Message copy() {
+ActiveMQMessage copy = new ActiveMQMessage();
+copy(copy);
+return copy;
+}
+
+protected void copy(ActiveMQMessage copy) {
+super.copy(copy);
+copy.acknowledgeCallback = acknowledgeCallback;
+}
+
+@Override
+public int hashCode() {
+MessageId id = getMessageId();
+if (id != null) {
+return id.hashCode();
+} else {
+return super.hashCode();
+}
+}
+
+@Override
+public boolean equals(Object o) {
+if (this == o) {
+return true;
+}
+if (o == null || o.getClass() != getClass()) {
+return false;
+}
+
+ActiveMQMessage msg = (ActiveMQMessage) o;
+MessageId oMsg = msg.getMessageId();
+MessageId thisMsg = this.getMessageId();
+return thisMsg != null && oMsg != null && oMsg.equals(thisMsg);
+}
+
+@Override
+public void acknowledge() throws JMSException {
+if (acknowledgeCallback != null) {
+try {
+acknowledgeCallback.execute();
+} catch (JMSException e) {
+throw e;
+} catch (Throwable e) {
+throw JMSExceptionSupport.create(e);
+}
+}
+}
+
+@Override
+public void clearBody() throws JMSException {
+setContent(null);
+readOnlyBody = false;
+}
+
+@Override
+public String getJMSMessageID() {
+MessageId messageId = this.getMessageId();
+if (messageId == null) {
+return null;
+}
+return messageId.toString();
+}
+
+/**
+ * Seems to be invalid because the parameter doesn't initialize MessageId
+ * instance variables ProducerId and ProducerSequenceId
+ *
+ * @param value
+ * @throws JMSException
+ */
+@Override
+public void