[jira] [Updated] (AMQ-7283) ActiveMQ client uses the failover URL timeout retry does not print the INFO log
[ https://issues.apache.org/jira/browse/AMQ-7283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré updated AMQ-7283: -- Fix Version/s: 5.18.3 (was: 5.18.2) > ActiveMQ client uses the failover URL timeout retry does not print the INFO > log > --- > > Key: AMQ-7283 > URL: https://issues.apache.org/jira/browse/AMQ-7283 > Project: ActiveMQ > Issue Type: Improvement > Components: JMS client >Reporter: Lei Zhang >Assignee: Jean-Baptiste Onofré >Priority: Minor > Labels: easyfix > Fix For: 5.18.3 > > > When the ActiveMQ client uses the failover URL, timeout retry does not print > the INFO log, which is inconvenient to locate the problem.I recommend > printing the log on the first retry and printing a successful retry after > successful -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AMQ-7283) ActiveMQ client uses the failover URL timeout retry does not print the INFO log
[ https://issues.apache.org/jira/browse/AMQ-7283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735546#comment-17735546 ] Jean-Baptiste Onofré commented on AMQ-7283: --- The retry log message should be with WARN log level. I guess it's OK. What message are you referencing (just to be sure we are talking about the same thing) ? Thanks ! > ActiveMQ client uses the failover URL timeout retry does not print the INFO > log > --- > > Key: AMQ-7283 > URL: https://issues.apache.org/jira/browse/AMQ-7283 > Project: ActiveMQ > Issue Type: Improvement > Components: JMS client >Reporter: Lei Zhang >Assignee: Jean-Baptiste Onofré >Priority: Minor > Labels: easyfix > Fix For: 5.18.2 > > > When the ActiveMQ client uses the failover URL, timeout retry does not print > the INFO log, which is inconvenient to locate the problem.I recommend > printing the log on the first retry and printing a successful retry after > successful -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AMQ-5045) Make default directory for KahaDB consistent
[
https://issues.apache.org/jira/browse/AMQ-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735543#comment-17735543
]
Jean-Baptiste Onofré commented on AMQ-5045:
---
NB: both message store and locker should be updated. IMHO it's not a big deal
as the directory is passed via XML configuration (xbean), but it's fair point
(not urgent).
> Make default directory for KahaDB consistent
>
>
> Key: AMQ-5045
> URL: https://issues.apache.org/jira/browse/AMQ-5045
> Project: ActiveMQ
> Issue Type: Wish
> Components: Broker
>Affects Versions: 5.9.0
>Reporter: Martin Lichtin
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 5.19.0, 5.18.3
>
>
> http://activemq.apache.org/kahadb.html says that the default for property
> "directory" is "activemq-data".
> However, in the code it is
> public static final File DEFAULT_DIRECTORY = new File("KahaDB");
> Also, it would make sense to me if the KahaDB directory would be created
> inside the broker's "dataDirectory" property. This does not currently happen.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (AMQ-5045) Make default directory for KahaDB consistent
[
https://issues.apache.org/jira/browse/AMQ-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jean-Baptiste Onofré updated AMQ-5045:
--
Fix Version/s: 5.18.3
(was: 5.18.2)
> Make default directory for KahaDB consistent
>
>
> Key: AMQ-5045
> URL: https://issues.apache.org/jira/browse/AMQ-5045
> Project: ActiveMQ
> Issue Type: Wish
> Components: Broker
>Affects Versions: 5.9.0
>Reporter: Martin Lichtin
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 5.19.0, 5.18.3
>
>
> http://activemq.apache.org/kahadb.html says that the default for property
> "directory" is "activemq-data".
> However, in the code it is
> public static final File DEFAULT_DIRECTORY = new File("KahaDB");
> Also, it would make sense to me if the KahaDB directory would be created
> inside the broker's "dataDirectory" property. This does not currently happen.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (AMQ-9233) NPE in SubQueueSelectorCacheBroker.removeConsumer
[
https://issues.apache.org/jira/browse/AMQ-9233?focusedWorklogId=866614&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-866614
]
ASF GitHub Bot logged work on AMQ-9233:
---
Author: ASF GitHub Bot
Created on: 21/Jun/23 05:39
Start Date: 21/Jun/23 05:39
Worklog Time Spent: 10m
Work Description: jbonofre opened a new pull request, #1034:
URL: https://github.com/apache/activemq/pull/1034
(no comment)
Issue Time Tracking
---
Worklog Id: (was: 866614)
Remaining Estimate: 0h
Time Spent: 10m
> NPE in SubQueueSelectorCacheBroker.removeConsumer
> -
>
> Key: AMQ-9233
> URL: https://issues.apache.org/jira/browse/AMQ-9233
> Project: ActiveMQ
> Issue Type: Bug
>Affects Versions: 5.16.4
>Reporter: Matt Pavlovich
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 5.19.0, 5.18.2
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This NPE occurs after a number of cascading errors. Probably, the
> _selectors.size()_ needs a null check.
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.activemq.plugin.SubQueueSelectorCacheBroker.removeConsumer(SubQueueSelectorCacheBroker.java:183)[activemq-broker-5.16.4.jar:5.16.4]
> at
> org.apache.activemq.broker.BrokerFilter.removeConsumer(BrokerFilter.java:139)[activemq-broker-5.16.4.jar:5.16.4]
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4310) Smaller Container / Dockerfile based on Alpine
[
https://issues.apache.org/jira/browse/ARTEMIS-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735472#comment-17735472
]
Thorsten Hirsch commented on ARTEMIS-4310:
--
Unfortunately, the "Fast Tests" don't look so good at all:
{noformat}
[INFO] ActiveMQ Artemis JUnit 4 Rules . FAILURE [ 5.018
s]{noformat}
In the details I see a connection failure:
{noformat}
2023-06-20T17:19:51.6675248Z [Thread-0 (ActiveMQ-client-global-threads)]
17:19:51,666 WARN [org.apache.activemq.artemis.core.client] AMQ212037:
Connection failure to invm:0 has been detected: AMQ219015: The connection was
disconnected because of server shutdown [code=DISCONNECTED]{noformat}
And even before that there's a problem with libaio, just like Tapan Gupta
assumed:
{noformat}
2023-06-20T17:19:51.1686698Z [main] 17:19:51,168 INFO
[org.apache.activemq.artemis.core.server] AMQ221045: libaio is not available,
switching the configuration into NIO{noformat}
However, all these tests seem to have been run with a JDK 11 installation in
/opt instead of "my" JDK 17...
{noformat}
2023-06-20T17:16:12.5139116Z JAVA_HOME_11_X64:
/opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/11.0.19-7/x64{noformat}
So... is the failed test anyhow related to the Alpine/JDK17 image or not?
> Smaller Container / Dockerfile based on Alpine
> --
>
> Key: ARTEMIS-4310
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4310
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
>Affects Versions: 2.28.0
>Reporter: Thorsten Hirsch
>Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (ARTEMIS-4310) Smaller Container / Dockerfile based on Alpine
[
https://issues.apache.org/jira/browse/ARTEMIS-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735472#comment-17735472
]
Thorsten Hirsch edited comment on ARTEMIS-4310 at 6/20/23 10:45 PM:
Unfortunately, the "Fast Tests" don't look so good at all:
{noformat}
[INFO] ActiveMQ Artemis JUnit 4 Rules . FAILURE [ 5.018
s]{noformat}
In the details I see a connection failure:
{noformat}
2023-06-20T17:19:51.6675248Z [Thread-0 (ActiveMQ-client-global-threads)]
17:19:51,666 WARN [org.apache.activemq.artemis.core.client] AMQ212037:
Connection failure to invm:0 has been detected: AMQ219015: The connection was
disconnected because of server shutdown [code=DISCONNECTED]{noformat}
And even before that there's a problem with libaio, just like Tapan Gupta
assumed:
{noformat}
2023-06-20T17:19:51.1686698Z [main] 17:19:51,168 INFO
[org.apache.activemq.artemis.core.server] AMQ221045: libaio is not available,
switching the configuration into NIO{noformat}
However, all these tests seem to have been run with a JDK 11 installation in
/opt instead of "my" JDK 17...
{noformat}
2023-06-20T17:16:12.5139116Z JAVA_HOME_11_X64:
/opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/11.0.19-7/x64{noformat}
So... is the failed test anyhow related to the Alpine/JDK17 image or not?
was (Author: thorstenhirsch):
Unfortunately, the "Fast Tests" don't look so good at all:
{noformat}
[INFO] ActiveMQ Artemis JUnit 4 Rules . FAILURE [ 5.018
s]{noformat}
In the details I see a connection failure:
{noformat}
2023-06-20T17:19:51.6675248Z [Thread-0 (ActiveMQ-client-global-threads)]
17:19:51,666 WARN [org.apache.activemq.artemis.core.client] AMQ212037:
Connection failure to invm:0 has been detected: AMQ219015: The connection was
disconnected because of server shutdown [code=DISCONNECTED]{noformat}
And even before that there's a problem with libaio, just like Tapan Gupta
assumed:
{noformat}
2023-06-20T17:19:51.1686698Z [main] 17:19:51,168 INFO
[org.apache.activemq.artemis.core.server] AMQ221045: libaio is not available,
switching the configuration into NIO{noformat}
However, all these tests seem to have been run with a JDK 11 installation in
/opt instead of "my" JDK 17...
{noformat}
2023-06-20T17:16:12.5139116Z JAVA_HOME_11_X64:
/opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/11.0.19-7/x64{noformat}
So... is the failed test anyhow related to the Alpine/JDK17 image or not?
> Smaller Container / Dockerfile based on Alpine
> --
>
> Key: ARTEMIS-4310
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4310
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
>Affects Versions: 2.28.0
>Reporter: Thorsten Hirsch
>Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4310) Smaller Container / Dockerfile based on Alpine
[ https://issues.apache.org/jira/browse/ARTEMIS-4310?focusedWorklogId=866578&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-866578 ] ASF GitHub Bot logged work on ARTEMIS-4310: --- Author: ASF GitHub Bot Created on: 20/Jun/23 22:15 Start Date: 20/Jun/23 22:15 Worklog Time Spent: 10m Work Description: thorstenhirsch commented on code in PR #4504: URL: https://github.com/apache/activemq-artemis/pull/4504#discussion_r1235952240 ## artemis-docker/Dockerfile-alpine-17: ## @@ -0,0 +1,71 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# ActiveMQ Artemis + +FROM eclipse-temurin:17-jdk-alpine +LABEL maintainer="T. Hirsch" Review Comment: fixed Issue Time Tracking --- Worklog Id: (was: 866578) Time Spent: 1h 20m (was: 1h 10m) > Smaller Container / Dockerfile based on Alpine > -- > > Key: ARTEMIS-4310 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4310 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.28.0 >Reporter: Thorsten Hirsch >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4310) Smaller Container / Dockerfile based on Alpine
[ https://issues.apache.org/jira/browse/ARTEMIS-4310?focusedWorklogId=866554&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-866554 ] ASF GitHub Bot logged work on ARTEMIS-4310: --- Author: ASF GitHub Bot Created on: 20/Jun/23 18:18 Start Date: 20/Jun/23 18:18 Worklog Time Spent: 10m Work Description: jbertram commented on code in PR #4504: URL: https://github.com/apache/activemq-artemis/pull/4504#discussion_r1235648255 ## artemis-docker/Dockerfile-alpine-17: ## @@ -0,0 +1,71 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# ActiveMQ Artemis + +FROM eclipse-temurin:17-jdk-alpine +LABEL maintainer="T. Hirsch" Review Comment: This should be "Apache ActiveMQ Team" since you're contributing it to the project. Issue Time Tracking --- Worklog Id: (was: 866554) Time Spent: 1h 10m (was: 1h) > Smaller Container / Dockerfile based on Alpine > -- > > Key: ARTEMIS-4310 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4310 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Broker >Affects Versions: 2.28.0 >Reporter: Thorsten Hirsch >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4321) Upgrade Guava to 32.0.0-jre
[ https://issues.apache.org/jira/browse/ARTEMIS-4321?focusedWorklogId=866553&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-866553 ] ASF GitHub Bot logged work on ARTEMIS-4321: --- Author: ASF GitHub Bot Created on: 20/Jun/23 17:54 Start Date: 20/Jun/23 17:54 Worklog Time Spent: 10m Work Description: jbertram opened a new pull request, #4519: URL: https://github.com/apache/activemq-artemis/pull/4519 (no comment) Issue Time Tracking --- Worklog Id: (was: 866553) Remaining Estimate: 0h Time Spent: 10m > Upgrade Guava to 32.0.0-jre > --- > > Key: ARTEMIS-4321 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4321 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARTEMIS-4321) Upgrade Guava to 32.0.0-jre
Justin Bertram created ARTEMIS-4321: --- Summary: Upgrade Guava to 32.0.0-jre Key: ARTEMIS-4321 URL: https://issues.apache.org/jira/browse/ARTEMIS-4321 Project: ActiveMQ Artemis Issue Type: Dependency upgrade Reporter: Justin Bertram Assignee: Justin Bertram -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4320) Upgrade Netty to 4.1.94.Final
[ https://issues.apache.org/jira/browse/ARTEMIS-4320?focusedWorklogId=866552&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-866552 ] ASF GitHub Bot logged work on ARTEMIS-4320: --- Author: ASF GitHub Bot Created on: 20/Jun/23 17:52 Start Date: 20/Jun/23 17:52 Worklog Time Spent: 10m Work Description: jbertram opened a new pull request, #4518: URL: https://github.com/apache/activemq-artemis/pull/4518 (no comment) Issue Time Tracking --- Worklog Id: (was: 866552) Remaining Estimate: 0h Time Spent: 10m > Upgrade Netty to 4.1.94.Final > - > > Key: ARTEMIS-4320 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4320 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARTEMIS-4320) Upgrade Netty to 4.1.94.Final
Justin Bertram created ARTEMIS-4320: --- Summary: Upgrade Netty to 4.1.94.Final Key: ARTEMIS-4320 URL: https://issues.apache.org/jira/browse/ARTEMIS-4320 Project: ActiveMQ Artemis Issue Type: Dependency upgrade Reporter: Justin Bertram Assignee: Justin Bertram -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4277) Upgrade checkstyle
[ https://issues.apache.org/jira/browse/ARTEMIS-4277?focusedWorklogId=866548&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-866548 ] ASF GitHub Bot logged work on ARTEMIS-4277: --- Author: ASF GitHub Bot Created on: 20/Jun/23 17:04 Start Date: 20/Jun/23 17:04 Worklog Time Spent: 10m Work Description: gemmellr merged PR #4513: URL: https://github.com/apache/activemq-artemis/pull/4513 Issue Time Tracking --- Worklog Id: (was: 866548) Time Spent: 20m (was: 10m) > Upgrade checkstyle > -- > > Key: ARTEMIS-4277 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4277 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (ARTEMIS-4277) Upgrade checkstyle
[ https://issues.apache.org/jira/browse/ARTEMIS-4277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved ARTEMIS-4277. - Fix Version/s: 2.30.0 Resolution: Fixed > Upgrade checkstyle > -- > > Key: ARTEMIS-4277 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4277 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Fix For: 2.30.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4277) Upgrade checkstyle
[ https://issues.apache.org/jira/browse/ARTEMIS-4277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735379#comment-17735379 ] ASF subversion and git services commented on ARTEMIS-4277: -- Commit 69ae79ad84ab91192827a8f146ebda5e661453b1 in activemq-artemis's branch refs/heads/main from Justin Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=69ae79ad84 ] ARTEMIS-4277 upgrade checkstyle > Upgrade checkstyle > -- > > Key: ARTEMIS-4277 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4277 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4314) Federation, support consumerWindowSize zero and federate in batches only when the local queue is has excess capacity
[ https://issues.apache.org/jira/browse/ARTEMIS-4314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735374#comment-17735374 ] ASF subversion and git services commented on ARTEMIS-4314: -- Commit a8b4ee19928fbf0a0b2bff5baf649ace97edc967 in activemq-artemis's branch refs/heads/dependabot/maven/com.google.guava-guava-32.0.0-jre from Gary Tully [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=a8b4ee1992 ] ARTEMIS-4314 support queue federation batchOnCapacity via consumerWindowSize=0 > Federation, support consumerWindowSize zero and federate in batches only when > the local queue is has excess capacity > > > Key: ARTEMIS-4314 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4314 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Federation >Affects Versions: 2.29.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Fix For: 2.30.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > Dual queue federation, where clusters federate in both direction can suffer > from message flip flopping once the priority adjustment kicks in. > If there is a large backlog, the lower priority federation consumer is in > play once all of the local consumer credit is exhausted and the backlog can > drain to the other cluster. > If demand is low there, the process can repeat. limiting the rate of the > federation consumer can help but it is not ideal b/c when there is no local > demand, we want to have a high rate of migration. > > A possible solution is to have the federation consumer manage its own credit > and only flow messages when the local queue has capacity. Then flow a batch > of messages, and await again that the local queue has capacity. In this way, > there is no thundering herd effect, but there is also fast migration of > messages once there is demand. > the consumerWindowSize=0 is already in play for consumer.receive calls and > there is already a defaultConsumerWindowSize for an address. These can be > combined to realise batchFederationOnCapacity semantics. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4311) Strange typo propagated throughout the codebase: "Mesasge"
[ https://issues.apache.org/jira/browse/ARTEMIS-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735378#comment-17735378 ] ASF subversion and git services commented on ARTEMIS-4311: -- Commit b316272e145c9c96fc6adf274452eec52051675b in activemq-artemis's branch refs/heads/dependabot/maven/com.google.guava-guava-32.0.0-jre from Justin Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=b316272e14 ] ARTEMIS-4311 fix typo > Strange typo propagated throughout the codebase: "Mesasge" > -- > > Key: ARTEMIS-4311 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4311 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.29.0 >Reporter: Geert Schuring >Assignee: Justin Bertram >Priority: Minor > Fix For: 2.30.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Somehow the same typo appears in 23 files. See > [https://github.com/search?q=repo%3Aapache%2Factivemq-artemis%20mesasge&type=code] > Nothing major, but a bit cringe to see this in the config of every broker I > create :) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4316) Example HTML does not render correctly
[ https://issues.apache.org/jira/browse/ARTEMIS-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735377#comment-17735377 ] ASF subversion and git services commented on ARTEMIS-4316: -- Commit 42c93fc7d215c3ad7d18143d782649a1737219f6 in activemq-artemis's branch refs/heads/dependabot/maven/com.google.guava-guava-32.0.0-jre from Justin Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=42c93fc7d2 ] ARTEMIS-4316 fix example doc formatting This commit also updates the artifact used to generate the HTML from the MarkDown as the existing artifact is now defunct. > Example HTML does not render correctly > -- > > Key: ARTEMIS-4316 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4316 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.29.0 >Reporter: Geert Schuring >Assignee: Justin Bertram >Priority: Major > Labels: documentation, examples, html, rendering > Fix For: 2.30.0 > > Attachments: image-2023-06-16-10-43-45-924.png > > Time Spent: 20m > Remaining Estimate: 0h > > The HTML files in the examples do not render correctly. Especially the code > parts. For example, the Readme in the CDI example: > apache-artemis-2.28.0/examples/features/standard/cdi/readme.html > !image-2023-06-16-10-43-45-924.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4314) Federation, support consumerWindowSize zero and federate in batches only when the local queue is has excess capacity
[ https://issues.apache.org/jira/browse/ARTEMIS-4314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735375#comment-17735375 ] ASF subversion and git services commented on ARTEMIS-4314: -- Commit 9b5dbf42653f460a6f70e6a9c40b2c539cc09217 in activemq-artemis's branch refs/heads/dependabot/maven/com.google.guava-guava-32.0.0-jre from Gary Tully [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=9b5dbf4265 ] ARTEMIS-4314 - fix typo in doc > Federation, support consumerWindowSize zero and federate in batches only when > the local queue is has excess capacity > > > Key: ARTEMIS-4314 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4314 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Federation >Affects Versions: 2.29.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Fix For: 2.30.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > Dual queue federation, where clusters federate in both direction can suffer > from message flip flopping once the priority adjustment kicks in. > If there is a large backlog, the lower priority federation consumer is in > play once all of the local consumer credit is exhausted and the backlog can > drain to the other cluster. > If demand is low there, the process can repeat. limiting the rate of the > federation consumer can help but it is not ideal b/c when there is no local > demand, we want to have a high rate of migration. > > A possible solution is to have the federation consumer manage its own credit > and only flow messages when the local queue has capacity. Then flow a batch > of messages, and await again that the local queue has capacity. In this way, > there is no thundering herd effect, but there is also fast migration of > messages once there is demand. > the consumerWindowSize=0 is already in play for consumer.receive calls and > there is already a defaultConsumerWindowSize for an address. These can be > combined to realise batchFederationOnCapacity semantics. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4314) Federation, support consumerWindowSize zero and federate in batches only when the local queue is has excess capacity
[ https://issues.apache.org/jira/browse/ARTEMIS-4314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735376#comment-17735376 ] ASF subversion and git services commented on ARTEMIS-4314: -- Commit c6a82ff95ef94cd192fa17c515d535d42dbafb8e in activemq-artemis's branch refs/heads/dependabot/maven/com.google.guava-guava-32.0.0-jre from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=c6a82ff95e ] ARTEMIS-4314 Small Tweak: using executor directly if no delay > Federation, support consumerWindowSize zero and federate in batches only when > the local queue is has excess capacity > > > Key: ARTEMIS-4314 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4314 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Federation >Affects Versions: 2.29.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Fix For: 2.30.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > Dual queue federation, where clusters federate in both direction can suffer > from message flip flopping once the priority adjustment kicks in. > If there is a large backlog, the lower priority federation consumer is in > play once all of the local consumer credit is exhausted and the backlog can > drain to the other cluster. > If demand is low there, the process can repeat. limiting the rate of the > federation consumer can help but it is not ideal b/c when there is no local > demand, we want to have a high rate of migration. > > A possible solution is to have the federation consumer manage its own credit > and only flow messages when the local queue has capacity. Then flow a batch > of messages, and await again that the local queue has capacity. In this way, > there is no thundering herd effect, but there is also fast migration of > messages once there is demand. > the consumerWindowSize=0 is already in play for consumer.receive calls and > there is already a defaultConsumerWindowSize for an address. These can be > combined to realise batchFederationOnCapacity semantics. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (ARTEMIS-4311) Strange typo propagated throughout the codebase: "Mesasge"
[ https://issues.apache.org/jira/browse/ARTEMIS-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram resolved ARTEMIS-4311. - Resolution: Fixed > Strange typo propagated throughout the codebase: "Mesasge" > -- > > Key: ARTEMIS-4311 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4311 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.29.0 >Reporter: Geert Schuring >Assignee: Justin Bertram >Priority: Minor > Fix For: 2.30.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Somehow the same typo appears in 23 files. See > [https://github.com/search?q=repo%3Aapache%2Factivemq-artemis%20mesasge&type=code] > Nothing major, but a bit cringe to see this in the config of every broker I > create :) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4311) Strange typo propagated throughout the codebase: "Mesasge"
[ https://issues.apache.org/jira/browse/ARTEMIS-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram updated ARTEMIS-4311: Fix Version/s: 2.30.0 > Strange typo propagated throughout the codebase: "Mesasge" > -- > > Key: ARTEMIS-4311 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4311 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.29.0 >Reporter: Geert Schuring >Assignee: Justin Bertram >Priority: Minor > Fix For: 2.30.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Somehow the same typo appears in 23 files. See > [https://github.com/search?q=repo%3Aapache%2Factivemq-artemis%20mesasge&type=code] > Nothing major, but a bit cringe to see this in the config of every broker I > create :) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4316) Example HTML does not render correctly
[ https://issues.apache.org/jira/browse/ARTEMIS-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram updated ARTEMIS-4316: Affects Version/s: 2.29.0 (was: 2.28.0) > Example HTML does not render correctly > -- > > Key: ARTEMIS-4316 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4316 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.29.0 >Reporter: Geert Schuring >Assignee: Justin Bertram >Priority: Major > Labels: documentation, examples, html, rendering > Fix For: 2.30.0 > > Attachments: image-2023-06-16-10-43-45-924.png > > Time Spent: 20m > Remaining Estimate: 0h > > The HTML files in the examples do not render correctly. Especially the code > parts. For example, the Readme in the CDI example: > apache-artemis-2.28.0/examples/features/standard/cdi/readme.html > !image-2023-06-16-10-43-45-924.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4311) Strange typo propagated throughout the codebase: "Mesasge"
[ https://issues.apache.org/jira/browse/ARTEMIS-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram updated ARTEMIS-4311: Affects Version/s: 2.29.0 (was: 2.28.0) > Strange typo propagated throughout the codebase: "Mesasge" > -- > > Key: ARTEMIS-4311 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4311 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.29.0 >Reporter: Geert Schuring >Assignee: Justin Bertram >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > Somehow the same typo appears in 23 files. See > [https://github.com/search?q=repo%3Aapache%2Factivemq-artemis%20mesasge&type=code] > Nothing major, but a bit cringe to see this in the config of every broker I > create :) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4316) Example HTML does not render correctly
[ https://issues.apache.org/jira/browse/ARTEMIS-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram updated ARTEMIS-4316: Fix Version/s: 2.30.0 > Example HTML does not render correctly > -- > > Key: ARTEMIS-4316 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4316 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.28.0 >Reporter: Geert Schuring >Assignee: Justin Bertram >Priority: Major > Labels: documentation, examples, html, rendering > Fix For: 2.30.0 > > Attachments: image-2023-06-16-10-43-45-924.png > > Time Spent: 20m > Remaining Estimate: 0h > > The HTML files in the examples do not render correctly. Especially the code > parts. For example, the Readme in the CDI example: > apache-artemis-2.28.0/examples/features/standard/cdi/readme.html > !image-2023-06-16-10-43-45-924.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (ARTEMIS-4316) Example HTML does not render correctly
[ https://issues.apache.org/jira/browse/ARTEMIS-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Bertram resolved ARTEMIS-4316. - Resolution: Fixed > Example HTML does not render correctly > -- > > Key: ARTEMIS-4316 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4316 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.29.0 >Reporter: Geert Schuring >Assignee: Justin Bertram >Priority: Major > Labels: documentation, examples, html, rendering > Fix For: 2.30.0 > > Attachments: image-2023-06-16-10-43-45-924.png > > Time Spent: 20m > Remaining Estimate: 0h > > The HTML files in the examples do not render correctly. Especially the code > parts. For example, the Readme in the CDI example: > apache-artemis-2.28.0/examples/features/standard/cdi/readme.html > !image-2023-06-16-10-43-45-924.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4311) Strange typo propagated throughout the codebase: "Mesasge"
[ https://issues.apache.org/jira/browse/ARTEMIS-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735367#comment-17735367 ] ASF subversion and git services commented on ARTEMIS-4311: -- Commit b316272e145c9c96fc6adf274452eec52051675b in activemq-artemis's branch refs/heads/main from Justin Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=b316272e14 ] ARTEMIS-4311 fix typo > Strange typo propagated throughout the codebase: "Mesasge" > -- > > Key: ARTEMIS-4311 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4311 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.28.0 >Reporter: Geert Schuring >Assignee: Justin Bertram >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > Somehow the same typo appears in 23 files. See > [https://github.com/search?q=repo%3Aapache%2Factivemq-artemis%20mesasge&type=code] > Nothing major, but a bit cringe to see this in the config of every broker I > create :) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4311) Strange typo propagated throughout the codebase: "Mesasge"
[ https://issues.apache.org/jira/browse/ARTEMIS-4311?focusedWorklogId=866545&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-866545 ] ASF GitHub Bot logged work on ARTEMIS-4311: --- Author: ASF GitHub Bot Created on: 20/Jun/23 16:50 Start Date: 20/Jun/23 16:50 Worklog Time Spent: 10m Work Description: gemmellr merged PR #4515: URL: https://github.com/apache/activemq-artemis/pull/4515 Issue Time Tracking --- Worklog Id: (was: 866545) Time Spent: 40m (was: 0.5h) > Strange typo propagated throughout the codebase: "Mesasge" > -- > > Key: ARTEMIS-4311 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4311 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.28.0 >Reporter: Geert Schuring >Assignee: Justin Bertram >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > Somehow the same typo appears in 23 files. See > [https://github.com/search?q=repo%3Aapache%2Factivemq-artemis%20mesasge&type=code] > Nothing major, but a bit cringe to see this in the config of every broker I > create :) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4316) Example HTML does not render correctly
[ https://issues.apache.org/jira/browse/ARTEMIS-4316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735350#comment-17735350 ] ASF subversion and git services commented on ARTEMIS-4316: -- Commit 42c93fc7d215c3ad7d18143d782649a1737219f6 in activemq-artemis's branch refs/heads/main from Justin Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=42c93fc7d2 ] ARTEMIS-4316 fix example doc formatting This commit also updates the artifact used to generate the HTML from the MarkDown as the existing artifact is now defunct. > Example HTML does not render correctly > -- > > Key: ARTEMIS-4316 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4316 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.28.0 >Reporter: Geert Schuring >Assignee: Justin Bertram >Priority: Major > Labels: documentation, examples, html, rendering > Attachments: image-2023-06-16-10-43-45-924.png > > Time Spent: 20m > Remaining Estimate: 0h > > The HTML files in the examples do not render correctly. Especially the code > parts. For example, the Readme in the CDI example: > apache-artemis-2.28.0/examples/features/standard/cdi/readme.html > !image-2023-06-16-10-43-45-924.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4316) Example HTML does not render correctly
[ https://issues.apache.org/jira/browse/ARTEMIS-4316?focusedWorklogId=866540&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-866540 ] ASF GitHub Bot logged work on ARTEMIS-4316: --- Author: ASF GitHub Bot Created on: 20/Jun/23 16:05 Start Date: 20/Jun/23 16:05 Worklog Time Spent: 10m Work Description: brusdev merged PR #4514: URL: https://github.com/apache/activemq-artemis/pull/4514 Issue Time Tracking --- Worklog Id: (was: 866540) Time Spent: 20m (was: 10m) > Example HTML does not render correctly > -- > > Key: ARTEMIS-4316 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4316 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.28.0 >Reporter: Geert Schuring >Assignee: Justin Bertram >Priority: Major > Labels: documentation, examples, html, rendering > Attachments: image-2023-06-16-10-43-45-924.png > > Time Spent: 20m > Remaining Estimate: 0h > > The HTML files in the examples do not render correctly. Especially the code > parts. For example, the Readme in the CDI example: > apache-artemis-2.28.0/examples/features/standard/cdi/readme.html > !image-2023-06-16-10-43-45-924.png! -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4318) Architecture documentation links to deprecated library "Airline"
[ https://issues.apache.org/jira/browse/ARTEMIS-4318?focusedWorklogId=866521&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-866521 ] ASF GitHub Bot logged work on ARTEMIS-4318: --- Author: ASF GitHub Bot Created on: 20/Jun/23 14:28 Start Date: 20/Jun/23 14:28 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4516: URL: https://github.com/apache/activemq-artemis/pull/4516#issuecomment-1598904008 I'm trying to get in touch with the repo's owner Rob Vesse to see about this. He's actually a committer and PMC member of Apache Jena so that's encouraging. Issue Time Tracking --- Worklog Id: (was: 866521) Time Spent: 40m (was: 0.5h) > Architecture documentation links to deprecated library "Airline" > > > Key: ARTEMIS-4318 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4318 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.28.0 >Reporter: Geert Schuring >Assignee: Justin Bertram >Priority: Major > Labels: deprecated, documentation, library > Time Spent: 40m > Remaining Estimate: 0h > > There's a link on this page (under "Stand-alone Broker") to a project called > "Airline" which is deprecated: > https://activemq.apache.org/components/artemis/documentation/latest/architecture.html -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4311) Strange typo propagated throughout the codebase: "Mesasge"
[
https://issues.apache.org/jira/browse/ARTEMIS-4311?focusedWorklogId=866497&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-866497
]
ASF GitHub Bot logged work on ARTEMIS-4311:
---
Author: ASF GitHub Bot
Created on: 20/Jun/23 12:46
Start Date: 20/Jun/23 12:46
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4515:
URL: https://github.com/apache/activemq-artemis/pull/4515#discussion_r1235209364
##
docs/user-manual/en/message-grouping.md:
##
@@ -89,7 +89,7 @@ However if you really do want to close a group you can add a
negative sequence n
Example:
```java
-Mesasge message = session.createTextMessage("hey");
+message message = session.createTextMessage("hey");
Review Comment:
Should be upper case M to match the interface type.
Issue Time Tracking
---
Worklog Id: (was: 866497)
Time Spent: 0.5h (was: 20m)
> Strange typo propagated throughout the codebase: "Mesasge"
> --
>
> Key: ARTEMIS-4311
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4311
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.28.0
>Reporter: Geert Schuring
>Assignee: Justin Bertram
>Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Somehow the same typo appears in 23 files. See
> [https://github.com/search?q=repo%3Aapache%2Factivemq-artemis%20mesasge&type=code]
> Nothing major, but a bit cringe to see this in the config of every broker I
> create :)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4314) Federation, support consumerWindowSize zero and federate in batches only when the local queue is has excess capacity
[ https://issues.apache.org/jira/browse/ARTEMIS-4314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated ARTEMIS-4314: Fix Version/s: 2.30.0 (was: 2.29.0) Affects Version/s: 2.29.0 (was: 2.28.0) Updated versions to reflect this missed 2.29.0 and so will later be in 2.30.0. > Federation, support consumerWindowSize zero and federate in batches only when > the local queue is has excess capacity > > > Key: ARTEMIS-4314 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4314 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Federation >Affects Versions: 2.29.0 >Reporter: Gary Tully >Assignee: Gary Tully >Priority: Major > Fix For: 2.30.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > Dual queue federation, where clusters federate in both direction can suffer > from message flip flopping once the priority adjustment kicks in. > If there is a large backlog, the lower priority federation consumer is in > play once all of the local consumer credit is exhausted and the backlog can > drain to the other cluster. > If demand is low there, the process can repeat. limiting the rate of the > federation consumer can help but it is not ideal b/c when there is no local > demand, we want to have a high rate of migration. > > A possible solution is to have the federation consumer manage its own credit > and only flow messages when the local queue has capacity. Then flow a batch > of messages, and await again that the local queue has capacity. In this way, > there is no thundering herd effect, but there is also fast migration of > messages once there is demand. > the consumerWindowSize=0 is already in play for consumer.receive calls and > there is already a defaultConsumerWindowSize for an address. These can be > combined to realise batchFederationOnCapacity semantics. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4242) closing session with recent 'async acks' can lead to exceptions from apparent consumer cleanup race
[
https://issues.apache.org/jira/browse/ARTEMIS-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735211#comment-17735211
]
Robbie Gemmell commented on ARTEMIS-4242:
-
Reopened as the change made was not to fix the issue, per previous comment.
> closing session with recent 'async acks' can lead to exceptions from apparent
> consumer cleanup race
> ---
>
> Key: ARTEMIS-4242
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4242
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.28.0, 2.29.0
>Reporter: Robbie Gemmell
>Priority: Major
>
> (Title is a little bit of a guess based on what a test is doing, the
> exceptions logged as a result, and the fact it poisoned a subsequent test).
> Closing a session with recent 'async acks' from using option
> 'blockOnAcknowledge=false' appears to lead to possible exceptions on the
> broker (snippet later), seemingly from a race between consumer cleanup during
> this, and processing of the previous acknowledgements.
> AcknowledgementTest.testNonBlockingAckPerf sends messages and then consumes
> them two seperate queues with 'blockOnAcknowledge=false' and
> 'blockOnAcknowledge=true' and compares duration. When it is done consuming,
> it closes the session (but not consumer) and connection. Invariably, it logs
> stacktraces like below during execution of this test (not obvious from
> default output, but is when turning on some debug instrumentation of which
> test is starting/stopping). After this happens, the test that follows would
> fail due to finding an extra message on a queue (queue1) they both used (this
> was reported in ARTEMIS-4082 against testDupsOKAcknowledgeQueue).
> Changing AcknowledgementTest.testNonBlockingAckPerf to closely inspect the
> counts after it is main work is finished, it then fails sporadically as or
> more often than it was causing testDupsOKAcknowledgeQueue to fail. Siilarly,
> isolating testNonBlockingAckPerf to its own queues looks to stop
> testDupsOKAcknowledgeQueue sporadically failing, which is what will be done
> here initially.
> Example output during failure in recent run:
> https://github.com/apache/activemq-artemis/actions/runs/4691971133/jobs/8317110969#step:5:33384
> {noformat}
> [Thread-0
> (ActiveMQ-remoting-threads-ActiveMQServerImpl::name=localhost-195163481)]
> 17:20:43,422 WARN [org.apache.activemq.artemis.core.server] AMQ222061:
> Client connection failed, clearing up resources for session
> 855206e2-da1f-11ed-8303-000d3aa462b0
> [Thread-0
> (ActiveMQ-remoting-threads-ActiveMQServerImpl::name=localhost-195163481)]
> 17:20:43,430 WARN [org.apache.activemq.artemis.core.server] AMQ222107:
> Cleared up resources for session 855206e2-da1f-11ed-8303-000d3aa462b0
> [Thread-7
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$6@fd46303)]
> 17:20:43,446 ERROR [org.apache.activemq.artemis.core.server] AMQ224016:
> Caught exception
> org.apache.activemq.artemis.api.core.ActiveMQIllegalStateException:
> AMQ229028: Consumer 0 doesn't exist on the server
> at
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl.findConsumer(ServerSessionImpl.java:1267)
> ~[artemis-server-2.29.0-SNAPSHOT.jar:2.29.0-SNAPSHOT]
> at
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl.acknowledge(ServerSessionImpl.java:1234)
> ~[artemis-server-2.29.0-SNAPSHOT.jar:2.29.0-SNAPSHOT]
> at
> org.apache.activemq.artemis.core.protocol.core.ServerSessionPacketHandler.onSessionAcknowledge(ServerSessionPacketHandler.java:762)
> ~[artemis-server-2.29.0-SNAPSHOT.jar:2.29.0-SNAPSHOT]
> at
> org.apache.activemq.artemis.core.protocol.core.ServerSessionPacketHandler.onMessagePacket(ServerSessionPacketHandler.java:302)
> ~[artemis-server-2.29.0-SNAPSHOT.jar:2.29.0-SNAPSHOT]
> at org.apache.activemq.artemis.utils.actors.Actor.doTask(Actor.java:32)
> ~[artemis-commons-2.29.0-SNAPSHOT.jar:?]
> at
> org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:68)
> ~[artemis-commons-2.29.0-SNAPSHOT.jar:?]
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:57)
> ~[artemis-commons-2.29.0-SNAPSHOT.jar:?]
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:32)
> ~[artemis-commons-2.29.0-SNAPSHOT.jar:?]
> at
> org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:68)
> ~[artemis-commons-2.29.0-SNAPSHOT.jar:?]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
> ~[?:?]
> at
> java.util.concurrent.ThreadPoolExecu
[jira] [Updated] (ARTEMIS-4242) closing session with recent 'async acks' can lead to exceptions from apparent consumer cleanup race
[
https://issues.apache.org/jira/browse/ARTEMIS-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robbie Gemmell updated ARTEMIS-4242:
Affects Version/s: 2.29.0
> closing session with recent 'async acks' can lead to exceptions from apparent
> consumer cleanup race
> ---
>
> Key: ARTEMIS-4242
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4242
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.28.0, 2.29.0
>Reporter: Robbie Gemmell
>Priority: Major
>
> (Title is a little bit of a guess based on what a test is doing, the
> exceptions logged as a result, and the fact it poisoned a subsequent test).
> Closing a session with recent 'async acks' from using option
> 'blockOnAcknowledge=false' appears to lead to possible exceptions on the
> broker (snippet later), seemingly from a race between consumer cleanup during
> this, and processing of the previous acknowledgements.
> AcknowledgementTest.testNonBlockingAckPerf sends messages and then consumes
> them two seperate queues with 'blockOnAcknowledge=false' and
> 'blockOnAcknowledge=true' and compares duration. When it is done consuming,
> it closes the session (but not consumer) and connection. Invariably, it logs
> stacktraces like below during execution of this test (not obvious from
> default output, but is when turning on some debug instrumentation of which
> test is starting/stopping). After this happens, the test that follows would
> fail due to finding an extra message on a queue (queue1) they both used (this
> was reported in ARTEMIS-4082 against testDupsOKAcknowledgeQueue).
> Changing AcknowledgementTest.testNonBlockingAckPerf to closely inspect the
> counts after it is main work is finished, it then fails sporadically as or
> more often than it was causing testDupsOKAcknowledgeQueue to fail. Siilarly,
> isolating testNonBlockingAckPerf to its own queues looks to stop
> testDupsOKAcknowledgeQueue sporadically failing, which is what will be done
> here initially.
> Example output during failure in recent run:
> https://github.com/apache/activemq-artemis/actions/runs/4691971133/jobs/8317110969#step:5:33384
> {noformat}
> [Thread-0
> (ActiveMQ-remoting-threads-ActiveMQServerImpl::name=localhost-195163481)]
> 17:20:43,422 WARN [org.apache.activemq.artemis.core.server] AMQ222061:
> Client connection failed, clearing up resources for session
> 855206e2-da1f-11ed-8303-000d3aa462b0
> [Thread-0
> (ActiveMQ-remoting-threads-ActiveMQServerImpl::name=localhost-195163481)]
> 17:20:43,430 WARN [org.apache.activemq.artemis.core.server] AMQ222107:
> Cleared up resources for session 855206e2-da1f-11ed-8303-000d3aa462b0
> [Thread-7
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$6@fd46303)]
> 17:20:43,446 ERROR [org.apache.activemq.artemis.core.server] AMQ224016:
> Caught exception
> org.apache.activemq.artemis.api.core.ActiveMQIllegalStateException:
> AMQ229028: Consumer 0 doesn't exist on the server
> at
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl.findConsumer(ServerSessionImpl.java:1267)
> ~[artemis-server-2.29.0-SNAPSHOT.jar:2.29.0-SNAPSHOT]
> at
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl.acknowledge(ServerSessionImpl.java:1234)
> ~[artemis-server-2.29.0-SNAPSHOT.jar:2.29.0-SNAPSHOT]
> at
> org.apache.activemq.artemis.core.protocol.core.ServerSessionPacketHandler.onSessionAcknowledge(ServerSessionPacketHandler.java:762)
> ~[artemis-server-2.29.0-SNAPSHOT.jar:2.29.0-SNAPSHOT]
> at
> org.apache.activemq.artemis.core.protocol.core.ServerSessionPacketHandler.onMessagePacket(ServerSessionPacketHandler.java:302)
> ~[artemis-server-2.29.0-SNAPSHOT.jar:2.29.0-SNAPSHOT]
> at org.apache.activemq.artemis.utils.actors.Actor.doTask(Actor.java:32)
> ~[artemis-commons-2.29.0-SNAPSHOT.jar:?]
> at
> org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:68)
> ~[artemis-commons-2.29.0-SNAPSHOT.jar:?]
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:57)
> ~[artemis-commons-2.29.0-SNAPSHOT.jar:?]
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:32)
> ~[artemis-commons-2.29.0-SNAPSHOT.jar:?]
> at
> org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:68)
> ~[artemis-commons-2.29.0-SNAPSHOT.jar:?]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
> ~[?:?]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
> ~[?:?]
> at
> org.apache.activemq.artemis.utils.Ac
[jira] [Reopened] (ARTEMIS-4242) closing session with recent 'async acks' can lead to exceptions from apparent consumer cleanup race
[
https://issues.apache.org/jira/browse/ARTEMIS-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robbie Gemmell reopened ARTEMIS-4242:
-
> closing session with recent 'async acks' can lead to exceptions from apparent
> consumer cleanup race
> ---
>
> Key: ARTEMIS-4242
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4242
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.28.0
>Reporter: Robbie Gemmell
>Priority: Major
>
> (Title is a little bit of a guess based on what a test is doing, the
> exceptions logged as a result, and the fact it poisoned a subsequent test).
> Closing a session with recent 'async acks' from using option
> 'blockOnAcknowledge=false' appears to lead to possible exceptions on the
> broker (snippet later), seemingly from a race between consumer cleanup during
> this, and processing of the previous acknowledgements.
> AcknowledgementTest.testNonBlockingAckPerf sends messages and then consumes
> them two seperate queues with 'blockOnAcknowledge=false' and
> 'blockOnAcknowledge=true' and compares duration. When it is done consuming,
> it closes the session (but not consumer) and connection. Invariably, it logs
> stacktraces like below during execution of this test (not obvious from
> default output, but is when turning on some debug instrumentation of which
> test is starting/stopping). After this happens, the test that follows would
> fail due to finding an extra message on a queue (queue1) they both used (this
> was reported in ARTEMIS-4082 against testDupsOKAcknowledgeQueue).
> Changing AcknowledgementTest.testNonBlockingAckPerf to closely inspect the
> counts after it is main work is finished, it then fails sporadically as or
> more often than it was causing testDupsOKAcknowledgeQueue to fail. Siilarly,
> isolating testNonBlockingAckPerf to its own queues looks to stop
> testDupsOKAcknowledgeQueue sporadically failing, which is what will be done
> here initially.
> Example output during failure in recent run:
> https://github.com/apache/activemq-artemis/actions/runs/4691971133/jobs/8317110969#step:5:33384
> {noformat}
> [Thread-0
> (ActiveMQ-remoting-threads-ActiveMQServerImpl::name=localhost-195163481)]
> 17:20:43,422 WARN [org.apache.activemq.artemis.core.server] AMQ222061:
> Client connection failed, clearing up resources for session
> 855206e2-da1f-11ed-8303-000d3aa462b0
> [Thread-0
> (ActiveMQ-remoting-threads-ActiveMQServerImpl::name=localhost-195163481)]
> 17:20:43,430 WARN [org.apache.activemq.artemis.core.server] AMQ222107:
> Cleared up resources for session 855206e2-da1f-11ed-8303-000d3aa462b0
> [Thread-7
> (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$6@fd46303)]
> 17:20:43,446 ERROR [org.apache.activemq.artemis.core.server] AMQ224016:
> Caught exception
> org.apache.activemq.artemis.api.core.ActiveMQIllegalStateException:
> AMQ229028: Consumer 0 doesn't exist on the server
> at
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl.findConsumer(ServerSessionImpl.java:1267)
> ~[artemis-server-2.29.0-SNAPSHOT.jar:2.29.0-SNAPSHOT]
> at
> org.apache.activemq.artemis.core.server.impl.ServerSessionImpl.acknowledge(ServerSessionImpl.java:1234)
> ~[artemis-server-2.29.0-SNAPSHOT.jar:2.29.0-SNAPSHOT]
> at
> org.apache.activemq.artemis.core.protocol.core.ServerSessionPacketHandler.onSessionAcknowledge(ServerSessionPacketHandler.java:762)
> ~[artemis-server-2.29.0-SNAPSHOT.jar:2.29.0-SNAPSHOT]
> at
> org.apache.activemq.artemis.core.protocol.core.ServerSessionPacketHandler.onMessagePacket(ServerSessionPacketHandler.java:302)
> ~[artemis-server-2.29.0-SNAPSHOT.jar:2.29.0-SNAPSHOT]
> at org.apache.activemq.artemis.utils.actors.Actor.doTask(Actor.java:32)
> ~[artemis-commons-2.29.0-SNAPSHOT.jar:?]
> at
> org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:68)
> ~[artemis-commons-2.29.0-SNAPSHOT.jar:?]
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:57)
> ~[artemis-commons-2.29.0-SNAPSHOT.jar:?]
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:32)
> ~[artemis-commons-2.29.0-SNAPSHOT.jar:?]
> at
> org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:68)
> ~[artemis-commons-2.29.0-SNAPSHOT.jar:?]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
> ~[?:?]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
> ~[?:?]
> at
> org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQTh
