[jira] [Work logged] (ARTEMIS-4362) Produce a logger when consumers are holding too many messages not allowing deposing
[
https://issues.apache.org/jira/browse/ARTEMIS-4362?focusedWorklogId=870680=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870680
]
ASF GitHub Bot logged work on ARTEMIS-4362:
---
Author: ASF GitHub Bot
Created on: 12/Jul/23 20:52
Start Date: 12/Jul/23 20:52
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4552:
URL: https://github.com/apache/activemq-artemis/pull/4552#discussion_r1261713360
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java:
##
@@ -3298,8 +3306,28 @@ private boolean needsDepage() {
return queueMemorySize.getSize() <
pageSubscription.getPagingStore().getMaxSize() &&
intermediateMessageReferences.size() + messageReferences.size() <
MAX_DEPAGE_NUM;
} else {
- return (maxReadBytes <= 0 || (queueMemorySize.getSize() +
deliveringMetrics.getPersistentSize()) < maxReadBytes) &&
+ boolean needsDepageResult = (maxReadBytes <= 0 ||
(queueMemorySize.getSize() + deliveringMetrics.getPersistentSize()) <
maxReadBytes) &&
(maxReadMessages <= 0 || (queueMemorySize.getElements() +
deliveringMetrics.getMessageCount()) < maxReadMessages);
+
+ if (!needsDepageResult) {
+if (!pageFlowControlled && (maxReadBytes > 0 &&
deliveringMetrics.getPersistentSize() >= maxReadBytes || maxReadMessages > 0 &&
deliveringMetrics.getMessageCount() >= maxReadMessages)) {
+ if (System.currentTimeMillis() - pageFlowControlledLastLog >
PAGE_FLOW_CONTROL_PRINT_INTERVAL) {
+ pageFlowControlledLastLog = System.currentTimeMillis();
+
ActiveMQServerLogger.LOGGER.warnPageFlowControl(String.valueOf(name),
String.valueOf(address), deliveringMetrics.getMessageCount(),
deliveringMetrics.getPersistentSize(), maxReadMessages, maxReadBytes);
+ }
+ if (logger.isDebugEnabled()) {
+ logger.warn("Queue {}/Address {} is currently delivering {}
messages that are holding {} bytes, with max sizes configured at
addressSettings.maxPageReadMessages={} and addressSettings.maxPageReadBytes={}.
System will not read more data from paging until acks are made. " +
Review Comment:
logger.debug!
Issue Time Tracking
---
Worklog Id: (was: 870680)
Time Spent: 20m (was: 10m)
> Produce a logger when consumers are holding too many messages not allowing
> deposing
> ---
>
> Key: ARTEMIS-4362
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4362
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Clebert Suconic
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We should add a log.warn whenever the system can't read more messages because
> consumers are holding too many messages in pending state.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4362) Produce a logger when consumers are holding too many messages not allowing deposing
[ https://issues.apache.org/jira/browse/ARTEMIS-4362?focusedWorklogId=870676=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870676 ] ASF GitHub Bot logged work on ARTEMIS-4362: --- Author: ASF GitHub Bot Created on: 12/Jul/23 20:47 Start Date: 12/Jul/23 20:47 Worklog Time Spent: 10m Work Description: clebertsuconic opened a new pull request, #4552: URL: https://github.com/apache/activemq-artemis/pull/4552 (no comment) Issue Time Tracking --- Worklog Id: (was: 870676) Remaining Estimate: 0h Time Spent: 10m > Produce a logger when consumers are holding too many messages not allowing > deposing > --- > > Key: ARTEMIS-4362 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4362 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Clebert Suconic >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > We should add a log.warn whenever the system can't read more messages because > consumers are holding too many messages in pending state. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARTEMIS-4362) Produce a logger when consumers are holding too many messages not allowing deposing
Clebert Suconic created ARTEMIS-4362: Summary: Produce a logger when consumers are holding too many messages not allowing deposing Key: ARTEMIS-4362 URL: https://issues.apache.org/jira/browse/ARTEMIS-4362 Project: ActiveMQ Artemis Issue Type: Improvement Reporter: Clebert Suconic We should add a log.warn whenever the system can't read more messages because consumers are holding too many messages in pending state. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4360) Make compatibility-tests opt in with -Pcompatibility-tests
[ https://issues.apache.org/jira/browse/ARTEMIS-4360?focusedWorklogId=870668=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870668 ] ASF GitHub Bot logged work on ARTEMIS-4360: --- Author: ASF GitHub Bot Created on: 12/Jul/23 19:38 Start Date: 12/Jul/23 19:38 Worklog Time Spent: 10m Work Description: clebertsuconic commented on code in PR #4551: URL: https://github.com/apache/activemq-artemis/pull/4551#discussion_r1261647498 ## pom.xml: ## @@ -1287,6 +1286,12 @@ false + + compatibility-tests Review Comment: @gemmellr I thought about doing it the way you mentioned.. but it is how the other properties are defined.. so I kept the way it's currently done. I thought it would be easier to manage the other skips. Issue Time Tracking --- Worklog Id: (was: 870668) Time Spent: 3h (was: 2h 50m) > Make compatibility-tests opt in with -Pcompatibility-tests > -- > > Key: ARTEMIS-4360 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4360 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.30.0 > > Time Spent: 3h > Remaining Estimate: 0h > > we should make compatibility-tests opt-in. from now on you have to use > -Pcompatibility-tests to run them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4360) Make compatibility-tests opt in with -Pcompatibility-tests
[ https://issues.apache.org/jira/browse/ARTEMIS-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742537#comment-17742537 ] ASF subversion and git services commented on ARTEMIS-4360: -- Commit 8429b8a4abf36f8bd83b11d3d6c26302e29bbeaa in activemq-artemis's branch refs/heads/main from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=8429b8a4ab ] ARTEMIS-4360 removing skipCompatibilityTests from fast-tests > Make compatibility-tests opt in with -Pcompatibility-tests > -- > > Key: ARTEMIS-4360 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4360 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.30.0 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > we should make compatibility-tests opt-in. from now on you have to use > -Pcompatibility-tests to run them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4360) Make compatibility-tests opt in with -Pcompatibility-tests
[ https://issues.apache.org/jira/browse/ARTEMIS-4360?focusedWorklogId=870667=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870667 ] ASF GitHub Bot logged work on ARTEMIS-4360: --- Author: ASF GitHub Bot Created on: 12/Jul/23 19:32 Start Date: 12/Jul/23 19:32 Worklog Time Spent: 10m Work Description: clebertsuconic commented on code in PR #4551: URL: https://github.com/apache/activemq-artemis/pull/4551#discussion_r1261642294 ## pom.xml: ## @@ -1276,7 +1276,6 @@ false false false -false Review Comment: ouch! thanks! Issue Time Tracking --- Worklog Id: (was: 870667) Time Spent: 2h 50m (was: 2h 40m) > Make compatibility-tests opt in with -Pcompatibility-tests > -- > > Key: ARTEMIS-4360 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4360 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.30.0 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > we should make compatibility-tests opt-in. from now on you have to use > -Pcompatibility-tests to run them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4361) MQTT subscription that fails auth leaves behind address and queue
[
https://issues.apache.org/jira/browse/ARTEMIS-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Bertram updated ARTEMIS-4361:
Description:
When an MQTT client tries to create a subscription that is rejected due to auth
failure an address and queue are created and left behind.
For example, client ID {{client1}} subscribes to {{#}} then the {{#}} address
is created with a {{client1.#}} queue; this queue will quickly fill up with
messages (as it captures all messages).
{{MQTTSubscriptionManager::addSubscription()}} creates the queue for the
subscription but {{createConsumerForSubscriptionQueue()}} call throws an
{{ActiveMQSecurityException}} when auth rejected; the created queue is not then
cleaned up.
I'm using a wildcard address settings via config to cleanup these created
queues, like this, but not a viable solution for all use cases:
{code:java}
config.addAddressSetting(wildcardConfiguration.getAnyWordsString(),
new AddressSettings()
.setAutoDeleteCreatedQueues(true)
.setAutoDeleteAddressesDelay(1)
.setAutoDeleteQueuesMessageCount(-1L)
);{code}
But this does not seem like good default behaviour as these leaked queues can
quickly fill up with messages.
was:
When an MQTT client tries to create a subscription that is rejected due to auth
failure an address and queue are created and left behind.
For example client ID `client1` subscribes to `#` then the `#` address is
created with a `client1.#` queue; this queue will quickly fill up with messages
(as it captures all messages).
`MQTTSubscriptionManager::addSubscription()` creates the queue for the
subscription but `createConsumerForSubscriptionQueue()` call throws an
`ActiveMQSecurityException` when auth rejected; the created queue is not then
cleaned up.
I'm using a wildcard address settings via config to cleanup these created
queues, like this, but not a viable solution for all use cases:
{code:java}
config.addAddressSetting(wildcardConfiguration.getAnyWordsString(),
new AddressSettings()
.setAutoDeleteCreatedQueues(true)
.setAutoDeleteAddressesDelay(1)
.setAutoDeleteQueuesMessageCount(-1L)
);{code}
But this does not seem like good default behaviour as these leaked queues can
quickly fill up with messages
> MQTT subscription that fails auth leaves behind address and queue
> -
>
> Key: ARTEMIS-4361
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4361
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: MQTT
>Affects Versions: 2.26.0
>Reporter: Rich T
>Assignee: Justin Bertram
>Priority: Major
>
> When an MQTT client tries to create a subscription that is rejected due to
> auth failure an address and queue are created and left behind.
> For example, client ID {{client1}} subscribes to {{#}} then the {{#}} address
> is created with a {{client1.#}} queue; this queue will quickly fill up with
> messages (as it captures all messages).
> {{MQTTSubscriptionManager::addSubscription()}} creates the queue for the
> subscription but {{createConsumerForSubscriptionQueue()}} call throws an
> {{ActiveMQSecurityException}} when auth rejected; the created queue is not
> then cleaned up.
> I'm using a wildcard address settings via config to cleanup these created
> queues, like this, but not a viable solution for all use cases:
>
> {code:java}
> config.addAddressSetting(wildcardConfiguration.getAnyWordsString(),
> new AddressSettings()
> .setAutoDeleteCreatedQueues(true)
> .setAutoDeleteAddressesDelay(1)
> .setAutoDeleteQueuesMessageCount(-1L)
> );{code}
> But this does not seem like good default behaviour as these leaked queues can
> quickly fill up with messages.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4361) MQTT subscription that fails auth leaves behind address and queue
[
https://issues.apache.org/jira/browse/ARTEMIS-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742531#comment-17742531
]
Rich T commented on ARTEMIS-4361:
-
Oh great I will upgrade and check it out thanks!
> MQTT subscription that fails auth leaves behind address and queue
> -
>
> Key: ARTEMIS-4361
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4361
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: MQTT
>Affects Versions: 2.26.0
>Reporter: Rich T
>Assignee: Justin Bertram
>Priority: Major
>
> When an MQTT client tries to create a subscription that is rejected due to
> auth failure an address and queue are created and left behind.
> For example client ID `client1` subscribes to `#` then the `#` address is
> created with a `client1.#` queue; this queue will quickly fill up with
> messages (as it captures all messages).
> `MQTTSubscriptionManager::addSubscription()` creates the queue for the
> subscription but `createConsumerForSubscriptionQueue()` call throws an
> `ActiveMQSecurityException` when auth rejected; the created queue is not then
> cleaned up.
> I'm using a wildcard address settings via config to cleanup these created
> queues, like this, but not a viable solution for all use cases:
>
> {code:java}
> config.addAddressSetting(wildcardConfiguration.getAnyWordsString(),
> new AddressSettings()
> .setAutoDeleteCreatedQueues(true)
> .setAutoDeleteAddressesDelay(1)
> .setAutoDeleteQueuesMessageCount(-1L)
> );{code}
>
>
> But this does not seem like good default behaviour as these leaked queues can
> quickly fill up with messages
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (ARTEMIS-4361) MQTT subscription that fails auth leaves behind address and queue
[
https://issues.apache.org/jira/browse/ARTEMIS-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Bertram reassigned ARTEMIS-4361:
---
Assignee: Justin Bertram
> MQTT subscription that fails auth leaves behind address and queue
> -
>
> Key: ARTEMIS-4361
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4361
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: MQTT
>Affects Versions: 2.26.0
>Reporter: Rich T
>Assignee: Justin Bertram
>Priority: Major
>
> When an MQTT client tries to create a subscription that is rejected due to
> auth failure an address and queue are created and left behind.
> For example client ID `client1` subscribes to `#` then the `#` address is
> created with a `client1.#` queue; this queue will quickly fill up with
> messages (as it captures all messages).
> `MQTTSubscriptionManager::addSubscription()` creates the queue for the
> subscription but `createConsumerForSubscriptionQueue()` call throws an
> `ActiveMQSecurityException` when auth rejected; the created queue is not then
> cleaned up.
> I'm using a wildcard address settings via config to cleanup these created
> queues, like this, but not a viable solution for all use cases:
>
> {code:java}
> config.addAddressSetting(wildcardConfiguration.getAnyWordsString(),
> new AddressSettings()
> .setAutoDeleteCreatedQueues(true)
> .setAutoDeleteAddressesDelay(1)
> .setAutoDeleteQueuesMessageCount(-1L)
> );{code}
>
>
> But this does not seem like good default behaviour as these leaked queues can
> quickly fill up with messages
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4361) MQTT subscription that fails auth leaves behind address and queue
[
https://issues.apache.org/jira/browse/ARTEMIS-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742529#comment-17742529
]
Justin Bertram commented on ARTEMIS-4361:
-
I believe this was already resolved in 2.29.0 via ARTEMIS-4249.
> MQTT subscription that fails auth leaves behind address and queue
> -
>
> Key: ARTEMIS-4361
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4361
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: MQTT
>Affects Versions: 2.26.0
>Reporter: Rich T
>Priority: Major
>
> When an MQTT client tries to create a subscription that is rejected due to
> auth failure an address and queue are created and left behind.
> For example client ID `client1` subscribes to `#` then the `#` address is
> created with a `client1.#` queue; this queue will quickly fill up with
> messages (as it captures all messages).
> `MQTTSubscriptionManager::addSubscription()` creates the queue for the
> subscription but `createConsumerForSubscriptionQueue()` call throws an
> `ActiveMQSecurityException` when auth rejected; the created queue is not then
> cleaned up.
> I'm using a wildcard address settings via config to cleanup these created
> queues, like this, but not a viable solution for all use cases:
>
> {code:java}
> config.addAddressSetting(wildcardConfiguration.getAnyWordsString(),
> new AddressSettings()
> .setAutoDeleteCreatedQueues(true)
> .setAutoDeleteAddressesDelay(1)
> .setAutoDeleteQueuesMessageCount(-1L)
> );{code}
>
>
> But this does not seem like good default behaviour as these leaked queues can
> quickly fill up with messages
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (ARTEMIS-4361) MQTT subscription that fails auth leaves behind address and queue
[
https://issues.apache.org/jira/browse/ARTEMIS-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Bertram resolved ARTEMIS-4361.
-
Resolution: Duplicate
> MQTT subscription that fails auth leaves behind address and queue
> -
>
> Key: ARTEMIS-4361
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4361
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: MQTT
>Affects Versions: 2.26.0
>Reporter: Rich T
>Priority: Major
>
> When an MQTT client tries to create a subscription that is rejected due to
> auth failure an address and queue are created and left behind.
> For example client ID `client1` subscribes to `#` then the `#` address is
> created with a `client1.#` queue; this queue will quickly fill up with
> messages (as it captures all messages).
> `MQTTSubscriptionManager::addSubscription()` creates the queue for the
> subscription but `createConsumerForSubscriptionQueue()` call throws an
> `ActiveMQSecurityException` when auth rejected; the created queue is not then
> cleaned up.
> I'm using a wildcard address settings via config to cleanup these created
> queues, like this, but not a viable solution for all use cases:
>
> {code:java}
> config.addAddressSetting(wildcardConfiguration.getAnyWordsString(),
> new AddressSettings()
> .setAutoDeleteCreatedQueues(true)
> .setAutoDeleteAddressesDelay(1)
> .setAutoDeleteQueuesMessageCount(-1L)
> );{code}
>
>
> But this does not seem like good default behaviour as these leaked queues can
> quickly fill up with messages
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4353) Clean up Maven dependencies
[
https://issues.apache.org/jira/browse/ARTEMIS-4353?focusedWorklogId=870665=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870665
]
ASF GitHub Bot logged work on ARTEMIS-4353:
---
Author: ASF GitHub Bot
Created on: 12/Jul/23 19:17
Start Date: 12/Jul/23 19:17
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4544:
URL: https://github.com/apache/activemq-artemis/pull/4544#discussion_r1261628995
##
artemis-quorum-ri/src/test/java/org/apache/activemq/artemis/quorum/DistributedLockTest.java:
##
@@ -222,7 +219,7 @@ public void timedTryLockFailAfterTimeout() throws
ExecutionException, Interrupte
final long timeoutSec = 1;
Assert.assertFalse(manager.getDistributedLock("a").tryLock(timeoutSec,
TimeUnit.SECONDS));
final long elapsed = TimeUnit.NANOSECONDS.toSeconds(System.nanoTime() -
start);
- assertThat(elapsed, greaterThanOrEqualTo(timeoutSec));
+ Assert.assertTrue(elapsed >= timeoutSec);
Review Comment:
I agree that Hamcrest provides better messages when assertions fail,
although there are huge number of vague uses of `assertTrue` throughout the
code-base. I've added messages where I thought it made sense or changed
`assertTrue` to `assertEquals` to get an automated message which is more useful.
Issue Time Tracking
---
Worklog Id: (was: 870665)
Time Spent: 2h (was: 1h 50m)
> Clean up Maven dependencies
> ---
>
> Key: ARTEMIS-4353
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4353
> Project: ActiveMQ Artemis
> Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Over time module dependencies can grow stale with declared dependencies which
> are never used and used dependencies which are not declared (i.e.
> transitive). Such is the case with most of the modules in Artemis.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4361) MQTT subscription that fails auth leaves behind address and queue
[
https://issues.apache.org/jira/browse/ARTEMIS-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rich T updated ARTEMIS-4361:
Description:
When an MQTT client tries to create a subscription that is rejected due to auth
failure an address and queue are created and left behind.
For example client ID `client1` subscribes to `#` then the `#` address is
created with a `client1.#` queue; this queue will quickly fill up with messages
(as it captures all messages).
`MQTTSubscriptionManager::addSubscription()` creates the queue for the
subscription but `createConsumerForSubscriptionQueue()` call throws an
`ActiveMQSecurityException` when auth rejected; the created queue is not then
cleaned up.
I'm using a wildcard address settings via config to cleanup these created
queues, like this, but not a viable solution for all use cases:
{code:java}
config.addAddressSetting(wildcardConfiguration.getAnyWordsString(),
new AddressSettings()
.setAutoDeleteCreatedQueues(true)
.setAutoDeleteAddressesDelay(1)
.setAutoDeleteQueuesMessageCount(-1L)
);{code}
But this does not seem like good default behaviour as these leaked queues can
quickly fill up with messages
was:
When an MQTT client tries to create a subscription that is rejected due to auth
failure an address and queue are created and left behind.
For example client ID `client1` subscribes to `#` then the `#` address is
created with a `client1.#` queue; this queue will quickly fill up with messages
(as it captures all messages).
`MQTTSubscriptionManager::addSubscription()` creates the queue for the
subscription but `createConsumerForSubscriptionQueue()` call throws an
`ActiveMQSecurityException` when auth rejected; the created queue is not then
cleaned up.
I was hoping I could use a wildcard address settings via config to cleanup
these created queues, like this, but it doesn't seem to clean them up:
{code:java}
config.addAddressSetting(wildcardConfiguration.getAnyWordsString(),
new AddressSettings()
.setAutoDeleteCreatedQueues(true)
.setAutoDeleteAddressesDelay(0)
.setAutoDeleteQueuesMessageCount(-1L)
);{code}
But this does not seem like good default behaviour as these leaked queues can
quickly fill up with messages
> MQTT subscription that fails auth leaves behind address and queue
> -
>
> Key: ARTEMIS-4361
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4361
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: MQTT
>Affects Versions: 2.26.0
>Reporter: Rich T
>Priority: Major
>
> When an MQTT client tries to create a subscription that is rejected due to
> auth failure an address and queue are created and left behind.
> For example client ID `client1` subscribes to `#` then the `#` address is
> created with a `client1.#` queue; this queue will quickly fill up with
> messages (as it captures all messages).
> `MQTTSubscriptionManager::addSubscription()` creates the queue for the
> subscription but `createConsumerForSubscriptionQueue()` call throws an
> `ActiveMQSecurityException` when auth rejected; the created queue is not then
> cleaned up.
> I'm using a wildcard address settings via config to cleanup these created
> queues, like this, but not a viable solution for all use cases:
>
> {code:java}
> config.addAddressSetting(wildcardConfiguration.getAnyWordsString(),
> new AddressSettings()
> .setAutoDeleteCreatedQueues(true)
> .setAutoDeleteAddressesDelay(1)
> .setAutoDeleteQueuesMessageCount(-1L)
> );{code}
>
>
> But this does not seem like good default behaviour as these leaked queues can
> quickly fill up with messages
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4361) MQTT subscription that fails auth leaves behind address and queue
[
https://issues.apache.org/jira/browse/ARTEMIS-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rich T updated ARTEMIS-4361:
Description:
When an MQTT client tries to create a subscription that is rejected due to auth
failure an address and queue are created and left behind.
For example client ID `client1` subscribes to `#` then the `#` address is
created with a `client1.#` queue; this queue will quickly fill up with messages
(as it captures all messages).
`MQTTSubscriptionManager::addSubscription()` creates the queue for the
subscription but `createConsumerForSubscriptionQueue()` call throws an
`ActiveMQSecurityException` when auth rejected; the created queue is not then
cleaned up.
I was hoping I could use a wildcard address settings via config to cleanup
these created queues, like this, but it doesn't seem to clean them up:
{code:java}
config.addAddressSetting(wildcardConfiguration.getAnyWordsString(),
new AddressSettings()
.setAutoDeleteCreatedQueues(true)
.setAutoDeleteAddressesDelay(0)
.setAutoDeleteQueuesMessageCount(-1L)
);{code}
But this does not seem like good default behaviour as these leaked queues can
quickly fill up with messages
was:
When an MQTT client tries to create a subscription that is rejected due to auth
failure an address and queue are created and left behind.
For example client ID `client1` subscribes to `#` then the `#` address is
created with a `client1.#` queue; this queue will quickly fill up with messages
(as it captures all messages).
`MQTTSubscriptionManager::addSubscription()` creates the queue for the
subscription but `createConsumerForSubscriptionQueue()` call throws an
`ActiveMQSecurityException` when auth rejected; the created queue is not then
cleaned up.
I am hoping I can use a wildcard address settings via config to cleanup these
created queues; I'm using embedded instance so something like:
{code:java}
config.addAddressSetting(wildcardConfiguration.getAnyWordsString(),
new AddressSettings()
.setAutoDeleteCreatedQueues(true)
.setAutoDeleteAddressesDelay(0)
.setAutoDeleteQueuesMessageCount(-1L)
);{code}
But this does not seem like good default behaviour as these leaked queues can
quickly fill up with messages
> MQTT subscription that fails auth leaves behind address and queue
> -
>
> Key: ARTEMIS-4361
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4361
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: MQTT
>Affects Versions: 2.26.0
>Reporter: Rich T
>Priority: Major
>
> When an MQTT client tries to create a subscription that is rejected due to
> auth failure an address and queue are created and left behind.
> For example client ID `client1` subscribes to `#` then the `#` address is
> created with a `client1.#` queue; this queue will quickly fill up with
> messages (as it captures all messages).
> `MQTTSubscriptionManager::addSubscription()` creates the queue for the
> subscription but `createConsumerForSubscriptionQueue()` call throws an
> `ActiveMQSecurityException` when auth rejected; the created queue is not then
> cleaned up.
> I was hoping I could use a wildcard address settings via config to cleanup
> these created queues, like this, but it doesn't seem to clean them up:
>
> {code:java}
> config.addAddressSetting(wildcardConfiguration.getAnyWordsString(),
> new AddressSettings()
> .setAutoDeleteCreatedQueues(true)
> .setAutoDeleteAddressesDelay(0)
> .setAutoDeleteQueuesMessageCount(-1L)
> );{code}
>
>
> But this does not seem like good default behaviour as these leaked queues can
> quickly fill up with messages
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (ARTEMIS-4361) MQTT subscription that fails auth leaves behind address and queue
Rich T created ARTEMIS-4361:
---
Summary: MQTT subscription that fails auth leaves behind address
and queue
Key: ARTEMIS-4361
URL: https://issues.apache.org/jira/browse/ARTEMIS-4361
Project: ActiveMQ Artemis
Issue Type: Bug
Components: MQTT
Affects Versions: 2.26.0
Reporter: Rich T
When an MQTT client tries to create a subscription that is rejected due to auth
failure an address and queue are created and left behind.
For example client ID `client1` subscribes to `#` then the `#` address is
created with a `client1.#` queue; this queue will quickly fill up with messages
(as it captures all messages).
`MQTTSubscriptionManager::addSubscription()` creates the queue for the
subscription but `createConsumerForSubscriptionQueue()` call throws an
`ActiveMQSecurityException` when auth rejected; the created queue is not then
cleaned up.
I am hoping I can use a wildcard address settings via config to cleanup these
created queues; I'm using embedded instance so something like:
{code:java}
config.addAddressSetting(wildcardConfiguration.getAnyWordsString(),
new AddressSettings()
.setAutoDeleteCreatedQueues(true)
.setAutoDeleteAddressesDelay(0)
.setAutoDeleteQueuesMessageCount(-1L)
);{code}
But this does not seem like good default behaviour as these leaked queues can
quickly fill up with messages
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4360) Make compatibility-tests opt in with -Pcompatibility-tests
[ https://issues.apache.org/jira/browse/ARTEMIS-4360?focusedWorklogId=870651=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870651 ] ASF GitHub Bot logged work on ARTEMIS-4360: --- Author: ASF GitHub Bot Created on: 12/Jul/23 17:17 Start Date: 12/Jul/23 17:17 Worklog Time Spent: 10m Work Description: gemmellr commented on code in PR #4551: URL: https://github.com/apache/activemq-artemis/pull/4551#discussion_r1261481072 ## pom.xml: ## @@ -1287,6 +1286,12 @@ false + + compatibility-tests Review Comment: Would prefer this profile was in the compatibility-tests module. Well, it is already there...would prefer the property was redefined in the modules profile rather than splitting it. Issue Time Tracking --- Worklog Id: (was: 870651) Time Spent: 2h 40m (was: 2.5h) > Make compatibility-tests opt in with -Pcompatibility-tests > -- > > Key: ARTEMIS-4360 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4360 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.30.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > we should make compatibility-tests opt-in. from now on you have to use > -Pcompatibility-tests to run them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4360) Make compatibility-tests opt in with -Pcompatibility-tests
[ https://issues.apache.org/jira/browse/ARTEMIS-4360?focusedWorklogId=870650=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870650 ] ASF GitHub Bot logged work on ARTEMIS-4360: --- Author: ASF GitHub Bot Created on: 12/Jul/23 17:17 Start Date: 12/Jul/23 17:17 Worklog Time Spent: 10m Work Description: gemmellr commented on code in PR #4551: URL: https://github.com/apache/activemq-artemis/pull/4551#discussion_r1261482609 ## pom.xml: ## @@ -1276,7 +1276,6 @@ false false false -false Review Comment: You left it set not-skipped/enabled in the fast-tests profile. ## pom.xml: ## @@ -1287,6 +1286,12 @@ false + + compatibility-tests Review Comment: Would prefer this profile was in the compatibility-tests module. Well, it is already there...would prefer the property was redefined in the module. Issue Time Tracking --- Worklog Id: (was: 870650) Time Spent: 2.5h (was: 2h 20m) > Make compatibility-tests opt in with -Pcompatibility-tests > -- > > Key: ARTEMIS-4360 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4360 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.30.0 > > Time Spent: 2.5h > Remaining Estimate: 0h > > we should make compatibility-tests opt-in. from now on you have to use > -Pcompatibility-tests to run them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4360) Make compatibility-tests opt in with -Pcompatibility-tests
[ https://issues.apache.org/jira/browse/ARTEMIS-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742488#comment-17742488 ] ASF subversion and git services commented on ARTEMIS-4360: -- Commit c9f2f53b88a32e3a80a543b76b71959d18f59a24 in activemq-artemis's branch refs/heads/main from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=c9f2f53b88 ] ARTEMIS-4360 Make compatibility-tests opt in with -Pcompatibility-tests > Make compatibility-tests opt in with -Pcompatibility-tests > -- > > Key: ARTEMIS-4360 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4360 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.30.0 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > we should make compatibility-tests opt-in. from now on you have to use > -Pcompatibility-tests to run them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4360) Make compatibility-tests opt in with -Pcompatibility-tests
[ https://issues.apache.org/jira/browse/ARTEMIS-4360?focusedWorklogId=870648=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870648 ] ASF GitHub Bot logged work on ARTEMIS-4360: --- Author: ASF GitHub Bot Created on: 12/Jul/23 16:46 Start Date: 12/Jul/23 16:46 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #4551: URL: https://github.com/apache/activemq-artemis/pull/4551 Issue Time Tracking --- Worklog Id: (was: 870648) Time Spent: 2h 20m (was: 2h 10m) > Make compatibility-tests opt in with -Pcompatibility-tests > -- > > Key: ARTEMIS-4360 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4360 > Project: ActiveMQ Artemis > Issue Type: Task >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.30.0 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > we should make compatibility-tests opt-in. from now on you have to use > -Pcompatibility-tests to run them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4353) Clean up Maven dependencies
[
https://issues.apache.org/jira/browse/ARTEMIS-4353?focusedWorklogId=870647=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870647
]
ASF GitHub Bot logged work on ARTEMIS-4353:
---
Author: ASF GitHub Bot
Created on: 12/Jul/23 16:42
Start Date: 12/Jul/23 16:42
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #4544:
URL: https://github.com/apache/activemq-artemis/pull/4544#discussion_r1261447705
##
artemis-junit/artemis-junit-5/pom.xml:
##
@@ -57,12 +57,7 @@
org.apache.activemq
- artemis-jms-server
- ${project.version}
-
-
- org.apache.activemq
- artemis-jms-client
Review Comment:
I see your point about the module providing the client to the depender to
make testing easier. I think that's fair.
Issue Time Tracking
---
Worklog Id: (was: 870647)
Time Spent: 1h 50m (was: 1h 40m)
> Clean up Maven dependencies
> ---
>
> Key: ARTEMIS-4353
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4353
> Project: ActiveMQ Artemis
> Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Over time module dependencies can grow stale with declared dependencies which
> are never used and used dependencies which are not declared (i.e.
> transitive). Such is the case with most of the modules in Artemis.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4340) fix artemis-journal ThreadLocalByteBufferPool.borrow zeroing
[ https://issues.apache.org/jira/browse/ARTEMIS-4340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742478#comment-17742478 ] David Hoffer commented on ARTEMIS-4340: --- Do you have an ETA when 2.30.0 will be released? This is a blocking issue for us, so need it as soon as possible. > fix artemis-journal ThreadLocalByteBufferPool.borrow zeroing > > > Key: ARTEMIS-4340 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4340 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.22.0, 2.29.0 > Environment: Windows 10, Linux >Reporter: David Hoffer >Assignee: Robbie Gemmell >Priority: Major > Fix For: 2.30.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Report was made (see below) about ByteUtil.uncheckedZeros throwing > IndexOutOfBoundsException. Though some of ByteUtil's behaviour can perhaps be > questioned, the problem ultimately starts earlier in the call tree with > ThreadLocalByteBufferPool.borrow(int, boolean) from artemis-journal passing > it invalid arguments. It passed in a buffer for zeroing, with its limit still > set below the requested size to be zero'd, leading to the > IndexOutOfBoundsException when trying to write beyond the limit. > The reason this seemingly long-standing bug has perhaps not been hit so far > is that it occurs in a less typical fallback case, where the buffer either > isnt direct _and_ able to be updated with Netty's Unsafe bits, or also > doesn't have an array. > ThreadLocalByteBufferPool should clear position+limit before zeroing the > buffer. > > Original Description: > = > In artemis-commons: > ByteUtil.uncheckedZeros throws IndexOutOfBoundsException in the else part of > the method. > The code in the else part is looping through number of bytes specified by > bytes input parameter which is often provided by buffer.capacity(), but then > the code at > buffer.put(i + offset, zero) where buffer is of DirectByteBuffer type calls > checkIndex(int i) and it throws if i is >= limit. > But limit is not the same as capacity in a Buffer. In our case capacity is > 4096 and limit is 16 so method always throws IndexOutOfBoundsException if the > else case is executed as soon as i ==16. > This code is called when Artemis is launched and it validates/creates the > various bindings files. This causes Artemis to fail to load properly. > Note I believe all versions of artemis-commons has this bug but I currently > am testing with 2.22.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4356) address match with wildcards seems to be broken
[
https://issues.apache.org/jira/browse/ARTEMIS-4356?focusedWorklogId=870630=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870630
]
ASF GitHub Bot logged work on ARTEMIS-4356:
---
Author: ASF GitHub Bot
Created on: 12/Jul/23 15:19
Start Date: 12/Jul/23 15:19
Worklog Time Spent: 10m
Work Description: gtully commented on code in PR #4549:
URL: https://github.com/apache/activemq-artemis/pull/4549#discussion_r1261342410
##
artemis-server/src/test/java/org/apache/activemq/artemis/core/settings/impl/MatchTest.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.core.settings.impl;
+
+import java.util.function.Predicate;
+import java.util.regex.Pattern;
+
+import org.apache.activemq.artemis.core.config.WildcardConfiguration;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class MatchTest {
+
+ @Test
+ public void predicateTestAnyChild() {
+
+ final Match underTest = new Match<>("test.#", null, new
WildcardConfiguration());
+ final Predicate predicate = underTest.getPattern().asPredicate();
+
+ Assert.assertTrue(predicate.test("test"));
+ Assert.assertTrue(predicate.test("test.A"));
+ Assert.assertTrue(predicate.test("test.A.B"));
+
+ Assert.assertFalse(predicate.test("testing.A"));
+ }
+
+ @Test
+ public void predicateTestAnyWord() {
+
+ final Match underTest = new Match<>("test.*", null, new
WildcardConfiguration());
+ final Predicate predicate = underTest.getPattern().asPredicate();
+
+ Assert.assertTrue(predicate.test("test.A"));
+
+ Assert.assertFalse(predicate.test("testing.A"));
+ Assert.assertFalse(predicate.test("test"));
+ Assert.assertFalse(predicate.test("test.A.B"));
+ }
+
+ @Test
+ public void patterDirectAnyChild() {
+
+ final Pattern pattern = Match.createPattern("test.#", new
WildcardConfiguration(), true);
+ final Predicate predicate = pattern.asPredicate();
+
+ Assert.assertTrue(predicate.test("test.A"));
+ Assert.assertTrue(predicate.test("test.A.B"));
+
+ Assert.assertFalse(predicate.test("testing.A"));
+ Assert.assertFalse(predicate.test("test")); // Is this correct?
Review Comment:
@jbertram this particular difference, I wonder if it is intentional?
Issue Time Tracking
---
Worklog Id: (was: 870630)
Time Spent: 0.5h (was: 20m)
> address match with wildcards seems to be broken
> ---
>
> Key: ARTEMIS-4356
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4356
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.29.0
>Reporter: Gary Tully
>Assignee: Gary Tully
>Priority: Major
> Fix For: 2.30.0
>
> Attachments: MatchTest.java
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Using a wildcard address include match in federation, include test.# is too
> lenient which points to a bug in the address settings matcher that is in play.
>
> the attached test shows the problem.
> {{final Match underTest = new Match<>("test.#", null, new
> WildcardConfiguration());}}
> {{Predicate predicate = underTest.getPattern().asPredicate();}}
> {{assertTrue(predicate.test("test.A"));}}
> {{assertFalse(predicate.test("testing.A"));}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4360) Make compatibility-tests opt in with -Pcompatibility-tests
[
https://issues.apache.org/jira/browse/ARTEMIS-4360?focusedWorklogId=870625=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870625
]
ASF GitHub Bot logged work on ARTEMIS-4360:
---
Author: ASF GitHub Bot
Created on: 12/Jul/23 14:59
Start Date: 12/Jul/23 14:59
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4551:
URL: https://github.com/apache/activemq-artemis/pull/4551#discussion_r1261314980
##
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/base/ClasspathBase.java:
##
@@ -181,7 +179,15 @@ protected ClassLoader getClasspath(String name, boolean
forceNew) throws Excepti
classPathValue = buffer.toString();
}
- Assert.assertTrue("Cannot run compatibility tests, no classpath found on
./target/" + name + ".cp", classPathValue != null &&
!classPathValue.trim().equals(""));
+ boolean foundClassPath = classPathValue != null &&
!classPathValue.trim().equals("");
+
+ if (!foundClassPath) {
+ logger.info("Rebuild project with -Pcompatibility-tests. Cannot find
classpath definition for {}", name);
+ }
+
+ Assume.assumeTrue("Rebuild project with -Pcompatibility-tests.",
foundClassPath);
+
+ Assume.assumeTrue("Rebuild project with -Pcompatibility-tests to be able
to run this test. No classpath found on ./target/" + name + ".cp",
foundClassPath);
Review Comment:
tests are not running if I just do:
mvn -Pcompatibility-tests from ./tests/compatibility-tests
I'm fixing it.
Issue Time Tracking
---
Worklog Id: (was: 870625)
Time Spent: 2h 10m (was: 2h)
> Make compatibility-tests opt in with -Pcompatibility-tests
> --
>
> Key: ARTEMIS-4360
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4360
> Project: ActiveMQ Artemis
> Issue Type: Task
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.30.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> we should make compatibility-tests opt-in. from now on you have to use
> -Pcompatibility-tests to run them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4360) Make compatibility-tests opt in with -Pcompatibility-tests
[
https://issues.apache.org/jira/browse/ARTEMIS-4360?focusedWorklogId=870623=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870623
]
ASF GitHub Bot logged work on ARTEMIS-4360:
---
Author: ASF GitHub Bot
Created on: 12/Jul/23 14:49
Start Date: 12/Jul/23 14:49
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4551:
URL: https://github.com/apache/activemq-artemis/pull/4551#discussion_r1261295183
##
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/base/ClasspathBase.java:
##
@@ -181,7 +179,15 @@ protected ClassLoader getClasspath(String name, boolean
forceNew) throws Excepti
classPathValue = buffer.toString();
}
- Assert.assertTrue("Cannot run compatibility tests, no classpath found on
./target/" + name + ".cp", classPathValue != null &&
!classPathValue.trim().equals(""));
+ boolean foundClassPath = classPathValue != null &&
!classPathValue.trim().equals("");
+
+ if (!foundClassPath) {
+ logger.info("Rebuild project with -Pcompatibility-tests. Cannot find
classpath definition for {}", name);
+ }
+
+ Assume.assumeTrue("Rebuild project with -Pcompatibility-tests.",
foundClassPath);
+
+ Assume.assumeTrue("Rebuild project with -Pcompatibility-tests to be able
to run this test. No classpath found on ./target/" + name + ".cp",
foundClassPath);
Review Comment:
@gemmellr PR has what I intend to merge now (apart from having to remove the
DO-NOT-MERGE commit as I'm validating if the PR can handle the failure).
Issue Time Tracking
---
Worklog Id: (was: 870623)
Time Spent: 2h (was: 1h 50m)
> Make compatibility-tests opt in with -Pcompatibility-tests
> --
>
> Key: ARTEMIS-4360
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4360
> Project: ActiveMQ Artemis
> Issue Type: Task
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.30.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> we should make compatibility-tests opt-in. from now on you have to use
> -Pcompatibility-tests to run them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4360) Make compatibility-tests opt in with -Pcompatibility-tests
[
https://issues.apache.org/jira/browse/ARTEMIS-4360?focusedWorklogId=870621=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870621
]
ASF GitHub Bot logged work on ARTEMIS-4360:
---
Author: ASF GitHub Bot
Created on: 12/Jul/23 14:42
Start Date: 12/Jul/23 14:42
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4551:
URL: https://github.com/apache/activemq-artemis/pull/4551#discussion_r1261286699
##
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/base/ClasspathBase.java:
##
@@ -181,7 +179,15 @@ protected ClassLoader getClasspath(String name, boolean
forceNew) throws Excepti
classPathValue = buffer.toString();
}
- Assert.assertTrue("Cannot run compatibility tests, no classpath found on
./target/" + name + ".cp", classPathValue != null &&
!classPathValue.trim().equals(""));
+ boolean foundClassPath = classPathValue != null &&
!classPathValue.trim().equals("");
+
+ if (!foundClassPath) {
+ logger.info("Rebuild project with -Pcompatibility-tests. Cannot find
classpath definition for {}", name);
+ }
+
+ Assume.assumeTrue("Rebuild project with -Pcompatibility-tests.",
foundClassPath);
+
+ Assume.assumeTrue("Rebuild project with -Pcompatibility-tests to be able
to run this test. No classpath found on ./target/" + name + ".cp",
foundClassPath);
Review Comment:
@gemmellr I used to use assume before I switched to files. The idea was that
if the variable wasn't set, the test for that particular class path would just
be ignored.
I thought it would still be valid to have the tests running at least on the
snapshots as that would at least validate the test itself.. but I can just
disable it altogether if the profile is not run and keep as before. which I
will do.
Issue Time Tracking
---
Worklog Id: (was: 870621)
Time Spent: 1h 50m (was: 1h 40m)
> Make compatibility-tests opt in with -Pcompatibility-tests
> --
>
> Key: ARTEMIS-4360
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4360
> Project: ActiveMQ Artemis
> Issue Type: Task
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.30.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> we should make compatibility-tests opt-in. from now on you have to use
> -Pcompatibility-tests to run them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4360) Make compatibility-tests opt in with -Pcompatibility-tests
[
https://issues.apache.org/jira/browse/ARTEMIS-4360?focusedWorklogId=870614=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870614
]
ASF GitHub Bot logged work on ARTEMIS-4360:
---
Author: ASF GitHub Bot
Created on: 12/Jul/23 14:18
Start Date: 12/Jul/23 14:18
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4551:
URL: https://github.com/apache/activemq-artemis/pull/4551#discussion_r1261252139
##
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/base/ClasspathBase.java:
##
@@ -181,7 +179,15 @@ protected ClassLoader getClasspath(String name, boolean
forceNew) throws Excepti
classPathValue = buffer.toString();
}
- Assert.assertTrue("Cannot run compatibility tests, no classpath found on
./target/" + name + ".cp", classPathValue != null &&
!classPathValue.trim().equals(""));
+ boolean foundClassPath = classPathValue != null &&
!classPathValue.trim().equals("");
+
+ if (!foundClassPath) {
+ logger.info("Rebuild project with -Pcompatibility-tests. Cannot find
classpath definition for {}", name);
+ }
+
+ Assume.assumeTrue("Rebuild project with -Pcompatibility-tests.",
foundClassPath);
+
+ Assume.assumeTrue("Rebuild project with -Pcompatibility-tests to be able
to run this test. No classpath found on ./target/" + name + ".cp",
foundClassPath);
Review Comment:
In retrospect I guess that surefire is still being run on the module even
when the profile isnt enabled? If so I would change that, so surefire only runs
when the profile is active.
Issue Time Tracking
---
Worklog Id: (was: 870614)
Time Spent: 1h 40m (was: 1.5h)
> Make compatibility-tests opt in with -Pcompatibility-tests
> --
>
> Key: ARTEMIS-4360
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4360
> Project: ActiveMQ Artemis
> Issue Type: Task
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.30.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> we should make compatibility-tests opt-in. from now on you have to use
> -Pcompatibility-tests to run them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4360) Make compatibility-tests opt in with -Pcompatibility-tests
[
https://issues.apache.org/jira/browse/ARTEMIS-4360?focusedWorklogId=870613=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870613
]
ASF GitHub Bot logged work on ARTEMIS-4360:
---
Author: ASF GitHub Bot
Created on: 12/Jul/23 14:16
Start Date: 12/Jul/23 14:16
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4551:
URL: https://github.com/apache/activemq-artemis/pull/4551#discussion_r1261249473
##
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/base/ClasspathBase.java:
##
@@ -181,7 +179,15 @@ protected ClassLoader getClasspath(String name, boolean
forceNew) throws Excepti
classPathValue = buffer.toString();
}
- Assert.assertTrue("Cannot run compatibility tests, no classpath found on
./target/" + name + ".cp", classPathValue != null &&
!classPathValue.trim().equals(""));
+ boolean foundClassPath = classPathValue != null &&
!classPathValue.trim().equals("");
+
+ if (!foundClassPath) {
+ logger.info("Rebuild project with -Pcompatibility-tests. Cannot find
classpath definition for {}", name);
+ }
+
+ Assume.assumeTrue("Rebuild project with -Pcompatibility-tests.",
foundClassPath);
+
+ Assume.assumeTrue("Rebuild project with -Pcompatibility-tests to be able
to run this test. No classpath found on ./target/" + name + ".cp",
foundClassPath);
Review Comment:
Ok. Then I'll actually ask. I was confused why you changed the existing
assertion check to an Assume, which will skip rather than fail the test?
Originally it used an assertTrue that would fail if tripped, and then you had
tried to add an explicit fail here at first, but then switched it to the
[semi-duplicated] assumeTrue instead.
Issue Time Tracking
---
Worklog Id: (was: 870613)
Time Spent: 1.5h (was: 1h 20m)
> Make compatibility-tests opt in with -Pcompatibility-tests
> --
>
> Key: ARTEMIS-4360
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4360
> Project: ActiveMQ Artemis
> Issue Type: Task
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.30.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> we should make compatibility-tests opt-in. from now on you have to use
> -Pcompatibility-tests to run them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4360) Make compatibility-tests opt in with -Pcompatibility-tests
[
https://issues.apache.org/jira/browse/ARTEMIS-4360?focusedWorklogId=870609=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870609
]
ASF GitHub Bot logged work on ARTEMIS-4360:
---
Author: ASF GitHub Bot
Created on: 12/Jul/23 13:53
Start Date: 12/Jul/23 13:53
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4551:
URL: https://github.com/apache/activemq-artemis/pull/4551#discussion_r1261216474
##
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/base/ClasspathBase.java:
##
@@ -181,7 +179,15 @@ protected ClassLoader getClasspath(String name, boolean
forceNew) throws Excepti
classPathValue = buffer.toString();
}
- Assert.assertTrue("Cannot run compatibility tests, no classpath found on
./target/" + name + ".cp", classPathValue != null &&
!classPathValue.trim().equals(""));
+ boolean foundClassPath = classPathValue != null &&
!classPathValue.trim().equals("");
+
+ if (!foundClassPath) {
+ logger.info("Rebuild project with -Pcompatibility-tests. Cannot find
classpath definition for {}", name);
+ }
+
+ Assume.assumeTrue("Rebuild project with -Pcompatibility-tests.",
foundClassPath);
+
+ Assume.assumeTrue("Rebuild project with -Pcompatibility-tests to be able
to run this test. No classpath found on ./target/" + name + ".cp",
foundClassPath);
Review Comment:
@gemmellr I made it a draft to send fail commits and make sure tests would
fail.
Issue Time Tracking
---
Worklog Id: (was: 870609)
Time Spent: 1h 20m (was: 1h 10m)
> Make compatibility-tests opt in with -Pcompatibility-tests
> --
>
> Key: ARTEMIS-4360
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4360
> Project: ActiveMQ Artemis
> Issue Type: Task
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.30.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> we should make compatibility-tests opt-in. from now on you have to use
> -Pcompatibility-tests to run them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4360) Make compatibility-tests opt in with -Pcompatibility-tests
[
https://issues.apache.org/jira/browse/ARTEMIS-4360?focusedWorklogId=870606=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870606
]
ASF GitHub Bot logged work on ARTEMIS-4360:
---
Author: ASF GitHub Bot
Created on: 12/Jul/23 13:50
Start Date: 12/Jul/23 13:50
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4551:
URL: https://github.com/apache/activemq-artemis/pull/4551#discussion_r1261212138
##
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/base/ClasspathBase.java:
##
@@ -181,7 +179,15 @@ protected ClassLoader getClasspath(String name, boolean
forceNew) throws Excepti
classPathValue = buffer.toString();
}
- Assert.assertTrue("Cannot run compatibility tests, no classpath found on
./target/" + name + ".cp", classPathValue != null &&
!classPathValue.trim().equals(""));
+ boolean foundClassPath = classPathValue != null &&
!classPathValue.trim().equals("");
+
+ if (!foundClassPath) {
+ logger.info("Rebuild project with -Pcompatibility-tests. Cannot find
classpath definition for {}", name);
+ }
+
+ Assume.assumeTrue("Rebuild project with -Pcompatibility-tests.",
foundClassPath);
+
+ Assume.assumeTrue("Rebuild project with -Pcompatibility-tests to be able
to run this test. No classpath found on ./target/" + name + ".cp",
foundClassPath);
Review Comment:
I was going to ask earlier about the Assume's but didnt as its Draft :)
Issue Time Tracking
---
Worklog Id: (was: 870606)
Time Spent: 1h 10m (was: 1h)
> Make compatibility-tests opt in with -Pcompatibility-tests
> --
>
> Key: ARTEMIS-4360
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4360
> Project: ActiveMQ Artemis
> Issue Type: Task
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.30.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> we should make compatibility-tests opt-in. from now on you have to use
> -Pcompatibility-tests to run them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4360) Make compatibility-tests opt in with -Pcompatibility-tests
[
https://issues.apache.org/jira/browse/ARTEMIS-4360?focusedWorklogId=870603=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870603
]
ASF GitHub Bot logged work on ARTEMIS-4360:
---
Author: ASF GitHub Bot
Created on: 12/Jul/23 13:45
Start Date: 12/Jul/23 13:45
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4551:
URL: https://github.com/apache/activemq-artemis/pull/4551#discussion_r1261204904
##
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/base/ClasspathBase.java:
##
@@ -181,7 +179,15 @@ protected ClassLoader getClasspath(String name, boolean
forceNew) throws Excepti
classPathValue = buffer.toString();
}
- Assert.assertTrue("Cannot run compatibility tests, no classpath found on
./target/" + name + ".cp", classPathValue != null &&
!classPathValue.trim().equals(""));
+ boolean foundClassPath = classPathValue != null &&
!classPathValue.trim().equals("");
+
+ if (!foundClassPath) {
+ logger.info("Rebuild project with -Pcompatibility-tests. Cannot find
classpath definition for {}", name);
+ }
+
+ Assume.assumeTrue("Rebuild project with -Pcompatibility-tests.",
foundClassPath);
+
+ Assume.assumeTrue("Rebuild project with -Pcompatibility-tests to be able
to run this test. No classpath found on ./target/" + name + ".cp",
foundClassPath);
Review Comment:
please @clebertsuconic remove this line!
Issue Time Tracking
---
Worklog Id: (was: 870603)
Time Spent: 1h (was: 50m)
> Make compatibility-tests opt in with -Pcompatibility-tests
> --
>
> Key: ARTEMIS-4360
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4360
> Project: ActiveMQ Artemis
> Issue Type: Task
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.30.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> we should make compatibility-tests opt-in. from now on you have to use
> -Pcompatibility-tests to run them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4355) Update Сurator to 5.5.0
[
https://issues.apache.org/jira/browse/ARTEMIS-4355?focusedWorklogId=870550=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870550
]
ASF GitHub Bot logged work on ARTEMIS-4355:
---
Author: ASF GitHub Bot
Created on: 12/Jul/23 11:28
Start Date: 12/Jul/23 11:28
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4545:
URL: https://github.com/apache/activemq-artemis/pull/4545#discussion_r1261040741
##
artemis-quorum-ri/src/test/java/org/apache/activemq/artemis/quorum/zookeeper/CuratorDistributedLockTest.java:
##
@@ -337,21 +333,8 @@ public void
beNotifiedOfAlreadyUnavailableManagerAfterAddingListener() throws Ex
}
}
- private boolean ensembleHasLeader() {
- return
testingServer.getServers().stream().filter(CuratorDistributedLockTest::isLeader).count()
!= 0;
- }
-
- private static boolean isLeader(TestingZooKeeperServer server) {
- if (server.getInstanceSpecs().size() == 1) {
- return true;
- }
- long leaderId = server.getQuorumPeer().getLeaderId();
- long id = server.getQuorumPeer().getId();
- return id == leaderId;
- }
-
private void stopMajorityNotLeaderNodes(boolean fromLast) throws Exception {
- List followers =
testingServer.getServers().stream().filter(Predicates.not(CuratorDistributedLockTest::isLeader)).collect(Collectors.toList());
+ List followers = testingServer.getServers();
Review Comment:
I was not really pointing out the name wasnt descriptive, but that you
appeared to have changed _what the method is trying to do_. As that could be a
difference that alters expected behaviour for tests using it, it isnt
immediately obvious as being desirable.
Issue Time Tracking
---
Worklog Id: (was: 870550)
Time Spent: 1h 20m (was: 1h 10m)
> Update Сurator to 5.5.0
> ---
>
> Key: ARTEMIS-4355
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4355
> Project: ActiveMQ Artemis
> Issue Type: Dependency upgrade
> Components: clustering
>Affects Versions: 2.29.0
>Reporter: Alexey Markevich
>Priority: Minor
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4355) Update Сurator to 5.5.0
[
https://issues.apache.org/jira/browse/ARTEMIS-4355?focusedWorklogId=870544=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870544
]
ASF GitHub Bot logged work on ARTEMIS-4355:
---
Author: ASF GitHub Bot
Created on: 12/Jul/23 11:23
Start Date: 12/Jul/23 11:23
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4545:
URL: https://github.com/apache/activemq-artemis/pull/4545#discussion_r1261036359
##
artemis-quorum-ri/src/test/java/org/apache/activemq/artemis/quorum/zookeeper/CuratorDistributedLockTest.java:
##
@@ -84,8 +82,6 @@ public void setupEnv() throws Throwable {
}
testingServer = new TestingCluster(clusterSpecs);
testingServer.start();
- // start waits for quorumPeer!=null but not that it has started...
- Wait.waitFor(this::ensembleHasLeader);
Review Comment:
I realise, which is why I mentioned it in my question. What I wondered is
whether the reason it did so, to wait for _actual startup_, has changed on the
curator side. If it didn't then you have just removed a step that I expect was
there for a reason.
Issue Time Tracking
---
Worklog Id: (was: 870544)
Time Spent: 1h 10m (was: 1h)
> Update Сurator to 5.5.0
> ---
>
> Key: ARTEMIS-4355
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4355
> Project: ActiveMQ Artemis
> Issue Type: Dependency upgrade
> Components: clustering
>Affects Versions: 2.29.0
>Reporter: Alexey Markevich
>Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4349) Replace Guava cache with Caffeine
[ https://issues.apache.org/jira/browse/ARTEMIS-4349?focusedWorklogId=870542=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870542 ] ASF GitHub Bot logged work on ARTEMIS-4349: --- Author: ASF GitHub Bot Created on: 12/Jul/23 11:15 Start Date: 12/Jul/23 11:15 Worklog Time Spent: 10m Work Description: gemmellr commented on PR #4540: URL: https://github.com/apache/activemq-artemis/pull/4540#issuecomment-1632321610 Both (once you restore the console bit you have removed) Issue Time Tracking --- Worklog Id: (was: 870542) Time Spent: 6h 10m (was: 6h) > Replace Guava cache with Caffeine > - > > Key: ARTEMIS-4349 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4349 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.29.0 >Reporter: Alexey Markevich >Priority: Major > Time Spent: 6h 10m > Remaining Estimate: 0h > > based on benchmark https://github.com/ben-manes/caffeine/wiki/Benchmarks -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4353) Clean up Maven dependencies
[
https://issues.apache.org/jira/browse/ARTEMIS-4353?focusedWorklogId=870540=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870540
]
ASF GitHub Bot logged work on ARTEMIS-4353:
---
Author: ASF GitHub Bot
Created on: 12/Jul/23 11:12
Start Date: 12/Jul/23 11:12
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4544:
URL: https://github.com/apache/activemq-artemis/pull/4544#discussion_r1260980843
##
tests/soak-tests/pom.xml:
##
@@ -33,28 +33,81 @@
-
- org.apache.activemq
- artemis-core-client
- ${project.version}
- test
-
Clean up Maven dependencies
> ---
>
> Key: ARTEMIS-4353
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4353
> Project: ActiveMQ Artemis
> Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Over time module dependencies can grow stale with declared dependencies which
> are never used and used dependencies which are not declared (i.e.
> transitive). Such is the case with most of the modules in Artemis.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4353) Clean up Maven dependencies
[
https://issues.apache.org/jira/browse/ARTEMIS-4353?focusedWorklogId=870517=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870517
]
ASF GitHub Bot logged work on ARTEMIS-4353:
---
Author: ASF GitHub Bot
Created on: 12/Jul/23 10:19
Start Date: 12/Jul/23 10:19
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4544:
URL: https://github.com/apache/activemq-artemis/pull/4544#discussion_r1260955912
##
artemis-junit/artemis-junit-5/pom.xml:
##
@@ -57,12 +57,7 @@
org.apache.activemq
- artemis-jms-server
- ${project.version}
-
-
- org.apache.activemq
- artemis-jms-client
Review Comment:
I was 'ok' with this removal since the junit 5 stuff is actually 'core
centric' (which again, I dont actually think makes any sense, since we would
recommend the JMS client to most, and most I've seen using this want it to test
with the JMS client, so they typically shouldn't be using the core API directly
for anything).
Thats unlike the original junit 4 aimed stuff though, which has some very
JMS-specific bits as well, that do use the JMS client, so I dont think it
should be removed from the junit 4 stuff at this point since that has always
supplied the JMS client, and some will expect it to.
I have however been forgetting about junit-commons module also existing,
which is perhaps still supplying the jms client to _both_ the junit 4 and 5
modules (the latter should arguably be excluding it if so) ?
Issue Time Tracking
---
Worklog Id: (was: 870517)
Time Spent: 1.5h (was: 1h 20m)
> Clean up Maven dependencies
> ---
>
> Key: ARTEMIS-4353
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4353
> Project: ActiveMQ Artemis
> Issue Type: Task
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Over time module dependencies can grow stale with declared dependencies which
> are never used and used dependencies which are not declared (i.e.
> transitive). Such is the case with most of the modules in Artemis.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4349) Replace Guava cache with Caffeine
[ https://issues.apache.org/jira/browse/ARTEMIS-4349?focusedWorklogId=870515=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870515 ] ASF GitHub Bot logged work on ARTEMIS-4349: --- Author: ASF GitHub Bot Created on: 12/Jul/23 09:56 Start Date: 12/Jul/23 09:56 Worklog Time Spent: 10m Work Description: amarkevich commented on PR #4540: URL: https://github.com/apache/activemq-artemis/pull/4540#issuecomment-1632206994 > Guava will still be getting used in the project directly or as transitive dependency? Issue Time Tracking --- Worklog Id: (was: 870515) Time Spent: 6h (was: 5h 50m) > Replace Guava cache with Caffeine > - > > Key: ARTEMIS-4349 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4349 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.29.0 >Reporter: Alexey Markevich >Priority: Major > Time Spent: 6h > Remaining Estimate: 0h > > based on benchmark https://github.com/ben-manes/caffeine/wiki/Benchmarks -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4349) Replace Guava cache with Caffeine
[ https://issues.apache.org/jira/browse/ARTEMIS-4349?focusedWorklogId=870512=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870512 ] ASF GitHub Bot logged work on ARTEMIS-4349: --- Author: ASF GitHub Bot Created on: 12/Jul/23 09:43 Start Date: 12/Jul/23 09:43 Worklog Time Spent: 10m Work Description: gemmellr commented on PR #4540: URL: https://github.com/apache/activemq-artemis/pull/4540#issuecomment-1632188903 > > want the guava dependencyManagement restored > > for the moment - yes, keep `annotationProcessorPaths` for further change Regardless of the annotationProcessorPaths situation. Guava will still be getting used in the project after this change, no matter which way the ErrorProne etc annotation processors are being configured (or even if we removed ErrorProne entirely). Issue Time Tracking --- Worklog Id: (was: 870512) Time Spent: 5h 50m (was: 5h 40m) > Replace Guava cache with Caffeine > - > > Key: ARTEMIS-4349 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4349 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.29.0 >Reporter: Alexey Markevich >Priority: Major > Time Spent: 5h 50m > Remaining Estimate: 0h > > based on benchmark https://github.com/ben-manes/caffeine/wiki/Benchmarks -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (AMQ-9239) Jakarta JMS package namespace for broker
[ https://issues.apache.org/jira/browse/AMQ-9239?focusedWorklogId=870503=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870503 ] ASF GitHub Bot logged work on AMQ-9239: --- Author: ASF GitHub Bot Created on: 12/Jul/23 08:53 Start Date: 12/Jul/23 08:53 Worklog Time Spent: 10m Work Description: ksdevelops commented on PR #996: URL: https://github.com/apache/activemq/pull/996#issuecomment-1632113032 hi @mattrpav Any update on the 5.19 release for jakarta broker support? It's a very important functionality. We are in middle of migrating to JDK17 and Spring 6. The current activemq broker doesn't support jakarta messaging. Any tentative ETA would be helpful. Issue Time Tracking --- Worklog Id: (was: 870503) Time Spent: 3h 50m (was: 3h 40m) > Jakarta JMS package namespace for broker > > > Key: AMQ-9239 > URL: https://issues.apache.org/jira/browse/AMQ-9239 > Project: ActiveMQ > Issue Type: New Feature >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Major > Time Spent: 3h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
