[jira] [Work logged] (AMQ-9239) Jakarta JMS package namespace for broker
[ https://issues.apache.org/jira/browse/AMQ-9239?focusedWorklogId=873697&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-873697 ] ASF GitHub Bot logged work on AMQ-9239: --- Author: ASF GitHub Bot Created on: 31/Jul/23 07:08 Start Date: 31/Jul/23 07:08 Worklog Time Spent: 10m Work Description: prasad5400 commented on PR #996: URL: https://github.com/apache/activemq/pull/996#issuecomment-1657792220 What is the plan to release this functionality? We need this for your migration to JDK17 and Spring 6. Issue Time Tracking --- Worklog Id: (was: 873697) Time Spent: 4h 10m (was: 4h) > Jakarta JMS package namespace for broker > > > Key: AMQ-9239 > URL: https://issues.apache.org/jira/browse/AMQ-9239 > Project: ActiveMQ > Issue Type: New Feature >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Major > Time Spent: 4h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARTEMIS-4380) Multiple Failover Failback example missing
Geert Schuring created ARTEMIS-4380: --- Summary: Multiple Failover Failback example missing Key: ARTEMIS-4380 URL: https://issues.apache.org/jira/browse/ARTEMIS-4380 Project: ActiveMQ Artemis Issue Type: Bug Affects Versions: 2.28.0 Reporter: Geert Schuring Fix For: 2.30.0 The code for example "Multiple Failover Failback" is the exact same as "Multiple Failover" while it should show how to make sure clients revert back to the master broker as soon as it comes back online. Compare these two: # [https://raw.githubusercontent.com/apache/activemq-artemis/main/examples/features/ha/multiple-failover/src/main/java/org/apache/activemq/artemis/jms/example/MultipleFailoverExample.java] # [https://raw.githubusercontent.com/apache/activemq-artemis/main/examples/features/ha/multiple-failover-failback/src/main/java/org/apache/activemq/artemis/jms/example/MultipleFailoverFailbackExample.java] There's not meaningfull difference between them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4380) Multiple Failover Failback example missing
[ https://issues.apache.org/jira/browse/ARTEMIS-4380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geert Schuring updated ARTEMIS-4380: Description: The code for example "Multiple Failover Failback" is the exact same as "Multiple Failover" while it should show how to make sure clients revert back to the master broker as soon as it comes back online. Compare these two: # [https://raw.githubusercontent.com/apache/activemq-artemis/main/examples/features/ha/multiple-failover/src/main/java/org/apache/activemq/artemis/jms/example/MultipleFailoverExample.java] # [https://raw.githubusercontent.com/apache/activemq-artemis/main/examples/features/ha/multiple-failover-failback/src/main/java/org/apache/activemq/artemis/jms/example/MultipleFailoverFailbackExample.java] There's no meaningfull difference between them, unless I'm misunderstanding something. In any case, the axample does not tell me how to achieve failback. was: The code for example "Multiple Failover Failback" is the exact same as "Multiple Failover" while it should show how to make sure clients revert back to the master broker as soon as it comes back online. Compare these two: # [https://raw.githubusercontent.com/apache/activemq-artemis/main/examples/features/ha/multiple-failover/src/main/java/org/apache/activemq/artemis/jms/example/MultipleFailoverExample.java] # [https://raw.githubusercontent.com/apache/activemq-artemis/main/examples/features/ha/multiple-failover-failback/src/main/java/org/apache/activemq/artemis/jms/example/MultipleFailoverFailbackExample.java] There's not meaningfull difference between them. > Multiple Failover Failback example missing > -- > > Key: ARTEMIS-4380 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4380 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.28.0 >Reporter: Geert Schuring >Priority: Major > Labels: examples, failback > Fix For: 2.30.0 > > > The code for example "Multiple Failover Failback" is the exact same as > "Multiple Failover" while it should show how to make sure clients revert back > to the master broker as soon as it comes back online. > Compare these two: > # > [https://raw.githubusercontent.com/apache/activemq-artemis/main/examples/features/ha/multiple-failover/src/main/java/org/apache/activemq/artemis/jms/example/MultipleFailoverExample.java] > # > [https://raw.githubusercontent.com/apache/activemq-artemis/main/examples/features/ha/multiple-failover-failback/src/main/java/org/apache/activemq/artemis/jms/example/MultipleFailoverFailbackExample.java] > There's no meaningfull difference between them, unless I'm misunderstanding > something. In any case, the axample does not tell me how to achieve failback. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4372) Move CLI framework to picocli and implement auto-complete
[ https://issues.apache.org/jira/browse/ARTEMIS-4372?focusedWorklogId=873718&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-873718 ] ASF GitHub Bot logged work on ARTEMIS-4372: --- Author: ASF GitHub Bot Created on: 31/Jul/23 08:53 Start Date: 31/Jul/23 08:53 Worklog Time Spent: 10m Work Description: gemmellr commented on code in PR #4565: URL: https://github.com/apache/activemq-artemis/pull/4565#discussion_r1278982761 ## artemis-distribution/src/main/resources/bin/artemis: ## @@ -91,6 +91,9 @@ if $cygwin ; then fi exec "$JAVACMD" $JAVA_ARGS $ARTEMIS_CLUSTER_PROPS \ +--add-opens java.base/java.lang=ALL-UNNAMED \ +--add-opens java.base/java.io=ALL-UNNAMED \ +--add-opens java.base/java.util=ALL-UNNAMED \ Review Comment: Its not actually surprising that behaviour here might differ on different JDKs, thats exactly why I wondered if you tried it on the newer ones, especially with JDK21 almost done (RC1 due in 10 days, later RC2 if needed; JDK17 didnt get an RC2)...though I was more concerned it may need other config, than not need any, we will need to use what works for them all. Issue Time Tracking --- Worklog Id: (was: 873718) Time Spent: 5h 10m (was: 5h) > Move CLI framework to picocli and implement auto-complete > - > > Key: ARTEMIS-4372 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4372 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.31.0 > > Time Spent: 5h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (ARTEMIS-4379) Multiple Failover Failback example missing
[ https://issues.apache.org/jira/browse/ARTEMIS-4379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geert Schuring closed ARTEMIS-4379. --- This isssue is an unintended clone of another identical issue. This one should be deleted. > Multiple Failover Failback example missing > -- > > Key: ARTEMIS-4379 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4379 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.28.0 >Reporter: Geert Schuring >Priority: Major > Labels: examples, failback > > The code for example "Multiple Failover Failback" is the exact same as > "Multiple Failover" while it should show how to make sure clients revert back > to the master broker as soon as it comes back online. > Compare these two: > # > [https://raw.githubusercontent.com/apache/activemq-artemis/main/examples/features/ha/multiple-failover/src/main/java/org/apache/activemq/artemis/jms/example/MultipleFailoverExample.java] > # > [https://raw.githubusercontent.com/apache/activemq-artemis/main/examples/features/ha/multiple-failover-failback/src/main/java/org/apache/activemq/artemis/jms/example/MultipleFailoverFailbackExample.java] > There's not meaningfull difference between them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (ARTEMIS-4379) Multiple Failover Failback example missing
[ https://issues.apache.org/jira/browse/ARTEMIS-4379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Geert Schuring resolved ARTEMIS-4379. - Fix Version/s: (was: 2.30.0) Resolution: Duplicate > Multiple Failover Failback example missing > -- > > Key: ARTEMIS-4379 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4379 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.28.0 >Reporter: Geert Schuring >Priority: Major > Labels: examples, failback > > The code for example "Multiple Failover Failback" is the exact same as > "Multiple Failover" while it should show how to make sure clients revert back > to the master broker as soon as it comes back online. > Compare these two: > # > [https://raw.githubusercontent.com/apache/activemq-artemis/main/examples/features/ha/multiple-failover/src/main/java/org/apache/activemq/artemis/jms/example/MultipleFailoverExample.java] > # > [https://raw.githubusercontent.com/apache/activemq-artemis/main/examples/features/ha/multiple-failover-failback/src/main/java/org/apache/activemq/artemis/jms/example/MultipleFailoverFailbackExample.java] > There's not meaningfull difference between them. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4380) Multiple Failover Failback example missing
[ https://issues.apache.org/jira/browse/ARTEMIS-4380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated ARTEMIS-4380: Fix Version/s: (was: 2.30.0) > Multiple Failover Failback example missing > -- > > Key: ARTEMIS-4380 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4380 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.28.0 >Reporter: Geert Schuring >Priority: Major > Labels: examples, failback > > The code for example "Multiple Failover Failback" is the exact same as > "Multiple Failover" while it should show how to make sure clients revert back > to the master broker as soon as it comes back online. > Compare these two: > # > [https://raw.githubusercontent.com/apache/activemq-artemis/main/examples/features/ha/multiple-failover/src/main/java/org/apache/activemq/artemis/jms/example/MultipleFailoverExample.java] > # > [https://raw.githubusercontent.com/apache/activemq-artemis/main/examples/features/ha/multiple-failover-failback/src/main/java/org/apache/activemq/artemis/jms/example/MultipleFailoverFailbackExample.java] > There's no meaningfull difference between them, unless I'm misunderstanding > something. In any case, the axample does not tell me how to achieve failback. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARTEMIS-4381) resource-limit-settings max-connections should be called max-sessions
Geert Schuring created ARTEMIS-4381: --- Summary: resource-limit-settings max-connections should be called max-sessions Key: ARTEMIS-4381 URL: https://issues.apache.org/jira/browse/ARTEMIS-4381 Project: ActiveMQ Artemis Issue Type: Bug Components: Broker Affects Versions: 2.28.0 Reporter: Geert Schuring The configuration setting "max-connections" should be called "max-sessions" since it limits the amounts of sessions and not the connections. [https://activemq.apache.org/components/artemis/documentation/latest/resource-limits.html#configuring-limits-via-resource-limit-settings] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4381) resource-limit-settings max-connections should be called max-sessions
[
https://issues.apache.org/jira/browse/ARTEMIS-4381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Geert Schuring updated ARTEMIS-4381:
Description:
The configuration setting "max-connections" should be called "max-sessions"
since it limits the amounts of sessions and not the connections.
[https://activemq.apache.org/components/artemis/documentation/latest/resource-limits.html#configuring-limits-via-resource-limit-settings]
After having limited the 'connections' using this setting I get the following
error even though this user has only 1 connection to the broker: (it does try
to create more then 1 sessions)
{quote}{{AMQ229110: Too many sessions for user 'user'}}
{quote}
was:
The configuration setting "max-connections" should be called "max-sessions"
since it limits the amounts of sessions and not the connections.
[https://activemq.apache.org/components/artemis/documentation/latest/resource-limits.html#configuring-limits-via-resource-limit-settings]
> resource-limit-settings max-connections should be called max-sessions
> -
>
> Key: ARTEMIS-4381
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4381
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.28.0
>Reporter: Geert Schuring
>Priority: Major
>
> The configuration setting "max-connections" should be called "max-sessions"
> since it limits the amounts of sessions and not the connections.
>
> [https://activemq.apache.org/components/artemis/documentation/latest/resource-limits.html#configuring-limits-via-resource-limit-settings]
> After having limited the 'connections' using this setting I get the following
> error even though this user has only 1 connection to the broker: (it does try
> to create more then 1 sessions)
> {quote}{{AMQ229110: Too many sessions for user 'user'}}
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4372) Move CLI framework to picocli and implement auto-complete
[
https://issues.apache.org/jira/browse/ARTEMIS-4372?focusedWorklogId=873790&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-873790
]
ASF GitHub Bot logged work on ARTEMIS-4372:
---
Author: ASF GitHub Bot
Created on: 31/Jul/23 12:39
Start Date: 31/Jul/23 12:39
Worklog Time Spent: 10m
Work Description: gnodet commented on code in PR #4565:
URL: https://github.com/apache/activemq-artemis/pull/4565#discussion_r1279185868
##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/Shell.java:
##
@@ -0,0 +1,128 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.cli;
+
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.function.Supplier;
+
+import org.jline.console.SystemRegistry;
+import org.jline.console.impl.SystemRegistryImpl;
+import org.jline.reader.EndOfFileException;
+import org.jline.reader.LineReader;
+import org.jline.reader.LineReaderBuilder;
+import org.jline.reader.MaskingCallback;
+import org.jline.reader.Parser;
+import org.jline.reader.UserInterruptException;
+import org.jline.reader.impl.DefaultParser;
+import org.jline.terminal.Terminal;
+import org.jline.terminal.TerminalBuilder;
+import picocli.CommandLine;
+import picocli.CommandLine.Command;
+import picocli.shell.jline3.PicocliCommands;
+
+@Command(name = "shell", description = "JLine3 shell helping using the CLI")
+public class Shell implements Runnable {
+
+ private static String RED_UNICODE = "\u001B[31m";
+ private static String YELLOW_UNICODE = "\u001B[33m";
+ private static String CLEAR_UNICODE = "\u001B[0m";
+
+ public Shell(CommandLine commandLine) {
+ }
+
+ @Override
+ public void run() {
+ runShell();
+ }
+
+ private static ThreadLocal IN_SHELL =
ThreadLocal.withInitial(() -> new AtomicBoolean(false));
+
+ public static boolean inShell() {
+ return IN_SHELL.get().get();
+ }
+
+ public static void runShell() {
+ try {
+ IN_SHELL.get().set(true);
+
+ boolean isInstance = System.getProperty("artemis.instance") != null;
+
+ Supplier workDir = () ->
Paths.get(System.getProperty("user.dir"));
+
+ PicocliCommands.PicocliCommandsFactory factory = new
PicocliCommands.PicocliCommandsFactory();
+
+ CommandLine commandLine = Artemis.buildCommand(isInstance,
!isInstance, true);
+
+ PicocliCommands picocliCommands = new PicocliCommands(commandLine);
+
+ Parser parser = new DefaultParser();
+ try (Terminal terminal = TerminalBuilder.builder().build()) {
Review Comment:
As a shortcut, you could use `TerminalBuilder.terminal()`
##
artemis-distribution/src/main/resources/bin/artemis:
##
@@ -91,6 +91,9 @@ if $cygwin ; then
fi
exec "$JAVACMD" $JAVA_ARGS $ARTEMIS_CLUSTER_PROPS \
+--add-opens java.base/java.lang=ALL-UNNAMED \
+--add-opens java.base/java.io=ALL-UNNAMED \
+--add-opens java.base/java.util=ALL-UNNAMED \
Review Comment:
See above, adding jansi will remove the need for those options.
##
artemis-cli/src/main/resources/org/apache/activemq/artemis/cli/commands/bin/artemis:
##
@@ -102,6 +102,9 @@ fi
exec "$JAVACMD" \
$JAVA_ARGS \
+--add-opens java.base/java.lang=ALL-UNNAMED \
+--add-opens java.base/java.io=ALL-UNNAMED \
+--add-opens java.base/java.util=ALL-UNNAMED \
Review Comment:
Adding the jansi library will remove the need for those additional JVM
options. Those are only required when using the exec provider, which won't be
used if you add jansi to support windows.
##
artemis-cli/pom.xml:
##
@@ -124,10 +124,17 @@
jakarta.xml.bind-api
${jakarta.xml.bind-api.version}
-
- com.github.rvesse
- airline
+ info.picocli
+ picocli
+
+
+ info.picocli
+ picocli-shell-jline3
+
+
+ org.jline
+ jline
Review Comment:
In order to support Windows properly, you need to add a dependency on jansi
or jna. I sug
[jira] [Work logged] (ARTEMIS-4372) Move CLI framework to picocli and implement auto-complete
[
https://issues.apache.org/jira/browse/ARTEMIS-4372?focusedWorklogId=873791&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-873791
]
ASF GitHub Bot logged work on ARTEMIS-4372:
---
Author: ASF GitHub Bot
Created on: 31/Jul/23 12:57
Start Date: 31/Jul/23 12:57
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4565:
URL: https://github.com/apache/activemq-artemis/pull/4565#discussion_r1279258496
##
artemis-cli/pom.xml:
##
@@ -124,10 +124,17 @@
jakarta.xml.bind-api
${jakarta.xml.bind-api.version}
-
- com.github.rvesse
- airline
+ info.picocli
+ picocli
+
+
+ info.picocli
+ picocli-shell-jline3
+
+
+ org.jline
+ jline
Review Comment:
@gnodet thank you so much.. that worked like a charm!
@gemmellr ^^^ C/C
Issue Time Tracking
---
Worklog Id: (was: 873791)
Time Spent: 5.5h (was: 5h 20m)
> Move CLI framework to picocli and implement auto-complete
> -
>
> Key: ARTEMIS-4372
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4372
> Project: ActiveMQ Artemis
> Issue Type: New Feature
>Reporter: Clebert Suconic
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.31.0
>
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4372) Move CLI framework to picocli and implement auto-complete
[
https://issues.apache.org/jira/browse/ARTEMIS-4372?focusedWorklogId=873792&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-873792
]
ASF GitHub Bot logged work on ARTEMIS-4372:
---
Author: ASF GitHub Bot
Created on: 31/Jul/23 13:05
Start Date: 31/Jul/23 13:05
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4565:
URL: https://github.com/apache/activemq-artemis/pull/4565#discussion_r1279267330
##
artemis-cli/pom.xml:
##
@@ -124,10 +124,17 @@
jakarta.xml.bind-api
${jakarta.xml.bind-api.version}
-
- com.github.rvesse
- airline
+ info.picocli
+ picocli
+
+
+ info.picocli
+ picocli-shell-jline3
+
+
+ org.jline
+ jline
Review Comment:
@gnodet thank you so much for your help here.
Issue Time Tracking
---
Worklog Id: (was: 873792)
Time Spent: 5h 40m (was: 5.5h)
> Move CLI framework to picocli and implement auto-complete
> -
>
> Key: ARTEMIS-4372
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4372
> Project: ActiveMQ Artemis
> Issue Type: New Feature
>Reporter: Clebert Suconic
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.31.0
>
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (AMQ-9239) Jakarta JMS package namespace for broker
[ https://issues.apache.org/jira/browse/AMQ-9239?focusedWorklogId=873813&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-873813 ] ASF GitHub Bot logged work on AMQ-9239: --- Author: ASF GitHub Bot Created on: 31/Jul/23 14:28 Start Date: 31/Jul/23 14:28 Worklog Time Spent: 10m Work Description: mattrpav commented on PR #996: URL: https://github.com/apache/activemq/pull/996#issuecomment-1658481899 @narendranss @prasad5400 reminder Issue Time Tracking --- Worklog Id: (was: 873813) Time Spent: 4h 20m (was: 4h 10m) > Jakarta JMS package namespace for broker > > > Key: AMQ-9239 > URL: https://issues.apache.org/jira/browse/AMQ-9239 > Project: ActiveMQ > Issue Type: New Feature >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Major > Time Spent: 4h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4372) Move CLI framework to picocli and implement auto-complete
[ https://issues.apache.org/jira/browse/ARTEMIS-4372?focusedWorklogId=873816&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-873816 ] ASF GitHub Bot logged work on ARTEMIS-4372: --- Author: ASF GitHub Bot Created on: 31/Jul/23 14:39 Start Date: 31/Jul/23 14:39 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4565: URL: https://github.com/apache/activemq-artemis/pull/4565#issuecomment-1658502892 @gemmellr I am merging this... further changes can be sent into main after this. Thanks for your help on this Issue Time Tracking --- Worklog Id: (was: 873816) Time Spent: 5h 50m (was: 5h 40m) > Move CLI framework to picocli and implement auto-complete > - > > Key: ARTEMIS-4372 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4372 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.31.0 > > Time Spent: 5h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4372) Move CLI framework to picocli and implement auto-complete
[ https://issues.apache.org/jira/browse/ARTEMIS-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17749216#comment-17749216 ] ASF subversion and git services commented on ARTEMIS-4372: -- Commit 93ee61e35c93564fb74b70f810a2a7a03dd0cb20 in activemq-artemis's branch refs/heads/main from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=93ee61e35c ] ARTEMIS-4372 Implement Pico-cli and script auto-complete ARTEMIS-4375 Implement artemis shell using JLine3 integrated with auto-completion from picocli This commit involves two JIRAs. One is adding PicoCLI and the next is Using JLine3 and implement a shell. I have tried to keep these commits separate but these changes became interdependent hence the two JIRAs are squashed in this commit. > Move CLI framework to picocli and implement auto-complete > - > > Key: ARTEMIS-4372 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4372 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.31.0 > > Time Spent: 6h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4375) JLine3 integration
[ https://issues.apache.org/jira/browse/ARTEMIS-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17749217#comment-17749217 ] ASF subversion and git services commented on ARTEMIS-4375: -- Commit 93ee61e35c93564fb74b70f810a2a7a03dd0cb20 in activemq-artemis's branch refs/heads/main from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=93ee61e35c ] ARTEMIS-4372 Implement Pico-cli and script auto-complete ARTEMIS-4375 Implement artemis shell using JLine3 integrated with auto-completion from picocli This commit involves two JIRAs. One is adding PicoCLI and the next is Using JLine3 and implement a shell. I have tried to keep these commits separate but these changes became interdependent hence the two JIRAs are squashed in this commit. > JLine3 integration > -- > > Key: ARTEMIS-4375 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4375 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Clebert Suconic >Priority: Major > > Integration with jLine3 on the shell. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4372) Move CLI framework to picocli and implement auto-complete
[ https://issues.apache.org/jira/browse/ARTEMIS-4372?focusedWorklogId=873817&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-873817 ] ASF GitHub Bot logged work on ARTEMIS-4372: --- Author: ASF GitHub Bot Created on: 31/Jul/23 14:40 Start Date: 31/Jul/23 14:40 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #4565: URL: https://github.com/apache/activemq-artemis/pull/4565 Issue Time Tracking --- Worklog Id: (was: 873817) Time Spent: 6h (was: 5h 50m) > Move CLI framework to picocli and implement auto-complete > - > > Key: ARTEMIS-4372 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4372 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.31.0 > > Time Spent: 6h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4375) JLine3 integration
[ https://issues.apache.org/jira/browse/ARTEMIS-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17749239#comment-17749239 ] ASF subversion and git services commented on ARTEMIS-4375: -- Commit 26566432678cdc10754e1d4a111e60b07a246193 in activemq-artemis's branch refs/heads/main from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=2656643267 ] ARTEMIS-4375 Block console if starting server from shell > JLine3 integration > -- > > Key: ARTEMIS-4375 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4375 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Clebert Suconic >Priority: Major > > Integration with jLine3 on the shell. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4372) Move CLI framework to picocli and implement auto-complete
[
https://issues.apache.org/jira/browse/ARTEMIS-4372?focusedWorklogId=873858&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-873858
]
ASF GitHub Bot logged work on ARTEMIS-4372:
---
Author: ASF GitHub Bot
Created on: 31/Jul/23 16:42
Start Date: 31/Jul/23 16:42
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4565:
URL: https://github.com/apache/activemq-artemis/pull/4565#discussion_r1279379655
##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/ConnectionAbstract.java:
##
@@ -157,68 +174,132 @@ private ConnectionFactory
createAMQPConnectionFactory(String brokerURL,
}
try {
- Connection connection = cf.createConnection();
- connection.close();
+ tryConnect(brokerURL, user, password, cf);
return cf;
} catch (JMSSecurityException e) {
// if a security exception will get the user and password through an
input
getActionContext().err.println("Connection failed::" +
e.getMessage());
- cf = new JmsConnectionFactory(inputUser(user),
inputPassword(password), brokerURL);
+ user = inputUser(user);
+ password = inputPassword(password);
+ cf = new JmsConnectionFactory(user, password, brokerURL);
if (clientID != null) {
cf.setClientID(clientID);
}
+ try {
+tryConnect(brokerURL, user, password, cf);
+ } catch (Exception e2) {
+e.printStackTrace();
+ }
return cf;
} catch (JMSException e) {
// if a connection exception will ask for the URL, user and password
getActionContext().err.println("Connection failed::" +
e.getMessage());
- cf = new JmsConnectionFactory(inputUser(user),
inputPassword(password), inputBrokerURL(brokerURL));
+ brokerURL = inputBrokerURL(brokerURL);
+ user = inputUser(user);
+ password = inputPassword(password);
+ cf = new JmsConnectionFactory(user, password, brokerURL);
if (clientID != null) {
cf.setClientID(clientID);
}
+ try {
+tryConnect(brokerURL, user, password, cf);
+ } catch (Exception e2) {
+e2.printStackTrace();
+ }
return cf;
}
}
protected ActiveMQConnectionFactory createCoreConnectionFactory() {
+ recoverConnectionInformation();
return createCoreConnectionFactory(brokerURL, user, password, clientID);
}
+ private void recoverConnectionInformation() {
+ if (CONNECTION_INFORMATION.get() != null) {
+ ConnectionInformation connectionInfo = CONNECTION_INFORMATION.get();
+ if (this.user == null) {
+this.user = connectionInfo.user;
+ }
+ if (this.password == null) {
+this.password = connectionInfo.password;
+ }
+ if (this.brokerURL == null) {
+this.brokerURL = connectionInfo.uri;
+ }
+
+ }
+ }
+
+ void saveConnectionInfo(String brokerURL, String user, String password) {
+ if (Shell.inShell() && CONNECTION_INFORMATION.get() == null) {
+ CONNECTION_INFORMATION.set(new ConnectionInformation(brokerURL, user,
password));
+ System.out.println("CLI connected to broker " + brokerURL + ", user:"
+ user);
+ }
+ }
+
protected ActiveMQConnectionFactory createCoreConnectionFactory(String
brokerURL,
String user,
String
password,
String
clientID) {
+ if (brokerURL.startsWith("amqp://")) {
+ // replacing amqp:// by tcp://
+ brokerURL = "tcp" + brokerURL.substring(4);
+ }
+
ActiveMQConnectionFactory cf = new ActiveMQConnectionFactory(brokerURL,
user, password);
if (clientID != null) {
getActionContext().out.println("Consumer:: clientID = " + clientID);
cf.setClientID(clientID);
}
try {
- Connection connection = cf.createConnection();
- connection.close();
+ tryConnect(brokerURL, user, password, cf);
return cf;
} catch (JMSSecurityException e) {
// if a security exception will get the user and password through an
input
if (getActionContext() != null) {
getActionContext().err.println("Connection failed::" +
e.getMessage());
}
- cf = new ActiveMQConnectionFactory(brokerURL, inputUser(user),
inputPassword(password));
+ user = inputUser(user);
+ password = inputPassword(password);
+ cf = new ActiveMQConnectionFactory(brokerURL, user, password);
if (clientID != null) {
cf.s
[jira] [Work logged] (ARTEMIS-4372) Move CLI framework to picocli and implement auto-complete
[
https://issues.apache.org/jira/browse/ARTEMIS-4372?focusedWorklogId=873866&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-873866
]
ASF GitHub Bot logged work on ARTEMIS-4372:
---
Author: ASF GitHub Bot
Created on: 31/Jul/23 17:02
Start Date: 31/Jul/23 17:02
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4565:
URL: https://github.com/apache/activemq-artemis/pull/4565#discussion_r1279627523
##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/Artemis.java:
##
@@ -194,68 +191,140 @@ public static Object execute(boolean inputEnabled,
boolean useSystemOut, File ar
* Useful on test cases
*/
private static Object internalExecute(File artemisHome, File
artemisInstance, File etcFolder, String[] args) throws Exception {
- return internalExecute(artemisHome, artemisInstance, etcFolder, args,
ActionContext.system());
+ return internalExecute(artemisHome, artemisInstance, etcFolder, args,
new ActionContext());
}
public static Object internalExecute(File artemisHome, File
artemisInstance, File etcFolder, String[] args, ActionContext context) throws
Exception {
- Action action = builder(artemisInstance).build().parse(args);
- action.setHomeValues(artemisHome, artemisInstance, etcFolder);
+ boolean isInstance = artemisInstance != null ||
System.getProperty("artemis.instance") != null;
+ CommandLine commandLine = buildCommand(isInstance, !isInstance);
+
+ Object userObject = parseAction(commandLine, args);
+
+ // Pico shouldn't allow generating a commandLine without an userObject.
+ // the following assert "should" never happen
+ assert userObject != null;
Review Comment:
this is never supposed to happen.
Only chance userObject is null is if you set the userObject wrongly during
development. and picocli actually validate that already.
Issue Time Tracking
---
Worklog Id: (was: 873866)
Time Spent: 6h 20m (was: 6h 10m)
> Move CLI framework to picocli and implement auto-complete
> -
>
> Key: ARTEMIS-4372
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4372
> Project: ActiveMQ Artemis
> Issue Type: New Feature
>Reporter: Clebert Suconic
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.31.0
>
> Time Spent: 6h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4372) Move CLI framework to picocli and implement auto-complete
[
https://issues.apache.org/jira/browse/ARTEMIS-4372?focusedWorklogId=873896&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-873896
]
ASF GitHub Bot logged work on ARTEMIS-4372:
---
Author: ASF GitHub Bot
Created on: 31/Jul/23 20:32
Start Date: 31/Jul/23 20:32
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4565:
URL: https://github.com/apache/activemq-artemis/pull/4565#discussion_r1279851195
##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/ConnectionAbstract.java:
##
@@ -157,68 +174,132 @@ private ConnectionFactory
createAMQPConnectionFactory(String brokerURL,
}
try {
- Connection connection = cf.createConnection();
- connection.close();
+ tryConnect(brokerURL, user, password, cf);
return cf;
} catch (JMSSecurityException e) {
// if a security exception will get the user and password through an
input
getActionContext().err.println("Connection failed::" +
e.getMessage());
- cf = new JmsConnectionFactory(inputUser(user),
inputPassword(password), brokerURL);
+ user = inputUser(user);
+ password = inputPassword(password);
+ cf = new JmsConnectionFactory(user, password, brokerURL);
if (clientID != null) {
cf.setClientID(clientID);
}
+ try {
+tryConnect(brokerURL, user, password, cf);
+ } catch (Exception e2) {
+e.printStackTrace();
+ }
return cf;
} catch (JMSException e) {
// if a connection exception will ask for the URL, user and password
getActionContext().err.println("Connection failed::" +
e.getMessage());
- cf = new JmsConnectionFactory(inputUser(user),
inputPassword(password), inputBrokerURL(brokerURL));
+ brokerURL = inputBrokerURL(brokerURL);
+ user = inputUser(user);
+ password = inputPassword(password);
+ cf = new JmsConnectionFactory(user, password, brokerURL);
if (clientID != null) {
cf.setClientID(clientID);
}
+ try {
+tryConnect(brokerURL, user, password, cf);
+ } catch (Exception e2) {
+e2.printStackTrace();
+ }
return cf;
}
}
protected ActiveMQConnectionFactory createCoreConnectionFactory() {
+ recoverConnectionInformation();
return createCoreConnectionFactory(brokerURL, user, password, clientID);
}
+ private void recoverConnectionInformation() {
+ if (CONNECTION_INFORMATION.get() != null) {
+ ConnectionInformation connectionInfo = CONNECTION_INFORMATION.get();
+ if (this.user == null) {
+this.user = connectionInfo.user;
+ }
+ if (this.password == null) {
+this.password = connectionInfo.password;
+ }
+ if (this.brokerURL == null) {
+this.brokerURL = connectionInfo.uri;
+ }
+
+ }
+ }
+
+ void saveConnectionInfo(String brokerURL, String user, String password) {
+ if (Shell.inShell() && CONNECTION_INFORMATION.get() == null) {
+ CONNECTION_INFORMATION.set(new ConnectionInformation(brokerURL, user,
password));
+ System.out.println("CLI connected to broker " + brokerURL + ", user:"
+ user);
+ }
+ }
+
protected ActiveMQConnectionFactory createCoreConnectionFactory(String
brokerURL,
String user,
String
password,
String
clientID) {
+ if (brokerURL.startsWith("amqp://")) {
+ // replacing amqp:// by tcp://
+ brokerURL = "tcp" + brokerURL.substring(4);
+ }
+
ActiveMQConnectionFactory cf = new ActiveMQConnectionFactory(brokerURL,
user, password);
if (clientID != null) {
getActionContext().out.println("Consumer:: clientID = " + clientID);
cf.setClientID(clientID);
}
try {
- Connection connection = cf.createConnection();
- connection.close();
+ tryConnect(brokerURL, user, password, cf);
return cf;
} catch (JMSSecurityException e) {
// if a security exception will get the user and password through an
input
if (getActionContext() != null) {
getActionContext().err.println("Connection failed::" +
e.getMessage());
}
- cf = new ActiveMQConnectionFactory(brokerURL, inputUser(user),
inputPassword(password));
+ user = inputUser(user);
+ password = inputPassword(password);
+ cf = new ActiveMQConnectionFactory(brokerURL, user, password);
if (clientID != null) {
[jira] [Created] (ARTEMIS-4382) CLI import / export may take a huge amount of time in large datasets.
Clebert Suconic created ARTEMIS-4382: Summary: CLI import / export may take a huge amount of time in large datasets. Key: ARTEMIS-4382 URL: https://issues.apache.org/jira/browse/ARTEMIS-4382 Project: ActiveMQ Artemis Issue Type: Bug Affects Versions: 2.30.0 Reporter: Clebert Suconic Assignee: Clebert Suconic Fix For: 2.31.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4372) Move CLI framework to picocli and implement auto-complete
[
https://issues.apache.org/jira/browse/ARTEMIS-4372?focusedWorklogId=873936&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-873936
]
ASF GitHub Bot logged work on ARTEMIS-4372:
---
Author: ASF GitHub Bot
Created on: 01/Aug/23 02:15
Start Date: 01/Aug/23 02:15
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4565:
URL: https://github.com/apache/activemq-artemis/pull/4565#discussion_r1280044335
##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/ConnectionAbstract.java:
##
@@ -157,68 +174,132 @@ private ConnectionFactory
createAMQPConnectionFactory(String brokerURL,
}
try {
- Connection connection = cf.createConnection();
- connection.close();
+ tryConnect(brokerURL, user, password, cf);
return cf;
} catch (JMSSecurityException e) {
// if a security exception will get the user and password through an
input
getActionContext().err.println("Connection failed::" +
e.getMessage());
- cf = new JmsConnectionFactory(inputUser(user),
inputPassword(password), brokerURL);
+ user = inputUser(user);
+ password = inputPassword(password);
+ cf = new JmsConnectionFactory(user, password, brokerURL);
if (clientID != null) {
cf.setClientID(clientID);
}
+ try {
+tryConnect(brokerURL, user, password, cf);
+ } catch (Exception e2) {
+e.printStackTrace();
+ }
return cf;
} catch (JMSException e) {
// if a connection exception will ask for the URL, user and password
getActionContext().err.println("Connection failed::" +
e.getMessage());
- cf = new JmsConnectionFactory(inputUser(user),
inputPassword(password), inputBrokerURL(brokerURL));
+ brokerURL = inputBrokerURL(brokerURL);
+ user = inputUser(user);
+ password = inputPassword(password);
+ cf = new JmsConnectionFactory(user, password, brokerURL);
if (clientID != null) {
cf.setClientID(clientID);
}
+ try {
+tryConnect(brokerURL, user, password, cf);
+ } catch (Exception e2) {
+e2.printStackTrace();
+ }
return cf;
}
}
protected ActiveMQConnectionFactory createCoreConnectionFactory() {
+ recoverConnectionInformation();
return createCoreConnectionFactory(brokerURL, user, password, clientID);
}
+ private void recoverConnectionInformation() {
+ if (CONNECTION_INFORMATION.get() != null) {
+ ConnectionInformation connectionInfo = CONNECTION_INFORMATION.get();
+ if (this.user == null) {
+this.user = connectionInfo.user;
+ }
+ if (this.password == null) {
+this.password = connectionInfo.password;
+ }
+ if (this.brokerURL == null) {
+this.brokerURL = connectionInfo.uri;
+ }
+
+ }
+ }
+
+ void saveConnectionInfo(String brokerURL, String user, String password) {
+ if (Shell.inShell() && CONNECTION_INFORMATION.get() == null) {
+ CONNECTION_INFORMATION.set(new ConnectionInformation(brokerURL, user,
password));
+ System.out.println("CLI connected to broker " + brokerURL + ", user:"
+ user);
+ }
+ }
+
protected ActiveMQConnectionFactory createCoreConnectionFactory(String
brokerURL,
String user,
String
password,
String
clientID) {
+ if (brokerURL.startsWith("amqp://")) {
+ // replacing amqp:// by tcp://
+ brokerURL = "tcp" + brokerURL.substring(4);
+ }
+
ActiveMQConnectionFactory cf = new ActiveMQConnectionFactory(brokerURL,
user, password);
if (clientID != null) {
getActionContext().out.println("Consumer:: clientID = " + clientID);
cf.setClientID(clientID);
}
try {
- Connection connection = cf.createConnection();
- connection.close();
+ tryConnect(brokerURL, user, password, cf);
return cf;
} catch (JMSSecurityException e) {
// if a security exception will get the user and password through an
input
if (getActionContext() != null) {
getActionContext().err.println("Connection failed::" +
e.getMessage());
}
- cf = new ActiveMQConnectionFactory(brokerURL, inputUser(user),
inputPassword(password));
+ user = inputUser(user);
+ password = inputPassword(password);
+ cf = new ActiveMQConnectionFactory(brokerURL, user, password);
if (clientID != null) {
[jira] [Commented] (ARTEMIS-4372) Move CLI framework to picocli and implement auto-complete
[ https://issues.apache.org/jira/browse/ARTEMIS-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17749422#comment-17749422 ] ASF subversion and git services commented on ARTEMIS-4372: -- Commit 05f8e5d68f6b8618639f84dcdd6862797cd10d55 in activemq-artemis's branch refs/heads/main from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=05f8e5d68f ] ARTEMIS-4372 small fixes on CLI > Move CLI framework to picocli and implement auto-complete > - > > Key: ARTEMIS-4372 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4372 > Project: ActiveMQ Artemis > Issue Type: New Feature >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.31.0 > > Time Spent: 6h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (AMQ-9292) Update stompjms 1.27
Matt Pavlovich created AMQ-9292: --- Summary: Update stompjms 1.27 Key: AMQ-9292 URL: https://issues.apache.org/jira/browse/AMQ-9292 Project: ActiveMQ Issue Type: Dependency upgrade Reporter: Matt Pavlovich Update stompjms to 1.27 and new groupId -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4382) CLI import / export may take a huge amount of time in large datasets.
[ https://issues.apache.org/jira/browse/ARTEMIS-4382?focusedWorklogId=873938&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-873938 ] ASF GitHub Bot logged work on ARTEMIS-4382: --- Author: ASF GitHub Bot Created on: 01/Aug/23 03:04 Start Date: 01/Aug/23 03:04 Worklog Time Spent: 10m Work Description: clebertsuconic opened a new pull request, #4572: URL: https://github.com/apache/activemq-artemis/pull/4572 (no comment) Issue Time Tracking --- Worklog Id: (was: 873938) Remaining Estimate: 0h Time Spent: 10m > CLI import / export may take a huge amount of time in large datasets. > - > > Key: ARTEMIS-4382 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4382 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.30.0 >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.31.0 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4382) CLI import / export may take a huge amount of time in large datasets.
[
https://issues.apache.org/jira/browse/ARTEMIS-4382?focusedWorklogId=873939&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-873939
]
ASF GitHub Bot logged work on ARTEMIS-4382:
---
Author: ASF GitHub Bot
Created on: 01/Aug/23 03:05
Start Date: 01/Aug/23 03:05
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4572:
URL: https://github.com/apache/activemq-artemis/pull/4572#discussion_r1280064266
##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/DBOption.java:
##
@@ -172,7 +183,7 @@ public Object execute(ActionContext context) throws
Exception {
super.execute(context);
if (output != null) {
- fileOutputStream = new FileOutputStream(output);
+ fileOutputStream = new BufferedOutputStream(new
FileOutputStream(output));
Review Comment:
this is the fix for the export ... it would take forever without this..
Issue Time Tracking
---
Worklog Id: (was: 873939)
Time Spent: 20m (was: 10m)
> CLI import / export may take a huge amount of time in large datasets.
> -
>
> Key: ARTEMIS-4382
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4382
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.30.0
>Reporter: Clebert Suconic
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.31.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (AMQ-9292) Update stompjms 1.27
[ https://issues.apache.org/jira/browse/AMQ-9292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré reassigned AMQ-9292: - Assignee: Jean-Baptiste Onofré > Update stompjms 1.27 > > > Key: AMQ-9292 > URL: https://issues.apache.org/jira/browse/AMQ-9292 > Project: ActiveMQ > Issue Type: Dependency upgrade >Reporter: Matt Pavlovich >Assignee: Jean-Baptiste Onofré >Priority: Minor > > Update stompjms to 1.27 and new groupId -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AMQ-9290) Upgrade ActiveMQ 5.18.x to Camel 3
[ https://issues.apache.org/jira/browse/AMQ-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17749459#comment-17749459 ] Jean-Baptiste Onofré commented on AMQ-9290: --- FYI, we plan to fully remove Camel from ActiveMQ 5.19.x as the component is now in Camel (nothing required in ActiveMQ anymore). > Upgrade ActiveMQ 5.18.x to Camel 3 > -- > > Key: AMQ-9290 > URL: https://issues.apache.org/jira/browse/AMQ-9290 > Project: ActiveMQ > Issue Type: Task >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Major > > Camel 3 is needed for JDK 17 support. We should align as the last LTS > JDK 17 LTS + ActiveMQ 5.18.x + JMS (javax.jms) + Camel 3.x -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (AMQ-9291) networkConnector does not support IPv6 address
[
https://issues.apache.org/jira/browse/AMQ-9291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jean-Baptiste Onofré reassigned AMQ-9291:
-
Assignee: Jean-Baptiste Onofré
> networkConnector does not support IPv6 address
> --
>
> Key: AMQ-9291
> URL: https://issues.apache.org/jira/browse/AMQ-9291
> Project: ActiveMQ
> Issue Type: Bug
> Components: Connector
>Affects Versions: 5.16.6, 5.17.5, 5.18.2
>Reporter: Greg Rabil
>Assignee: Jean-Baptiste Onofré
>Priority: Blocker
>
> In ActiveMQ 5.15.15, the following networkConnector URI works for connecting
> to an ActiveMQ broker over IPv6:
> uri="static:(failover:(ssl://[fd00::15]:61617?verifyHostName=false)?initialReconnectDelay=100&randomize=false)"/>
>
> However, in ActiveMQ 5.16, 5.17, and 5.18, this will fail with the following
> error (warning):
> 2023-07-17 12:52:30,825 | WARN | Failed to connect to
> [ssl://[fd00::15]:61617?verifyHostName=false] after: 1 attempt(s) with
> Contains non-LDH ASCII characters, continuing to retry. |
> org.apache.activemq.transport.failover.FailoverTransport | ActiveMQ Failover
> Worker: 1448780972
>
> The problem is caused by this new code in the
> org.apache.activemq.transport.tcp.SslTransport.java class:
> {{ // Lets try to configure the SSL SNI field. Handy in case your
> using}}
> {{ // a single proxy to route to different messaging apps.}}
> {{ final SSLParameters sslParams = new SSLParameters();}}
> {{ if (remoteLocation != null) {}}
> {{ sslParams.setServerNames(Collections.singletonList(new
> SNIHostName(remoteLocation.getHost(;}}
> {{ }}}
>
> The remoteLocation.getHost() will return "[fd00::15]", which causes the
> exception in the SNIHostName constructor. It seems that the above condition
> should be:
>
> {{ if ((remoteLocation != null) && verifyHostName) {}}
> {{ sslParams.setServerNames(Collections.singletonList(new
> SNIHostName(remoteLocation.getHost(;}}
> {{ }}}
>
> Because the SNIHostName only makes sense in the context of verifying the
> hostname of the server certificate.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (AMQ-9293) Upgrade to Spring 5.3.29
Jean-Baptiste Onofré created AMQ-9293: - Summary: Upgrade to Spring 5.3.29 Key: AMQ-9293 URL: https://issues.apache.org/jira/browse/AMQ-9293 Project: ActiveMQ Issue Type: Dependency upgrade Reporter: Jean-Baptiste Onofré Assignee: Jean-Baptiste Onofré Fix For: 5.18.3, 5.17.6 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (AMQ-9293) Upgrade to Spring 5.3.29
[ https://issues.apache.org/jira/browse/AMQ-9293?focusedWorklogId=873962&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-873962 ] ASF GitHub Bot logged work on AMQ-9293: --- Author: ASF GitHub Bot Created on: 01/Aug/23 05:36 Start Date: 01/Aug/23 05:36 Worklog Time Spent: 10m Work Description: jbonofre opened a new pull request, #1040: URL: https://github.com/apache/activemq/pull/1040 (no comment) Issue Time Tracking --- Worklog Id: (was: 873962) Remaining Estimate: 0h Time Spent: 10m > Upgrade to Spring 5.3.29 > > > Key: AMQ-9293 > URL: https://issues.apache.org/jira/browse/AMQ-9293 > Project: ActiveMQ > Issue Type: Dependency upgrade >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 5.18.3, 5.17.6 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (AMQ-9239) Jakarta JMS package namespace for broker
[ https://issues.apache.org/jira/browse/AMQ-9239?focusedWorklogId=873971&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-873971 ] ASF GitHub Bot logged work on AMQ-9239: --- Author: ASF GitHub Bot Created on: 01/Aug/23 06:13 Start Date: 01/Aug/23 06:13 Worklog Time Spent: 10m Work Description: ksdevelops commented on PR #996: URL: https://github.com/apache/activemq/pull/996#issuecomment-1659631908 > @narendranss @prasad5400 reminder Issue Time Tracking --- Worklog Id: (was: 873971) Time Spent: 4.5h (was: 4h 20m) > Jakarta JMS package namespace for broker > > > Key: AMQ-9239 > URL: https://issues.apache.org/jira/browse/AMQ-9239 > Project: ActiveMQ > Issue Type: New Feature >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Major > Time Spent: 4.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
