[jira] [Commented] (ARTEMIS-4447) Add paging prefetch parameters into address settings
[ https://issues.apache.org/jira/browse/ARTEMIS-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770604#comment-17770604 ] ASF subversion and git services commented on ARTEMIS-4447: -- Commit 7c9a15e9b4dc86ca81ff26f6d29d359f1ac3d931 in activemq-artemis's branch refs/heads/main from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=7c9a15e9b4 ] ARTEMIS-4447 Add paging prefetch parameters into address settings we are adding new attributes to determine how many messages (or bytes) we are reading from paging into Queue memory. > Add paging prefetch parameters into address settings > > > Key: ARTEMIS-4447 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4447 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.31.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.32.0 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > we should include optimal prefetch values for paging. Right now the system > will always read up to max-read-page-messages and max-read-page-bytes. We > should have a separate configuration attribute for the prefetch value. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4447) Add paging prefetch parameters into address settings
[ https://issues.apache.org/jira/browse/ARTEMIS-4447?focusedWorklogId=882720&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882720 ] ASF GitHub Bot logged work on ARTEMIS-4447: --- Author: ASF GitHub Bot Created on: 29/Sep/23 22:43 Start Date: 29/Sep/23 22:43 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #4637: URL: https://github.com/apache/activemq-artemis/pull/4637 Issue Time Tracking --- Worklog Id: (was: 882720) Time Spent: 1h 40m (was: 1.5h) > Add paging prefetch parameters into address settings > > > Key: ARTEMIS-4447 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4447 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.31.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.32.0 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > we should include optimal prefetch values for paging. Right now the system > will always read up to max-read-page-messages and max-read-page-bytes. We > should have a separate configuration attribute for the prefetch value. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4447) Add paging prefetch parameters into address settings
[ https://issues.apache.org/jira/browse/ARTEMIS-4447?focusedWorklogId=882719&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882719 ] ASF GitHub Bot logged work on ARTEMIS-4447: --- Author: ASF GitHub Bot Created on: 29/Sep/23 22:43 Start Date: 29/Sep/23 22:43 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4637: URL: https://github.com/apache/activemq-artemis/pull/4637#issuecomment-1741557186 I am going to merge this now further fixes in documentation (or anything else) can be sent before a release. thanks for all the help. Issue Time Tracking --- Worklog Id: (was: 882719) Time Spent: 1.5h (was: 1h 20m) > Add paging prefetch parameters into address settings > > > Key: ARTEMIS-4447 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4447 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.31.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.32.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > we should include optimal prefetch values for paging. Right now the system > will always read up to max-read-page-messages and max-read-page-bytes. We > should have a separate configuration attribute for the prefetch value. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4447) Add paging prefetch parameters into address settings
[ https://issues.apache.org/jira/browse/ARTEMIS-4447?focusedWorklogId=882706&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882706 ] ASF GitHub Bot logged work on ARTEMIS-4447: --- Author: ASF GitHub Bot Created on: 29/Sep/23 18:53 Start Date: 29/Sep/23 18:53 Worklog Time Spent: 10m Work Description: clebertsuconic commented on code in PR #4637: URL: https://github.com/apache/activemq-artemis/pull/4637#discussion_r1341702295 ## docs/user-manual/paging.adoc: ## @@ -135,10 +141,10 @@ The configured policy will start based on the first value to reach its mark. Maximum read from page -`max-read-page-messages` and `max-read-page-bytes` are used to control messaging reading from paged file into the Queue. -The broker will add messages on the Queue until either `max-read-page-meessages` or `max-read-page-bytes` reaches the limit. +`max-read-page-messages`, `max-read-page-bytes`, `prefetch-page-messages` and `prefetch-page-bytes` are used to control reading from paged file into the Queue. +The broker will add messages as long as all these limits are satisfied. -If both values are set to -1 the broker will keep reading messages as long as the consumer is reaching for more messages. +If all these values are set to -1 the broker will keep reading messages as long as the consumer is reaching for more messages. Review Comment: I will actually update the code to use all these values. Issue Time Tracking --- Worklog Id: (was: 882706) Time Spent: 1h 20m (was: 1h 10m) > Add paging prefetch parameters into address settings > > > Key: ARTEMIS-4447 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4447 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.31.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.32.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > we should include optimal prefetch values for paging. Right now the system > will always read up to max-read-page-messages and max-read-page-bytes. We > should have a separate configuration attribute for the prefetch value. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4448) Remove winsw
[ https://issues.apache.org/jira/browse/ARTEMIS-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emmanuel Hugonnet updated ARTEMIS-4448: --- Summary: Remove winsw (was: Upgrade winsw to 2.12.0) > Remove winsw > > > Key: ARTEMIS-4448 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4448 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade > Components: Broker >Affects Versions: 2.31.0 >Reporter: Emmanuel Hugonnet >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > the winws version is quite old (5 years old) , we should upgrade to 2.12.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4448) Upgrade winsw to 2.12.0
[ https://issues.apache.org/jira/browse/ARTEMIS-4448?focusedWorklogId=882693&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882693 ] ASF GitHub Bot logged work on ARTEMIS-4448: --- Author: ASF GitHub Bot Created on: 29/Sep/23 17:26 Start Date: 29/Sep/23 17:26 Worklog Time Spent: 10m Work Description: ehsavoie closed pull request #4638: ARTEMIS-4448 Upgrade winsw to 2.12.0 URL: https://github.com/apache/activemq-artemis/pull/4638 Issue Time Tracking --- Worklog Id: (was: 882693) Time Spent: 20m (was: 10m) > Upgrade winsw to 2.12.0 > --- > > Key: ARTEMIS-4448 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4448 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade > Components: Broker >Affects Versions: 2.31.0 >Reporter: Emmanuel Hugonnet >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > the winws version is quite old (5 years old) , we should upgrade to 2.12.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4448) Remove winsw
[ https://issues.apache.org/jira/browse/ARTEMIS-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emmanuel Hugonnet updated ARTEMIS-4448: --- Description: Instead of providing winsw as part of Artemis we should remove it and provide the information to install it tso that a windows service can be created (was: the winws version is quite old (5 years old) , we should upgrade to 2.12.0) > Remove winsw > > > Key: ARTEMIS-4448 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4448 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade > Components: Broker >Affects Versions: 2.31.0 >Reporter: Emmanuel Hugonnet >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Instead of providing winsw as part of Artemis we should remove it and provide > the information to install it tso that a windows service can be created -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4448) Upgrade winsw to 2.12.0
[ https://issues.apache.org/jira/browse/ARTEMIS-4448?focusedWorklogId=882689&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882689 ] ASF GitHub Bot logged work on ARTEMIS-4448: --- Author: ASF GitHub Bot Created on: 29/Sep/23 17:06 Start Date: 29/Sep/23 17:06 Worklog Time Spent: 10m Work Description: ehsavoie opened a new pull request, #4638: URL: https://github.com/apache/activemq-artemis/pull/4638 (no comment) Issue Time Tracking --- Worklog Id: (was: 882689) Remaining Estimate: 0h Time Spent: 10m > Upgrade winsw to 2.12.0 > --- > > Key: ARTEMIS-4448 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4448 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade > Components: Broker >Affects Versions: 2.31.0 >Reporter: Emmanuel Hugonnet >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > the winws version is quite old (5 years old) , we should upgrade to 2.12.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ARTEMIS-4448) Upgrade winsw to 2.12.0
[ https://issues.apache.org/jira/browse/ARTEMIS-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emmanuel Hugonnet updated ARTEMIS-4448: --- Summary: Upgrade winsw to 2.12.0 (was: Upgrade winws to 2.12.0) > Upgrade winsw to 2.12.0 > --- > > Key: ARTEMIS-4448 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4448 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade > Components: Broker >Affects Versions: 2.31.0 >Reporter: Emmanuel Hugonnet >Priority: Major > > the winws version is quite old (5 years old) , we should upgrade to 2.12.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARTEMIS-4448) Upgrade winws to 2.12.0
Emmanuel Hugonnet created ARTEMIS-4448: -- Summary: Upgrade winws to 2.12.0 Key: ARTEMIS-4448 URL: https://issues.apache.org/jira/browse/ARTEMIS-4448 Project: ActiveMQ Artemis Issue Type: Dependency upgrade Components: Broker Affects Versions: 2.31.0 Reporter: Emmanuel Hugonnet the winws version is quite old (5 years old) , we should upgrade to 2.12.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AMQ-9308) RedeliveryPlugin: make scheduleRedelivery method protected to ease inheritance
[ https://issues.apache.org/jira/browse/AMQ-9308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770504#comment-17770504 ] Jean-Baptiste Onofré commented on AMQ-9308: --- It sounds reasonable. I gonna change that adding related tests as well. > RedeliveryPlugin: make scheduleRedelivery method protected to ease inheritance > -- > > Key: AMQ-9308 > URL: https://issues.apache.org/jira/browse/AMQ-9308 > Project: ActiveMQ > Issue Type: Improvement > Components: Broker >Affects Versions: 5.16.6 >Reporter: Martin Lichtin >Assignee: Jean-Baptiste Onofré >Priority: Major > > RedeliveryPlugin: make scheduleRedelivery method protected to ease inheritance > When extending the RedeliveryPlugin class, it'd be useful to use the existing > scheduleRedelivery() method -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AMQ-9296) Support ACTIVEMQ_USER and ACTIVEMQ_PASSWORD env vars in Docker images
[ https://issues.apache.org/jira/browse/AMQ-9296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770503#comment-17770503 ] Jean-Baptiste Onofré commented on AMQ-9296: --- Good idea and thanks for the PR, I gonna review it. > Support ACTIVEMQ_USER and ACTIVEMQ_PASSWORD env vars in Docker images > - > > Key: AMQ-9296 > URL: https://issues.apache.org/jira/browse/AMQ-9296 > Project: ActiveMQ > Issue Type: Improvement >Reporter: Eddú Meléndez >Assignee: Jean-Baptiste Onofré >Priority: Major > > Docker images for Apache ActiveMQ have been published > [https://hub.docker.com/r/apache/activemq-classic/tags] > It would be great to support env vars for USER and PASSWORD. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (AMQ-9308) RedeliveryPlugin: make scheduleRedelivery method protected to ease inheritance
[ https://issues.apache.org/jira/browse/AMQ-9308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré reassigned AMQ-9308: - Assignee: Jean-Baptiste Onofré > RedeliveryPlugin: make scheduleRedelivery method protected to ease inheritance > -- > > Key: AMQ-9308 > URL: https://issues.apache.org/jira/browse/AMQ-9308 > Project: ActiveMQ > Issue Type: Improvement > Components: Broker >Affects Versions: 5.16.6 >Reporter: Martin Lichtin >Assignee: Jean-Baptiste Onofré >Priority: Major > > RedeliveryPlugin: make scheduleRedelivery method protected to ease inheritance > When extending the RedeliveryPlugin class, it'd be useful to use the existing > scheduleRedelivery() method -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AMQ-9299) Unknown license gram dependency
[ https://issues.apache.org/jira/browse/AMQ-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770501#comment-17770501 ] Jean-Baptiste Onofré commented on AMQ-9299: --- I think we can remove gram completely. Not necessary in openwire itself but maybe as a transitive deps. I'm testing a new packaging now. I will keep you posted. > Unknown license gram dependency > --- > > Key: AMQ-9299 > URL: https://issues.apache.org/jira/browse/AMQ-9299 > Project: ActiveMQ > Issue Type: Task >Reporter: Henri Yandell >Assignee: Matt Pavlovich >Priority: Trivial > Fix For: 6.0.1 > > > Found an interesting "what's the license?" in this project. > [https://repo1.maven.org/maven2/org/apache/activemq/activemq-openwire-generator/5.18.2/activemq-openwire-generator-5.18.2.pom] > That component is still getting released regularly. It depends on > "org.codehaus.gram-1.1". Which isold. And also without clear license, and > no source code available. It looks like it's a bit of flotsam that happened > during Groovy's early years and if any of it has survived, it has morphed > into something else. > I don't see the source using it. The jar itself only contains: > 3537 10-03-2005 10:01 org/codehaus/gram/Gram.class > 1864 10-03-2005 10:01 org/codehaus/gram/GramModule.class > 2875 10-03-2005 10:01 org/codehaus/gram/GramSupport.class > 4467 10-03-2005 10:01 org/codehaus/gram/GramTask.class > 3318 10-03-2005 10:01 org/codehaus/gram/hibernate/ColumnInfo.class > 2275 10-03-2005 10:01 > org/codehaus/gram/hibernate/HibernateSupport.class > Though reading OPENWIRE-46; it sounds like this entire repo may want to go. > If so...why is this still being released as an artifact? > I originally opened this as OPENWIRE-64 but suggestion on Slack was to open > here as that Jira project was not active. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (AMQ-9299) Unknown license gram dependency
[ https://issues.apache.org/jira/browse/AMQ-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré reassigned AMQ-9299: - Assignee: Jean-Baptiste Onofré (was: Matt Pavlovich) > Unknown license gram dependency > --- > > Key: AMQ-9299 > URL: https://issues.apache.org/jira/browse/AMQ-9299 > Project: ActiveMQ > Issue Type: Task >Reporter: Henri Yandell >Assignee: Jean-Baptiste Onofré >Priority: Trivial > Fix For: 6.0.1 > > > Found an interesting "what's the license?" in this project. > [https://repo1.maven.org/maven2/org/apache/activemq/activemq-openwire-generator/5.18.2/activemq-openwire-generator-5.18.2.pom] > That component is still getting released regularly. It depends on > "org.codehaus.gram-1.1". Which isold. And also without clear license, and > no source code available. It looks like it's a bit of flotsam that happened > during Groovy's early years and if any of it has survived, it has morphed > into something else. > I don't see the source using it. The jar itself only contains: > 3537 10-03-2005 10:01 org/codehaus/gram/Gram.class > 1864 10-03-2005 10:01 org/codehaus/gram/GramModule.class > 2875 10-03-2005 10:01 org/codehaus/gram/GramSupport.class > 4467 10-03-2005 10:01 org/codehaus/gram/GramTask.class > 3318 10-03-2005 10:01 org/codehaus/gram/hibernate/ColumnInfo.class > 2275 10-03-2005 10:01 > org/codehaus/gram/hibernate/HibernateSupport.class > Though reading OPENWIRE-46; it sounds like this entire repo may want to go. > If so...why is this still being released as an artifact? > I originally opened this as OPENWIRE-64 but suggestion on Slack was to open > here as that Jira project was not active. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (AMQ-9296) Support ACTIVEMQ_USER and ACTIVEMQ_PASSWORD env vars in Docker images
[ https://issues.apache.org/jira/browse/AMQ-9296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré reassigned AMQ-9296: - Assignee: Jean-Baptiste Onofré > Support ACTIVEMQ_USER and ACTIVEMQ_PASSWORD env vars in Docker images > - > > Key: AMQ-9296 > URL: https://issues.apache.org/jira/browse/AMQ-9296 > Project: ActiveMQ > Issue Type: Improvement >Reporter: Eddú Meléndez >Assignee: Jean-Baptiste Onofré >Priority: Major > > Docker images for Apache ActiveMQ have been published > [https://hub.docker.com/r/apache/activemq-classic/tags] > It would be great to support env vars for USER and PASSWORD. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AMQ-9312) Upgrade to Spring 6.0.12
[ https://issues.apache.org/jira/browse/AMQ-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770497#comment-17770497 ] ASF subversion and git services commented on AMQ-9312: -- Commit 42ba96eae73915743d85be4ae4cb81bdc1dcca9e in activemq's branch refs/heads/main from JB Onofré [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=42ba96eae ] AMQ-9312: Upgrade to Spring 6.0.12 > Upgrade to Spring 6.0.12 > > > Key: AMQ-9312 > URL: https://issues.apache.org/jira/browse/AMQ-9312 > Project: ActiveMQ > Issue Type: Dependency upgrade > Components: Broker >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (AMQ-9312) Upgrade to Spring 6.0.12
[ https://issues.apache.org/jira/browse/AMQ-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jean-Baptiste Onofré resolved AMQ-9312. --- Resolution: Fixed > Upgrade to Spring 6.0.12 > > > Key: AMQ-9312 > URL: https://issues.apache.org/jira/browse/AMQ-9312 > Project: ActiveMQ > Issue Type: Dependency upgrade > Components: Broker >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (AMQ-9312) Upgrade to Spring 6.0.12
[ https://issues.apache.org/jira/browse/AMQ-9312?focusedWorklogId=882686&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882686 ] ASF GitHub Bot logged work on AMQ-9312: --- Author: ASF GitHub Bot Created on: 29/Sep/23 16:08 Start Date: 29/Sep/23 16:08 Worklog Time Spent: 10m Work Description: jbonofre merged PR #1058: URL: https://github.com/apache/activemq/pull/1058 Issue Time Tracking --- Worklog Id: (was: 882686) Time Spent: 20m (was: 10m) > Upgrade to Spring 6.0.12 > > > Key: AMQ-9312 > URL: https://issues.apache.org/jira/browse/AMQ-9312 > Project: ActiveMQ > Issue Type: Dependency upgrade > Components: Broker >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AMQ-9312) Upgrade to Spring 6.0.12
[ https://issues.apache.org/jira/browse/AMQ-9312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770498#comment-17770498 ] ASF subversion and git services commented on AMQ-9312: -- Commit 7215057bc57386c76e84c65a4b11defa01dc0b9f in activemq's branch refs/heads/main from JB Onofré [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=7215057bc ] Merge pull request #1058 from jbonofre/AMQ-9312 AMQ-9312: Upgrade to Spring 6.0.12 > Upgrade to Spring 6.0.12 > > > Key: AMQ-9312 > URL: https://issues.apache.org/jira/browse/AMQ-9312 > Project: ActiveMQ > Issue Type: Dependency upgrade > Components: Broker >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4447) Add paging prefetch parameters into address settings
[ https://issues.apache.org/jira/browse/ARTEMIS-4447?focusedWorklogId=882683&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882683 ] ASF GitHub Bot logged work on ARTEMIS-4447: --- Author: ASF GitHub Bot Created on: 29/Sep/23 15:43 Start Date: 29/Sep/23 15:43 Worklog Time Spent: 10m Work Description: gemmellr commented on code in PR #4637: URL: https://github.com/apache/activemq-artemis/pull/4637#discussion_r1341530564 ## artemis-server/src/main/resources/schema/artemis-configuration.xsd: ## @@ -3937,11 +3937,29 @@ - + Review Comment: (presumably this is what made the test runs all fail) Issue Time Tracking --- Worklog Id: (was: 882683) Time Spent: 1h 10m (was: 1h) > Add paging prefetch parameters into address settings > > > Key: ARTEMIS-4447 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4447 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.31.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.32.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > we should include optimal prefetch values for paging. Right now the system > will always read up to max-read-page-messages and max-read-page-bytes. We > should have a separate configuration attribute for the prefetch value. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4447) Add paging prefetch parameters into address settings
[ https://issues.apache.org/jira/browse/ARTEMIS-4447?focusedWorklogId=882682&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882682 ] ASF GitHub Bot logged work on ARTEMIS-4447: --- Author: ASF GitHub Bot Created on: 29/Sep/23 15:42 Start Date: 29/Sep/23 15:42 Worklog Time Spent: 10m Work Description: gemmellr commented on code in PR #4637: URL: https://github.com/apache/activemq-artemis/pull/4637#discussion_r1341494715 ## artemis-server/src/main/resources/schema/artemis-configuration.xsd: ## @@ -3937,11 +3937,29 @@ - + + + + How many messages we are reading from paging and keeping ready in queues ready to deliver to consumers. Default: If not defined max-read-page-messages is used. Review Comment: This, coupled with max-page-read-size starting "How many messages are we allowed to read from page into the Queue each time." doesnt do that great a job of conveying the behaviour or relationship between the two. Arguably max-read-page-messages needs updated to drop the "each time" to help clarify it being a limit on the total read in, while this one further allows limiting the amount read in at any given time to a smaller number. ```suggestion How many messages the broker will read from paging and keep ready in queues ready to deliver to consumers. Default: If not defined max-read-page-messages is used. ``` ## docs/user-manual/paging.adoc: ## @@ -135,10 +141,10 @@ The configured policy will start based on the first value to reach its mark. Maximum read from page -`max-read-page-messages` and `max-read-page-bytes` are used to control messaging reading from paged file into the Queue. -The broker will add messages on the Queue until either `max-read-page-meessages` or `max-read-page-bytes` reaches the limit. +`max-read-page-messages`, `max-read-page-bytes`, `prefetch-page-messages` and `prefetch-page-bytes` are used to control reading from paged file into the Queue. +The broker will add messages as long as all these limits are satisfied. -If both values are set to -1 the broker will keep reading messages as long as the consumer is reaching for more messages. +If all these values are set to -1 the broker will keep reading messages as long as the consumer is reaching for more messages. Review Comment: Its still just if `max-read-page-messages` and `max-read-page-bytes`are set to <=0, as it was before before, so its probably clearer to just say that. ```suggestion If `max-read-page-messages` and `max-read-page-bytes` are set to -1 the broker will keep reading messages as long as the consumer is reaching for more messages. The `prefetch-page-messages` and `prefetch-page-bytes` will not be considered. ``` ## artemis-server/src/main/resources/schema/artemis-configuration.xsd: ## @@ -3937,11 +3937,29 @@ - + Review Comment: c&p error on the default, this is the messages one so 20MB doesnt make sense. Issue Time Tracking --- Worklog Id: (was: 882682) Time Spent: 1h (was: 50m) > Add paging prefetch parameters into address settings > > > Key: ARTEMIS-4447 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4447 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.31.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.32.0 > > Time Spent: 1h > Remaining Estimate: 0h > > we should include optimal prefetch values for paging. Right now the system > will always read up to max-read-page-messages and max-read-page-bytes. We > should have a separate configuration attribute for the prefetch value. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (AMQ-8391) Consolidate to a single JAAS for jmx, messaging and web layers
[ https://issues.apache.org/jira/browse/AMQ-8391?focusedWorklogId=882681&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882681 ] ASF GitHub Bot logged work on AMQ-8391: --- Author: ASF GitHub Bot Created on: 29/Sep/23 15:35 Start Date: 29/Sep/23 15:35 Worklog Time Spent: 10m Work Description: mattrpav commented on PR #1057: URL: https://github.com/apache/activemq/pull/1057#issuecomment-1741086805 @jbonofre @cshannon This is what is done: Issue Time Tracking --- Worklog Id: (was: 882681) Time Spent: 20m (was: 10m) > Consolidate to a single JAAS for jmx, messaging and web layers > -- > > Key: AMQ-8391 > URL: https://issues.apache.org/jira/browse/AMQ-8391 > Project: ActiveMQ > Issue Type: Task >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Major > Fix For: 6.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Currently, the default Apache ActiveMQ distribution has 3 user and group > backends-- jmx, messaging and web. > Update: > 1. Migrate the jetty.xml to use the JAAS backend used for messaging > 2. Add the jaasAuthentication to default activemq.xml (so it is explicitly > visible) > 3. Update the web-console servlet to permite access via 'web-console-role' > 4. Update the api servlet to allow access using 'rest-role' > 5. Add admin to the 'web-console-role' and 'rest-role' by default > 6. Migrate jmx to use the 'activemq' realm > 7. Create default jmx-readwrite-role and jmx-readonly-role roles in the > conf/jmx.access file > 8. Include the config breaking change in release notes -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AMQ-9311) Remove startup script support for JDK < 17
[ https://issues.apache.org/jira/browse/AMQ-9311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770478#comment-17770478 ] ASF subversion and git services commented on AMQ-9311: -- Commit 5f62d5d67f47f9a634d939e6f43d112a17b3e0ba in activemq's branch refs/heads/main from Matt Pavlovich [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=5f62d5d67 ] [AMQ-9311] Remove support for JDK less than 17 from startup scripts > Remove startup script support for JDK < 17 > -- > > Key: AMQ-9311 > URL: https://issues.apache.org/jira/browse/AMQ-9311 > Project: ActiveMQ > Issue Type: Task >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Major > Fix For: 6.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The startup scripts contain jdk version checks for > 8 to handle java > modules. Since, we are JDK 17+ now, we can reduce cruft by removing these > parts -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (AMQ-9311) Remove startup script support for JDK < 17
[ https://issues.apache.org/jira/browse/AMQ-9311?focusedWorklogId=882678&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882678 ] ASF GitHub Bot logged work on AMQ-9311: --- Author: ASF GitHub Bot Created on: 29/Sep/23 15:10 Start Date: 29/Sep/23 15:10 Worklog Time Spent: 10m Work Description: mattrpav merged PR #1056: URL: https://github.com/apache/activemq/pull/1056 Issue Time Tracking --- Worklog Id: (was: 882678) Time Spent: 20m (was: 10m) > Remove startup script support for JDK < 17 > -- > > Key: AMQ-9311 > URL: https://issues.apache.org/jira/browse/AMQ-9311 > Project: ActiveMQ > Issue Type: Task >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Major > Fix For: 6.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The startup scripts contain jdk version checks for > 8 to handle java > modules. Since, we are JDK 17+ now, we can reduce cruft by removing these > parts -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (AMQ-9311) Remove startup script support for JDK < 17
[ https://issues.apache.org/jira/browse/AMQ-9311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Pavlovich resolved AMQ-9311. - Resolution: Fixed > Remove startup script support for JDK < 17 > -- > > Key: AMQ-9311 > URL: https://issues.apache.org/jira/browse/AMQ-9311 > Project: ActiveMQ > Issue Type: Task >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Major > Fix For: 6.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The startup scripts contain jdk version checks for > 8 to handle java > modules. Since, we are JDK 17+ now, we can reduce cruft by removing these > parts -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4447) Add paging prefetch parameters into address settings
[ https://issues.apache.org/jira/browse/ARTEMIS-4447?focusedWorklogId=882658&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882658 ] ASF GitHub Bot logged work on ARTEMIS-4447: --- Author: ASF GitHub Bot Created on: 29/Sep/23 14:22 Start Date: 29/Sep/23 14:22 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #4637: URL: https://github.com/apache/activemq-artemis/pull/4637#issuecomment-1740975653 @gemmellr docs are updated... Issue Time Tracking --- Worklog Id: (was: 882658) Time Spent: 40m (was: 0.5h) > Add paging prefetch parameters into address settings > > > Key: ARTEMIS-4447 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4447 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.31.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.32.0 > > Time Spent: 40m > Remaining Estimate: 0h > > we should include optimal prefetch values for paging. Right now the system > will always read up to max-read-page-messages and max-read-page-bytes. We > should have a separate configuration attribute for the prefetch value. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4447) Add paging prefetch parameters into address settings
[
https://issues.apache.org/jira/browse/ARTEMIS-4447?focusedWorklogId=882659&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882659
]
ASF GitHub Bot logged work on ARTEMIS-4447:
---
Author: ASF GitHub Bot
Created on: 29/Sep/23 14:22
Start Date: 29/Sep/23 14:22
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4637:
URL: https://github.com/apache/activemq-artemis/pull/4637#discussion_r1341430836
##
artemis-server/src/test/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImplTest.java:
##
@@ -1623,6 +1623,32 @@ public void
testAddressSettingsPageLimitInvalidConfiguration5() throws Throwable
Assert.assertEquals(null, storeImpl.getPageFullMessagePolicy());
}
+ @Test
+ public void testPagePrefetch() throws Throwable {
+ ConfigurationImpl configuration = new ConfigurationImpl();
+
+ Properties properties = new Properties();
+
+ String randomString = RandomUtil.randomString();
+
+ properties.put("addressSettings.#.expiryAddress", randomString);
+ properties.put("addressSettings.#.prefetchPageMessages", "333"); // this
should make the PagingStore to parse it as null
+ properties.put("addressSettings.#.prefetchPageBytes", "777"); // this
should make the PagingStore to parse it as null
+
+ configuration.parsePrefixedProperties(properties, null);
+
+ Assert.assertEquals(1, configuration.getAddressSettings().size());
+ Assert.assertEquals(SimpleString.toSimpleString(randomString),
configuration.getAddressSettings().get("#").getExpiryAddress());
+ Assert.assertEquals(333,
configuration.getAddressSettings().get("#").getPrefetchPageMessages());
+ Assert.assertEquals(777,
configuration.getAddressSettings().get("#").getPrefetchPageBytes());
+
+ PagingStore storeImpl = new PagingStoreImpl(new SimpleString("Test"),
(ScheduledExecutorService) null, 100L, Mockito.mock(PagingManager.class),
Mockito.mock(StorageManager.class), Mockito.mock(SequentialFileFactory.class),
Mockito.mock(PagingStoreFactory.class), new SimpleString("Test"),
configuration.getAddressSettings().get("#"), null, null, true);
+
+ Assert.assertEquals(333, storeImpl.getPrefetchPageMessages());
+ Assert.assertEquals(777, storeImpl.getPrefetchPageBytes());
+ }
+
+
Review Comment:
I need to do this one still... doing it now.
Issue Time Tracking
---
Worklog Id: (was: 882659)
Time Spent: 50m (was: 40m)
> Add paging prefetch parameters into address settings
>
>
> Key: ARTEMIS-4447
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4447
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Affects Versions: 2.31.0
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.32.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> we should include optimal prefetch values for paging. Right now the system
> will always read up to max-read-page-messages and max-read-page-bytes. We
> should have a separate configuration attribute for the prefetch value.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4447) Add paging prefetch parameters into address settings
[
https://issues.apache.org/jira/browse/ARTEMIS-4447?focusedWorklogId=882638&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882638
]
ASF GitHub Bot logged work on ARTEMIS-4447:
---
Author: ASF GitHub Bot
Created on: 29/Sep/23 12:56
Start Date: 29/Sep/23 12:56
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4637:
URL: https://github.com/apache/activemq-artemis/pull/4637#discussion_r1341331633
##
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PageFilterTest.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.tests.integration.paging;
+
+import javax.jms.Connection;
+import javax.jms.ConnectionFactory;
+import javax.jms.Message;
+import javax.jms.MessageConsumer;
+import javax.jms.MessageProducer;
+import javax.jms.Session;
+import javax.jms.Topic;
+
+import java.lang.invoke.MethodHandles;
+
+import org.apache.activemq.artemis.api.core.RoutingType;
+import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.core.server.ActiveMQServer;
+import org.apache.activemq.artemis.core.server.impl.AddressInfo;
+import org.apache.activemq.artemis.core.settings.impl.AddressSettings;
+import org.apache.activemq.artemis.tests.util.ActiveMQTestBase;
+import org.apache.activemq.artemis.tests.util.CFUtil;
+import org.apache.activemq.artemis.tests.util.PrintDataUtil;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class PageFilterTest extends ActiveMQTestBase {
Review Comment:
When I started investigation this issue, I had an OME and a heap dump from a
user, and it seemed the issue was on filtering.
In the end the issue I was investigating was a result of misconfigured
maxes.. and I left the test here.
There are other tests testing filtering.. I will remove that test from this
PR.
Issue Time Tracking
---
Worklog Id: (was: 882638)
Time Spent: 0.5h (was: 20m)
> Add paging prefetch parameters into address settings
>
>
> Key: ARTEMIS-4447
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4447
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Affects Versions: 2.31.0
>Reporter: Clebert Suconic
>Priority: Major
> Fix For: 2.32.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> we should include optimal prefetch values for paging. Right now the system
> will always read up to max-read-page-messages and max-read-page-bytes. We
> should have a separate configuration attribute for the prefetch value.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (AMQ-9314) Upgrade to Jetty 11.0.16
[ https://issues.apache.org/jira/browse/AMQ-9314?focusedWorklogId=882635&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882635 ] ASF GitHub Bot logged work on AMQ-9314: --- Author: ASF GitHub Bot Created on: 29/Sep/23 12:55 Start Date: 29/Sep/23 12:55 Worklog Time Spent: 10m Work Description: jbonofre opened a new pull request, #1060: URL: https://github.com/apache/activemq/pull/1060 (no comment) Issue Time Tracking --- Worklog Id: (was: 882635) Remaining Estimate: 0h Time Spent: 10m > Upgrade to Jetty 11.0.16 > > > Key: AMQ-9314 > URL: https://issues.apache.org/jira/browse/AMQ-9314 > Project: ActiveMQ > Issue Type: Dependency upgrade > Components: Transport, Web Console >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.0.0 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (ARTEMIS-4439) Upgrade Netty to 4.1.99.Final
[ https://issues.apache.org/jira/browse/ARTEMIS-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic closed ARTEMIS-4439. > Upgrade Netty to 4.1.99.Final > - > > Key: ARTEMIS-4439 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4439 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Fix For: 2.32.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (AMQ-9314) Upgrade to Jetty 11.0.16
Jean-Baptiste Onofré created AMQ-9314: - Summary: Upgrade to Jetty 11.0.16 Key: AMQ-9314 URL: https://issues.apache.org/jira/browse/AMQ-9314 Project: ActiveMQ Issue Type: Dependency upgrade Components: Transport, Web Console Reporter: Jean-Baptiste Onofré Assignee: Jean-Baptiste Onofré Fix For: 6.0.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (AMQ-9313) Upgrade to ASM 9.5
[ https://issues.apache.org/jira/browse/AMQ-9313?focusedWorklogId=882633&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882633 ] ASF GitHub Bot logged work on AMQ-9313: --- Author: ASF GitHub Bot Created on: 29/Sep/23 12:51 Start Date: 29/Sep/23 12:51 Worklog Time Spent: 10m Work Description: jbonofre opened a new pull request, #1059: URL: https://github.com/apache/activemq/pull/1059 (no comment) Issue Time Tracking --- Worklog Id: (was: 882633) Remaining Estimate: 0h Time Spent: 10m > Upgrade to ASM 9.5 > -- > > Key: AMQ-9313 > URL: https://issues.apache.org/jira/browse/AMQ-9313 > Project: ActiveMQ > Issue Type: Dependency upgrade > Components: Broker >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.0.0, 5.18.3, 5.17.6 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4444) Allow broker classpath extension using custom paths
[ https://issues.apache.org/jira/browse/ARTEMIS-?focusedWorklogId=882631&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882631 ] ASF GitHub Bot logged work on ARTEMIS-: --- Author: ASF GitHub Bot Created on: 29/Sep/23 12:45 Start Date: 29/Sep/23 12:45 Worklog Time Spent: 10m Work Description: brusdev commented on code in PR #4635: URL: https://github.com/apache/activemq-artemis/pull/4635#discussion_r1341320819 ## docs/user-manual/using-server.adoc: ## @@ -532,10 +532,16 @@ NOTE: the environment variable `JAVA_ARGS_APPEND` can be used to append or overr Runtime dependencies like diverts, transformers, broker plugins, JDBC drivers, password decoders, etc. must be accessible by the broker at runtime. Package the dependency in a jar, and put it on the broker's classpath. -This can be done by placing the jar file in the `lib` directory of the broker distribution itself or in the `lib` directory of the broker instance. +This can be done by placing the jar file in the `lib` directory of the broker distribution itself, +by placing the jar file in the `lib` directory of the broker instance or +by setting the environment variable `ARTEMIS_EXTRA_LIBS` with the directory that contain the jar file. Review Comment: suggestion applied, thanks Issue Time Tracking --- Worklog Id: (was: 882631) Time Spent: 50m (was: 40m) > Allow broker classpath extension using custom paths > --- > > Key: ARTEMIS- > URL: https://issues.apache.org/jira/browse/ARTEMIS- > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Currently users can add runtime dependencies by placing the jar files in the > `lib` directory of the broker distribution itself or in the `lib` directory > of the broker instance. Supporting an environment variable to extend the > classpath would avoid the need to copy those artifact in the broker > directories and allow to add those jar files to the ActiveMQ Artemis > container mounting additional volumes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4447) Add paging prefetch parameters into address settings
[
https://issues.apache.org/jira/browse/ARTEMIS-4447?focusedWorklogId=882612&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882612
]
ASF GitHub Bot logged work on ARTEMIS-4447:
---
Author: ASF GitHub Bot
Created on: 29/Sep/23 11:50
Start Date: 29/Sep/23 11:50
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4637:
URL: https://github.com/apache/activemq-artemis/pull/4637#discussion_r1341238040
##
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/PageFilterTest.java:
##
@@ -0,0 +1,163 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.tests.integration.paging;
+
+import javax.jms.Connection;
+import javax.jms.ConnectionFactory;
+import javax.jms.Message;
+import javax.jms.MessageConsumer;
+import javax.jms.MessageProducer;
+import javax.jms.Session;
+import javax.jms.Topic;
+
+import java.lang.invoke.MethodHandles;
+
+import org.apache.activemq.artemis.api.core.RoutingType;
+import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.core.server.ActiveMQServer;
+import org.apache.activemq.artemis.core.server.impl.AddressInfo;
+import org.apache.activemq.artemis.core.settings.impl.AddressSettings;
+import org.apache.activemq.artemis.tests.util.ActiveMQTestBase;
+import org.apache.activemq.artemis.tests.util.CFUtil;
+import org.apache.activemq.artemis.tests.util.PrintDataUtil;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class PageFilterTest extends ActiveMQTestBase {
+
+ private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ public static final SimpleString ADDRESS = new
SimpleString("SimpleAddress");
+
+ private ActiveMQServer server;
+
+ protected boolean isNetty() {
+ return true;
+ }
+
+ @Override
+ @Before
+ public void setUp() throws Exception {
+ super.setUp();
+ server = newActiveMQServer();
+
+ server.start();
+ waitForServerToStart(server);
+ }
+
+ private ActiveMQServer newActiveMQServer() throws Exception {
+ ActiveMQServer server = createServer(true, isNetty());
+
+ AddressSettings defaultSetting = new
AddressSettings().setPageSizeBytes(10 * 1024).setMaxSizeMessages(10);
+
+ server.getAddressSettingsRepository().addMatch("#", defaultSetting);
+
+ return server;
+ }
+
+ @Test
+ public void testPageFilter() throws Exception {
+
+ ConnectionFactory connectionFactory =
CFUtil.createConnectionFactory("CORE", "tcp://localhost:61616");
+
+ int numberOfMessages = 3 * 24;
+ String filter = "partial=true";
+ String negfilter = "partial=false";
+
+ server.addAddressInfo(new
AddressInfo(getName()).addRoutingType(RoutingType.MULTICAST));
+
+
+
+ try (Connection connection = connectionFactory.createConnection();
+ Connection otherConnection = connectionFactory.createConnection()) {
+ Session session = connection.createSession(false,
Session.AUTO_ACKNOWLEDGE);
+ Topic topic = session.createTopic(getName());
+ session.createSharedDurableConsumer(topic, "wholeThing", negfilter);
+ MessageConsumer partialThing =
session.createSharedDurableConsumer(topic, "partialThing", filter);
+
+ final String oneThousandCharacters;
+ {
+StringBuilder builder = new StringBuilder(1000);
+for (int i = 0; i < 1000; i++) {
+ builder.append('a');
+}
+oneThousandCharacters = builder.toString();
+ }
+
+ MessageProducer producer = session.createProducer(topic);
+
+
+ Session txsession = otherConnection.createSession(true,
Session.SESSION_TRANSACTED);
+ MessageProducer txProducer = txsession.createProducer(topic);
+ for (int i = 0; i < 100; i++) {
+Message message = session.createTextMessage(oneThousandCharacters
+ i);
+message.setIntProperty("i", i);
+m
[jira] [Work logged] (ARTEMIS-4444) Allow broker classpath extension using custom paths
[ https://issues.apache.org/jira/browse/ARTEMIS-?focusedWorklogId=882588&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882588 ] ASF GitHub Bot logged work on ARTEMIS-: --- Author: ASF GitHub Bot Created on: 29/Sep/23 10:17 Start Date: 29/Sep/23 10:17 Worklog Time Spent: 10m Work Description: gemmellr commented on code in PR #4635: URL: https://github.com/apache/activemq-artemis/pull/4635#discussion_r1341179720 ## docs/user-manual/using-server.adoc: ## @@ -532,10 +532,16 @@ NOTE: the environment variable `JAVA_ARGS_APPEND` can be used to append or overr Runtime dependencies like diverts, transformers, broker plugins, JDBC drivers, password decoders, etc. must be accessible by the broker at runtime. Package the dependency in a jar, and put it on the broker's classpath. -This can be done by placing the jar file in the `lib` directory of the broker distribution itself or in the `lib` directory of the broker instance. +This can be done by placing the jar file in the `lib` directory of the broker distribution itself, +by placing the jar file in the `lib` directory of the broker instance or +by setting the environment variable `ARTEMIS_EXTRA_LIBS` with the directory that contain the jar file. Review Comment: ```suggestion by placing the jar file in the `lib` directory of the broker instance, or by setting the environment variable `ARTEMIS_EXTRA_LIBS` with the directory that contains the jar file. ``` Issue Time Tracking --- Worklog Id: (was: 882588) Time Spent: 40m (was: 0.5h) > Allow broker classpath extension using custom paths > --- > > Key: ARTEMIS- > URL: https://issues.apache.org/jira/browse/ARTEMIS- > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > Currently users can add runtime dependencies by placing the jar files in the > `lib` directory of the broker distribution itself or in the `lib` directory > of the broker instance. Supporting an environment variable to extend the > classpath would avoid the need to copy those artifact in the broker > directories and allow to add those jar files to the ActiveMQ Artemis > container mounting additional volumes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (AMQ-9312) Upgrade to Spring 6.0.12
[ https://issues.apache.org/jira/browse/AMQ-9312?focusedWorklogId=882584&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882584 ] ASF GitHub Bot logged work on AMQ-9312: --- Author: ASF GitHub Bot Created on: 29/Sep/23 09:38 Start Date: 29/Sep/23 09:38 Worklog Time Spent: 10m Work Description: jbonofre opened a new pull request, #1058: URL: https://github.com/apache/activemq/pull/1058 (no comment) Issue Time Tracking --- Worklog Id: (was: 882584) Remaining Estimate: 0h Time Spent: 10m > Upgrade to Spring 6.0.12 > > > Key: AMQ-9312 > URL: https://issues.apache.org/jira/browse/AMQ-9312 > Project: ActiveMQ > Issue Type: Dependency upgrade > Components: Broker >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.0.0 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (AMQ-9312) Upgrade to Spring 6.0.12
Jean-Baptiste Onofré created AMQ-9312: - Summary: Upgrade to Spring 6.0.12 Key: AMQ-9312 URL: https://issues.apache.org/jira/browse/AMQ-9312 Project: ActiveMQ Issue Type: Dependency upgrade Components: Broker Reporter: Jean-Baptiste Onofré Assignee: Jean-Baptiste Onofré Fix For: 6.0.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (AMQ-9313) Upgrade to ASM 9.5
Jean-Baptiste Onofré created AMQ-9313: - Summary: Upgrade to ASM 9.5 Key: AMQ-9313 URL: https://issues.apache.org/jira/browse/AMQ-9313 Project: ActiveMQ Issue Type: Dependency upgrade Components: Broker Reporter: Jean-Baptiste Onofré Assignee: Jean-Baptiste Onofré Fix For: 6.0.0, 5.18.3, 5.17.6 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4444) Allow broker classpath extension using custom paths
[ https://issues.apache.org/jira/browse/ARTEMIS-?focusedWorklogId=882582&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-882582 ] ASF GitHub Bot logged work on ARTEMIS-: --- Author: ASF GitHub Bot Created on: 29/Sep/23 09:19 Start Date: 29/Sep/23 09:19 Worklog Time Spent: 10m Work Description: gtully commented on PR #4635: URL: https://github.com/apache/activemq-artemis/pull/4635#issuecomment-1740575543 looks even better :-) Issue Time Tracking --- Worklog Id: (was: 882582) Time Spent: 0.5h (was: 20m) > Allow broker classpath extension using custom paths > --- > > Key: ARTEMIS- > URL: https://issues.apache.org/jira/browse/ARTEMIS- > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Domenico Francesco Bruscino >Assignee: Domenico Francesco Bruscino >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Currently users can add runtime dependencies by placing the jar files in the > `lib` directory of the broker distribution itself or in the `lib` directory > of the broker instance. Supporting an environment variable to extend the > classpath would avoid the need to copy those artifact in the broker > directories and allow to add those jar files to the ActiveMQ Artemis > container mounting additional volumes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
