[jira] [Commented] (ARTEMIS-4301) Resource leakage / ignored configuration

2024-01-03 Thread Justin Bertram (Jira)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-4301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802382#comment-17802382
 ] 

Justin Bertram commented on ARTEMIS-4301:
-

I think this will be dealt with via ARTEMIS-4501.

Also, the documentation is technically correct about the default values of 
{{auto-delete-queues}} and {{auto-delete-addresses}}. They _are_ {{true}} in 
the code. However, the default {{broker.xml}} generated by the {{create}} 
command sets them to {{false}} explicitly since they aren't generally 
recommended.

> Resource leakage / ignored configuration
> 
>
> Key: ARTEMIS-4301
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4301
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.28.0
>Reporter: Daniel Martin
>Priority: Critical
>
> I have an MQTT client connecting to the ActiveMQ Artemis broker. The client 
> connects with a {{sessionExpiryInterval}} of 60 seconds. Among my 
> {{}} in {{{}broker.xml{}}}, I have 
> {{{}true{}}}. When I restart the 
> MQTT client process, I can see in the broker's logs that the disconnect 
> message is received and, after 60 seconds, the "session state" is removed.
> However, every time I restart the client, the queue count in a few addresses 
> increases by one, and never decreases after that. Inspecting the queues, they 
> all have a message count of 0, and all but the one corresponding to the 
> currently-active client have a consumer count of 0. Furthermore, when 
> inspecting the queue's attributes, they are all marked as "Auto delete: 
> false", seemingly ignoring the setting in {{{}broker.xml{}}}.
> A secondary but still important issue: I had to manually turn queue 
> auto-deletion on, as it was explicitly disabled by default, contrary to what 
> is claimed in the documentation 
> ([https://activemq.apache.org/components/artemis/documentation/latest/address-settings.html]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (ARTEMIS-4301) Resource leakage / ignored configuration

2024-01-03 Thread Justin Bertram (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram resolved ARTEMIS-4301.
-
  Assignee: Justin Bertram
Resolution: Duplicate

> Resource leakage / ignored configuration
> 
>
> Key: ARTEMIS-4301
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4301
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.28.0
>Reporter: Daniel Martin
>Assignee: Justin Bertram
>Priority: Critical
>
> I have an MQTT client connecting to the ActiveMQ Artemis broker. The client 
> connects with a {{sessionExpiryInterval}} of 60 seconds. Among my 
> {{}} in {{{}broker.xml{}}}, I have 
> {{{}true{}}}. When I restart the 
> MQTT client process, I can see in the broker's logs that the disconnect 
> message is received and, after 60 seconds, the "session state" is removed.
> However, every time I restart the client, the queue count in a few addresses 
> increases by one, and never decreases after that. Inspecting the queues, they 
> all have a message count of 0, and all but the one corresponding to the 
> currently-active client have a consumer count of 0. Furthermore, when 
> inspecting the queue's attributes, they are all marked as "Auto delete: 
> false", seemingly ignoring the setting in {{{}broker.xml{}}}.
> A secondary but still important issue: I had to manually turn queue 
> auto-deletion on, as it was explicitly disabled by default, contrary to what 
> is claimed in the documentation 
> ([https://activemq.apache.org/components/artemis/documentation/latest/address-settings.html]).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (ARTEMIS-4452) Allow to customize http header in http-upgrade request from Artemis

2024-01-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802375#comment-17802375
 ] 

ASF subversion and git services commented on ARTEMIS-4452:
--

Commit 7456e64f3960255b6e74197791e5dd8087cf85a8 in activemq-artemis's branch 
refs/heads/main from Emmanuel Hugonnet
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=7456e64f39 ]

ARTEMIS-4452: Allow to customize http header in http-upgrade request from 
Artemis.

Using a prefix "netty.http.header." to be able to define http headers
used for http request from the netty connector.

Issue: https://issues.apache.org/jira/browse/ARTEMIS-4452

Signed-off-by: Emmanuel Hugonnet 


> Allow to customize http header in http-upgrade request from Artemis
> ---
>
> Key: ARTEMIS-4452
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4452
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.31.0
>Reporter: Emmanuel Hugonnet
>Priority: Major
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Currently there is no way to customize the headers of the http-upgrade request



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-4452) Allow to customize http header in http-upgrade request from Artemis

2024-01-03 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4452?focusedWorklogId=897950&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-897950
 ]

ASF GitHub Bot logged work on ARTEMIS-4452:
---

Author: ASF GitHub Bot
Created on: 04/Jan/24 02:55
Start Date: 04/Jan/24 02:55
Worklog Time Spent: 10m 
  Work Description: jbertram commented on code in PR #4712:
URL: https://github.com/apache/activemq-artemis/pull/4712#discussion_r1441225599


##
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/client/NettyConnectorTest.java:
##
@@ -60,4 +64,35 @@ public void testConnectionTimeoutConfig() throws Exception {
   factory.close();
   locator.close();
}
+
+   @Test
+   public void testConnectionHttpHeaders() throws Exception {
+  TransportConfiguration transport = new 
TransportConfiguration(NETTY_CONNECTOR_FACTORY);
+  transport.getParams().put(TransportConstants.HTTP_ENABLED_PROP_NAME, 
true);
+  transport.getParams().put("netty.http.header.accept", 
"text/html,application/xhtml+xml,application/xml");
+  transport.getParams().put("netty.http.header.Accept-Encoding", 
"gzip,deflate");
+  transport.getParams().put("netty.http.header.Accept-Language", 
"en-us,en;q=0.5");

Review Comment:
   That's fair.





Issue Time Tracking
---

Worklog Id: (was: 897950)
Time Spent: 1h 40m  (was: 1.5h)

> Allow to customize http header in http-upgrade request from Artemis
> ---
>
> Key: ARTEMIS-4452
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4452
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.31.0
>Reporter: Emmanuel Hugonnet
>Priority: Major
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Currently there is no way to customize the headers of the http-upgrade request



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-4452) Allow to customize http header in http-upgrade request from Artemis

2024-01-03 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4452?focusedWorklogId=897949&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-897949
 ]

ASF GitHub Bot logged work on ARTEMIS-4452:
---

Author: ASF GitHub Bot
Created on: 04/Jan/24 02:55
Start Date: 04/Jan/24 02:55
Worklog Time Spent: 10m 
  Work Description: jbertram merged PR #4712:
URL: https://github.com/apache/activemq-artemis/pull/4712




Issue Time Tracking
---

Worklog Id: (was: 897949)
Time Spent: 1.5h  (was: 1h 20m)

> Allow to customize http header in http-upgrade request from Artemis
> ---
>
> Key: ARTEMIS-4452
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4452
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.31.0
>Reporter: Emmanuel Hugonnet
>Priority: Major
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Currently there is no way to customize the headers of the http-upgrade request



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (ARTEMIS-4540) NullPointerException during initialization

2024-01-03 Thread Justin Bertram (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram reassigned ARTEMIS-4540:
---

Assignee: Justin Bertram

> NullPointerException during initialization
> --
>
> Key: ARTEMIS-4540
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4540
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.31.0
>Reporter: Daniel Martin
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> {noformat}
>  __   _
> / \  | |_  ___ __  __(_) _
>/ _ \|  _ \ __|/ _ \  \/  | |/  __/
>   / ___ \ | \/ |_/  __/ |\/| | |\___ \
>  /_/   \_\|   \__\|_|  |_|_|/___ /
>  Apache ActiveMQ Artemis 2.31.0
> 18:58:47,218 INFO  [org.apache.activemq.artemis.integration.bootstrap] 
> AMQ101000: Starting ActiveMQ Artemis Server version 2.31.0
> 18:58:47,288 INFO  [org.apache.activemq.artemis.core.server] AMQ221000: live 
> Message Broker is starting with configuration Broker Configuration 
> (clustered=false,journalDirectory=data/journal,bindingsDirectory=data/bindings,largeMessagesDirectory=data/large-messages,pagingDirectory=data/paging)
> 18:58:47,371 INFO  [org.apache.activemq.artemis.core.server] AMQ221013: Using 
> NIO Journal
> 18:58:47,475 INFO  [org.apache.activemq.artemis.core.server] AMQ221057: 
> Global Max Size is being adjusted to 1/2 of the JVM max size (-Xmx). being 
> defined as 1073741824
> 18:58:47,522 INFO  [org.apache.activemq.artemis.core.server] AMQ221043: 
> Protocol module found: [artemis-server]. Adding protocol support for: CORE
> 18:58:47,524 INFO  [org.apache.activemq.artemis.core.server] AMQ221043: 
> Protocol module found: [artemis-amqp-protocol]. Adding protocol support for: 
> AMQP
> 18:58:47,524 INFO  [org.apache.activemq.artemis.core.server] AMQ221043: 
> Protocol module found: [artemis-hornetq-protocol]. Adding protocol support 
> for: HORNETQ
> 18:58:47,528 INFO  [org.apache.activemq.artemis.core.server] AMQ221043: 
> Protocol module found: [artemis-mqtt-protocol]. Adding protocol support for: 
> MQTT
> 18:58:47,528 INFO  [org.apache.activemq.artemis.core.server] AMQ221043: 
> Protocol module found: [artemis-openwire-protocol]. Adding protocol support 
> for: OPENWIRE
> 18:58:47,528 INFO  [org.apache.activemq.artemis.core.server] AMQ221043: 
> Protocol module found: [artemis-stomp-protocol]. Adding protocol support for: 
> STOMP
> 18:58:47,664 INFO  [org.apache.activemq.artemis.core.server] AMQ221034: 
> Waiting indefinitely to obtain live lock
> 18:58:47,664 INFO  [org.apache.activemq.artemis.core.server] AMQ221035: Live 
> Server Obtained live lock
> 18:58:48,822 INFO  [org.apache.activemq.artemis.core.server] AMQ221080: 
> Deploying address DLQ supporting [ANYCAST]
> 18:58:48,823 INFO  [org.apache.activemq.artemis.core.server] AMQ221003: 
> Deploying ANYCAST queue DLQ on address DLQ
> 18:58:48,833 INFO  [org.apache.activemq.artemis.core.server] AMQ221080: 
> Deploying address ExpiryQueue supporting [ANYCAST]
> 18:58:48,834 INFO  [org.apache.activemq.artemis.core.server] AMQ221003: 
> Deploying ANYCAST queue ExpiryQueue on address ExpiryQueue
> 18:58:49,081 WARN  [org.apache.activemq.artemis.core.server] AMQ222080: Error 
> instantiating remoting acceptor 
> org.apache.activemq.artemis.core.remoting.impl.netty.NettyAcceptorFactory
> java.lang.NullPointerException: null
> at 
> java.util.concurrent.ConcurrentHashMap.putVal(ConcurrentHashMap.java:1011) 
> ~[?:?]
> at 
> java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:1006) ~[?:?]
> at 
> org.apache.activemq.artemis.core.protocol.mqtt.MQTTStateManager.(MQTTStateManager.java:88)
>  ~[artemis-mqtt-protocol-2.31.0.jar:2.31.0]
> at 
> org.apache.activemq.artemis.core.protocol.mqtt.MQTTStateManager.getInstance(MQTTStateManager.java:66)
>  ~[artemis-mqtt-protocol-2.31.0.jar:2.31.0]
> at 
> org.apache.activemq.artemis.core.protocol.mqtt.MQTTProtocolManager.(MQTTProtocolManager.java:86)
>  ~[artemis-mqtt-protocol-2.31.0.jar:2.31.0]
> at 
> org.apache.activemq.artemis.core.protocol.mqtt.MQTTProtocolManagerFactory.createProtocolManager(MQTTProtocolManagerFactory.java:51)
>  ~[artemis-mqtt-protocol-2.31.0.jar:2.31.0]
> at 
> org.apache.activemq.artemis.core.remoting.server.impl.RemotingServiceImpl.createAcceptor(RemotingServiceImpl.java:271)
>  [artemis-server-2.31.0.jar:2.31.0]
> at 
> org.apache.activemq.artemis.core.remoting.server.impl.RemotingServiceImpl.start(RemotingServiceImpl.java:217)
>  [artemis-server-2.31.0.jar:2.31.0]
> at 
> org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.initialisePart2(ActiveMQServerImpl.java:3488)
>  [artemis-server-2.31.0.jar:2.31.0]
> at 
> org.apache.activemq.artemis.core.server.impl.LiveOnlyActivatio

[jira] [Created] (AMQNET-837) Add Buffer Sizes Support for SSL Scheme in ActiveMQ OpenWire

2024-01-03 Thread Jira
Krzysztof Porębski created AMQNET-837:
-

 Summary: Add Buffer Sizes Support for SSL Scheme in ActiveMQ 
OpenWire
 Key: AMQNET-837
 URL: https://issues.apache.org/jira/browse/AMQNET-837
 Project: ActiveMQ .Net
  Issue Type: Bug
  Components: ActiveMQ
Affects Versions: OpenWire-2.1.0
Reporter: Krzysztof Porębski


We have identified a limitation in the SSL scheme of ActiveMQ's OpenWire 
protocol where configuring transport.sendBufferSize and 
transport.receiveBufferSize through the client URL is currently only effective 
for the TCP scheme. This is an issue because the SslTransportFactory, which 
inherits from TcpTransportFactory, does not set the sendBufferSize and 
receiveBufferSize properties.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-3474) Replace use of non-inclusive terms throughout source code, comments and documentation

2024-01-03 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-3474?focusedWorklogId=897926&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-897926
 ]

ASF GitHub Bot logged work on ARTEMIS-3474:
---

Author: ASF GitHub Bot
Created on: 03/Jan/24 20:43
Start Date: 03/Jan/24 20:43
Worklog Time Spent: 10m 
  Work Description: jbertram commented on code in PR #4728:
URL: https://github.com/apache/activemq-artemis/pull/4728#discussion_r1440927957


##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java:
##
@@ -170,9 +170,13 @@ public class Create extends InstallAbstract {
@Option(names = "--shared-store", description = "Enable broker shared 
store.")
private boolean sharedStore = false;
 
-   @Option(names = "--slave", description = "Be a slave broker. Valid for 
shared store or replication.")
+   @Deprecated(forRemoval = true)
+   @Option(names = "--slave", description = "Deprecated for removal. Use 
'backup' instead.")

Review Comment:
   Fixed!





Issue Time Tracking
---

Worklog Id: (was: 897926)
Time Spent: 1.5h  (was: 1h 20m)

> Replace use of non-inclusive terms throughout source code, comments and 
> documentation
> -
>
> Key: ARTEMIS-3474
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3474
> Project: ActiveMQ Artemis
>  Issue Type: Task
>Reporter: Andy Taylor
>Priority: Major
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> this follows up on the ActiveMQ  Jira at 
> https://issues.apache.org/jira/browse/AMQ-7514 but for Artemis . The 
> conversation is on this Jira and in the forum



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-4488) Support "literal" address setting match

2024-01-03 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4488?focusedWorklogId=897914&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-897914
 ]

ASF GitHub Bot logged work on ARTEMIS-4488:
---

Author: ASF GitHub Bot
Created on: 03/Jan/24 17:26
Start Date: 03/Jan/24 17:26
Worklog Time Spent: 10m 
  Work Description: jbertram commented on PR #4719:
URL: 
https://github.com/apache/activemq-artemis/pull/4719#issuecomment-1875717798

   This looks good to me, but it needs to be rebased.




Issue Time Tracking
---

Worklog Id: (was: 897914)
Time Spent: 40m  (was: 0.5h)

> Support "literal" address setting match
> ---
>
> Key: ARTEMIS-4488
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4488
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> There are use-cases (mainly with MQTT) where wildcard addresses need to be 
> configured differently from the the addresses which actually match the 
> wildcard. Currently we have no way to separate these two categories. We need 
> a new configuration semantic to enable this differentiation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (ARTEMIS-4537) Address setting matches with wildcard are not idempotent

2024-01-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ARTEMIS-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802264#comment-17802264
 ] 

ASF subversion and git services commented on ARTEMIS-4537:
--

Commit b075cd6fc08e5e69fc4b887ff3af070c43ae6d6a in activemq-artemis's branch 
refs/heads/main from Domenico Francesco Bruscino
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=b075cd6fc0 ]

ARTEMIS-4537 Fix merge of multiple address setting matches

Merge multiple address setting matches on a new instance to be idempotent.


> Address setting matches with wildcard are not idempotent
> 
>
> Key: ARTEMIS-4537
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4537
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Domenico Francesco Bruscino
>Assignee: Domenico Francesco Bruscino
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> When addresses match different multiple address settings with the same most 
> specific address setting the overlay is not idempotent, i.e. supposing to 
> define the following address settings:
> {code}
> addressSettings."foo.*".maxRedeliveryDelay=1
> addressSettings."foo.0.#".maxExpiryDelay=2
> addressSettings."foo.1.#".maxExpiryDelay=3
> {code}
> Every address matching foo.* have maxExpiryDelay=-1 if it is created before 
> foo.0 and it have maxExpiryDelay=2 if it is created after foo.0.
> Every address matching foo.* have maxExpiryDelay=-1 if it is created before 
> foo.1 and it have maxExpiryDelay=3 if it is created after foo.1.
> The addresses foo.0 and foo.1 have maxExpiryDelay=2 if foo.0 is created 
> before foo.1.
> The addresses foo.0 and foo.1 have maxExpiryDelay=3 if foo.1 is created 
> before foo.0.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-4537) Address setting matches with wildcard are not idempotent

2024-01-03 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4537?focusedWorklogId=897912&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-897912
 ]

ASF GitHub Bot logged work on ARTEMIS-4537:
---

Author: ASF GitHub Bot
Created on: 03/Jan/24 17:02
Start Date: 03/Jan/24 17:02
Worklog Time Spent: 10m 
  Work Description: jbertram merged PR #4715:
URL: https://github.com/apache/activemq-artemis/pull/4715




Issue Time Tracking
---

Worklog Id: (was: 897912)
Time Spent: 40m  (was: 0.5h)

> Address setting matches with wildcard are not idempotent
> 
>
> Key: ARTEMIS-4537
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4537
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Domenico Francesco Bruscino
>Assignee: Domenico Francesco Bruscino
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> When addresses match different multiple address settings with the same most 
> specific address setting the overlay is not idempotent, i.e. supposing to 
> define the following address settings:
> {code}
> addressSettings."foo.*".maxRedeliveryDelay=1
> addressSettings."foo.0.#".maxExpiryDelay=2
> addressSettings."foo.1.#".maxExpiryDelay=3
> {code}
> Every address matching foo.* have maxExpiryDelay=-1 if it is created before 
> foo.0 and it have maxExpiryDelay=2 if it is created after foo.0.
> Every address matching foo.* have maxExpiryDelay=-1 if it is created before 
> foo.1 and it have maxExpiryDelay=3 if it is created after foo.1.
> The addresses foo.0 and foo.1 have maxExpiryDelay=2 if foo.0 is created 
> before foo.1.
> The addresses foo.0 and foo.1 have maxExpiryDelay=3 if foo.1 is created 
> before foo.0.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-3474) Replace use of non-inclusive terms throughout source code, comments and documentation

2024-01-03 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-3474?focusedWorklogId=897905&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-897905
 ]

ASF GitHub Bot logged work on ARTEMIS-3474:
---

Author: ASF GitHub Bot
Created on: 03/Jan/24 15:57
Start Date: 03/Jan/24 15:57
Worklog Time Spent: 10m 
  Work Description: clebertsuconic commented on code in PR #4728:
URL: https://github.com/apache/activemq-artemis/pull/4728#discussion_r1440615532


##
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/Create.java:
##
@@ -170,9 +170,13 @@ public class Create extends InstallAbstract {
@Option(names = "--shared-store", description = "Enable broker shared 
store.")
private boolean sharedStore = false;
 
-   @Option(names = "--slave", description = "Be a slave broker. Valid for 
shared store or replication.")
+   @Deprecated(forRemoval = true)
+   @Option(names = "--slave", description = "Deprecated for removal. Use 
'backup' instead.")

Review Comment:
   for anything CLI, you must use hidden=true.
   
   it will disappear from the CLI help and auto-complete, but it would be 
available for use.





Issue Time Tracking
---

Worklog Id: (was: 897905)
Time Spent: 1h 20m  (was: 1h 10m)

> Replace use of non-inclusive terms throughout source code, comments and 
> documentation
> -
>
> Key: ARTEMIS-3474
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3474
> Project: ActiveMQ Artemis
>  Issue Type: Task
>Reporter: Andy Taylor
>Priority: Major
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> this follows up on the ActiveMQ  Jira at 
> https://issues.apache.org/jira/browse/AMQ-7514 but for Artemis . The 
> conversation is on this Jira and in the forum



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-4550) Upgrade spring boot version to 2.7.18

2024-01-03 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4550?focusedWorklogId=897900&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-897900
 ]

ASF GitHub Bot logged work on ARTEMIS-4550:
---

Author: ASF GitHub Bot
Created on: 03/Jan/24 15:47
Start Date: 03/Jan/24 15:47
Worklog Time Spent: 10m 
  Work Description: gemmellr merged PR #1:
URL: https://github.com/apache/activemq-artemis-examples/pull/1




Issue Time Tracking
---

Worklog Id: (was: 897900)
Time Spent: 40m  (was: 0.5h)

> Upgrade spring boot version to 2.7.18
> -
>
> Key: ARTEMIS-4550
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4550
> Project: ActiveMQ Artemis
>  Issue Type: Dependency upgrade
>  Components: ActiveMQ-Artemis-Examples
>Reporter: Domenico Francesco Bruscino
>Assignee: Domenico Francesco Bruscino
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (ARTEMIS-4551) Interceptor client example should not depend on interceptor example

2024-01-03 Thread Domenico Francesco Bruscino (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Domenico Francesco Bruscino reassigned ARTEMIS-4551:


Component/s: ActiveMQ-Artemis-Examples
   Assignee: Domenico Francesco Bruscino

> Interceptor client example should not depend on interceptor example
> ---
>
> Key: ARTEMIS-4551
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4551
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: ActiveMQ-Artemis-Examples
>Reporter: Domenico Francesco Bruscino
>Assignee: Domenico Francesco Bruscino
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The interceptor client example depends on the interceptor example. This 
> inter-dependence between them is not required and could cause the failure of 
> the check [verify 
> examples|https://github.com/apache/activemq-artemis-examples/blob/main/.github/workflows/build.yml].



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (AMQ-9394) Tech Preview: Virtual Thread support

2024-01-03 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/AMQ-9394?focusedWorklogId=897895&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-897895
 ]

ASF GitHub Bot logged work on AMQ-9394:
---

Author: ASF GitHub Bot
Created on: 03/Jan/24 14:29
Start Date: 03/Jan/24 14:29
Worklog Time Spent: 10m 
  Work Description: PascalSchumacher commented on PR #1121:
URL: https://github.com/apache/activemq/pull/1121#issuecomment-1875460731

   Great to see work done on this! 👍 
   
   What about other threads like `ActiveMQ Data File Writer`, `ActiveMQ Journal 
*`, can/should these be virtual too or is that a bad idea?
   




Issue Time Tracking
---

Worklog Id: (was: 897895)
Time Spent: 20m  (was: 10m)

> Tech Preview: Virtual Thread support
> 
>
> Key: AMQ-9394
> URL: https://issues.apache.org/jira/browse/AMQ-9394
> Project: ActiveMQ
>  Issue Type: New Feature
>Reporter: Matt Pavlovich
>Assignee: Matt Pavlovich
>Priority: Major
>  Labels: #virtualthread
> Fix For: 6.1.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Initial technical preview of Virtual Thread support



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-4551) Interceptor client example should not depend on interceptor example

2024-01-03 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4551?focusedWorklogId=897893&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-897893
 ]

ASF GitHub Bot logged work on ARTEMIS-4551:
---

Author: ASF GitHub Bot
Created on: 03/Jan/24 14:03
Start Date: 03/Jan/24 14:03
Worklog Time Spent: 10m 
  Work Description: brusdev merged PR #2:
URL: https://github.com/apache/activemq-artemis-examples/pull/2




Issue Time Tracking
---

Worklog Id: (was: 897893)
Remaining Estimate: 0h
Time Spent: 10m

> Interceptor client example should not depend on interceptor example
> ---
>
> Key: ARTEMIS-4551
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4551
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Domenico Francesco Bruscino
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> The interceptor client example depends on the interceptor example. This 
> inter-dependence between them is not required and could cause the failure of 
> the check [verify 
> examples|https://github.com/apache/activemq-artemis-examples/blob/main/.github/workflows/build.yml].



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (ARTEMIS-4551) Interceptor client example should not depend on interceptor example

2024-01-03 Thread Domenico Francesco Bruscino (Jira)
Domenico Francesco Bruscino created ARTEMIS-4551:


 Summary: Interceptor client example should not depend on 
interceptor example
 Key: ARTEMIS-4551
 URL: https://issues.apache.org/jira/browse/ARTEMIS-4551
 Project: ActiveMQ Artemis
  Issue Type: Bug
Reporter: Domenico Francesco Bruscino


The interceptor client example depends on the interceptor example. This 
inter-dependence between them is not required and could cause the failure of 
the check [verify 
examples|https://github.com/apache/activemq-artemis-examples/blob/main/.github/workflows/build.yml].



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-4550) Upgrade spring boot version to 2.7.18

2024-01-03 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4550?focusedWorklogId=897826&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-897826
 ]

ASF GitHub Bot logged work on ARTEMIS-4550:
---

Author: ASF GitHub Bot
Created on: 03/Jan/24 10:38
Start Date: 03/Jan/24 10:38
Worklog Time Spent: 10m 
  Work Description: brusdev commented on PR #1:
URL: 
https://github.com/apache/activemq-artemis-examples/pull/1#issuecomment-1875158438

   I changed the base of this PR to the development branch and created the PR 
#2 to fix the interceptor-client example.




Issue Time Tracking
---

Worklog Id: (was: 897826)
Time Spent: 0.5h  (was: 20m)

> Upgrade spring boot version to 2.7.18
> -
>
> Key: ARTEMIS-4550
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4550
> Project: ActiveMQ Artemis
>  Issue Type: Dependency upgrade
>  Components: ActiveMQ-Artemis-Examples
>Reporter: Domenico Francesco Bruscino
>Assignee: Domenico Francesco Bruscino
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-4550) Upgrade spring boot version to 2.7.18

2024-01-03 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4550?focusedWorklogId=897822&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-897822
 ]

ASF GitHub Bot logged work on ARTEMIS-4550:
---

Author: ASF GitHub Bot
Created on: 03/Jan/24 10:16
Start Date: 03/Jan/24 10:16
Worklog Time Spent: 10m 
  Work Description: gemmellr commented on PR #1:
URL: 
https://github.com/apache/activemq-artemis-examples/pull/1#issuecomment-1875130009

   PRs should be opened against the development branch rather than main branch. 
   
   Though the PR build didnt do exactly what I intended if you did open one 
against main, i.e to use the released artemis main already does, as the PR 
setup is slightly different than the manual triggered runs I tested things 
with...will need to try tweaking the step gating once I'm back to work.
   
   Regardless of that, the precise failure could point to an inter-dependence 
between some examples that hasnt been spotted before as the existing published 
snapshots were still available, but should have now been removed (or the 
released examples, which wont exist going forward)...so the PR check likely 
will still fail even when retargeted at the development branch. If so, I think 
the examples should be changed to remove the inter-dependence between them.




Issue Time Tracking
---

Worklog Id: (was: 897822)
Time Spent: 20m  (was: 10m)

> Upgrade spring boot version to 2.7.18
> -
>
> Key: ARTEMIS-4550
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4550
> Project: ActiveMQ Artemis
>  Issue Type: Dependency upgrade
>  Components: ActiveMQ-Artemis-Examples
>Reporter: Domenico Francesco Bruscino
>Assignee: Domenico Francesco Bruscino
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Work logged] (ARTEMIS-4550) Upgrade spring boot version to 2.7.18

2024-01-03 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/ARTEMIS-4550?focusedWorklogId=897807&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-897807
 ]

ASF GitHub Bot logged work on ARTEMIS-4550:
---

Author: ASF GitHub Bot
Created on: 03/Jan/24 09:29
Start Date: 03/Jan/24 09:29
Worklog Time Spent: 10m 
  Work Description: brusdev opened a new pull request, #1:
URL: https://github.com/apache/activemq-artemis-examples/pull/1

   (no comment)




Issue Time Tracking
---

Worklog Id: (was: 897807)
Remaining Estimate: 0h
Time Spent: 10m

> Upgrade spring boot version to 2.7.18
> -
>
> Key: ARTEMIS-4550
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4550
> Project: ActiveMQ Artemis
>  Issue Type: Dependency upgrade
>  Components: ActiveMQ-Artemis-Examples
>Reporter: Domenico Francesco Bruscino
>Assignee: Domenico Francesco Bruscino
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (ARTEMIS-4550) Upgrade spring boot version to 2.7.18

2024-01-03 Thread Domenico Francesco Bruscino (Jira)
Domenico Francesco Bruscino created ARTEMIS-4550:


 Summary: Upgrade spring boot version to 2.7.18
 Key: ARTEMIS-4550
 URL: https://issues.apache.org/jira/browse/ARTEMIS-4550
 Project: ActiveMQ Artemis
  Issue Type: Dependency upgrade
  Components: ActiveMQ-Artemis-Examples
Reporter: Domenico Francesco Bruscino
Assignee: Domenico Francesco Bruscino






--
This message was sent by Atlassian Jira
(v8.20.10#820010)