[jira] [Closed] (ARTEMIS-4225) Update hawtio to 2.17.0
[ https://issues.apache.org/jira/browse/ARTEMIS-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Prankl closed ARTEMIS-4225. --- Resolution: Duplicate > Update hawtio to 2.17.0 > --- > > Key: ARTEMIS-4225 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4225 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade > Components: Web Console >Affects Versions: 2.28.0 >Reporter: Michael Prankl >Priority: Minor > > Update hawtio to latest 2.x release (2.17.0) from currently 2.15.0. > This would also include a feature in hawtio-oauth plugin that enables PKCE > support (see https://github.com/hawtio/hawtio-oauth/issues/29). > Some company security guidelines require PKCE usage when using public Clients > for OAuth2/OpenID, so this upgrade would make that possible for Artemis. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARTEMIS-4570) filter not applied to all brokers in cluster
Howard Gao created ARTEMIS-4570: --- Summary: filter not applied to all brokers in cluster Key: ARTEMIS-4570 URL: https://issues.apache.org/jira/browse/ARTEMIS-4570 Project: ActiveMQ Artemis Issue Type: Bug Components: Clustering Affects Versions: 2.31.2 Reporter: Howard Gao Assignee: Howard Gao When applying a new filter on a clustered queue, its remotebinding doesn't get updated. The result is when sending a message that desn't match the filter to the local queue the filter works, i.e. the local consumer won't get the message. However if there is a remote consumer that message will be delivered the the remote consumer (ON_DEMAND policy) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4569) Blocked Producers Memory Leaks
[ https://issues.apache.org/jira/browse/ARTEMIS-4569?focusedWorklogId=99&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-99 ] ASF GitHub Bot logged work on ARTEMIS-4569: --- Author: ASF GitHub Bot Created on: 16/Jan/24 22:18 Start Date: 16/Jan/24 22:18 Worklog Time Spent: 10m Work Description: clebertsuconic opened a new pull request, #4743: URL: https://github.com/apache/activemq-artemis/pull/4743 … consumed. When initially developed the expectation was that no more producers would keep connecting but in a scenario like this the consumers could actually give up and things will just accumulate on the server. We should cleanup these upon disconnect. Issue Time Tracking --- Worklog Id: (was: 99) Remaining Estimate: 0h Time Spent: 10m > Blocked Producers Memory Leaks > -- > > Key: ARTEMIS-4569 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4569 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.31.2 >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.32.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Say you have paging configured as blocking. And you keep opening and closing > connections that will be blocked while producing. > These Runnables will accumulate until the number of messages goes back to > negative again. > Also these are holding Connections and other server objects. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARTEMIS-4569) Blocked Producers Memory Leaks
Clebert Suconic created ARTEMIS-4569: Summary: Blocked Producers Memory Leaks Key: ARTEMIS-4569 URL: https://issues.apache.org/jira/browse/ARTEMIS-4569 Project: ActiveMQ Artemis Issue Type: Improvement Affects Versions: 2.31.2 Reporter: Clebert Suconic Assignee: Clebert Suconic Fix For: 2.32.0 Say you have paging configured as blocking. And you keep opening and closing connections that will be blocked while producing. These Runnables will accumulate until the number of messages goes back to negative again. Also these are holding Connections and other server objects. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (OPENWIRE-75) Support mapping javax -> jakarta exceptions in openwire
[ https://issues.apache.org/jira/browse/OPENWIRE-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher L. Shannon resolved OPENWIRE-75. Resolution: Fixed > Support mapping javax -> jakarta exceptions in openwire > --- > > Key: OPENWIRE-75 > URL: https://issues.apache.org/jira/browse/OPENWIRE-75 > Project: ActiveMQ OpenWire > Issue Type: Task >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 1.0.0 > > > This issue is to migrate the changes from > https://issues.apache.org/jira/browse/AMQ-9418 so that if the clients using > Openwire generated by this project (which will always be new clients jakarta) > talk to an older 5.x broker that uses javax exception types then the > exceptions can be translated correctly -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OPENWIRE-75) Support mapping javax -> jakarta exceptions in openwire
[ https://issues.apache.org/jira/browse/OPENWIRE-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807446#comment-17807446 ] ASF subversion and git services commented on OPENWIRE-75: - Commit c5e91020adbf3864d0a920e4c76154285054d792 in activemq-openwire's branch refs/heads/main from Christopher L. Shannon (cshannon) [ https://gitbox.apache.org/repos/asf?p=activemq-openwire.git;h=c5e9102 ] OPENWIRE-75 - convert javax to jakarta jms exception This allows properly translating jms exceptions received when connection to an old 5.x broker that is using javax namespace > Support mapping javax -> jakarta exceptions in openwire > --- > > Key: OPENWIRE-75 > URL: https://issues.apache.org/jira/browse/OPENWIRE-75 > Project: ActiveMQ OpenWire > Issue Type: Task >Reporter: Christopher L. Shannon >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 1.0.0 > > > This issue is to migrate the changes from > https://issues.apache.org/jira/browse/AMQ-9418 so that if the clients using > Openwire generated by this project (which will always be new clients jakarta) > talk to an older 5.x broker that uses javax exception types then the > exceptions can be translated correctly -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OPENWIRE-75) Support mapping javax -> jakarta exceptions in openwire
Christopher L. Shannon created OPENWIRE-75: -- Summary: Support mapping javax -> jakarta exceptions in openwire Key: OPENWIRE-75 URL: https://issues.apache.org/jira/browse/OPENWIRE-75 Project: ActiveMQ OpenWire Issue Type: Task Reporter: Christopher L. Shannon Assignee: Christopher L. Shannon Fix For: 1.0.0 This issue is to migrate the changes from https://issues.apache.org/jira/browse/AMQ-9418 so that if the clients using Openwire generated by this project (which will always be new clients jakarta) talk to an older 5.x broker that uses javax exception types then the exceptions can be translated correctly -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AMQ-9418) Support mapping jakarta -> javax exceptions in openwire
[ https://issues.apache.org/jira/browse/AMQ-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807441#comment-17807441 ] Christopher L. Shannon commented on AMQ-9418: - One more thing to do is to migrate these changes to the [OPENWIRE|https://issues.apache.org/jira/projects/OPENWIRE/] project since that will be used for new versions going forward > Support mapping jakarta -> javax exceptions in openwire > --- > > Key: AMQ-9418 > URL: https://issues.apache.org/jira/browse/AMQ-9418 > Project: ActiveMQ > Issue Type: Bug >Reporter: Matt Pavlovich >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 6.1.0, 5.18.4, 5.17.7, 5.16.8, 6.0.2 > > Time Spent: 50m > Remaining Estimate: 0h > > For javax clients to connect to jakarta-based broker, we need to map > exceptions to the javax namespace from jakarta-based broker-side exceptions > and vice versa for jakarta clients talking to a javax broker. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (AMQ-9418) Support mapping jakarta -> javax exceptions in openwire
[ https://issues.apache.org/jira/browse/AMQ-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher L. Shannon resolved AMQ-9418. - Resolution: Fixed > Support mapping jakarta -> javax exceptions in openwire > --- > > Key: AMQ-9418 > URL: https://issues.apache.org/jira/browse/AMQ-9418 > Project: ActiveMQ > Issue Type: Bug >Reporter: Matt Pavlovich >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 6.1.0, 5.18.4, 5.17.7, 5.16.8, 6.0.2 > > Time Spent: 50m > Remaining Estimate: 0h > > For javax clients to connect to jakarta-based broker, we need to map > exceptions to the javax namespace from jakarta-based broker-side exceptions > and vice versa for jakarta clients talking to a javax broker. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AMQ-9418) Support mapping jakarta -> javax exceptions in openwire
[ https://issues.apache.org/jira/browse/AMQ-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807433#comment-17807433 ] Christopher L. Shannon commented on AMQ-9418: - Another option for Openwire v13 for conversion is to just update the ExceptionResponse to no longer have exception type (just code and message) and push the conversion logic into the marshallers for old version so the broker doesn't need to worry about the conversion > Support mapping jakarta -> javax exceptions in openwire > --- > > Key: AMQ-9418 > URL: https://issues.apache.org/jira/browse/AMQ-9418 > Project: ActiveMQ > Issue Type: Bug >Reporter: Matt Pavlovich >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 6.1.0, 5.18.4, 5.17.7, 5.16.8, 6.0.2 > > Time Spent: 50m > Remaining Estimate: 0h > > For javax clients to connect to jakarta-based broker, we need to map > exceptions to the javax namespace from jakarta-based broker-side exceptions > and vice versa for jakarta clients talking to a javax broker. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AMQ-9418) Support mapping jakarta -> javax exceptions in openwire
[ https://issues.apache.org/jira/browse/AMQ-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807431#comment-17807431 ] ASF subversion and git services commented on AMQ-9418: -- Commit cd201c0f7522b2054dfe7babcac0787af99b22ee in activemq's branch refs/heads/activemq-5.16.x from Christopher L. Shannon (cshannon) [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=cd201c0f7 ] AMQ-9418 - Support converting jakarta jms exceptions to javax This fixes the OpenWire v12 marshaller so that if an exception is received by a jakarta based broker the client will convert back to a javax jms exception type. (cherry picked from commit b92479cd2ec0913b6dae03a4789bdceae58b57b5) > Support mapping jakarta -> javax exceptions in openwire > --- > > Key: AMQ-9418 > URL: https://issues.apache.org/jira/browse/AMQ-9418 > Project: ActiveMQ > Issue Type: Bug >Reporter: Matt Pavlovich >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 6.1.0, 5.18.4, 5.17.7, 5.16.8, 6.0.2 > > Time Spent: 50m > Remaining Estimate: 0h > > For javax clients to connect to jakarta-based broker, we need to map > exceptions to the javax namespace from jakarta-based broker-side exceptions > and vice versa for jakarta clients talking to a javax broker. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AMQ-9418) Support mapping jakarta -> javax exceptions in openwire
[ https://issues.apache.org/jira/browse/AMQ-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807430#comment-17807430 ] ASF subversion and git services commented on AMQ-9418: -- Commit da27536132fb99427019b7c43bbb11458c339bc6 in activemq's branch refs/heads/activemq-5.17.x from Christopher L. Shannon (cshannon) [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=da2753613 ] AMQ-9418 - Support converting jakarta jms exceptions to javax This fixes the OpenWire v12 marshaller so that if an exception is received by a jakarta based broker the client will convert back to a javax jms exception type. (cherry picked from commit b92479cd2ec0913b6dae03a4789bdceae58b57b5) > Support mapping jakarta -> javax exceptions in openwire > --- > > Key: AMQ-9418 > URL: https://issues.apache.org/jira/browse/AMQ-9418 > Project: ActiveMQ > Issue Type: Bug >Reporter: Matt Pavlovich >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 6.1.0, 5.18.4, 5.17.7, 5.16.8, 6.0.2 > > Time Spent: 50m > Remaining Estimate: 0h > > For javax clients to connect to jakarta-based broker, we need to map > exceptions to the javax namespace from jakarta-based broker-side exceptions > and vice versa for jakarta clients talking to a javax broker. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AMQ-9418) Support mapping jakarta -> javax exceptions in openwire
[ https://issues.apache.org/jira/browse/AMQ-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807428#comment-17807428 ] ASF subversion and git services commented on AMQ-9418: -- Commit 7a3db6f1dc569888a4f8204fda1a713df0eb1e38 in activemq's branch refs/heads/activemq-6.0.x from Christopher L. Shannon (cshannon) [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=7a3db6f1d ] AMQ-9418 - Support converting javax jms exceptions to jakarta This fixes the OpenWire v12 marshaller so that if an exception is received by a javax based broker the client will convert back to a jakarta jms exception type. (cherry picked from commit be64fdba511803e93312e57040e5776a66cf7be2) > Support mapping jakarta -> javax exceptions in openwire > --- > > Key: AMQ-9418 > URL: https://issues.apache.org/jira/browse/AMQ-9418 > Project: ActiveMQ > Issue Type: Bug >Reporter: Matt Pavlovich >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 6.1.0, 5.18.4, 5.17.7, 5.16.8, 6.0.2 > > Time Spent: 50m > Remaining Estimate: 0h > > For javax clients to connect to jakarta-based broker, we need to map > exceptions to the javax namespace from jakarta-based broker-side exceptions > and vice versa for jakarta clients talking to a javax broker. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AMQ-9418) Support mapping jakarta -> javax exceptions in openwire
[ https://issues.apache.org/jira/browse/AMQ-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807427#comment-17807427 ] ASF subversion and git services commented on AMQ-9418: -- Commit a2bf5b8adb8669a1fa020519cfd9a0fdae2f8787 in activemq's branch refs/heads/main from Christopher L. Shannon [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=a2bf5b8ad ] Merge pull request #1141 from cshannon/javax-jakarta-exception-conversion AMQ-9418 - Support converting javax jms exceptions to jakarta > Support mapping jakarta -> javax exceptions in openwire > --- > > Key: AMQ-9418 > URL: https://issues.apache.org/jira/browse/AMQ-9418 > Project: ActiveMQ > Issue Type: Bug >Reporter: Matt Pavlovich >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 6.1.0, 5.18.4, 5.17.7, 5.16.8, 6.0.2 > > Time Spent: 50m > Remaining Estimate: 0h > > For javax clients to connect to jakarta-based broker, we need to map > exceptions to the javax namespace from jakarta-based broker-side exceptions > and vice versa for jakarta clients talking to a javax broker. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AMQ-9418) Support mapping jakarta -> javax exceptions in openwire
[ https://issues.apache.org/jira/browse/AMQ-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807426#comment-17807426 ] ASF subversion and git services commented on AMQ-9418: -- Commit be64fdba511803e93312e57040e5776a66cf7be2 in activemq's branch refs/heads/main from Christopher L. Shannon (cshannon) [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=be64fdba5 ] AMQ-9418 - Support converting javax jms exceptions to jakarta This fixes the OpenWire v12 marshaller so that if an exception is received by a javax based broker the client will convert back to a jakarta jms exception type. > Support mapping jakarta -> javax exceptions in openwire > --- > > Key: AMQ-9418 > URL: https://issues.apache.org/jira/browse/AMQ-9418 > Project: ActiveMQ > Issue Type: Bug >Reporter: Matt Pavlovich >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 6.1.0, 5.18.4, 5.17.7, 5.16.8, 6.0.2 > > Time Spent: 50m > Remaining Estimate: 0h > > For javax clients to connect to jakarta-based broker, we need to map > exceptions to the javax namespace from jakarta-based broker-side exceptions > and vice versa for jakarta clients talking to a javax broker. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (AMQ-9418) Support mapping jakarta -> javax exceptions in openwire
[ https://issues.apache.org/jira/browse/AMQ-9418?focusedWorklogId=85&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-85 ] ASF GitHub Bot logged work on AMQ-9418: --- Author: ASF GitHub Bot Created on: 16/Jan/24 20:30 Start Date: 16/Jan/24 20:30 Worklog Time Spent: 10m Work Description: cshannon merged PR #1141: URL: https://github.com/apache/activemq/pull/1141 Issue Time Tracking --- Worklog Id: (was: 85) Time Spent: 50m (was: 40m) > Support mapping jakarta -> javax exceptions in openwire > --- > > Key: AMQ-9418 > URL: https://issues.apache.org/jira/browse/AMQ-9418 > Project: ActiveMQ > Issue Type: Bug >Reporter: Matt Pavlovich >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 6.1.0, 5.18.4, 5.17.7, 5.16.8, 6.0.2 > > Time Spent: 50m > Remaining Estimate: 0h > > For javax clients to connect to jakarta-based broker, we need to map > exceptions to the javax namespace from jakarta-based broker-side exceptions > and vice versa for jakarta clients talking to a javax broker. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (AMQ-9418) Support mapping jakarta -> javax exceptions in openwire
[ https://issues.apache.org/jira/browse/AMQ-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher L. Shannon updated AMQ-9418: Fix Version/s: 6.1.0 > Support mapping jakarta -> javax exceptions in openwire > --- > > Key: AMQ-9418 > URL: https://issues.apache.org/jira/browse/AMQ-9418 > Project: ActiveMQ > Issue Type: Bug >Reporter: Matt Pavlovich >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 6.1.0, 5.18.4, 5.17.7, 5.16.8, 6.0.2 > > Time Spent: 40m > Remaining Estimate: 0h > > For javax clients to connect to jakarta-based broker, we need to map > exceptions to the javax namespace from jakarta-based broker-side exceptions > and vice versa for jakarta clients talking to a javax broker. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AMQ-9418) Support mapping jakarta -> javax exceptions in openwire
[ https://issues.apache.org/jira/browse/AMQ-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807424#comment-17807424 ] ASF subversion and git services commented on AMQ-9418: -- Commit ef9c0bd5971e0da615e86ad7fdbb80dd99a5b6f7 in activemq's branch refs/heads/activemq-5.18.x from Christopher L. Shannon [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=ef9c0bd59 ] Merge pull request #1140 from cshannon/jakarta-javax-exception-conversion AMQ-9418 - Support converting jakarta jms exceptions to javax > Support mapping jakarta -> javax exceptions in openwire > --- > > Key: AMQ-9418 > URL: https://issues.apache.org/jira/browse/AMQ-9418 > Project: ActiveMQ > Issue Type: Bug >Reporter: Matt Pavlovich >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 5.18.4, 5.17.7, 5.16.8, 6.0.2 > > Time Spent: 40m > Remaining Estimate: 0h > > For javax clients to connect to jakarta-based broker, we need to map > exceptions to the javax namespace from jakarta-based broker-side exceptions > and vice versa for jakarta clients talking to a javax broker. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (AMQ-9418) Support mapping jakarta -> javax exceptions in openwire
[ https://issues.apache.org/jira/browse/AMQ-9418?focusedWorklogId=84&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-84 ] ASF GitHub Bot logged work on AMQ-9418: --- Author: ASF GitHub Bot Created on: 16/Jan/24 20:22 Start Date: 16/Jan/24 20:22 Worklog Time Spent: 10m Work Description: cshannon merged PR #1140: URL: https://github.com/apache/activemq/pull/1140 Issue Time Tracking --- Worklog Id: (was: 84) Time Spent: 40m (was: 0.5h) > Support mapping jakarta -> javax exceptions in openwire > --- > > Key: AMQ-9418 > URL: https://issues.apache.org/jira/browse/AMQ-9418 > Project: ActiveMQ > Issue Type: Bug >Reporter: Matt Pavlovich >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 5.18.4, 5.17.7, 5.16.8, 6.0.2 > > Time Spent: 40m > Remaining Estimate: 0h > > For javax clients to connect to jakarta-based broker, we need to map > exceptions to the javax namespace from jakarta-based broker-side exceptions > and vice versa for jakarta clients talking to a javax broker. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AMQ-9418) Support mapping jakarta -> javax exceptions in openwire
[ https://issues.apache.org/jira/browse/AMQ-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807423#comment-17807423 ] ASF subversion and git services commented on AMQ-9418: -- Commit b92479cd2ec0913b6dae03a4789bdceae58b57b5 in activemq's branch refs/heads/activemq-5.18.x from Christopher L. Shannon (cshannon) [ https://gitbox.apache.org/repos/asf?p=activemq.git;h=b92479cd2 ] AMQ-9418 - Support converting jakarta jms exceptions to javax This fixes the OpenWire v12 marshaller so that if an exception is received by a jakarta based broker the client will convert back to a javax jms exception type. This commit also updates activemq-client-jakarta to do the proper mapping in the reverse. > Support mapping jakarta -> javax exceptions in openwire > --- > > Key: AMQ-9418 > URL: https://issues.apache.org/jira/browse/AMQ-9418 > Project: ActiveMQ > Issue Type: Bug >Reporter: Matt Pavlovich >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 5.18.4, 5.17.7, 5.16.8, 6.0.2 > > Time Spent: 40m > Remaining Estimate: 0h > > For javax clients to connect to jakarta-based broker, we need to map > exceptions to the javax namespace from jakarta-based broker-side exceptions > and vice versa for jakarta clients talking to a javax broker. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4568) Support reloading AMQP broker federation configuration
[ https://issues.apache.org/jira/browse/ARTEMIS-4568?focusedWorklogId=82&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-82 ] ASF GitHub Bot logged work on ARTEMIS-4568: --- Author: ASF GitHub Bot Created on: 16/Jan/24 20:04 Start Date: 16/Jan/24 20:04 Worklog Time Spent: 10m Work Description: tabish121 opened a new pull request, #4742: URL: https://github.com/apache/activemq-artemis/pull/4742 Allows the configuration of AMQP Federation broker connections to be updated and reloaded. This allows for update, add or remove of AMQP federation broker connections as well as the basic AMQP sender and receiver broker connections. It checks for and ignores changes in AMQP broker connections that are performing Mirroring as that would lead to issues that can break mirroring. Issue Time Tracking --- Worklog Id: (was: 82) Remaining Estimate: 0h Time Spent: 10m > Support reloading AMQP broker federation configuration > -- > > Key: ARTEMIS-4568 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4568 > Project: ActiveMQ Artemis > Issue Type: New Feature > Components: AMQP, Configuration >Affects Versions: 2.31.2 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Minor > Fix For: 2.32.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Add support for reload of AMQP federation broker connection configuration > from XML and broker properties such that active federations are stopped and > updated with new configuration settings, and support add and remove of AMQP > federation broker connections. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (AMQ-9418) Support mapping jakarta -> javax exceptions in openwire
[ https://issues.apache.org/jira/browse/AMQ-9418?focusedWorklogId=899988&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-899988 ] ASF GitHub Bot logged work on AMQ-9418: --- Author: ASF GitHub Bot Created on: 16/Jan/24 19:38 Start Date: 16/Jan/24 19:38 Worklog Time Spent: 10m Work Description: cshannon opened a new pull request, #1141: URL: https://github.com/apache/activemq/pull/1141 This fixes the OpenWire v12 marshaller so that if an exception is received by a javax based broker the client will convert back to a jakarta jms exception type. Issue Time Tracking --- Worklog Id: (was: 899988) Time Spent: 0.5h (was: 20m) > Support mapping jakarta -> javax exceptions in openwire > --- > > Key: AMQ-9418 > URL: https://issues.apache.org/jira/browse/AMQ-9418 > Project: ActiveMQ > Issue Type: Bug >Reporter: Matt Pavlovich >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 5.18.4, 5.17.7, 5.16.8, 6.0.2 > > Time Spent: 0.5h > Remaining Estimate: 0h > > For javax clients to connect to jakarta-based broker, we need to map > exceptions to the javax namespace from jakarta-based broker-side exceptions > and vice versa for jakarta clients talking to a javax broker. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (AMQ-9418) Support mapping jakarta -> javax exceptions in openwire
[ https://issues.apache.org/jira/browse/AMQ-9418?focusedWorklogId=899985&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-899985 ] ASF GitHub Bot logged work on AMQ-9418: --- Author: ASF GitHub Bot Created on: 16/Jan/24 19:19 Start Date: 16/Jan/24 19:19 Worklog Time Spent: 10m Work Description: mattrpav commented on code in PR #1140: URL: https://github.com/apache/activemq/pull/1140#discussion_r1453898497 ## activemq-client/src/main/java/org/apache/activemq/openwire/v12/BaseDataStreamMarshaller.java: ## @@ -16,6 +16,8 @@ */ package org.apache.activemq.openwire.v12; +import static org.apache.activemq.openwire.OpenWireUtil.convertJmsPackage; Review Comment: nice use of import static method =) Issue Time Tracking --- Worklog Id: (was: 899985) Time Spent: 20m (was: 10m) > Support mapping jakarta -> javax exceptions in openwire > --- > > Key: AMQ-9418 > URL: https://issues.apache.org/jira/browse/AMQ-9418 > Project: ActiveMQ > Issue Type: Bug >Reporter: Matt Pavlovich >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 5.18.4, 5.17.7, 5.16.8, 6.0.2 > > Time Spent: 20m > Remaining Estimate: 0h > > For javax clients to connect to jakarta-based broker, we need to map > exceptions to the javax namespace from jakarta-based broker-side exceptions > and vice versa for jakarta clients talking to a javax broker. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (AMQ-9418) Support mapping jakarta -> javax exceptions in openwire
[ https://issues.apache.org/jira/browse/AMQ-9418?focusedWorklogId=899982&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-899982 ] ASF GitHub Bot logged work on AMQ-9418: --- Author: ASF GitHub Bot Created on: 16/Jan/24 19:15 Start Date: 16/Jan/24 19:15 Worklog Time Spent: 10m Work Description: cshannon opened a new pull request, #1140: URL: https://github.com/apache/activemq/pull/1140 This fixes the OpenWire v12 marshaller so that if an exception is received by a jakarta based broker the client will convert back to a javax jms exception type. This commit also updates activemq-client-jakarta to do the proper mapping in the reverse. Issue Time Tracking --- Worklog Id: (was: 899982) Remaining Estimate: 0h Time Spent: 10m > Support mapping jakarta -> javax exceptions in openwire > --- > > Key: AMQ-9418 > URL: https://issues.apache.org/jira/browse/AMQ-9418 > Project: ActiveMQ > Issue Type: Bug >Reporter: Matt Pavlovich >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 5.18.4, 5.17.7, 5.16.8, 6.0.2 > > Time Spent: 10m > Remaining Estimate: 0h > > For javax clients to connect to jakarta-based broker, we need to map > exceptions to the javax namespace from jakarta-based broker-side exceptions > and vice versa for jakarta clients talking to a javax broker. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ARTEMIS-4568) Support reloading AMQP broker federation configuration
Timothy A. Bish created ARTEMIS-4568: Summary: Support reloading AMQP broker federation configuration Key: ARTEMIS-4568 URL: https://issues.apache.org/jira/browse/ARTEMIS-4568 Project: ActiveMQ Artemis Issue Type: New Feature Components: AMQP, Configuration Affects Versions: 2.31.2 Reporter: Timothy A. Bish Assignee: Timothy A. Bish Fix For: 2.32.0 Add support for reload of AMQP federation broker connection configuration from XML and broker properties such that active federations are stopped and updated with new configuration settings, and support add and remove of AMQP federation broker connections. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (AMQ-9418) Support mapping jakarta -> javax exceptions in openwire
[ https://issues.apache.org/jira/browse/AMQ-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher L. Shannon updated AMQ-9418: Fix Version/s: 5.17.7 5.16.8 > Support mapping jakarta -> javax exceptions in openwire > --- > > Key: AMQ-9418 > URL: https://issues.apache.org/jira/browse/AMQ-9418 > Project: ActiveMQ > Issue Type: Bug >Reporter: Matt Pavlovich >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 5.18.4, 5.17.7, 5.16.8, 6.0.2 > > > For javax clients to connect to jakarta-based broker, we need to map > exceptions to the javax namespace from jakarta-based broker-side exceptions > and vice versa for jakarta clients talking to a javax broker. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (AMQ-9418) Support mapping jakarta -> javax exceptions in openwire
[ https://issues.apache.org/jira/browse/AMQ-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807410#comment-17807410 ] Christopher L. Shannon commented on AMQ-9418: - I decided to go with a client side approach as described here https://lists.apache.org/thread/pr2ty60xx54tm3tfnfb1k2hbrmvm59no We can provide updated clients (5.18.x, 6.0.x, etc) that can do the conversion to the correct JMS package if the wrong type is received which is much simpler than the broker having to try and figure out what to send back and doesn't require the broker to keep both versions on the classpath. The downside is any client that wants to handle the conversion needs an upgrade but I think that is ok as long as we document it. Any other clients will just get back a generic JMSException type so would still work just with a less specific exception. The main use case would be for users that have a client or a broker that is mismatched for whatever reason (maybe stuck on an old JDK version, etc) so one is using jakarta and one is using javax. In this case they can still upgrade to the latest versions of that client library line if they want the conversion to work (5.17.x or 5.18.x or whatever) and we can document this on the website for people looking at compatibility between brokers. This obviously means NMS clients or other non-java clients would need an update as well. Going forward with a new version of OpenWire (maybe v13 or v14 etc) ideally we would replace the ExceptionResponse command with a new version (ExceptionResponseV2 or whatever we want to call it) and it can use error codes and allow the client to decide how to convert to exceptions so we are not having to send them back. This also prevents future security issues like the one we recently patched. > Support mapping jakarta -> javax exceptions in openwire > --- > > Key: AMQ-9418 > URL: https://issues.apache.org/jira/browse/AMQ-9418 > Project: ActiveMQ > Issue Type: Bug >Reporter: Matt Pavlovich >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 5.18.4, 5.17.7, 5.16.8, 6.0.2 > > > For javax clients to connect to jakarta-based broker, we need to map > exceptions to the javax namespace from jakarta-based broker-side exceptions > and vice versa for jakarta clients talking to a javax broker. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (AMQ-9418) Support mapping jakarta -> javax exceptions in openwire
[ https://issues.apache.org/jira/browse/AMQ-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher L. Shannon updated AMQ-9418: Fix Version/s: 5.18.4 6.0.2 (was: 6.1.0) > Support mapping jakarta -> javax exceptions in openwire > --- > > Key: AMQ-9418 > URL: https://issues.apache.org/jira/browse/AMQ-9418 > Project: ActiveMQ > Issue Type: Bug >Reporter: Matt Pavlovich >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 5.18.4, 6.0.2 > > > For javax clients to connect to jakarta-based broker, we need to map > exceptions to the javax namespace from jakarta-based broker-side exceptions > and vice versa for jakarta clients talking to a javax broker. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (AMQ-9418) Support mapping jakarta -> javax exceptions in openwire
[ https://issues.apache.org/jira/browse/AMQ-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher L. Shannon updated AMQ-9418: Description: For javax clients to connect to jakarta-based broker, we need to map exceptions to the javax namespace from jakarta-based broker-side exceptions and vice versa for jakarta clients talking to a javax broker. (was: For javax clients to connect to jakarta-based broker, we need to map exceptions to the javax namespace from jakarta-based broker-side exceptions) > Support mapping jakarta -> javax exceptions in openwire > --- > > Key: AMQ-9418 > URL: https://issues.apache.org/jira/browse/AMQ-9418 > Project: ActiveMQ > Issue Type: Task >Reporter: Matt Pavlovich >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 6.1.0 > > > For javax clients to connect to jakarta-based broker, we need to map > exceptions to the javax namespace from jakarta-based broker-side exceptions > and vice versa for jakarta clients talking to a javax broker. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (AMQ-9418) Support mapping jakarta -> javax exceptions in openwire
[ https://issues.apache.org/jira/browse/AMQ-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher L. Shannon updated AMQ-9418: Issue Type: Bug (was: Task) > Support mapping jakarta -> javax exceptions in openwire > --- > > Key: AMQ-9418 > URL: https://issues.apache.org/jira/browse/AMQ-9418 > Project: ActiveMQ > Issue Type: Bug >Reporter: Matt Pavlovich >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 6.1.0 > > > For javax clients to connect to jakarta-based broker, we need to map > exceptions to the javax namespace from jakarta-based broker-side exceptions > and vice versa for jakarta clients talking to a javax broker. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work started] (AMQ-9418) Support mapping jakarta -> javax exceptions in openwire
[ https://issues.apache.org/jira/browse/AMQ-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on AMQ-9418 started by Christopher L. Shannon. --- > Support mapping jakarta -> javax exceptions in openwire > --- > > Key: AMQ-9418 > URL: https://issues.apache.org/jira/browse/AMQ-9418 > Project: ActiveMQ > Issue Type: Task >Reporter: Matt Pavlovich >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 6.1.0 > > > For javax clients to connect to jakarta-based broker, we need to map > exceptions to the javax namespace from jakarta-based broker-side exceptions > and vice versa for jakarta clients talking to a javax broker. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OPENWIRE-74) Add marshal support for error code on JMSExceptions
[ https://issues.apache.org/jira/browse/OPENWIRE-74?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Pavlovich updated OPENWIRE-74: --- Fix Version/s: 1.0.0 > Add marshal support for error code on JMSExceptions > --- > > Key: OPENWIRE-74 > URL: https://issues.apache.org/jira/browse/OPENWIRE-74 > Project: ActiveMQ OpenWire > Issue Type: New Feature >Reporter: Matt Pavlovich >Priority: Major > Fix For: 1.0.0 > > > This allows us to pass error codes to clients -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OPENWIRE-74) Add marshal support for error code on JMSExceptions
Matt Pavlovich created OPENWIRE-74: -- Summary: Add marshal support for error code on JMSExceptions Key: OPENWIRE-74 URL: https://issues.apache.org/jira/browse/OPENWIRE-74 Project: ActiveMQ OpenWire Issue Type: New Feature Reporter: Matt Pavlovich This allows us to pass error codes to clients -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OPENWIRE-74) Add marshal support for error code on JMSExceptions
[ https://issues.apache.org/jira/browse/OPENWIRE-74?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Pavlovich updated OPENWIRE-74: --- Labels: #v13 (was: ) > Add marshal support for error code on JMSExceptions > --- > > Key: OPENWIRE-74 > URL: https://issues.apache.org/jira/browse/OPENWIRE-74 > Project: ActiveMQ OpenWire > Issue Type: New Feature >Reporter: Matt Pavlovich >Priority: Major > Labels: #v13 > Fix For: 1.0.0 > > > This allows us to pass error codes to clients -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ARTEMIS-4558) AMQP Mirror ACKS should be idempotent
[ https://issues.apache.org/jira/browse/ARTEMIS-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17807364#comment-17807364 ] ASF subversion and git services commented on ARTEMIS-4558: -- Commit 1fef332bea6909bd33568232c990f85bae3058e8 in activemq-artemis's branch refs/heads/main from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=1fef332bea ] ARTEMIS-4558 Improving test assertions on IdempotentMirrored Ack Test > AMQP Mirror ACKS should be idempotent > - > > Key: ARTEMIS-4558 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4558 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.32.0 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > When I first developed Mirroring, I assumed sending the mirrored ACK on a > aferACK and disconnected from any other transactions would be enough, with > the caveat you could get a duplicate delivery on the target mirror in case of > failures. > I got some complains that this is not safe enough from some users, and I'm > making this now idempotent. > I took an overal mirroring hardening approach and I'm improving test coverage > for this improvement. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (AMQ-9418) Support mapping jakarta -> javax exceptions in openwire
[ https://issues.apache.org/jira/browse/AMQ-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher L. Shannon reassigned AMQ-9418: --- Assignee: Christopher L. Shannon > Support mapping jakarta -> javax exceptions in openwire > --- > > Key: AMQ-9418 > URL: https://issues.apache.org/jira/browse/AMQ-9418 > Project: ActiveMQ > Issue Type: Task >Reporter: Matt Pavlovich >Assignee: Christopher L. Shannon >Priority: Major > Fix For: 6.1.0 > > > For javax clients to connect to jakarta-based broker, we need to map > exceptions to the javax namespace from jakarta-based broker-side exceptions -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (ARTEMIS-4552) Configure all connection-router settings by using broker properties
[
https://issues.apache.org/jira/browse/ARTEMIS-4552?focusedWorklogId=899827&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-899827
]
ASF GitHub Bot logged work on ARTEMIS-4552:
---
Author: ASF GitHub Bot
Created on: 16/Jan/24 09:50
Start Date: 16/Jan/24 09:50
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4729:
URL: https://github.com/apache/activemq-artemis/pull/4729#discussion_r1453163076
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/routing/CacheConfiguration.java:
##
@@ -43,4 +52,12 @@ public CacheConfiguration setTimeout(int timeout) {
this.timeout = timeout;
return this;
}
+
+ public CacheConfiguration() {
+
+ }
+
+ public CacheConfiguration(boolean enabled) {
+ this.enabled = enabled;
+ }
Review Comment:
Can we put the constructors at the top given their importance in this case
(will also minimise the diff in this case as one was there already)
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java:
##
@@ -2871,6 +2871,9 @@ private void parseConnectionRouterConfiguration(final
Element e, final Configura
}
private void parseCacheConfiguration(final Element e, final
CacheConfiguration cacheConfiguration) throws ClassNotFoundException {
+ cacheConfiguration.setEnabled(getBoolean(e, "enabled",
+ cacheConfiguration.isEnabled()));
Review Comment:
Feels like this would be better defaulting to simply the literal "true" per
the xsd as you had it originally?
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/routing/PoolConfiguration.java:
##
@@ -118,4 +129,12 @@ public PoolConfiguration setDiscoveryGroupName(String
discoveryGroupName) {
this.discoveryGroupName = discoveryGroupName;
return this;
}
+
+ public PoolConfiguration() {
+
+ }
+
+ public PoolConfiguration(boolean enabled) {
+ this.enabled = enabled;
+ }
Review Comment:
Ditto
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java:
##
@@ -2889,6 +2892,9 @@ private void parsePolicyConfiguration(final Element e,
final NamedPropertyConfig
}
private void parsePoolConfiguration(final Element e, final Configuration
config, final PoolConfiguration poolConfiguration) throws Exception {
+ poolConfiguration.setEnabled(getBoolean(e, "enabled",
+ poolConfiguration.isEnabled()));
Review Comment:
ditto
Issue Time Tracking
---
Worklog Id: (was: 899827)
Time Spent: 1.5h (was: 1h 20m)
> Configure all connection-router settings by using broker properties
> ---
>
> Key: ARTEMIS-4552
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4552
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Domenico Francesco Bruscino
>Assignee: Domenico Francesco Bruscino
>Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Allow to configure all the connection-router settings by using the broker
> properties. The broker properties for the cache configuration cause a null
> pointer exception:
> {code}
> "connectionRouters.autoShard.cacheConfiguration.persisted=true"
> "connectionRouters.autoShard.cacheConfiguration.timeout=6"
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
