[jira] [Assigned] (ARTEMIS-4787) Anycast queue does not auto-create if already multicast queue on same address
[
https://issues.apache.org/jira/browse/ARTEMIS-4787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Bertram reassigned ARTEMIS-4787:
---
Assignee: Justin Bertram
> Anycast queue does not auto-create if already multicast queue on same address
> -
>
> Key: ARTEMIS-4787
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4787
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Reporter: Josh Byster
>Assignee: Justin Bertram
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As a preface, I am aware that creating both anycast and multicast queues on
> the same address is an anti-pattern and not recommended. However, this is
> causing difficulties migrating over legacy clients from using Classic to
> Artemis.
> If one creates a JMS topic on an address, and then tries to create a JMS
> queue, it fails to create. However, if the order is flipped (creating a
> queue, then a topic), there is no exception.
> It seems like the issue is in this area of {{ServerSessionImpl}}:
> {code:java}
> Bindings bindings =
> server.getPostOffice().lookupBindingsForAddress(unPrefixedAddress);
> if (bindings != null && bindings.hasLocalBinding() && !queueConfig.isFqqn()) {
>// The address has another queue with a different name, which is fine.
> Just ignore it.
>result = AutoCreateResult.EXISTED;{code}
> Please see test below to reproduce, which throws the exception immediately as
> seen in production.
> {code:java}
> package org.apache.activemq.artemis.tests.integration;
> import org.apache.activemq.artemis.api.core.client.ClientSession;
> import org.apache.activemq.artemis.api.core.client.ClientSessionFactory;
> import org.apache.activemq.artemis.api.core.client.ServerLocator;
> import org.apache.activemq.artemis.core.server.ActiveMQServer;
> import org.apache.activemq.artemis.core.settings.impl.AddressSettings;
> import org.apache.activemq.artemis.tests.util.ActiveMQTestBase;
> import org.junit.Before;
> import org.junit.Test;
> import javax.jms.Connection;
> import javax.jms.ConnectionFactory;
> import javax.jms.MessageConsumer;
> import javax.jms.Queue;
> import javax.jms.Session;
> import javax.jms.Topic;
> import java.util.HashMap;
> public class QueueTopicSameNameTest extends ActiveMQTestBase {
> protected ActiveMQServer server;
> @Override
> @Before
> public void setUp() throws Exception {
> super.setUp();
> server = createServer(true, createDefaultNettyConfig());
> server.start();
> }
> @Test
> public void testTopicThenQueueCreate() throws Exception {
> String myAddr = "TEST";
> ConnectionFactory cf = new
> org.apache.activemq.ActiveMQConnectionFactory("failover:(tcp://localhost:61616)");
> Connection c = cf.createConnection();
> Session s = c.createSession();
> Topic t = s.createTopic(myAddr);
> MessageConsumer consumer = s.createConsumer(t);
> Queue q = s.createQueue(myAddr);
> MessageConsumer otherConsumer = s.createConsumer(q);
> c.close();
> }
> }{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Updated] (AMQ-9487) Deprecated tag for ForcePersistencyModeBroker and TimeStampingBrokerPlugin
[ https://issues.apache.org/jira/browse/AMQ-9487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Pavlovich updated AMQ-9487: Description: Prefer to configure a HeaderMessageInterceptorStrategy on a DestinationPolicy instead (was: Prefer to configure a HeaderMessageStrategy on a DestinationPolicy instead) > Deprecated tag for ForcePersistencyModeBroker and TimeStampingBrokerPlugin > -- > > Key: AMQ-9487 > URL: https://issues.apache.org/jira/browse/AMQ-9487 > Project: ActiveMQ Classic > Issue Type: Task >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Minor > > Prefer to configure a HeaderMessageInterceptorStrategy on a DestinationPolicy > instead -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4787) Anycast queue does not auto-create if already multicast queue on same address
[
https://issues.apache.org/jira/browse/ARTEMIS-4787?focusedWorklogId=921842=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921842
]
ASF GitHub Bot logged work on ARTEMIS-4787:
---
Author: ASF GitHub Bot
Created on: 03/Jun/24 20:19
Start Date: 03/Jun/24 20:19
Worklog Time Spent: 10m
Work Description: jbertram commented on PR #4957:
URL:
https://github.com/apache/activemq-artemis/pull/4957#issuecomment-2146048881
BTW, I already ran the full test-suite on this and there were no failures
related to my changes.
Issue Time Tracking
---
Worklog Id: (was: 921842)
Time Spent: 20m (was: 10m)
> Anycast queue does not auto-create if already multicast queue on same address
> -
>
> Key: ARTEMIS-4787
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4787
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Reporter: Josh Byster
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> As a preface, I am aware that creating both anycast and multicast queues on
> the same address is an anti-pattern and not recommended. However, this is
> causing difficulties migrating over legacy clients from using Classic to
> Artemis.
> If one creates a JMS topic on an address, and then tries to create a JMS
> queue, it fails to create. However, if the order is flipped (creating a
> queue, then a topic), there is no exception.
> It seems like the issue is in this area of {{ServerSessionImpl}}:
> {code:java}
> Bindings bindings =
> server.getPostOffice().lookupBindingsForAddress(unPrefixedAddress);
> if (bindings != null && bindings.hasLocalBinding() && !queueConfig.isFqqn()) {
>// The address has another queue with a different name, which is fine.
> Just ignore it.
>result = AutoCreateResult.EXISTED;{code}
> Please see test below to reproduce, which throws the exception immediately as
> seen in production.
> {code:java}
> package org.apache.activemq.artemis.tests.integration;
> import org.apache.activemq.artemis.api.core.client.ClientSession;
> import org.apache.activemq.artemis.api.core.client.ClientSessionFactory;
> import org.apache.activemq.artemis.api.core.client.ServerLocator;
> import org.apache.activemq.artemis.core.server.ActiveMQServer;
> import org.apache.activemq.artemis.core.settings.impl.AddressSettings;
> import org.apache.activemq.artemis.tests.util.ActiveMQTestBase;
> import org.junit.Before;
> import org.junit.Test;
> import javax.jms.Connection;
> import javax.jms.ConnectionFactory;
> import javax.jms.MessageConsumer;
> import javax.jms.Queue;
> import javax.jms.Session;
> import javax.jms.Topic;
> import java.util.HashMap;
> public class QueueTopicSameNameTest extends ActiveMQTestBase {
> protected ActiveMQServer server;
> @Override
> @Before
> public void setUp() throws Exception {
> super.setUp();
> server = createServer(true, createDefaultNettyConfig());
> server.start();
> }
> @Test
> public void testTopicThenQueueCreate() throws Exception {
> String myAddr = "TEST";
> ConnectionFactory cf = new
> org.apache.activemq.ActiveMQConnectionFactory("failover:(tcp://localhost:61616)");
> Connection c = cf.createConnection();
> Session s = c.createSession();
> Topic t = s.createTopic(myAddr);
> MessageConsumer consumer = s.createConsumer(t);
> Queue q = s.createQueue(myAddr);
> MessageConsumer otherConsumer = s.createConsumer(q);
> c.close();
> }
> }{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4787) Anycast queue does not auto-create if already multicast queue on same address
[
https://issues.apache.org/jira/browse/ARTEMIS-4787?focusedWorklogId=921841=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921841
]
ASF GitHub Bot logged work on ARTEMIS-4787:
---
Author: ASF GitHub Bot
Created on: 03/Jun/24 20:18
Start Date: 03/Jun/24 20:18
Worklog Time Spent: 10m
Work Description: jbertram opened a new pull request, #4957:
URL: https://github.com/apache/activemq-artemis/pull/4957
There's an edge-case in the auto-creation logic for anycast queues that
checks to see if any queue already exists on the address and if so then nothing
further is created. It's not clear to me what use-case this is for, and it
precludes the use-case detailed on ARTEMIS-4787 where a migrating user has
overlapping names for JMS queues and topics.
This commit removes this edge-case and adds a test to verify auto-creation
works properly with both OpenWire and Core. The test includes methods for AMQP,
but they are disabled since the AMQP protocol handler doesn't handle this
use-case at all. This PR is specifically for OpenWire.
Issue Time Tracking
---
Worklog Id: (was: 921841)
Remaining Estimate: 0h
Time Spent: 10m
> Anycast queue does not auto-create if already multicast queue on same address
> -
>
> Key: ARTEMIS-4787
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4787
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Reporter: Josh Byster
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As a preface, I am aware that creating both anycast and multicast queues on
> the same address is an anti-pattern and not recommended. However, this is
> causing difficulties migrating over legacy clients from using Classic to
> Artemis.
> If one creates a JMS topic on an address, and then tries to create a JMS
> queue, it fails to create. However, if the order is flipped (creating a
> queue, then a topic), there is no exception.
> It seems like the issue is in this area of {{ServerSessionImpl}}:
> {code:java}
> Bindings bindings =
> server.getPostOffice().lookupBindingsForAddress(unPrefixedAddress);
> if (bindings != null && bindings.hasLocalBinding() && !queueConfig.isFqqn()) {
>// The address has another queue with a different name, which is fine.
> Just ignore it.
>result = AutoCreateResult.EXISTED;{code}
> Please see test below to reproduce, which throws the exception immediately as
> seen in production.
> {code:java}
> package org.apache.activemq.artemis.tests.integration;
> import org.apache.activemq.artemis.api.core.client.ClientSession;
> import org.apache.activemq.artemis.api.core.client.ClientSessionFactory;
> import org.apache.activemq.artemis.api.core.client.ServerLocator;
> import org.apache.activemq.artemis.core.server.ActiveMQServer;
> import org.apache.activemq.artemis.core.settings.impl.AddressSettings;
> import org.apache.activemq.artemis.tests.util.ActiveMQTestBase;
> import org.junit.Before;
> import org.junit.Test;
> import javax.jms.Connection;
> import javax.jms.ConnectionFactory;
> import javax.jms.MessageConsumer;
> import javax.jms.Queue;
> import javax.jms.Session;
> import javax.jms.Topic;
> import java.util.HashMap;
> public class QueueTopicSameNameTest extends ActiveMQTestBase {
> protected ActiveMQServer server;
> @Override
> @Before
> public void setUp() throws Exception {
> super.setUp();
> server = createServer(true, createDefaultNettyConfig());
> server.start();
> }
> @Test
> public void testTopicThenQueueCreate() throws Exception {
> String myAddr = "TEST";
> ConnectionFactory cf = new
> org.apache.activemq.ActiveMQConnectionFactory("failover:(tcp://localhost:61616)");
> Connection c = cf.createConnection();
> Session s = c.createSession();
> Topic t = s.createTopic(myAddr);
> MessageConsumer consumer = s.createConsumer(t);
> Queue q = s.createQueue(myAddr);
> MessageConsumer otherConsumer = s.createConsumer(q);
> c.close();
> }
> }{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Commented] (ARTEMIS-4780) Artemis web console does not ever set 'artemisJmxDomain' in localStorage
[
https://issues.apache.org/jira/browse/ARTEMIS-4780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17851801#comment-17851801
]
Josh Byster commented on ARTEMIS-4780:
--
Thanks for the quick fix on this, [~andytaylor]!
> Artemis web console does not ever set 'artemisJmxDomain' in localStorage
>
>
> Key: ARTEMIS-4780
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4780
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.32.0
>Reporter: Josh Byster
>Assignee: Andy Taylor
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We relocate our artemis packages as part of our shading process.
> I did set up:
>
> {code:java}
> aActiveMQServer.getConfiguration().setJMXDomain("com.abc.shaded.org.apache.activemq.artemis");
> {code}
> However the web console does not show up. I noticed in the code it's because
> we try to read in localStorage['artemisJmxDomain'] but never actually set it
> as far as I can tell. Thus we always default to org.apache.activemq.artemis.
> Everything works properly when setting localStorage['artemisJmxDomain'] =
> "com.abc.shaded.org.apache.activemq.artemis"
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Created] (ARTEMIS-4793) OpenWire auto-created consumer queues are not marked as auto-created
Josh Byster created ARTEMIS-4793:
Summary: OpenWire auto-created consumer queues are not marked as
auto-created
Key: ARTEMIS-4793
URL: https://issues.apache.org/jira/browse/ARTEMIS-4793
Project: ActiveMQ Artemis
Issue Type: Bug
Components: OpenWire
Reporter: Josh Byster
I noticed that in AMQConsumer line 256:
{code:java}
session.getCoreSession().createQueue(new
QueueConfiguration(queueName).setAddress(address).setFilterString(selector).setDurable(false).setTemporary(true).setInternal(internalAddress));
{code}
We do not set the autoCreated flag, which does not make it eligible for
deletion automatically unless {{auto-delete-created-queues}} is set to true
(easy workaround, but maybe not technically necessary).
Effectively we do not define any queues on startup and none of them end up
being marked as auto-created for this reason.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4792) Add support for setting consumer priority on AMQP Receiver Source addresses
[
https://issues.apache.org/jira/browse/ARTEMIS-4792?focusedWorklogId=921836=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921836
]
ASF GitHub Bot logged work on ARTEMIS-4792:
---
Author: ASF GitHub Bot
Created on: 03/Jun/24 19:32
Start Date: 03/Jun/24 19:32
Worklog Time Spent: 10m
Work Description: tabish121 opened a new pull request, #4956:
URL: https://github.com/apache/activemq-artemis/pull/4956
…ress
Allow the Source address to provide consumer priority on the address using
the same option value as a core consumer '?consumer-priority=X'. The change
parses any query string appended to an address and uses the address portion as
the actual receiver address and currently only looks at consumer priority
values in the extracted address query parameters and ignores any other options
found. The existing consumer priority taken from link properties takes
precedence over the value placed on the address query options if both are
present.
Issue Time Tracking
---
Worklog Id: (was: 921836)
Remaining Estimate: 0h
Time Spent: 10m
> Add support for setting consumer priority on AMQP Receiver Source addresses
> ---
>
> Key: ARTEMIS-4792
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4792
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: AMQP
>Affects Versions: 2.34.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Minor
> Fix For: 2.35.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When creating a receiver link from a client the only way currently to adjust
> the consumer priority on the broker is to set a value in the receiver
> properties to indicate the desired priority. For some client AMQP client
> libraries this is not simple or not possible in the provided API. To solve
> this we can add support for parsing URI type options from the source address
> of the receiver attach and look for the option "consumer-priority" which is
> also used by the Core client to configure consumer priority (Openwire clients
> can do the same via an openwire client property "consumer.priority").
> This updates the client receiver attach to extract properties from the
> address the source which have the form:
> {code:java}
> address?consumer-priority=1{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Updated] (ARTEMIS-4792) Add support for setting consumer priority on AMQP Receiver Source addresses
[
https://issues.apache.org/jira/browse/ARTEMIS-4792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothy A. Bish updated ARTEMIS-4792:
-
Summary: Add support for setting consumer priority on AMQP Receiver Source
addresses (was: Add support for setting consumer priority on AMQP Source
address)
> Add support for setting consumer priority on AMQP Receiver Source addresses
> ---
>
> Key: ARTEMIS-4792
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4792
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: AMQP
>Affects Versions: 2.34.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Minor
> Fix For: 2.35.0
>
>
> When creating a receiver link from a client the only way currently to adjust
> the consumer priority on the broker is to set a value in the receiver
> properties to indicate the desired priority. For some client AMQP client
> libraries this is not simple or not possible in the provided API. To solve
> this we can add support for parsing URI type options from the source address
> of the receiver attach and look for the option "consumer-priority" which is
> also used by the Core client to configure consumer priority (Openwire clients
> can do the same via an openwire client property "consumer.priority").
> This updates the client receiver attach to extract properties from the
> address the source which have the form:
> {code:java}
> address?consumer-priority=1{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Created] (ARTEMIS-4792) Add support for setting consumer priority on AMQP Source address
Timothy A. Bish created ARTEMIS-4792:
Summary: Add support for setting consumer priority on AMQP Source
address
Key: ARTEMIS-4792
URL: https://issues.apache.org/jira/browse/ARTEMIS-4792
Project: ActiveMQ Artemis
Issue Type: New Feature
Components: AMQP
Affects Versions: 2.34.0
Reporter: Timothy A. Bish
Assignee: Timothy A. Bish
Fix For: 2.35.0
When creating a receiver link from a client the only way currently to adjust
the consumer priority on the broker is to set a value in the receiver
properties to indicate the desired priority. For some client AMQP client
libraries this is not simple or not possible in the provided API. To solve
this we can add support for parsing URI type options from the source address of
the receiver attach and look for the option "consumer-priority" which is also
used by the Core client to configure consumer priority (Openwire clients can do
the same via an openwire client property "consumer.priority").
This updates the client receiver attach to extract properties from the address
the source which have the form:
{code:java}
address?consumer-priority=1{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4760) Creating MQTT consumer should work if auto-create-queues is false
[ https://issues.apache.org/jira/browse/ARTEMIS-4760?focusedWorklogId=921815=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921815 ] ASF GitHub Bot logged work on ARTEMIS-4760: --- Author: ASF GitHub Bot Created on: 03/Jun/24 17:19 Start Date: 03/Jun/24 17:19 Worklog Time Spent: 10m Work Description: jbertram opened a new pull request, #4955: URL: https://github.com/apache/activemq-artemis/pull/4955 (no comment) Issue Time Tracking --- Worklog Id: (was: 921815) Remaining Estimate: 0h Time Spent: 10m > Creating MQTT consumer should work if auto-create-queues is false > - > > Key: ARTEMIS-4760 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4760 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Resolved] (ARTEMIS-4791) Update to JUnit 5.10.2
[ https://issues.apache.org/jira/browse/ARTEMIS-4791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved ARTEMIS-4791. - Resolution: Fixed > Update to JUnit 5.10.2 > -- > > Key: ARTEMIS-4791 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4791 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade > Components: Tests >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Update to JUnit 5.10.2 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Commented] (ARTEMIS-4791) Update to JUnit 5.10.2
[ https://issues.apache.org/jira/browse/ARTEMIS-4791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17851728#comment-17851728 ] ASF subversion and git services commented on ARTEMIS-4791: -- Commit 8935b1150b6708e8d608bcaec60e08e446c54151 in activemq-artemis's branch refs/heads/main from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=8935b1150b ] ARTEMIS-4791: update to junit-5.10.2 > Update to JUnit 5.10.2 > -- > > Key: ARTEMIS-4791 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4791 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade > Components: Tests >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Update to JUnit 5.10.2 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4791) Update to JUnit 5.10.2
[ https://issues.apache.org/jira/browse/ARTEMIS-4791?focusedWorklogId=921813=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921813 ] ASF GitHub Bot logged work on ARTEMIS-4791: --- Author: ASF GitHub Bot Created on: 03/Jun/24 16:49 Start Date: 03/Jun/24 16:49 Worklog Time Spent: 10m Work Description: gemmellr merged PR #4954: URL: https://github.com/apache/activemq-artemis/pull/4954 Issue Time Tracking --- Worklog Id: (was: 921813) Time Spent: 20m (was: 10m) > Update to JUnit 5.10.2 > -- > > Key: ARTEMIS-4791 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4791 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade > Components: Tests >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > Update to JUnit 5.10.2 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4791) Update to JUnit 5.10.2
[ https://issues.apache.org/jira/browse/ARTEMIS-4791?focusedWorklogId=921809=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921809 ] ASF GitHub Bot logged work on ARTEMIS-4791: --- Author: ASF GitHub Bot Created on: 03/Jun/24 16:03 Start Date: 03/Jun/24 16:03 Worklog Time Spent: 10m Work Description: gemmellr opened a new pull request, #4954: URL: https://github.com/apache/activemq-artemis/pull/4954 (no comment) Issue Time Tracking --- Worklog Id: (was: 921809) Remaining Estimate: 0h Time Spent: 10m > Update to JUnit 5.10.2 > -- > > Key: ARTEMIS-4791 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4791 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade > Components: Tests >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Update to JUnit 5.10.2 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Commented] (ARTEMIS-4760) Creating MQTT consumer should work if auto-create-queues is false
[
https://issues.apache.org/jira/browse/ARTEMIS-4760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17851708#comment-17851708
]
Justin Bertram commented on ARTEMIS-4760:
-
The broker creates a subscription queue for an MQTT consumer and it should do
so even if {{auto-create-queues}} is {{false}} because this is how it's handled
for other protocols and also the documented behavior:
bq. Automatic queue creation is for queues that _would not otherwise be created
during normal operation_. For example, when a remote application creates a
consumer on a JMS topic then a queue will be created representing that
subscription as described in the [JMS-to-core mapping
chapter|https://activemq.apache.org/components/artemis/documentation/latest/jms-core-mapping.html].
This queue will be created regardless of how {{auto-create-queues}} is
configured because it is required for _normal operation_.
The previously committed code is incorrect.
> Creating MQTT consumer should work if auto-create-queues is false
> -
>
> Key: ARTEMIS-4760
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4760
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Created] (ARTEMIS-4791) Update to JUnit 5.10.2
Robbie Gemmell created ARTEMIS-4791: --- Summary: Update to JUnit 5.10.2 Key: ARTEMIS-4791 URL: https://issues.apache.org/jira/browse/ARTEMIS-4791 Project: ActiveMQ Artemis Issue Type: Dependency upgrade Components: Tests Reporter: Robbie Gemmell Assignee: Robbie Gemmell Update to JUnit 5.10.2 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work started] (ARTEMIS-4790) Use JUnit 5 for the test suite
[ https://issues.apache.org/jira/browse/ARTEMIS-4790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on ARTEMIS-4790 started by Robbie Gemmell. --- > Use JUnit 5 for the test suite > -- > > Key: ARTEMIS-4790 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4790 > Project: ActiveMQ Artemis > Issue Type: Task > Components: Tests >Affects Versions: 2.33.0 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: 2.35.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Switch to using JUnit 5 for the test suite, primarily using the new JUnit > Jupiter API and associated junit-jupiter-engine engine, but with select use > of junit-vintage-engine for some specific tests/models, e.g those that > require specific third party JUnit 4 Runners, or rely on dependencies that > fix them at JUnit 4 / 3. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Assigned] (ARTEMIS-4790) Use JUnit 5 for the test suite
[ https://issues.apache.org/jira/browse/ARTEMIS-4790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell reassigned ARTEMIS-4790: --- Assignee: Robbie Gemmell > Use JUnit 5 for the test suite > -- > > Key: ARTEMIS-4790 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4790 > Project: ActiveMQ Artemis > Issue Type: Task > Components: Tests >Affects Versions: 2.33.0 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: 2.35.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Switch to using JUnit 5 for the test suite, primarily using the new JUnit > Jupiter API and associated junit-jupiter-engine engine, but with select use > of junit-vintage-engine for some specific tests/models, e.g those that > require specific third party JUnit 4 Runners, or rely on dependencies that > fix them at JUnit 4 / 3. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Commented] (ARTEMIS-4790) Use JUnit 5 for the test suite
[ https://issues.apache.org/jira/browse/ARTEMIS-4790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17851688#comment-17851688 ] ASF subversion and git services commented on ARTEMIS-4790: -- Commit 362dbd11ac132e66f7bce99eb0fb4aa020346210 in activemq-artemis's branch refs/heads/main from Robbie Gemmell [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=362dbd11ac ] ARTEMIS-4790: use JUnit 5 for the tests > Use JUnit 5 for the test suite > -- > > Key: ARTEMIS-4790 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4790 > Project: ActiveMQ Artemis > Issue Type: Task > Components: Tests >Affects Versions: 2.33.0 >Reporter: Robbie Gemmell >Priority: Major > Fix For: 2.35.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Switch to using JUnit 5 for the test suite, primarily using the new JUnit > Jupiter API and associated junit-jupiter-engine engine, but with select use > of junit-vintage-engine for some specific tests/models, e.g those that > require specific third party JUnit 4 Runners, or rely on dependencies that > fix them at JUnit 4 / 3. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4790) Use JUnit 5 for the test suite
[ https://issues.apache.org/jira/browse/ARTEMIS-4790?focusedWorklogId=921797=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921797 ] ASF GitHub Bot logged work on ARTEMIS-4790: --- Author: ASF GitHub Bot Created on: 03/Jun/24 15:06 Start Date: 03/Jun/24 15:06 Worklog Time Spent: 10m Work Description: jbertram merged PR #4953: URL: https://github.com/apache/activemq-artemis/pull/4953 Issue Time Tracking --- Worklog Id: (was: 921797) Time Spent: 0.5h (was: 20m) > Use JUnit 5 for the test suite > -- > > Key: ARTEMIS-4790 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4790 > Project: ActiveMQ Artemis > Issue Type: Task > Components: Tests >Affects Versions: 2.33.0 >Reporter: Robbie Gemmell >Priority: Major > Fix For: 2.35.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Switch to using JUnit 5 for the test suite, primarily using the new JUnit > Jupiter API and associated junit-jupiter-engine engine, but with select use > of junit-vintage-engine for some specific tests/models, e.g those that > require specific third party JUnit 4 Runners, or rely on dependencies that > fix them at JUnit 4 / 3. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4790) Use JUnit 5 for the test suite
[ https://issues.apache.org/jira/browse/ARTEMIS-4790?focusedWorklogId=921796=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921796 ] ASF GitHub Bot logged work on ARTEMIS-4790: --- Author: ASF GitHub Bot Created on: 03/Jun/24 15:06 Start Date: 03/Jun/24 15:06 Worklog Time Spent: 10m Work Description: jbertram commented on PR #4953: URL: https://github.com/apache/activemq-artemis/pull/4953#issuecomment-2145441213 After a skim I'm proceeding with a commit-then-review approach to avoid having to rebase this more than you've already had to. Issue Time Tracking --- Worklog Id: (was: 921796) Time Spent: 20m (was: 10m) > Use JUnit 5 for the test suite > -- > > Key: ARTEMIS-4790 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4790 > Project: ActiveMQ Artemis > Issue Type: Task > Components: Tests >Affects Versions: 2.33.0 >Reporter: Robbie Gemmell >Priority: Major > Fix For: 2.35.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Switch to using JUnit 5 for the test suite, primarily using the new JUnit > Jupiter API and associated junit-jupiter-engine engine, but with select use > of junit-vintage-engine for some specific tests/models, e.g those that > require specific third party JUnit 4 Runners, or rely on dependencies that > fix them at JUnit 4 / 3. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4790) Use JUnit 5 for the test suite
[ https://issues.apache.org/jira/browse/ARTEMIS-4790?focusedWorklogId=921782=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921782 ] ASF GitHub Bot logged work on ARTEMIS-4790: --- Author: ASF GitHub Bot Created on: 03/Jun/24 14:28 Start Date: 03/Jun/24 14:28 Worklog Time Spent: 10m Work Description: gemmellr opened a new pull request, #4953: URL: https://github.com/apache/activemq-artemis/pull/4953 Use JUnit 5 for the test suite; primarily the Jupiter API and junit-jupiter-engine, but junit-vintage-engine for a few select modules or test classes that rely on runners or deps that still need the earlier APIs. Given the changes are test-only and the significant amount of time I have already spent rebasing them to this point, I'd like to merge this quickly and then address tweaking as followups. Issue Time Tracking --- Worklog Id: (was: 921782) Remaining Estimate: 0h Time Spent: 10m > Use JUnit 5 for the test suite > -- > > Key: ARTEMIS-4790 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4790 > Project: ActiveMQ Artemis > Issue Type: Task > Components: Tests >Affects Versions: 2.33.0 >Reporter: Robbie Gemmell >Priority: Major > Fix For: 2.35.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Switch to using JUnit 5 for the test suite, primarily using the new JUnit > Jupiter API and associated junit-jupiter-engine engine, but with select use > of junit-vintage-engine for some specific tests/models, e.g those that > require specific third party JUnit 4 Runners, or rely on dependencies that > fix them at JUnit 4 / 3. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Created] (ARTEMIS-4790) Use JUnit 5 for the test suite
Robbie Gemmell created ARTEMIS-4790: --- Summary: Use JUnit 5 for the test suite Key: ARTEMIS-4790 URL: https://issues.apache.org/jira/browse/ARTEMIS-4790 Project: ActiveMQ Artemis Issue Type: Task Components: Tests Affects Versions: 2.33.0 Reporter: Robbie Gemmell Fix For: 2.35.0 Switch to using JUnit 5 for the test suite, primarily using the new JUnit Jupiter API and associated junit-jupiter-engine engine, but with select use of junit-vintage-engine for some specific tests/models, e.g those that require specific third party JUnit 4 Runners, or rely on dependencies that fix them at JUnit 4 / 3. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Commented] (ARTEMIS-4780) Artemis web console does not ever set 'artemisJmxDomain' in localStorage
[
https://issues.apache.org/jira/browse/ARTEMIS-4780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17851579#comment-17851579
]
Andy Taylor commented on ARTEMIS-4780:
--
I have changed the new console to auto detect the domain by searching for
*{*}:broker={*}*. PR at
[https://github.com/apache/activemq-artemis-console/pull/18] . I will hopefully
release a 1.0.0 (that can be run standalone, very soon.
Regarding the current console, I don't see any point in changing it, It has
been like that for years but if you want to do something similar you could make
the changes and send a PR.
> Artemis web console does not ever set 'artemisJmxDomain' in localStorage
>
>
> Key: ARTEMIS-4780
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4780
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.32.0
>Reporter: Josh Byster
>Assignee: Andy Taylor
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We relocate our artemis packages as part of our shading process.
> I did set up:
>
> {code:java}
> aActiveMQServer.getConfiguration().setJMXDomain("com.abc.shaded.org.apache.activemq.artemis");
> {code}
> However the web console does not show up. I noticed in the code it's because
> we try to read in localStorage['artemisJmxDomain'] but never actually set it
> as far as I can tell. Thus we always default to org.apache.activemq.artemis.
> Everything works properly when setting localStorage['artemisJmxDomain'] =
> "com.abc.shaded.org.apache.activemq.artemis"
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4780) Artemis web console does not ever set 'artemisJmxDomain' in localStorage
[
https://issues.apache.org/jira/browse/ARTEMIS-4780?focusedWorklogId=921726=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921726
]
ASF GitHub Bot logged work on ARTEMIS-4780:
---
Author: ASF GitHub Bot
Created on: 03/Jun/24 10:31
Start Date: 03/Jun/24 10:31
Worklog Time Spent: 10m
Work Description: andytaylor opened a new pull request, #18:
URL: https://github.com/apache/activemq-artemis-console/pull/18
This is because users can change this, the code now searched for *:broker=*
Issue Time Tracking
---
Worklog Id: (was: 921726)
Remaining Estimate: 0h
Time Spent: 10m
> Artemis web console does not ever set 'artemisJmxDomain' in localStorage
>
>
> Key: ARTEMIS-4780
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4780
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.32.0
>Reporter: Josh Byster
>Assignee: Andy Taylor
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We relocate our artemis packages as part of our shading process.
> I did set up:
>
> {code:java}
> aActiveMQServer.getConfiguration().setJMXDomain("com.abc.shaded.org.apache.activemq.artemis");
> {code}
> However the web console does not show up. I noticed in the code it's because
> we try to read in localStorage['artemisJmxDomain'] but never actually set it
> as far as I can tell. Thus we always default to org.apache.activemq.artemis.
> Everything works properly when setting localStorage['artemisJmxDomain'] =
> "com.abc.shaded.org.apache.activemq.artemis"
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Assigned] (ARTEMIS-4780) Artemis web console does not ever set 'artemisJmxDomain' in localStorage
[
https://issues.apache.org/jira/browse/ARTEMIS-4780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy Taylor reassigned ARTEMIS-4780:
Assignee: Andy Taylor
> Artemis web console does not ever set 'artemisJmxDomain' in localStorage
>
>
> Key: ARTEMIS-4780
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4780
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.32.0
>Reporter: Josh Byster
>Assignee: Andy Taylor
>Priority: Minor
>
> We relocate our artemis packages as part of our shading process.
> I did set up:
>
> {code:java}
> aActiveMQServer.getConfiguration().setJMXDomain("com.abc.shaded.org.apache.activemq.artemis");
> {code}
> However the web console does not show up. I noticed in the code it's because
> we try to read in localStorage['artemisJmxDomain'] but never actually set it
> as far as I can tell. Thus we always default to org.apache.activemq.artemis.
> Everything works properly when setting localStorage['artemisJmxDomain'] =
> "com.abc.shaded.org.apache.activemq.artemis"
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
