[jira] [Commented] (ARTEMIS-2965) Allow mirror to stop capture events and delete inner queue
[ https://issues.apache.org/jira/browse/ARTEMIS-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854596#comment-17854596 ] Clebert Suconic commented on ARTEMIS-2965: -- [~sebaker]I will think about doing this task. Regarding the mirroring growing faster.. take a look at the latest releases? Especially 2.34.0 and 2.35.0 now? I did a lot of working in Mirroring, especially with Paging. (Paging was not working at all and I fixed a lot of stuff now). > Allow mirror to stop capture events and delete inner queue > -- > > Key: ARTEMIS-2965 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2965 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.16.0 >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Critical > > When a mirror starts, the current events will not be cleared when > brokerConnection.stop() is called. > > We should support removing the Mirror manager, and deleting the queue upon > brokerConnection.stop(). > (or another method TBD that would determine the semantic to remove the SnF > queue and future generation on mirror). > Related comments: > [https://github.com/apache/activemq-artemis/pull/3316#discussion_r513491335] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Commented] (ARTEMIS-2965) Allow mirror to stop capture events and delete inner queue
[ https://issues.apache.org/jira/browse/ARTEMIS-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854581#comment-17854581 ] Stephen Baker commented on ARTEMIS-2965: Just a vote from me; we just hit an issue where the mirror was growing faster than it was draining for an extended period of time and we caused a service disruption, disabling the mirror in broker.xml and restarting. An official and live way to do this would have helped. > Allow mirror to stop capture events and delete inner queue > -- > > Key: ARTEMIS-2965 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2965 > Project: ActiveMQ Artemis > Issue Type: Improvement >Affects Versions: 2.16.0 >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Critical > > When a mirror starts, the current events will not be cleared when > brokerConnection.stop() is called. > > We should support removing the Mirror manager, and deleting the queue upon > brokerConnection.stop(). > (or another method TBD that would determine the semantic to remove the SnF > queue and future generation on mirror). > Related comments: > [https://github.com/apache/activemq-artemis/pull/3316#discussion_r513491335] -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Commented] (ARTEMIS-4667) JMX Recovery operation triggers ClassCastException
[
https://issues.apache.org/jira/browse/ARTEMIS-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854561#comment-17854561
]
ASF subversion and git services commented on ARTEMIS-4667:
--
Commit 7f038de9ad0d999044749c6ab398ef2f2d8dee5f in activemq-artemis's branch
refs/heads/main from Clebert Suconic
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=7f038de9ad ]
ARTEMIS-4667 Fixing replay manager with replication on the large message case
> JMX Recovery operation triggers ClassCastException
> --
>
> Key: ARTEMIS-4667
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4667
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.30.0
>Reporter: Jean-Pascal Briquet
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.36.0
>
> Attachments: ReplayWithReplicationTest.java,
> msg-replay-classcastexception.png
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> *Description:*
> Impossibility to replay messages from retention folders due to a
> ClassCastException.
> It happens when replication ha-policy is configured and after the live role
> switch back from the backup node to the primary node:
>
> {code:java}
> java.lang.ClassCastException : class
> org.apache.activemq.artemis.core.replication.ReplicatedJournal cannot be cast
> to class org.apache.activemq.artemis.core.journal.impl.JournalImpl
> (org.apache.activemq.artemis.core.replication.ReplicatedJournal and
> org.apache.activemq.artemis.core.journal.impl.JournalImpl are in unnamed
> module of loader java.net.URLClassLoader @73d16e93){code}
>
> See attached screenshot of the Artemis console for additional details.
>
> *Configuration details:*
> * Cluster of Artemis primary/backup groups and with replication ha-policy
> (ZK)
>
> *Reproduction scenario:*
> With a brand new primary/backup group with replica :
> * Start primary and backup nodes
> * The JMX replay command works well on primary
> * Stop the primary node, backup becomes live
> * Restart the primary, it becomes live again (failback is enabled)
> * At this step, the reuse of the replay command on the primary trigger the
> ClassCastException
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Closed] (ARTEMIS-4667) JMX Recovery operation triggers ClassCastException
[
https://issues.apache.org/jira/browse/ARTEMIS-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Clebert Suconic closed ARTEMIS-4667.
Resolution: Fixed
> JMX Recovery operation triggers ClassCastException
> --
>
> Key: ARTEMIS-4667
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4667
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.30.0
>Reporter: Jean-Pascal Briquet
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.36.0
>
> Attachments: ReplayWithReplicationTest.java,
> msg-replay-classcastexception.png
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> *Description:*
> Impossibility to replay messages from retention folders due to a
> ClassCastException.
> It happens when replication ha-policy is configured and after the live role
> switch back from the backup node to the primary node:
>
> {code:java}
> java.lang.ClassCastException : class
> org.apache.activemq.artemis.core.replication.ReplicatedJournal cannot be cast
> to class org.apache.activemq.artemis.core.journal.impl.JournalImpl
> (org.apache.activemq.artemis.core.replication.ReplicatedJournal and
> org.apache.activemq.artemis.core.journal.impl.JournalImpl are in unnamed
> module of loader java.net.URLClassLoader @73d16e93){code}
>
> See attached screenshot of the Artemis console for additional details.
>
> *Configuration details:*
> * Cluster of Artemis primary/backup groups and with replication ha-policy
> (ZK)
>
> *Reproduction scenario:*
> With a brand new primary/backup group with replica :
> * Start primary and backup nodes
> * The JMX replay command works well on primary
> * Stop the primary node, backup becomes live
> * Restart the primary, it becomes live again (failback is enabled)
> * At this step, the reuse of the replay command on the primary trigger the
> ClassCastException
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Commented] (ARTEMIS-4667) JMX Recovery operation triggers ClassCastException
[
https://issues.apache.org/jira/browse/ARTEMIS-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854560#comment-17854560
]
Clebert Suconic commented on ARTEMIS-4667:
--
Thanks for providing a complete test on this. I know you extended the Replay
test but that was spot on...
that test you wrote captured the case for large messages.. I missed it, closed
the JIRA to realize the test failing on my complete testsuite.
the next PR is fixing that, so I'm closing the JIRA back as fixed... thanks
again.
> JMX Recovery operation triggers ClassCastException
> --
>
> Key: ARTEMIS-4667
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4667
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.30.0
>Reporter: Jean-Pascal Briquet
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.36.0
>
> Attachments: ReplayWithReplicationTest.java,
> msg-replay-classcastexception.png
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> *Description:*
> Impossibility to replay messages from retention folders due to a
> ClassCastException.
> It happens when replication ha-policy is configured and after the live role
> switch back from the backup node to the primary node:
>
> {code:java}
> java.lang.ClassCastException : class
> org.apache.activemq.artemis.core.replication.ReplicatedJournal cannot be cast
> to class org.apache.activemq.artemis.core.journal.impl.JournalImpl
> (org.apache.activemq.artemis.core.replication.ReplicatedJournal and
> org.apache.activemq.artemis.core.journal.impl.JournalImpl are in unnamed
> module of loader java.net.URLClassLoader @73d16e93){code}
>
> See attached screenshot of the Artemis console for additional details.
>
> *Configuration details:*
> * Cluster of Artemis primary/backup groups and with replication ha-policy
> (ZK)
>
> *Reproduction scenario:*
> With a brand new primary/backup group with replica :
> * Start primary and backup nodes
> * The JMX replay command works well on primary
> * Stop the primary node, backup becomes live
> * Restart the primary, it becomes live again (failback is enabled)
> * At this step, the reuse of the replay command on the primary trigger the
> ClassCastException
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4667) JMX Recovery operation triggers ClassCastException
[
https://issues.apache.org/jira/browse/ARTEMIS-4667?focusedWorklogId=923184=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923184
]
ASF GitHub Bot logged work on ARTEMIS-4667:
---
Author: ASF GitHub Bot
Created on: 12/Jun/24 22:42
Start Date: 12/Jun/24 22:42
Worklog Time Spent: 10m
Work Description: clebertsuconic opened a new pull request, #4974:
URL: https://github.com/apache/activemq-artemis/pull/4974
(no comment)
Issue Time Tracking
---
Worklog Id: (was: 923184)
Time Spent: 0.5h (was: 20m)
> JMX Recovery operation triggers ClassCastException
> --
>
> Key: ARTEMIS-4667
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4667
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.30.0
>Reporter: Jean-Pascal Briquet
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.36.0
>
> Attachments: ReplayWithReplicationTest.java,
> msg-replay-classcastexception.png
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> *Description:*
> Impossibility to replay messages from retention folders due to a
> ClassCastException.
> It happens when replication ha-policy is configured and after the live role
> switch back from the backup node to the primary node:
>
> {code:java}
> java.lang.ClassCastException : class
> org.apache.activemq.artemis.core.replication.ReplicatedJournal cannot be cast
> to class org.apache.activemq.artemis.core.journal.impl.JournalImpl
> (org.apache.activemq.artemis.core.replication.ReplicatedJournal and
> org.apache.activemq.artemis.core.journal.impl.JournalImpl are in unnamed
> module of loader java.net.URLClassLoader @73d16e93){code}
>
> See attached screenshot of the Artemis console for additional details.
>
> *Configuration details:*
> * Cluster of Artemis primary/backup groups and with replication ha-policy
> (ZK)
>
> *Reproduction scenario:*
> With a brand new primary/backup group with replica :
> * Start primary and backup nodes
> * The JMX replay command works well on primary
> * Stop the primary node, backup becomes live
> * Restart the primary, it becomes live again (failback is enabled)
> * At this step, the reuse of the replay command on the primary trigger the
> ClassCastException
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Commented] (ARTEMIS-4667) JMX Recovery operation triggers ClassCastException
[
https://issues.apache.org/jira/browse/ARTEMIS-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854556#comment-17854556
]
Clebert Suconic commented on ARTEMIS-4667:
--
Reopening it as Large message is not working with replication
> JMX Recovery operation triggers ClassCastException
> --
>
> Key: ARTEMIS-4667
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4667
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.30.0
>Reporter: Jean-Pascal Briquet
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.36.0
>
> Attachments: ReplayWithReplicationTest.java,
> msg-replay-classcastexception.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> *Description:*
> Impossibility to replay messages from retention folders due to a
> ClassCastException.
> It happens when replication ha-policy is configured and after the live role
> switch back from the backup node to the primary node:
>
> {code:java}
> java.lang.ClassCastException : class
> org.apache.activemq.artemis.core.replication.ReplicatedJournal cannot be cast
> to class org.apache.activemq.artemis.core.journal.impl.JournalImpl
> (org.apache.activemq.artemis.core.replication.ReplicatedJournal and
> org.apache.activemq.artemis.core.journal.impl.JournalImpl are in unnamed
> module of loader java.net.URLClassLoader @73d16e93){code}
>
> See attached screenshot of the Artemis console for additional details.
>
> *Configuration details:*
> * Cluster of Artemis primary/backup groups and with replication ha-policy
> (ZK)
>
> *Reproduction scenario:*
> With a brand new primary/backup group with replica :
> * Start primary and backup nodes
> * The JMX replay command works well on primary
> * Stop the primary node, backup becomes live
> * Restart the primary, it becomes live again (failback is enabled)
> * At this step, the reuse of the replay command on the primary trigger the
> ClassCastException
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Reopened] (ARTEMIS-4667) JMX Recovery operation triggers ClassCastException
[
https://issues.apache.org/jira/browse/ARTEMIS-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Clebert Suconic reopened ARTEMIS-4667:
--
> JMX Recovery operation triggers ClassCastException
> --
>
> Key: ARTEMIS-4667
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4667
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.30.0
>Reporter: Jean-Pascal Briquet
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.36.0
>
> Attachments: ReplayWithReplicationTest.java,
> msg-replay-classcastexception.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> *Description:*
> Impossibility to replay messages from retention folders due to a
> ClassCastException.
> It happens when replication ha-policy is configured and after the live role
> switch back from the backup node to the primary node:
>
> {code:java}
> java.lang.ClassCastException : class
> org.apache.activemq.artemis.core.replication.ReplicatedJournal cannot be cast
> to class org.apache.activemq.artemis.core.journal.impl.JournalImpl
> (org.apache.activemq.artemis.core.replication.ReplicatedJournal and
> org.apache.activemq.artemis.core.journal.impl.JournalImpl are in unnamed
> module of loader java.net.URLClassLoader @73d16e93){code}
>
> See attached screenshot of the Artemis console for additional details.
>
> *Configuration details:*
> * Cluster of Artemis primary/backup groups and with replication ha-policy
> (ZK)
>
> *Reproduction scenario:*
> With a brand new primary/backup group with replica :
> * Start primary and backup nodes
> * The JMX replay command works well on primary
> * Stop the primary node, backup becomes live
> * Restart the primary, it becomes live again (failback is enabled)
> * At this step, the reuse of the replay command on the primary trigger the
> ClassCastException
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Closed] (ARTEMIS-4667) JMX Recovery operation triggers ClassCastException
[
https://issues.apache.org/jira/browse/ARTEMIS-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Clebert Suconic closed ARTEMIS-4667.
Resolution: Fixed
> JMX Recovery operation triggers ClassCastException
> --
>
> Key: ARTEMIS-4667
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4667
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.30.0
>Reporter: Jean-Pascal Briquet
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.36.0
>
> Attachments: ReplayWithReplicationTest.java,
> msg-replay-classcastexception.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> *Description:*
> Impossibility to replay messages from retention folders due to a
> ClassCastException.
> It happens when replication ha-policy is configured and after the live role
> switch back from the backup node to the primary node:
>
> {code:java}
> java.lang.ClassCastException : class
> org.apache.activemq.artemis.core.replication.ReplicatedJournal cannot be cast
> to class org.apache.activemq.artemis.core.journal.impl.JournalImpl
> (org.apache.activemq.artemis.core.replication.ReplicatedJournal and
> org.apache.activemq.artemis.core.journal.impl.JournalImpl are in unnamed
> module of loader java.net.URLClassLoader @73d16e93){code}
>
> See attached screenshot of the Artemis console for additional details.
>
> *Configuration details:*
> * Cluster of Artemis primary/backup groups and with replication ha-policy
> (ZK)
>
> *Reproduction scenario:*
> With a brand new primary/backup group with replica :
> * Start primary and backup nodes
> * The JMX replay command works well on primary
> * Stop the primary node, backup becomes live
> * Restart the primary, it becomes live again (failback is enabled)
> * At this step, the reuse of the replay command on the primary trigger the
> ClassCastException
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Commented] (ARTEMIS-4667) JMX Recovery operation triggers ClassCastException
[
https://issues.apache.org/jira/browse/ARTEMIS-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854552#comment-17854552
]
ASF subversion and git services commented on ARTEMIS-4667:
--
Commit dd6c74fc1c862aeb69def42ed8a8bfecc3447f50 in activemq-artemis's branch
refs/heads/main from Clebert Suconic
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=dd6c74fc1c ]
ARTEMIS-4667 ReplayManager does not work with replication
co-authored: Jean-Pascal Briquet provided the testcase
> JMX Recovery operation triggers ClassCastException
> --
>
> Key: ARTEMIS-4667
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4667
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.30.0
>Reporter: Jean-Pascal Briquet
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.36.0
>
> Attachments: ReplayWithReplicationTest.java,
> msg-replay-classcastexception.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> *Description:*
> Impossibility to replay messages from retention folders due to a
> ClassCastException.
> It happens when replication ha-policy is configured and after the live role
> switch back from the backup node to the primary node:
>
> {code:java}
> java.lang.ClassCastException : class
> org.apache.activemq.artemis.core.replication.ReplicatedJournal cannot be cast
> to class org.apache.activemq.artemis.core.journal.impl.JournalImpl
> (org.apache.activemq.artemis.core.replication.ReplicatedJournal and
> org.apache.activemq.artemis.core.journal.impl.JournalImpl are in unnamed
> module of loader java.net.URLClassLoader @73d16e93){code}
>
> See attached screenshot of the Artemis console for additional details.
>
> *Configuration details:*
> * Cluster of Artemis primary/backup groups and with replication ha-policy
> (ZK)
>
> *Reproduction scenario:*
> With a brand new primary/backup group with replica :
> * Start primary and backup nodes
> * The JMX replay command works well on primary
> * Stop the primary node, backup becomes live
> * Restart the primary, it becomes live again (failback is enabled)
> * At this step, the reuse of the replay command on the primary trigger the
> ClassCastException
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4667) JMX Recovery operation triggers ClassCastException
[
https://issues.apache.org/jira/browse/ARTEMIS-4667?focusedWorklogId=923182=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923182
]
ASF GitHub Bot logged work on ARTEMIS-4667:
---
Author: ASF GitHub Bot
Created on: 12/Jun/24 21:57
Start Date: 12/Jun/24 21:57
Worklog Time Spent: 10m
Work Description: clebertsuconic merged PR #4973:
URL: https://github.com/apache/activemq-artemis/pull/4973
Issue Time Tracking
---
Worklog Id: (was: 923182)
Time Spent: 20m (was: 10m)
> JMX Recovery operation triggers ClassCastException
> --
>
> Key: ARTEMIS-4667
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4667
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.30.0
>Reporter: Jean-Pascal Briquet
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.36.0
>
> Attachments: ReplayWithReplicationTest.java,
> msg-replay-classcastexception.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> *Description:*
> Impossibility to replay messages from retention folders due to a
> ClassCastException.
> It happens when replication ha-policy is configured and after the live role
> switch back from the backup node to the primary node:
>
> {code:java}
> java.lang.ClassCastException : class
> org.apache.activemq.artemis.core.replication.ReplicatedJournal cannot be cast
> to class org.apache.activemq.artemis.core.journal.impl.JournalImpl
> (org.apache.activemq.artemis.core.replication.ReplicatedJournal and
> org.apache.activemq.artemis.core.journal.impl.JournalImpl are in unnamed
> module of loader java.net.URLClassLoader @73d16e93){code}
>
> See attached screenshot of the Artemis console for additional details.
>
> *Configuration details:*
> * Cluster of Artemis primary/backup groups and with replication ha-policy
> (ZK)
>
> *Reproduction scenario:*
> With a brand new primary/backup group with replica :
> * Start primary and backup nodes
> * The JMX replay command works well on primary
> * Stop the primary node, backup becomes live
> * Restart the primary, it becomes live again (failback is enabled)
> * At this step, the reuse of the replay command on the primary trigger the
> ClassCastException
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4667) JMX Recovery operation triggers ClassCastException
[
https://issues.apache.org/jira/browse/ARTEMIS-4667?focusedWorklogId=923180=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923180
]
ASF GitHub Bot logged work on ARTEMIS-4667:
---
Author: ASF GitHub Bot
Created on: 12/Jun/24 21:22
Start Date: 12/Jun/24 21:22
Worklog Time Spent: 10m
Work Description: clebertsuconic opened a new pull request, #4973:
URL: https://github.com/apache/activemq-artemis/pull/4973
co-authored: Jean-Pascal Briquet provided the testcase
Issue Time Tracking
---
Worklog Id: (was: 923180)
Remaining Estimate: 0h
Time Spent: 10m
> JMX Recovery operation triggers ClassCastException
> --
>
> Key: ARTEMIS-4667
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4667
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.30.0
>Reporter: Jean-Pascal Briquet
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.36.0
>
> Attachments: ReplayWithReplicationTest.java,
> msg-replay-classcastexception.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> *Description:*
> Impossibility to replay messages from retention folders due to a
> ClassCastException.
> It happens when replication ha-policy is configured and after the live role
> switch back from the backup node to the primary node:
>
> {code:java}
> java.lang.ClassCastException : class
> org.apache.activemq.artemis.core.replication.ReplicatedJournal cannot be cast
> to class org.apache.activemq.artemis.core.journal.impl.JournalImpl
> (org.apache.activemq.artemis.core.replication.ReplicatedJournal and
> org.apache.activemq.artemis.core.journal.impl.JournalImpl are in unnamed
> module of loader java.net.URLClassLoader @73d16e93){code}
>
> See attached screenshot of the Artemis console for additional details.
>
> *Configuration details:*
> * Cluster of Artemis primary/backup groups and with replication ha-policy
> (ZK)
>
> *Reproduction scenario:*
> With a brand new primary/backup group with replica :
> * Start primary and backup nodes
> * The JMX replay command works well on primary
> * Stop the primary node, backup becomes live
> * Restart the primary, it becomes live again (failback is enabled)
> * At this step, the reuse of the replay command on the primary trigger the
> ClassCastException
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work started] (ARTEMIS-4667) JMX Recovery operation triggers ClassCastException
[
https://issues.apache.org/jira/browse/ARTEMIS-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on ARTEMIS-4667 started by Clebert Suconic.
> JMX Recovery operation triggers ClassCastException
> --
>
> Key: ARTEMIS-4667
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4667
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.30.0
>Reporter: Jean-Pascal Briquet
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.36.0
>
> Attachments: ReplayWithReplicationTest.java,
> msg-replay-classcastexception.png
>
>
> *Description:*
> Impossibility to replay messages from retention folders due to a
> ClassCastException.
> It happens when replication ha-policy is configured and after the live role
> switch back from the backup node to the primary node:
>
> {code:java}
> java.lang.ClassCastException : class
> org.apache.activemq.artemis.core.replication.ReplicatedJournal cannot be cast
> to class org.apache.activemq.artemis.core.journal.impl.JournalImpl
> (org.apache.activemq.artemis.core.replication.ReplicatedJournal and
> org.apache.activemq.artemis.core.journal.impl.JournalImpl are in unnamed
> module of loader java.net.URLClassLoader @73d16e93){code}
>
> See attached screenshot of the Artemis console for additional details.
>
> *Configuration details:*
> * Cluster of Artemis primary/backup groups and with replication ha-policy
> (ZK)
>
> *Reproduction scenario:*
> With a brand new primary/backup group with replica :
> * Start primary and backup nodes
> * The JMX replay command works well on primary
> * Stop the primary node, backup becomes live
> * Restart the primary, it becomes live again (failback is enabled)
> * At this step, the reuse of the replay command on the primary trigger the
> ClassCastException
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Updated] (ARTEMIS-4667) JMX Recovery operation triggers ClassCastException
[
https://issues.apache.org/jira/browse/ARTEMIS-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Clebert Suconic updated ARTEMIS-4667:
-
Fix Version/s: 2.36.0
> JMX Recovery operation triggers ClassCastException
> --
>
> Key: ARTEMIS-4667
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4667
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.30.0
>Reporter: Jean-Pascal Briquet
>Assignee: Clebert Suconic
>Priority: Major
> Fix For: 2.36.0
>
> Attachments: ReplayWithReplicationTest.java,
> msg-replay-classcastexception.png
>
>
> *Description:*
> Impossibility to replay messages from retention folders due to a
> ClassCastException.
> It happens when replication ha-policy is configured and after the live role
> switch back from the backup node to the primary node:
>
> {code:java}
> java.lang.ClassCastException : class
> org.apache.activemq.artemis.core.replication.ReplicatedJournal cannot be cast
> to class org.apache.activemq.artemis.core.journal.impl.JournalImpl
> (org.apache.activemq.artemis.core.replication.ReplicatedJournal and
> org.apache.activemq.artemis.core.journal.impl.JournalImpl are in unnamed
> module of loader java.net.URLClassLoader @73d16e93){code}
>
> See attached screenshot of the Artemis console for additional details.
>
> *Configuration details:*
> * Cluster of Artemis primary/backup groups and with replication ha-policy
> (ZK)
>
> *Reproduction scenario:*
> With a brand new primary/backup group with replica :
> * Start primary and backup nodes
> * The JMX replay command works well on primary
> * Stop the primary node, backup becomes live
> * Restart the primary, it becomes live again (failback is enabled)
> * At this step, the reuse of the replay command on the primary trigger the
> ClassCastException
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Assigned] (ARTEMIS-4667) JMX Recovery operation triggers ClassCastException
[
https://issues.apache.org/jira/browse/ARTEMIS-4667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Clebert Suconic reassigned ARTEMIS-4667:
Assignee: Clebert Suconic
> JMX Recovery operation triggers ClassCastException
> --
>
> Key: ARTEMIS-4667
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4667
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.30.0
>Reporter: Jean-Pascal Briquet
>Assignee: Clebert Suconic
>Priority: Major
> Attachments: ReplayWithReplicationTest.java,
> msg-replay-classcastexception.png
>
>
> *Description:*
> Impossibility to replay messages from retention folders due to a
> ClassCastException.
> It happens when replication ha-policy is configured and after the live role
> switch back from the backup node to the primary node:
>
> {code:java}
> java.lang.ClassCastException : class
> org.apache.activemq.artemis.core.replication.ReplicatedJournal cannot be cast
> to class org.apache.activemq.artemis.core.journal.impl.JournalImpl
> (org.apache.activemq.artemis.core.replication.ReplicatedJournal and
> org.apache.activemq.artemis.core.journal.impl.JournalImpl are in unnamed
> module of loader java.net.URLClassLoader @73d16e93){code}
>
> See attached screenshot of the Artemis console for additional details.
>
> *Configuration details:*
> * Cluster of Artemis primary/backup groups and with replication ha-policy
> (ZK)
>
> *Reproduction scenario:*
> With a brand new primary/backup group with replica :
> * Start primary and backup nodes
> * The JMX replay command works well on primary
> * Stop the primary node, backup becomes live
> * Restart the primary, it becomes live again (failback is enabled)
> * At this step, the reuse of the replay command on the primary trigger the
> ClassCastException
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Closed] (ARTEMIS-4802) Update deprecated tags in examples/features/ha/replicated-failback sample
[
https://issues.apache.org/jira/browse/ARTEMIS-4802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Clebert Suconic closed ARTEMIS-4802.
> Update deprecated tags in examples/features/ha/replicated-failback sample
> -
>
> Key: ARTEMIS-4802
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4802
> Project: ActiveMQ Artemis
> Issue Type: Task
> Components: ActiveMQ-Artemis-Examples
>Affects Versions: 2.34.0
>Reporter: Susinda Perera
>Assignee: Robbie Gemmell
>Priority: Minor
> Fix For: 2.35.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When starting active mq ha samples it gives below log messages.
>
> {code:java}
> INFO [org.apache.activemq.artemis.core.server] AMQ221038: Configuration
> option 'master' is deprecated and will be removed in a future version. Use
> 'primary' instead. Consult the manual for details.
> INFO [org.apache.activemq.artemis.core.server] AMQ221038: Configuration
> option 'check-for-live-server' is deprecated and will be removed in a future
> version. Use 'check-for-active-server' instead. Consult the manual for
> details.
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4814) Remove linear iteration to get direct bindings
[
https://issues.apache.org/jira/browse/ARTEMIS-4814?focusedWorklogId=923169=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923169
]
ASF GitHub Bot logged work on ARTEMIS-4814:
---
Author: ASF GitHub Bot
Created on: 12/Jun/24 18:56
Start Date: 12/Jun/24 18:56
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on PR #4972:
URL:
https://github.com/apache/activemq-artemis/pull/4972#issuecomment-2163705211
at least the -Ptests testsuite (complete one) ran fine.
Issue Time Tracking
---
Worklog Id: (was: 923169)
Time Spent: 1h 20m (was: 1h 10m)
> Remove linear iteration to get direct bindings
> --
>
> Key: ARTEMIS-4814
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4814
> Project: ActiveMQ Artemis
> Issue Type: Task
> Components: Broker
>Reporter: Josh Byster
>Priority: Minor
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Currently, with 500K+ queues, the cleanup step of {{TempQueueCleanerUpper}}
> requires invoking {{WildcardAddressManager#getDirectBindings}}, which is O(k)
> in the number of queues.
> From method profiling, this can consume up to 95% of our CPU time when
> needing to clean up many of these.
> It would be nice to make this more efficient, which shouldn't be difficult
> given the iteration just does a simple equality check.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4814) Remove linear iteration to get direct bindings
[
https://issues.apache.org/jira/browse/ARTEMIS-4814?focusedWorklogId=923164=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923164
]
ASF GitHub Bot logged work on ARTEMIS-4814:
---
Author: ASF GitHub Bot
Created on: 12/Jun/24 17:58
Start Date: 12/Jun/24 17:58
Worklog Time Spent: 10m
Work Description: joshb1050 commented on code in PR #4972:
URL: https://github.com/apache/activemq-artemis/pull/4972#discussion_r1636884171
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/SimpleAddressManager.java:
##
@@ -160,15 +172,7 @@ public Collection getMatchingBindings(final
SimpleString address) throw
@Override
public Collection getDirectBindings(final SimpleString address)
throws Exception {
SimpleString realAddress = CompositeAddress.extractAddressName(address);
- Collection bindings = new ArrayList<>();
-
- nameMap.forEach((bindingUniqueName, bindingAddressPair) -> {
- if (bindingAddressPair.getA().getAddress().equals(realAddress)) {
-bindings.add(bindingAddressPair.getA());
- }
- });
-
- return bindings;
+ return new ArrayList<>(directBindingMap.getOrDefault(realAddress,
Collections.emptyList()));
Review Comment:
It's a copy operation, and works efficiently internally (at least in JDK
17). We could do a null check instead and return a new list if null, but this
has to be a defensive copy since the tests will otherwise fail.
```
public ArrayList(Collection c) {
Object[] a = c.toArray();
if ((size = a.length) != 0) {
if (c.getClass() == ArrayList.class) {
elementData = a;
} else {
elementData = Arrays.copyOf(a, size, Object[].class);
}
} else {
// replace with empty array.
elementData = EMPTY_ELEMENTDATA;
}
}
```
Issue Time Tracking
---
Worklog Id: (was: 923164)
Time Spent: 1h 10m (was: 1h)
> Remove linear iteration to get direct bindings
> --
>
> Key: ARTEMIS-4814
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4814
> Project: ActiveMQ Artemis
> Issue Type: Task
> Components: Broker
>Reporter: Josh Byster
>Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Currently, with 500K+ queues, the cleanup step of {{TempQueueCleanerUpper}}
> requires invoking {{WildcardAddressManager#getDirectBindings}}, which is O(k)
> in the number of queues.
> From method profiling, this can consume up to 95% of our CPU time when
> needing to clean up many of these.
> It would be nice to make this more efficient, which shouldn't be difficult
> given the iteration just does a simple equality check.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4814) Remove linear iteration to get direct bindings
[
https://issues.apache.org/jira/browse/ARTEMIS-4814?focusedWorklogId=923157=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923157
]
ASF GitHub Bot logged work on ARTEMIS-4814:
---
Author: ASF GitHub Bot
Created on: 12/Jun/24 17:01
Start Date: 12/Jun/24 17:01
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #4972:
URL: https://github.com/apache/activemq-artemis/pull/4972#discussion_r1636813616
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/SimpleAddressManager.java:
##
@@ -160,15 +172,7 @@ public Collection getMatchingBindings(final
SimpleString address) throw
@Override
public Collection getDirectBindings(final SimpleString address)
throws Exception {
SimpleString realAddress = CompositeAddress.extractAddressName(address);
- Collection bindings = new ArrayList<>();
-
- nameMap.forEach((bindingUniqueName, bindingAddressPair) -> {
- if (bindingAddressPair.getA().getAddress().equals(realAddress)) {
-bindings.add(bindingAddressPair.getA());
- }
- });
-
- return bindings;
+ return new ArrayList<>(directBindingMap.getOrDefault(realAddress,
Collections.emptyList()));
Review Comment:
It seems rather odd to return a new ArrayList that's wrapping a potentially
immutable empty list. This should probably be made a bit smarter.
Issue Time Tracking
---
Worklog Id: (was: 923157)
Time Spent: 1h (was: 50m)
> Remove linear iteration to get direct bindings
> --
>
> Key: ARTEMIS-4814
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4814
> Project: ActiveMQ Artemis
> Issue Type: Task
> Components: Broker
>Reporter: Josh Byster
>Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Currently, with 500K+ queues, the cleanup step of {{TempQueueCleanerUpper}}
> requires invoking {{WildcardAddressManager#getDirectBindings}}, which is O(k)
> in the number of queues.
> From method profiling, this can consume up to 95% of our CPU time when
> needing to clean up many of these.
> It would be nice to make this more efficient, which shouldn't be difficult
> given the iteration just does a simple equality check.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4814) Remove linear iteration to get direct bindings
[
https://issues.apache.org/jira/browse/ARTEMIS-4814?focusedWorklogId=923156=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923156
]
ASF GitHub Bot logged work on ARTEMIS-4814:
---
Author: ASF GitHub Bot
Created on: 12/Jun/24 16:58
Start Date: 12/Jun/24 16:58
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on PR #4972:
URL:
https://github.com/apache/activemq-artemis/pull/4972#issuecomment-2163510246
@joshb1050 there's a complete test suite that you can run with -Ptests.
The CI in Jenkins runs a limited version of the test suite for basic
validation.
For more through verification I run the entire test suite but I wouldn't
have reousrces for such a long process in the public CI from GitHub.
Issue Time Tracking
---
Worklog Id: (was: 923156)
Time Spent: 50m (was: 40m)
> Remove linear iteration to get direct bindings
> --
>
> Key: ARTEMIS-4814
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4814
> Project: ActiveMQ Artemis
> Issue Type: Task
> Components: Broker
>Reporter: Josh Byster
>Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently, with 500K+ queues, the cleanup step of {{TempQueueCleanerUpper}}
> requires invoking {{WildcardAddressManager#getDirectBindings}}, which is O(k)
> in the number of queues.
> From method profiling, this can consume up to 95% of our CPU time when
> needing to clean up many of these.
> It would be nice to make this more efficient, which shouldn't be difficult
> given the iteration just does a simple equality check.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Closed] (ARTEMIS-4792) Add support for setting consumer priority on AMQP Receiver Source addresses
[
https://issues.apache.org/jira/browse/ARTEMIS-4792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Clebert Suconic closed ARTEMIS-4792.
> Add support for setting consumer priority on AMQP Receiver Source addresses
> ---
>
> Key: ARTEMIS-4792
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4792
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: AMQP
>Affects Versions: 2.34.0
>Reporter: Timothy A. Bish
>Assignee: Timothy A. Bish
>Priority: Minor
> Fix For: 2.35.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When creating a receiver link from a client the only way currently to adjust
> the consumer priority on the broker is to set a value in the receiver
> properties to indicate the desired priority. For some client AMQP client
> libraries this is not simple or not possible in the provided API. To solve
> this we can add support for parsing URI type options from the source address
> of the receiver attach and look for the option "consumer-priority" which is
> also used by the Core client to configure consumer priority (Openwire clients
> can do the same via an openwire client property "consumer.priority").
> This updates the client receiver attach to extract properties from the
> address the source which have the form:
> {code:java}
> address?consumer-priority=1{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Closed] (ARTEMIS-4789) Page.destroy race with cleanup
[ https://issues.apache.org/jira/browse/ARTEMIS-4789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic closed ARTEMIS-4789. > Page.destroy race with cleanup > -- > > Key: ARTEMIS-4789 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4789 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.34.0 >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.35.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > There's a rare race between Queue.destroy and cleanup. > if the cleanup is called while depaging is still happening you might endup > with a Critical IO exception as the storage folder is removed. > This is the reason why testPagingStoreDestroyed(derby) was eventually failing. > testPagingStoreDestroyed serves as the verification for this issue, as this > is intended as the test fix. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Closed] (ARTEMIS-4788) AMQP Federation Broker connection can deadlock broker shutdown
[ https://issues.apache.org/jira/browse/ARTEMIS-4788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic closed ARTEMIS-4788. > AMQP Federation Broker connection can deadlock broker shutdown > -- > > Key: ARTEMIS-4788 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4788 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.33.0, 2.34.0 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Major > Fix For: 2.35.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > In a rare race between broker shutdown and create of federation consumer the > broker connection federation manager can deadlock and hang the shutdown of > the broker. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Closed] (ARTEMIS-4801) AMQP Session address query cache can have invalid state for long lived sessions
[ https://issues.apache.org/jira/browse/ARTEMIS-4801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic closed ARTEMIS-4801. > AMQP Session address query cache can have invalid state for long lived > sessions > --- > > Key: ARTEMIS-4801 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4801 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.34.0 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Major > Fix For: 2.35.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The AMQPSessionCallback retains a map of AddressQueryResult instances for > previous address checks. This map is not updated if the state of broker > addresses changes, neither addresses added, removed or updated states are > reflected in the cache. This leads to issues for long running sessions where > a link attach may fail for a non-existent address and on a later attempt > should succeed if the address was added but can't because the cache will > still hold the non-exists query result. Other scenarios are possible such as > an address removed and re-added with different routing type but the former > case is more serious. > The cache should be removed and if a similar optimization is actually found > to be needed a better mechanism should be chosen to avoid the issues found. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Closed] (ARTEMIS-4760) Creating MQTT consumer should work if auto-create-queues is false
[ https://issues.apache.org/jira/browse/ARTEMIS-4760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic closed ARTEMIS-4760. > Creating MQTT consumer should work if auto-create-queues is false > - > > Key: ARTEMIS-4760 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4760 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Fix For: 2.35.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Closed] (ARTEMIS-4799) Broker Connection Receiver attach handled incorrectly
[ https://issues.apache.org/jira/browse/ARTEMIS-4799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic closed ARTEMIS-4799. > Broker Connection Receiver attach handled incorrectly > - > > Key: ARTEMIS-4799 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4799 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.34.0 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Minor > Fix For: 2.35.0 > > Time Spent: 20m > Remaining Estimate: 0h > > The AMQP Broker Connection Receiver configuration creates a receiver for > messages from a remote AMQP source however the attach handling is not > properly handled leading to a receiver that thinks it is operating as an > opened anonymous relay sender meaning it only routes messages with a set 'To' > field in the properties. The receiver attach should be using the locally > defined target as the address for incoming messages and ignore an 'To' value > in the message properties. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Closed] (ARTEMIS-4795) Enforce queue filter when sending to FQQN
[ https://issues.apache.org/jira/browse/ARTEMIS-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic closed ARTEMIS-4795. Fix Version/s: 2.35.0 Resolution: Fixed > Enforce queue filter when sending to FQQN > - > > Key: ARTEMIS-4795 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4795 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Fix For: 2.35.0 > > Time Spent: 20m > Remaining Estimate: 0h > > When sending a message directly to an FQQN the queue's filter is not enforced > on the message which is sent. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Commented] (ARTEMIS-4815) Add --json option to ./artemis queue stat
[ https://issues.apache.org/jira/browse/ARTEMIS-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854470#comment-17854470 ] ASF subversion and git services commented on ARTEMIS-4815: -- Commit 842a176a4e6869315955506dd683f3c1f7921a59 in activemq-artemis's branch refs/heads/main from Clebert Suconic [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=842a176a4e ] ARTEMIS-4815 json output into ./artemis queue stat > Add --json option to ./artemis queue stat > - > > Key: ARTEMIS-4815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4815 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.35.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Closed] (ARTEMIS-4815) Add --json option to ./artemis queue stat
[ https://issues.apache.org/jira/browse/ARTEMIS-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic closed ARTEMIS-4815. Resolution: Fixed > Add --json option to ./artemis queue stat > - > > Key: ARTEMIS-4815 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4815 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.35.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4814) Remove linear iteration to get direct bindings
[
https://issues.apache.org/jira/browse/ARTEMIS-4814?focusedWorklogId=923144=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923144
]
ASF GitHub Bot logged work on ARTEMIS-4814:
---
Author: ASF GitHub Bot
Created on: 12/Jun/24 14:17
Start Date: 12/Jun/24 14:17
Worklog Time Spent: 10m
Work Description: joshb1050 commented on PR #4972:
URL:
https://github.com/apache/activemq-artemis/pull/4972#issuecomment-2163134836
@clebertsuconic I believe I have fixed, though I wasn't able to see all of
those test failures when running locally (and it shows me as the CI passing as
well).
This is needed because each time one connection disconnects, say, with a few
thousand consumers, the `TempQueueCleanerUpper` needs to clean each of these
up, and it invokes `getDirectBindings` for each—so then this ends up being `O(k
* n)` where `k` is the number of queues on the server and `n` is the number of
consumers on the connection. It completely stops the server from functioning,
and seems to be a blocker for any setup that has a few hundred thousand plus
temp queues.
Issue Time Tracking
---
Worklog Id: (was: 923144)
Time Spent: 40m (was: 0.5h)
> Remove linear iteration to get direct bindings
> --
>
> Key: ARTEMIS-4814
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4814
> Project: ActiveMQ Artemis
> Issue Type: Task
> Components: Broker
>Reporter: Josh Byster
>Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently, with 500K+ queues, the cleanup step of {{TempQueueCleanerUpper}}
> requires invoking {{WildcardAddressManager#getDirectBindings}}, which is O(k)
> in the number of queues.
> From method profiling, this can consume up to 95% of our CPU time when
> needing to clean up many of these.
> It would be nice to make this more efficient, which shouldn't be difficult
> given the iteration just does a simple equality check.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Created] (ARTEMIS-4815) Add --json option to ./artemis queue stat
Clebert Suconic created ARTEMIS-4815: Summary: Add --json option to ./artemis queue stat Key: ARTEMIS-4815 URL: https://issues.apache.org/jira/browse/ARTEMIS-4815 Project: ActiveMQ Artemis Issue Type: Improvement Reporter: Clebert Suconic Assignee: Clebert Suconic Fix For: 2.35.0 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Closed] (ARTEMIS-4798) Address Size differs between Mirror and Source queue, leading to OME scenarios
[ https://issues.apache.org/jira/browse/ARTEMIS-4798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic closed ARTEMIS-4798. Resolution: Fixed > Address Size differs between Mirror and Source queue, leading to OME scenarios > -- > > Key: ARTEMIS-4798 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4798 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.34.0 >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.35.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Say you configure the broker to mirror. > You stop the mirror target (shutdown the server). > Now you send and consume from a destination, keeping the destination's size > close to zero. > You may get an OME on that situation. > This is because the calculation on the address-size only computes the main > body of the message at the original queue. While Mirror will only get a small > portion on the reference, in such cases you would end up with lazy starts in > paging... and things could go wrong. > To fix that, both Mirror and the source queue should get the body portion of > the size. > Basically while we route the message, we check if the address is not the > original and the Mirror SNF should also get the same portion of the size in > its calculation. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Closed] (ARTEMIS-4812) PageCursorInfo should be cleared on its Maps when page is marked as complete
[ https://issues.apache.org/jira/browse/ARTEMIS-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic closed ARTEMIS-4812. Resolution: Fixed > PageCursorInfo should be cleared on its Maps when page is marked as complete > > > Key: ARTEMIS-4812 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4812 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.34.0 >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.35.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Say you have a paged destination where there is a lazy consumer. The other > queues will keep consuming, and they will mark a page as complete. However > PageCursorInfo::acks and PageCursorInfo::removedReferences should be cleared > upon completion otherwise they will only be GCed when the page file is > removed and the entries for PageCursorInfo removed. > IntObjectHashMap also keeps an array of integers in memory and it won't > remove it when all elements are removed. to the reference to IntObjectHashMap > has to be set to null instead of removeAllReferences. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Closed] (ARTEMIS-4813) LargeMessages could lose a body while in sync if backup becomes activated
[ https://issues.apache.org/jira/browse/ARTEMIS-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic closed ARTEMIS-4813. Resolution: Fixed > LargeMessages could lose a body while in sync if backup becomes activated > - > > Key: ARTEMIS-4813 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4813 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.34.0 >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.35.0 > > Time Spent: 20m > Remaining Estimate: 0h > > This is a regression because of ARTEMIS-4784 > If a large message is received while synchronization still happening, and if > the backup becomes online right away you may lose partial of the large > message. > testBackupStartsWhenPrimaryIsREceivingLargeMessage is failing because of this. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Closed] (ARTEMIS-4811) Upgrade Netty to 4.1.111.Final
[ https://issues.apache.org/jira/browse/ARTEMIS-4811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic closed ARTEMIS-4811. Resolution: Fixed > Upgrade Netty to 4.1.111.Final > -- > > Key: ARTEMIS-4811 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4811 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Emmanuel Hugonnet >Priority: Major > Fix For: 2.35.0 > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Closed] (ARTEMIS-4796) Simplify SimpleString API
[
https://issues.apache.org/jira/browse/ARTEMIS-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Clebert Suconic closed ARTEMIS-4796.
Resolution: Fixed
> Simplify SimpleString API
> -
>
> Key: ARTEMIS-4796
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4796
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.35.0
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Instead of using the verbosely named {{toSimpleString}} static factory method
> (and its overloaded counterparts), {{SimpleString}} should provide {{of}}
> implementations. This change would make the code more concise and readable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Updated] (ARTEMIS-4165) Page transactions not getting deleted on queue deletion
[
https://issues.apache.org/jira/browse/ARTEMIS-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Clebert Suconic updated ARTEMIS-4165:
-
Fix Version/s: 2.35.0
> Page transactions not getting deleted on queue deletion
> ---
>
> Key: ARTEMIS-4165
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4165
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.28.0
>Reporter: Iliya Grushevskiy
>Priority: Major
> Fix For: 2.35.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> If the queue contains paged messages then during queue deletion those message
> records won't be updated. That will lead to journal grows as those records
> will never get removed from journal.
> {code:java}
> operation@AddRecordTX;txID=107743391288,recordID=107743391443;userRecordType=35;isUpdate=false;compactCount=18;PageTransactionInfoImpl(transactionID=107743391288,id=107743391443,numberOfMessages=1)
> operation@Commit;txID=107743391288,numberOfRecords=1
> operation@AddRecordTX;txID=107743391258,recordID=107743391446;userRecordType=35;isUpdate=false;compactCount=18;PageTransactionInfoImpl(transactionID=107743391258,id=107743391446,numberOfMessages=1){code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Closed] (ARTEMIS-4165) Page transactions not getting deleted on queue deletion
[
https://issues.apache.org/jira/browse/ARTEMIS-4165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Clebert Suconic closed ARTEMIS-4165.
Resolution: Fixed
> Page transactions not getting deleted on queue deletion
> ---
>
> Key: ARTEMIS-4165
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4165
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.28.0
>Reporter: Iliya Grushevskiy
>Priority: Major
> Fix For: 2.35.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> If the queue contains paged messages then during queue deletion those message
> records won't be updated. That will lead to journal grows as those records
> will never get removed from journal.
> {code:java}
> operation@AddRecordTX;txID=107743391288,recordID=107743391443;userRecordType=35;isUpdate=false;compactCount=18;PageTransactionInfoImpl(transactionID=107743391288,id=107743391443,numberOfMessages=1)
> operation@Commit;txID=107743391288,numberOfRecords=1
> operation@AddRecordTX;txID=107743391258,recordID=107743391446;userRecordType=35;isUpdate=false;compactCount=18;PageTransactionInfoImpl(transactionID=107743391258,id=107743391446,numberOfMessages=1){code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Closed] (ARTEMIS-4786) ConcurrentModificationException on Page.destroy
[ https://issues.apache.org/jira/browse/ARTEMIS-4786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic closed ARTEMIS-4786. Fix Version/s: 2.35.0 Resolution: Fixed > ConcurrentModificationException on Page.destroy > --- > > Key: ARTEMIS-4786 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4786 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.35.0 > > > I observed this while running > org.apache.activemq.artemis.tests.integration.client.ConcurrentCreateDeleteProduceTest.testConcurrentProduceCreateAndDelete > in loop: > java.lang.AssertionError: null is not a legitimate internal value. Concurrent > Modification? > at > io.netty.util.collection.IntObjectHashMap.toExternal(IntObjectHashMap.java:103) > ~[netty-common-4.1.109.Final.jar:4.1.109.Final] > at > io.netty.util.collection.IntObjectHashMap.access$900(IntObjectHashMap.java:37) > ~[netty-common-4.1.109.Final.jar:4.1.109.Final] > at > io.netty.util.collection.IntObjectHashMap$PrimitiveIterator.value(IntObjectHashMap.java:650) > ~[netty-common-4.1.109.Final.jar:4.1.109.Final] > at > io.netty.util.collection.IntObjectHashMap$2$1.next(IntObjectHashMap.java:234) > ~[netty-common-4.1.109.Final.jar:4.1.109.Final] > at > org.apache.activemq.artemis.core.paging.cursor.impl.PageSubscriptionImpl.destroy(PageSubscriptionImpl.java:642) > ~[classes/:?] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.destroyPaging(QueueImpl.java:2382) > ~[classes/:?] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.deleteQueue(QueueImpl.java:2441) > ~[classes/:?] > at > org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2512) > ~[classes/:?] > at > org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2461) > ~[classes/:?] > at > org.apache.activemq.artemis.core.server.impl.ServerSessionImpl.deleteQueue(ServerSessionImpl.java:1212) > ~[classes/:?] > at > org.apache.activemq.artemis.core.server.impl.ServerSessionImpl.deleteQueue(ServerSessionImpl.java:1196) > ~[classes/:?] > at > org.apache.activemq.artemis.core.protocol.core.ServerSessionPacketHandler.slowPacketHandler(ServerSessionPacketHandler.java:436) > ~[classes/:?] > On the occasion I had a fix for ARTEMIS-4165 in place, but the issue seems > orthogonal to me. > The cleanup methods are clearing the Netty collection out of abundance of > caution (to help out GC). The fix here is just to stop doing that. > As part of this fix I'm also adding a check-leak test to make sure such > objects are not leaking. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Updated] (ARTEMIS-4791) Update to JUnit 5.10.2
[ https://issues.apache.org/jira/browse/ARTEMIS-4791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic updated ARTEMIS-4791: - Fix Version/s: 2.35.0 > Update to JUnit 5.10.2 > -- > > Key: ARTEMIS-4791 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4791 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade > Components: Tests >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Minor > Fix For: 2.35.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Update to JUnit 5.10.2 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Closed] (ARTEMIS-4790) Use JUnit 5 for the test suite
[ https://issues.apache.org/jira/browse/ARTEMIS-4790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic closed ARTEMIS-4790. Resolution: Fixed > Use JUnit 5 for the test suite > -- > > Key: ARTEMIS-4790 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4790 > Project: ActiveMQ Artemis > Issue Type: Task > Components: Tests >Affects Versions: 2.33.0 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Major > Fix For: 2.35.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Switch to using JUnit 5 for the test suite, primarily using the new JUnit > Jupiter API and associated junit-jupiter-engine engine, but with select use > of junit-vintage-engine for some specific tests/models, e.g those that > require specific third party JUnit 4 Runners, or rely on dependencies that > fix them at JUnit 4 / 3. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Assigned] (ARTEMIS-4786) ConcurrentModificationException on Page.destroy
[ https://issues.apache.org/jira/browse/ARTEMIS-4786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic reassigned ARTEMIS-4786: Assignee: Clebert Suconic > ConcurrentModificationException on Page.destroy > --- > > Key: ARTEMIS-4786 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4786 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > > I observed this while running > org.apache.activemq.artemis.tests.integration.client.ConcurrentCreateDeleteProduceTest.testConcurrentProduceCreateAndDelete > in loop: > java.lang.AssertionError: null is not a legitimate internal value. Concurrent > Modification? > at > io.netty.util.collection.IntObjectHashMap.toExternal(IntObjectHashMap.java:103) > ~[netty-common-4.1.109.Final.jar:4.1.109.Final] > at > io.netty.util.collection.IntObjectHashMap.access$900(IntObjectHashMap.java:37) > ~[netty-common-4.1.109.Final.jar:4.1.109.Final] > at > io.netty.util.collection.IntObjectHashMap$PrimitiveIterator.value(IntObjectHashMap.java:650) > ~[netty-common-4.1.109.Final.jar:4.1.109.Final] > at > io.netty.util.collection.IntObjectHashMap$2$1.next(IntObjectHashMap.java:234) > ~[netty-common-4.1.109.Final.jar:4.1.109.Final] > at > org.apache.activemq.artemis.core.paging.cursor.impl.PageSubscriptionImpl.destroy(PageSubscriptionImpl.java:642) > ~[classes/:?] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.destroyPaging(QueueImpl.java:2382) > ~[classes/:?] > at > org.apache.activemq.artemis.core.server.impl.QueueImpl.deleteQueue(QueueImpl.java:2441) > ~[classes/:?] > at > org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2512) > ~[classes/:?] > at > org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2461) > ~[classes/:?] > at > org.apache.activemq.artemis.core.server.impl.ServerSessionImpl.deleteQueue(ServerSessionImpl.java:1212) > ~[classes/:?] > at > org.apache.activemq.artemis.core.server.impl.ServerSessionImpl.deleteQueue(ServerSessionImpl.java:1196) > ~[classes/:?] > at > org.apache.activemq.artemis.core.protocol.core.ServerSessionPacketHandler.slowPacketHandler(ServerSessionPacketHandler.java:436) > ~[classes/:?] > On the occasion I had a fix for ARTEMIS-4165 in place, but the issue seems > orthogonal to me. > The cleanup methods are clearing the Netty collection out of abundance of > caution (to help out GC). The fix here is just to stop doing that. > As part of this fix I'm also adding a check-leak test to make sure such > objects are not leaking. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Closed] (ARTEMIS-4791) Update to JUnit 5.10.2
[ https://issues.apache.org/jira/browse/ARTEMIS-4791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic closed ARTEMIS-4791. > Update to JUnit 5.10.2 > -- > > Key: ARTEMIS-4791 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4791 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade > Components: Tests >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Minor > Fix For: 2.35.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Update to JUnit 5.10.2 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Updated] (ARTEMIS-4796) Simplify SimpleString API
[
https://issues.apache.org/jira/browse/ARTEMIS-4796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Clebert Suconic updated ARTEMIS-4796:
-
Fix Version/s: 2.35.0
> Simplify SimpleString API
> -
>
> Key: ARTEMIS-4796
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4796
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.35.0
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Instead of using the verbosely named {{toSimpleString}} static factory method
> (and its overloaded counterparts), {{SimpleString}} should provide {{of}}
> implementations. This change would make the code more concise and readable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Updated] (ARTEMIS-4800) Simplify QueueConfiguration API
[ https://issues.apache.org/jira/browse/ARTEMIS-4800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic updated ARTEMIS-4800: - Fix Version/s: 2.35.0 > Simplify QueueConfiguration API > --- > > Key: ARTEMIS-4800 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4800 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Fix For: 2.35.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Closed] (ARTEMIS-4800) Simplify QueueConfiguration API
[ https://issues.apache.org/jira/browse/ARTEMIS-4800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic closed ARTEMIS-4800. Resolution: Fixed > Simplify QueueConfiguration API > --- > > Key: ARTEMIS-4800 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4800 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Fix For: 2.35.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Updated] (ARTEMIS-4811) Upgrade Netty to 4.1.111.Final
[ https://issues.apache.org/jira/browse/ARTEMIS-4811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clebert Suconic updated ARTEMIS-4811: - Fix Version/s: 2.35.0 > Upgrade Netty to 4.1.111.Final > -- > > Key: ARTEMIS-4811 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4811 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Emmanuel Hugonnet >Priority: Major > Fix For: 2.35.0 > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4814) Remove linear iteration to get direct bindings
[
https://issues.apache.org/jira/browse/ARTEMIS-4814?focusedWorklogId=923137=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923137
]
ASF GitHub Bot logged work on ARTEMIS-4814:
---
Author: ASF GitHub Bot
Created on: 12/Jun/24 13:00
Start Date: 12/Jun/24 13:00
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on PR #4972:
URL:
https://github.com/apache/activemq-artemis/pull/4972#issuecomment-2162952102
there are a few test failures:
Test /
org.apache.activemq.artemis.tests.integration.cli.AddressCommandTest.testForceDeleteAddressWhenExistsQueues
Test /
org.apache.activemq.artemis.tests.integration.addressing.TwoWaysRemoveAddressTest.testDeadLock
Test /
org.apache.activemq.artemis.tests.integration.ra.ActiveMQMessageHandlerTest.testSimpleMessageReceivedOnQueueManyMessagesAndInterruptTimeout
Test /
org.objectweb.jtests.jms.conform.session.TopicSessionTest.testUnsubscribe
Test /
org.objectweb.jtests.jms.conform.session.TopicSessionTest.testCreateSubscriber_1
Test /
org.objectweb.jtests.jms.conform.session.TopicSessionTest.testCreateSubscriber_2
Test /
org.objectweb.jtests.jms.conform.session.TopicSessionTest.testDurableSubscriber
Test /
org.objectweb.jtests.jms.conform.session.TopicSessionTest.testCreateDurableSubscriber_1
Test /
org.objectweb.jtests.jms.conform.session.TopicSessionTest.testCreateDurableSubscriber_2
Test /
org.objectweb.jtests.jms.conform.session.UnifiedSessionTest.testCreateTemporaryTopicOnQueueSession
Test /
org.objectweb.jtests.jms.conform.session.UnifiedSessionTest.testCreateQueueOnTopicSession
Test /
org.objectweb.jtests.jms.conform.session.UnifiedSessionTest.testCreateBrowserOnTopicSession
Test /
org.objectweb.jtests.jms.conform.session.UnifiedSessionTest.testUnsubscribeOnQueueSession
Test /
org.objectweb.jtests.jms.conform.session.UnifiedSessionTest.testCreateTemporaryQueueOnTopicSession
Test /
org.objectweb.jtests.jms.conform.session.UnifiedSessionTest.testCreateDurableSubscriberOnQueueSession
Test /
org.objectweb.jtests.jms.conform.session.UnifiedSessionTest.testCreateDurableConnectionConsumerOnQueueConnection
Test /
org.objectweb.jtests.jms.conform.session.UnifiedSessionTest.testCreateTopicOnQueueSession
Test /
org.objectweb.jtests.jms.conform.topic.TemporaryTopicTest.testTemporaryTopic
Test /
org.apache.activemq.artemis.tests.integration.amqp.connect.AMQPFederationAddressPolicyTest.testFederationHandlesAddressDeletedAndConsumerRecreates
Test /
org.apache.activemq.artemis.tests.integration.amqp.connect.AMQPFederationAddressPolicyTest.testRemoteBrokerClosesFederationReceiverAfterAddressRemoved
Test /
org.apache.activemq.artemis.tests.integration.cluster.distribution.SimpleSymmetricClusterTest.testDeleteAddress
Test /
org.apache.activemq.artemis.tests.integration.cluster.distribution.SymmetricClusterWithDiscoveryTest.testStartStopServers
Why you need this optimization? Are you constantly querying for the
destination on a producer or consumer?
Issue Time Tracking
---
Worklog Id: (was: 923137)
Time Spent: 20m (was: 10m)
> Remove linear iteration to get direct bindings
> --
>
> Key: ARTEMIS-4814
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4814
> Project: ActiveMQ Artemis
> Issue Type: Task
> Components: Broker
>Reporter: Josh Byster
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently, with 500K+ queues, the cleanup step of {{TempQueueCleanerUpper}}
> requires invoking {{WildcardAddressManager#getDirectBindings}}, which is O(k)
> in the number of queues.
> From method profiling, this can consume up to 95% of our CPU time when
> needing to clean up many of these.
> It would be nice to make this more efficient, which shouldn't be difficult
> given the iteration just does a simple equality check.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4814) Remove linear iteration to get direct bindings
[
https://issues.apache.org/jira/browse/ARTEMIS-4814?focusedWorklogId=923138=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923138
]
ASF GitHub Bot logged work on ARTEMIS-4814:
---
Author: ASF GitHub Bot
Created on: 12/Jun/24 13:00
Start Date: 12/Jun/24 13:00
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on PR #4972:
URL:
https://github.com/apache/activemq-artemis/pull/4972#issuecomment-2162952912
Why you need this optimization? are you querying the queue every time you
produce?
Issue Time Tracking
---
Worklog Id: (was: 923138)
Time Spent: 0.5h (was: 20m)
> Remove linear iteration to get direct bindings
> --
>
> Key: ARTEMIS-4814
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4814
> Project: ActiveMQ Artemis
> Issue Type: Task
> Components: Broker
>Reporter: Josh Byster
>Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently, with 500K+ queues, the cleanup step of {{TempQueueCleanerUpper}}
> requires invoking {{WildcardAddressManager#getDirectBindings}}, which is O(k)
> in the number of queues.
> From method profiling, this can consume up to 95% of our CPU time when
> needing to clean up many of these.
> It would be nice to make this more efficient, which shouldn't be difficult
> given the iteration just does a simple equality check.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4795) Enforce queue filter when sending to FQQN
[ https://issues.apache.org/jira/browse/ARTEMIS-4795?focusedWorklogId=923124=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923124 ] ASF GitHub Bot logged work on ARTEMIS-4795: --- Author: ASF GitHub Bot Created on: 12/Jun/24 12:26 Start Date: 12/Jun/24 12:26 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #4958: URL: https://github.com/apache/activemq-artemis/pull/4958 Issue Time Tracking --- Worklog Id: (was: 923124) Time Spent: 20m (was: 10m) > Enforce queue filter when sending to FQQN > - > > Key: ARTEMIS-4795 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4795 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > When sending a message directly to an FQQN the queue's filter is not enforced > on the message which is sent. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Commented] (ARTEMIS-4795) Enforce queue filter when sending to FQQN
[ https://issues.apache.org/jira/browse/ARTEMIS-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17854418#comment-17854418 ] ASF subversion and git services commented on ARTEMIS-4795: -- Commit e3805bd05adeca495f8cf0ec8b83571cbdff9a9e in activemq-artemis's branch refs/heads/main from Justin Bertram [ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=e3805bd05a ] ARTEMIS-4795 enforce queue filter when sending to FQQN > Enforce queue filter when sending to FQQN > - > > Key: ARTEMIS-4795 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4795 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > When sending a message directly to an FQQN the queue's filter is not enforced > on the message which is sent. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
