[jira] [Work logged] (ARTEMIS-5073) Formatting error of AMQ601771 audit log event
[
https://issues.apache.org/jira/browse/ARTEMIS-5073?focusedWorklogId=936980&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936980
]
ASF GitHub Bot logged work on ARTEMIS-5073:
---
Author: ASF GitHub Bot
Created on: 28/Sep/24 17:06
Start Date: 28/Sep/24 17:06
Worklog Time Spent: 10m
Work Description: jbertram opened a new pull request, #5266:
URL: https://github.com/apache/activemq-artemis/pull/5266
(no comment)
Issue Time Tracking
---
Worklog Id: (was: 936980)
Remaining Estimate: 0h
Time Spent: 10m
> Formatting error of AMQ601771 audit log event
> -
>
> Key: ARTEMIS-5073
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5073
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Affects Versions: 2.36.0, 2.37.0
>Reporter: Aleksandr Milovidov
>Assignee: Justin Bertram
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When audit logging is enabled and the Prometheus JMX exporter is used as a
> Java agent, some errors are written to stdout. It happens when the exporter
> collects metrics. Username in this case may be null or anonymous.
> Reproducible in versions 2.36.0 and 2.37.0.
> Steps to reproduce:
> # Create Artemis instance.
> # Enable base audit logging in {{log4j2.properties}}:
> {noformat}
> logger.audit_base.level = INFO{noformat}
> # Add JMX exporter as Java agent: add following arguments to the
> {{JAVA_ARGS}} variable in the {{artemis.profile}} (change paths according to
> the environment):
> {noformat}
> -javaagent:/path/to/jmx_prometheus_javaagent.jar=9404:/path/to/jmx_exporter_config.yml{noformat}
> Example {{jmx_exporter_config.yml}}:
> {code:yaml}
> lowercaseOutputName: true
> lowercaseOutputLabelNames: true
> rules:
> - pattern:
> "^org.apache.activemq.artemis<>([^:]*):\\s(.*)"
> attrNameSnakeCase: true
> name: artemis_$2
> type: GAUGE{code}
> JMX Exporter can be downloaded
> [here|https://github.com/prometheus/jmx_exporter/tree/release-1.0.1/docs].
> # Start Artemis and access {{http://your-server-name:9404/metrics/}} using a
> browser or {{curl}} command-line utility.
> Event is logged to stdout of Artemis process:
> {noformat}
> 2024-09-27T11:39:06.041494200Z prometheus-http-1-1 ERROR Unable to format
> msg: AMQ601771: User {} is getting name on target resource: {}
> java.lang.IllegalArgumentException: found 2 argument placeholders, but
> provided 1 for pattern `AMQ601771: User {} is getting name on target
> resource: {}`
> at
> org.apache.logging.log4j.message.ParameterFormatter.formatMessage(ParameterFormatter.java:248)
> at
> org.apache.logging.log4j.message.ParameterizedMessage.formatTo(ParameterizedMessage.java:282)
> at
> org.apache.logging.log4j.core.pattern.MessagePatternConverter$SimpleMessagePatternConverter.format(MessagePatternConverter.java:120)
> at
> org.apache.logging.log4j.core.layout.PatternLayout$NoFormatPatternSerializer.toSerializable(PatternLayout.java:355)
> at
> org.apache.logging.log4j.core.layout.PatternLayout.toText(PatternLayout.java:252)
> at
> org.apache.logging.log4j.core.layout.PatternLayout.encode(PatternLayout.java:238)
> at
> org.apache.logging.log4j.core.layout.PatternLayout.encode(PatternLayout.java:58)
> at
> org.apache.logging.log4j.core.appender.AbstractOutputStreamAppender.directEncodeEvent(AbstractOutputStreamAppender.java:227)
> at
> org.apache.logging.log4j.core.appender.AbstractOutputStreamAppender.tryAppend(AbstractOutputStreamAppender.java:220)
> at
> org.apache.logging.log4j.core.appender.AbstractOutputStreamAppender.append(AbstractOutputStreamAppender.java:211)
> at
> org.apache.logging.log4j.core.appender.RollingFileAppender.append(RollingFileAppender.java:337)
> at
> org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:160)
> at
> org.apache.logging.log4j.core.config.AppenderControl.callAppender0(AppenderControl.java:133)
> at
> org.apache.logging.log4j.core.config.AppenderControl.callAppenderPreventRecursion(AppenderControl.java:124)
> at
> org.apache.logging.log4j.core.config.AppenderControl.callAppender(AppenderControl.java:88)
> at
> org.apache.logging.log4j.core.config.LoggerConfig.callAppenders(LoggerConfig.java:705)
> at
> org.apache.logging.log4j.core.config.LoggerConfig.processLogEvent(LoggerConfig.java:663)
> at
> org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:639)
> at
> org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:575)
> at
> org.apache.logging.log4j.core.config.AwaitCompletionReliabilityS
[jira] [Work logged] (ARTEMIS-5074) Broker AMQP Message mishandles put and get of byte[] in ApplicationProperties
[ https://issues.apache.org/jira/browse/ARTEMIS-5074?focusedWorklogId=936906&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936906 ] ASF GitHub Bot logged work on ARTEMIS-5074: --- Author: ASF GitHub Bot Created on: 27/Sep/24 18:30 Start Date: 27/Sep/24 18:30 Worklog Time Spent: 10m Work Description: gemmellr merged PR #5265: URL: https://github.com/apache/activemq-artemis/pull/5265 Issue Time Tracking --- Worklog Id: (was: 936906) Time Spent: 0.5h (was: 20m) > Broker AMQP Message mishandles put and get of byte[] in ApplicationProperties > - > > Key: ARTEMIS-5074 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5074 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.37.0 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Major > Fix For: 2.38.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > When the internal AMQPMessage API methods for getting or setting byte[] > values in the ApplicationProperties of the AMQP message are used they are > treating the value as a byte[] array where it should always be wrapped in an > AMQP Binary instance to allow proton to encode it and unwrap it when decoded > and fetched from the application properties. > Without the handling the proton encoder will throw a ClassCastException when > attempting to encode byte[] instances (which are not allowed in the > application-properties section). The get code must account for the Binary as > the wrapper and account for the fact that the array may be an offset view of > a larger array value. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5074) Broker AMQP Message mishandles put and get of byte[] in ApplicationProperties
[ https://issues.apache.org/jira/browse/ARTEMIS-5074?focusedWorklogId=936843&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936843 ] ASF GitHub Bot logged work on ARTEMIS-5074: --- Author: ASF GitHub Bot Created on: 27/Sep/24 16:10 Start Date: 27/Sep/24 16:10 Worklog Time Spent: 10m Work Description: tabish121 commented on PR #5265: URL: https://github.com/apache/activemq-artemis/pull/5265#issuecomment-2379627108 I've run these changes through CI a few times to validate no new failures Issue Time Tracking --- Worklog Id: (was: 936843) Time Spent: 20m (was: 10m) > Broker AMQP Message mishandles put and get of byte[] in ApplicationProperties > - > > Key: ARTEMIS-5074 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5074 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.37.0 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Major > Fix For: 2.38.0 > > Time Spent: 20m > Remaining Estimate: 0h > > When the internal AMQPMessage API methods for getting or setting byte[] > values in the ApplicationProperties of the AMQP message are used they are > treating the value as a byte[] array where it should always be wrapped in an > AMQP Binary instance to allow proton to encode it and unwrap it when decoded > and fetched from the application properties. > Without the handling the proton encoder will throw a ClassCastException when > attempting to encode byte[] instances. The get code must account for the > Binary as the wrapper and account for the fact that the array may be an > offset view of a larger array value. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5074) Broker AMQP Message mishandles put and get of byte[] in ApplicationProperties
[ https://issues.apache.org/jira/browse/ARTEMIS-5074?focusedWorklogId=936842&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936842 ] ASF GitHub Bot logged work on ARTEMIS-5074: --- Author: ASF GitHub Bot Created on: 27/Sep/24 16:10 Start Date: 27/Sep/24 16:10 Worklog Time Spent: 10m Work Description: tabish121 opened a new pull request, #5265: URL: https://github.com/apache/activemq-artemis/pull/5265 When a bytes property is added to an AMQPMessage and it is then reencoded it will fail without first wrapping the byte array in an AMQP binary as required by the ApplicationProperties section specification defined type allowances. Issue Time Tracking --- Worklog Id: (was: 936842) Remaining Estimate: 0h Time Spent: 10m > Broker AMQP Message mishandles put and get of byte[] in ApplicationProperties > - > > Key: ARTEMIS-5074 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5074 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: AMQP >Affects Versions: 2.37.0 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Major > Fix For: 2.38.0 > > Time Spent: 10m > Remaining Estimate: 0h > > When the internal AMQPMessage API methods for getting or setting byte[] > values in the ApplicationProperties of the AMQP message are used they are > treating the value as a byte[] array where it should always be wrapped in an > AMQP Binary instance to allow proton to encode it and unwrap it when decoded > and fetched from the application properties. > Without the handling the proton encoder will throw a ClassCastException when > attempting to encode byte[] instances. The get code must account for the > Binary as the wrapper and account for the fact that the array may be an > offset view of a larger array value. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5037) AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages
[
https://issues.apache.org/jira/browse/ARTEMIS-5037?focusedWorklogId=936748&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936748
]
ASF GitHub Bot logged work on ARTEMIS-5037:
---
Author: ASF GitHub Bot
Created on: 27/Sep/24 09:11
Start Date: 27/Sep/24 09:11
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #5220:
URL: https://github.com/apache/activemq-artemis/pull/5220#discussion_r1778266549
##
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerSource.java:
##
@@ -236,6 +238,10 @@ public void deleteAddress(AddressInfo addressInfo) throws
Exception {
if (ignoreAddress(addressInfo.getName())) {
return;
}
+ if (isBlockedByNoForward()) {
+ return;
+ }
+
Review Comment:
I would do this earlier; no point checking the specific address is permitted
(the bit above) if we aren't allowed to forward it _anywhere_.
Same for other bits further down
Issue Time Tracking
---
Worklog Id: (was: 936748)
Time Spent: 3.5h (was: 3h 20m)
> AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages
> ---
>
> Key: ARTEMIS-5037
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5037
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Thomas Lavocat
>Assignee: Thomas Lavocat
>Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages:
> if we have a->b-c->a..
> a message will circulate forever in the mirrors
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5037) AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages
[
https://issues.apache.org/jira/browse/ARTEMIS-5037?focusedWorklogId=936747&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936747
]
ASF GitHub Bot logged work on ARTEMIS-5037:
---
Author: ASF GitHub Bot
Created on: 27/Sep/24 09:10
Start Date: 27/Sep/24 09:10
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #5220:
URL: https://github.com/apache/activemq-artemis/pull/5220#discussion_r1778261976
##
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerSource.java:
##
@@ -60,7 +61,7 @@
import static
org.apache.activemq.artemis.protocol.amqp.connect.mirror.AMQPMirrorControllerTarget.getControllerInUse;
-public class AMQPMirrorControllerSource extends BasicMirrorController
implements MirrorController, ActiveMQComponent {
+public class AMQPMirrorControllerSource extends BasicMirrorController
implements ActiveMQComponent, NoForwardMirrorController {
Review Comment:
Per other comments, feels like this should still just implement the base
MirrorController interface only?
Issue Time Tracking
---
Worklog Id: (was: 936747)
Time Spent: 3h 20m (was: 3h 10m)
> AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages
> ---
>
> Key: ARTEMIS-5037
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5037
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Thomas Lavocat
>Assignee: Thomas Lavocat
>Priority: Major
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages:
> if we have a->b-c->a..
> a message will circulate forever in the mirrors
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5037) AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages
[
https://issues.apache.org/jira/browse/ARTEMIS-5037?focusedWorklogId=936746&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936746
]
ASF GitHub Bot logged work on ARTEMIS-5037:
---
Author: ASF GitHub Bot
Created on: 27/Sep/24 09:10
Start Date: 27/Sep/24 09:10
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #5220:
URL: https://github.com/apache/activemq-artemis/pull/5220#discussion_r1777398695
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/mirror/NoForwardMirrorController.java:
##
@@ -0,0 +1,5 @@
+package org.apache.activemq.artemis.core.server.mirror;
Review Comment:
Needs the license header added
##
artemis-server/src/main/resources/schema/artemis-configuration.xsd:
##
@@ -2306,6 +2306,14 @@
+
+
+
+ If this is true, the mirror at the opposite end of the link
will not forward data coming from that link to any other mirrors down the line.
Review Comment:
"the mirror at the opposite end of the link will not forward data coming
from that link..." might be clearer as something like "the broker at the
opposite end of the mirror link will not forward messages or instructions
coming from this broker..."
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/mirror/NoForwardMirrorController.java:
##
@@ -0,0 +1,5 @@
+package org.apache.activemq.artemis.core.server.mirror;
+
+public interface NoForwardMirrorController extends MirrorController{
Review Comment:
I would go with e.g MirrorControllerTarget or TargetMirrorController, and
then only the AMQPMirrorControllerTarget (and the substitute inside AckManager)
would implement it, not the AMQPMirrorControllerSource. We can use the same
interface for other Target-specific detail later without renaming it or adding
others, and more easily follow target-specific functionality around the broker.
In the usage we only care if the message is being operated on via a mirror
target, by a mirror source. The mirror source doesnt need to implement this
method.
EDIT: later bit already fixed.
##
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerSource.java:
##
@@ -236,6 +238,10 @@ public void deleteAddress(AddressInfo addressInfo) throws
Exception {
if (ignoreAddress(addressInfo.getName())) {
return;
}
+ if (isBlockedByNoForward()) {
+ return;
+ }
+
Review Comment:
I would do this earlier; no point checking the specific address is permitted
(the bit above) if we aren't allowed to forward it _anywhere_.
Same for other bits futher down
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/amqpBrokerConnectivity/AMQPMirrorBrokerConnectionElement.java:
##
@@ -75,6 +77,15 @@ public AMQPMirrorBrokerConnectionElement
setQueueCreation(boolean queueCreation)
return this;
}
+ public boolean getNoForward() {
+ return noForward;
+ }
+
+ public AMQPMirrorBrokerConnectionElement setNoForward(boolean noForward) {
Review Comment:
The naming here influences the namign needed for Broker Properties
.properties / .yaml based configs. Here the property name is "NoForward", but
in the xml config the wording "no-forwarding". They should probably be
consistent in the wording i.e the _forward_, or _forwarding_) if there isn't a
significant reason for them to differ.
##
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerSource.java:
##
@@ -559,6 +587,10 @@ public void preAcknowledge(final Transaction tx, final
MessageReference ref, fin
return;
}
+ if (isBlockedByNoForward()) {
+ return;
+ }
+
Review Comment:
I suspect a different check will be needed here, inspecting the specific
message; this is ultimately called by the queue, which I expect usually wont
have a mirror target controller set. It will also want to accommodate not
sending acks for no-forward messages [that it didnt send to begin with] even
across broker restarts, due to expiry, etc etc.
I expect the test-peer based testing I know you are working on will
demonstrate this.
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/mirror/NoForwardMirrorController.java:
##
@@ -0,0 +1,5 @@
+package org.apache.activemq.artemis.core.server.mirror;
+
+public interface NoForwardMirrorController extends MirrorController{
+ public boolean getNoForward();
Review Comment:
As a boolean, isNoForward would be more typical.
##
artemis-protocols/artemis-amqp-protocol/src/main/java
[jira] [Work logged] (ARTEMIS-5037) AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages
[ https://issues.apache.org/jira/browse/ARTEMIS-5037?focusedWorklogId=936620&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936620 ] ASF GitHub Bot logged work on ARTEMIS-5037: --- Author: ASF GitHub Bot Created on: 26/Sep/24 16:09 Start Date: 26/Sep/24 16:09 Worklog Time Spent: 10m Work Description: lavocatt commented on code in PR #5220: URL: https://github.com/apache/activemq-artemis/pull/5220#discussion_r1777384712 ## artemis-server/src/main/resources/schema/artemis-configuration.xsd: ## @@ -2290,6 +2290,14 @@ + + + + If this is true, the mirror at the opposite end of the link will not forward messages coming from that link to any other mirrors down the line. + This is false by default. + + + Review Comment: Got that fixed. Issue Time Tracking --- Worklog Id: (was: 936620) Time Spent: 3h (was: 2h 50m) > AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages > --- > > Key: ARTEMIS-5037 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5037 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Thomas Lavocat >Assignee: Thomas Lavocat >Priority: Major > Time Spent: 3h > Remaining Estimate: 0h > > AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages: > if we have a->b-c->a.. > a message will circulate forever in the mirrors -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5062) ClusterConnectionControl has wrong annotation
[ https://issues.apache.org/jira/browse/ARTEMIS-5062?focusedWorklogId=936628&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936628 ] ASF GitHub Bot logged work on ARTEMIS-5062: --- Author: ASF GitHub Bot Created on: 26/Sep/24 16:48 Start Date: 26/Sep/24 16:48 Worklog Time Spent: 10m Work Description: jbertram merged PR #5253: URL: https://github.com/apache/activemq-artemis/pull/5253 Issue Time Tracking --- Worklog Id: (was: 936628) Time Spent: 20m (was: 10m) > ClusterConnectionControl has wrong annotation > - > > Key: ARTEMIS-5062 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5062 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: management >Affects Versions: 2.37.0 >Reporter: Howard Gao >Assignee: Howard Gao >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > The ClusterConnectionControl.getBridgeMetrics() method is annotated with > Attribute but it should be Operation. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5037) AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages
[
https://issues.apache.org/jira/browse/ARTEMIS-5037?focusedWorklogId=936619&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936619
]
ASF GitHub Bot logged work on ARTEMIS-5037:
---
Author: ASF GitHub Bot
Created on: 26/Sep/24 16:05
Start Date: 26/Sep/24 16:05
Worklog Time Spent: 10m
Work Description: lavocatt commented on code in PR #5220:
URL: https://github.com/apache/activemq-artemis/pull/5220#discussion_r1777379020
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/PostOffice.java:
##
@@ -65,10 +65,14 @@ default void reloadAddressInfo(AddressInfo addressInfo)
throws Exception {
AddressInfo removeAddressInfo(SimpleString address, boolean force) throws
Exception;
+ AddressInfo removeAddressInfo(SimpleString address, boolean force, boolean
noForward) throws Exception;
Review Comment:
I've implemented this today.
Issue Time Tracking
---
Worklog Id: (was: 936619)
Time Spent: 2h 50m (was: 2h 40m)
> AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages
> ---
>
> Key: ARTEMIS-5037
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5037
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Thomas Lavocat
>Assignee: Thomas Lavocat
>Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages:
> if we have a->b-c->a..
> a message will circulate forever in the mirrors
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9570) Upgrade to Spring 6.1.13
[ https://issues.apache.org/jira/browse/AMQ-9570?focusedWorklogId=936578&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936578 ] ASF GitHub Bot logged work on AMQ-9570: --- Author: ASF GitHub Bot Created on: 26/Sep/24 12:11 Start Date: 26/Sep/24 12:11 Worklog Time Spent: 10m Work Description: jbonofre opened a new pull request, #1317: URL: https://github.com/apache/activemq/pull/1317 (no comment) Issue Time Tracking --- Worklog Id: (was: 936578) Remaining Estimate: 0h Time Spent: 10m > Upgrade to Spring 6.1.13 > > > Key: AMQ-9570 > URL: https://issues.apache.org/jira/browse/AMQ-9570 > Project: ActiveMQ Classic > Issue Type: Dependency upgrade > Components: Broker >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.2.0, 6.1.4 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9585) Upgrade to taglist-maven-plugin 3.1.0
[ https://issues.apache.org/jira/browse/AMQ-9585?focusedWorklogId=936577&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936577 ] ASF GitHub Bot logged work on AMQ-9585: --- Author: ASF GitHub Bot Created on: 26/Sep/24 12:04 Start Date: 26/Sep/24 12:04 Worklog Time Spent: 10m Work Description: jbonofre merged PR #1315: URL: https://github.com/apache/activemq/pull/1315 Issue Time Tracking --- Worklog Id: (was: 936577) Time Spent: 20m (was: 10m) > Upgrade to taglist-maven-plugin 3.1.0 > - > > Key: AMQ-9585 > URL: https://issues.apache.org/jira/browse/AMQ-9585 > Project: ActiveMQ Classic > Issue Type: Dependency upgrade >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.2.0, 5.18.6, 6.1.4 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5063) Addition of a messageMoved() callback in ActiveMQServerMessagePlugin
[ https://issues.apache.org/jira/browse/ARTEMIS-5063?focusedWorklogId=936516&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936516 ] ASF GitHub Bot logged work on ARTEMIS-5063: --- Author: ASF GitHub Bot Created on: 26/Sep/24 06:42 Start Date: 26/Sep/24 06:42 Worklog Time Spent: 10m Work Description: jpbriquet commented on PR #5257: URL: https://github.com/apache/activemq-artemis/pull/5257#issuecomment-2376065499 Thanks for the merge @clebertsuconic ! Issue Time Tracking --- Worklog Id: (was: 936516) Time Spent: 40m (was: 0.5h) > Addition of a messageMoved() callback in ActiveMQServerMessagePlugin > > > Key: ARTEMIS-5063 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5063 > Project: ActiveMQ Artemis > Issue Type: New Feature > Components: Broker >Reporter: Jean-Pascal Briquet >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > The Addition of a messageMoved() callback in ActiveMQServerMessagePlugin > would allow the interception of message move events in custom plugins. > A typical use case would be to log details about these move operations. > > The callback would be triggered when a message move operation occurs within > Artemis. > The best location for this seems to be within the QueueImpl.move() method. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9584) Upgrade to javacc-maven-plugin 3.1.0
[ https://issues.apache.org/jira/browse/AMQ-9584?focusedWorklogId=936511&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936511 ] ASF GitHub Bot logged work on AMQ-9584: --- Author: ASF GitHub Bot Created on: 26/Sep/24 05:57 Start Date: 26/Sep/24 05:57 Worklog Time Spent: 10m Work Description: jbonofre merged PR #1314: URL: https://github.com/apache/activemq/pull/1314 Issue Time Tracking --- Worklog Id: (was: 936511) Time Spent: 20m (was: 10m) > Upgrade to javacc-maven-plugin 3.1.0 > > > Key: AMQ-9584 > URL: https://issues.apache.org/jira/browse/AMQ-9584 > Project: ActiveMQ Classic > Issue Type: Dependency upgrade >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.2.0, 5.18.6, 6.1.4 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9583) Upgrade to build-helper-maven-plugin 3.6.0
[ https://issues.apache.org/jira/browse/AMQ-9583?focusedWorklogId=936510&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936510 ] ASF GitHub Bot logged work on AMQ-9583: --- Author: ASF GitHub Bot Created on: 26/Sep/24 05:52 Start Date: 26/Sep/24 05:52 Worklog Time Spent: 10m Work Description: jbonofre merged PR #1313: URL: https://github.com/apache/activemq/pull/1313 Issue Time Tracking --- Worklog Id: (was: 936510) Time Spent: 20m (was: 10m) > Upgrade to build-helper-maven-plugin 3.6.0 > -- > > Key: AMQ-9583 > URL: https://issues.apache.org/jira/browse/AMQ-9583 > Project: ActiveMQ Classic > Issue Type: Dependency upgrade >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.2.0, 5.18.6, 6.1.4 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5063) Addition of a messageMoved() callback in ActiveMQServerMessagePlugin
[ https://issues.apache.org/jira/browse/ARTEMIS-5063?focusedWorklogId=936497&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936497 ] ASF GitHub Bot logged work on ARTEMIS-5063: --- Author: ASF GitHub Bot Created on: 26/Sep/24 01:59 Start Date: 26/Sep/24 01:59 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #5257: URL: https://github.com/apache/activemq-artemis/pull/5257 Issue Time Tracking --- Worklog Id: (was: 936497) Time Spent: 0.5h (was: 20m) > Addition of a messageMoved() callback in ActiveMQServerMessagePlugin > > > Key: ARTEMIS-5063 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5063 > Project: ActiveMQ Artemis > Issue Type: New Feature > Components: Broker >Reporter: Jean-Pascal Briquet >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > The Addition of a messageMoved() callback in ActiveMQServerMessagePlugin > would allow the interception of message move events in custom plugins. > A typical use case would be to log details about these move operations. > > The callback would be triggered when a message move operation occurs within > Artemis. > The best location for this seems to be within the QueueImpl.move() method. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5068) Temporary Queues should not be mirrored
[ https://issues.apache.org/jira/browse/ARTEMIS-5068?focusedWorklogId=936496&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936496 ] ASF GitHub Bot logged work on ARTEMIS-5068: --- Author: ASF GitHub Bot Created on: 26/Sep/24 01:58 Start Date: 26/Sep/24 01:58 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #5260: URL: https://github.com/apache/activemq-artemis/pull/5260 Issue Time Tracking --- Worklog Id: (was: 936496) Time Spent: 20m (was: 10m) > Temporary Queues should not be mirrored > --- > > Key: ARTEMIS-5068 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5068 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Clebert Suconic >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5066) Diverts should not be applied on mirror
[ https://issues.apache.org/jira/browse/ARTEMIS-5066?focusedWorklogId=936495&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936495 ] ASF GitHub Bot logged work on ARTEMIS-5066: --- Author: ASF GitHub Bot Created on: 26/Sep/24 01:57 Start Date: 26/Sep/24 01:57 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #5256: URL: https://github.com/apache/activemq-artemis/pull/5256 Issue Time Tracking --- Worklog Id: (was: 936495) Time Spent: 20m (was: 10m) > Diverts should not be applied on mirror > --- > > Key: ARTEMIS-5066 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5066 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.38.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Instead of applying Diverts on Mirror Target, we should just send the > operations after the fact. > Right now if you have a non exclusive divert, the messages will be > duplicated.. one from the afterSend event, another for the actual routing of > the divert on the targets resulting in messages that will not be removed from > the ACK Manager and duplicates. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5065) We should remove mirror properties for Core and OpenWire Protocols upon receiving them on the server
[ https://issues.apache.org/jira/browse/ARTEMIS-5065?focusedWorklogId=936494&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936494 ] ASF GitHub Bot logged work on ARTEMIS-5065: --- Author: ASF GitHub Bot Created on: 26/Sep/24 01:57 Start Date: 26/Sep/24 01:57 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #5255: URL: https://github.com/apache/activemq-artemis/pull/5255 Issue Time Tracking --- Worklog Id: (was: 936494) Time Spent: 20m (was: 10m) > We should remove mirror properties for Core and OpenWire Protocols upon > receiving them on the server > > > Key: ARTEMIS-5065 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5065 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.38.0 > > Time Spent: 20m > Remaining Estimate: 0h > > say a consumer received a message from a target mirror using Core or OpenWire > Protocol. > The message will contain properties that would be hidden if using AMQP > Protocol. > Upon receiving them the server should remove them to avoid retagging them > with the older values. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5068) Temporary Queues should not be mirrored
[ https://issues.apache.org/jira/browse/ARTEMIS-5068?focusedWorklogId=936482&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936482 ] ASF GitHub Bot logged work on ARTEMIS-5068: --- Author: ASF GitHub Bot Created on: 25/Sep/24 21:19 Start Date: 25/Sep/24 21:19 Worklog Time Spent: 10m Work Description: clebertsuconic opened a new pull request, #5260: URL: https://github.com/apache/activemq-artemis/pull/5260 (no comment) Issue Time Tracking --- Worklog Id: (was: 936482) Remaining Estimate: 0h Time Spent: 10m > Temporary Queues should not be mirrored > --- > > Key: ARTEMIS-5068 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5068 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Clebert Suconic >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5067) Race on Mirror while one side is connected while the other is not
[ https://issues.apache.org/jira/browse/ARTEMIS-5067?focusedWorklogId=936466&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936466 ] ASF GitHub Bot logged work on ARTEMIS-5067: --- Author: ASF GitHub Bot Created on: 25/Sep/24 19:44 Start Date: 25/Sep/24 19:44 Worklog Time Spent: 10m Work Description: clebertsuconic closed pull request #5259: ARTEMIS-5067 Preventing Race when one side is not connected in the mirror URL: https://github.com/apache/activemq-artemis/pull/5259 Issue Time Tracking --- Worklog Id: (was: 936466) Time Spent: 20m (was: 10m) > Race on Mirror while one side is connected while the other is not > - > > Key: ARTEMIS-5067 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5067 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.37.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.38.0 > > Time Spent: 20m > Remaining Estimate: 0h > > you send a message on mirror Source.. > Source connects to target, but target still trying to connect back. > a message send to target will bounce back as a new message. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9582) Upgrade to maven-surefire-plugin 3.5.0
[ https://issues.apache.org/jira/browse/AMQ-9582?focusedWorklogId=936445&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936445 ] ASF GitHub Bot logged work on AMQ-9582: --- Author: ASF GitHub Bot Created on: 25/Sep/24 16:58 Start Date: 25/Sep/24 16:58 Worklog Time Spent: 10m Work Description: jbonofre merged PR #1312: URL: https://github.com/apache/activemq/pull/1312 Issue Time Tracking --- Worklog Id: (was: 936445) Time Spent: 20m (was: 10m) > Upgrade to maven-surefire-plugin 3.5.0 > -- > > Key: AMQ-9582 > URL: https://issues.apache.org/jira/browse/AMQ-9582 > Project: ActiveMQ Classic > Issue Type: Dependency upgrade >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.2.0, 5.18.6, 6.1.4 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9581) Upgrade to maven-release-plugin 3.1.1
[ https://issues.apache.org/jira/browse/AMQ-9581?focusedWorklogId=936444&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936444 ] ASF GitHub Bot logged work on AMQ-9581: --- Author: ASF GitHub Bot Created on: 25/Sep/24 16:54 Start Date: 25/Sep/24 16:54 Worklog Time Spent: 10m Work Description: jbonofre merged PR #1311: URL: https://github.com/apache/activemq/pull/1311 Issue Time Tracking --- Worklog Id: (was: 936444) Time Spent: 20m (was: 10m) > Upgrade to maven-release-plugin 3.1.1 > - > > Key: AMQ-9581 > URL: https://issues.apache.org/jira/browse/AMQ-9581 > Project: ActiveMQ Classic > Issue Type: Dependency upgrade >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.2.0, 5.18.6, 6.1.4 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5063) Addition of a messageMoved() callback in ActiveMQServerMessagePlugin
[ https://issues.apache.org/jira/browse/ARTEMIS-5063?focusedWorklogId=936441&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936441 ] ASF GitHub Bot logged work on ARTEMIS-5063: --- Author: ASF GitHub Bot Created on: 25/Sep/24 16:50 Start Date: 25/Sep/24 16:50 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #5257: URL: https://github.com/apache/activemq-artemis/pull/5257#issuecomment-2374621924 nicely done... I actually thought it was Justin's when I read the user's name committing (Justin's user starts with jb) What I meant was: nicely node as in committer's quality... thanks for the contribution! I will merge it after running some of my CI runs... just in case. (Internal CI with a more complete test set). Issue Time Tracking --- Worklog Id: (was: 936441) Time Spent: 20m (was: 10m) > Addition of a messageMoved() callback in ActiveMQServerMessagePlugin > > > Key: ARTEMIS-5063 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5063 > Project: ActiveMQ Artemis > Issue Type: New Feature > Components: Broker >Reporter: Jean-Pascal Briquet >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > The Addition of a messageMoved() callback in ActiveMQServerMessagePlugin > would allow the interception of message move events in custom plugins. > A typical use case would be to log details about these move operations. > > The callback would be triggered when a message move operation occurs within > Artemis. > The best location for this seems to be within the QueueImpl.move() method. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5067) Race on Mirror while one side is connected while the other is not
[ https://issues.apache.org/jira/browse/ARTEMIS-5067?focusedWorklogId=936433&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936433 ] ASF GitHub Bot logged work on ARTEMIS-5067: --- Author: ASF GitHub Bot Created on: 25/Sep/24 16:16 Start Date: 25/Sep/24 16:16 Worklog Time Spent: 10m Work Description: clebertsuconic opened a new pull request, #5259: URL: https://github.com/apache/activemq-artemis/pull/5259 (no comment) Issue Time Tracking --- Worklog Id: (was: 936433) Remaining Estimate: 0h Time Spent: 10m > Race on Mirror while one side is connected while the other is not > - > > Key: ARTEMIS-5067 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5067 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.37.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.38.0 > > Time Spent: 10m > Remaining Estimate: 0h > > you send a message on mirror Source.. > Source connects to target, but target still trying to connect back. > a message send to target will bounce back as a new message. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9580) Upgrade to maven-project-info-reports-plugin 3.7.0
[ https://issues.apache.org/jira/browse/AMQ-9580?focusedWorklogId=936432&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936432 ] ASF GitHub Bot logged work on AMQ-9580: --- Author: ASF GitHub Bot Created on: 25/Sep/24 16:11 Start Date: 25/Sep/24 16:11 Worklog Time Spent: 10m Work Description: jbonofre merged PR #1310: URL: https://github.com/apache/activemq/pull/1310 Issue Time Tracking --- Worklog Id: (was: 936432) Time Spent: 20m (was: 10m) > Upgrade to maven-project-info-reports-plugin 3.7.0 > -- > > Key: AMQ-9580 > URL: https://issues.apache.org/jira/browse/AMQ-9580 > Project: ActiveMQ Classic > Issue Type: Dependency upgrade >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.2.0, 5.18.6, 6.1.4 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9578) Upgrade to maven-jar-plugin 3.4.2
[ https://issues.apache.org/jira/browse/AMQ-9578?focusedWorklogId=936429&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936429 ] ASF GitHub Bot logged work on AMQ-9578: --- Author: ASF GitHub Bot Created on: 25/Sep/24 16:01 Start Date: 25/Sep/24 16:01 Worklog Time Spent: 10m Work Description: jbonofre merged PR #1308: URL: https://github.com/apache/activemq/pull/1308 Issue Time Tracking --- Worklog Id: (was: 936429) Time Spent: 20m (was: 10m) > Upgrade to maven-jar-plugin 3.4.2 > - > > Key: AMQ-9578 > URL: https://issues.apache.org/jira/browse/AMQ-9578 > Project: ActiveMQ Classic > Issue Type: Dependency upgrade >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.2.0, 5.18.6, 6.1.4 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9563) Refactor code to remove deprecated AccessController and SecurityManager
[ https://issues.apache.org/jira/browse/AMQ-9563?focusedWorklogId=936424&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936424 ] ASF GitHub Bot logged work on AMQ-9563: --- Author: ASF GitHub Bot Created on: 25/Sep/24 15:47 Start Date: 25/Sep/24 15:47 Worklog Time Spent: 10m Work Description: mattrpav merged PR #1296: URL: https://github.com/apache/activemq/pull/1296 Issue Time Tracking --- Worklog Id: (was: 936424) Time Spent: 50m (was: 40m) > Refactor code to remove deprecated AccessController and SecurityManager > --- > > Key: AMQ-9563 > URL: https://issues.apache.org/jira/browse/AMQ-9563 > Project: ActiveMQ Classic > Issue Type: Task >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Major > Fix For: 6.2.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Future JDKs remove AccessController class > TODO: Need a test framework modification to update this unit test: > https://github.com/apache/activemq/blob/e1bcbb9f3ec377367d1d72a21bfbff7410e33105/activemq-kahadb-store/src/test/java/org/apache/activemq/store/kahadb/JournalArchiveTest.java#L119 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5063) Addition of a messageMoved() callback in BrokerMessagePlugins
[ https://issues.apache.org/jira/browse/ARTEMIS-5063?focusedWorklogId=936408&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936408 ] ASF GitHub Bot logged work on ARTEMIS-5063: --- Author: ASF GitHub Bot Created on: 25/Sep/24 14:26 Start Date: 25/Sep/24 14:26 Worklog Time Spent: 10m Work Description: jpbriquet opened a new pull request, #5257: URL: https://github.com/apache/activemq-artemis/pull/5257 PR for https://issues.apache.org/jira/projects/ARTEMIS/issues/ARTEMIS-5063 Issue Time Tracking --- Worklog Id: (was: 936408) Remaining Estimate: 0h Time Spent: 10m > Addition of a messageMoved() callback in BrokerMessagePlugins > - > > Key: ARTEMIS-5063 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5063 > Project: ActiveMQ Artemis > Issue Type: New Feature > Components: Broker >Reporter: Jean-Pascal Briquet >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > The Addition of a messageMoved() callback in BrokerMessagePlugins would allow > the interception of message move events in custom plugins. > A typical use case would be to log details about these move operations. > > The callback would be triggered when a message move operation occurs within > Artemis. > The best location for this seems to be within the QueueImpl.move() method. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5066) Diverts should not be applied on mirror
[ https://issues.apache.org/jira/browse/ARTEMIS-5066?focusedWorklogId=936406&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936406 ] ASF GitHub Bot logged work on ARTEMIS-5066: --- Author: ASF GitHub Bot Created on: 25/Sep/24 14:14 Start Date: 25/Sep/24 14:14 Worklog Time Spent: 10m Work Description: clebertsuconic opened a new pull request, #5256: URL: https://github.com/apache/activemq-artemis/pull/5256 (no comment) Issue Time Tracking --- Worklog Id: (was: 936406) Remaining Estimate: 0h Time Spent: 10m > Diverts should not be applied on mirror > --- > > Key: ARTEMIS-5066 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5066 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.38.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Instead of applying Diverts on Mirror Target, we should just send the > operations after the fact. > Right now if you have a non exclusive divert, the messages will be > duplicated.. one from the afterSend event, another for the actual routing of > the divert on the targets resulting in messages that will not be removed from > the ACK Manager and duplicates. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5065) We should remove mirror properties for Core and OpenWire Protocols upon receiving them on the server
[ https://issues.apache.org/jira/browse/ARTEMIS-5065?focusedWorklogId=936404&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936404 ] ASF GitHub Bot logged work on ARTEMIS-5065: --- Author: ASF GitHub Bot Created on: 25/Sep/24 14:07 Start Date: 25/Sep/24 14:07 Worklog Time Spent: 10m Work Description: clebertsuconic opened a new pull request, #5255: URL: https://github.com/apache/activemq-artemis/pull/5255 (no comment) Issue Time Tracking --- Worklog Id: (was: 936404) Remaining Estimate: 0h Time Spent: 10m > We should remove mirror properties for Core and OpenWire Protocols upon > receiving them on the server > > > Key: ARTEMIS-5065 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5065 > Project: ActiveMQ Artemis > Issue Type: Bug >Reporter: Clebert Suconic >Assignee: Clebert Suconic >Priority: Major > Fix For: 2.38.0 > > Time Spent: 10m > Remaining Estimate: 0h > > say a consumer received a message from a target mirror using Core or OpenWire > Protocol. > The message will contain properties that would be hidden if using AMQP > Protocol. > Upon receiving them the server should remove them to avoid retagging them > with the older values. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4971) AckManager "giving up" processing of Acks in warning log level
[
https://issues.apache.org/jira/browse/ARTEMIS-4971?focusedWorklogId=936403&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936403
]
ASF GitHub Bot logged work on ARTEMIS-4971:
---
Author: ASF GitHub Bot
Created on: 25/Sep/24 13:52
Start Date: 25/Sep/24 13:52
Worklog Time Spent: 10m
Work Description: clebertsuconic merged PR #5251:
URL: https://github.com/apache/activemq-artemis/pull/5251
Issue Time Tracking
---
Worklog Id: (was: 936403)
Time Spent: 20m (was: 10m)
> AckManager "giving up" processing of Acks in warning log level
> --
>
> Key: ARTEMIS-4971
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4971
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP, Broker
>Affects Versions: 2.35.0, 2.36.0
>Reporter: Jean-Pascal Briquet
>Assignee: Clebert Suconic
>Priority: Minor
> Fix For: 2.38.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Within the AMQP AckManager, the following log message, currently at DEBUG
> level, should be increased to WARN level:
> {code:java}
> logger.debug("Retried {} {} times, giving up on the entry now", retry,
> retry.getPageAttempts());{code}
> Setting this log to WARN level would allow operators to be aware of two
> things:
> - The AckManager may require configuration tuning of queue/page attempts.
> This can easily occur with the default configuration when handling large
> messages.
> - Missed message replication, which is crucial when replication is required,
> allowing operators to investigate the source of the problem.
> The downside is that this change may trigger a large number of logs when
> enabled on Artemis nodes containing messages created before the mirroring
> configuration activation.
> This might not be desirable for everyone, so it could be beneficial to have
> it enabled as an optional parameter, configurable via a system environment
> variable, similar to the fine-tuning options available for AckManager.
> Ideally, the log should as well contain the queue name, which would allow to
> track down the source of messages.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5054) large messages only forwarded to one subscriber when using STOMP on multicast address
[
https://issues.apache.org/jira/browse/ARTEMIS-5054?focusedWorklogId=936395&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936395
]
ASF GitHub Bot logged work on ARTEMIS-5054:
---
Author: ASF GitHub Bot
Created on: 25/Sep/24 13:12
Start Date: 25/Sep/24 13:12
Worklog Time Spent: 10m
Work Description: gemmellr merged PR #5254:
URL: https://github.com/apache/activemq-artemis/pull/5254
Issue Time Tracking
---
Worklog Id: (was: 936395)
Time Spent: 1h (was: 50m)
> large messages only forwarded to one subscriber when using STOMP on multicast
> address
> -
>
> Key: ARTEMIS-5054
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5054
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: STOMP
>Affects Versions: 2.32.0, 2.33.0, 2.34.0, 2.35.0, 2.36.0, 2.37.0
>Reporter: Renaud Rwemalika
>Assignee: Timothy A. Bish
>Priority: Major
> Fix For: 2.38.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> We noticed a bug that affects versions after 2.31.2. When sending a large
> message using STOMP (in our use case, we used the stomp.py library from
> Python) on a MULTICAST address with multiple non-durable queues, we noticed
> that only one of the queues gets the message forwarded to it.
> Note that the issue does not appear with messages that are not flagged as
> large messages: all the queues get the message.
> We conducted our test using 20MB messages using the Docker image
> (docker.io/apache/activemq-artemis:2.37.0) without changing anything in the
> configuration.
> Sending a large message with STOMP on a MULTICAST queue generates the
> following in Artemis logs:
> {noformat}
> 2024-09-17 12:46:29,850 WARN
> [org.apache.activemq.artemis.core.protocol.stomp] AMQ332069: Sent ERROR frame
> to STOMP client 10.0.2.100:34400: null
> 2024-09-17 12:46:29,851 WARN [org.apache.activemq.artemis.core.server]
> AMQ222067: Connection failure has been detected: null [code=REMOTE_DISCONNECT]
> 2024-09-17 12:46:29,851 WARN [org.apache.activemq.artemis.core.server]
> AMQ222061: Client connection failed, clearing up resources for session
> dc1a3fc3-74f2-11ef-a9fa-caa03bc75f5c
> 2024-09-17 12:46:29,853 WARN [org.apache.activemq.artemis.core.server]
> AMQ222107: Cleared up resources for session
> dc1a3fc3-74f2-11ef-a9fa-caa03bc75f5c
> 2024-09-17 12:46:29,850 WARN
> [org.apache.activemq.artemis.core.protocol.stomp] AMQ332071: Unable to send
> message to client:
> LargeServerMessage[messageID=34,durable=false,userID=null,priority=4,
> timestamp=Tue Sep 17 12:46:29 UTC 2024,expiration=0, durable=false,
> address=simulation.results.inflated-dimensions,
> properties=TypedProperties[destination=simulation.results.inflated-dimensions,
> content-length=7057754, _AMQ_LARGE_SIZE=7057754]]@132459861
> java.lang.RuntimeException:
> ActiveMQIllegalStateException[errorType=ILLEGAL_STATE message=File 34.tmp has
> a null channel]
> at
> org.apache.activemq.artemis.core.persistence.impl.journal.LargeBody.getReadOnlyBodyBuffer(LargeBody.java:275)
> ~[artemis-server-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.persistence.impl.journal.LargeServerMessageImpl.getReadOnlyBodyBuffer(LargeServerMessageImpl.java:257)
> ~[artemis-server-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.protocol.stomp.VersionedStompFrameHandler.createMessageFrame(VersionedStompFrameHandler.java:334)
> ~[artemis-stomp-protocol-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.protocol.stomp.StompConnection.createStompMessage(StompConnection.java:630)
> ~[artemis-stomp-protocol-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.protocol.stomp.StompSession.sendMessage(StompSession.java:169)
> ~[artemis-stomp-protocol-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1215)
> ~[artemis-server-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:528)
> ~[artemis-server-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.server.impl.QueueImpl.proceedDeliver(QueueImpl.java:4091)
> ~[artemis-server-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:3325)
> ~[artemis-server-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:4459)
> ~[artemis-server-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:57)
> ~[artemis-commons-2.37.0.jar:2.37.0]
[jira] [Work logged] (ARTEMIS-5054) large messages only forwarded to one subscriber when using STOMP on multicast address
[
https://issues.apache.org/jira/browse/ARTEMIS-5054?focusedWorklogId=936383&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936383
]
ASF GitHub Bot logged work on ARTEMIS-5054:
---
Author: ASF GitHub Bot
Created on: 25/Sep/24 12:27
Start Date: 25/Sep/24 12:27
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #5254:
URL: https://github.com/apache/activemq-artemis/pull/5254#discussion_r1775134186
##
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/StompTest.java:
##
@@ -2120,4 +2120,54 @@ public void
testSameMessageHasDifferentMessageIdPerConsumer() throws Exception {
conn.disconnect();
}
+ @Test
+ public void testMultipleSubscriptionsOnMulticastAddressReadSameMessage()
throws Exception {
+ doTestMultipleSubscriptionsOnMulticastAddressReadSameMessage(10);
+ }
+
+ @Test
+ public void
testMultipleSubscriptionsOnMulticastAddressReadSameLargeMessage() throws
Exception {
+ doTestMultipleSubscriptionsOnMulticastAddressReadSameMessage(120_000);
+ }
+
+ private void
doTestMultipleSubscriptionsOnMulticastAddressReadSameMessage(int size) throws
Exception {
+ final String body = "A".repeat(size);
+
+ final StompClientConnection conn_r1 =
StompClientConnectionFactory.createClientConnection(uri);
+ final StompClientConnection conn_r2 =
StompClientConnectionFactory.createClientConnection(uri);
+
+ try {
+ conn_r1.connect(defUser, defPass);
+ subscribeTopic(conn_r1, null, null, null);
+
+ conn_r2.connect(defUser, defPass);
+ subscribeTopic(conn_r2, null, null, null);
+
+ // Sender
+ conn.connect(defUser, defPass);
+ send(conn, getTopicPrefix() + getTopicName(), null, body, true,
RoutingType.MULTICAST);
+
+ ClientStompFrame frame1 = conn_r1.receiveFrame(1);
+ ClientStompFrame frame2 = conn_r2.receiveFrame(1);
+
+ assertEquals(Stomp.Responses.MESSAGE, frame2.getCommand());
+ assertEquals(Stomp.Responses.MESSAGE, frame1.getCommand());
+
+ assertEquals(getTopicPrefix() + getTopicName(),
frame2.getHeader(Stomp.Headers.Send.DESTINATION));
+ assertEquals(getTopicPrefix() + getTopicName(),
frame1.getHeader(Stomp.Headers.Send.DESTINATION));
+
+ assertEquals(RoutingType.MULTICAST.toString(),
frame2.getHeader(Stomp.Headers.Send.DESTINATION_TYPE));
+ assertEquals(RoutingType.MULTICAST.toString(),
frame1.getHeader(Stomp.Headers.Send.DESTINATION_TYPE));
+
+
assertTrue(frame2.getHeader(org.apache.activemq.artemis.api.core.Message.HDR_ROUTING_TYPE.toString())
== null);
+
assertTrue(frame1.getHeader(org.apache.activemq.artemis.api.core.Message.HDR_ROUTING_TYPE.toString())
== null);
Review Comment:
Fixed
Issue Time Tracking
---
Worklog Id: (was: 936383)
Time Spent: 50m (was: 40m)
> large messages only forwarded to one subscriber when using STOMP on multicast
> address
> -
>
> Key: ARTEMIS-5054
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5054
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: STOMP
>Affects Versions: 2.32.0, 2.33.0, 2.34.0, 2.35.0, 2.36.0, 2.37.0
>Reporter: Renaud Rwemalika
>Assignee: Timothy A. Bish
>Priority: Major
> Fix For: 2.38.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> We noticed a bug that affects versions after 2.31.2. When sending a large
> message using STOMP (in our use case, we used the stomp.py library from
> Python) on a MULTICAST address with multiple non-durable queues, we noticed
> that only one of the queues gets the message forwarded to it.
> Note that the issue does not appear with messages that are not flagged as
> large messages: all the queues get the message.
> We conducted our test using 20MB messages using the Docker image
> (docker.io/apache/activemq-artemis:2.37.0) without changing anything in the
> configuration.
> Sending a large message with STOMP on a MULTICAST queue generates the
> following in Artemis logs:
> {noformat}
> 2024-09-17 12:46:29,850 WARN
> [org.apache.activemq.artemis.core.protocol.stomp] AMQ332069: Sent ERROR frame
> to STOMP client 10.0.2.100:34400: null
> 2024-09-17 12:46:29,851 WARN [org.apache.activemq.artemis.core.server]
> AMQ222067: Connection failure has been detected: null [code=REMOTE_DISCONNECT]
> 2024-09-17 12:46:29,851 WARN [org.apache.activemq.artemis.core.server]
> AMQ222061: Client connection failed, clearing up resources for session
> dc1a3fc3-74f2-11ef-a9fa-caa03bc75f5c
> 2024-09-17 12:46:29,853 WARN [org.apache.activemq.artemis.core.server]
>
[jira] [Work logged] (ARTEMIS-5054) large messages only forwarded to one subscriber when using STOMP on multicast address
[
https://issues.apache.org/jira/browse/ARTEMIS-5054?focusedWorklogId=936369&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936369
]
ASF GitHub Bot logged work on ARTEMIS-5054:
---
Author: ASF GitHub Bot
Created on: 25/Sep/24 11:47
Start Date: 25/Sep/24 11:47
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #5254:
URL: https://github.com/apache/activemq-artemis/pull/5254#discussion_r1774929556
##
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/stomp/StompTest.java:
##
@@ -2120,4 +2120,54 @@ public void
testSameMessageHasDifferentMessageIdPerConsumer() throws Exception {
conn.disconnect();
}
+ @Test
+ public void testMultipleSubscriptionsOnMulticastAddressReadSameMessage()
throws Exception {
+ doTestMultipleSubscriptionsOnMulticastAddressReadSameMessage(10);
+ }
+
+ @Test
+ public void
testMultipleSubscriptionsOnMulticastAddressReadSameLargeMessage() throws
Exception {
+ doTestMultipleSubscriptionsOnMulticastAddressReadSameMessage(120_000);
+ }
+
+ private void
doTestMultipleSubscriptionsOnMulticastAddressReadSameMessage(int size) throws
Exception {
+ final String body = "A".repeat(size);
+
+ final StompClientConnection conn_r1 =
StompClientConnectionFactory.createClientConnection(uri);
+ final StompClientConnection conn_r2 =
StompClientConnectionFactory.createClientConnection(uri);
+
+ try {
+ conn_r1.connect(defUser, defPass);
+ subscribeTopic(conn_r1, null, null, null);
+
+ conn_r2.connect(defUser, defPass);
+ subscribeTopic(conn_r2, null, null, null);
+
+ // Sender
+ conn.connect(defUser, defPass);
+ send(conn, getTopicPrefix() + getTopicName(), null, body, true,
RoutingType.MULTICAST);
+
+ ClientStompFrame frame1 = conn_r1.receiveFrame(1);
+ ClientStompFrame frame2 = conn_r2.receiveFrame(1);
+
+ assertEquals(Stomp.Responses.MESSAGE, frame2.getCommand());
+ assertEquals(Stomp.Responses.MESSAGE, frame1.getCommand());
+
+ assertEquals(getTopicPrefix() + getTopicName(),
frame2.getHeader(Stomp.Headers.Send.DESTINATION));
+ assertEquals(getTopicPrefix() + getTopicName(),
frame1.getHeader(Stomp.Headers.Send.DESTINATION));
+
+ assertEquals(RoutingType.MULTICAST.toString(),
frame2.getHeader(Stomp.Headers.Send.DESTINATION_TYPE));
+ assertEquals(RoutingType.MULTICAST.toString(),
frame1.getHeader(Stomp.Headers.Send.DESTINATION_TYPE));
+
+
assertTrue(frame2.getHeader(org.apache.activemq.artemis.api.core.Message.HDR_ROUTING_TYPE.toString())
== null);
+
assertTrue(frame1.getHeader(org.apache.activemq.artemis.api.core.Message.HDR_ROUTING_TYPE.toString())
== null);
Review Comment:
assertNull ?
Issue Time Tracking
---
Worklog Id: (was: 936369)
Time Spent: 40m (was: 0.5h)
> large messages only forwarded to one subscriber when using STOMP on multicast
> address
> -
>
> Key: ARTEMIS-5054
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5054
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: STOMP
>Affects Versions: 2.32.0, 2.33.0, 2.34.0, 2.35.0, 2.36.0, 2.37.0
>Reporter: Renaud Rwemalika
>Assignee: Timothy A. Bish
>Priority: Major
> Fix For: 2.38.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> We noticed a bug that affects versions after 2.31.2. When sending a large
> message using STOMP (in our use case, we used the stomp.py library from
> Python) on a MULTICAST address with multiple non-durable queues, we noticed
> that only one of the queues gets the message forwarded to it.
> Note that the issue does not appear with messages that are not flagged as
> large messages: all the queues get the message.
> We conducted our test using 20MB messages using the Docker image
> (docker.io/apache/activemq-artemis:2.37.0) without changing anything in the
> configuration.
> Sending a large message with STOMP on a MULTICAST queue generates the
> following in Artemis logs:
> {noformat}
> 2024-09-17 12:46:29,850 WARN
> [org.apache.activemq.artemis.core.protocol.stomp] AMQ332069: Sent ERROR frame
> to STOMP client 10.0.2.100:34400: null
> 2024-09-17 12:46:29,851 WARN [org.apache.activemq.artemis.core.server]
> AMQ222067: Connection failure has been detected: null [code=REMOTE_DISCONNECT]
> 2024-09-17 12:46:29,851 WARN [org.apache.activemq.artemis.core.server]
> AMQ222061: Client connection failed, clearing up resources for session
> dc1a3fc3-74f2-11ef-a9fa-caa03bc75f5c
> 2024-09-17 12:46:29,853 WARN [org.apache.activemq.artemis.core.ser
[jira] [Work logged] (ARTEMIS-5037) AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages
[
https://issues.apache.org/jira/browse/ARTEMIS-5037?focusedWorklogId=936367&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936367
]
ASF GitHub Bot logged work on ARTEMIS-5037:
---
Author: ASF GitHub Bot
Created on: 25/Sep/24 11:41
Start Date: 25/Sep/24 11:41
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #5220:
URL: https://github.com/apache/activemq-artemis/pull/5220#discussion_r1775020313
##
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/connect/AMQPSquareMirroringTest.java:
##
@@ -0,0 +1,282 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.tests.integration.amqp.connect;
+
+import javax.jms.Connection;
+import javax.jms.ConnectionFactory;
+import javax.jms.MessageConsumer;
+import javax.jms.MessageProducer;
+import javax.jms.Session;
+import javax.jms.TextMessage;
+
+import
org.apache.activemq.artemis.core.config.amqpBrokerConnectivity.AMQPBrokerConnectConfiguration;
+import
org.apache.activemq.artemis.core.config.amqpBrokerConnectivity.AMQPMirrorBrokerConnectionElement;
+import org.apache.activemq.artemis.core.server.ActiveMQServer;
+import org.apache.activemq.artemis.core.server.Queue;
+import
org.apache.activemq.artemis.tests.integration.amqp.AmqpClientTestSupport;
+import org.apache.activemq.artemis.tests.util.CFUtil;
+import org.apache.activemq.artemis.utils.Wait;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertNull;
+
+public class AMQPSquareMirroringTest extends AmqpClientTestSupport {
+
+ protected static final int AMQP_PORT_2 = 5673;
+ protected static final int AMQP_PORT_3 = 5674;
+ protected static final int AMQP_PORT_4 = 5675;
+
+ ActiveMQServer server_2;
+ ActiveMQServer server_3;
+ ActiveMQServer server_4;
+
+ @Override
+ protected ActiveMQServer createServer() throws Exception {
+ return createServer(AMQP_PORT, false);
+ }
+
+ protected String getConfiguredProtocols() {
+ return "AMQP,CORE,OPENWIRE";
+ }
+
+ @Test
+ public void testSquare() throws Exception {
+ server_2 = createServer(AMQP_PORT_2, false);
+ server_3 = createServer(AMQP_PORT_3, false);
+ server_4 = createServer(AMQP_PORT_4, false);
Review Comment:
I'd also try adding some testing using the ProtonJ2 test peers, rather than
all brokers, to validate and exercise the actual broker behaviour at the
protocol level. It gives a better accounting of what is really going on and
when it changes unexpectedly.
E.g it seems all but certain these brokers are currently forwarding around
mirrored acks for noForward messages they didn't originally mirror to begin
with, but this test will not notice that one way or the other. Similarly with
various other potentially unexpected behaviours that might occur.
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/PostOffice.java:
##
@@ -65,10 +65,14 @@ default void reloadAddressInfo(AddressInfo addressInfo)
throws Exception {
AddressInfo removeAddressInfo(SimpleString address, boolean force) throws
Exception;
+ AddressInfo removeAddressInfo(SimpleString address, boolean force, boolean
noForward) throws Exception;
Review Comment:
I think this would be the first main case of directly exposing mirroring
related config/behaviour directly into general APIs of post office and server
around addresses and queues. In some ways its the slightly more efficient way
to do this, though as adding/removing addresses and queues is usually a
relatively less frequent activity than e.g actual message transit I'm not sure
that slight efficiency is really a concern here. I'd try out alternatives that
dont need these specific APIs.
I was more expecting something like, or just actual usage of, the existing
mechanism already in place to let the mirroring decide not to send a given
mirrored message/comm
[jira] [Work logged] (ARTEMIS-5054) large messages only forwarded to one subscriber when using STOMP on multicast address
[
https://issues.apache.org/jira/browse/ARTEMIS-5054?focusedWorklogId=936235&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936235
]
ASF GitHub Bot logged work on ARTEMIS-5054:
---
Author: ASF GitHub Bot
Created on: 25/Sep/24 00:09
Start Date: 25/Sep/24 00:09
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on PR #5254:
URL:
https://github.com/apache/activemq-artemis/pull/5254#issuecomment-2372606261
ohh man.. Stomp and Large messages.. who would think about that combination
:)
Issue Time Tracking
---
Worklog Id: (was: 936235)
Time Spent: 0.5h (was: 20m)
> large messages only forwarded to one subscriber when using STOMP on multicast
> address
> -
>
> Key: ARTEMIS-5054
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5054
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: STOMP
>Affects Versions: 2.32.0, 2.33.0, 2.34.0, 2.35.0, 2.36.0, 2.37.0
>Reporter: Renaud Rwemalika
>Assignee: Timothy A. Bish
>Priority: Major
> Fix For: 2.38.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> We noticed a bug that affects versions after 2.31.2. When sending a large
> message using STOMP (in our use case, we used the stomp.py library from
> Python) on a MULTICAST address with multiple non-durable queues, we noticed
> that only one of the queues gets the message forwarded to it.
> Note that the issue does not appear with messages that are not flagged as
> large messages: all the queues get the message.
> We conducted our test using 20MB messages using the Docker image
> (docker.io/apache/activemq-artemis:2.37.0) without changing anything in the
> configuration.
> Sending a large message with STOMP on a MULTICAST queue generates the
> following in Artemis logs:
> {noformat}
> 2024-09-17 12:46:29,850 WARN
> [org.apache.activemq.artemis.core.protocol.stomp] AMQ332069: Sent ERROR frame
> to STOMP client 10.0.2.100:34400: null
> 2024-09-17 12:46:29,851 WARN [org.apache.activemq.artemis.core.server]
> AMQ222067: Connection failure has been detected: null [code=REMOTE_DISCONNECT]
> 2024-09-17 12:46:29,851 WARN [org.apache.activemq.artemis.core.server]
> AMQ222061: Client connection failed, clearing up resources for session
> dc1a3fc3-74f2-11ef-a9fa-caa03bc75f5c
> 2024-09-17 12:46:29,853 WARN [org.apache.activemq.artemis.core.server]
> AMQ222107: Cleared up resources for session
> dc1a3fc3-74f2-11ef-a9fa-caa03bc75f5c
> 2024-09-17 12:46:29,850 WARN
> [org.apache.activemq.artemis.core.protocol.stomp] AMQ332071: Unable to send
> message to client:
> LargeServerMessage[messageID=34,durable=false,userID=null,priority=4,
> timestamp=Tue Sep 17 12:46:29 UTC 2024,expiration=0, durable=false,
> address=simulation.results.inflated-dimensions,
> properties=TypedProperties[destination=simulation.results.inflated-dimensions,
> content-length=7057754, _AMQ_LARGE_SIZE=7057754]]@132459861
> java.lang.RuntimeException:
> ActiveMQIllegalStateException[errorType=ILLEGAL_STATE message=File 34.tmp has
> a null channel]
> at
> org.apache.activemq.artemis.core.persistence.impl.journal.LargeBody.getReadOnlyBodyBuffer(LargeBody.java:275)
> ~[artemis-server-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.persistence.impl.journal.LargeServerMessageImpl.getReadOnlyBodyBuffer(LargeServerMessageImpl.java:257)
> ~[artemis-server-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.protocol.stomp.VersionedStompFrameHandler.createMessageFrame(VersionedStompFrameHandler.java:334)
> ~[artemis-stomp-protocol-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.protocol.stomp.StompConnection.createStompMessage(StompConnection.java:630)
> ~[artemis-stomp-protocol-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.protocol.stomp.StompSession.sendMessage(StompSession.java:169)
> ~[artemis-stomp-protocol-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1215)
> ~[artemis-server-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:528)
> ~[artemis-server-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.server.impl.QueueImpl.proceedDeliver(QueueImpl.java:4091)
> ~[artemis-server-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:3325)
> ~[artemis-server-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:4459)
> ~[artemis-server-2.37.0.jar:2.37.0]
> at
> org.
[jira] [Work logged] (ARTEMIS-5054) large messages only forwarded to one subscriber when using STOMP on multicast address
[
https://issues.apache.org/jira/browse/ARTEMIS-5054?focusedWorklogId=936211&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936211
]
ASF GitHub Bot logged work on ARTEMIS-5054:
---
Author: ASF GitHub Bot
Created on: 24/Sep/24 20:18
Start Date: 24/Sep/24 20:18
Worklog Time Spent: 10m
Work Description: tabish121 commented on PR #5254:
URL:
https://github.com/apache/activemq-artemis/pull/5254#issuecomment-2372295183
Ran the full test suite on this change with no new failures
Issue Time Tracking
---
Worklog Id: (was: 936211)
Time Spent: 20m (was: 10m)
> large messages only forwarded to one subscriber when using STOMP on multicast
> address
> -
>
> Key: ARTEMIS-5054
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5054
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: STOMP
>Affects Versions: 2.32.0, 2.33.0, 2.34.0, 2.35.0, 2.36.0, 2.37.0
>Reporter: Renaud Rwemalika
>Assignee: Timothy A. Bish
>Priority: Major
> Fix For: 2.38.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We noticed a bug that affects versions after 2.31.2. When sending a large
> message using STOMP (in our use case, we used the stomp.py library from
> Python) on a MULTICAST address with multiple non-durable queues, we noticed
> that only one of the queues gets the message forwarded to it.
> Note that the issue does not appear with messages that are not flagged as
> large messages: all the queues get the message.
> We conducted our test using 20MB messages using the Docker image
> (docker.io/apache/activemq-artemis:2.37.0) without changing anything in the
> configuration.
> Sending a large message with STOMP on a MULTICAST queue generates the
> following in Artemis logs:
> {noformat}
> 2024-09-17 12:46:29,850 WARN
> [org.apache.activemq.artemis.core.protocol.stomp] AMQ332069: Sent ERROR frame
> to STOMP client 10.0.2.100:34400: null
> 2024-09-17 12:46:29,851 WARN [org.apache.activemq.artemis.core.server]
> AMQ222067: Connection failure has been detected: null [code=REMOTE_DISCONNECT]
> 2024-09-17 12:46:29,851 WARN [org.apache.activemq.artemis.core.server]
> AMQ222061: Client connection failed, clearing up resources for session
> dc1a3fc3-74f2-11ef-a9fa-caa03bc75f5c
> 2024-09-17 12:46:29,853 WARN [org.apache.activemq.artemis.core.server]
> AMQ222107: Cleared up resources for session
> dc1a3fc3-74f2-11ef-a9fa-caa03bc75f5c
> 2024-09-17 12:46:29,850 WARN
> [org.apache.activemq.artemis.core.protocol.stomp] AMQ332071: Unable to send
> message to client:
> LargeServerMessage[messageID=34,durable=false,userID=null,priority=4,
> timestamp=Tue Sep 17 12:46:29 UTC 2024,expiration=0, durable=false,
> address=simulation.results.inflated-dimensions,
> properties=TypedProperties[destination=simulation.results.inflated-dimensions,
> content-length=7057754, _AMQ_LARGE_SIZE=7057754]]@132459861
> java.lang.RuntimeException:
> ActiveMQIllegalStateException[errorType=ILLEGAL_STATE message=File 34.tmp has
> a null channel]
> at
> org.apache.activemq.artemis.core.persistence.impl.journal.LargeBody.getReadOnlyBodyBuffer(LargeBody.java:275)
> ~[artemis-server-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.persistence.impl.journal.LargeServerMessageImpl.getReadOnlyBodyBuffer(LargeServerMessageImpl.java:257)
> ~[artemis-server-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.protocol.stomp.VersionedStompFrameHandler.createMessageFrame(VersionedStompFrameHandler.java:334)
> ~[artemis-stomp-protocol-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.protocol.stomp.StompConnection.createStompMessage(StompConnection.java:630)
> ~[artemis-stomp-protocol-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.protocol.stomp.StompSession.sendMessage(StompSession.java:169)
> ~[artemis-stomp-protocol-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1215)
> ~[artemis-server-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:528)
> ~[artemis-server-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.server.impl.QueueImpl.proceedDeliver(QueueImpl.java:4091)
> ~[artemis-server-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:3325)
> ~[artemis-server-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:4459)
> ~[artemis-server-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.uti
[jira] [Work logged] (ARTEMIS-5054) large messages only forwarded to one subscriber when using STOMP on multicast address
[
https://issues.apache.org/jira/browse/ARTEMIS-5054?focusedWorklogId=936210&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936210
]
ASF GitHub Bot logged work on ARTEMIS-5054:
---
Author: ASF GitHub Bot
Created on: 24/Sep/24 20:15
Start Date: 24/Sep/24 20:15
Worklog Time Spent: 10m
Work Description: tabish121 opened a new pull request, #5254:
URL: https://github.com/apache/activemq-artemis/pull/5254
When converting a large server message to an outgoing STOMP frame the
converter is allowing unsafe concurrent access to the large message internals
which leads to failures on message deliver as the state is out of sync amongst
the dispatch threads.
Issue Time Tracking
---
Worklog Id: (was: 936210)
Remaining Estimate: 0h
Time Spent: 10m
> large messages only forwarded to one subscriber when using STOMP on multicast
> address
> -
>
> Key: ARTEMIS-5054
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5054
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: STOMP
>Affects Versions: 2.32.0, 2.33.0, 2.34.0, 2.35.0, 2.36.0, 2.37.0
>Reporter: Renaud Rwemalika
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.31.2
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> We noticed a bug that affects versions after 2.31.2. When sending a large
> message using STOMP (in our use case, we used the stomp.py library from
> Python) on a MULTICAST address with multiple non-durable queues, we noticed
> that only one of the queues gets the message forwarded to it.
> Note that the issue does not appear with messages that are not flagged as
> large messages: all the queues get the message.
> We conducted our test using 20MB messages using the Docker image
> (docker.io/apache/activemq-artemis:2.37.0) without changing anything in the
> configuration.
> Sending a large message with STOMP on a MULTICAST queue generates the
> following in Artemis logs:
> {noformat}
> 2024-09-17 12:46:29,850 WARN
> [org.apache.activemq.artemis.core.protocol.stomp] AMQ332069: Sent ERROR frame
> to STOMP client 10.0.2.100:34400: null
> 2024-09-17 12:46:29,851 WARN [org.apache.activemq.artemis.core.server]
> AMQ222067: Connection failure has been detected: null [code=REMOTE_DISCONNECT]
> 2024-09-17 12:46:29,851 WARN [org.apache.activemq.artemis.core.server]
> AMQ222061: Client connection failed, clearing up resources for session
> dc1a3fc3-74f2-11ef-a9fa-caa03bc75f5c
> 2024-09-17 12:46:29,853 WARN [org.apache.activemq.artemis.core.server]
> AMQ222107: Cleared up resources for session
> dc1a3fc3-74f2-11ef-a9fa-caa03bc75f5c
> 2024-09-17 12:46:29,850 WARN
> [org.apache.activemq.artemis.core.protocol.stomp] AMQ332071: Unable to send
> message to client:
> LargeServerMessage[messageID=34,durable=false,userID=null,priority=4,
> timestamp=Tue Sep 17 12:46:29 UTC 2024,expiration=0, durable=false,
> address=simulation.results.inflated-dimensions,
> properties=TypedProperties[destination=simulation.results.inflated-dimensions,
> content-length=7057754, _AMQ_LARGE_SIZE=7057754]]@132459861
> java.lang.RuntimeException:
> ActiveMQIllegalStateException[errorType=ILLEGAL_STATE message=File 34.tmp has
> a null channel]
> at
> org.apache.activemq.artemis.core.persistence.impl.journal.LargeBody.getReadOnlyBodyBuffer(LargeBody.java:275)
> ~[artemis-server-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.persistence.impl.journal.LargeServerMessageImpl.getReadOnlyBodyBuffer(LargeServerMessageImpl.java:257)
> ~[artemis-server-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.protocol.stomp.VersionedStompFrameHandler.createMessageFrame(VersionedStompFrameHandler.java:334)
> ~[artemis-stomp-protocol-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.protocol.stomp.StompConnection.createStompMessage(StompConnection.java:630)
> ~[artemis-stomp-protocol-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.protocol.stomp.StompSession.sendMessage(StompSession.java:169)
> ~[artemis-stomp-protocol-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1215)
> ~[artemis-server-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:528)
> ~[artemis-server-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.server.impl.QueueImpl.proceedDeliver(QueueImpl.java:4091)
> ~[artemis-server-2.37.0.jar:2.37.0]
> at
> org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:3325)
> ~[artemis-server
[jira] [Work logged] (AMQ-9579) Upgrade to maven-javadoc-plugin 3.10.0
[ https://issues.apache.org/jira/browse/AMQ-9579?focusedWorklogId=936177&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936177 ] ASF GitHub Bot logged work on AMQ-9579: --- Author: ASF GitHub Bot Created on: 24/Sep/24 16:38 Start Date: 24/Sep/24 16:38 Worklog Time Spent: 10m Work Description: jbonofre merged PR #1309: URL: https://github.com/apache/activemq/pull/1309 Issue Time Tracking --- Worklog Id: (was: 936177) Time Spent: 20m (was: 10m) > Upgrade to maven-javadoc-plugin 3.10.0 > -- > > Key: AMQ-9579 > URL: https://issues.apache.org/jira/browse/AMQ-9579 > Project: ActiveMQ Classic > Issue Type: Dependency upgrade >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.2.0, 5.18.6, 6.1.4 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9577) Upgrade to maven-enforcer-plugin 3.5.0
[ https://issues.apache.org/jira/browse/AMQ-9577?focusedWorklogId=936173&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936173 ] ASF GitHub Bot logged work on AMQ-9577: --- Author: ASF GitHub Bot Created on: 24/Sep/24 16:11 Start Date: 24/Sep/24 16:11 Worklog Time Spent: 10m Work Description: jbonofre merged PR #1307: URL: https://github.com/apache/activemq/pull/1307 Issue Time Tracking --- Worklog Id: (was: 936173) Time Spent: 20m (was: 10m) > Upgrade to maven-enforcer-plugin 3.5.0 > -- > > Key: AMQ-9577 > URL: https://issues.apache.org/jira/browse/AMQ-9577 > Project: ActiveMQ Classic > Issue Type: Dependency upgrade >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.2.0, 5.18.6, 6.1.4 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5062) ClusterConnectionControl has wrong annotation
[ https://issues.apache.org/jira/browse/ARTEMIS-5062?focusedWorklogId=936004&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936004 ] ASF GitHub Bot logged work on ARTEMIS-5062: --- Author: ASF GitHub Bot Created on: 24/Sep/24 06:57 Start Date: 24/Sep/24 06:57 Worklog Time Spent: 10m Work Description: gaohoward opened a new pull request, #5253: URL: https://github.com/apache/activemq-artemis/pull/5253 (no comment) Issue Time Tracking --- Worklog Id: (was: 936004) Remaining Estimate: 0h Time Spent: 10m > ClusterConnectionControl has wrong annotation > - > > Key: ARTEMIS-5062 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5062 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: management >Affects Versions: 2.37.0 >Reporter: Howard Gao >Assignee: Howard Gao >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The ClusterConnectionControl.getBridgeMetrics() method is annotated with > Attribute but it should be Operation. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4971) AckManager "giving up" processing of Acks in warning log level
[
https://issues.apache.org/jira/browse/ARTEMIS-4971?focusedWorklogId=935970&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935970
]
ASF GitHub Bot logged work on ARTEMIS-4971:
---
Author: ASF GitHub Bot
Created on: 23/Sep/24 23:55
Start Date: 23/Sep/24 23:55
Worklog Time Spent: 10m
Work Description: clebertsuconic opened a new pull request, #5251:
URL: https://github.com/apache/activemq-artemis/pull/5251
(no comment)
Issue Time Tracking
---
Worklog Id: (was: 935970)
Remaining Estimate: 0h
Time Spent: 10m
> AckManager "giving up" processing of Acks in warning log level
> --
>
> Key: ARTEMIS-4971
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4971
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP, Broker
>Affects Versions: 2.35.0, 2.36.0
>Reporter: Jean-Pascal Briquet
>Assignee: Clebert Suconic
>Priority: Minor
> Fix For: 2.38.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Within the AMQP AckManager, the following log message, currently at DEBUG
> level, should be increased to WARN level:
> {code:java}
> logger.debug("Retried {} {} times, giving up on the entry now", retry,
> retry.getPageAttempts());{code}
> Setting this log to WARN level would allow operators to be aware of two
> things:
> - The AckManager may require configuration tuning of queue/page attempts.
> This can easily occur with the default configuration when handling large
> messages.
> - Missed message replication, which is crucial when replication is required,
> allowing operators to investigate the source of the problem.
> The downside is that this change may trigger a large number of logs when
> enabled on Artemis nodes containing messages created before the mirroring
> configuration activation.
> This might not be desirable for everyone, so it could be beneficial to have
> it enabled as an optional parameter, configurable via a system environment
> variable, similar to the fine-tuning options available for AckManager.
> Ideally, the log should as well contain the queue name, which would allow to
> track down the source of messages.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9530) ClassCastException in SelectorAwareVirtualTopicInterceptor if there is another interceptor
[
https://issues.apache.org/jira/browse/AMQ-9530?focusedWorklogId=935969&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935969
]
ASF GitHub Bot logged work on AMQ-9530:
---
Author: ASF GitHub Bot
Created on: 23/Sep/24 23:53
Start Date: 23/Sep/24 23:53
Worklog Time Spent: 10m
Work Description: Nikita-Shupletsov commented on code in PR #1247:
URL: https://github.com/apache/activemq/pull/1247#discussion_r1772350011
##
activemq-broker/src/main/java/org/apache/activemq/broker/region/virtual/BaseVirtualDestinationFilter.java:
##
@@ -0,0 +1,23 @@
+package org.apache.activemq.broker.region.virtual;
+
+import org.apache.activemq.broker.region.BaseDestination;
+import org.apache.activemq.broker.region.Destination;
+import org.apache.activemq.broker.region.DestinationFilter;
+
+import java.util.Optional;
+
+public class BaseVirtualDestinationFilter extends DestinationFilter {
+
+public BaseVirtualDestinationFilter(Destination next) {
+super(next);
+}
+
+Optional getBaseDestination(Destination virtualDest) {
Review Comment:
Done!
Issue Time Tracking
---
Worklog Id: (was: 935969)
Time Spent: 2h (was: 1h 50m)
> ClassCastException in SelectorAwareVirtualTopicInterceptor if there is
> another interceptor
> ---
>
> Key: AMQ-9530
> URL: https://issues.apache.org/jira/browse/AMQ-9530
> Project: ActiveMQ Classic
> Issue Type: Bug
> Components: Plugin
>Reporter: Nikita Shupletsov
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Fix For: 6.2.0, 6.1.4, 5.18.7
>
> Attachments:
> SelectorAwareVirtualTopicInterceptor_ClassCastException_test.patch
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> See the patch in the attachment that shows how to reproduce the issue.
>
> The stacktrace:
> {{jakarta.jms.JMSException: class
> org.apache.activemq.broker.region.DestinationFilter cannot be cast to class
> org.apache.activemq.broker.region.Topic
> (org.apache.activemq.broker.region.DestinationFilter and
> org.apache.activemq.broker.region.Topic are in unnamed module of loader
> 'app')}}{{ at
> org.apache.activemq.util.JMSExceptionSupport.create(JMSExceptionSupport.java:67)}}
> {{ at
> org.apache.activemq.ActiveMQConnection.syncSendPacket(ActiveMQConnection.java:1465)}}
> {{ at
> org.apache.activemq.ActiveMQConnection.ensureConnectionInfoSent(ActiveMQConnection.java:1548)}}
> {{ at
> org.apache.activemq.ActiveMQConnection.start(ActiveMQConnection.java:568)}}
> {{ at
> org.apache.activemq.broker.virtual.CompositeQueueTest.testVirtualTopicCreation(CompositeQueueTest.java:59)}}
> {{ at
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)}}
> {{ at java.base/java.lang.reflect.Method.invoke(Method.java:580)}}
> {{ at junit.framework.TestCase.runTest(TestCase.java:177)}}
> {{ at junit.framework.TestCase.runBare(TestCase.java:142)}}
> {{ at
> org.apache.activemq.CombinationTestSupport.runBare(CombinationTestSupport.java:107)}}
> {{ at
> org.apache.activemq.CombinationTestSupport.runBare(CombinationTestSupport.java:113)}}
> {{ at junit.framework.TestResult$1.protect(TestResult.java:122)}}
> {{ at junit.framework.TestResult.runProtected(TestResult.java:142)}}
> {{ at junit.framework.TestResult.run(TestResult.java:125)}}
> {{ at junit.framework.TestCase.run(TestCase.java:130)}}
> {{ at junit.framework.TestSuite.runTest(TestSuite.java:241)}}
> {{ at junit.framework.TestSuite.run(TestSuite.java:236)}}
> {{ at
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:90)}}
> {{ at org.junit.runner.JUnitCore.run(JUnitCore.java:137)}}
> {{ at
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)}}
> {{ at
> com.intellij.rt.junit.IdeaTestRunner$Repeater$1.execute(IdeaTestRunner.java:38)}}
> {{ at
> com.intellij.rt.execution.junit.TestsRepeater.repeat(TestsRepeater.java:11)}}
> {{ at
> com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:35)}}
> {{ at
> com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:232)}}
> {{ at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:55)}}
> {{Caused by: java.lang.ClassCastException: class
> org.apache.activemq.broker.region.DestinationFilter cannot be cast to class
> org.apache.activemq.broker.region.Topic
> (org.apache.activemq.broker.region.DestinationFilter and
> org.apache.activemq.broker.region.Topic are in unnamed module of loader
> 'app')}}
> {{ at
> org.apache.activemq.broker.region.virtual.SelectorAwareVirtualTopicInte
[jira] [Work logged] (ARTEMIS-5042) The load balancing is not working correctly when several brokers are down
[ https://issues.apache.org/jira/browse/ARTEMIS-5042?focusedWorklogId=935924&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935924 ] ASF GitHub Bot logged work on ARTEMIS-5042: --- Author: ASF GitHub Bot Created on: 23/Sep/24 19:30 Start Date: 23/Sep/24 19:30 Worklog Time Spent: 10m Work Description: tabish121 merged PR #5246: URL: https://github.com/apache/activemq-artemis/pull/5246 Issue Time Tracking --- Worklog Id: (was: 935924) Time Spent: 40m (was: 0.5h) > The load balancing is not working correctly when several brokers are down > - > > Key: ARTEMIS-5042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5042 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Balancer >Affects Versions: 2.35.0 > Environment: Cluster Configuration broker.xml: > > > > 6 > 5000 > 500 > 1.0 > 5000 > -1 > -1 > false > artemis > ON_DEMAND > 1 > > node0 > node1 > node2 > > > > >Reporter: Juanjo Marin >Assignee: Justin Bertram >Priority: Major > Attachments: 1NodoUp.PNG, 1nodeUp.PNG, 3NodesUp.PNG, 3Nodosup.PNG, > ArtemisInternalWithMessage.PNG, EmptysQueue.PNG, > QueueInternWithMessageNoConsumer.PNG, artemis.log, broker.xml > > Time Spent: 40m > Remaining Estimate: 0h > > The load balancing is not working correctly when several brokers are down. > With the configuration we have in the cluster, we understand that this should > not be happening. The load balancing should be smart and not send messages to > the nodes that are down." -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5042) The load balancing is not working correctly when several brokers are down
[
https://issues.apache.org/jira/browse/ARTEMIS-5042?focusedWorklogId=935922&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935922
]
ASF GitHub Bot logged work on ARTEMIS-5042:
---
Author: ASF GitHub Bot
Created on: 23/Sep/24 19:12
Start Date: 23/Sep/24 19:12
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #5246:
URL: https://github.com/apache/activemq-artemis/pull/5246#discussion_r1771953251
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java:
##
@@ -1621,4 +1621,7 @@ void
noQueueIdDefined(org.apache.activemq.artemis.api.core.Message message,
@LogMessage(id = 224139, value = "Failed to stop bridge: {}", level =
LogMessage.Level.ERROR)
void errorStoppingBridge(String bridgeName, Exception e);
+
+ @LogMessage(id = 224140, value = "Clearing bindings on cluster-connection
{} failed to remove binding {}: {}", level = LogMessage.Level.WARN)
+ void clusterConnectionFailedToRemovingBindingOnClear(String
clusterConnection, String binding, String exceptionMessage);
Review Comment:
Fixed.
Issue Time Tracking
---
Worklog Id: (was: 935922)
Time Spent: 0.5h (was: 20m)
> The load balancing is not working correctly when several brokers are down
> -
>
> Key: ARTEMIS-5042
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5042
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Balancer
>Affects Versions: 2.35.0
> Environment: Cluster Configuration broker.xml:
>
>
>
> 6
> 5000
> 500
> 1.0
> 5000
> -1
> -1
> false
> artemis
> ON_DEMAND
> 1
>
> node0
> node1
> node2
>
>
>
>
>Reporter: Juanjo Marin
>Assignee: Justin Bertram
>Priority: Major
> Attachments: 1NodoUp.PNG, 1nodeUp.PNG, 3NodesUp.PNG, 3Nodosup.PNG,
> ArtemisInternalWithMessage.PNG, EmptysQueue.PNG,
> QueueInternWithMessageNoConsumer.PNG, artemis.log, broker.xml
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The load balancing is not working correctly when several brokers are down.
> With the configuration we have in the cluster, we understand that this should
> not be happening. The load balancing should be smart and not send messages to
> the nodes that are down."
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9563) Refactor code to remove deprecated AccessController and SecurityManager
[ https://issues.apache.org/jira/browse/AMQ-9563?focusedWorklogId=935918&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935918 ] ASF GitHub Bot logged work on AMQ-9563: --- Author: ASF GitHub Bot Created on: 23/Sep/24 18:46 Start Date: 23/Sep/24 18:46 Worklog Time Spent: 10m Work Description: mattrpav commented on PR #1296: URL: https://github.com/apache/activemq/pull/1296#issuecomment-2369093740 > > I'd be in favor of changing the level here to a WARN or ERROR. Perhaps best as a follow-on for 7.x to not break any existing log capture? > > We should probably just change it in 6.2.0 or 6.3.0 etc, because with removing the security check it's pretty unlikely to fail. And without the security check if it does fail there's probably something much more serious going on if you can't check a system roperty, so I would think logging it as a WARN level would make sense and maybe in 7.x actually throw an exception. A quick check confirmed that the logger only exists for these two log messages, it may be better to get rid of the logger completely in 7.x and throw an exception? 1. Merge this as-is in 6.2.0 (Leave log level alone) 2. Remove logger in 7.x and throw an exception Issue Time Tracking --- Worklog Id: (was: 935918) Time Spent: 40m (was: 0.5h) > Refactor code to remove deprecated AccessController and SecurityManager > --- > > Key: AMQ-9563 > URL: https://issues.apache.org/jira/browse/AMQ-9563 > Project: ActiveMQ Classic > Issue Type: Task >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Major > Fix For: 6.2.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Future JDKs remove AccessController class > TODO: Need a test framework modification to update this unit test: > https://github.com/apache/activemq/blob/e1bcbb9f3ec377367d1d72a21bfbff7410e33105/activemq-kahadb-store/src/test/java/org/apache/activemq/store/kahadb/JournalArchiveTest.java#L119 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9552) StatisticsPlugin - add metric lastMessageTimestamp
[
https://issues.apache.org/jira/browse/AMQ-9552?focusedWorklogId=935917&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935917
]
ASF GitHub Bot logged work on AMQ-9552:
---
Author: ASF GitHub Bot
Created on: 23/Sep/24 18:38
Start Date: 23/Sep/24 18:38
Worklog Time Spent: 10m
Work Description: mattrpav commented on code in PR #1285:
URL: https://github.com/apache/activemq/pull/1285#discussion_r1771914221
##
activemq-broker/src/main/java/org/apache/activemq/plugin/StatisticsBroker.java:
##
@@ -160,6 +160,11 @@ else if (dest instanceof Topic) {
tempFirstMessage.clear();
}
}
+if ( stats.getEnqueues().hasUpdated() ) {
+// NOTICE: Client-side, you may get the broker
"now" Timestamp by msg.getJMSTimestamp()
+// This allows for calculating inactivity.
+statsMessage.setLong("lastMessageTimestamp",
stats.getEnqueues().getLastSampleTime());
Review Comment:
@ggkochanski The field naming is a broader conversation. The full scope is
not one field as you have in this PR. We currently have a number of metrics
(and config params) that are not fully aligned in naming convention, so I would
press for an organized approach for these new metrics.
Related JIRAs:
ref: https://issues.apache.org/jira/browse/AMQ-4358
ref: https://issues.apache.org/jira/browse/AMQ-5497
Issue Time Tracking
---
Worklog Id: (was: 935917)
Time Spent: 1h 10m (was: 1h)
> StatisticsPlugin - add metric lastMessageTimestamp
> --
>
> Key: AMQ-9552
> URL: https://issues.apache.org/jira/browse/AMQ-9552
> Project: ActiveMQ Classic
> Issue Type: Improvement
> Components: Broker
>Reporter: Grzegorz Kochański
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Metric {{lastMessageTimestamp}} can be captured from the modification time of
> metric {{enqueues:}}
>
> {code:java}
> statsMessage.setLong("lastMessageTimestamp",
> stats.getEnqueues().getLastSampleTime()); {code}
>
> Disclaimer: disadvantage of such approach is that after broker restart this
> value is holding start time of the broker (which may be relevant when the
> frequency of broker restarts is comparable to the frequency of enqueued
> messages)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5042) The load balancing is not working correctly when several brokers are down
[
https://issues.apache.org/jira/browse/ARTEMIS-5042?focusedWorklogId=935916&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935916
]
ASF GitHub Bot logged work on ARTEMIS-5042:
---
Author: ASF GitHub Bot
Created on: 23/Sep/24 18:37
Start Date: 23/Sep/24 18:37
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #5246:
URL: https://github.com/apache/activemq-artemis/pull/5246#discussion_r1771912709
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java:
##
@@ -1621,4 +1621,7 @@ void
noQueueIdDefined(org.apache.activemq.artemis.api.core.Message message,
@LogMessage(id = 224139, value = "Failed to stop bridge: {}", level =
LogMessage.Level.ERROR)
void errorStoppingBridge(String bridgeName, Exception e);
+
+ @LogMessage(id = 224140, value = "Clearing bindings on cluster-connection
{} failed to remove binding {}: {}", level = LogMessage.Level.WARN)
+ void clusterConnectionFailedToRemovingBindingOnClear(String
clusterConnection, String binding, String exceptionMessage);
Review Comment:
I'd feel clusterConnectionFailedToRemoveBindingOnClear would be more
grammatically correct
Issue Time Tracking
---
Worklog Id: (was: 935916)
Time Spent: 20m (was: 10m)
> The load balancing is not working correctly when several brokers are down
> -
>
> Key: ARTEMIS-5042
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5042
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Balancer
>Affects Versions: 2.35.0
> Environment: Cluster Configuration broker.xml:
>
>
>
> 6
> 5000
> 500
> 1.0
> 5000
> -1
> -1
> false
> artemis
> ON_DEMAND
> 1
>
> node0
> node1
> node2
>
>
>
>
>Reporter: Juanjo Marin
>Assignee: Justin Bertram
>Priority: Major
> Attachments: 1NodoUp.PNG, 1nodeUp.PNG, 3NodesUp.PNG, 3Nodosup.PNG,
> ArtemisInternalWithMessage.PNG, EmptysQueue.PNG,
> QueueInternWithMessageNoConsumer.PNG, artemis.log, broker.xml
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The load balancing is not working correctly when several brokers are down.
> With the configuration we have in the cluster, we understand that this should
> not be happening. The load balancing should be smart and not send messages to
> the nodes that are down."
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9563) Refactor code to remove deprecated AccessController and SecurityManager
[ https://issues.apache.org/jira/browse/AMQ-9563?focusedWorklogId=935915&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935915 ] ASF GitHub Bot logged work on AMQ-9563: --- Author: ASF GitHub Bot Created on: 23/Sep/24 18:27 Start Date: 23/Sep/24 18:27 Worklog Time Spent: 10m Work Description: cshannon commented on PR #1296: URL: https://github.com/apache/activemq/pull/1296#issuecomment-2369052745 > I'd be in favor of changing the level here to a WARN or ERROR. Perhaps best as a follow-on for 7.x to not break any existing log capture? We should probably just change it in 6.2.0 or 6.3.0 etc, because with removing the security check it's pretty unlikely to fail. And without the security check if it does fail there's probably something much more serious going on if you can't check a system roperty, so I would think logging it as a WARN level would make sense and maybe in 7.x actually throw an exception. Issue Time Tracking --- Worklog Id: (was: 935915) Time Spent: 0.5h (was: 20m) > Refactor code to remove deprecated AccessController and SecurityManager > --- > > Key: AMQ-9563 > URL: https://issues.apache.org/jira/browse/AMQ-9563 > Project: ActiveMQ Classic > Issue Type: Task >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Major > Fix For: 6.2.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Future JDKs remove AccessController class > TODO: Need a test framework modification to update this unit test: > https://github.com/apache/activemq/blob/e1bcbb9f3ec377367d1d72a21bfbff7410e33105/activemq-kahadb-store/src/test/java/org/apache/activemq/store/kahadb/JournalArchiveTest.java#L119 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9563) Refactor code to remove deprecated AccessController and SecurityManager
[ https://issues.apache.org/jira/browse/AMQ-9563?focusedWorklogId=935914&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935914 ] ASF GitHub Bot logged work on AMQ-9563: --- Author: ASF GitHub Bot Created on: 23/Sep/24 18:20 Start Date: 23/Sep/24 18:20 Worklog Time Spent: 10m Work Description: mattrpav commented on PR #1296: URL: https://github.com/apache/activemq/pull/1296#issuecomment-2369038246 @cshannon Good point. I had opted to leave the logging level alone. If there were an exception, it would be a SecurityException (in future JDKs this will cease to be a code path), NPE, or some fatal RuntimeException like OOM, interrupted, etc. I'd be in favor of changing the level here to a WARN or ERROR. Perhaps best as a follow-on for 7.x? Issue Time Tracking --- Worklog Id: (was: 935914) Time Spent: 20m (was: 10m) > Refactor code to remove deprecated AccessController and SecurityManager > --- > > Key: AMQ-9563 > URL: https://issues.apache.org/jira/browse/AMQ-9563 > Project: ActiveMQ Classic > Issue Type: Task >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Major > Fix For: 6.2.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Future JDKs remove AccessController class > TODO: Need a test framework modification to update this unit test: > https://github.com/apache/activemq/blob/e1bcbb9f3ec377367d1d72a21bfbff7410e33105/activemq-kahadb-store/src/test/java/org/apache/activemq/store/kahadb/JournalArchiveTest.java#L119 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-1962) "HA: failover-on-server-shutdown" documentation wrong or incomplete
[ https://issues.apache.org/jira/browse/ARTEMIS-1962?focusedWorklogId=935905&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935905 ] ASF GitHub Bot logged work on ARTEMIS-1962: --- Author: ASF GitHub Bot Created on: 23/Sep/24 17:29 Start Date: 23/Sep/24 17:29 Worklog Time Spent: 10m Work Description: jbertram opened a new pull request, #5250: URL: https://github.com/apache/activemq-artemis/pull/5250 (no comment) Issue Time Tracking --- Worklog Id: (was: 935905) Remaining Estimate: 0h Time Spent: 10m > "HA: failover-on-server-shutdown" documentation wrong or incomplete > --- > > Key: ARTEMIS-1962 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1962 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.6.2 >Reporter: Johan Stenberg >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > The HA documentation at > [https://activemq.apache.org/artemis/docs/latest/ha.html] seems to contain > errors regarding the "failover-on-server-shutdown" feature. > # The text talks about an option named *failover-on-server-shutdown* but the > code uses *true* > # The documentation suggests that the *failover-on-server-shutdown* option > only exists for ** but e.g. not for **. Looking at > the configuration XSD *failover-on-server-shutdown* is only defined for > ** elements and not for ** elements used by > **. So it remains unclear where the > *failover-on-server-shutdown* actually can be used and if for example in case > of ** it can/must also be specified. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-1962) "HA: failover-on-server-shutdown" documentation wrong or incomplete
[ https://issues.apache.org/jira/browse/ARTEMIS-1962?focusedWorklogId=935906&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935906 ] ASF GitHub Bot logged work on ARTEMIS-1962: --- Author: ASF GitHub Bot Created on: 23/Sep/24 17:29 Start Date: 23/Sep/24 17:29 Worklog Time Spent: 10m Work Description: jbertram merged PR #5250: URL: https://github.com/apache/activemq-artemis/pull/5250 Issue Time Tracking --- Worklog Id: (was: 935906) Time Spent: 20m (was: 10m) > "HA: failover-on-server-shutdown" documentation wrong or incomplete > --- > > Key: ARTEMIS-1962 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1962 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.6.2 >Reporter: Johan Stenberg >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > The HA documentation at > [https://activemq.apache.org/artemis/docs/latest/ha.html] seems to contain > errors regarding the "failover-on-server-shutdown" feature. > # The text talks about an option named *failover-on-server-shutdown* but the > code uses *true* > # The documentation suggests that the *failover-on-server-shutdown* option > only exists for ** but e.g. not for **. Looking at > the configuration XSD *failover-on-server-shutdown* is only defined for > ** elements and not for ** elements used by > **. So it remains unclear where the > *failover-on-server-shutdown* actually can be used and if for example in case > of ** it can/must also be specified. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5038) Mirror ACKs are broken if using multiple priorities
[
https://issues.apache.org/jira/browse/ARTEMIS-5038?focusedWorklogId=935902&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935902
]
ASF GitHub Bot logged work on ARTEMIS-5038:
---
Author: ASF GitHub Bot
Created on: 23/Sep/24 16:45
Start Date: 23/Sep/24 16:45
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #5221:
URL: https://github.com/apache/activemq-artemis/pull/5221#discussion_r1771683716
##
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/FileUtil.java:
##
@@ -126,4 +133,21 @@ public static boolean findReplace(File file, String find,
String replace) throws
}
}
+ public static String readFile(InputStream inputStream) throws Exception {
+ BufferedReader bufferedReader = new BufferedReader(new
InputStreamReader(inputStream));
+ String fileOutput =
bufferedReader.lines().collect(Collectors.joining(System.lineSeparator()));
+ return fileOutput;
+ }
+
+ public static boolean find(File file, Predicate search) throws
Exception {
+ AtomicBoolean found = new AtomicBoolean(false);
+ try (Stream lines = Files.lines(file.toPath())) {
+ lines.filter(search::test).findFirst().ifPresent(line -> {
+logger.info("pattern found at {}", line);
Review Comment:
Should this be info level given this is in artemis-commons?
Also, should the method be in artemis-commons at all given it is only used
in a test util?
##
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/PriorityLinkedListImpl.java:
##
@@ -40,6 +41,10 @@ public class PriorityLinkedListImpl implements
PriorityLinkedList {
private int lastPriority = -1;
+ protected void removed(final int level, final E element) {
+ exclusiveIncrementSize(-1);
+ }
Review Comment:
Is this new method just for debugging? It doesnt seem to use either of the
arguments, which seems odd given in one case new field tracking was added just
to pass it.
##
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/LinkedListIterator.java:
##
@@ -27,6 +27,9 @@ public interface LinkedListIterator extends Iterator,
AutoCloseable {
void repeat();
+ /** This method is doing exactly what {@link Iterator#remove()} would do,
however it will return the removed element being removed. */
+ E removeLastElement();
Review Comment:
removeLastElement() seems ambiguous. If its the same as remove(), which
operates on the _current_ element in most Iterators, something like
removeCurrentElement() element would probably be more straightforward for later
users. Or something much more on the nose like removeAndReturn().
##
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/LinkedListImpl.java:
##
@@ -599,23 +599,33 @@ public E next() {
@Override
public void remove() {
+ removeLastElement();
+ }
+
+ @Override
+ public E removeLastElement() {
Review Comment:
This doesnt seem like it satisfies the requirement to throw
IllegalStateException if the method is called again before next() is called
again.
Though I cant really follow what it actually does given it maintains 'last'
inside next() and yet then only removes based on 'current', both of which are
seemingly updated separately, including by other iterators 'nudges'?
##
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java:
##
@@ -3070,6 +3053,11 @@ private void internalAddSorted(final MessageReference
ref) {
}
private int getPriority(MessageReference ref) {
+ if (isInternalQueue()) {
+ // if it's an internal queue we need to send the events on their
original ordering
+ // for example an ACK arriving before the send on a Mirror..
+ return 4;
+ }
Review Comment:
Is this true of _all_ such queues? They arent all for mirroring.
##
tests/soak-tests/src/test/java/org/apache/activemq/artemis/tests/soak/brokerConnection/mirror/LogAssert.java:
##
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the Licens
[jira] [Work logged] (ARTEMIS-5061) Bump org.jline:jline from 3.26.3 to 3.27.0
[ https://issues.apache.org/jira/browse/ARTEMIS-5061?focusedWorklogId=935901&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935901 ] ASF GitHub Bot logged work on ARTEMIS-5061: --- Author: ASF GitHub Bot Created on: 23/Sep/24 16:44 Start Date: 23/Sep/24 16:44 Worklog Time Spent: 10m Work Description: jbertram merged PR #5249: URL: https://github.com/apache/activemq-artemis/pull/5249 Issue Time Tracking --- Worklog Id: (was: 935901) Time Spent: 20m (was: 10m) > Bump org.jline:jline from 3.26.3 to 3.27.0 > -- > > Key: ARTEMIS-5061 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5061 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5061) Bump org.jline:jline from 3.26.3 to 3.27.0
[ https://issues.apache.org/jira/browse/ARTEMIS-5061?focusedWorklogId=935900&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935900 ] ASF GitHub Bot logged work on ARTEMIS-5061: --- Author: ASF GitHub Bot Created on: 23/Sep/24 16:44 Start Date: 23/Sep/24 16:44 Worklog Time Spent: 10m Work Description: jbertram opened a new pull request, #5249: URL: https://github.com/apache/activemq-artemis/pull/5249 (no comment) Issue Time Tracking --- Worklog Id: (was: 935900) Remaining Estimate: 0h Time Spent: 10m > Bump org.jline:jline from 3.26.3 to 3.27.0 > -- > > Key: ARTEMIS-5061 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5061 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5060) Bump selenium.version from 4.24.0 to 4.25.0
[ https://issues.apache.org/jira/browse/ARTEMIS-5060?focusedWorklogId=935898&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935898 ] ASF GitHub Bot logged work on ARTEMIS-5060: --- Author: ASF GitHub Bot Created on: 23/Sep/24 16:41 Start Date: 23/Sep/24 16:41 Worklog Time Spent: 10m Work Description: jbertram merged PR #5248: URL: https://github.com/apache/activemq-artemis/pull/5248 Issue Time Tracking --- Worklog Id: (was: 935898) Time Spent: 20m (was: 10m) > Bump selenium.version from 4.24.0 to 4.25.0 > --- > > Key: ARTEMIS-5060 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5060 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5060) Bump selenium.version from 4.24.0 to 4.25.0
[ https://issues.apache.org/jira/browse/ARTEMIS-5060?focusedWorklogId=935897&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935897 ] ASF GitHub Bot logged work on ARTEMIS-5060: --- Author: ASF GitHub Bot Created on: 23/Sep/24 16:40 Start Date: 23/Sep/24 16:40 Worklog Time Spent: 10m Work Description: jbertram opened a new pull request, #5248: URL: https://github.com/apache/activemq-artemis/pull/5248 (no comment) Issue Time Tracking --- Worklog Id: (was: 935897) Remaining Estimate: 0h Time Spent: 10m > Bump selenium.version from 4.24.0 to 4.25.0 > --- > > Key: ARTEMIS-5060 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5060 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5059) Bump commons-io:commons-io from 2.16.1 to 2.17.0
[ https://issues.apache.org/jira/browse/ARTEMIS-5059?focusedWorklogId=935895&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935895 ] ASF GitHub Bot logged work on ARTEMIS-5059: --- Author: ASF GitHub Bot Created on: 23/Sep/24 16:38 Start Date: 23/Sep/24 16:38 Worklog Time Spent: 10m Work Description: jbertram merged PR #5247: URL: https://github.com/apache/activemq-artemis/pull/5247 Issue Time Tracking --- Worklog Id: (was: 935895) Time Spent: 20m (was: 10m) > Bump commons-io:commons-io from 2.16.1 to 2.17.0 > > > Key: ARTEMIS-5059 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5059 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5059) Bump commons-io:commons-io from 2.16.1 to 2.17.0
[ https://issues.apache.org/jira/browse/ARTEMIS-5059?focusedWorklogId=935894&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935894 ] ASF GitHub Bot logged work on ARTEMIS-5059: --- Author: ASF GitHub Bot Created on: 23/Sep/24 16:37 Start Date: 23/Sep/24 16:37 Worklog Time Spent: 10m Work Description: jbertram opened a new pull request, #5247: URL: https://github.com/apache/activemq-artemis/pull/5247 (no comment) Issue Time Tracking --- Worklog Id: (was: 935894) Remaining Estimate: 0h Time Spent: 10m > Bump commons-io:commons-io from 2.16.1 to 2.17.0 > > > Key: ARTEMIS-5059 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5059 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5037) AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages
[
https://issues.apache.org/jira/browse/ARTEMIS-5037?focusedWorklogId=935890&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935890
]
ASF GitHub Bot logged work on ARTEMIS-5037:
---
Author: ASF GitHub Bot
Created on: 23/Sep/24 16:00
Start Date: 23/Sep/24 16:00
Worklog Time Spent: 10m
Work Description: lavocatt commented on code in PR #5220:
URL: https://github.com/apache/activemq-artemis/pull/5220#discussion_r1771722983
##
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/connect/AMQPSquareMirroringTest.java:
##
@@ -0,0 +1,278 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.tests.integration.amqp.connect;
+
+import javax.jms.Connection;
+import javax.jms.ConnectionFactory;
+import javax.jms.MessageConsumer;
+import javax.jms.MessageProducer;
+import javax.jms.Session;
+import javax.jms.TextMessage;
+
+import
org.apache.activemq.artemis.core.config.amqpBrokerConnectivity.AMQPBrokerConnectConfiguration;
+import
org.apache.activemq.artemis.core.config.amqpBrokerConnectivity.AMQPMirrorBrokerConnectionElement;
+import org.apache.activemq.artemis.core.server.ActiveMQServer;
+import org.apache.activemq.artemis.core.server.Queue;
+import
org.apache.activemq.artemis.tests.integration.amqp.AmqpClientTestSupport;
+import org.apache.activemq.artemis.tests.util.CFUtil;
+import org.apache.activemq.artemis.utils.Wait;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertNull;
+
+public class AMQPSquareMirroringTest extends AmqpClientTestSupport {
+
+ protected static final int AMQP_PORT_2 = 5673;
+ protected static final int AMQP_PORT_3 = 5674;
+ protected static final int AMQP_PORT_4 = 5675;
+
+ ActiveMQServer server_2;
+ ActiveMQServer server_3;
+ ActiveMQServer server_4;
+
+ @Override
+ protected ActiveMQServer createServer() throws Exception {
+ return createServer(AMQP_PORT, false);
+ }
+
+ @Test
+ public void testSquare() throws Exception {
+ server_2 = createServer(AMQP_PORT_2, false);
+ server_3 = createServer(AMQP_PORT_3, false);
+ server_4 = createServer(AMQP_PORT_4, false);
+
+ // name the servers, for convenience during debugging
+ server.getConfiguration().setName("1");
+ server_2.getConfiguration().setName("2");
+ server_3.getConfiguration().setName("3");
+ server_4.getConfiguration().setName("4");
+
+ /**
+ *
+ * Setup the mirroring topology to be a square:
+ *
+ * 1 <- - -> 2
+ * ^ ^ The link between 1 and 2 and the
+ * | | link between 3 and 4 are noForward
+ * v v links in both directions.
+ * 4 <- - -> 3
+ */
+
+ {
+ AMQPBrokerConnectConfiguration amqpConnection = new
AMQPBrokerConnectConfiguration(getTestMethodName() + "1to2", "tcp://localhost:"
+ AMQP_PORT_2).setRetryInterval(100);
+ amqpConnection.addElement(new
AMQPMirrorBrokerConnectionElement().setCanForwardMessages(false));
+ server.getConfiguration().addAMQPConnection(amqpConnection);
+ amqpConnection = new
AMQPBrokerConnectConfiguration(getTestMethodName() + "1to4", "tcp://localhost:"
+ AMQP_PORT_4).setRetryInterval(100);
+ amqpConnection.addElement(new AMQPMirrorBrokerConnectionElement());
+ server.getConfiguration().addAMQPConnection(amqpConnection);
+ }
+
+ {
+ AMQPBrokerConnectConfiguration amqpConnection = new
AMQPBrokerConnectConfiguration(getTestMethodName() + "2to1", "tcp://localhost:"
+ AMQP_PORT).setRetryInterval(100);
+ amqpConnection.addElement(new
AMQPMirrorBrokerConnectionElement().setCanForwardMessages(false));
+ server_2.getConfiguration().addAMQPConnection(amqpConnection);
+ amqpConnection = new
AMQPBrokerConnectConfiguration(getTestMethodName() + "2to3", "tcp://localhost:"
+ AMQP_PORT_3).setRetryInterval(100);
+
[jira] [Work logged] (AMQ-9574) Upgrade to commons-io 2.17.0
[ https://issues.apache.org/jira/browse/AMQ-9574?focusedWorklogId=935891&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935891 ] ASF GitHub Bot logged work on AMQ-9574: --- Author: ASF GitHub Bot Created on: 23/Sep/24 16:01 Start Date: 23/Sep/24 16:01 Worklog Time Spent: 10m Work Description: jbonofre merged PR #1305: URL: https://github.com/apache/activemq/pull/1305 Issue Time Tracking --- Worklog Id: (was: 935891) Time Spent: 20m (was: 10m) > Upgrade to commons-io 2.17.0 > > > Key: AMQ-9574 > URL: https://issues.apache.org/jira/browse/AMQ-9574 > Project: ActiveMQ Classic > Issue Type: Dependency upgrade > Components: Broker >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.2.0, 5.18.6, 6.1.4 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5042) The load balancing is not working correctly when several brokers are down
[ https://issues.apache.org/jira/browse/ARTEMIS-5042?focusedWorklogId=935888&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935888 ] ASF GitHub Bot logged work on ARTEMIS-5042: --- Author: ASF GitHub Bot Created on: 23/Sep/24 15:49 Start Date: 23/Sep/24 15:49 Worklog Time Spent: 10m Work Description: jbertram opened a new pull request, #5246: URL: https://github.com/apache/activemq-artemis/pull/5246 Throwing an exception when clearing the bindings when a cluster-connection is closed short-circuits the clearing (and closing) process. This commit fixes that by simply logging the failure to clear and continues on. No new tests are added with this commit. It relies on existing tests. Issue Time Tracking --- Worklog Id: (was: 935888) Remaining Estimate: 0h Time Spent: 10m > The load balancing is not working correctly when several brokers are down > - > > Key: ARTEMIS-5042 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5042 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Balancer >Affects Versions: 2.35.0 > Environment: Cluster Configuration broker.xml: > > > > 6 > 5000 > 500 > 1.0 > 5000 > -1 > -1 > false > artemis > ON_DEMAND > 1 > > node0 > node1 > node2 > > > > >Reporter: Juanjo Marin >Assignee: Justin Bertram >Priority: Major > Attachments: 1NodoUp.PNG, 1nodeUp.PNG, 3NodesUp.PNG, 3Nodosup.PNG, > ArtemisInternalWithMessage.PNG, EmptysQueue.PNG, > QueueInternWithMessageNoConsumer.PNG, artemis.log, broker.xml > > Time Spent: 10m > Remaining Estimate: 0h > > The load balancing is not working correctly when several brokers are down. > With the configuration we have in the cluster, we understand that this should > not be happening. The load balancing should be smart and not send messages to > the nodes that are down." -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5038) Mirror ACKs are broken if using multiple priorities
[ https://issues.apache.org/jira/browse/ARTEMIS-5038?focusedWorklogId=935886&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935886 ] ASF GitHub Bot logged work on ARTEMIS-5038: --- Author: ASF GitHub Bot Created on: 23/Sep/24 15:48 Start Date: 23/Sep/24 15:48 Worklog Time Spent: 10m Work Description: clebertsuconic merged PR #5221: URL: https://github.com/apache/activemq-artemis/pull/5221 Issue Time Tracking --- Worklog Id: (was: 935886) Time Spent: 1h 10m (was: 1h) > Mirror ACKs are broken if using multiple priorities > --- > > Key: ARTEMIS-5038 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5038 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.37.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.38.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5037) AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages
[
https://issues.apache.org/jira/browse/ARTEMIS-5037?focusedWorklogId=935883&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935883
]
ASF GitHub Bot logged work on ARTEMIS-5037:
---
Author: ASF GitHub Bot
Created on: 23/Sep/24 15:41
Start Date: 23/Sep/24 15:41
Worklog Time Spent: 10m
Work Description: lavocatt commented on code in PR #5220:
URL: https://github.com/apache/activemq-artemis/pull/5220#discussion_r1771695026
##
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerTarget.java:
##
@@ -248,6 +253,13 @@ public AMQPMirrorControllerTarget(AMQPSessionCallback
sessionSPI,
this.configuration = server.getConfiguration();
this.referenceNodeStore =
sessionSPI.getProtocolManager().getReferenceIDSupplier();
mirrorContext = protonSession.getSessionSPI().getSessionContext();
+ if (receiver.getRemoteDesiredCapabilities() != null) {
+ for (Symbol capability : receiver.getRemoteDesiredCapabilities()) {
+if (capability == NO_FORWARD) {
+ this.canForwardMessages = false;
+}
Review Comment:
This is done now :slightly_smiling_face:
Issue Time Tracking
---
Worklog Id: (was: 935883)
Time Spent: 2h 20m (was: 2h 10m)
> AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages
> ---
>
> Key: ARTEMIS-5037
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5037
> Project: ActiveMQ Artemis
> Issue Type: Bug
>Reporter: Thomas Lavocat
>Assignee: Thomas Lavocat
>Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> AMQ Broker Mirroring: One to Many - avoid the infinite loop of the messages:
> if we have a->b-c->a..
> a message will circulate forever in the mirrors
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5055) AIO not detected in official Ubuntu Docker image
[
https://issues.apache.org/jira/browse/ARTEMIS-5055?focusedWorklogId=935875&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935875
]
ASF GitHub Bot logged work on ARTEMIS-5055:
---
Author: ASF GitHub Bot
Created on: 23/Sep/24 14:50
Start Date: 23/Sep/24 14:50
Worklog Time Spent: 10m
Work Description: clebertsuconic merged PR #5241:
URL: https://github.com/apache/activemq-artemis/pull/5241
Issue Time Tracking
---
Worklog Id: (was: 935875)
Time Spent: 20m (was: 10m)
> AIO not detected in official Ubuntu Docker image
>
>
> Key: ARTEMIS-5055
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5055
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Image
>Affects Versions: 2.36.0, 2.37.0
>Reporter: William Sperlazza
>Assignee: Justin Bertram
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Ubuntu changed their libaio package name as was addressed
> [here|https://github.com/apache/activemq-artemis/commit/86f36e95b09c709fb7e4af33f4a535f9a80d7221].
>
> But the native {{LibaioContext}} link is still referencing {{libaio.so.1}},
> as seen in startup logs with debug enabled:
> {noformat}
> 2024-09-18 15:40:43,807 DEBUG
> [org.apache.activemq.artemis.nativo.jlibaio.LibaioContext] artemis-native-64
> -> not possible to load native library
> java.lang.UnsatisfiedLinkError:
> /opt/activemq-artemis/bin/lib/linux-x86_64/libartemis-native-64.so:
> libaio.so.1: cannot open shared object file: No such file or directory{quote}
> I think the link created
> [here|https://github.com/apache/activemq-artemis-native/blob/02ad87f08395993ae417ce75bf8ce78a3bc23e0a/src/main/c/CMakeLists.txt#L80C1-L80C22]
> is stale, and a simple rebuild of artemis-native may be all that's needed?
> Maybe the [dockerfile needs updating
> there|https://github.com/apache/activemq-artemis-native/blob/02ad87f08395993ae417ce75bf8ce78a3bc23e0a/src/main/docker/Dockerfile-ubuntu#L36]
> too though.{noformat}
> NOTE: This only affects the Ubuntu image. Alpine is fine.
> The workaround is to either use the official Alpine image instead, or create
> a symlink to the old library name in a Dockerfile based on the official image:
> {noformat}
> RUN ln -s /lib/x86_64-linux-gnu/libaio.so.1t64
> /lib/x86_64-linux-gnu/libaio.so.1{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5055) AIO not detected in official Ubuntu Docker image
[
https://issues.apache.org/jira/browse/ARTEMIS-5055?focusedWorklogId=935879&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935879
]
ASF GitHub Bot logged work on ARTEMIS-5055:
---
Author: ASF GitHub Bot
Created on: 23/Sep/24 14:55
Start Date: 23/Sep/24 14:55
Worklog Time Spent: 10m
Work Description: jbertram commented on PR #5241:
URL:
https://github.com/apache/activemq-artemis/pull/5241#issuecomment-2368536152
I figure we'll do another release pretty soon so I don't think that's
necessary.
Issue Time Tracking
---
Worklog Id: (was: 935879)
Time Spent: 40m (was: 0.5h)
> AIO not detected in official Ubuntu Docker image
>
>
> Key: ARTEMIS-5055
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5055
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Image
>Affects Versions: 2.36.0, 2.37.0
>Reporter: William Sperlazza
>Assignee: Justin Bertram
>Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Ubuntu changed their libaio package name as was addressed
> [here|https://github.com/apache/activemq-artemis/commit/86f36e95b09c709fb7e4af33f4a535f9a80d7221].
>
> But the native {{LibaioContext}} link is still referencing {{libaio.so.1}},
> as seen in startup logs with debug enabled:
> {noformat}
> 2024-09-18 15:40:43,807 DEBUG
> [org.apache.activemq.artemis.nativo.jlibaio.LibaioContext] artemis-native-64
> -> not possible to load native library
> java.lang.UnsatisfiedLinkError:
> /opt/activemq-artemis/bin/lib/linux-x86_64/libartemis-native-64.so:
> libaio.so.1: cannot open shared object file: No such file or directory{quote}
> I think the link created
> [here|https://github.com/apache/activemq-artemis-native/blob/02ad87f08395993ae417ce75bf8ce78a3bc23e0a/src/main/c/CMakeLists.txt#L80C1-L80C22]
> is stale, and a simple rebuild of artemis-native may be all that's needed?
> Maybe the [dockerfile needs updating
> there|https://github.com/apache/activemq-artemis-native/blob/02ad87f08395993ae417ce75bf8ce78a3bc23e0a/src/main/docker/Dockerfile-ubuntu#L36]
> too though.{noformat}
> NOTE: This only affects the Ubuntu image. Alpine is fine.
> The workaround is to either use the official Alpine image instead, or create
> a symlink to the old library name in a Dockerfile based on the official image:
> {noformat}
> RUN ln -s /lib/x86_64-linux-gnu/libaio.so.1t64
> /lib/x86_64-linux-gnu/libaio.so.1{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5055) AIO not detected in official Ubuntu Docker image
[
https://issues.apache.org/jira/browse/ARTEMIS-5055?focusedWorklogId=935876&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935876
]
ASF GitHub Bot logged work on ARTEMIS-5055:
---
Author: ASF GitHub Bot
Created on: 23/Sep/24 14:50
Start Date: 23/Sep/24 14:50
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on PR #5241:
URL:
https://github.com/apache/activemq-artemis/pull/5241#issuecomment-2368521895
@jbertram should we redo the tag?
Issue Time Tracking
---
Worklog Id: (was: 935876)
Time Spent: 0.5h (was: 20m)
> AIO not detected in official Ubuntu Docker image
>
>
> Key: ARTEMIS-5055
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5055
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Image
>Affects Versions: 2.36.0, 2.37.0
>Reporter: William Sperlazza
>Assignee: Justin Bertram
>Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Ubuntu changed their libaio package name as was addressed
> [here|https://github.com/apache/activemq-artemis/commit/86f36e95b09c709fb7e4af33f4a535f9a80d7221].
>
> But the native {{LibaioContext}} link is still referencing {{libaio.so.1}},
> as seen in startup logs with debug enabled:
> {noformat}
> 2024-09-18 15:40:43,807 DEBUG
> [org.apache.activemq.artemis.nativo.jlibaio.LibaioContext] artemis-native-64
> -> not possible to load native library
> java.lang.UnsatisfiedLinkError:
> /opt/activemq-artemis/bin/lib/linux-x86_64/libartemis-native-64.so:
> libaio.so.1: cannot open shared object file: No such file or directory{quote}
> I think the link created
> [here|https://github.com/apache/activemq-artemis-native/blob/02ad87f08395993ae417ce75bf8ce78a3bc23e0a/src/main/c/CMakeLists.txt#L80C1-L80C22]
> is stale, and a simple rebuild of artemis-native may be all that's needed?
> Maybe the [dockerfile needs updating
> there|https://github.com/apache/activemq-artemis-native/blob/02ad87f08395993ae417ce75bf8ce78a3bc23e0a/src/main/docker/Dockerfile-ubuntu#L36]
> too though.{noformat}
> NOTE: This only affects the Ubuntu image. Alpine is fine.
> The workaround is to either use the official Alpine image instead, or create
> a symlink to the old library name in a Dockerfile based on the official image:
> {noformat}
> RUN ln -s /lib/x86_64-linux-gnu/libaio.so.1t64
> /lib/x86_64-linux-gnu/libaio.so.1{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9585) Upgrade to taglist-maven-plugin 3.1.0
[ https://issues.apache.org/jira/browse/AMQ-9585?focusedWorklogId=935863&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935863 ] ASF GitHub Bot logged work on AMQ-9585: --- Author: ASF GitHub Bot Created on: 23/Sep/24 13:58 Start Date: 23/Sep/24 13:58 Worklog Time Spent: 10m Work Description: jbonofre opened a new pull request, #1315: URL: https://github.com/apache/activemq/pull/1315 (no comment) Issue Time Tracking --- Worklog Id: (was: 935863) Remaining Estimate: 0h Time Spent: 10m > Upgrade to taglist-maven-plugin 3.1.0 > - > > Key: AMQ-9585 > URL: https://issues.apache.org/jira/browse/AMQ-9585 > Project: ActiveMQ Classic > Issue Type: Dependency upgrade >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.2.0, 5.18.6, 6.1.4 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9584) Upgrade to javacc-maven-plugin 3.1.0
[ https://issues.apache.org/jira/browse/AMQ-9584?focusedWorklogId=935862&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935862 ] ASF GitHub Bot logged work on AMQ-9584: --- Author: ASF GitHub Bot Created on: 23/Sep/24 13:56 Start Date: 23/Sep/24 13:56 Worklog Time Spent: 10m Work Description: jbonofre opened a new pull request, #1314: URL: https://github.com/apache/activemq/pull/1314 (no comment) Issue Time Tracking --- Worklog Id: (was: 935862) Remaining Estimate: 0h Time Spent: 10m > Upgrade to javacc-maven-plugin 3.1.0 > > > Key: AMQ-9584 > URL: https://issues.apache.org/jira/browse/AMQ-9584 > Project: ActiveMQ Classic > Issue Type: Dependency upgrade >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.2.0, 5.18.6, 6.1.4 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9583) Upgrade to build-helper-maven-plugin 3.6.0
[ https://issues.apache.org/jira/browse/AMQ-9583?focusedWorklogId=935860&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935860 ] ASF GitHub Bot logged work on AMQ-9583: --- Author: ASF GitHub Bot Created on: 23/Sep/24 13:54 Start Date: 23/Sep/24 13:54 Worklog Time Spent: 10m Work Description: jbonofre opened a new pull request, #1313: URL: https://github.com/apache/activemq/pull/1313 (no comment) Issue Time Tracking --- Worklog Id: (was: 935860) Remaining Estimate: 0h Time Spent: 10m > Upgrade to build-helper-maven-plugin 3.6.0 > -- > > Key: AMQ-9583 > URL: https://issues.apache.org/jira/browse/AMQ-9583 > Project: ActiveMQ Classic > Issue Type: Dependency upgrade >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.2.0, 5.18.6, 6.1.4 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9582) Upgrade to maven-surefire-plugin 3.5.0
[ https://issues.apache.org/jira/browse/AMQ-9582?focusedWorklogId=935858&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935858 ] ASF GitHub Bot logged work on AMQ-9582: --- Author: ASF GitHub Bot Created on: 23/Sep/24 13:53 Start Date: 23/Sep/24 13:53 Worklog Time Spent: 10m Work Description: jbonofre opened a new pull request, #1312: URL: https://github.com/apache/activemq/pull/1312 (no comment) Issue Time Tracking --- Worklog Id: (was: 935858) Remaining Estimate: 0h Time Spent: 10m > Upgrade to maven-surefire-plugin 3.5.0 > -- > > Key: AMQ-9582 > URL: https://issues.apache.org/jira/browse/AMQ-9582 > Project: ActiveMQ Classic > Issue Type: Dependency upgrade >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.2.0, 5.18.6, 6.1.4 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9581) Upgrade to maven-release-plugin 3.1.1
[ https://issues.apache.org/jira/browse/AMQ-9581?focusedWorklogId=935856&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935856 ] ASF GitHub Bot logged work on AMQ-9581: --- Author: ASF GitHub Bot Created on: 23/Sep/24 13:45 Start Date: 23/Sep/24 13:45 Worklog Time Spent: 10m Work Description: jbonofre opened a new pull request, #1311: URL: https://github.com/apache/activemq/pull/1311 (no comment) Issue Time Tracking --- Worklog Id: (was: 935856) Remaining Estimate: 0h Time Spent: 10m > Upgrade to maven-release-plugin 3.1.1 > - > > Key: AMQ-9581 > URL: https://issues.apache.org/jira/browse/AMQ-9581 > Project: ActiveMQ Classic > Issue Type: Dependency upgrade >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.2.0, 5.18.6, 6.1.4 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9580) Upgrade to maven-project-info-reports-plugin 3.7.0
[ https://issues.apache.org/jira/browse/AMQ-9580?focusedWorklogId=935852&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935852 ] ASF GitHub Bot logged work on AMQ-9580: --- Author: ASF GitHub Bot Created on: 23/Sep/24 13:23 Start Date: 23/Sep/24 13:23 Worklog Time Spent: 10m Work Description: jbonofre opened a new pull request, #1310: URL: https://github.com/apache/activemq/pull/1310 (no comment) Issue Time Tracking --- Worklog Id: (was: 935852) Remaining Estimate: 0h Time Spent: 10m > Upgrade to maven-project-info-reports-plugin 3.7.0 > -- > > Key: AMQ-9580 > URL: https://issues.apache.org/jira/browse/AMQ-9580 > Project: ActiveMQ Classic > Issue Type: Dependency upgrade >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.2.0, 5.18.6, 6.1.4 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9576) Upgrade to maven-clean-plugin 3.4.0
[ https://issues.apache.org/jira/browse/AMQ-9576?focusedWorklogId=935843&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935843 ] ASF GitHub Bot logged work on AMQ-9576: --- Author: ASF GitHub Bot Created on: 23/Sep/24 12:54 Start Date: 23/Sep/24 12:54 Worklog Time Spent: 10m Work Description: jbonofre merged PR #1306: URL: https://github.com/apache/activemq/pull/1306 Issue Time Tracking --- Worklog Id: (was: 935843) Time Spent: 20m (was: 10m) > Upgrade to maven-clean-plugin 3.4.0 > --- > > Key: AMQ-9576 > URL: https://issues.apache.org/jira/browse/AMQ-9576 > Project: ActiveMQ Classic > Issue Type: Dependency upgrade >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.2.0, 5.18.6, 6.1.4 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9579) Upgrade to maven-javadoc-plugin 3.10.0
[ https://issues.apache.org/jira/browse/AMQ-9579?focusedWorklogId=935823&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935823 ] ASF GitHub Bot logged work on AMQ-9579: --- Author: ASF GitHub Bot Created on: 23/Sep/24 11:56 Start Date: 23/Sep/24 11:56 Worklog Time Spent: 10m Work Description: jbonofre opened a new pull request, #1309: URL: https://github.com/apache/activemq/pull/1309 (no comment) Issue Time Tracking --- Worklog Id: (was: 935823) Remaining Estimate: 0h Time Spent: 10m > Upgrade to maven-javadoc-plugin 3.10.0 > -- > > Key: AMQ-9579 > URL: https://issues.apache.org/jira/browse/AMQ-9579 > Project: ActiveMQ Classic > Issue Type: Dependency upgrade >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.2.0, 5.18.6, 6.1.4 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-8049) Failed to start Apache ActiveMQ (mKahaDB / JMX)
[
https://issues.apache.org/jira/browse/AMQ-8049?focusedWorklogId=935815&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935815
]
ASF GitHub Bot logged work on AMQ-8049:
---
Author: ASF GitHub Bot
Created on: 23/Sep/24 11:00
Start Date: 23/Sep/24 11:00
Worklog Time Spent: 10m
Work Description: lraczko closed pull request #984: AMQ-8049: Failed to
start Apache ActiveMQ (mKahaDB / JMX)
URL: https://github.com/apache/activemq/pull/984
Issue Time Tracking
---
Worklog Id: (was: 935815)
Time Spent: 1.5h (was: 1h 20m)
> Failed to start Apache ActiveMQ (mKahaDB / JMX)
> ---
>
> Key: AMQ-8049
> URL: https://issues.apache.org/jira/browse/AMQ-8049
> Project: ActiveMQ Classic
> Issue Type: Bug
> Components: Broker
>Affects Versions: 5.15.12
> Environment: - Ubuntu 18.04.4 LTS (x86_64, server)
> - OpenJDK 11.0.7 (64-Bit Server VM)
> - ActiveMQ 5.15.12 (vanilla; tar.gz)
>Reporter: Guillermo Grandes
>Assignee: Jean-Baptiste Onofré
>Priority: Major
> Fix For: 6.0.0, 5.18.4, 5.17.7
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Summary:
> {noformat}
> 2020-10-06 15:02:03,889 | ERROR | Failed to start Apache ActiveMQ (localhost,
> null) | org.apache.activemq.broker.BrokerService | main
> javax.management.InstanceAlreadyExistsException:
> org.apache.activemq:type=Broker,brokerName=localhost,service=PersistenceAdapter,instanceName=KahaDBPersistenceAdapter[/opt/activemq/data/kahadb/queue#3a#2f#2fActiveMQ.#3e_Index_/opt/activemq/data/kahadb/queue#3a#2f#2fActiveMQ.#3e]
> {noformat}
> This is the full-log (start-to-fail-and-shutdown):
> {code:none}
> 2020-10-06 15:01:58,507 | INFO | Refreshing
> org.apache.activemq.xbean.XBeanBrokerFactory$1@56620197: startup date [Tue
> Oct 06 15:01:58 CEST 2020]; root of context hierarchy |
> org.apache.activemq.xbean.XBeanBrokerFactory$1 | main
> 2020-10-06 15:02:02,417 | INFO | Using Persistence Adapter:
> MultiKahaDBPersistenceAdapter[/opt/activemq/data/kahadb][KahaDBPersistenceAdapter[/opt/activemq/data/kahadb/queue#3a#2f#2fActiveMQ.#3e],
>
> KahaDBPersistenceAdapter[/opt/activemq/data/kahadb/topic#3a#2f#2fActiveMQ.#3e]]
> | org.apache.activemq.broker.BrokerService | main
> 2020-10-06 15:02:02,638 | INFO | KahaDB is version 6 |
> org.apache.activemq.store.kahadb.MessageDatabase | main
> 2020-10-06 15:02:02,823 | INFO | KahaDB is version 6 |
> org.apache.activemq.store.kahadb.MessageDatabase | main
> 2020-10-06 15:02:02,978 | INFO | KahaDB is version 6 |
> org.apache.activemq.store.kahadb.MessageDatabase | main
> 2020-10-06 15:02:03,007 | INFO | Stopping async queue tasks |
> org.apache.activemq.store.kahadb.KahaDBStore | main
> 2020-10-06 15:02:03,010 | INFO | Stopping async topic tasks |
> org.apache.activemq.store.kahadb.KahaDBStore | main
> 2020-10-06 15:02:03,095 | INFO | Stopped KahaDB |
> org.apache.activemq.store.kahadb.KahaDBStore | main
> 2020-10-06 15:02:03,257 | INFO | KahaDB is version 6 |
> org.apache.activemq.store.kahadb.MessageDatabase | main
> 2020-10-06 15:02:03,480 | INFO | KahaDB is version 6 |
> org.apache.activemq.store.kahadb.MessageDatabase | main
> 2020-10-06 15:02:03,575 | INFO | KahaDB is version 6 |
> org.apache.activemq.store.kahadb.MessageDatabase | main
> 2020-10-06 15:02:03,681 | INFO | KahaDB is version 6 |
> org.apache.activemq.store.kahadb.MessageDatabase | main
> 2020-10-06 15:02:03,798 | INFO | KahaDB is version 6 |
> org.apache.activemq.store.kahadb.MessageDatabase | main
> 2020-10-06 15:02:03,851 | INFO | KahaDB is version 6 |
> org.apache.activemq.store.kahadb.MessageDatabase | main
> 2020-10-06 15:02:03,859 | INFO | Page File:
> /opt/activemq/data/kahadb/queue#3a#2f#2fActiveMQ.#3e/db.data. Recovering
> pageFile free list due to prior unclean shutdown.. |
> org.apache.activemq.store.kahadb.disk.page.PageFile | KahaDB Index Free Page
> Recovery
> 2020-10-06 15:02:03,889 | ERROR | Failed to start Apache ActiveMQ (localhost,
> null) | org.apache.activemq.broker.BrokerService | main
> javax.management.InstanceAlreadyExistsException:
> org.apache.activemq:type=Broker,brokerName=localhost,service=PersistenceAdapter,instanceName=KahaDBPersistenceAdapter[/opt/activemq/data/kahadb/queue#3a#2f#2fActiveMQ.#3e_Index_/opt/activemq/data/kahadb/queue#3a#2f#2fActiveMQ.#3e]
> at
> java.management/com.sun.jmx.mbeanserver.Repository.addMBean(Repository.java:436)[:]
> at
> java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerWithRepository(DefaultMBeanServerInterceptor.java:1855)[:]
> at
> java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerDynamicMBean(DefaultMBeanServerInterceptor.java:955)[:]
> at
> jav
[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4
[ https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=935796&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935796 ] ASF GitHub Bot logged work on ARTEMIS-4680: --- Author: ASF GitHub Bot Created on: 23/Sep/24 09:30 Start Date: 23/Sep/24 09:30 Worklog Time Spent: 10m Work Description: gemmellr merged PR #32: URL: https://github.com/apache/activemq-artemis-console/pull/32 Issue Time Tracking --- Worklog Id: (was: 935796) Time Spent: 15h 10m (was: 15h) > Upgrade the console to use HawtIO 4 > --- > > Key: ARTEMIS-4680 > URL: https://issues.apache.org/jira/browse/ARTEMIS-4680 > Project: ActiveMQ Artemis > Issue Type: Improvement > Components: Web Console >Reporter: Andy Taylor >Assignee: Andy Taylor >Priority: Major > Fix For: console-1.0.0 > > Time Spent: 15h 10m > Remaining Estimate: 0h > > The current console is based upon HawtIO 1 which in turn is built on > Bootstrap. Bootstrap is old and no longer actively being maintained. > > This improvement is to migrate the current console to use HawtIO 4 which i > based on Typescript, react and Patternfly. > > As it can run standalone and be built seperately, this will be released > independently from [https://github.com/apache/activemq-artemis-console] and > the output later consumed in Artemis releases (similar to artemis-native). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9578) Upgrade to maven-jar-plugin 3.4.2
[ https://issues.apache.org/jira/browse/AMQ-9578?focusedWorklogId=935791&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935791 ] ASF GitHub Bot logged work on AMQ-9578: --- Author: ASF GitHub Bot Created on: 23/Sep/24 09:22 Start Date: 23/Sep/24 09:22 Worklog Time Spent: 10m Work Description: jbonofre opened a new pull request, #1308: URL: https://github.com/apache/activemq/pull/1308 (no comment) Issue Time Tracking --- Worklog Id: (was: 935791) Remaining Estimate: 0h Time Spent: 10m > Upgrade to maven-jar-plugin 3.4.2 > - > > Key: AMQ-9578 > URL: https://issues.apache.org/jira/browse/AMQ-9578 > Project: ActiveMQ Classic > Issue Type: Dependency upgrade >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.2.0, 5.18.6, 6.1.4 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9577) Upgrade to maven-enforcer-plugin 3.5.0
[ https://issues.apache.org/jira/browse/AMQ-9577?focusedWorklogId=935789&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935789 ] ASF GitHub Bot logged work on AMQ-9577: --- Author: ASF GitHub Bot Created on: 23/Sep/24 09:21 Start Date: 23/Sep/24 09:21 Worklog Time Spent: 10m Work Description: jbonofre opened a new pull request, #1307: URL: https://github.com/apache/activemq/pull/1307 (no comment) Issue Time Tracking --- Worklog Id: (was: 935789) Remaining Estimate: 0h Time Spent: 10m > Upgrade to maven-enforcer-plugin 3.5.0 > -- > > Key: AMQ-9577 > URL: https://issues.apache.org/jira/browse/AMQ-9577 > Project: ActiveMQ Classic > Issue Type: Dependency upgrade >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.2.0, 5.18.6, 6.1.4 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4
[
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=935782&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935782
]
ASF GitHub Bot logged work on ARTEMIS-4680:
---
Author: ASF GitHub Bot
Created on: 23/Sep/24 08:48
Start Date: 23/Sep/24 08:48
Worklog Time Spent: 10m
Work Description: andytaylor commented on code in PR #32:
URL:
https://github.com/apache/activemq-artemis-console/pull/32#discussion_r1770995281
##
.github/workflows/build.yml:
##
@@ -26,5 +26,26 @@ jobs:
if: failure()
uses: actions/upload-artifact@v4
with:
- name: rat
- path: target/rat.txt
\ No newline at end of file
+ name: rat-${{ matrix.java }}
+ path: target/rat.txt
+
+ - name: Upload Rat Report On Failure
+if: failure()
+uses: actions/upload-artifact@v4
+with:
+ name: rat-distribution-${{ matrix.java }}
+ path: artemis-console-distribution/target/rat.txt
+
+ - name: Upload Rat Report On Failure
+if: failure()
+uses: actions/upload-artifact@v4
+with:
+ name: rat-extension-${{ matrix.java }}
+ path: artemis-console-extension/target/rat.txt
+
+ - name: Upload Rat Report On Failure
+if: failure()
+uses: actions/upload-artifact@v4
+with:
+ name: rat-console-${{ matrix.java }}
+ path: artemis-console-war/target/rat.txt
Review Comment:
fixed
Issue Time Tracking
---
Worklog Id: (was: 935782)
Time Spent: 15h (was: 14h 50m)
> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
> Fix For: console-1.0.0
>
> Time Spent: 15h
> Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>
> This improvement is to migrate the current console to use HawtIO 4 which i
> based on Typescript, react and Patternfly.
>
> As it can run standalone and be built seperately, this will be released
> independently from [https://github.com/apache/activemq-artemis-console] and
> the output later consumed in Artemis releases (similar to artemis-native).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9576) Upgrade to maven-clean-plugin 3.4.0
[ https://issues.apache.org/jira/browse/AMQ-9576?focusedWorklogId=935751&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935751 ] ASF GitHub Bot logged work on AMQ-9576: --- Author: ASF GitHub Bot Created on: 23/Sep/24 06:23 Start Date: 23/Sep/24 06:23 Worklog Time Spent: 10m Work Description: jbonofre opened a new pull request, #1306: URL: https://github.com/apache/activemq/pull/1306 (no comment) Issue Time Tracking --- Worklog Id: (was: 935751) Remaining Estimate: 0h Time Spent: 10m > Upgrade to maven-clean-plugin 3.4.0 > --- > > Key: AMQ-9576 > URL: https://issues.apache.org/jira/browse/AMQ-9576 > Project: ActiveMQ Classic > Issue Type: Dependency upgrade >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.2.0, 5.18.6, 6.1.4 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9574) Upgrade to commons-io 2.17.0
[ https://issues.apache.org/jira/browse/AMQ-9574?focusedWorklogId=935750&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935750 ] ASF GitHub Bot logged work on AMQ-9574: --- Author: ASF GitHub Bot Created on: 23/Sep/24 06:18 Start Date: 23/Sep/24 06:18 Worklog Time Spent: 10m Work Description: jbonofre opened a new pull request, #1305: URL: https://github.com/apache/activemq/pull/1305 (no comment) Issue Time Tracking --- Worklog Id: (was: 935750) Remaining Estimate: 0h Time Spent: 10m > Upgrade to commons-io 2.17.0 > > > Key: AMQ-9574 > URL: https://issues.apache.org/jira/browse/AMQ-9574 > Project: ActiveMQ Classic > Issue Type: Dependency upgrade > Components: Broker >Reporter: Jean-Baptiste Onofré >Assignee: Jean-Baptiste Onofré >Priority: Major > Fix For: 6.2.0, 5.18.6, 6.1.4 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9552) StatisticsPlugin - add metric lastMessageTimestamp
[
https://issues.apache.org/jira/browse/AMQ-9552?focusedWorklogId=935716&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935716
]
ASF GitHub Bot logged work on AMQ-9552:
---
Author: ASF GitHub Bot
Created on: 22/Sep/24 09:06
Start Date: 22/Sep/24 09:06
Worklog Time Spent: 10m
Work Description: ggkochanski commented on code in PR #1285:
URL: https://github.com/apache/activemq/pull/1285#discussion_r1770280543
##
activemq-broker/src/main/java/org/apache/activemq/plugin/StatisticsBroker.java:
##
@@ -160,6 +160,11 @@ else if (dest instanceof Topic) {
tempFirstMessage.clear();
}
}
+if ( stats.getEnqueues().hasUpdated() ) {
+// NOTICE: Client-side, you may get the broker
"now" Timestamp by msg.getJMSTimestamp()
+// This allows for calculating inactivity.
+statsMessage.setLong("lastMessageTimestamp",
stats.getEnqueues().getLastSampleTime());
Review Comment:
@mattrpav I can see your change is merged, so I'm refreshing the pull
request.
I understand the name unification motivation. Should I change name
**lastMessageTimestamp** into **lastEnqueTimestamp** here?
Issue Time Tracking
---
Worklog Id: (was: 935716)
Time Spent: 1h (was: 50m)
> StatisticsPlugin - add metric lastMessageTimestamp
> --
>
> Key: AMQ-9552
> URL: https://issues.apache.org/jira/browse/AMQ-9552
> Project: ActiveMQ Classic
> Issue Type: Improvement
> Components: Broker
>Reporter: Grzegorz Kochański
>Assignee: Jean-Baptiste Onofré
>Priority: Minor
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Metric {{lastMessageTimestamp}} can be captured from the modification time of
> metric {{enqueues:}}
>
> {code:java}
> statsMessage.setLong("lastMessageTimestamp",
> stats.getEnqueues().getLastSampleTime()); {code}
>
> Disclaimer: disadvantage of such approach is that after broker restart this
> value is holding start time of the broker (which may be relevant when the
> frequency of broker restarts is comparable to the frequency of enqueued
> messages)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5058) Update Qpid protonj2 to version 1.0.0-M22
[ https://issues.apache.org/jira/browse/ARTEMIS-5058?focusedWorklogId=935636&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935636 ] ASF GitHub Bot logged work on ARTEMIS-5058: --- Author: ASF GitHub Bot Created on: 20/Sep/24 21:42 Start Date: 20/Sep/24 21:42 Worklog Time Spent: 10m Work Description: tabish121 merged PR #5242: URL: https://github.com/apache/activemq-artemis/pull/5242 Issue Time Tracking --- Worklog Id: (was: 935636) Time Spent: 0.5h (was: 20m) > Update Qpid protonj2 to version 1.0.0-M22 > - > > Key: ARTEMIS-5058 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5058 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade > Components: AMQP >Affects Versions: 2.37.0 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Minor > Fix For: 2.38.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5058) Update Qpid protonj2 to version 1.0.0-M22
[ https://issues.apache.org/jira/browse/ARTEMIS-5058?focusedWorklogId=935635&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935635 ] ASF GitHub Bot logged work on ARTEMIS-5058: --- Author: ASF GitHub Bot Created on: 20/Sep/24 21:42 Start Date: 20/Sep/24 21:42 Worklog Time Spent: 10m Work Description: tabish121 commented on PR #5242: URL: https://github.com/apache/activemq-artemis/pull/5242#issuecomment-2364656642 Ran full CI without any new test failures Issue Time Tracking --- Worklog Id: (was: 935635) Time Spent: 20m (was: 10m) > Update Qpid protonj2 to version 1.0.0-M22 > - > > Key: ARTEMIS-5058 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5058 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade > Components: AMQP >Affects Versions: 2.37.0 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Minor > Fix For: 2.38.0 > > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5058) Update Qpid protonj2 to version 1.0.0-M22
[ https://issues.apache.org/jira/browse/ARTEMIS-5058?focusedWorklogId=935632&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935632 ] ASF GitHub Bot logged work on ARTEMIS-5058: --- Author: ASF GitHub Bot Created on: 20/Sep/24 21:23 Start Date: 20/Sep/24 21:23 Worklog Time Spent: 10m Work Description: tabish121 opened a new pull request, #5242: URL: https://github.com/apache/activemq-artemis/pull/5242 Update to latest release, used in AMQP tests Issue Time Tracking --- Worklog Id: (was: 935632) Remaining Estimate: 0h Time Spent: 10m > Update Qpid protonj2 to version 1.0.0-M22 > - > > Key: ARTEMIS-5058 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5058 > Project: ActiveMQ Artemis > Issue Type: Dependency upgrade > Components: AMQP >Affects Versions: 2.37.0 >Reporter: Timothy A. Bish >Assignee: Timothy A. Bish >Priority: Minor > Fix For: 2.38.0 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-4680) Upgrade the console to use HawtIO 4
[
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=935592&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935592
]
ASF GitHub Bot logged work on ARTEMIS-4680:
---
Author: ASF GitHub Bot
Created on: 20/Sep/24 16:46
Start Date: 20/Sep/24 16:46
Worklog Time Spent: 10m
Work Description: andytaylor commented on code in PR #32:
URL:
https://github.com/apache/activemq-artemis-console/pull/32#discussion_r1768913206
##
.github/workflows/build.yml:
##
@@ -26,5 +26,26 @@ jobs:
if: failure()
uses: actions/upload-artifact@v4
with:
- name: rat
- path: target/rat.txt
\ No newline at end of file
+ name: rat-${{ matrix.java }}
+ path: target/rat.txt
+
+ - name: Upload Rat Report On Failure
+if: failure()
+uses: actions/upload-artifact@v4
+with:
+ name: rat-distribution-${{ matrix.java }}
+ path: artemis-console-distribution/target/rat.txt
+
+ - name: Upload Rat Report On Failure
+if: failure()
+uses: actions/upload-artifact@v4
+with:
+ name: rat-extension-${{ matrix.java }}
+ path: artemis-console-extension/target/rat.txt
+
+ - name: Upload Rat Report On Failure
+if: failure()
+uses: actions/upload-artifact@v4
+with:
+ name: rat-console-${{ matrix.java }}
+ path: artemis-console-war/target/rat.txt
Review Comment:
I will fix this monday
Issue Time Tracking
---
Worklog Id: (was: 935592)
Time Spent: 14h 50m (was: 14h 40m)
> Upgrade the console to use HawtIO 4
> ---
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Web Console
>Reporter: Andy Taylor
>Assignee: Andy Taylor
>Priority: Major
> Fix For: console-1.0.0
>
> Time Spent: 14h 50m
> Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>
> This improvement is to migrate the current console to use HawtIO 4 which i
> based on Typescript, react and Patternfly.
>
> As it can run standalone and be built seperately, this will be released
> independently from [https://github.com/apache/activemq-artemis-console] and
> the output later consumed in Artemis releases (similar to artemis-native).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9437) Add optional advanced destination statistics including networkEnqueueCount and networkDequeueCount
[ https://issues.apache.org/jira/browse/AMQ-9437?focusedWorklogId=935568&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935568 ] ASF GitHub Bot logged work on AMQ-9437: --- Author: ASF GitHub Bot Created on: 20/Sep/24 13:56 Start Date: 20/Sep/24 13:56 Worklog Time Spent: 10m Work Description: mattrpav merged PR #1304: URL: https://github.com/apache/activemq/pull/1304 Issue Time Tracking --- Worklog Id: (was: 935568) Time Spent: 1h (was: 50m) > Add optional advanced destination statistics including networkEnqueueCount > and networkDequeueCount > --- > > Key: AMQ-9437 > URL: https://issues.apache.org/jira/browse/AMQ-9437 > Project: ActiveMQ Classic > Issue Type: Improvement >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Minor > Fix For: 6.2.0, 5.18.6 > > Time Spent: 1h > Remaining Estimate: 0h > > 1. Add a enableAdvancedStatistics = false (default) flag to guard the ability > to enable advanced destination statistics > 2. Add networkEnqueueCount and networkDequeueCount to track which enqueue(s) > and dequeue(s) were for network connections. > Note: Add'l tickets are requesting advanced destination statistics (times, > messageIds, etc). Adding a single boolean guard around these allows admins to > toggle when the latency penalty is ok. For example, non-persistent topics may > never want these enabled. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9437) Add optional advanced destination statistics including networkEnqueueCount and networkDequeueCount
[ https://issues.apache.org/jira/browse/AMQ-9437?focusedWorklogId=935567&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935567 ] ASF GitHub Bot logged work on AMQ-9437: --- Author: ASF GitHub Bot Created on: 20/Sep/24 13:55 Start Date: 20/Sep/24 13:55 Worklog Time Spent: 10m Work Description: mattrpav opened a new pull request, #1304: URL: https://github.com/apache/activemq/pull/1304 (no comment) Issue Time Tracking --- Worklog Id: (was: 935567) Time Spent: 50m (was: 40m) > Add optional advanced destination statistics including networkEnqueueCount > and networkDequeueCount > --- > > Key: AMQ-9437 > URL: https://issues.apache.org/jira/browse/AMQ-9437 > Project: ActiveMQ Classic > Issue Type: Improvement >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Minor > Fix For: 6.2.0, 5.18.6 > > Time Spent: 50m > Remaining Estimate: 0h > > 1. Add a enableAdvancedStatistics = false (default) flag to guard the ability > to enable advanced destination statistics > 2. Add networkEnqueueCount and networkDequeueCount to track which enqueue(s) > and dequeue(s) were for network connections. > Note: Add'l tickets are requesting advanced destination statistics (times, > messageIds, etc). Adding a single boolean guard around these allows admins to > toggle when the latency penalty is ok. For example, non-persistent topics may > never want these enabled. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (AMQ-9437) Add optional advanced destination statistics including networkEnqueueCount and networkDequeueCount
[ https://issues.apache.org/jira/browse/AMQ-9437?focusedWorklogId=935562&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935562 ] ASF GitHub Bot logged work on AMQ-9437: --- Author: ASF GitHub Bot Created on: 20/Sep/24 13:48 Start Date: 20/Sep/24 13:48 Worklog Time Spent: 10m Work Description: mattrpav merged PR #1156: URL: https://github.com/apache/activemq/pull/1156 Issue Time Tracking --- Worklog Id: (was: 935562) Time Spent: 40m (was: 0.5h) > Add optional advanced destination statistics including networkEnqueueCount > and networkDequeueCount > --- > > Key: AMQ-9437 > URL: https://issues.apache.org/jira/browse/AMQ-9437 > Project: ActiveMQ Classic > Issue Type: Improvement >Reporter: Matt Pavlovich >Assignee: Matt Pavlovich >Priority: Minor > Fix For: 6.2.0, 5.18.6 > > Time Spent: 40m > Remaining Estimate: 0h > > 1. Add a enableAdvancedStatistics = false (default) flag to guard the ability > to enable advanced destination statistics > 2. Add networkEnqueueCount and networkDequeueCount to track which enqueue(s) > and dequeue(s) were for network connections. > Note: Add'l tickets are requesting advanced destination statistics (times, > messageIds, etc). Adding a single boolean guard around these allows admins to > toggle when the latency penalty is ok. For example, non-persistent topics may > never want these enabled. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5051) console jolokia default detector config makes unauthenticated mbean requests that are denied by ArtemisRbacMBeanServerBuilder
[
https://issues.apache.org/jira/browse/ARTEMIS-5051?focusedWorklogId=935524&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935524
]
ASF GitHub Bot logged work on ARTEMIS-5051:
---
Author: ASF GitHub Bot
Created on: 20/Sep/24 11:23
Start Date: 20/Sep/24 11:23
Worklog Time Spent: 10m
Work Description: gtully merged PR #5238:
URL: https://github.com/apache/activemq-artemis/pull/5238
Issue Time Tracking
---
Worklog Id: (was: 935524)
Time Spent: 20m (was: 10m)
> console jolokia default detector config makes unauthenticated mbean requests
> that are denied by ArtemisRbacMBeanServerBuilder
> -
>
> Key: ARTEMIS-5051
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5051
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Web Console
>Affects Versions: 2.37.0
>Reporter: Gary Tully
>Assignee: Gary Tully
>Priority: Major
> Fix For: 2.38.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The resulting errors are not consequential but very ugly.
> {noformat}
> broker with: java ... -Dhawtio.role=*
> -Djavax.management.builder.initial=org.apache.activemq.artemis.core.server.management.ArtemisRbacMBeanServerBuilder{noformat}
> errors of the form:
> {noformat}
> AMQ601716: User anonymous@internal failed authentication on connection
> management, reason: AMQ229031: Unable to validate user from management.
> Username: null; SSL certificate subject DN: unavailable
> jolokia-agent: Error while using detector GeronimoDetector:
> java.lang.SecurityException: AMQ229031: Unable to validate user from
> management. Username: null; SSL certificate subject DN: unavailable
> java.lang.SecurityException: AMQ229031: Unable to validate user from
> management. Username: null; SSL certificate subject DN: unavailable
> at
> org.apache.activemq.artemis.core.server.management.ArtemisRbacInvocationHandler.securityCheck(ArtemisRbacInvocationHandler.java:207)
> at
> org.apache.activemq.artemis.core.server.management.ArtemisRbacInvocationHandler.invoke(ArtemisRbacInvocationHandler.java:71)
> at jdk.proxy2/jdk.proxy2.$Proxy29.queryNames
> at
> org.jolokia.backend.executor.AbstractMBeanServerExecutor.queryNames(AbstractMBeanServerExecutor.java:113)
> at
> org.jolokia.detector.AbstractServerDetector.searchMBeans(AbstractServerDetector.java:46)
> at
> org.jolokia.detector.AbstractServerDetector.getSingleStringAttribute(AbstractServerDetector.java:124)
> at
> org.jolokia.detector.GeronimoDetector.detect(GeronimoDetector.java:32){noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5049) Add detailed logging for auth caches
[ https://issues.apache.org/jira/browse/ARTEMIS-5049?focusedWorklogId=935423&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935423 ] ASF GitHub Bot logged work on ARTEMIS-5049: --- Author: ASF GitHub Bot Created on: 19/Sep/24 20:36 Start Date: 19/Sep/24 20:36 Worklog Time Spent: 10m Work Description: tabish121 merged PR #5237: URL: https://github.com/apache/activemq-artemis/pull/5237 Issue Time Tracking --- Worklog Id: (was: 935423) Time Spent: 40m (was: 0.5h) > Add detailed logging for auth caches > > > Key: ARTEMIS-5049 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5049 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5049) Add detailed logging for auth caches
[ https://issues.apache.org/jira/browse/ARTEMIS-5049?focusedWorklogId=935410&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935410 ] ASF GitHub Bot logged work on ARTEMIS-5049: --- Author: ASF GitHub Bot Created on: 19/Sep/24 19:43 Start Date: 19/Sep/24 19:43 Worklog Time Spent: 10m Work Description: jbertram commented on PR #5237: URL: https://github.com/apache/activemq-artemis/pull/5237#issuecomment-2362042667 Conflicts resolved. Issue Time Tracking --- Worklog Id: (was: 935410) Time Spent: 0.5h (was: 20m) > Add detailed logging for auth caches > > > Key: ARTEMIS-5049 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5049 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5055) AIO not detected in official Ubuntu Docker image
[
https://issues.apache.org/jira/browse/ARTEMIS-5055?focusedWorklogId=935408&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935408
]
ASF GitHub Bot logged work on ARTEMIS-5055:
---
Author: ASF GitHub Bot
Created on: 19/Sep/24 19:33
Start Date: 19/Sep/24 19:33
Worklog Time Spent: 10m
Work Description: jbertram opened a new pull request, #5241:
URL: https://github.com/apache/activemq-artemis/pull/5241
(no comment)
Issue Time Tracking
---
Worklog Id: (was: 935408)
Remaining Estimate: 0h
Time Spent: 10m
> AIO not detected in official Ubuntu Docker image
>
>
> Key: ARTEMIS-5055
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5055
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: ActiveMQ-Artemis-Native, Image
>Affects Versions: 2.36.0, 2.37.0
>Reporter: William Sperlazza
>Assignee: Justin Bertram
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> libaio changed their package name as was addressed here:
> [https://github.com/apache/activemq-artemis/commit/86f36e95b09c709fb7e4af33f4a535f9a80d7221]
>
> But the native LibaioContext link is still trying to reference libaio.so.1,
> as seen in startup logs with debug enabled:
> {quote}
> 2024-09-18 15:40:43,807 DEBUG
> [org.apache.activemq.artemis.nativo.jlibaio.LibaioContext] artemis-native-64
> -> not possible to load native library
> java.lang.UnsatisfiedLinkError:
> /opt/activemq-artemis/bin/lib/linux-x86_64/libartemis-native-64.so:
> libaio.so.1: cannot open shared object file: No such file or directory{quote}
> I think the link created
> [here|https://github.com/apache/activemq-artemis-native/blob/02ad87f08395993ae417ce75bf8ce78a3bc23e0a/src/main/c/CMakeLists.txt#L80C1-L80C22]
> is stale, and a simple rebuild of artemis-native may be all that's needed?
> Maybe the [dockerfile needs updating
> there|https://github.com/apache/activemq-artemis-native/blob/02ad87f08395993ae417ce75bf8ce78a3bc23e0a/src/main/docker/Dockerfile-ubuntu#L36]
> too though.
> NOTE: This only affects the ubuntu image; alpine is fine.
>
> The workaround is to either use the alpine official image instead, or create
> a symlink to the old library name in a Dockerfile based on the official image:
> {quote}RUN ln -s /lib/x86_64-linux-gnu/libaio.so.1t64
> /lib/x86_64-linux-gnu/libaio.so.1
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5049) Add detailed logging for auth caches
[ https://issues.apache.org/jira/browse/ARTEMIS-5049?focusedWorklogId=935400&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935400 ] ASF GitHub Bot logged work on ARTEMIS-5049: --- Author: ASF GitHub Bot Created on: 19/Sep/24 19:05 Start Date: 19/Sep/24 19:05 Worklog Time Spent: 10m Work Description: tabish121 commented on PR #5237: URL: https://github.com/apache/activemq-artemis/pull/5237#issuecomment-2361958136 This one will need some updates based on recent commits Issue Time Tracking --- Worklog Id: (was: 935400) Time Spent: 20m (was: 10m) > Add detailed logging for auth caches > > > Key: ARTEMIS-5049 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5049 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5052) Hash authentication cache keys
[ https://issues.apache.org/jira/browse/ARTEMIS-5052?focusedWorklogId=935399&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935399 ] ASF GitHub Bot logged work on ARTEMIS-5052: --- Author: ASF GitHub Bot Created on: 19/Sep/24 18:55 Start Date: 19/Sep/24 18:55 Worklog Time Spent: 10m Work Description: tabish121 merged PR #5236: URL: https://github.com/apache/activemq-artemis/pull/5236 Issue Time Tracking --- Worklog Id: (was: 935399) Time Spent: 50m (was: 40m) > Hash authentication cache keys > -- > > Key: ARTEMIS-5052 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5052 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5052) Hash authentication cache keys
[ https://issues.apache.org/jira/browse/ARTEMIS-5052?focusedWorklogId=935397&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935397 ] ASF GitHub Bot logged work on ARTEMIS-5052: --- Author: ASF GitHub Bot Created on: 19/Sep/24 18:28 Start Date: 19/Sep/24 18:28 Worklog Time Spent: 10m Work Description: jbertram commented on PR #5236: URL: https://github.com/apache/activemq-artemis/pull/5236#issuecomment-2361890546 @tabish121, the latest run looks good. Issue Time Tracking --- Worklog Id: (was: 935397) Time Spent: 40m (was: 0.5h) > Hash authentication cache keys > -- > > Key: ARTEMIS-5052 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5052 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Justin Bertram >Assignee: Justin Bertram >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5038) Concurrent access issues on LinkedListImpl
[ https://issues.apache.org/jira/browse/ARTEMIS-5038?focusedWorklogId=935396&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935396 ] ASF GitHub Bot logged work on ARTEMIS-5038: --- Author: ASF GitHub Bot Created on: 19/Sep/24 18:16 Start Date: 19/Sep/24 18:16 Worklog Time Spent: 10m Work Description: clebertsuconic commented on PR #5221: URL: https://github.com/apache/activemq-artemis/pull/5221#issuecomment-2361870455 I have now found the exact condition that was being broken at my user.. and I updated the PR for the minimal changes that are required. Issue Time Tracking --- Worklog Id: (was: 935396) Time Spent: 1h (was: 50m) > Concurrent access issues on LinkedListImpl > -- > > Key: ARTEMIS-5038 > URL: https://issues.apache.org/jira/browse/ARTEMIS-5038 > Project: ActiveMQ Artemis > Issue Type: Bug >Affects Versions: 2.37.0 >Reporter: Clebert Suconic >Priority: Major > Fix For: 2.38.0 > > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org For additional commands, e-mail: issues-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
[jira] [Work logged] (ARTEMIS-5048) Use java.util.Base64
[
https://issues.apache.org/jira/browse/ARTEMIS-5048?focusedWorklogId=935394&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935394
]
ASF GitHub Bot logged work on ARTEMIS-5048:
---
Author: ASF GitHub Bot
Created on: 19/Sep/24 18:06
Start Date: 19/Sep/24 18:06
Worklog Time Spent: 10m
Work Description: tabish121 merged PR #5240:
URL: https://github.com/apache/activemq-artemis/pull/5240
Issue Time Tracking
---
Worklog Id: (was: 935394)
Time Spent: 2h (was: 1h 50m)
> Use java.util.Base64
>
>
> Key: ARTEMIS-5048
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5048
> Project: ActiveMQ Artemis
> Issue Type: Improvement
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
> Fix For: 2.38.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> We've traditionally used {{org.apache.activemq.artemis.utils.Base64}} for
> Base64 encoding/decoding. This implementation is based on public domain code
> from http://iharder.net/base64.
> In Java 8 {{java.util.Base64}} was introduced. I assumed we hadn't switched
> to this implementation for performance reasons so I created a simple
> JMH-based test to compare the two implementations and it appears to me that
> {{java.util.Base64}} is significantly faster than our current implementation.
> Using the JDK's class will simplify our code _and_ improve performance. Also,
> it should be 100% backwards compatible since Base64 encoding/decoding is
> standardized.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: issues-unsubscr...@activemq.apache.org
For additional commands, e-mail: issues-h...@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
