[jira] [Commented] (AMQ-6108) SelectorManager Executor is not shutdown when transport os stopped.
[ https://issues.apache.org/jira/browse/AMQ-6108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15196057#comment-15196057 ] Volker Kleinschmidt commented on AMQ-6108: -- Thanks for the quick fix! > SelectorManager Executor is not shutdown when transport os stopped. > --- > > Key: AMQ-6108 > URL: https://issues.apache.org/jira/browse/AMQ-6108 > Project: ActiveMQ > Issue Type: Bug >Reporter: Andy Gumbrecht >Assignee: Timothy Bish > Fix For: 5.13.1, 5.14.0 > > Attachments: SelectorManager.Shutdown.patch > > > SelectorManager creates an Executor that is not shut down on termination of > the Transport. > The Executor currently uses non-daemon threads and is is not guaranteed the > the SelectorWorker thread exit condition is ever met. > This causes the shutdown to hang when using transports that utilise the > SelectorManager, such as nio+ssl for example. > The proposed patch shuts down the ExecutorService on/after Transport > shutdown. The SelectorWorkers also check for this as an exit condition. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-6108) SelectorManager Executor is not shutdown when transport os stopped.
[ https://issues.apache.org/jira/browse/AMQ-6108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195827#comment-15195827 ] ASF subversion and git services commented on AMQ-6108: -- Commit e0081014bfd95140b0545ffc20e1d25558044a02 in activemq's branch refs/heads/activemq-5.13.x from [~tabish121] [ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=e008101 ] https://issues.apache.org/jira/browse/AMQ-6108 Update the threads created by the SelectorManager to be daemon threads. (cherry picked from commit e2b4ca2c59a316be91cf391c758a10e518dd3a1f) Conflicts: activemq-client/src/main/java/org/apache/activemq/transport/nio/SelectorManager.java > SelectorManager Executor is not shutdown when transport os stopped. > --- > > Key: AMQ-6108 > URL: https://issues.apache.org/jira/browse/AMQ-6108 > Project: ActiveMQ > Issue Type: Bug >Reporter: Andy Gumbrecht >Assignee: Timothy Bish > Fix For: 5.13.1, 5.14.0 > > Attachments: SelectorManager.Shutdown.patch > > > SelectorManager creates an Executor that is not shut down on termination of > the Transport. > The Executor currently uses non-daemon threads and is is not guaranteed the > the SelectorWorker thread exit condition is ever met. > This causes the shutdown to hang when using transports that utilise the > SelectorManager, such as nio+ssl for example. > The proposed patch shuts down the ExecutorService on/after Transport > shutdown. The SelectorWorkers also check for this as an exit condition. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-6108) SelectorManager Executor is not shutdown when transport os stopped.
[ https://issues.apache.org/jira/browse/AMQ-6108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195818#comment-15195818 ] ASF subversion and git services commented on AMQ-6108: -- Commit e2b4ca2c59a316be91cf391c758a10e518dd3a1f in activemq's branch refs/heads/master from [~tabish121] [ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=e2b4ca2 ] https://issues.apache.org/jira/browse/AMQ-6108 Update the threads created by the SelectorManager to be daemon threads. > SelectorManager Executor is not shutdown when transport os stopped. > --- > > Key: AMQ-6108 > URL: https://issues.apache.org/jira/browse/AMQ-6108 > Project: ActiveMQ > Issue Type: Bug >Reporter: Andy Gumbrecht >Assignee: Timothy Bish > Fix For: 5.13.1, 5.14.0 > > Attachments: SelectorManager.Shutdown.patch > > > SelectorManager creates an Executor that is not shut down on termination of > the Transport. > The Executor currently uses non-daemon threads and is is not guaranteed the > the SelectorWorker thread exit condition is ever met. > This causes the shutdown to hang when using transports that utilise the > SelectorManager, such as nio+ssl for example. > The proposed patch shuts down the ExecutorService on/after Transport > shutdown. The SelectorWorkers also check for this as an exit condition. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-6108) SelectorManager Executor is not shutdown when transport os stopped.
[ https://issues.apache.org/jira/browse/AMQ-6108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15194293#comment-15194293 ] Volker Kleinschmidt commented on AMQ-6108: -- Actually these check-ins call setDaemon(false), i.e. they create the ActiveMQ IO Worker thread as user thread, not as daemon. This is exactly the wrong way around! > SelectorManager Executor is not shutdown when transport os stopped. > --- > > Key: AMQ-6108 > URL: https://issues.apache.org/jira/browse/AMQ-6108 > Project: ActiveMQ > Issue Type: Bug >Reporter: Andy Gumbrecht >Assignee: Timothy Bish > Fix For: 5.13.1, 5.14.0 > > Attachments: SelectorManager.Shutdown.patch > > > SelectorManager creates an Executor that is not shut down on termination of > the Transport. > The Executor currently uses non-daemon threads and is is not guaranteed the > the SelectorWorker thread exit condition is ever met. > This causes the shutdown to hang when using transports that utilise the > SelectorManager, such as nio+ssl for example. > The proposed patch shuts down the ExecutorService on/after Transport > shutdown. The SelectorWorkers also check for this as an exit condition. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-6108) SelectorManager Executor is not shutdown when transport os stopped.
[ https://issues.apache.org/jira/browse/AMQ-6108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098910#comment-15098910 ] Timothy Bish commented on AMQ-6108: --- Since the SelectorManager instance is shared amongst every Transport instance created when using the NIOTransport types it doesn't make any sense to shutdown the executor when any one instance is stopped, or when any one TransportConnector instance is stopped as that defeats the purpose of the NIO bits sharing resources. The Threads in the executor should be set deamon though in order to prevent them keeping a JVM running. > SelectorManager Executor is not shutdown when transport os stopped. > --- > > Key: AMQ-6108 > URL: https://issues.apache.org/jira/browse/AMQ-6108 > Project: ActiveMQ > Issue Type: Bug >Reporter: Andy Gumbrecht > Fix For: 5.13.1 > > Attachments: SelectorManager.Shutdown.patch > > > SelectorManager creates an Executor that is not shut down on termination of > the Transport. > The Executor currently uses non-daemon threads and is is not guaranteed the > the SelectorWorker thread exit condition is ever met. > This causes the shutdown to hang when using transports that utilise the > SelectorManager, such as nio+ssl for example. > The proposed patch shuts down the ExecutorService on/after Transport > shutdown. The SelectorWorkers also check for this as an exit condition. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-6108) SelectorManager Executor is not shutdown when transport os stopped.
[ https://issues.apache.org/jira/browse/AMQ-6108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098940#comment-15098940 ] ASF subversion and git services commented on AMQ-6108: -- Commit 5adbafef3b9ec05de7186caa9112f3639c7a6253 in activemq's branch refs/heads/master from [~tabish121] [ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=5adbafe ] https://issues.apache.org/jira/browse/AMQ-6108 Ensure that executor threads are created as daemon threads, fix a try/finaly block, clean up some warnings. > SelectorManager Executor is not shutdown when transport os stopped. > --- > > Key: AMQ-6108 > URL: https://issues.apache.org/jira/browse/AMQ-6108 > Project: ActiveMQ > Issue Type: Bug >Reporter: Andy Gumbrecht > Fix For: 5.13.1 > > Attachments: SelectorManager.Shutdown.patch > > > SelectorManager creates an Executor that is not shut down on termination of > the Transport. > The Executor currently uses non-daemon threads and is is not guaranteed the > the SelectorWorker thread exit condition is ever met. > This causes the shutdown to hang when using transports that utilise the > SelectorManager, such as nio+ssl for example. > The proposed patch shuts down the ExecutorService on/after Transport > shutdown. The SelectorWorkers also check for this as an exit condition. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (AMQ-6108) SelectorManager Executor is not shutdown when transport os stopped.
[ https://issues.apache.org/jira/browse/AMQ-6108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098943#comment-15098943 ] ASF subversion and git services commented on AMQ-6108: -- Commit 1d9fdbcbeaacf2d5673bb5435b1caae0b1cfc7a7 in activemq's branch refs/heads/activemq-5.13.x from [~tabish121] [ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=1d9fdbc ] https://issues.apache.org/jira/browse/AMQ-6108 Ensure that executor threads are created as daemon threads, fix a try/finaly block, clean up some warnings. (cherry picked from commit 5adbafef3b9ec05de7186caa9112f3639c7a6253) > SelectorManager Executor is not shutdown when transport os stopped. > --- > > Key: AMQ-6108 > URL: https://issues.apache.org/jira/browse/AMQ-6108 > Project: ActiveMQ > Issue Type: Bug >Reporter: Andy Gumbrecht > Fix For: 5.13.1 > > Attachments: SelectorManager.Shutdown.patch > > > SelectorManager creates an Executor that is not shut down on termination of > the Transport. > The Executor currently uses non-daemon threads and is is not guaranteed the > the SelectorWorker thread exit condition is ever met. > This causes the shutdown to hang when using transports that utilise the > SelectorManager, such as nio+ssl for example. > The proposed patch shuts down the ExecutorService on/after Transport > shutdown. The SelectorWorkers also check for this as an exit condition. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
