[jira] [Commented] (AMQ-6614) JMX Queue attribute blockedSends not updated when a sync send hits flow control
[ https://issues.apache.org/jira/browse/AMQ-6614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114341#comment-16114341 ] Christopher L. Shannon commented on AMQ-6614: - [~gtully], Ok, sounds good, just wanted to double check. > JMX Queue attribute blockedSends not updated when a sync send hits flow > control > --- > > Key: AMQ-6614 > URL: https://issues.apache.org/jira/browse/AMQ-6614 > Project: ActiveMQ > Issue Type: Bug > Components: JMX >Affects Versions: 5.14.0 >Reporter: Gary Tully >Assignee: Gary Tully > Labels: jmx > Fix For: 5.15.0 > > > an async send that blocks waiting for space increments the blockedSends jmx > attribute but with the producerwindow or a sync send it does not. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (AMQ-6614) JMX Queue attribute blockedSends not updated when a sync send hits flow control
[ https://issues.apache.org/jira/browse/AMQ-6614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114268#comment-16114268 ] Gary Tully commented on AMQ-6614: - [~cshannon] thanks for the second pair of eyes. I think it will be ok. I modified the ProducerBrokerExchange.copy to share that state flag - flowControlInfo so both the copy and original will share it. https://git-wip-us.apache.org/repos/asf?p=activemq.git;a=blobdiff;f=activemq-broker/src/main/java/org/apache/activemq/broker/ProducerBrokerExchange.java;h=26652debe644977fa00fa37f5ec33a4acf279ca7;hp=bf1d21e80022765aeb7611e5b8363c7eeec79af6;hb=e67d486;hpb=eab9a0d05758fd0e8e83e7e482f4f0406cd9af5e > JMX Queue attribute blockedSends not updated when a sync send hits flow > control > --- > > Key: AMQ-6614 > URL: https://issues.apache.org/jira/browse/AMQ-6614 > Project: ActiveMQ > Issue Type: Bug > Components: JMX >Affects Versions: 5.14.0 >Reporter: Gary Tully >Assignee: Gary Tully > Labels: jmx > Fix For: 5.15.0 > > > an async send that blocks waiting for space increments the blockedSends jmx > attribute but with the producerwindow or a sync send it does not. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (AMQ-6614) JMX Queue attribute blockedSends not updated when a sync send hits flow control
[
https://issues.apache.org/jira/browse/AMQ-6614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108910#comment-16108910
]
Christopher L. Shannon commented on AMQ-6614:
-
[~gtully], I was looking at this commit and noticed something...
Should this line:
https://github.com/apache/activemq/blob/activemq-5.15.0/activemq-broker/src/main/java/org/apache/activemq/broker/region/Queue.java#L707
be changed from {{producerExchangeCopy.blockingOnFlowControl(false);}} to
{{producerExchange.blockingOnFlowControl(false);}} ?
The flag is set true later on line 713 on the original producerExchange so the
copy would always have the flag be false already (unless I am missing something)
> JMX Queue attribute blockedSends not updated when a sync send hits flow
> control
> ---
>
> Key: AMQ-6614
> URL: https://issues.apache.org/jira/browse/AMQ-6614
> Project: ActiveMQ
> Issue Type: Bug
> Components: JMX
>Affects Versions: 5.14.0
>Reporter: Gary Tully
>Assignee: Gary Tully
> Labels: jmx
> Fix For: 5.15.0
>
>
> an async send that blocks waiting for space increments the blockedSends jmx
> attribute but with the producerwindow or a sync send it does not.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (AMQ-6614) JMX Queue attribute blockedSends not updated when a sync send hits flow control
[ https://issues.apache.org/jira/browse/AMQ-6614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15892608#comment-15892608 ] ASF subversion and git services commented on AMQ-6614: -- Commit e67d48680f16061d0a5fbd09129ce8f0a7759255 in activemq's branch refs/heads/master from [~gtully] [ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=e67d486 ] [AMQ-6614] fix up jmx blockedSendsCount and producer view blocking flag for async send case. fix and test > JMX Queue attribute blockedSends not updated when a sync send hits flow > control > --- > > Key: AMQ-6614 > URL: https://issues.apache.org/jira/browse/AMQ-6614 > Project: ActiveMQ > Issue Type: Bug > Components: JMX >Affects Versions: 5.14.0 >Reporter: Gary Tully >Assignee: Gary Tully > Labels: jmx > Fix For: 5.15.0 > > > an async send that blocks waiting for space increments the blockedSends jmx > attribute but with the producerwindow or a sync send it does not. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
