[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[
https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980715#comment-15980715
]
ASF GitHub Bot commented on ARTEMIS-1093:
-
Github user gaohoward commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1215#discussion_r112863550
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/util/FQQN.java
---
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.tests.util;
+
+import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.utils.CompositeAddress;
+
+public final class FQQN {
+
--- End diff --
@clebertsuconic Thanks. :)
> Full qualified queue name support
> -
>
> Key: ARTEMIS-1093
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1093
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.0.0
>Reporter: Howard Gao
>Assignee: Howard Gao
> Fix For: 2.next
>
>
> Broker should support full qualified queue names (FQQN) as well as bare queue
> names. This means when clients access to a queue they have two equivalent
> ways to do so. One way is by queue names and the other is by FQQN (i.e.
> address::qname) names. When accessing a queue by its bare name, it is
> required that the name should be unique across all addresses.
> Otherwise a warning is given and client should use FQQN instead.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[
https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980526#comment-15980526
]
ASF GitHub Bot commented on ARTEMIS-1093:
-
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1215#discussion_r112843427
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/util/FQQN.java
---
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.tests.util;
+
+import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.utils.CompositeAddress;
+
+public final class FQQN {
+
--- End diff --
Actually, I already did while merging.
> Full qualified queue name support
> -
>
> Key: ARTEMIS-1093
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1093
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.0.0
>Reporter: Howard Gao
>Assignee: Howard Gao
> Fix For: 2.next
>
>
> Broker should support full qualified queue names (FQQN) as well as bare queue
> names. This means when clients access to a queue they have two equivalent
> ways to do so. One way is by queue names and the other is by FQQN (i.e.
> address::qname) names. When accessing a queue by its bare name, it is
> required that the name should be unique across all addresses.
> Otherwise a warning is given and client should use FQQN instead.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980524#comment-15980524 ] ASF subversion and git services commented on ARTEMIS-1093: -- Commit 23b3d2182ce8df0499da31d7a9b48d436d85969f in activemq-artemis's branch refs/heads/master from Clebert Suconic [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=23b3d21 ] ARTEMIS-1093 Moving FQQN methods into CompositeAddress > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980523#comment-15980523 ] ASF subversion and git services commented on ARTEMIS-1093: -- Commit f344c1ebafb23e96d6cc0ba46b7fbd2b0b8edd82 in activemq-artemis's branch refs/heads/master from [~gaohoward] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=f344c1e ] ARTEMIS-1093 Full qualified queue name support Broker should support full qualified queue names (FQQN) as well as bare queue names. This means when clients access to a queue they have two equivalent ways to do so. One way is by queue names and the other is by FQQN (i.e. address::qname) names. Currently only receiving is supported. > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980525#comment-15980525 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1215 > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[
https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980514#comment-15980514
]
ASF GitHub Bot commented on ARTEMIS-1093:
-
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1215#discussion_r112842725
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/util/FQQN.java
---
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.tests.util;
+
+import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.utils.CompositeAddress;
+
+public final class FQQN {
+
--- End diff --
Can you remove this class, and move these two methods towards
CompositeAddress
> Full qualified queue name support
> -
>
> Key: ARTEMIS-1093
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1093
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.0.0
>Reporter: Howard Gao
>Assignee: Howard Gao
> Fix For: 2.next
>
>
> Broker should support full qualified queue names (FQQN) as well as bare queue
> names. This means when clients access to a queue they have two equivalent
> ways to do so. One way is by queue names and the other is by FQQN (i.e.
> address::qname) names. When accessing a queue by its bare name, it is
> required that the name should be unique across all addresses.
> Otherwise a warning is given and client should use FQQN instead.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978811#comment-15978811 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 Jenkins looking good. :) > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978245#comment-15978245 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 @clebertsuconic @mtaylor turns out I compared a String address with SimpleString, which always return false. Fixed that and added a simple test. Jenkins for the moment seems down, I'll kick off a build when it's back. > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978037#comment-15978037 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 @clebertsuconic sure I'll take care of it. Thanks. > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978030#comment-15978030 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 @gaohoward actually, the example managmeent is broken after this. Can you look please? > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15978023#comment-15978023 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 @mtaylor I will let you merge this.. but this PR is +1 from me.. nice job @gaohoward > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977050#comment-15977050 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 There might be a problem with Jenkins machine, the failure relates to 'memory allocation'. Not related to my PR. @clebertsuconic I ran the whole test suite on my local machine, there are few test failures but none of them related to my PR. They failed both with and without my PR. (I'll investigate those failures further when I got time). > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976909#comment-15976909 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 Please. While the whole testsuite ? > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976888#comment-15976888 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 OK, I removed the garbage files and reverted AmqpSendReceiveTest. > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976851#comment-15976851 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user gaohoward commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1215#discussion_r112476953 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpSendReceiveTest.java --- @@ -53,38 +56,61 @@ import org.apache.qpid.proton.engine.Sender; import org.jgroups.util.UUID; import org.junit.Test; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; import org.slf4j.Logger; import org.slf4j.LoggerFactory; /** * Test basic send and receive scenarios using only AMQP sender and receiver links. */ +@RunWith(Parameterized.class) --- End diff -- @tabish121 ok, I'll remove it to keep it simple. > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976841#comment-15976841 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user tabish121 commented on a diff in the pull request: https://github.com/apache/activemq-artemis/pull/1215#discussion_r112475520 --- Diff: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/AmqpSendReceiveTest.java --- @@ -53,38 +56,61 @@ import org.apache.qpid.proton.engine.Sender; import org.jgroups.util.UUID; import org.junit.Test; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; import org.slf4j.Logger; import org.slf4j.LoggerFactory; /** * Test basic send and receive scenarios using only AMQP sender and receiver links. */ +@RunWith(Parameterized.class) --- End diff -- This seems like an unnecessary change to this test. The intent here is to test basic AMQP protocol support not to test the FQQN support in the broker which it appears is already done in the ProtonFullQualifiedNameTest. I'd prefer if we could keep tests targeted and not try and make them test the entirety of the broker features in one monolithic test case as that makes it harder to maintain. If you changed this one why didn't you change every single AMQP test in the same fashion? > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976826#comment-15976826 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 guys please hold on this commit, I found some garbage files need to remove. > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976819#comment-15976819 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1215 @clebertsuconic @mtaylor This is a resubmit of FQQN PR, with all tests fixed. > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976815#comment-15976815 ] ASF GitHub Bot commented on ARTEMIS-1093: - GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/1215 ARTEMIS-1093 Full qualified queue name support Broker should support full qualified queue names (FQQN) as well as bare queue names. This means when clients access to a queue they have two equivalent ways to do so. One way is by queue names and the other is by FQQN (i.e. address::qname) names. Currently only receiving is supported. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gaohoward/activemq-artemis master_more_fqqn Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1215.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1215 > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970584#comment-15970584 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user gaohoward closed the pull request at: https://github.com/apache/activemq-artemis/pull/1201 > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968376#comment-15968376 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1201 @gaohoward Please close this, and bring this back whenever you fix the other PR. > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966715#comment-15966715 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user jbertram closed the pull request at: https://github.com/apache/activemq-artemis/pull/1203 > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966602#comment-15966602 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1203 @jbertram close this please? it's been reverted. > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966600#comment-15966600 ] ASF subversion and git services commented on ARTEMIS-1093: -- Commit f6098841866d52d8ef55423acbf60bb4663e52cf in activemq-artemis's branch refs/heads/master from Clebert Suconic [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=f609884 ] Revert "ARTEMIS-1093 Full qualified queue name support" Testsuite won't complete with this commit. Reerting it for further evaluation. This reverts commit a9a3c478089ac0f5d32fd414e45441a340dbeb5d. > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966578#comment-15966578 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1172 @mtaylor @gaohoward I am reverting this fix... the testsuite is completely broken after this. please @gaohoward revisit this and after all figured out we can come back with this fix. > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15966228#comment-15966228 ] ASF GitHub Bot commented on ARTEMIS-1093: - GitHub user jbertram opened a pull request: https://github.com/apache/activemq-artemis/pull/1203 ARTEMIS-1093 fix bug in comparison You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbertram/activemq-artemis master_work Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1203.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1203 commit 62a6405ccd1a949825a00f2f5ce1d18879b72880 Author: Justin Bertram Date: 2017-04-12T17:11:41Z ARTEMIS-1093 fix bug in comparison > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965867#comment-15965867 ] ASF GitHub Bot commented on ARTEMIS-1093: - GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/1201 ARTEMIS-1093 Added more tests for FQQN You can merge this pull request into a Git repository by running: $ git pull https://github.com/gaohoward/activemq-artemis master_more_fqqn Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1201.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1201 commit aced1224d42f96c1205a4d7225722c1456511618 Author: Howard Gao Date: 2017-04-12T12:55:29Z ARTEMIS-1093 Added more tests for FQQN > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965574#comment-15965574 ] ASF subversion and git services commented on ARTEMIS-1093: -- Commit a9a3c478089ac0f5d32fd414e45441a340dbeb5d in activemq-artemis's branch refs/heads/master from [~gaohoward] [ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=a9a3c47 ] ARTEMIS-1093 Full qualified queue name support Broker should support full qualified queue names (FQQN) as well as bare queue names. This means when clients access to a queue they have two equivalent ways to do so. One way is by queue names and the other is by FQQN (i.e. address::qname) names. Currently only receiving is supported. > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965575#comment-15965575 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1172 > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15964132#comment-15964132 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1172 @howardgao Nice work, I like this solution. Thanks. > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963719#comment-15963719 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1172 @mtaylor done updating doc. > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15963681#comment-15963681 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1172 @mtaylor ok will do. > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962998#comment-15962998 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1172 @gaohoward Yes, just do it on consume for now. We'll sort out the send later. Could you just ensure that this is reflected in the docs. I.e. support for AMQP, JMS, OpenWire on consume only. Thanks > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962935#comment-15962935 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1172 @mtaylor I update the PR, pls review again. About sending direct to a queue, I think we can do it in another task. According to current design, messages are meant for address as always, then postoffice routes the messages to a target queue, based on the routing type of the address. > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958624#comment-15958624 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1172 @gaohoward From a end users point of view, I'd like at some point to be able to send direct to a queue. I thought you'd already done the work for this in this patch. If not, then the really simple thing to do here is intercept the consume packet, parse the FQQN and look up the queue. It should be straight forward since the queue name is part of the FQQN, then just check that the first part of the FQQN (the address) matches the address on the queue. You'll also need to ensure that this works with auto-create-queues and auto-create-addresses. Thanks. > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958254#comment-15958254 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1172 @clebertsuconic Just sent a discussion to dev list. :) > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958138#comment-15958138 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1172 @gaohoward you don't have to open a discuss for every simple fix you're going to make.. But the one you had here was certainly not simple. If you simplify the logic then you don't need one probably > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958069#comment-15958069 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1172 @mtaylor @clebertsuconic guys thanks for the comments/suggestions. I'll try to simplify if it is possible. I think I'd better send out a discussion giving the details of how it is implemented before I change any code. Sorry for not having done it first, I've had too much assumptions. :) > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957065#comment-15957065 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1172 @gaohoward another reason to simplify the patch then. Make it simple please! > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957037#comment-15957037 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1172 @mtaylor ok. BTW I didn't change the send part at all. My thought is that sending is always targeted to an address, not a queue, so it doesn't make sense to reference an address by FQQN. > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956992#comment-15956992 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1172 @gaohoward Could you split this into two patches. The consume should be pretty easy. If the subscribe packet contains a FQQN then parse the address, then lookup the queue. The send is harder but we can resolve that later. Cheers > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956943#comment-15956943 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1172 @mtaylor is it possible to use the existing SimpleAddressManager or WildcardAddressManager and just add a new binding for "address::foo" -> QueueBindingImpl(name="foo", address="address") ? Let me think about it... > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956939#comment-15956939 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1172 @clebertsuconic fyi https://github.com/apache/activemq-artemis/blob/master/docs/user-manual/en/address-model.md#fully-qualified-queue-names > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956940#comment-15956940 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1172 @gaohoward @clebertsuconic Just to clarify Clebert is referring to the implementation not the feature. The feature is required. @gaohoward is it possible to use the existing SimpleAddressManager or WildcardAddressManager and just add a new binding for "address::foo" -> QueueBindingImpl(name="foo", address="address") ? > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956935#comment-15956935 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1172 @clebertsuconic This is already in user's manual, I thought it just missed the implementation. But anyway I couldn't send out a discussion. > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956889#comment-15956889 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1172 @gaohoward for something like this you should have talked to us through a DISCUSS thread, or talked about some design first... There's WildcardConfiguration already... this is a big change, and I don't like it much.. it adds a complext piece of a referenceCounting on this Key, plus some concatenations to lookup for Addresses... I'm really concerned about letting this change go in... Can't we have a simpler change.. perhaps use the WildcardAddressManager in any way? what it is needed that is not covered by that already? > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956811#comment-15956811 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1172 Yes OpenWire still referring to the queue name, in JMS terms. Not sure what you meant by "ANYCAST address name". My understanding is that when you send messages you send to an address of anycast and/or multicast route type, is that correct? > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956746#comment-15956746 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user mtaylor commented on the issue: https://github.com/apache/activemq-artemis/pull/1172 @gaohoward Howard, I am a bit confused by your commit message. Since the new addressing change, clients should now refer to an ANYCAST address name, not the queue name. Do this commit change the behaviour here or was OpenWire still referring to the queue name? > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956252#comment-15956252 ] ASF GitHub Bot commented on ARTEMIS-1093: - Github user gaohoward commented on the issue: https://github.com/apache/activemq-artemis/pull/1172 @mtaylor Martyn can you review this? Thanks > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ARTEMIS-1093) Full qualified queue name support
[ https://issues.apache.org/jira/browse/ARTEMIS-1093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956250#comment-15956250 ] ASF GitHub Bot commented on ARTEMIS-1093: - GitHub user gaohoward opened a pull request: https://github.com/apache/activemq-artemis/pull/1172 ARTEMIS-1093 Full qualified queue name support Broker should support full qualified queue names (FQQN) as well as bare queue names. This means when clients access to a queue they have two equivalent ways to do so. One way is by queue names and the other is by FQQN (i.e. address::qname) names. When accessing a queue by its bare name, it is required that the name should be unique across all addresses. Otherwise a warning is given and client should use FQQN instead. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gaohoward/activemq-artemis master_fqn Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1172.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1172 commit 9085d5a6b6ae0220e09972f3a3cff3aea06e510c Author: Howard Gao Date: 2017-04-05T03:21:16Z ARTEMIS-1093 Full qualified queue name support Broker should support full qualified queue names (FQQN) as well as bare queue names. This means when clients access to a queue they have two equivalent ways to do so. One way is by queue names and the other is by FQQN (i.e. address::qname) names. When accessing a queue by its bare name, it is required that the name should be unique across all addresses. Otherwise a warning is given and client should use FQQN instead. > Full qualified queue name support > - > > Key: ARTEMIS-1093 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1093 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.0.0 >Reporter: Howard Gao >Assignee: Howard Gao > Fix For: 2.next > > > Broker should support full qualified queue names (FQQN) as well as bare queue > names. This means when clients access to a queue they have two equivalent > ways to do so. One way is by queue names and the other is by FQQN (i.e. > address::qname) names. When accessing a queue by its bare name, it is > required that the name should be unique across all addresses. > Otherwise a warning is given and client should use FQQN instead. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
