[jira] [Commented] (ARTEMIS-1207) [Core JMS Client] Align order of when setClientId can be called with AcitveMQ5 and QPID

[Michael Andre Pearce (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16052764#comment-16052764
 ] 

Michael Andre Pearce commented on ARTEMIS-1207:
---

yup, jira updated.

> [Core JMS Client] Align order of when setClientId can be called with 
> AcitveMQ5 and QPID
> ---
>
> Key: ARTEMIS-1207
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1207
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>Assignee: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> There is a difference in behaviour of when it is valid to be able to set 
> clientId though it seems the behaviour isn't clear in JMS spec, where QPID 
> and ActiveMQ5 allow you to set an exception listener first, where as 
> currently Artemis requires the very first call to setClientId if you wish to 
> set it. 
> As discussed will create and align the clients so even so not detailed in 
> spec, a user of ActiveMQ5 client or QPID client can expect the same behaviour.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1207) [Core JMS Client] Align order of when setClientId can be called with AcitveMQ5 and QPID

[Timothy Bish (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16052289#comment-16052289
 ] 

Timothy Bish commented on ARTEMIS-1207:
---

Is this complete now?  Changes seems to cover the cases called out.  If so can 
you close it as resolved now?

> [Core JMS Client] Align order of when setClientId can be called with 
> AcitveMQ5 and QPID
> ---
>
> Key: ARTEMIS-1207
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1207
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> There is a difference in behaviour of when it is valid to be able to set 
> clientId though it seems the behaviour isn't clear in JMS spec, where QPID 
> and ActiveMQ5 allow you to set an exception listener first, where as 
> currently Artemis requires the very first call to setClientId if you wish to 
> set it. 
> As discussed will create and align the clients so even so not detailed in 
> spec, a user of ActiveMQ5 client or QPID client can expect the same behaviour.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1207) [Core JMS Client] Align order of when setClientId can be called with AcitveMQ5 and QPID

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041260#comment-16041260
 ] 

ASF GitHub Bot commented on ARTEMIS-1207:
-

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1323
  
@clebertsuconic no worries at all


> [Core JMS Client] Align order of when setClientId can be called with 
> AcitveMQ5 and QPID
> ---
>
> Key: ARTEMIS-1207
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1207
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> There is a difference in behaviour of when it is valid to be able to set 
> clientId though it seems the behaviour isn't clear in JMS spec, where QPID 
> and ActiveMQ5 allow you to set an exception listener first, where as 
> currently Artemis requires the very first call to setClientId if you wish to 
> set it. 
> As discussed will create and align the clients so even so not detailed in 
> spec, a user of ActiveMQ5 client or QPID client can expect the same behaviour.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1207) [Core JMS Client] Align order of when setClientId can be called with AcitveMQ5 and QPID

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040954#comment-16040954
 ] 

ASF GitHub Bot commented on ARTEMIS-1207:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1323
  
@michaelandrepearce I have amended the description of the commit with a 
checkout and merged that branch...

just wanted to keep the descriptions shorter.


> [Core JMS Client] Align order of when setClientId can be called with 
> AcitveMQ5 and QPID
> ---
>
> Key: ARTEMIS-1207
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1207
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> There is a difference in behaviour of when it is valid to be able to set 
> clientId though it seems the behaviour isn't clear in JMS spec, where QPID 
> and ActiveMQ5 allow you to set an exception listener first, where as 
> currently Artemis requires the very first call to setClientId if you wish to 
> set it. 
> As discussed will create and align the clients so even so not detailed in 
> spec, a user of ActiveMQ5 client or QPID client can expect the same behaviour.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1207) [Core JMS Client] Align order of when setClientId can be called with AcitveMQ5 and QPID

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040953#comment-16040953
 ] 

ASF GitHub Bot commented on ARTEMIS-1207:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1323


> [Core JMS Client] Align order of when setClientId can be called with 
> AcitveMQ5 and QPID
> ---
>
> Key: ARTEMIS-1207
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1207
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> There is a difference in behaviour of when it is valid to be able to set 
> clientId though it seems the behaviour isn't clear in JMS spec, where QPID 
> and ActiveMQ5 allow you to set an exception listener first, where as 
> currently Artemis requires the very first call to setClientId if you wish to 
> set it. 
> As discussed will create and align the clients so even so not detailed in 
> spec, a user of ActiveMQ5 client or QPID client can expect the same behaviour.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1207) [Core JMS Client] Align order of when setClientId can be called with AcitveMQ5 and QPID

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040951#comment-16040951
 ] 

ASF subversion and git services commented on ARTEMIS-1207:
--

Commit e8fa02bf80118738c52489c4bf2511aa0d1ef5b8 in activemq-artemis's branch 
refs/heads/master from [~michael.andre.pearce]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=e8fa02b ]

ARTEMIS-1207: Align when setClientId can be called

Update ActiveMQConnection to change/alighn behaviour for addtional methods:
- getMetaData
- stop

Adding test to avoid regression.

This is aligning with qpid-jms and openwire clients


> [Core JMS Client] Align order of when setClientId can be called with 
> AcitveMQ5 and QPID
> ---
>
> Key: ARTEMIS-1207
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1207
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> There is a difference in behaviour of when it is valid to be able to set 
> clientId though it seems the behaviour isn't clear in JMS spec, where QPID 
> and ActiveMQ5 allow you to set an exception listener first, where as 
> currently Artemis requires the very first call to setClientId if you wish to 
> set it. 
> As discussed will create and align the clients so even so not detailed in 
> spec, a user of ActiveMQ5 client or QPID client can expect the same behaviour.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1207) [Core JMS Client] Align order of when setClientId can be called with AcitveMQ5 and QPID

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039811#comment-16039811
 ] 

ASF GitHub Bot commented on ARTEMIS-1207:
-

GitHub user michaelandrepearce opened a pull request:

https://github.com/apache/activemq-artemis/pull/1323

ARTEMIS-1207: Align order of when setClientId can be called with AcitveMQ5 
and QPID

Update ActiveMQConnection to change/alighn behaviour for addtional methods/
getMetaData
stop

Add test to avoid regression.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/michaelandrepearce/activemq-artemis 
ARTEMIS-1207

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1323.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1323


commit 5c1ceed8bdbfc38fe0269b2a3e1480cbb68fe698
Author: Michael Andre Pearce 
Date:   2017-06-06T15:09:58Z

ARTEMIS-1207: [Core JMS Client] Align order of when setClientId can be 
called with AcitveMQ5 and QPID

Update ActiveMQConnection to change/alighn behaviour for addtional methods/
getMetaData
stop

Add test to avoid regression.




> [Core JMS Client] Align order of when setClientId can be called with 
> AcitveMQ5 and QPID
> ---
>
> Key: ARTEMIS-1207
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1207
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> There is a difference in behaviour of when it is valid to be able to set 
> clientId though it seems the behaviour isn't clear in JMS spec, where QPID 
> and ActiveMQ5 allow you to set an exception listener first, where as 
> currently Artemis requires the very first call to setClientId if you wish to 
> set it. 
> As discussed will create and align the clients so even so not detailed in 
> spec, a user of ActiveMQ5 client or QPID client can expect the same behaviour.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1207) [Core JMS Client] Align order of when setClientId can be called with AcitveMQ5 and QPID

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039809#comment-16039809
 ] 

ASF GitHub Bot commented on ARTEMIS-1207:
-

Github user michaelandrepearce closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1322


> [Core JMS Client] Align order of when setClientId can be called with 
> AcitveMQ5 and QPID
> ---
>
> Key: ARTEMIS-1207
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1207
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> There is a difference in behaviour of when it is valid to be able to set 
> clientId though it seems the behaviour isn't clear in JMS spec, where QPID 
> and ActiveMQ5 allow you to set an exception listener first, where as 
> currently Artemis requires the very first call to setClientId if you wish to 
> set it. 
> As discussed will create and align the clients so even so not detailed in 
> spec, a user of ActiveMQ5 client or QPID client can expect the same behaviour.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1207) [Core JMS Client] Align order of when setClientId can be called with AcitveMQ5 and QPID

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039808#comment-16039808
 ] 

ASF GitHub Bot commented on ARTEMIS-1207:
-

GitHub user michaelandrepearce opened a pull request:

https://github.com/apache/activemq-artemis/pull/1322

ARTEMIS-1207: Align order of when setClientId can be called with AcitveMQ5 
and QPID

Update ActiveMQConnection to change behaviour, getMetaData and stop methods.

Add test to avoid regression.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/michaelandrepearce/activemq-artemis 
ARTEMIS-1207

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1322.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1322


commit a8fc2160d41243807cd834854137477849e481a6
Author: Michael Andre Pearce 
Date:   2017-06-06T08:54:02Z

ARTEMIS-1207: [Core JMS Client] Align order of when setClientId can be 
called with AcitveMQ5 and QPID

Update ActiveMQConnection to change behaviour

Add test to avoid regression.




> [Core JMS Client] Align order of when setClientId can be called with 
> AcitveMQ5 and QPID
> ---
>
> Key: ARTEMIS-1207
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1207
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> There is a difference in behaviour of when it is valid to be able to set 
> clientId though it seems the behaviour isn't clear in JMS spec, where QPID 
> and ActiveMQ5 allow you to set an exception listener first, where as 
> currently Artemis requires the very first call to setClientId if you wish to 
> set it. 
> As discussed will create and align the clients so even so not detailed in 
> spec, a user of ActiveMQ5 client or QPID client can expect the same behaviour.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1207) [Core JMS Client] Align order of when setClientId can be called with AcitveMQ5 and QPID

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039056#comment-16039056
 ] 

ASF GitHub Bot commented on ARTEMIS-1207:
-

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1317
  
Will work on this tonight / train home, hopefully.


> [Core JMS Client] Align order of when setClientId can be called with 
> AcitveMQ5 and QPID
> ---
>
> Key: ARTEMIS-1207
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1207
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> There is a difference in behaviour of when it is valid to be able to set 
> clientId though it seems the behaviour isn't clear in JMS spec, where QPID 
> and ActiveMQ5 allow you to set an exception listener first, where as 
> currently Artemis requires the very first call to setClientId if you wish to 
> set it. 
> As discussed will create and align the clients so even so not detailed in 
> spec, a user of ActiveMQ5 client or QPID client can expect the same behaviour.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1207) [Core JMS Client] Align order of when setClientId can be called with AcitveMQ5 and QPID

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039033#comment-16039033
 ] 

ASF GitHub Bot commented on ARTEMIS-1207:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1317


> [Core JMS Client] Align order of when setClientId can be called with 
> AcitveMQ5 and QPID
> ---
>
> Key: ARTEMIS-1207
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1207
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> There is a difference in behaviour of when it is valid to be able to set 
> clientId though it seems the behaviour isn't clear in JMS spec, where QPID 
> and ActiveMQ5 allow you to set an exception listener first, where as 
> currently Artemis requires the very first call to setClientId if you wish to 
> set it. 
> As discussed will create and align the clients so even so not detailed in 
> spec, a user of ActiveMQ5 client or QPID client can expect the same behaviour.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1207) [Core JMS Client] Align order of when setClientId can be called with AcitveMQ5 and QPID

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039030#comment-16039030
 ] 

ASF subversion and git services commented on ARTEMIS-1207:
--

Commit 754e9db5fdee3807758a4c2da14bc61e715d616f in activemq-artemis's branch 
refs/heads/master from [~michael.andre.pearce]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=754e9db ]

ARTEMIS-1207: [Core JMS Client] Align order of when setClientId can be called 
with AcitveMQ5 and QPID

Update ActiveMQConnection to change behaviour

Add test to avoid regression.

> [Core JMS Client] Align order of when setClientId can be called with 
> AcitveMQ5 and QPID
> ---
>
> Key: ARTEMIS-1207
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1207
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> There is a difference in behaviour of when it is valid to be able to set 
> clientId though it seems the behaviour isn't clear in JMS spec, where QPID 
> and ActiveMQ5 allow you to set an exception listener first, where as 
> currently Artemis requires the very first call to setClientId if you wish to 
> set it. 
> As discussed will create and align the clients so even so not detailed in 
> spec, a user of ActiveMQ5 client or QPID client can expect the same behaviour.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1207) [Core JMS Client] Align order of when setClientId can be called with AcitveMQ5 and QPID

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039022#comment-16039022
 ] 

ASF GitHub Bot commented on ARTEMIS-1207:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1317
  
@michaelandrepearce I'm ok with that.. keep the JIRA open


> [Core JMS Client] Align order of when setClientId can be called with 
> AcitveMQ5 and QPID
> ---
>
> Key: ARTEMIS-1207
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1207
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> There is a difference in behaviour of when it is valid to be able to set 
> clientId though it seems the behaviour isn't clear in JMS spec, where QPID 
> and ActiveMQ5 allow you to set an exception listener first, where as 
> currently Artemis requires the very first call to setClientId if you wish to 
> set it. 
> As discussed will create and align the clients so even so not detailed in 
> spec, a user of ActiveMQ5 client or QPID client can expect the same behaviour.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1207) [Core JMS Client] Align order of when setClientId can be called with AcitveMQ5 and QPID

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039021#comment-16039021
 ] 

ASF GitHub Bot commented on ARTEMIS-1207:
-

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1317
  
@jbertram i only just see the update in the JIRA ticket, sure we can add 
these also. I can work on aligning those also. You ok to merge this one, whilst 
i work on those also? We close JIRA only once all done?


> [Core JMS Client] Align order of when setClientId can be called with 
> AcitveMQ5 and QPID
> ---
>
> Key: ARTEMIS-1207
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1207
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> There is a difference in behaviour of when it is valid to be able to set 
> clientId though it seems the behaviour isn't clear in JMS spec, where QPID 
> and ActiveMQ5 allow you to set an exception listener first, where as 
> currently Artemis requires the very first call to setClientId if you wish to 
> set it. 
> As discussed will create and align the clients so even so not detailed in 
> spec, a user of ActiveMQ5 client or QPID client can expect the same behaviour.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1207) [Core JMS Client] Align order of when setClientId can be called with AcitveMQ5 and QPID

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039012#comment-16039012
 ] 

ASF GitHub Bot commented on ARTEMIS-1207:
-

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1317
  
What about the other methods mentioned in the JIRA (i.e. getMetaData and 
stop)?


> [Core JMS Client] Align order of when setClientId can be called with 
> AcitveMQ5 and QPID
> ---
>
> Key: ARTEMIS-1207
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1207
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> There is a difference in behaviour of when it is valid to be able to set 
> clientId though it seems the behaviour isn't clear in JMS spec, where QPID 
> and ActiveMQ5 allow you to set an exception listener first, where as 
> currently Artemis requires the very first call to setClientId if you wish to 
> set it. 
> As discussed will create and align the clients so even so not detailed in 
> spec, a user of ActiveMQ5 client or QPID client can expect the same behaviour.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1207) [Core JMS Client] Align order of when setClientId can be called with AcitveMQ5 and QPID

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038995#comment-16038995
 ] 

ASF GitHub Bot commented on ARTEMIS-1207:
-

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1317#discussion_r120379443
  
--- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/connection/ExceptionListenerTest.java
 ---
@@ -143,4 +143,22 @@ public void 
testListenerCalledForOneConnectionAndSessions() throws Exception {
   conn.close();
}
 
+
+   /**
+* The JMS Spec isn't specific about if ClientId can be set after 
Exception Listener or not,
+* simply it states that clientId must be set before any operation 
(read as remote)
+*
+* QpidJMS and ActiveMQ5 both interpret that therefor you can set the 
exception lister first.
+* As such we align with those, allowing the exception listener to be 
set prior to the clientId,
+* This to avoid causing implementation nuance's, when switching code 
from one client to another.
+*
+* This test is to test this and to ensure it doesn't get accidentally 
regressed.
+*/
+   @Test
+   public void testSetClientIdAfterSetExceptionListener() throws Exception 
{
+  Connection conn = cf.createConnection();
--- End diff --

the issue was if you setExceptionListener before clientId, it would 
fail/throw exceptions on setting clientId. Now it is possible to set it before 
setting the clientId, this test is testing this behaviour. (e.g. if you revert 
the change in the ActiveMQConnection , this test fails)


> [Core JMS Client] Align order of when setClientId can be called with 
> AcitveMQ5 and QPID
> ---
>
> Key: ARTEMIS-1207
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1207
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> There is a difference in behaviour of when it is valid to be able to set 
> clientId though it seems the behaviour isn't clear in JMS spec, where QPID 
> and ActiveMQ5 allow you to set an exception listener first, where as 
> currently Artemis requires the very first call to setClientId if you wish to 
> set it. 
> As discussed will create and align the clients so even so not detailed in 
> spec, a user of ActiveMQ5 client or QPID client can expect the same behaviour.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1207) [Core JMS Client] Align order of when setClientId can be called with AcitveMQ5 and QPID

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038989#comment-16038989
 ] 

ASF GitHub Bot commented on ARTEMIS-1207:
-

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1317#discussion_r120378248
  
--- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/connection/ExceptionListenerTest.java
 ---
@@ -143,4 +143,22 @@ public void 
testListenerCalledForOneConnectionAndSessions() throws Exception {
   conn.close();
}
 
+
+   /**
+* The JMS Spec isn't specific about if ClientId can be set after 
Exception Listener or not,
+* simply it states that clientId must be set before any operation 
(read as remote)
+*
+* QpidJMS and ActiveMQ5 both interpret that therefor you can set the 
exception lister first.
+* As such we align with those, allowing the exception listener to be 
set prior to the clientId,
+* This to avoid causing implementation nuance's, when switching code 
from one client to another.
+*
+* This test is to test this and to ensure it doesn't get accidentally 
regressed.
+*/
+   @Test
+   public void testSetClientIdAfterSetExceptionListener() throws Exception 
{
+  Connection conn = cf.createConnection();
--- End diff --

I thought, from what I read the code, the issue was calling 
setExceptionListener and clientID wouldn't fail.. I'm confused on what is the 
issue now..


> [Core JMS Client] Align order of when setClientId can be called with 
> AcitveMQ5 and QPID
> ---
>
> Key: ARTEMIS-1207
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1207
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> There is a difference in behaviour of when it is valid to be able to set 
> clientId though it seems the behaviour isn't clear in JMS spec, where QPID 
> and ActiveMQ5 allow you to set an exception listener first, where as 
> currently Artemis requires the very first call to setClientId if you wish to 
> set it. 
> As discussed will create and align the clients so even so not detailed in 
> spec, a user of ActiveMQ5 client or QPID client can expect the same behaviour.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1207) [Core JMS Client] Align order of when setClientId can be called with AcitveMQ5 and QPID

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038983#comment-16038983
 ] 

ASF GitHub Bot commented on ARTEMIS-1207:
-

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1317#discussion_r120377162
  
--- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/connection/ExceptionListenerTest.java
 ---
@@ -143,4 +143,22 @@ public void 
testListenerCalledForOneConnectionAndSessions() throws Exception {
   conn.close();
}
 
+
+   /**
+* The JMS Spec isn't specific about if ClientId can be set after 
Exception Listener or not,
+* simply it states that clientId must be set before any operation 
(read as remote)
+*
+* QpidJMS and ActiveMQ5 both interpret that therefor you can set the 
exception lister first.
+* As such we align with those, allowing the exception listener to be 
set prior to the clientId,
+* This to avoid causing implementation nuance's, when switching code 
from one client to another.
+*
+* This test is to test this and to ensure it doesn't get accidentally 
regressed.
+*/
+   @Test
+   public void testSetClientIdAfterSetExceptionListener() throws Exception 
{
+  Connection conn = cf.createConnection();
--- End diff --

 the issue was setExceptionListener that we were hitting, but you're 
correct getExceptionListener should be the same,  we should add that test, will 
add.


> [Core JMS Client] Align order of when setClientId can be called with 
> AcitveMQ5 and QPID
> ---
>
> Key: ARTEMIS-1207
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1207
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> There is a difference in behaviour of when it is valid to be able to set 
> clientId though it seems the behaviour isn't clear in JMS spec, where QPID 
> and ActiveMQ5 allow you to set an exception listener first, where as 
> currently Artemis requires the very first call to setClientId if you wish to 
> set it. 
> As discussed will create and align the clients so even so not detailed in 
> spec, a user of ActiveMQ5 client or QPID client can expect the same behaviour.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1207) [Core JMS Client] Align order of when setClientId can be called with AcitveMQ5 and QPID

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038968#comment-16038968
 ] 

ASF GitHub Bot commented on ARTEMIS-1207:
-

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1317#discussion_r120375080
  
--- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/connection/ExceptionListenerTest.java
 ---
@@ -143,4 +143,22 @@ public void 
testListenerCalledForOneConnectionAndSessions() throws Exception {
   conn.close();
}
 
+
+   /**
+* The JMS Spec isn't specific about if ClientId can be set after 
Exception Listener or not,
+* simply it states that clientId must be set before any operation 
(read as remote)
+*
+* QpidJMS and ActiveMQ5 both interpret that therefor you can set the 
exception lister first.
+* As such we align with those, allowing the exception listener to be 
set prior to the clientId,
+* This to avoid causing implementation nuance's, when switching code 
from one client to another.
+*
+* This test is to test this and to ensure it doesn't get accidentally 
regressed.
+*/
+   @Test
+   public void testSetClientIdAfterSetExceptionListener() throws Exception 
{
+  Connection conn = cf.createConnection();
--- End diff --

You are not using getExceptionListener here.. is the test really 
duplicating the issue?


> [Core JMS Client] Align order of when setClientId can be called with 
> AcitveMQ5 and QPID
> ---
>
> Key: ARTEMIS-1207
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1207
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> There is a difference in behaviour of when it is valid to be able to set 
> clientId though it seems the behaviour isn't clear in JMS spec, where QPID 
> and ActiveMQ5 allow you to set an exception listener first, where as 
> currently Artemis requires the very first call to setClientId if you wish to 
> set it. 
> As discussed will create and align the clients so even so not detailed in 
> spec, a user of ActiveMQ5 client or QPID client can expect the same behaviour.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1207) [Core JMS Client] Align order of when setClientId can be called with AcitveMQ5 and QPID

[clebert suconic (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038929#comment-16038929
 ] 

clebert suconic commented on ARTEMIS-1207:
--

We should at least merge that one.. it makes sense.. we can keep it open for 
other cases.

> [Core JMS Client] Align order of when setClientId can be called with 
> AcitveMQ5 and QPID
> ---
>
> Key: ARTEMIS-1207
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1207
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> There is a difference in behaviour of when it is valid to be able to set 
> clientId though it seems the behaviour isn't clear in JMS spec, where QPID 
> and ActiveMQ5 allow you to set an exception listener first, where as 
> currently Artemis requires the very first call to setClientId if you wish to 
> set it. 
> As discussed will create and align the clients so even so not detailed in 
> spec, a user of ActiveMQ5 client or QPID client can expect the same behaviour.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1207) [Core JMS Client] Align order of when setClientId can be called with AcitveMQ5 and QPID

[Justin Bertram (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038916#comment-16038916
 ] 

Justin Bertram commented on ARTEMIS-1207:
-

The point in my last comment is that we should align all methods, not just one.

> [Core JMS Client] Align order of when setClientId can be called with 
> AcitveMQ5 and QPID
> ---
>
> Key: ARTEMIS-1207
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1207
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> There is a difference in behaviour of when it is valid to be able to set 
> clientId though it seems the behaviour isn't clear in JMS spec, where QPID 
> and ActiveMQ5 allow you to set an exception listener first, where as 
> currently Artemis requires the very first call to setClientId if you wish to 
> set it. 
> As discussed will create and align the clients so even so not detailed in 
> spec, a user of ActiveMQ5 client or QPID client can expect the same behaviour.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1207) [Core JMS Client] Align order of when setClientId can be called with AcitveMQ5 and QPID

[Justin Bertram (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038857#comment-16038857
 ] 

Justin Bertram commented on ARTEMIS-1207:
-

As it stands currently these are the methods from each broker that cause the 
javax.jms.Connection implementation to become "dirty" such that the clientID 
can't be set...

Artemis:
* getExceptionListener
* setExceptionListener
* getMetaData
* start
* stop
* createSession

Qpid Java:
* createSession
* start

ActiveMQ 5.x:
* createSession
* start

> [Core JMS Client] Align order of when setClientId can be called with 
> AcitveMQ5 and QPID
> ---
>
> Key: ARTEMIS-1207
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1207
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> There is a difference in behaviour of when it is valid to be able to set 
> clientId though it seems the behaviour isn't clear in JMS spec, where QPID 
> and ActiveMQ5 allow you to set an exception listener first, where as 
> currently Artemis requires the very first call to setClientId if you wish to 
> set it. 
> As discussed will create and align the clients so even so not detailed in 
> spec, a user of ActiveMQ5 client or QPID client can expect the same behaviour.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1207) [Core JMS Client] Align order of when setClientId can be called with AcitveMQ5 and QPID

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038411#comment-16038411
 ] 

ASF GitHub Bot commented on ARTEMIS-1207:
-

GitHub user michaelandrepearce opened a pull request:

https://github.com/apache/activemq-artemis/pull/1317

ARTEMIS-1207: Align order of when setClientId can be called with AcitveMQ5 
and QPID

Update ActiveMQConnection to change behaviour
Add test to avoid regression.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/michaelandrepearce/activemq-artemis 
ARTEMIS-1207

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1317.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1317


commit 1f09a8e3046ed2769a9a80e7851e2e9ab56041a9
Author: Michael Andre Pearce 
Date:   2017-06-06T08:54:02Z

ARTEMIS-1207: [Core JMS Client] Align order of when setClientId can be 
called with AcitveMQ5 and QPID

Update ActiveMQConnection to change behaviour
Add test to avoid regression.




> [Core JMS Client] Align order of when setClientId can be called with 
> AcitveMQ5 and QPID
> ---
>
> Key: ARTEMIS-1207
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1207
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> There is a difference in behaviour of when it is valid to be able to set 
> clientId though it seems the behaviour isn't clear in JMS spec, where QPID 
> and ActiveMQ5 allow you to set an exception listener first, where as 
> currently Artemis requires the very first call to setClientId if you wish to 
> set it. 
> As discussed will create and align the clients so even so not detailed in 
> spec, a user of ActiveMQ5 client or QPID client can expect the same behaviour.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)