[jira] [Commented] (ARTEMIS-1246) AMQ119019: Queue already exists

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16066095#comment-16066095
 ] 

ASF GitHub Bot commented on ARTEMIS-1246:
-

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1365
  
@clebertsuconic 

> you would eventually see this issue when using older clients:
>
> AMQ119019: Queue already exists

I hope it doesn't happen anymore after this fix!
To reproduce it and to have proper tests on it I see 2 solutions:

1. having unit tests on protocol handling that emulate old clients message 
flow
2. having a new "compatibility-tests" folder with tests that verify JMS 
behaviours with different old clients

But neither seems a simple and effetive solution to be done now; did you 
see other ways to test it? 



> AMQ119019: Queue already exists
> ---
>
> Key: ARTEMIS-1246
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1246
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>Priority: Blocker
>
> Using old versions (<1.5.4) of the JMS Client (with CORE protocol), JMS temp 
> queues will rise javax.jms.InvalidDestinationException: AMQ119019: Queue 
> already exists.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1246) AMQ119019: Queue already exists

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065254#comment-16065254
 ] 

ASF subversion and git services commented on ARTEMIS-1246:
--

Commit a8356fb057eb45f3a560e3841ce3fec220155153 in activemq-artemis's branch 
refs/heads/master from [~nigro@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=a8356fb ]

ARTEMIS-1246 Fixing compatibility issue

It fixes compatibility issues with JMS Core clients using the old address 
model, allowing the client to query JMS temporary queues too.

you would eventually see this issue when using older clients:
AMQ119019: Queue already exists


> AMQ119019: Queue already exists
> ---
>
> Key: ARTEMIS-1246
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1246
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>Priority: Blocker
>
> Using old versions (<1.5.4) of the JMS Client (with CORE protocol), JMS temp 
> queues will rise javax.jms.InvalidDestinationException: AMQ119019: Queue 
> already exists.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1246) AMQ119019: Queue already exists

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065255#comment-16065255
 ] 

ASF GitHub Bot commented on ARTEMIS-1246:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1365


> AMQ119019: Queue already exists
> ---
>
> Key: ARTEMIS-1246
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1246
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>Priority: Blocker
>
> Using old versions (<1.5.4) of the JMS Client (with CORE protocol), JMS temp 
> queues will rise javax.jms.InvalidDestinationException: AMQ119019: Queue 
> already exists.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1246) AMQ119019: Queue already exists

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065133#comment-16065133
 ] 

ASF GitHub Bot commented on ARTEMIS-1246:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1365
  
I was going to merge by using checkout-PR and merge-branch scripts... (from 
./scripts).

with this commit meesage instead:
```
ARTEMIS-1246 Fixing compatibility issue 

It fixes compatibility issues with JMS Core clients using the old address 
model, allowing the client to query JMS temporary queues too.

you would eventually see this issue when using older clients:

AMQ119019: Queue already exists
```

Isn't there a way to replicate this failure though?


> AMQ119019: Queue already exists
> ---
>
> Key: ARTEMIS-1246
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1246
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>Priority: Blocker
>
> Using old versions (<1.5.4) of the JMS Client (with CORE protocol), JMS temp 
> queues will rise javax.jms.InvalidDestinationException: AMQ119019: Queue 
> already exists.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1246) AMQ119019: Queue already exists

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065120#comment-16065120
 ] 

ASF GitHub Bot commented on ARTEMIS-1246:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1365
  
your commit message here is: 'ARTEMIS-1246 AMQ119019: Queue already exists'

It should be fixing:

ARTEMIS-1246 compatibilty issue that will cause Queue already exists error




That commit message is an error message, which I would have to open the 
JIRA to have more information about it.. the logs should be self content about 
the change... opening the JIRA should be an add-on to the discussion... I use 
git logs doezens of times a day.. having to open JIRA for each one of the 
changes is not optimal.


> AMQ119019: Queue already exists
> ---
>
> Key: ARTEMIS-1246
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1246
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>Priority: Blocker
>
> Using old versions (<1.5.4) of the JMS Client (with CORE protocol), JMS temp 
> queues will rise javax.jms.InvalidDestinationException: AMQ119019: Queue 
> already exists.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1246) AMQ119019: Queue already exists

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16064418#comment-16064418
 ] 

ASF GitHub Bot commented on ARTEMIS-1246:
-

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1365
  
@clebertsuconic I've added an additional comment to the first line of the 
commit message (that is actually the same of the related JIRA) to make more 
clear what case it fixes :+1: 


> AMQ119019: Queue already exists
> ---
>
> Key: ARTEMIS-1246
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1246
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>Priority: Blocker
>
> Using old versions (<1.5.4) of the JMS Client (with CORE protocol), JMS temp 
> queues will rise javax.jms.InvalidDestinationException: AMQ119019: Queue 
> already exists.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1246) AMQ119019: Queue already exists

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063747#comment-16063747
 ] 

ASF GitHub Bot commented on ARTEMIS-1246:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1365
  
The commit message you used on git doesn't actually saw what was the 
change..

what was broken? Can you amend the commit message with something more 
meaninful?

I don't want to have to open the JIRA link to know what was changed.


> AMQ119019: Queue already exists
> ---
>
> Key: ARTEMIS-1246
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1246
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>Priority: Blocker
>
> Using old versions (<1.5.4) of the JMS Client (with CORE protocol), JMS temp 
> queues will rise javax.jms.InvalidDestinationException: AMQ119019: Queue 
> already exists.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1246) AMQ119019: Queue already exists

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16063265#comment-16063265
 ] 

ASF GitHub Bot commented on ARTEMIS-1246:
-

GitHub user franz1981 opened a pull request:

https://github.com/apache/activemq-artemis/pull/1365

ARTEMIS-1246 AMQ119019: Queue already exists



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/franz1981/activemq-artemis 
old_client_jms_temp_fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1365.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1365


commit 6b26d7b9f6bd9c67878084489b76d439cb32b7b4
Author: Francesco Nigro 
Date:   2017-06-21T12:42:34Z

ARTEMIS-1246 AMQ119019: Queue already exists




> AMQ119019: Queue already exists
> ---
>
> Key: ARTEMIS-1246
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1246
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>Priority: Blocker
>
> Using old versions (<1.5.4) of the JMS Client (with CORE protocol), JMS temp 
> queues will rise javax.jms.InvalidDestinationException: AMQ119019: Queue 
> already exists.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)