[jira] [Commented] (ARTEMIS-1318) Uses unbuffered MAPPED Journal if no data-sync is required
[ https://issues.apache.org/jira/browse/ARTEMIS-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16197468#comment-16197468 ] ASF GitHub Bot commented on ARTEMIS-1318: - Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1436 > Uses unbuffered MAPPED Journal if no data-sync is required > -- > > Key: ARTEMIS-1318 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1318 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Francesco Nigro >Assignee: Francesco Nigro > > Disable the TimedBuffer on MAPPED journal if no data-sync in required: > * reduced footprint (no TimedBuffer) > * reduced CPU usage (less buffer copy and no TimedBuffer background timer > thread) > * reduced latencies (not timeout can influence when the write will happen) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1318) Uses unbuffered MAPPED Journal if no data-sync is required
[ https://issues.apache.org/jira/browse/ARTEMIS-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16112683#comment-16112683 ] ASF GitHub Bot commented on ARTEMIS-1318: - Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1436 @clebertsuconic Yes I need to run the whole test suite, add some others tests to see if it is working as expected plus provides the NIO version too. What I'm not understanding is what is happening here: https://github.com/franz1981/activemq-artemis/blob/31d5758885214ff65aebfdeb6024f7b275397bff/artemis-journal/src/main/java/org/apache/activemq/artemis/core/journal/impl/JournalImpl.java#L2646-L2646 Seems the only visible difference when the TimedBuffer is not enable (on NIO too)... > Uses unbuffered MAPPED Journal if no data-sync is required > -- > > Key: ARTEMIS-1318 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1318 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Francesco Nigro >Assignee: Francesco Nigro > > Disable the TimedBuffer on MAPPED journal if no data-sync in required: > * reduced footprint (no TimedBuffer) > * reduced CPU usage (less buffer copy and no TimedBuffer background timer > thread) > * reduced latencies (not timeout can influence when the write will happen) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1318) Uses unbuffered MAPPED Journal if no data-sync is required
[ https://issues.apache.org/jira/browse/ARTEMIS-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1626#comment-1626 ] ASF GitHub Bot commented on ARTEMIS-1318: - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1436 @franz1981 I feel like you should do more tests before merging this Franz. > Uses unbuffered MAPPED Journal if no data-sync is required > -- > > Key: ARTEMIS-1318 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1318 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Francesco Nigro >Assignee: Francesco Nigro > > Disable the TimedBuffer on MAPPED journal if no data-sync in required: > * reduced footprint (no TimedBuffer) > * reduced CPU usage (less buffer copy and no TimedBuffer background timer > thread) > * reduced latencies (not timeout can influence when the write will happen) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1318) Uses unbuffered MAPPED Journal if no data-sync is required
[ https://issues.apache.org/jira/browse/ARTEMIS-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110931#comment-16110931 ] ASF GitHub Bot commented on ARTEMIS-1318: - Github user clebertsuconic commented on the issue: https://github.com/apache/activemq-artemis/pull/1436 @franz1981 what about replacing the TimedBuffer from another delegating buffer that would call the callbacks? Now, you have to make sure that callbacks from replication would still be used, as in this mode you would need it to work. > Uses unbuffered MAPPED Journal if no data-sync is required > -- > > Key: ARTEMIS-1318 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1318 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Francesco Nigro >Assignee: Francesco Nigro > > Disable the TimedBuffer on MAPPED journal if no data-sync in required: > * reduced footprint (no TimedBuffer) > * reduced CPU usage (less buffer copy and no TimedBuffer background timer > thread) > * reduced latencies (not timeout can influence when the write will happen) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1318) Uses unbuffered MAPPED Journal if no data-sync is required
[ https://issues.apache.org/jira/browse/ARTEMIS-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110632#comment-16110632 ] ASF GitHub Bot commented on ARTEMIS-1318: - Github user franz1981 commented on the issue: https://github.com/apache/activemq-artemis/pull/1436 @clebertsuconic I'm just concerned about the callbacks behaviour...do you have any advices? > Uses unbuffered MAPPED Journal if no data-sync is required > -- > > Key: ARTEMIS-1318 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1318 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Francesco Nigro >Assignee: Francesco Nigro > > Disable the TimedBuffer on MAPPED journal if no data-sync in required: > * reduced footprint (no TimedBuffer) > * reduced CPU usage (less buffer copy and no TimedBuffer background timer > thread) > * reduced latencies (not timeout can influence when the write will happen) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ARTEMIS-1318) Uses unbuffered MAPPED Journal if no data-sync is required
[ https://issues.apache.org/jira/browse/ARTEMIS-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110629#comment-16110629 ] ASF GitHub Bot commented on ARTEMIS-1318: - GitHub user franz1981 opened a pull request: https://github.com/apache/activemq-artemis/pull/1436 ARTEMIS-1318 Uses unbuffered MAPPED Journal if no data-sync is required In order to reduce memory footprint, CPU usage and reduce latencies it avoid to use the TimedBuffer on the MAPPED journal if no datasync is required. You can merge this pull request into a Git repository by running: $ git pull https://github.com/franz1981/activemq-artemis mapped_timed_buffer_fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1436.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1436 commit 77c2f61ffee363b437ad4e39d4b4ed74ebb3c651 Author: Francesco Nigro Date: 2017-07-27T08:47:08Z ARTEMIS-1318 Uses unbuffered MAPPED Journal if no data-sync is required > Uses unbuffered MAPPED Journal if no data-sync is required > -- > > Key: ARTEMIS-1318 > URL: https://issues.apache.org/jira/browse/ARTEMIS-1318 > Project: ActiveMQ Artemis > Issue Type: Improvement >Reporter: Francesco Nigro >Assignee: Francesco Nigro > > Disable the TimedBuffer on MAPPED journal if no data-sync in required: > * reduced footprint (no TimedBuffer) > * reduced CPU usage (less buffer copy and no TimedBuffer background timer > thread) > * reduced latencies (not timeout can influence when the write will happen) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
