[jira] [Commented] (ARTEMIS-1407) FindBugs: Suspicious calls to generic collection methods in AMQPConnectionCallback.java

2017-09-12 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163397#comment-16163397
 ] 

ASF subversion and git services commented on ARTEMIS-1407:
--

Commit 412b63a6b5c5be097379f09c249f9c3bfb89e4ea in activemq-artemis's branch 
refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=412b63a ]

ARTEMIS-1407 Remove unused method that performs invalid operation

Remove the unused transaction remove method as the getTransaction method
provides the remove operation and the remove method was doing an invalud
remove of wrong type from the transactions collection. 

> FindBugs: Suspicious calls to generic collection methods in 
> AMQPConnectionCallback.java
> ---
>
> Key: ARTEMIS-1407
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1407
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP, Broker
>Affects Versions: 2.4.0
>Reporter: Jiri Danek
>
> {noformat}
> 249   public Transaction removeTransaction(Binary txid) {
> 250  XidImpl xid = newXID(txid.getArray());
>   
> CID 1420682 (#1 of 1): GC: Suspicious calls to generic collection methods 
> (FB.GC_UNRELATED_TYPES)
> 1. defect: org.apache.activemq.artemis.core.transaction.impl.XidImpl is 
> incompatible with expected argument type org.apache.qpid.proton.amqp.Binary.
> 251  return transactions.remove(xid);
> 252   }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1407) FindBugs: Suspicious calls to generic collection methods in AMQPConnectionCallback.java

2017-09-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162016#comment-16162016
 ] 

ASF GitHub Bot commented on ARTEMIS-1407:
-

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1528
  
+1 checked code for usages and confirm this is unused.


> FindBugs: Suspicious calls to generic collection methods in 
> AMQPConnectionCallback.java
> ---
>
> Key: ARTEMIS-1407
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1407
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP, Broker
>Affects Versions: 2.4.0
>Reporter: Jiri Danek
>
> {noformat}
> 249   public Transaction removeTransaction(Binary txid) {
> 250  XidImpl xid = newXID(txid.getArray());
>   
> CID 1420682 (#1 of 1): GC: Suspicious calls to generic collection methods 
> (FB.GC_UNRELATED_TYPES)
> 1. defect: org.apache.activemq.artemis.core.transaction.impl.XidImpl is 
> incompatible with expected argument type org.apache.qpid.proton.amqp.Binary.
> 251  return transactions.remove(xid);
> 252   }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ARTEMIS-1407) FindBugs: Suspicious calls to generic collection methods in AMQPConnectionCallback.java

2017-09-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16161799#comment-16161799
 ] 

ASF GitHub Bot commented on ARTEMIS-1407:
-

GitHub user tabish121 opened a pull request:

https://github.com/apache/activemq-artemis/pull/1528

ARTEMIS-1407 Remove unused method that performs invalid operation

Remove the unused transaction remove method as the getTransaction method
provides the remove operation and the remove method was doing an invalud
remove of wrong type from the transactions collection.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-1407

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1528.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1528


commit 315755031ce29647548c8b5d09806ece0f61c154
Author: Timothy Bish 
Date:   2017-09-11T19:01:18Z

ARTEMIS-1407 Remove unused method that performs invalid operation

Remove the unused transaction remove method as the getTransaction method
provides the remove operation and the remove method was doing an invalud
remove of wrong type from the transactions collection.




> FindBugs: Suspicious calls to generic collection methods in 
> AMQPConnectionCallback.java
> ---
>
> Key: ARTEMIS-1407
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1407
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: AMQP, Broker
>Affects Versions: 2.4.0
>Reporter: Jiri Danek
>
> {noformat}
> 249   public Transaction removeTransaction(Binary txid) {
> 250  XidImpl xid = newXID(txid.getArray());
>   
> CID 1420682 (#1 of 1): GC: Suspicious calls to generic collection methods 
> (FB.GC_UNRELATED_TYPES)
> 1. defect: org.apache.activemq.artemis.core.transaction.impl.XidImpl is 
> incompatible with expected argument type org.apache.qpid.proton.amqp.Binary.
> 251  return transactions.remove(xid);
> 252   }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)